Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Vincent Lefevre
On 2019-01-24 17:50:39 +, avih wrote: > While `git blame -w` does skip white spaces changes, not all > tools/editors use it. In this case, the user could use an alias "blame = blame -w" in his git configuration. > In general, I think it's better to not do style-only changes except > in

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread avih
While `git blame -w` does skip white spaces changes, not all tools/editors use it. In general, I think it's better to not do style-only changes except in lines/functions which are touched for "proper" reasons. - avih On Thursday, January 24, 2019 7:20 PM, Christian Jullien wrote: I

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Michael Matz
Hi, On Thu, 24 Jan 2019, Christian Jullien wrote: > I understand it's a go? >From my perspective, yup :) Ciao, Michael. > > -Original Message- > From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org] > On Behalf Of Michael Matz > Sent: jeudi 24 janvier 2019

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Michael Matz
Hi, On Thu, 24 Jan 2019, Christian Jullien wrote: > Hum! Unrelated question, I'm a big fan of Doxyen which I use on all > projects I own, I'm asking if we want start to move to Doxygen for > public API. I can make project infrastructure (but of course not > associated Doxygen tags). I

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Christian Jullien
I understand it's a go? -Original Message- From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange...@nongnu.org] On Behalf Of Michael Matz Sent: jeudi 24 janvier 2019 18:10 To: tinycc-devel@nongnu.org Subject: Re: [Tinycc-devel] tcc coding style question Hi, On Thu, 24 Jan 2019,

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Christian Jullien
For sure, that's why I asked maintainers before doing those gratuitous changes. I don't want to be the person to be blamed :o)) I'll do nothing then. Hum! Unrelated question, I'm a big fan of Doxyen which I use on all projects I own, I'm asking if we want start to move to Doxygen for public API.

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Michael Matz
Hi, On Thu, 24 Jan 2019, Vincent Lefevre wrote: > On 2019-01-24 16:10:03 +, Michael Matz wrote: > > On Thu, 24 Jan 2019, Christian Jullien wrote: > > > > > Question (to maintainers): do you allow me to fix them all? > > > > Please don't. It makes git blame unnecessarily hard. > > Doesn't

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Vincent Lefevre
On 2019-01-24 16:10:03 +, Michael Matz wrote: > On Thu, 24 Jan 2019, Christian Jullien wrote: > > > Question (to maintainers): do you allow me to fix them all? > > Please don't. It makes git blame unnecessarily hard. Doesn't the -w option of "git blame" solve this issue. -- Vincent

Re: [Tinycc-devel] tcc coding style question

2019-01-24 Thread Michael Matz
Hi, On Thu, 24 Jan 2019, Christian Jullien wrote: > Question (to maintainers): do you allow me to fix them all? Please don't. It makes git blame unnecessarily hard. You can fix style issues when you change the code in question for other reasons. (I'm probably responsible for some of the