Re: [tipc-discussion] [PATCH] net/tipc: fix potential null pointer dereference in several tipc netlink compat functions

From: Baozeng Ding Date: Sun, 22 May 2016 00:22:48 +0800 > @@ -916,10 +970,16 @@ static int tipc_nl_compat_sk_dump(struct > tipc_nl_compat_msg *msg, > static int tipc_nl_compat_media_dump(struct tipc_nl_compat_msg *msg, > struct nlattr **attrs) > { > +int err; > s

Re: [tipc-discussion] [PATCH iproute2 v1 0/4] tipc: updates for neighbour monitor

On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote: > Hi, > > This commit series requires the following kernel patch set: > "[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor" Nice work Partha! I inlined some minor comments from a first look. Thanks Richard > > I have issues

Re: [tipc-discussion] [PATCH iproute2 v1 4/4] tipc: list monitor command

On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote: > In this commit, we fetch the monitor attributes > and present it in a user friendly manner. It would be nice with an snippet printout here. So we can see how it might look. > > Signed-off-by: Parthasarathy Bhuvaragan > > --- > include/linu

Re: [tipc-discussion] [PATCH iproute2 v1 3/4] tipc: get monitor command

On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote: > Signed-off-by: Parthasarathy Bhuvaragan > > --- > tipc/link.c | 105 > > 1 file changed, 98 insertions(+), 7 deletions(-) > > diff --git a/tipc/link.c b/tipc/link.c > index 2e67b

Re: [tipc-discussion] [PATCH iproute2 v1 2/4] tipc: add monitor set command

On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote: > Signed-off-by: Parthasarathy Bhuvaragan > > --- > include/linux/tipc_netlink.h | 33 > tipc/link.c | 74 > +++- > 2 files changed, 106 insertions(+), 1 deletion(-

Re: [tipc-discussion] [PATCH iproute2 v1 1/4] tipc: cleanup dead code

On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote: > Signed-off-by: Parthasarathy Bhuvaragan > > --- > tipc/bearer.c | 2 +- > tipc/link.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tipc/bearer.c b/tipc/bearer.c > index 30b54d9fe24e..3673f4f85f16 100644 > ---

[tipc-discussion] [PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor

Hi, The commits are based on the Jon Maloy's "[PATCH net-next v7 0/4] tipc: neighbor monitoring etc" The updates to iproute2 will be sent as a seperate series shortly. regards Partha Parthasarathy Bhuvaragan (5): tipc: introduce constants for tipc address validation tipc: make cluster size

[tipc-discussion] [PATCH iproute2 v1 2/4] tipc: add monitor set command

Signed-off-by: Parthasarathy Bhuvaragan --- include/linux/tipc_netlink.h | 33 tipc/link.c | 74 +++- 2 files changed, 106 insertions(+), 1 deletion(-) diff --git a/include/linux/tipc_netlink.h b/include/linux/tipc_net

[tipc-discussion] [PATCH iproute2 v1 3/4] tipc: get monitor command

Signed-off-by: Parthasarathy Bhuvaragan --- tipc/link.c | 105 1 file changed, 98 insertions(+), 7 deletions(-) diff --git a/tipc/link.c b/tipc/link.c index 2e67be1d0470..42c48d4beed1 100644 --- a/tipc/link.c +++ b/tipc/link.c @@ -497,

[tipc-discussion] [PATCH iproute2 v1 1/4] tipc: cleanup dead code

Signed-off-by: Parthasarathy Bhuvaragan --- tipc/bearer.c | 2 +- tipc/link.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tipc/bearer.c b/tipc/bearer.c index 30b54d9fe24e..3673f4f85f16 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -281,7 +281,7 @@ static int cmd_be

[tipc-discussion] [PATCH iproute2 v1 4/4] tipc: list monitor command

In this commit, we fetch the monitor attributes and present it in a user friendly manner. Signed-off-by: Parthasarathy Bhuvaragan --- include/linux/tipc_netlink.h | 8 +- tipc/link.c | 217 ++- tipc/node.c | 21 - t

[tipc-discussion] [PATCH iproute2 v1 0/4] tipc: updates for neighbour monitor

Hi, This commit series requires the following kernel patch set: "[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor" I have issues compiling the latest iproute2 package, so compiled myseries on commit c13b6b097ab3 "add coverity model file". regards Partha Parthasarathy Bhuvarag

[tipc-discussion] [PATCH net-next v1 3/5] tipc: get monitor threshold for the cluster

In this commit, we add support to fetch the configured cluster monitoring threshold. Signed-off-by: Parthasarathy Bhuvaragan --- include/uapi/linux/tipc_netlink.h | 1 + net/tipc/monitor.c| 7 ++ net/tipc/monitor.h| 2 ++ net/tipc/netlink.c|

[tipc-discussion] [PATCH net-next v1 4/5] tipc: add a function to get the bearer name

Introduce a new function to get the bearer name from its id. This is used in subsequent commit. Signed-off-by: Parthasarathy Bhuvaragan --- net/tipc/bearer.c | 21 + net/tipc/bearer.h | 1 + 2 files changed, 22 insertions(+) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.

[tipc-discussion] [PATCH net-next v1 1/5] tipc: introduce constants for tipc address validation

In this commit, we introduce defines for tipc address size, offset and mask specification for Zone.Cluster.Node. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan --- include/uapi/linux/tipc.h | 30 ++ net/tipc/addr.h | 5

[tipc-discussion] [PATCH net-next v1 2/5] tipc: make cluster size threshold for monitoring configurable

In this commit, we introduce support to configure the minimum threshold to activate the new link monitoring algorithm. Signed-off-by: Parthasarathy Bhuvaragan --- include/uapi/linux/tipc_netlink.h | 11 +++ net/tipc/monitor.c| 12 net/tipc/monitor.h

[tipc-discussion] [PATCH net-next v1 5/5] tipc: dump monitor attributes

In this commit, we dump the monitor attributes when queried. The link monitor attributes are separated into two kinds: 1. general attributes per bearer 2. specific attributes per node/peer This style resembles the socket attributes and the nametable publications per socket. Signed-off-by: Parthasa