Re: [tipc-discussion] BC rcv link acked stuck after receiving a named with a BC ACK of 0

2016-08-24 Thread John THompson
Hi Jon, To clarify my previous email regarding the behaviour observed, What happens over time: + remove bc peer ... some time until peer rejoins ... + add bc peer + tipc_link_bc_ack_rcv link is up = false, node is up = false (this gets called a number of times until both the link and node are

Re: [tipc-discussion] BC rcv link acked stuck after receiving a named with a BC ACK of 0

2016-08-24 Thread John THompson
Hi Jon, It is a similar problem in terms of what happens to the bc link. I do have that patch applied. I have added debug through the remove bc peer and various other functions and the setting of the acked field to 0 is occurring when processing a packet from named (msg user 11) or BCAST protoco

Re: [tipc-discussion] [PATCH net-next v2 4/7] tipc: introduce UDP replicast

2016-08-24 Thread Erik Hugne
> >>> @@ -209,23 +218,79 @@ static int tipc_udp_send_msg(struct net *net, struct sk_buff *skb, > >>> if (skb_headroom(skb) < UDP_MIN_HEADROOM) { > >>> err = pskb_expand_head(skb, UDP_MIN_HEADROOM, 0, GFP_ATOMIC); > >>> if (err) > >>> - goto tx_error; >

Re: [tipc-discussion] [PATCH net-next 1/3] tipc: transfer broadcast nacks in link state messages

2016-08-24 Thread Xue, Ying
Hi Jon, Thank you for the clear explanation below, and now I am sure that the patch is no problem with me. Regards, Ying -Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: Tuesday, August 23, 2016 9:55 PM To: Xue, Ying; tipc-discussion@lists.sourceforge.net; Parth

Re: [tipc-discussion] [PATCH net-next v2 4/7] tipc: introduce UDP replicast

2016-08-24 Thread Jon Maloy
On 08/24/2016 06:57 AM, Richard Alpe wrote: > On 2016-08-24 12:08, Jon Maloy wrote: >> >> On 08/23/2016 10:41 AM, Richard Alpe wrote: >>> This patch introduces UDP replicast. A concept where we emulate >>> multicast by sending multiple unicast messages to configured peers. >>> >>> The purpose of

Re: [tipc-discussion] [PATCH net-next v2 4/7] tipc: introduce UDP replicast

2016-08-24 Thread Richard Alpe
On 2016-08-24 12:08, Jon Maloy wrote: > > > On 08/23/2016 10:41 AM, Richard Alpe wrote: >> This patch introduces UDP replicast. A concept where we emulate >> multicast by sending multiple unicast messages to configured peers. >> >> The purpose of replicast is mainly to be able to use TIPC in clou

Re: [tipc-discussion] BC rcv link acked stuck after receiving a named with a BC ACK of 0

2016-08-24 Thread Jon Maloy
Hi John, This sounds a lot like the problem I tried to fix in a71eb720355c2 ("tipc: ensure correct broadcast send buffer release when peer is lost") So, either that patch is not present in your kernel (if it is 4.7 it is supposed to be) or my solution somehow hasn't solved the problem. Can you c

Re: [tipc-discussion] [PATCH net-next v2 4/7] tipc: introduce UDP replicast

2016-08-24 Thread Jon Maloy
On 08/23/2016 10:41 AM, Richard Alpe wrote: > This patch introduces UDP replicast. A concept where we emulate > multicast by sending multiple unicast messages to configured peers. > > The purpose of replicast is mainly to be able to use TIPC in cloud > environments where IP multicast is disabled.