Re: [tipc-discussion] [PATCH net-next v3 4/7] tipc: introduce UDP replicast

2016-08-25 Thread Jon Maloy
Now it looks good to me. For the whole series: Reviewed-by: jon ///jon On 08/25/2016 04:15 AM, Richard Alpe wrote: > This patch introduces UDP replicast. A concept where we emulate > multicast by sending multiple unicast messages to configured peers. > > The purpose of replicast is mainly to b

Re: [tipc-discussion] [PATCH net-next 2/3] tipc: rate limit broadcast retransmissions

2016-08-25 Thread Xue, Ying
-Original Message- From: Jon Maloy [mailto:jon.ma...@ericsson.com] Sent: Wednesday, August 17, 2016 2:09 AM To: tipc-discussion@lists.sourceforge.net; parthasarathy.bhuvara...@ericsson.com; Xue, Ying; richard.a...@ericsson.com; jon.ma...@ericsson.com Cc: ma...@donjonn.com; gbala...@gma

[tipc-discussion] [PATCH net-next v3 0/7] tipc: introduce UDP replicast

2016-08-25 Thread Richard Alpe
This series does some preparation and introduces UDP replicast. A concept where we emulate multicast by sending multiple unicast messages to configured peers. This is required for TIPC to work in environments where IP multicast is disabled. There is a corresponding patch series for the tipc user s

[tipc-discussion] [PATCH net-next v3 4/7] tipc: introduce UDP replicast

2016-08-25 Thread Richard Alpe
This patch introduces UDP replicast. A concept where we emulate multicast by sending multiple unicast messages to configured peers. The purpose of replicast is mainly to be able to use TIPC in cloud environments where IP multicast is disabled. Using replicas to unicast multicast messages is costly

[tipc-discussion] [PATCH net-next v3 3/7] tipc: refactor multicast ip check

2016-08-25 Thread Richard Alpe
Add a function to check if a tipc UDP media address is a multicast address or not. This is a purely cosmetic change. Signed-off-by: Richard Alpe --- net/tipc/udp_media.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/net/tipc/udp_media.c

[tipc-discussion] [PATCH net-next v3 7/7] tipc: add UDP remoteip dump to netlink API

2016-08-25 Thread Richard Alpe
When using replicast a UDP bearer can have an arbitrary amount of remote ip addresses associated with it. This means we cannot simply add all remote ip addresses to an existing bearer data message as it might fill the message, leaving us with a truncated message that we can't safely resume. To hand

[tipc-discussion] [PATCH net-next v3 1/7] tipc: split UDP nl address parsing

2016-08-25 Thread Richard Alpe
Split the UDP netlink parse function so that it only parses one netlink attribute at the time. This makes the parse function more generic and allow future UDP API functions to use it for parsing. Signed-off-by: Richard Alpe Acked-by: Ying Xue Acked-by: Jon Maloy --- net/tipc/udp_media.c | 112

[tipc-discussion] [PATCH net-next v3 2/7] tipc: split UDP send function

2016-08-25 Thread Richard Alpe
Split the UDP send function into two. One callback that prepares the skb and one transmit function that sends the skb. This will come in handy in later patches, when we introduce UDP replicast. Signed-off-by: Richard Alpe Acked-by: Ying Xue Acked-by: Jon Maloy --- net/tipc/udp_media.c | 50 +++

[tipc-discussion] [PATCH net-next v3 5/7] tipc: add replicast peer discovery

2016-08-25 Thread Richard Alpe
Automatically learn UDP remote IP addresses of communicating peers by looking at the source IP address of incoming TIPC link configuration messages (neighbor discovery). This makes configuration slightly easier and removes the problematic scenario where a node receives directly addressed neighbor

[tipc-discussion] [PATCH net-next v3 6/7] tipc: add the ability to get UDP options via netlink

2016-08-25 Thread Richard Alpe
Add UDP bearer options to netlink bearer get message. This is used by the tipc user space tool to display UDP options. The UDP bearer information is passed using either a sockaddr_in or sockaddr_in6 structs. This means the user space receiver should intermediately store the retrieved data in a lar