Re: [tipc-discussion] WARNING: locking bug in icmp_send

2019-03-25 Thread Jon Maloy
Yet another duplicate of syzbot+a25307ad099309f1c...@syzkaller.appspotmail.com A fix has been posted. ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of syzbot > Sent: 23-Mar-19 19:03 > To: da...@davemloft.net; Jon Maloy ; > kuz...@ms2.inr.ac.ru;

Re: [tipc-discussion] [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()

2019-03-25 Thread Jon Maloy
Acked-by: Jon Maloy > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of Wei Yongjun > Sent: 25-Mar-19 07:31 > To: Jon Maloy ; Ying Xue > ; Hoang Huu Le ; > Eric Dumazet > Cc: Wei Yongjun ; net...@vger.kernel.org; > tipc-discussion@lists.sourceforge.net;

Re: [tipc-discussion] inconsistent lock state in icmp_send

2019-03-25 Thread Jon Maloy
Just another manifestation of syzbot+a25307ad099309f1c...@syzkaller.appspotmail.com We have just posted a patch fixing this. ///jon > Signed-off-by: Xin Long > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of syzbot > Sent: 24-Mar-19 14:38 > To:

Re: [tipc-discussion] [PATCH net] tipc: change to check tipc_own_id to return in tipc_net_stop

2019-03-25 Thread Jon Maloy
Acked-by: Jon Maloy > -Original Message- > From: Xin Long > Sent: 23-Mar-19 17:48 > To: network dev > Cc: da...@davemloft.net; Jon Maloy ; Ying Xue > ; tipc-discussion@lists.sourceforge.net; > syzkal...@googlegroups.com > Subject: [PATCH net] tipc: change to check tipc_own_id to return

Re: [tipc-discussion] [net-next 1/3] tipc: improve TIPC throughput by Gap ACK blocks

2019-03-25 Thread Tuong Lien Tong
Hi Ying! Correct, the idea was inspired from SACK in SCTP protocol but with simplicity. Also, I see your suggestions about the "duplicated packets"... which is connected to the SCTP "delayed SACK" algorithm (i.e. in the case of no payload message loss). In TIPC, as I understand so far, we