Re: [tipc-discussion] [net-next] tipc: add loopback device tracking

2019-06-17 Thread Erik Hugne
Change in netlink.c unrelated to the commit //E On Tue, 18 Jun 2019, 02:23 John Rutherford, wrote: > Since node internal messages are passed directly to socket it is not > possible to observe this message exchange via tcpdump or wireshark. > > We now remedy this by making it possible to clone

[tipc-discussion] [net-next] tipc: add loopback device tracking

2019-06-17 Thread John Rutherford
Since node internal messages are passed directly to socket it is not possible to observe this message exchange via tcpdump or wireshark. We now remedy this by making it possible to clone such messages and send the clones to the loopback interface. The clones are dropped at reception and have no

Re: [tipc-discussion] [net-next] tipc: include retrans failure detection for unicast

2019-06-17 Thread David Miller
From: Tuong Lien Date: Mon, 17 Jun 2019 12:15:42 +0700 > In patch series, commit 9195948fbf34 ("tipc: improve TIPC throughput by > Gap ACK blocks"), as for simplicity, the repeated retransmit failures' > detection in the function - "tipc_link_retrans()" was kept there for > broadcast

Re: [tipc-discussion] [PATCH net 0/3] net: fix quite a few dst_cache crashes reported by syzbot

2019-06-17 Thread Jon Maloy
Hi Xin, As I remember the discussion around introduction of UDP media a few years ago, the developer, Erik Huge, only chose to register TIPC as a udp tunnel user instead of regular udp user because it provides a more efficient way to receive packet in kernel space. With UDP tunnel, we could

Re: [tipc-discussion] [PATCH RFC 2/2] tipc: fix changeover issues due to large packet

2019-06-17 Thread Tuong Lien Tong
Hi Ying, Thanks for your comments! Regarding your last statement, yes when making the patch, I noticed that the "tipc_msg_build()" and "tipc_msg_fragment()" do a similar task, also I tried to think a way to combine them but didn't because of the reasons: 1- The "core" functions to copy the data