Re: [tipc-discussion] [net-next 1/1] tipc: embed jiffies in macro TIPC_BC_RETR_LIM

2019-07-01 Thread David Miller
From: Jon Maloy Date: Fri, 28 Jun 2019 17:06:20 +0200 > The macro TIPC_BC_RETR_LIM is always used in combination with 'jiffies', > so we can just as well perform the addition in the macro itself. This > way, we get a few shorter code lines and one less line break. > > Signed-off-by: Jon Maloy

[tipc-discussion] [PATCH net-next] tipc: remove ub->ubsock checks

2019-07-01 Thread Xin Long
Both tipc_udp_enable and tipc_udp_disable are called under rtnl_lock, ub->ubsock could never be NULL in tipc_udp_disable and cleanup_bearer, so remove the check. Also remove the one in tipc_udp_enable by adding "free" label. Signed-off-by: Xin Long --- net/tipc/udp_media.c | 17

[tipc-discussion] [PATCH net-next] tipc: use rcu dereference functions properly

2019-07-01 Thread Xin Long
For these places are protected by rcu_read_lock, we change from rcu_dereference_rtnl to rcu_dereference, as there is no need to check if rtnl lock is held. For these places are protected by rtnl_lock, we change from rcu_dereference_rtnl to rtnl_dereference/rcu_dereference_protected, as no extra