Re: [tipc-discussion] [net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

On Tue, Jun 02, 2020 at 11:46:40AM +0700, Tuong Lien wrote: Tested-by: Hoang Le > This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. > > There is no actual tipc_node refcnt leak as stated in the above commit. > The refcnt is hold carefully for the case of an asynchronous decryption >

[tipc-discussion] [net 0/2] tipc: revert two patches

We revert two patches: tipc: Fix potential tipc_node refcnt leak in tipc_rcv tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv which prevented TIPC encryption from working properly and caused kernel panic. Tuong Lien (2): Revert "tipc: Fix potential tipc_node refcnt leak in

[tipc-discussion] [net 1/2] Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv"

This reverts commit de058420767df21e2b6b0f3bb36d1616fb962032. There is no actual tipc_node refcnt leak as stated in the above commit. The refcnt is hold carefully for the case of an asynchronous decryption (i.e. -EINPROGRESS/-EBUSY and skb = NULL is returned), so that the node object cannot be

[tipc-discussion] [net 2/2] Revert "tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv"

This reverts commit 441870ee4240cf67b5d3ab8e16216a9ff42eb5d6. Like the previous patch in this series, we revert the above commit that causes similar issues with the 'aead' object. Acked-by: Jon Maloy Signed-off-by: Tuong Lien --- net/tipc/crypto.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [tipc-discussion] [RFC PATCH] tipc: fix general protection fault in sendstream()

Hi Jon, all, Would you please look at this patch and give me your 'Acked-by' before I post it? I can see the patch from YueHaibing ("tipc: Fix NULL pointer dereference in __tipc_sendstream()") was applied, but this patch is needed nonetheless since it will also cover the other case as

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

Hi Jon, See my comment inline. Hoang -Original Message- From: Jon Maloy Sent: Monday, June 1, 2020 7:40 PM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net Cc: Tung Quang Nguyen ; Tuong Tong Lien ; ma...@donjonn.com; x...@redhat.com; ying@windriver.com;

Re: [tipc-discussion] [net 0/2] tipc: revert two commits

Series acked by: Jon Maloy On 5/29/20 3:48 AM, Tuong Lien wrote: Hi Jon, all, I can see we had two commits from 'Xiyu Yang ' without your 'Acked-by', not sure why... They have caused kernel panics and the TIPC encryption cannot work correctly. Therefore, so I'd revert them. Please help

Re: [tipc-discussion] [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by:

Re: [tipc-discussion] [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by:

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

Hi Hoang. See below. On 6/1/20 5:33 AM, Hoang Huu Le wrote: Hi Jon, There is a concern in function tipc_node_broadcast. See my comment inline. Regards, Hoang -Original Message- From: jma...@redhat.com Sent: Friday, May 29, 2020 10:34 PM To: tipc-discussion@lists.sourceforge.net Cc:

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

Hi Jon, There is a concern in function tipc_node_broadcast. See my comment inline. Regards, Hoang -Original Message- From: jma...@redhat.com Sent: Friday, May 29, 2020 10:34 PM To: tipc-discussion@lists.sourceforge.net Cc: Tung Quang Nguyen ; Hoang Huu Le ; Tuong Tong Lien ;