Re: [tipc-discussion] [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-03 Thread David Miller
From: Huang Guobin Date: Sun, 2 Aug 2020 22:00:55 -0400 > Using is_broadcast_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is broadcast > address. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > >

[tipc-discussion] [PATCH net 1/2] ipv6: add ipv6_dev_find()

2020-08-03 Thread Xin Long
This is to add an ip_dev_find like function for ipv6, used to find the dev by saddr. It will be used by TIPC protocol. So also export it. Signed-off-by: Xin Long --- include/net/addrconf.h | 2 ++ net/ipv6/addrconf.c| 39 +++ 2 files changed, 41

[tipc-discussion] [PATCH net 2/2] tipc: set ub->ifindex for local ipv6 address

2020-08-03 Thread Xin Long
Without ub->ifindex set for ipv6 address in tipc_udp_enable(), ipv6_sock_mc_join() may make the wrong dev join the multicast address in enable_mcast(). This causes that tipc links would never be created. So fix it by getting the right netdev and setting ub->ifindex, as it does for ipv4 address.

[tipc-discussion] [PATCH net 0/2] net: fix a mcast issue for tipc udp media

2020-08-03 Thread Xin Long
Patch 1 is to add a function to get the dev by source address, whcih will be used by Patch 2. Xin Long (2): ipv6: add ipv6_dev_find() tipc: set ub->ifindex for local ipv6 address include/net/addrconf.h | 2 ++ net/ipv6/addrconf.c| 39 +++

Re: [tipc-discussion] [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-03 Thread Ying Xue
On 8/3/20 10:00 AM, Huang Guobin wrote: > Using is_broadcast_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is broadcast > address. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Huang Guobin