Re: [tipc-discussion] [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 13:59:46 -0700 > Is this a new Kconfig feature? ipv6_stub was introduced for > VXLAN, at that time I don't remember we have such kind of > Kconfig rules, otherwise it would not be needed. The ipv6_stub exists in order to allow the troublesome "ipv6=m &&

Re: [tipc-discussion] [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 13:29:40 -0700 > On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote: >> >> TIPC=m and IPV6=m builds just fine. >> >> Having tipc autoload ipv6 is a different problem. (IMO) >> >> >> This Kconfig entry: >> menuconfig TIPC >> tristate "The TIPC

Re: [tipc-discussion] [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 11:55:55 -0700 > On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: >> >> It just restricts how TIPC can be built, so that >> TIPC=y and IPV6=m cannot happen together, which causes >> a build error. > > It also disallows TIPC=m and IPV6=m, right? That

Re: [tipc-discussion] [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Xin Long
On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: > > On Sun, Aug 16, 2020 at 4:54 AM Xin Long wrote: > > > > When using ipv6_dev_find() in one module, it requires ipv6 not to > > work as a module. Otherwise, this error occurs in build: > > > > undefined reference to `ipv6_dev_find'. > > > > So

[tipc-discussion] [PATCH net] ipv6: some fixes for ipv6_dev_find()

2020-08-17 Thread Xin Long
This patch is to do 3 things for ipv6_dev_find(): As David A. noticed, - rt6_lookup() is not really needed. Different from __ip_dev_find(), ipv6_dev_find() doesn't have a compatibility problem, so remove it. As Hideaki suggested, - "valid" (non-tentative) check for the address is