Re: [tipc-discussion] [PATCH net] tipc: fix a race in tipc_sk_mcast_rcv

2021-04-28 Thread Tung Quang Nguyen
Hi Xin, See my comments inline. Best regards, Tung Nguyen -Original Message- From: Xin Long Sent: Thursday, April 29, 2021 2:31 AM To: network dev ; tipc-discussion@lists.sourceforge.net Cc: k...@kernel.org; lyl2...@mail.ustc.edu.cn; da...@davemloft.net Subject: [tipc-discussion]

[tipc-discussion] [PATCH net] tipc: fix a race in tipc_sk_mcast_rcv

2021-04-28 Thread Xin Long
After commit cb1b728096f5 ("tipc: eliminate race condition at multicast reception"), when processing the multicast reception, the packets are firstly moved from be->inputq1 to be->arrvq in tipc_node_broadcast(), then process be->arrvq in tipc_sk_mcast_rcv(). In tipc_sk_mcast_rcv(), it gets the