for TIPC UDP bearers to work in environments where IP multicast is
disabled.
Signed-off-by: Richard Alpe
Reviewed-by: Parthasarathy Bhuvaragan
Acked-by: Jon Maloy
---
man/man8/tipc-bearer.8 | 24 ++
tipc/bearer.c | 125 +
it
(replicast) we handle the TIPC_NLA_UDP_MULTI_REMOTEIP flag and send
a TIPC_NL_UDP_GET_REMOTEIP query transparently to the user.
Signed-off-by: Richard Alpe
Reviewed-by: Parthasarathy Bhuvaragan
Acked-by: Jon Maloy
---
man/man8/tipc-bearer.8 | 5 +-
tipc/bearer.c | 272
Would be nice to get an ack or review on this before I
send it in to netdev.
Richard Alpe (2):
tipc: introduce bearer add for remoteip
tipc: add the ability to get UDP bearer options
include/linux/tipc_netlink.h | 3 +
man/man8/tipc-bearer.8 | 29 +++-
tipc/bearer.c
for TIPC UDP bearers to work in environments where IP multicast is
disabled.
Signed-off-by: Richard Alpe
---
include/linux/tipc_netlink.h | 1 +
man/man8/tipc-bearer.8 | 24 +
tipc/bearer.c| 125 +++
3 files changed, 150
it
(replicast) we handle the TIPC_NLA_UDP_MULTI_REMOTEIP flag and send
a TIPC_NL_UDP_GET_REMOTEIP query transparently to the user.
Signed-off-by: Richard Alpe
---
include/linux/tipc_netlink.h | 2 +
man/man8/tipc-bearer.8 | 5 +-
tipc/bearer.c| 264
Split the UDP send function into two. One callback that prepares the
skb and one transmit function that sends the skb. This will come in
handy in later patches, when we introduce UDP replicast.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
net/tipc/udp_media.c | 50
Split the UDP netlink parse function so that it only parses one
netlink attribute at the time. This makes the parse function more
generic and allow future UDP API functions to use it for parsing.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
net/tipc/udp_media.c
add remote addresses to the replicast list.
Richard Alpe (7):
tipc: split UDP nl address parsing
tipc: split UDP send function
tipc: refactor multicast ip check
tipc: introduce UDP replicast
tipc: add replicast peer discovery
tipc: add the ability to get UDP options via netlink
tipc
discovery
messages sent using replicast which the node cannot "reply" to using
mutlicast, leaving the link FSM in a limbo state.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
---
net/tipc/udp_media.c | 83 ++--
1 file changed, 80
Add a function to check if a tipc UDP media address is a multicast
address or not. This is a purely cosmetic change.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
---
net/tipc/udp_media.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff
costly as we have to copy each skb and send the
copies individually.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 1 +
net/tipc/bearer.c | 44 ++
net/tipc/bearer.h | 1 +
net/tipc/netlink.c
e. To handle this we introduce the new netlink
command TIPC_NL_UDP_GET_REMOTEIP. This command is intended to be
called when the bearer data message has the
TIPC_NLA_UDP_MULTI_REMOTEIP flag set, indicating there are more than
one remote ip (replicast).
Signed-off-by: Richard Alpe
Reviewed-by: Jon
large enough struct
(sockaddr_strage) before casting to the proper IP version type.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
include/uapi/linux/tipc_netlink.h | 2 ++
net/tipc/bearer.c | 8 +
net/tipc/udp_media.c | 61
space tool that
allows a user to add remote addresses to the replicast list.
Richard Alpe (7):
tipc: split UDP nl address parsing
tipc: split UDP send function
tipc: refactor multicast ip check
tipc: introduce UDP replicast
tipc: add replicast peer discovery
tipc: add the ability to get
costly as we have to copy each skb and send the
copies individually.
Signed-off-by: Richard Alpe
---
include/uapi/linux/tipc_netlink.h | 1 +
net/tipc/bearer.c | 44 ++
net/tipc/bearer.h | 1 +
net/tipc/netlink.c| 5 ++
net/tipc
Add a function to check if a tipc UDP media address is a multicast
address or not. This is a purely cosmetic change.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/net/tipc/udp_media.c
e. To handle this we introduce the new netlink
command TIPC_NL_UDP_GET_REMOTEIP. This command is intended to be
called when the bearer data message has the
TIPC_NLA_UDP_MULTI_REMOTEIP flag set, indicating there are more than
one remote ip (replicast).
Signed-off-by: Richard Alpe
---
net/tipc/netl
Split the UDP netlink parse function so that it only parses one
netlink attribute at the time. This makes the parse function more
generic and allow future UDP API functions to use it for parsing.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
net/tipc/udp_media.c | 112
Split the UDP send function into two. One callback that prepares the
skb and one transmit function that sends the skb. This will come in
handy in later patches, when we introduce UDP replicast.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
net/tipc/udp_media.c | 50
discovery
messages sent using replicast which the node cannot "reply" to using
mutlicast, leaving the link FSM in a limbo state.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 83 ++--
1 file changed, 80 insertions(+), 3 deletion
large enough struct
(sockaddr_strage) before casting to the proper IP version type.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 ++
net/tipc/bearer.c | 8 +
net/tipc/udp_media.c | 61
On 2016-08-24 12:08, Jon Maloy wrote:
>
>
> On 08/23/2016 10:41 AM, Richard Alpe wrote:
>> This patch introduces UDP replicast. A concept where we emulate
>> multicast by sending multiple unicast messages to configured peers.
>>
>> The purpose of replicast is
Split the UDP send function into two. One callback that prepares the
skb and one transmit function that sends the skb. This will come in
handy in later patches, when we introduce UDP replicast.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
net/tipc/udp_media.c | 50
e. To handle this we introduce the new netlink
command TIPC_NL_UDP_GET_REMOTEIP. This command is intended to be
called when the bearer data message has the
TIPC_NLA_UDP_MULTI_REMOTEIP flag set, indicating there are more than
one remote ip (replicast).
Signed-off-by: Richard Alpe
---
net/tipc/netl
discovery
messages sent using replicast which the node cannot "reply" to using
mutlicast, leaving the link FSM in a limbo state.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 83 ++--
1 file changed, 80 insertions(+), 3 deletion
costly as we have to copy each skb and send the
copies individually.
Signed-off-by: Richard Alpe
---
include/uapi/linux/tipc_netlink.h | 1 +
net/tipc/bearer.c | 44 +
net/tipc/bearer.h | 1 +
net/tipc/netlink.c| 5 ++
net/tipc
large enough struct
(sockaddr_strage) before casting to the proper IP version type.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 ++
net/tipc/bearer.c | 8 +
net/tipc/udp_media.c | 61
---
net/tipc/udp_media.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 7033b4a..b8ec1a1 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -84,6 +84,17 @@ struct udp_bearer {
Split the UDP netlink parse function so that it only parses one
netlink attribute at the time. This makes the parse function more
generic and allow future UDP API functions to use it for parsing.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
net/tipc/udp_media.c | 112
space tool that
allows a user to add remote addresses to the replicast list.
Richard Alpe (7):
tipc: split UDP nl address parsing
tipc: split UDP send function
tipc: refactor multicast ip check
tipc: introduce UDP replicast
tipc: add replicast peer discovery
tipc: add the ability to get
This enables a user to remove an offline peer from the kernel data
structures. This could for example be useful when deliberately scaling
in peer nodes in a cloud environment.
This functionality was first merged in:
f9dec657e4 (Richard Alpe tipc: add peer remove functionality)
And later backed
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove
an offline peer node from the internal data structures.
This will be supported by the tipc user space tool in iproute2.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
include/uapi/linux/tipc_netlink.h
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove
an offline peer node from the internal data structures.
This will be supported by the tipc user space tool in iproute2.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
include/uapi/linux/tipc_netlink.h
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove
an offline peer node from the internal data structures.
This will be supported by the tipc user space tool in iproute2.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
include/uapi/linux/tipc_netlink.h
Local ip is not required to identify a UDP bearer and shouldn't be
passed to bearer disable, set or get. In this patch we remove the
localip entry from the synopsis of these functions.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 14 --
1 file changed, 4 inser
Introduce a generic function (nl_add_bearer_name()) that identifies a
bearer and adds it to an existing netlink message. This reduces code
complexity and makes the code a little bit easier to maintain.
Signed-off-by: Richard Alpe
---
tipc/bearer.c | 313
e still there?
---
Add TIPC_NL_PEER_REMOVE netlink command. This command can remove
an offline peer node from the internal data structures.
This will be supported by the tipc user space tool in iproute2.
Signed-off-by: Richard Alpe
Reviewed-by: Jon Maloy
Acked-by: Ying Xue
---
inclu
Introduce a generic function (nl_add_bearer_name()) that identifies a
bearer and adds it to an existing netlink message. This reduces code
complexity and makes the code a little bit easier to maintain.
Signed-off-by: Richard Alpe
---
tipc/bearer.c | 312
Local ip is not required to identify a UDP bearer and shouldn't be
passed to bearer disable, set or get. In this patch we remove the
localip entry from the synopsis of these functions.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 14 --
1 file changed, 4 inser
Hi everyone,
Just wanted to let you know I got the bash tab completion recipes for
the tipc tool in iproute2 merged. It will be in the next release 2.4.
https://github.com/scop/bash-completion
Regards
Richard
--
___
What happened to this patch-set?
/Richard
On 2016-04-09 08:21, Erik Hugne wrote:
> It made sense to keep tipcconfig in the tipcutils package for a while
> after Richard merged it to iproute2, but now it's becoming more of a
> source of confusion. And any patches submitted to iproute2/tipc would
>
an infoleak in tipc_nl_compat_link_dump)
Signed-off-by: Richard Alpe
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index 3ad9fab..1fd4647 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_com
On 2016-06-29 21:20, Jon Maloy wrote:
>
>
>> -Original Message-
>> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
>> Sent: Wednesday, 29 June, 2016 12:05
>> To: Jon Maloy; tipc-discussion@lists.sourceforge.net
>> Subject: Re: [tipc-discussion] [PATCH net-next 3/6] tipc: introduce UDP
>>
On 2016-06-29 14:17, Jon Maloy wrote:
>
>
> On 06/28/2016 05:21 AM, Richard Alpe wrote:
>> This patch introduces UDP replicast. A concept where we emulate
>> multicast by sending multiple unicast messages to configured peers.
>>
>> The purpose of replicast is
ed on c13b6b0.
Richard Alpe (4):
tipc: fix UDP bearer synopsis
tipc: refactor bearer identification
tipc: introduce bearer add for remoteip
tipc: add the ability to get UDP bearer options
include/linux/tipc_netlink.h | 3 +
man/man8/tipc-bearer.8 | 39 ++-
tipc/bearer.c
it
(replicast) we handle the TIPC_NLA_UDP_MULTI_REMOTEIP flag and send
a TIPC_NL_UDP_GET_REMOTEIP query transparently to the user.
Signed-off-by: Richard Alpe
---
include/linux/tipc_netlink.h | 2 +
man/man8/tipc-bearer.8 | 5 +-
tipc/bearer.c| 265
discovery
messages sent using replicast which the node cannot "reply" to using
mutlicast, leaving the link FSM in a limbo state.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 98
1 file changed, 91 insertions(+), 7 deletion
Local ip is not required to identify a UDP bearer and shouldn't be
passed to bearer disable, set or get. In this patch we remove the
localip entry from the synopsis of these functions.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 14 --
1 file changed, 4 inser
Split the UDP send function into two. One callback that prepares the
skb and one transmit function that sends the skb. This will come in
handy in later patches, when we introduce UDP replicast.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 50
for TIPC UDP bearers to work in environments where IP multicast is
disabled.
Signed-off-by: Richard Alpe
---
include/linux/tipc_netlink.h | 1 +
man/man8/tipc-bearer.8 | 24 +
tipc/bearer.c| 125 +++
3 files changed, 150
Introduce a generic function (nl_add_bearer_name()) that identifies a
bearer and adds it to an existing netlink message. This reduces code
complexity and makes the code a little bit easier to maintain.
Signed-off-by: Richard Alpe
---
tipc/bearer.c | 312
Split the UDP netlink parse function so that it only parses one
netlink attribute at the time. This makes the parse function more
generic and allow future UDP API functions to use it for parsing.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 112
costly as we have to copy each skb and send the
copies individually.
Signed-off-by: Richard Alpe
---
include/uapi/linux/tipc_netlink.h | 1 +
net/tipc/bearer.c | 44 +++
net/tipc/bearer.h | 1 +
net/tipc/netlink.c| 5 ++
net/tipc
e. To handle this we introduce the new netlink
command TIPC_NL_UDP_GET_REMOTEIP. This command is intended to be
called when the bearer data message has the
TIPC_NLA_UDP_MULTI_REMOTEIP flag set, indicating there are more than
one remote ip (replicast).
Signed-off-by: Richard Alpe
---
net/tipc/netl
large enough struct
(sockaddr_strage) before casting to the proper IP version type.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
include/uapi/linux/tipc_netlink.h | 2 ++
net/tipc/bearer.c | 8 ++
net/tipc/udp_media.c | 58
space tool that
allows a user to add remote addresses to the replicast list.
Richard Alpe (6):
tipc: split UDP nl address parsing
tipc: split UDP send function
tipc: introduce UDP replicast
tipc: add replicast peer discovery
tipc: add the ability to get UDP options via netlink
tipc: add
Context implies that port in struct "udp_media_addr" is referring
to a UDP port.
Signed-off-by: Richard Alpe
Acked-by: Jon Maloy
Acked-by: Ying Xue
---
net/tipc/udp_media.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/net/tipc/udp
The UDP msg2addr function tipc_udp_msg2addr() can return -EINVAL which
prior to this patch was unhanded in the caller.
Signed-off-by: Richard Alpe
Acked-by: Jon Maloy
Acked-by: Ying Xue
---
net/tipc/discover.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/tipc
On 2016-06-22 17:40, Erik Hugne wrote:
> This change is not backwards compatible, udp_media_addr is carried in the
> neighbor discovery messages.
You're right. I will drop this patch.
/Richard
>
> //E
> On Jun 22, 2016 10:03, "Richard Alpe" wrote:
>
>&g
The UDP msg2addr function tipc_udp_msg2addr() can return -EINVAL which
prior to this patch was unhanded in the caller.
Signed-off-by: Richard Alpe
---
net/tipc/discover.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index
Context implies that port in struct "udp_media_addr" is referring
to a UDP port.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index c9cf2b
Use socket address family instead of ethernet protocol ID to identify
IP version internally.
---
net/tipc/udp_media.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index b016c01..c7df8bd 100644
--- a/net
Did some minor UDP refactoring in the midst of some UDP features I'm
working on. Sending them in a separate patchset as they should make
sense even without the rest of the changes I'm wokring on.
Richard Alpe (3):
tipc: honor msg2addr return value
tipc: rename udp_port
On 2016-06-08 21:40, Jon Maloy wrote:
>
>
>> -Original Message-
>> From: Parthasarathy Bhuvaragan
>> Sent: Thursday, 02 June, 2016 10:10
>> To: tipc-discussion@lists.sourceforge.net; Jon Maloy; ma...@donjonn.com; Ying
>> Xue; Richard Alpe
>> Su
On 2016-06-08 22:01, Jon Maloy wrote:
>
>
>> -Original Message-
>> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
>> Sent: Wednesday, 08 June, 2016 15:46
>> To: Parthasarathy Bhuvaragan; tipc-discussion@lists.sourceforge.net;
>> ma...@donjonn.com; Y
Hi Erik,
On 2016-05-27 15:34, Richard Alpe wrote:
> On 2016-05-27 13:29, Erik Hugne wrote:
>> On May 27, 2016 10:13, "Richard Alpe" wrote:
>>>
>>> On 2016-05-26 19:58, Erik Hugne wrote:
>>>>> .ti -8
>>>>> +.B tipc bearer add r
On 2016-05-27 13:29, Erik Hugne wrote:
> On May 27, 2016 10:13, "Richard Alpe" wrote:
>>
>> On 2016-05-26 19:58, Erik Hugne wrote:
>>>> .ti -8
>>>> +.B tipc bearer add remoteip REMOTEIP media udp name NAME
>>>
>>> Why is the
On 2016-05-26 19:58, Erik Hugne wrote:
>> .ti -8
>> +.B tipc bearer add remoteip REMOTEIP media udp name NAME
>
> Why is the parameter order different from "bearer enable"?
>
> tipc bearer enable media udp localip xxx name yyy?
>
> Or can you specify it in this order when adding replicast remot
ommunicate in environments
where IP multicast is disabled.
Signed-off-by: Richard Alpe
---
include/linux/tipc_netlink.h | 1 +
man/man8/tipc-bearer.8 | 15 +++
tipc/bearer.c| 95
3 files changed, 111 insertions(+)
diff --git
In this patch we add the ability to print local and remote UDP bearer
information. More specifically localip, localport, remoteip and
remoteport.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 31 ++--
tipc/bearer.c | 134
Local ip is not required to identify a UDP bearer and shouldn't be
passed to bearer disable, set or get. In this patch we remove the
localip entry from the synopsis of these functions.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 14 --
1 file changed, 4 inser
Here is a early preview of the bearer add (replicast) and bearer get functions
I'm working on. There is still some testing and tweaking left for the replicast
functionality.
You can expect a new version of this and the kernel counterpart next week.
Richard Alpe (4):
tipc: fix UDP b
Signed-off-by: Richard Alpe
---
tipc/bearer.c | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bearer.c
index 30b54d9..32abad6 100644
--- a/tipc/bearer.c
+++ b/tipc/bearer.c
@@ -67,8 +67,7 @@ static void cmd_bearer_enable_udp_help
On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote:
> Hi,
>
> This commit series requires the following kernel patch set:
> "[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor"
Nice work Partha! I inlined some minor comments from a first look.
Thanks
Richard
>
> I have issues
On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote:
> In this commit, we fetch the monitor attributes
> and present it in a user friendly manner.
It would be nice with an snippet printout here. So we can see how it
might look.
>
> Signed-off-by: Parthasarathy Bhuvaragan
>
> ---
> include/linu
On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote:
> Signed-off-by: Parthasarathy Bhuvaragan
>
> ---
> tipc/link.c | 105
>
> 1 file changed, 98 insertions(+), 7 deletions(-)
>
> diff --git a/tipc/link.c b/tipc/link.c
> index 2e67b
On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote:
> Signed-off-by: Parthasarathy Bhuvaragan
>
> ---
> include/linux/tipc_netlink.h | 33
> tipc/link.c | 74
> +++-
> 2 files changed, 106 insertions(+), 1 deletion(-
On 2016-05-23 15:27, Parthasarathy Bhuvaragan wrote:
> Signed-off-by: Parthasarathy Bhuvaragan
>
> ---
> tipc/bearer.c | 2 +-
> tipc/link.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tipc/bearer.c b/tipc/bearer.c
> index 30b54d9fe24e..3673f4f85f16 100644
> ---
Split the UDP netlink parse function so that it only parses one
netlink attribute at the time. This makes the parse function more
generic and allow future UDP API functions to use it for parsing.
Signed-off-by: Richard Alpe
---
net/tipc/udp_media.c | 113
struct
(sockaddr_strage) before casting to the proper type.
Signed-off-by: Richard Alpe
Acked-by: Ying Xue
Acked-by: Jon Maloy
---
net/tipc/bearer.c| 9 +
net/tipc/udp_media.c | 52
net/tipc/udp_media.h | 42
This patch introduces UDP replicast. A concept where we emulate
multicast by sending multiple unicast messages to configured peers.
This is intended solely for cloud environments where IP multicast is
disabled. Using replicas to send multicast messages is costly as we
have to copy each skb and sen
Split the UDP send function into two. One callback that prepares the
skb and one transmit function that sends the skb. This will come in
handy in later, when we introduce UDP replicast.
---
net/tipc/udp_media.c | 51 +--
1 file changed, 33 insertions
feedback it's always apricated.
Richard Alpe (4):
tipc: add the ability to get UDP options via netlink
tipc: split udp nl address parsing
tipc: split UDP send function
tipc: introduce UDP replicast
include/uapi/linux/tipc_netlink.h | 1 +
net/tipc/bearer.c | 52
The publication field of the old netlink API should contain the
publication key and not the publication reference.
Fixes: 44a8ae94fd55 (tipc: convert legacy nl name table dump to nl compat)
Signed-off-by: Richard Alpe
Acked-by: Jon Maloy
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1
The publication field of the old netlink API should contain the
publication key and not the publication reference.
Signed-off-by: Richard Alpe
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
Make sure the socket for which the user is listing publication exists
before parsing the socket netlink attributes.
Prior to this patch a call without any socket caused a NULL pointer
dereference in tipc_nl_publ_dump().
Tested-and-reported-by: Baozeng Ding
Signed-off-by: Richard Alpe
---
net
Signed-off-by: Richard Alpe
---
tipc/bearer.c | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/tipc/bearer.c b/tipc/bearer.c
index 30b54d9..32abad6 100644
--- a/tipc/bearer.c
+++ b/tipc/bearer.c
@@ -67,8 +67,7 @@ static void cmd_bearer_enable_udp_help
Local ip is not required to identify a UDP bearer and shouldn't be
passed to bearer disable, set or get. In this patch we remove the
localip entry from the synopsis of these functions.
Signed-off-by: Richard Alpe
---
man/man8/tipc-bearer.8 | 14 --
1 file changed, 4 inser
In this patch we add the ability to print local and remote UDP bearer
information. More specifically local ip, local port, remote ip and
remote port.
---
man/man8/tipc-bearer.8 | 31 ++--
tipc/bearer.c | 134 -
2 files changed, 137
struct
(sockaddr_strage) before casting to the proper type.
Signed-off-by: Richard Alpe
---
net/tipc/bearer.c| 7 +++
net/tipc/udp_media.c | 53
net/tipc/udp_media.h | 42 +
3 files changed, 102
for iproute2 for this as well.
Richard Alpe (1):
tipc: add the ability to get UDP options via netlink
net/tipc/bearer.c| 7 +++
net/tipc/udp_media.c | 53
net/tipc/udp_media.h | 42 +
3 files
On 2016-04-18 12:02, Eric Zhou wrote:
> Hi,
> We plan to introduce the TIPC into our system but we have one
> question on the system configuration.
> Our system supports standalone mode and modular chassis mode.
> -->For standalone mode, two cards are inserted in the sam
Nice functionality. Some minor comments inline.
On 2016-04-09 20:38, Jon Maloy wrote:
> TIPC based clusters are by default set up with full-mesh link
> connectivity between all nodes. Those links are expected to provide
> a short failure detection time, by default set to 1500 ms. Because
> of this
On 2016-04-11 21:44, Jon Maloy wrote:
> Partha,Richard,
> I think you are the experts on this now. To me it looks like a message
> rejected (probably because of overload, according to previous mail exchange
> with GUNA) back to a socket on the local node is not being dropped, as it
> should. May
On 2016-04-11 14:59, Jon Maloy wrote:
> In some link establishment scenarios we see that packet #2 may be sent
> out before packet #1, forcing the receiver to demand retransmission of
> the missing packet. This is harmless, but may cause confusion among
> people tracing the packet flow.
>
> Since
On 2016-04-11 14:59, Jon Maloy wrote:
> The function tipc_link_timeout() is unnecessary complex, and can
> easily be made more readable.
>
> We do that with this commit. The only functional change is that we
> remove a redundant test for whether the broadcast link is up or not.
>
> Signed-off-by:
Getting some conflicts applying this on net-next. Can
you rebase it or let us know what you based it on?
Regards
Richard
On 2016-04-09 20:38, Jon Maloy wrote:
> TIPC based clusters are by default set up with full-mesh link
> connectivity between all nodes. Those links are expected to provide
> a
Great, whole patchset:
Acked-by: Richard Alpe
On 2016-04-09 08:21, Erik Hugne wrote:
> It made sense to keep tipcconfig in the tipcutils package for a while
> after Richard merged it to iproute2, but now it's becoming more of a
> source of confusion. And any patches submitted to
Hi,
On 2016-04-06 17:36, GUNA wrote:
> I upgraded kernel from 3.4.2 to 4.4.0 and noticed links were bouncing
> and not stable.
>
> There are a multitude of “Link not active” messages from audit_tipc.sh
> script, as you could see below, however the links are up from
> "tipc-config -l".
As a side n
Tested and reviewed. Nice work Erik! :)
Richard
On 2016-04-02 10:52, Erik Hugne wrote:
> Patch #1 aims to fix a potential issue with deferred updates being pushed
> to the wrong namespace
> Patch #2 should solve the problem with stale updates in the defer queue after
> node down,
>
1 - 100 of 141 matches
Mail list logo
