[tipc-discussion] [PATCH net] tipc: do not write skb_shinfo frags when doing decrytion

2021-07-23 Thread Xin Long
One skb's skb_shinfo frags are not writable, and they can be shared with other skbs' like by pskb_copy(). To write the frags may cause other skb's data crash. So before doing en/decryption, skb_cow_data() should always be called for a cloned or nonlinear skb if req dst is using the same sg as req

Re: [tipc-discussion] [PATCH net] tipc: do not write skb_shinfo frags when doing decrytion

2021-07-23 Thread Jon Maloy
On 23/07/2021 13:43, Xin Long wrote: One skb's skb_shinfo frags are not writable, and they can be shared with other skbs' like by pskb_copy(). To write the frags may cause other skb's data crash. So before doing en/decryption, skb_cow_data() should always be called for a cloned or nonlinear

[tipc-discussion] [PATCH net] tipc: do not write skb_shinfo frags when doing decrytion

2021-07-23 Thread Xin Long
One skb's skb_shinfo frags are not writable, and they can be shared with other skbs' like by pskb_copy(). To write the frags may cause other skb's data crash. So before doing en/decryption, skb_cow_data() should always be called for a cloned or nonlinear skb if req dst is using the same sg as req