Acked-by: Jon
///jon
> -----Original Message-----
> From: Parthasarathy Bhuvaragan
> Sent: Thursday, 03 March, 2016 11:28
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy; ma...@donjonn.com; Ying
> Xue; Richard Alpe; Anders Widell
> Subject: [PATCH net v1 1/1] tipc: fix nullptr crash during subscription cancel
>
> commit 4d5cfcba2f6e ('tipc: fix connection abort during subscription
> cancel'), removes the check for a valid subscription before calling
> tipc_nametbl_subscribe().
>
> This will lead to a nullptr exception when we process a
> subscription cancel request. For a cancel request, a null
> subscription is passed to tipc_nametbl_subscribe() resulting
> in exception.
>
> In this commit, we call tipc_nametbl_subscribe() only for
> a valid subscription.
>
> Fixes: 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel')
> Reported-by: Anders Widell <anders.wid...@ericsson.com>
> Signed-off-by: Parthasarathy Bhuvaragan
> <parthasarathy.bhuvara...@ericsson.com>
> ---
> net/tipc/subscr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
> index 69ee2eeef968..f9ff73a8d815 100644
> --- a/net/tipc/subscr.c
> +++ b/net/tipc/subscr.c
> @@ -296,7 +296,8 @@ static void tipc_subscrb_rcv_cb(struct net *net, int
> conid,
> if (tipc_subscrp_create(net, (struct tipc_subscr *)buf, subscrb, &sub))
> return tipc_conn_terminate(tn->topsrv, subscrb->conid);
>
> - tipc_nametbl_subscribe(sub);
> + if (sub)
> + tipc_nametbl_subscribe(sub);
> }
>
> /* Handle one request to establish a new subscriber */
> --
> 2.1.4
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
tipc-discussion mailing list
tipc-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tipc-discussion
