[tipc-discussion] [iproute2-next v6] tipc: support interface name when activating UDP bearer

2019-06-24 Thread Hoang Le
Support for indicating interface name has an ip address in parallel with specifying ip address when activating UDP bearer. This liberates the user from keeping track of the current ip address for each device. Old command syntax: $tipc bearer enable media udp name NAME localip IP New command

Re: [tipc-discussion] [PATCHv2 net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread David Miller
From: Xin Long Date: Tue, 25 Jun 2019 00:28:19 +0800 > This patch is to fix an uninit-value issue, reported by syzbot: ... > TLV_GET_DATA_LEN() may return a negtive int value, which will be > used as size_t (becoming a big unsigned long) passed into memchr, > cause this issue. > > Similar to

[tipc-discussion] [PATCHv2 net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread Xin Long
This patch is to fix an uninit-value issue, reported by syzbot: BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:981 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x191/0x1f0 lib/dump_stack.c:113 kmsan_report+0x130/0x2a0 mm/kmsan/kmsan.c:622

Re: [tipc-discussion] [PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread David Miller
From: Xin Long Date: Tue, 25 Jun 2019 00:00:39 +0800 > Sorry, David, do I need to resend this one? Yes, please, that helps me a lot. ___ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net

Re: [tipc-discussion] [PATCH net] tipc: check msg->req data len in tipc_nl_compat_bearer_disable

2019-06-24 Thread Xin Long
On Mon, Jun 24, 2019 at 4:33 PM Eric Dumazet wrote: > > > > On 6/24/19 12:59 AM, Xin Long wrote: > > This patch is to fix an uninit-value issue, reported by syzbot: > > > > BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:981 > > Call Trace: > > __dump_stack lib/dump_stack.c:77

Re: [tipc-discussion] [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread David Miller
From: Xin Long Date: Mon, 24 Jun 2019 23:54:02 +0800 > On Mon, Jun 24, 2019 at 10:35 PM David Miller wrote: >> >> From: Xin Long >> Date: Mon, 24 Jun 2019 16:02:42 +0800 >> >> > tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() >> > which already does the check for

Re: [tipc-discussion] [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread Xin Long
On Mon, Jun 24, 2019 at 10:35 PM David Miller wrote: > > From: Xin Long > Date: Mon, 24 Jun 2019 16:02:42 +0800 > > > tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() > > which already does the check for msg->req check, so remove it from > > tipc_nl_compat_bearer_set(),

Re: [tipc-discussion] [net-next] tipc: fix missing indentation in source code

2019-06-24 Thread David Miller
From: John Rutherford Date: Mon, 24 Jun 2019 14:01:23 +1000 > Fix misalignment of policy statement in netlink.c due to automatic > spatch code transformation. > > Fixes: 3b0f31f2b8c9 ("genetlink: make policy common to family") > Acked-by: Jon Maloy > Signed-off-by: John Rutherford Applied.

[tipc-discussion] [PATCH net] tipc: remove the unnecessary msg->req check from tipc_nl_compat_bearer_set

2019-06-24 Thread Xin Long
tipc_nl_compat_bearer_set() is only called by tipc_nl_compat_link_set() which already does the check for msg->req check, so remove it from tipc_nl_compat_bearer_set(), and do the same in tipc_nl_compat_media_set(). Signed-off-by: Xin Long --- net/tipc/netlink_compat.c | 10 -- 1 file