Re: [tipc-discussion] [net-next 3/4] tipc: refactor function tipc_sk_anc_data_recv()

2021-03-31 Thread Hoang Huu Le
> -Original Message- > From: jma...@redhat.com > Sent: Thursday, March 25, 2021 10:56 PM > To: tipc-discussion@lists.sourceforge.net > Cc: Tung Quang Nguyen ; Hoang Huu Le > ; Tuong Tong Lien > ; jma...@redhat.com; ma...@donjonn.com; > l...@redhat.com; ying@windriver.com; >

[tipc-discussion] [iproute2-next] tipc: use the libmnl functions in lib/mnl_utils.c

2021-03-31 Thread Hoang Le
To avoid code duplication, tipc should be converted to use the helper functions for working with libmnl in lib/mnl_utils.c Acked-by: Jon Maloy Signed-off-by: Hoang Le --- tipc/bearer.c| 38 ++ tipc/cmdl.c | 2 - tipc/link.c | 37 + tipc/media.c |

[tipc-discussion] [net] tipc: fix unique bearer names sanity check

2021-03-31 Thread Hoang Le
When enabling a bearer by name, we don't sanity check its name with higher slot in bearer list. This may have the effect that the name of an already enabled bearer bypasses the check. To fix the above issue, we just perform an extra checking with all existing bearers. Fixes: cb30a63384bc9

Re: [tipc-discussion] [iproute2-next] tipc: use the libmnl functions in lib/mnl_utils.c

2021-03-31 Thread Jon Maloy
On 3/29/21 6:59 AM, Hoang Le wrote: To avoid duplication, avoid code duplication tipc should be converted to use the helper functions for working with libmnl in lib/mnl_utils.c Signed-off-by: Hoang Le --- tipc/bearer.c| 38 ++ tipc/cmdl.c | 2 - tipc/link.c

Re: [tipc-discussion] [net v2] tipc: fix unique bearer names sanity check

2021-03-31 Thread Jon Maloy
On 3/29/21 10:16 PM, Hoang Le wrote: When enabling a bearer s/with identify//g by name, we don't sanity check its name with higher slot in bearer list. This lead to duplicate bearer names bypassed the check. This may have the effect that the name of an already enabled bearer bypasses