Hi Partha,
Forget about my previous comment. On a closer look, I find that your patch is
correct. (But you should still rephrase.)
Both patches acked by: me
///jon
> -Original Message-
> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
> Sent: Friday, February 24, 2017
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Friday, February 24, 2017 08:51 AM
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy
> <jon.ma...@ericsson.com>; Ying Xue <ying@windriver.com>;
> pbut...@sonusnet.com
> Subject: [P
> -Original Message-
> From: Butler, Peter [mailto:pbut...@sonusnet.com]
> Sent: Wednesday, February 22, 2017 04:31 PM
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.sourceforge.net
> Cc: Butler, Peter <pbut...@sonusnet.com>
> Subje
initialized stack fields are not updated accordingly.
We fix this in this commit.
Reported-by: Matthew Wong <mw...@sonusnet.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/node.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/net/tipc/
> -Original Message-
> From: Butler, Peter [mailto:pbut...@sonusnet.com]
> Sent: Thursday, February 23, 2017 10:25 AM
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.sourceforge.net
> Cc: Butler, Peter <pbut...@sonusnet.com>
> Subje
> -Original Message-
> From: Butler, Peter [mailto:pbut...@sonusnet.com]
> Sent: Thursday, February 23, 2017 01:09 PM
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.sourceforge.net; Parthasarathy Bhuvaragan
> <parthasarathy.bhuvara...@ericss
> -Original Message-
> From: Butler, Peter [mailto:pbut...@sonusnet.com]
> Sent: Thursday, February 23, 2017 01:23 PM
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.sourceforge.net; Parthasarathy Bhuvaragan
> <parthasarathy.bhuvara...@ericss
Hi John.
Yes you are right. But I still would prefer a condensed patch where we don’t
touch the refcounts when this goes into ‘net’. I am awaiting a comment from
Ying.
///jon
From: John Thompson [mailto:thompa@gmail.com]
Sent: Tuesday, February 21, 2017 04:18 PM
To: Jon Maloy <jon
> Sent: Wednesday, February 22, 2017 10:40 AM
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.sourceforge.net
> Cc: Butler, Peter <pbut...@sonusnet.com>
> Subject: RE: TIPC Oops in tipc_sk_recv
>
> If you have any suggestions as to procedures/tricks y
Hi Matthew,
See below for my comment.
Also, although this is about a different problem, you should check if you have
the following patch, and the one it is referring to:
commit 06bd2b1ed04ca9f (" tipc: fix broadcast link synchronization problem")
> -Original Message-
> From: Wong,
Thanks Partha. Any viewpoints form Ying? Otherwise I'll send it in tomorrow.
///jon
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Tuesday, 17 January, 2017 09:35
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of David Miller
> Sent: Monday, 16 January, 2017 14:45
> To: Jon Maloy <jon.ma...@ericsson.com>
> Cc: net...@vger.kernel.org; v...@zeniv.linux.org.uk;
() to
the bearer layer, and letting the bearer selection function in
bcast.c use this to give a new boolean field, 'bcast_support' the
appropriate value.
Reviewed-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off-b
reordering caused by method change,
i.e., when changes to cluster size or number of destinations would
otherwise mandate a new method to be used.
Reviewed-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off
ted number of unicast links,
instead of relying on the underlying media. This option is used when
true broadcast/multicast is not supported by the media, or when the
number of true destinations is much smaller than the cluster size.
Jon Maloy (4):
tipc: add function for checking broadcast support
com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c | 33 +++--
net/tipc/bcast.h | 15 ++-
net/tipc/name_table.c | 38 +-
net/tipc
nd reset at the same locations as with the previous solution, while
the packet filtering is moved to the generic code for the sending side.
On the receiving side, the filtering is still done in media specific
code, but now including the UDP bearer.
Acked-by: Ying Xue <ying@windriver.com>
Signed
If Erik doesn't have access to the tipcutils repository I suggest one of you
guys apply and check it in.
Acked-by: jon
> -Original Message-
> From: Richard Alpe
> Sent: Monday, 01 August, 2016 08:39
> To: Erik Hugne <erik.hu...@gmail.com>; Jon Maloy <jon.ma...@eric
> -Original Message-
> From: Butler, Peter [mailto:pbut...@sonusnet.com]
> Sent: Monday, February 27, 2017 10:15 AM
> To: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
> Cc: Jon Maloy <jon.ma...@ericsson.com>; tipc-
> discuss...@lists.
On 08/23/2016 10:41 AM, Richard Alpe wrote:
> This patch introduces UDP replicast. A concept where we emulate
> multicast by sending multiple unicast messages to configured peers.
>
> The purpose of replicast is mainly to be able to use TIPC in cloud
> environments where IP multicast is
Hi John,
See below.
///jon
From: John THompson [mailto:thompa@gmail.com]
Sent: Tuesday, 06 September, 2016 00:14
To: Jon Maloy <ma...@donjonn.com>
Cc: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net
Subject: Re: [tipc-discussion] BC rcv link acked
among the nodes in order to avoid NACK storms.
Reviewed-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/link.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/
iewed-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c | 8 ---
net/tipc/bcast.h | 4 ++--
net/tipc/link.c | 64
net/tipc/link.h | 6 +++---
net/tipc/msg.h |
<ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/link.c | 52 +++-
1 file changed, 47 insertions(+), 5 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 136316f..58bb44d 100644
--
The broadcast protocol has turned out to not scale well beyond 70-80
nodes, while it is now possible to build TIPC clusters of at least ten
times that size. This commit series improves the NACK/retransmission
mechanism of the broadcast protocol to make is at scalable as the rest
of TIPC.
Jon
From: John THompson [mailto:thompa@gmail.com]
Sent: Tuesday, 06 September, 2016 20:48
To: Jon Maloy <jon.ma...@ericsson.com>
Cc: Jon Maloy <ma...@donjonn.com>; tipc-discussion@lists.sourceforge.net
Subject: Re: [tipc-discussion] BC rcv link acked stuck after receiving a named
w
On 08/25/2016 05:41 AM, Xue, Ying wrote:
>
> -Original Message-
> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
> Sent: Wednesday, August 17, 2016 2:09 AM
> To: tipc-discussion@lists.sourceforge.net;
> parthasarathy.bhuvara...@ericsson.com; Xue, Ying; richard
///jon
From: John THompson [mailto:thompa@gmail.com]
Sent: Wednesday, 24 August, 2016 16:22
To: Jon Maloy <jon.ma...@ericsson.com>
Cc: tipc-discussion@lists.sourceforge.net
Subject: Re: [tipc-discussion] BC rcv link acked stuck after receiving a named
with a BC ACK of 0
Hi Jon,
To clar
The multicast failure is known. It happens because I lowered the socket
receive buffer size in commit 10724cc7bb783 ("tipc: redesign
connection-level flow control") so that the send stream now occasionally
get too big, and a message is rejected. I don't consider this an error,
as a multicast
Reviewed-by: Jon Maloy
On 08/31/2016 07:35 AM, Parthasarathy Bhuvaragan wrote:
> In a dual bearer configuration, if the second tipc link becomes
> active while the first link still has pending nametable "bulk"
> updates, it randomly leads to reset of the second li
commit c7cad0d6f70cd upstream
(“tipc: move linearization of buffers to generic code”)
was applied to net-next in November 2015, and is present in kernel
versions from 4.5.x onwards.
We later discovered that this commit also fixes a serious bug, since
even L2 buffers may arrive non-linearized.
by replicating and sending the packets over as
many unicast links as needed to reach all identified destinations.
We now introduce a new TIPC link-level 'replicast' service that does
this.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c
As a further preparation for the upcoming 'replicast' functionality,
we add some necessary structs and functions for looking up and returning
a list of all nodes that host destinations for a given multicast message.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/name_table.
ted number of unicast links,
instead of relying on the underlying media. This option is used when
true broadcast/multicast is not supported by the media, or when the
number of true destinations is much smaller than the cluster size.
Jon Maloy (4):
tipc: add function for checking broadcast support
On 09/15/2016 08:29 AM, Parthasarathy Bhuvaragan wrote:
>
> On 09/14/2016 10:20 PM, Jon Maloy wrote:
>> Hi Partha,
>> It looks good. I am especially happy that you got rid of the "connected"
>> field, which I have been requesting for several years.
>> I
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Wednesday, 05 October, 2016 04:18
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> ma...@donjonn.com; Ying Xue <ying@windriver.com>
> Subject: Re: [PATCH
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Thursday, 06 October, 2016 04:35
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> ma...@donjonn.com; Ying Xue <ying@windriver.com>
> Subject: Re: [PATCH
Acked-by: jon
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Tuesday, 04 October, 2016 08:29
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy <jon.ma...@ericsson.com>;
> ma...@donjonn.com; Ying Xue <ying@windriver.com>
> Subject: [
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Tuesday, 04 October, 2016 08:29
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy <jon.ma...@ericsson.com>;
> ma...@donjonn.com; Ying Xue <ying@windriver.com>
> Subject: [PATCH net v1 2
This looks fine to me now.
Acked-by: Jon Maloy
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Monday, 19 September, 2016 14:56
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy <jon.ma...@ericsson.com>;
> ma...@donjonn.com; Ying Xue <ying@
> -Original Message-
> From: Rune Torgersen [mailto:ru...@innovsys.com]
> Sent: Wednesday, 21 September, 2016 15:52
> To: 'Jon Maloy' <ma...@donjonn.com>; tipc-discussion@lists.sourceforge.net
> Subject: Re: [tipc-discussion] Strange TIPC error
>
> I do not th
> -Original Message-
> From: Xue, Ying [mailto:ying@windriver.com]
> Sent: Tuesday, 23 August, 2016 05:48
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
e to claim an unused bit in the header to indicate that the value
is invalid. This minor protocol change is fully backwards compatible.
Reported-by: John Thompson <thompa@gmail.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c | 17 -
net/tipc
Hi John,
I think this one should solve the problem. Pease try it when you are back from
vacation, and give feedback.
BR
///jon
> -Original Message-
> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
> Sent: Friday, 30 September, 2016 18:07
> To: tipc-discussion@lists.sou
kets sent out before the broadcast
links are fully synchronized.
This minor protocol update is fully backwards compatible.
Reported-by: John Thompson <thompa@gmail.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c | 14 ++
net/tipc/bcast.
Thank you John,I really appreciated your help and patience with this. I'll post
the patch asap.
BR///jon
De : John Thompson <thompa@gmail.com>
À : Jon Maloy <ma...@donjonn.com>
Cc : Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
Partha
kets sent out before the broadcast
links are fully synchronized.
This minor protocol update is fully backwards compatible.
Reported-by: John Thompson <thompa@gmail.com>
Tested-by: John Thompson <thompa....@gmail.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.c
Hi Richard,
I had a question about whether it is possible to simultaneously monitor IPv4
and IPv6 connectivity via the same interface by enabling two udp bearers, one
for each protocol, on the same interface. I tried this, and it failed they both
are using the same (hard coded?) port number.
ver the weekend and will be in touch next week about
> how it has
> held up.
>
> Thanks,
> JT
>
>
> On Sat, Oct 1, 2016 at 10:23 PM, Jon Maloy <jon.ma...@ericsson.com
> <mailto:jon.ma...@ericsson.com>> wrote:
>
> In commit 2d18ac4ba745 ("tipc: exte
t was done, and which of
the patches are needed to resolve the issue.
BR
///jon
> -Original Message-
> From: XIANG Haiming [mailto:haiming.xi...@alcatel-sbell.com.cn]
> Sent: Wednesday, 23 November, 2016 20:41
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lis
yclic link establishment and
reset on the 4.6+ node.
We fix this by adding a test that the received value should not only
be valid, but also differ from the current value in order to cause the
receiving link endpoint to reset.
Reported-by: Amar Nv <amar.nv...@gmail.com>
Signed-off-by: J
Hi,
I will take a look into this during the next days. Are you ok with installing
your own patches?
///jon
> -Original Message-
> From: XIANG Haiming [mailto:haiming.xi...@alcatel-sbell.com.cn]
> Sent: Sunday, 20 November, 2016 21:35
> To: tipc-discussion@lists.sourceforge.net
>
ition used for determining connection congestion.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index db32777..41f0138 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/so
> -Original Message-
> From: Holger Brunck [mailto:holger.bru...@keymile.com]
> Sent: Monday, 28 November, 2016 07:41
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net
> Subject: Re: [tipc-discussion] TIPC link statistic
>
> Hi
> -Original Message-
> From: Holger Brunck [mailto:holger.bru...@keymile.com]
> Sent: Monday, 28 November, 2016 09:22
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net
> Subject: Re: [tipc-discussion] TIPC link statistic
>
> Hi
> -Original Message-
> From: Holger Brunck [mailto:holger.bru...@keymile.com]
> Sent: Monday, 28 November, 2016 09:49
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net
> Subject: Re: [tipc-discussion] TIPC link statistic
>
> O
On 11/28/2016 10:32 AM, Holger Brunck wrote:
> On 28/11/16 15:55, Jon Maloy wrote:
>>>> The explanation is simple: the patch is not applied on net-next yet, only
>>>> on net.
>>> It normally takes a few days before David re-applies fixes to net back to
> -Original Message-
> From: Holger Brunck [mailto:holger.bru...@keymile.com]
> Sent: Thursday, 24 November, 2016 09:48
> To: tipc-discussion@lists.sourceforge.net
> Subject: [tipc-discussion] TIPC link statistic
>
> Hi all,
> I got a basic question to the link statistic printed out from
The comment block in socket.c describing the locking policy is
obsolete, and does not reflect current reality. We remove it in this
commit.
Since the current locking policy is much simpler and follows a
mainstream approach, we see no need to add a new description.
Signed-off-by: Jon Maloy
even when the
link returns a congestion code means that the sending socket code can
be simplified. Also, since this is a good opportunity to get rid of the
obsolete 'mtu change' condition in the three socket send functions, we
now choose to refactor those functions completely.
Signed-off-by: Jon
also add a couple of new
functions which will come to use in the next commits.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/name_table.c | 100 --
net/tipc/name_table.h | 21 ---
net/tipc/socket.c | 8 ++--
3
We fix a very real starvation problem that may occur when the link level
runs into send buffer congestion. At the same time we make the
interaction between the socket and link layer simpler and more
consistent.
Jon Maloy (3):
tipc: unify tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg
now
introduce a new macro tipc_wait_for_cond() where the wakeup condition
can be stated as an argument to the call. This macro replaces all
current and future uses of the two functions, which can now be
eliminated.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/socket.c
I am having some new doubts about our current link congestion criteria. See
below.
///jon
> -Original Message-
> From: Jon Maloy [mailto:jon.ma...@ericsson.com]
> Sent: Monday, 21 November, 2016 09:57
> To: tipc-discussion@lists.sourceforge.net; Parthasarath
Hi Xiang,
Although the version you are using has the same number (I am planning to step
it to 3.0.0 soon) as the current one in the latest kernels (4.x), it is a very
different species indeed. Almost all code has been rewritten, and in some cases
more than once. I would strongly suggest you
Hi Amar,
The claim that TIPC is compatible between different kernel versions is
true, and we always test for backwards compatibility when we introduce
changes that may cause compatibility problems. However, you kernel 3.2.0
i on node 1.1.6 is *very* old, and I don't think anybody of us is
As a further preparation for the upcoming 'replicast' functionality,
we add some necessary structs and functions for looking up and returning
a list of all nodes that host destinations for a given multicast message.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c
node list
- Moved definition of node destination list from to bcast.{h,c}
Jon Maloy (4):
tipc: add function for checking broadcast support in bearer
tipc: add functionality to lookup multicast destination nodes
tipc: introduce replicast as transport option for multicast
tipc: make replic
by replicating and sending the packets over as
many unicast links as needed to reach all identified destinations.
We now introduce a new TIPC link-level 'replicast' service that does
this.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c
in the three socket send functions, we
now choose to refactor those functions completely.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/bcast.c | 2 +-
net/tipc/link.c | 66 +--
net/tipc/msg.h| 2 -
net/tipc/node.c | 2 +-
net/tipc/socket.c
now
introduce a new macro tipc_wait_for_cond() where the wakeup condition
can be stated as an argument to the call. This macro replaces all
current and future uses of the two functions, which can now be
eliminated.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/socket.c
are congested. This
seems to have a positive effect on performance.
Jon Maloy (3):
tipc: unify tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg()
functions
tipc: modify struct tipc_plist to be more versatile
tipc: reduce risk of user starvation during link congestion
net/tipc
it am *.eml" and I get some error (detailed info refer
> to patch_result.txt)
>
> Please help me to analyze these error. Thank you.
>
>
>
>
> -Original Message-
> From: Ying Xue [mailto:ying....@windriver.com]
> Sent: 2016年12月12日 17:18
> To: XIANG Ha
> -Original Message-
> From: Ying Xue [mailto:ying@windriver.com]
> Sent: Tuesday, 13 December, 2016 06:04
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com&
> -Original Message-
> From: Ying Xue [mailto:ying@windriver.com]
> Sent: Tuesday, 13 December, 2016 07:39
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com&
also add a couple of new
functions which will come to use in the next commits.
Acked-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/
We fix a very real starvation problem that may occur when a link
encounters send buffer congestion. At the same time we make the
interaction between the socket and link layer simpler and more
consistent.
Jon Maloy (3):
tipc: unify tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg
in the three socket send functions, we
now choose to refactor those functions completely.
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/t
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Friday, 13 January, 2017 05:14
> To: tipc-discussion@lists.sourceforge.net; Jon Maloy <jon.ma...@ericsson.com>;
> Ying Xue <ying@windriver.com>; ru...@innovsys.com
> Subject: [PATCH net v1 1
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Friday, 13 January, 2017 04:24
> To: Jon Maloy <jon.ma...@ericsson.com>; tipc-discussion@lists.sourceforge.net;
> Ying Xue <ying@windriver.com>
> Subject: Re: [tipc-discussion] [net-next v3
58.572031] RSP
> [ 58.662814] ---[ end trace fa57695d3ce8757f ]---
> [ 58.663875] Kernel panic - not syncing: Fatal exception in interrupt
> [ 58.664872] Kernel Offset: disabled
> [ 58.664872] ---[ end Kernel panic - not syncing: Fatal exception in
> interrupt
>
> regards
limit. This reduces the risk of higher levels
starving out lower levels.
Jon Maloy (3):
tipc: unify tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg()
functions
tipc: modify struct tipc_plist to be more versatile
tipc: reduce risk of user starvation during link congestion
net/tipc
even when the
link returns a congestion code means that the sending socket code can
be simplified. Also, since this is a good opportunity to get rid of the
obsolete 'mtu change' condition in the three socket send functions, we
now choose to refactor those functions completely.
Signed-off-by: Jon
now
introduce a new macro tipc_wait_for_cond() where the wakeup condition
can be stated as an argument to the call. This macro replaces all
current and future uses of the two functions, which can now be
eliminated.
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/tipc/socket.c
> -Original Message-
> From: Parthasarathy Bhuvaragan
> Sent: Monday, 05 December, 2016 15:11
> To: Jon Maloy <ma...@donjonn.com>; Jon Maloy <jon.ma...@ericsson.com>;
> tipc-discussion@lists.sourceforge.net; Ying Xue <ying@windriver.com>
> Cc
/article.gmane.org/gmane.network.tipc.general/4380
fix the problem, so no need to send patch for fix link_timeout() deadlock
warming.
Signed-off-by: Wang Weidong <wangweido...@huawei.com>
Signed-off-by: Ding Tianhong <dingtianh...@huawei.com>
Acked-by: Ying Xue <ying....@windri
-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/server.c | 15 ---
1 file changed, 12 insertions(
ver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/eth_media.c | 6 +++---
net/tipc/ib_media.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/tipc/eth_media.c b/net/tipc/eth_
y fail if the
interface names contains special characters. We change the lookup
method to iterate over the list of nodes and compare the link
names.
Signed-off-by: Erik Hugne <erik.hu...@ericsson.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <j
ts use is as unnecessary as
using auto to declare automatic/local variables in a block.
Signed-off-by: Joe Perches <j...@perches.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/irda/irnet/irnet.h | 15 ++---
net/l2tp/l
iewed-by: Ying Xue <ying@windriver.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/bcast.c | 6 --
net/tipc/bearer.c| 33 ++
s NULL pointer
Signed-off-by: Ying Xue <ying@windriver.com>
Signed-off-by: Andreas Bofjäll <andreas.bofj...@ericsson.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <d
ssages are built and sent.
Signed-off-by: Ying Xue <ying@windriver.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/link.c | 25
where this is what really is meant.
Note that this change is cosmetic only, and no runtime behaviour
changes are made here.
Signed-off-by: Ying Xue <ying@windriver.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
icious or buggy. Either way, the correct behavior is now
to reset the link instead of trying to revert its sequence number.
So, this is what we do in this commit.
Signed-off-by: Erik Hugne <erik.hu...@ericsson.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by:
kernel coding
style.
Signed-off-by: Ying Xue <ying@windriver.com>
Reviewed-by: Paul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/link.c | 28 ++
ul Gortmaker <paul.gortma...@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
---
net/tipc/bearer.c| 14 +++---
net/tipc/bearer.h| 2 +-
net/tipc/eth_media.c | 6 +++---
net/tipc/ib_media.c |
On 12/06/2016 03:49 AM, Parthasarathy Bhuvaragan wrote:
> On 11/29/2016 06:03 PM, Jon Maloy wrote:
>> The functions tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg() are very
>> similar. The latter function is also called from two locations, and
>> there will be more in the
in the three socket send functions, we
now choose to refactor those functions completely.
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com>
Acked-by: Ying Xue <ying@windriver.com>
Signed-off-by: Jon Maloy <jon.ma...@ericsson.com>
---
net/t
We fix a very real starvation problem that may occur when a link
encounters send buffer congestion. At the same time we make the
interaction between the socket and link layer simpler and more
consistent.
Jon Maloy (3):
tipc: unify tipc_wait_for_sndpkt() and tipc_wait_for_sndmsg
201 - 300 of 969 matches
Mail list logo
