simplify stale link failure criteria")
Reported-by: Hoang Le
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 92 -
net/tipc/msg.h | 8 +++--
2 files changed, 57 insertions(+), 43 dele
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 29 ++---
net/tipc/msg.c | 4 ++--
2 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 6cc75ffd9e2c..22ba0c8af3a8 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
reover, since now we have both the messages in hand, we can even
optimize the 'tipc_msg_bundle()' function, make bundle of a very large
(size ~ MSS) and small messages which is not with the current
algorithm, e.g. [1400-byte message] + [10-byte message] (MTU = 1500).
Signed-off-by: Tu
r message
comes, a new bundle is created and so on...
We will solve this issue radically by the 2nd patch of this series.
Fixes: 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Reported-by: Hoang Le
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
r message
comes, a new bundle is created and so on...
We will solve this issue radically by another patch.
Fixes: 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Reported-by: Hoang Le
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/link.c |
H' command will remove all existing keys if any.
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc_netlink.h | 4 ++
net/tipc/netlink.c| 16 -
net/tipc/node.c | 133 ++
net/tipc/node.h | 2 +
or interface can be disabled in the meanwhile.
If that happens, the bearer will be released then when the crypto
operation is completed and 'tipc_bearer_put()' is called.
Signed-off-by: Tuong Lien
---
net/tipc/bearer.c | 23 ++-
net/tipc/bearer.h | 3 +++
2 file
gned-off-by: Tuong Lien
---
net/tipc/node.c | 103
net/tipc/node.h | 3 ++
2 files changed, 77 insertions(+), 29 deletions(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index f2e3cf70c922..2eeffc380e8f 100644
--- a/net/tipc/node.c
+++ b
The new structure 'tipc_aead_key' is added to the 'tipc.h' for user to
be able to transfer a key to TIPC in kernel. Netlink will be used for
this purpose in the later commits.
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc.h | 21 +
1 file ch
s. With the support from hardware
crypto i.e. the Intel AES-NI CPU instructions, the throughput increases
upto ~85% for small messages and ~55% for large messages.
MAINTAINERS | add two new files 'crypto.h' & 'crypto.c' in tipc
Signed-off-by: Tuong Lien
---
net/tipc/Makefile
This series provides TIPC encryption feature, kernel part. There will be
another one in the 'iproute2/tipc' for user space to set key.
Tuong Lien (5):
tipc: add reference counter to bearer
tipc: enable creating a "preliminary" node
tipc: add new AEAD key structure
- If NODEID is own node, the key is used for message encryption (TX)
from the node. Whereas, if NODEID is a peer node, the key is for
message decryption (RX) from that peer node.
This is the 'per-node-key' mode that each nodes in the cluster has its
specific (TX) key.
Signed-off-by: Tuong Li
e the overheads to zero.
Moreover, since now we have both the messages in hand, we can even
optimize the 'tipc_msg_bundle()' function, make bundle of a very large
(size ~ MSS) and small messages which is not with the current algorithm
e.g. [1400-byte message] + [10-byte message] (MTU = 1500
q, the link synching will just
start and stop shortly on the peer side.
The patch is backward compatible.
Acked-by: Jon Maloy
Tested-by: Hoang Le
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/net
pective of when the subscription is issued. This turns out to be
easy to fix. We now add functionality to ensure that publication events
always are issued in the same temporal order as the corresponding
bindings were performed.
Acked-by: Jon Maloy
Signed-off-by: Tuong Li
0).
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 59 +++---
net/tipc/msg.c | 153 +---
net/tipc/msg.h | 5 +-
3 files changed, 113 insertions(+), 104 deletions(-)
diff --g
v2: rebase
Signed-off-by: Tuong Lien
---
net/tipc/node.c | 103 +++-
net/tipc/node.h | 1 +
2 files changed, 73 insertions(+), 31 deletions(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 4b60928049ea..5d5c95c9b4e6 100644
--- a/net/
This series provides TIPC encryption feature, kernel part. There will be
another one in the 'iproute2/tipc' for user space to set key.
Tuong Lien (5):
tipc: add reference counter to bearer
tipc: enable creating a "preliminary" node
tipc: add new AEAD key structure
uot;TIPC_CRYPTO"
in the kernel configuration to enable/disable the new code when needed.
v2: rebase, add new kernel option ("TIPC_CRYPTO")
MAINTAINERS | add two new files 'crypto.h' & 'crypto.c' in tipc
Signed-off-by: Tuong Lien
---
net/tipc/Kconfig | 12
or interface can be disabled in the meanwhile.
If that happens, the bearer will be released then when the crypto
operation is completed and 'tipc_bearer_put()' is called.
Signed-off-by: Tuong Lien
---
net/tipc/bearer.c | 14 +-
net/tipc/bearer.h | 3 +++
2 files changed
H' command will remove all existing keys if any.
v2: rebase, add new kernel option ("TIPC_CRYPTO")
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc_netlink.h | 8 +++
net/tipc/netlink.c| 20 +-
net/tipc/node.c | 135 ++
The new structure 'tipc_aead_key' is added to the 'tipc.h' for user to
be able to transfer a key to TIPC in kernel. Netlink will be used for
this purpose in the later commits.
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc.h | 21 +
1 file ch
uot;TIPC_CRYPTO"
in the kernel configuration to enable/disable the new code when needed.
v2: rebase, add new kernel option ("TIPC_CRYPTO")
v3: remove the "ifdef/else" for the bearer_xmit()
MAINTAINERS | add two new files 'crypto.h' & 'crypto.c' in tipc
d a round-robin fashion for it.
Besides, since now we have the 'max' value, we can even improve the
searching for a next range matching e.g. in case of multicast, so get
rid of the unneeded looping over all the nodes in the tree.
Signed-off-by: Tuong Lien
---
net/tipc/name_table.c |
q, the link synching will just
start and stop shortly on the peer side.
The patch is backward compatible.
Acked-by: Jon Maloy
Tested-by: Hoang Le
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/net
d-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/node.c | 103 +++-
net/tipc/node.h | 1 +
2 files changed, 73 insertions(+), 31 deletions(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 1f158451
The new structure 'tipc_aead_key' is added to the 'tipc.h' for user to
be able to transfer a key to TIPC in kernel. Netlink will be used for
this purpose in the later commits.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
include/ua
This series provides TIPC encryption feature, kernel part. There will be
another one in the 'iproute2/tipc' for user space to set key.
Tuong Lien (5):
tipc: add reference counter to bearer
tipc: enable creating a "preliminary" node
tipc: add new AEAD key structure
or interface can be disabled in the meanwhile.
If that happens, the bearer will be released then when the crypto
operation is completed and 'tipc_bearer_put()' is called.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bearer.c | 14 +-
net/t
H' command will remove all existing keys if any.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc_netlink.h | 4 ++
net/tipc/netlink.c| 18 -
net/tipc/node.c | 135 +++
uot;TIPC_CRYPTO"
in the kernel configuration to enable/disable the new code when needed.
MAINTAINERS | add two new files 'crypto.h' & 'crypto.c' in tipc
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/Kconfig | 12 +
net/tipc/Makefi
This series provides TIPC encryption feature, kernel part. There will be
another one in the 'iproute2/tipc' for user space to set key.
v2: add select crypto 'aes(gcm)' for TIPC_CRYPTO in Kconfig
Tuong Lien (5):
tipc: add reference counter to bearer
tipc: enable creating
The new structure 'tipc_aead_key' is added to the 'tipc.h' for user to
be able to transfer a key to TIPC in kernel. Netlink will be used for
this purpose in the later commits.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
include/ua
or interface can be disabled in the meanwhile.
If that happens, the bearer will be released then when the crypto
operation is completed and 'tipc_bearer_put()' is called.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bearer.c | 14 +-
net/t
d-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/node.c | 99 +
net/tipc/node.h | 1 +
2 files changed, 73 insertions(+), 27 deletions(-)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index b66d2f67b1dd..43d12a63
H' command will remove all existing keys if any.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
include/uapi/linux/tipc_netlink.h | 4 ++
net/tipc/netlink.c| 18 -
net/tipc/node.c | 135 +++
uot;TIPC_CRYPTO"
in the kernel configuration to enable/disable the new code when needed.
MAINTAINERS | add two new files 'crypto.h' & 'crypto.c' in tipc
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/Kconfig | 15 +
net/tipc/Makefi
The series consists of two individual patches which were sent earlier
but now v2 with some minor updates.
Tuong Lien (2):
tipc: support in-order name publication events
tipc: fix name table rbtree issues
net/tipc/name_table.c | 326 +-
net
. not fixed) & call
the service_range_match_first() directly as suggested by Jon; rebase to
make a series.
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/name_table.c | 279 --
1 file changed, 179 insertions(+), 100 deletions(-)
di
ven if users set their subscription filter to 'TIPC_SUB_PORTS'.
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/name_table.c | 47 +++
net/tipc/name_table.h | 4
2 files changed, 43 insertions(+), 8 deletions(-)
diff --git a/
pective of when the subscription is issued. This turns out to be
easy to fix. We now add functionality to ensure that publication events
always are issued in the same temporal order as the corresponding
bindings were performed.
Acked-by: Jon Maloy
Signed-off-by: Tuong Li
inline
function.
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/name_table.c | 53 +++
net/tipc/name_table.h | 4
2 files changed, 49 insertions(+), 8 deletions(-)
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
inde
r nodes.
- If NODEID is own node, the key is used for message encryption (TX)
from the node. Whereas, if NODEID is a peer node, the key is for
message decryption (RX) from that peer node. This is the 'per-node-key'
mode that each nodes in the cluster has its specific (TX) key.
Ac
with inline
function.
v3: reuse 'time_after32()' instead of reinventing the same exact code.
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/name_table.c | 51 +++
net/tipc/name_table.h | 4
2 files changed, 47 insertions(+
27; will be increased & decreased
correctly and the sock object can be released later.
Fixes: 0d5fcebf3c37 ("tipc: refactor tipc_sk_timeout() function")
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/tipc
should not face a
link congestion, there is no need to touch the socket 'cong_link_cnt'
either. In addition, in the event of any error (e.g. -ENOBUFS), we will
purge the entire payload message queue and make a return immediately.
Fixes: c55c8edafa91 ("tipc: smooth change between
#x27; and its header will not be modified by anyone.
Fixes: 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff -
other header fields' handling.
Fixes: f73b12812a3d ("tipc: improve throughput between nodes in netns")
Signed-off-by: Tuong Lien
---
net/tipc/discover.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index b043e8c6
searching appoarch to solve the
issues above. Another benefit from this is that we can now improve the
searching for a next range matching e.g. in case of multicast, so get
rid of the unneeded looping over all nodes in the tree.
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/name_ta
This series consists of some bug-fixes for TIPC.
Tuong Lien (4):
tipc: fix name table rbtree issues
tipc: fix potential hanging after b/rcast changing
tipc: fix retrans failure due to wrong destination
tipc: fix use-after-free in tipc_disc_rcv()
net/tipc/bcast.c | 24 +++--
net
should not face a
link congestion, there is no need to touch the socket 'cong_link_cnt'
either. In addition, in the event of any error (e.g. -ENOBUFS), we will
purge the entire payload message queue and make a return immediately.
Fixes: c55c8edafa91 ("tipc: smooth ch
#x27; and its header will not be modified by anyone.
Fixes: 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 32 ++--
1 file changed, 18 insertions(+), 14
other header fields' handling.
Fixes: f73b12812a3d ("tipc: improve throughput between nodes in netns")
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/discover.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/tipc/discover.c b/net
building & sending a message but then finally
gets an unexpected result (e.g. '-EPIPE').
This commit fixes the issue by returning the corresponding error code
if any when the wait process is waken up.
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 6 --
1 file changed, 4
other socket states;
fix a memleak issue (- reported by 'Hoang Huu Le').
--
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 53 -
1 file changed, 32 insertions(+), 21 deletions(-)
diff --git a/net/tipc/socket.c b/ne
x27;key' structure in the 'union'
form instead.
Fixes: 24bee3bf9752 ("tipc: add new commands to set TIPC AEAD key")
Reported-by: Stephen Hemminger
Signed-off-by: Tuong Lien
---
tipc/node.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tipc/node.c b
lished. Otherwise, either the socket
error code if any or '-ETIMEDOUT'/'-EINTR' will be returned
correspondingly.
-
v2: changed after discussing with Ying
-
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ns for such socket
messages because they are 'dest-droppable' by default.
In addition, the new code makes the other socket states clear
(e.g.'TIPC_LISTEN') and treats as a separate case to avoid misbehaving.
Acked-by: Ying Xue
Acked-by: Jon M
T'/'-EINTR' will be returned correspondingly.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 6ebd809ef207..f9b4fb92c0b1 100
ll get '-EPIPE' but the socket is still able to read the
messages existing in its receive queue.
Note: This solution doesn't break the previous one as it deals with a
different situation that the socket state is 'DISCONNECTING' but has no
error (i.e. sk->sk_err = 0).
Fi
ll get '-EPIPE' but the socket is still able to read the
messages existing in its receive queue.
Note: This solution doesn't break the previous one as it deals with a
different situation that the socket state is 'DISCONNECTING' but has no
error (i.e. sk->sk_err = 0).
Fixe
Tuong Lien (2):
tipc: add Gap ACK blocks support for broadcast link
tipc: enable broadcast retransmission via unicast
net/tipc/bcast.c | 16 +-
net/tipc/bcast.h | 4 +-
net/tipc/link.c | 442 +-
net/tipc/link.h | 8 +-
net/tipc
17.67s
Without the patch:
$ time tipc-pipe --mc --rdm --data_size 123 --data_num 150
real5m 28.80s
user0m 0.85s
sys 0m 3.62s
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 9 +-
net/tipc/link.c | 440 +--
net/tipc/link
etruni
Default is '0', i.e. the broadcast retransmission still works as usual.
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 11 ---
net/tipc/bcast.h | 4 +++-
net/tipc/link.c | 10 ++
net/tipc/link.h | 3 ++-
net/tipc/node.c | 2 +-
net/tipc/sysctl.c | 9 ++
etruni
Default is '0', i.e. the broadcast retransmission still works as usual.
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 11 ---
net/tipc/bcast.h | 4 +++-
net/tipc/link.c | 8 +---
net/tipc/link.h | 3 ++-
net/tipc/node.c | 2 +-
net/tipc/sysctl.c | 9 ++
retrans:0
Congestion link:0 Send queue max:0 avg:0
In addition, the broadcast-receiver link statistics can be reset in the
usual way via netlink by specifying that link name in command.
Note: the 'tipc_link_name_ext()' is removed because the link name can
now be retrieved simply via t
In the previous commit ("tipc: add Gap ACK blocks support for broadcast
link"), we have removed the following link trace events due to the code
changes:
- tipc_link_bc_ack
- tipc_link_retrans
This commit adds them back along with some minor changes to adapt to
the new code.
Signed-off
resh' is lowered.
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 467c53a1fb5c..d4675e922a8f 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -1065,7 +1065,7 @@ static void tipc_link_u
17.67s
Without the patch:
$ time tipc-pipe --mc --rdm --data_size 123 --data_num 150
real8m 27.94s
user0m 0.55s
sys 0m 2.38s
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 9 +-
net/tipc/link.c | 438 +-
retrans:0
Congestion link:0 Send queue max:0 avg:0
In addition, the broadcast-receiver link statistics can be reset in the
usual way via netlink by specifying that link name in command.
Note: the 'tipc_link_name_ext()' is removed because the link name can
now be retrieved simply via t
In the previous commit ("tipc: add Gap ACK blocks support for broadcast
link"), we have removed the following link trace events due to the code
changes:
- tipc_link_bc_ack
- tipc_link_retrans
This commit adds them back along with some minor changes to adapt to
the new code.
Signed-off
etruni
Default is '0', i.e. the broadcast retransmission still works as usual.
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 11 ---
net/tipc/bcast.h | 4 +++-
net/tipc/link.c | 8 +---
net/tipc/link.h | 3 ++-
net/tipc/node.c | 2 +-
net/tipc/sysctl.c | 9 ++
s i.e. broadcast rcv stats dumping.
Thanks alot!
Tuong Lien (4):
tipc: introduce Gap ACK blocks for broadcast link
tipc: add back link trace events
tipc: enable broadcast retrans via unicast
tipc: add support for broadcast rcv stats dumping
net/tipc/bcast.c | 22 ++-
net/tipc/bcast.h
max:0 avg:0
$ tipc l st re l broadcast-link:1001002
$ tipc l st sh l broadcast-link:1001002
Link
Window:50 packets
RX packets:0 fragments:0/0 bundles:0/0
TX packets:0 fragments:0/0 bundles:0/0
RX naks:0 defs:0 dups:0
TX naks:0 acks:0 retrans:0
Congestion link:0 Send queue max:0 avg:0
Signed
which indicates in seconds how long a peer down node should be removed.
The default value is 300 i.e. 5 mins, while a value of '0' will disable
the auto removal feature.
Signed-off-by: Tuong Lien
---
net/tipc/core.h | 1 +
net/tipc/node.c | 15 +--
net/tipc/sysctl.c
hresh' is lowered.
Fixes: 16ad3f4022bb ("tipc: introduce variable window congestion control")
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 467c53a1fb5c..d
le cannot be removed (unless the objectes are somehow forced
to release first);
The commit fixes the issue by closing the connection if the 'recvmsg()'
returns '0' i.e. when the peer is shutdown gracefully. It also includes
the other unexpected cases.
Signed-off-by: Tuong Lien
Hi Jon, all,
Here are the patches for the Nagle issues that I mentioned in the last
meeting, please take a look and give me feedback.
Thanks a lot!
BR/Tuong
Tuong Lien (2):
tipc: fix large latency in smart Nagle streaming
tipc: add test for Nagle algorithm effectiveness
net/tipc/msg.c
timize code
v3: rebase to non debug
v4: rename patch subject
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 43 ---
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 693e8902161e..4e71774528ad 10064
s messages without a break, so Nagle would still take in effect.
Signed-off-by: Tuong Lien
---
net/tipc/msg.c| 3 ---
net/tipc/msg.h| 14 +++--
net/tipc/socket.c | 60 ---
3 files changed, 60 insertions(+), 17 deletions(-)
di
le cannot be removed (unless the objects are somehow forced
to release first);
The commit fixes the issue by closing the connection if the 'recvmsg()'
returns '0' i.e. when the peer is shutdown gracefully. It also includes
the other unexpected cases.
Acked-by: Jon Maloy
Acked
Hi Jon, all,
There are a couple of issues with our service subscriptions and here is
the bug fixes, please help review before I send to net.
Thanks a lot!
BR/Tuong
Tuong Lien (2):
tipc: fix memory leak in service subscripting
tipc: fix failed service subscription deletion
net/tipc
ased all
references.
This commit fixes the issue by simply adding one test if the connection
remains in 'connected' state soon after we obtain the connection's lock
then a subscription object can be created as usual, otherwise we ignore
it.
Reported-by: Thang Ngo
Signed-off-by: Tuong Lien
ime later. Meanwhile,
the number of available subscriptions may be exhausted.
This commit fixes the two issues above, so as needed a subscription can
be deleted correctly.
Signed-off-by: Tuong Lien
---
net/tipc/topsrv.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/net
ime later. Meanwhile,
the number of available subscriptions may be exhausted.
This commit fixes the two issues above, so as needed a subscription can
be deleted correctly.
v2: define a new macro to write sub field value (- Jon's comment)
Signed-off-by: Tuong Lien
---
net/tipc/subscr.h | 10
ime later. Meanwhile,
the number of available subscriptions may be exhausted.
This commit fixes the two issues above, so as needed a subscription can
be deleted correctly.
v2: define a new macro to write sub field value (- Jon's comment)
v3: break if the sub to be deleted has been found
Signe
Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/socket.c | 42 +++---
1 file changed, 31 insertions(+), 11 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 87466607097f..e370ad0edd76 100644
--- a/net/tipc/socket.c
+++ b/net/
This series adds patches to fix some issues in TIPC streaming & service
subscription.
Tuong Lien (3):
tipc: fix large latency in smart Nagle streaming
tipc: fix memory leak in service subscripting
tipc: fix failed service subscription deletion
net/tipc/socket.c
ased all
references.
This commit fixes the issue by simply adding one test if the connection
remains in 'connected' state right after we obtain the connection lock,
then a subscription object can be created as usual, otherwise we ignore
it.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Reported-by:
ime later. Meanwhile,
the number of available subscriptions may be exhausted.
This commit fixes the two issues above, so as needed a subscription can
be deleted correctly.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/subscr.h | 10 ++
net/tipc/topsrv.
he 'l->name'.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 6 ++---
net/tipc/bcast.h | 5 +++--
net/tipc/link.c| 65 +++---
net/tipc/link.h| 3 +--
net/tipc/msg.c | 9 +++
: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 3 +++
net/tipc/trace.h | 13 -
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index d29b9c531171..288c5670cfa5 100644
--- a/net/tipc/link.c
+++ b/net/t
etruni
Default is '0', i.e. the broadcast retransmission still works as usual.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 11 ---
net/tipc/bcast.h | 4 +++-
net/tipc/link.c | 10 ++
net/tipc/link.h | 3 ++-
net/ti
retransmissions via unicast which might be useful in
some cases.
Besides, the Nagle algorithm can now automatically 'adjust' itself
depending on the specific network condition a stream connection runs by
the last patch.
Tuong Lien (5):
tipc: introduce Gap ACK blocks for broadcast lin
17.67s
Without the patch:
$ time tipc-pipe --mc --rdm --data_size 123 --data_num 150
real8m 27.94s
user0m 0.55s
sys 0m 2.38s
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/bcast.c | 9 +-
net/tipc/link.c | 425 +++
s messages without a break, so Nagle would still take in effect.
Acked-by: Ying Xue
Acked-by: Jon Maloy
Signed-off-by: Tuong Lien
---
net/tipc/msg.c| 3 ---
net/tipc/msg.h| 14 ++--
net/tipc/socket.c | 64 ---
3 files changed,
max:0 avg:0
$ tipc l st re l broadcast-link:1001002
$ tipc l st sh l broadcast-link:1001002
Link
Window:50 packets
RX packets:0 fragments:0/0 bundles:0/0
TX packets:0 fragments:0/0 bundles:0/0
RX naks:0 defs:0 dups:0
TX naks:0 acks:0 retrans:0
Congestion link:0 Send queue max:0 avg:0
Acked-
gth is
no longer accurate.
This commit resolves the issue by explicitly checking whether the queue
contains a 'MSG_FRAGMENTER' message instead.
Signed-off-by: Tuong Lien
---
net/tipc/link.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/tipc/link.c b
least one skb to go with the
socket header and optional data section that may be empty like what we
had with the 'tipc_msg_build()'.
Reported-by: syzbot+8eac6d030e7807c21...@syzkaller.appspotmail.com
Fixes: c0bceb97db9e ("tipc: add smart nagle feature")
Signed-off-by: Tuo
This reverts commit 441870ee4240cf67b5d3ab8e16216a9ff42eb5d6.
Like the previous patch in this series, we revert the above commit that
causes similar issues with the 'aead' object.
Signed-off-by: Tuong Lien
---
net/tipc/crypto.c | 1 -
1 file changed, 1 deletion(-)
diff --git
1 - 100 of 223 matches
Mail list logo
