Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Martin Thomson
Thanks Kazuho! Experiences like your own are critical at this stage. It is encouraging to see that there were so few problems. As for the key schedule, EKR and I have discussed taking a dump from one of our many test cases and putting that in a draft, including private keys and all the intermedia

Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Ilari Liusvaara
On Thu, Oct 13, 2016 at 03:17:32PM +0900, Kazuho Oku wrote: > TLDR: the spec. was clear and easy to implement, but some test vectors > and clarification on what constitutes a Handshake Context would have > helped. > > FWIW, please let me share my experience of implementing TLS 1.3. > > This month

Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Eric Rescorla
Kazuho, Thanks for the feedback. This is very helpful. On Wed, Oct 12, 2016 at 11:17 PM, Kazuho Oku wrote: > > I wrote my implementation by going through the draft. While writing my > code, I did not refer to other implementations except for looking into > OpenSSL to see if there was an optimize

Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Ilari Liusvaara
On Thu, Oct 13, 2016 at 12:18:03PM +0300, Ilari Liusvaara wrote: > On Thu, Oct 13, 2016 at 03:17:32PM +0900, Kazuho Oku wrote: > > TLDR: the spec. was clear and easy to implement, but some test vectors > > and clarification on what constitutes a Handshake Context would have > > helped. > > > > FWI

Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Kazuho Oku
Hi Martin, 2016-10-13 16:07 GMT+09:00 Martin Thomson : > Thanks Kazuho! > > Experiences like your own are critical at this stage. It is encouraging to > see that there were so few problems. > > As for the key schedule, EKR and I have discussed taking a dump from one of > our many test cases and pu

[TLS] Which SHA function should I use for CertificateVerify of a rsa_pkcs1_sha1 certificate?

2016-10-13 Thread Kazuho Oku
Hi, In TLS 1.3, my understanding is that the digest function negotiated using the Signature Algorithm should be used for generating CertificateVerify, since the draft states that: | Each SignatureScheme value lists a single signature algorithm that the client is willing to verify. | (section 4.2.

Re: [TLS] Which SHA function should I use for CertificateVerify of a rsa_pkcs1_sha1 certificate?

2016-10-13 Thread Kazuho Oku
Sorry for the fuss, I think I was confused. Now my interpretation of the draft is as follows. A server is expected to send a Certificate message that contains certificates using the signature algorithms specified by the client, with preference and exception rules defined in section 4.2.3 (Signatu

Re: [TLS] Newcomer’s Implementation Experience of TLS 1.3 Draft 16

2016-10-13 Thread Kazuho Oku
Hi Ilari, Thank you for trying picotls, and thank you very much for notifying me of the issues you found. I have fixed three issues you reported (i.e. SNI decode error, EC group check error, PKCS not included in Signature Algorithms). Regarding the crash, is your implementation available to publ