Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-07-09 Thread Nicholas Marriott
I'm not sure I see the point but if you feel strongly about this sure send me a diff and I'll have to decide ;-). On Sun, Jul 08, 2012 at 11:42:41PM +0200, Marcel Partap wrote: .. Ok then how about supporting both in code, while changing the man page to 'mouse-copy-mode' ? #regards...

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-07-08 Thread Nicholas Marriott
Sorry, I've been very busy so no time to look at this stuff but now I'm free all this week. But I'm not clear what is what - can you send me any diffs that are finished and working with an explanation of what they do? Thanks On Thu, Jun 21, 2012 at 06:32:48PM +0200, Marcel Partap wrote:

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-07-08 Thread Nicholas Marriott
Hi I don't much like mode-mouse as a name but now that it's there, I'm not sure we should just rename it and I don't think it's important enough to add translation table or whatever. On Sun, Jul 08, 2012 at 07:10:00PM +0200, Marcel Partap wrote: But I'm not clear what is what - can you send

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-07-08 Thread Marcel Partap
.. Ok then how about supporting both in code, while changing the man page to 'mouse-copy-mode' ? #regards... -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
What exactly is the functionality you are missing Fabio? None about the mouse wheel actually. :) I just realized, though, that it could be coherent and handy to have a similar behavior while scrolling with the keyboard (hjkl, the arrow keys, or whatever one likes). When you have reached the

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On Thu, Jun 21, 2012 at 02:43:30PM +0200, Fabio Spelta wrote: What exactly is the functionality you are missing Fabio? None about the mouse wheel actually. :) I just realized, though, that it could be coherent and handy to have a similar behavior while scrolling with the keyboard

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
Taking a very quick look at this, does the following help? Yes, thanks, it works. The odd behavior is that if I have not scrolled the buffer upwards, I mean I am browsing the screen in copy mode without getting past the top line visible on the screen, either moving the wheel down or pressing

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Fabio Spelta
2012/6/21 Fabio Spelta spe...@gmail.com Taking a very quick look at this, does the following help? Yes, thanks, it works. The odd behavior is that if I have not scrolled the buffer upwards, I mean I am browsing the screen in copy mode without getting past the top line visible on the

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On 21 June 2012 15:01, Fabio Spelta spe...@gmail.com wrote: If I move up over the first visible line and start scrolling, then getting back works with the mouse wheel, and scrolling down with the keyboards puts me back to the first line and exits copy mode when I am on the bottom. Not

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
G, what the rush^^ have been working on this and here's what i have in tree right now. These are somewhat untested, will test and report back later... C: From a824632d2fb794fbc0e64d47fc15ef6e9e219b47 Mon Sep 17 00:00:00 2001 From: Marcel Partap mpar...@gmx.net Date: Wed, 20 Jun 2012 15:48:27

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Thomas Adam
On Thu, Jun 21, 2012 at 04:33:36PM +0200, Marcel Partap wrote: G, what the rush^^ have been working on this and here's what i have in tree right now. These are somewhat untested, will test and report back later... C: You need to check the logic for lines in input_mouse() -- holding down ctrl

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
You need to check the logic for lines in input_mouse() -- holding down ctrl and scrolling down all the way to the bottom of the window causes the server to crash. :) ANY scrolling caused crashing. Because fatalx(missing option); Well I put the option inbetween the other mouse-* options - in

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-21 Thread Marcel Partap
server to crash. :) uncrashed. From 7f588c64242b3c1d8a31d3bc6aaa1b590027b776 Mon Sep 17 00:00:00 2001 From: Marcel Partap mpar...@gmx.net Date: Thu, 21 Jun 2012 12:01:55 +0200 Subject: [PATCH 4/4] Cleaned up implementation of mouse wheel scrolling emulation. --- trunk/examples/tmux.vim |

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-20 Thread Fabio Spelta
Thomas Adam thomas at xteddy.org writes: Hi, Yes, this was synched in Openbsd patchset 1082. Look in svn trunk. Hello, I just fetched the latest (so far) version of the svn trunk (it's revision 2829) and the new option is not there. I can't grep mode-mouse-scroll-down in the sources

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-20 Thread Thomas Adam
On Wed, Jun 20, 2012 at 11:44:09AM +, Fabio Spelta wrote: Thomas Adam thomas at xteddy.org writes: Hi, Yes, this was synched in Openbsd patchset 1082. Look in svn trunk. Hello, I just fetched the latest (so far) version of the svn trunk (it's revision 2829) and the new

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-20 Thread marcel partap
Be as it may, what went in is rather only fixing odd behaviour.. What exactly is the functionality you are missing Fabio? -- #regards/marcel -- Live Security Virtual Conference Exclusive live event will cover all the

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-20 Thread Fabio Spelta
It's implicit; I never said it was an option you define or control. Being called an option, I supposed it was _optional_. :) I wonder if it could make sense in certain situations to actually being able to turn it off so to use the mouse wheel the old way. It is indeed just working as is.

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-05 Thread Thomas Adam
Hi, Yes, this was synched in Openbsd patchset 1082. Look in svn trunk. It's not in a released version of tmux yet. -- Thomas Adam On Jun 4, 2012 7:41 PM, Sébastien le Preste de Vauban ulpianoso...@gmail.com wrote: On Sun, Apr 01, 2012 at 02:50:20AM -0400, James Nylen wrote: The attached

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-06-04 Thread Sébastien le Preste de Vauban
On Sun, Apr 01, 2012 at 02:50:20AM -0400, James Nylen wrote: The attached patch adds a new option, mode-mouse-scroll-down, which allows the mouse wheel to scroll down past the end of the screen in copy mode.* If the option is enabled, copy mode will only be exited when the cursor

[PATCH] Allow using mouse to scroll down in copy mode

2012-04-01 Thread James Nylen
The attached patch adds a new option, mode-mouse-scroll-down, which allows the mouse wheel to scroll down past the end of the screen in copy mode. If the option is enabled, copy mode will only be exited when the cursor reaches the end of the buffer, instead of the default behavior (copy mode is

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-04-01 Thread Nicholas Marriott
Hi If this isn't the default already it's a bug, copy mode should be exited when you scroll off the bottom of the history entirely not off the bottom of the current visible screen. So no need for the option... On Sun, Apr 01, 2012 at 02:50:20AM -0400, James Nylen wrote: The attached patch

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-04-01 Thread James Nylen
I think there's a bug then. The attached patch fixes the issue. On Sun, Apr 1, 2012 at 4:29 AM, Nicholas Marriott nicholas.marri...@gmail.com wrote: Hi If this isn't the default already it's a bug, copy mode should be exited when you scroll off the bottom of the history entirely not off

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-04-01 Thread James Nylen
Updated patch with a now-unused variable removed. On Sun, Apr 1, 2012 at 5:06 AM, James Nylen jny...@gmail.com wrote: I think there's a bug then. The attached patch fixes the issue. On Sun, Apr 1, 2012 at 4:29 AM, Nicholas Marriott nicholas.marri...@gmail.com wrote: Hi If this isn't

Re: [PATCH] Allow using mouse to scroll down in copy mode

2012-04-01 Thread Nicholas Marriott
Applied, thanks. On Sun, Apr 01, 2012 at 05:10:10AM -0400, James Nylen wrote: Updated patch with a now-unused variable removed. On Sun, Apr 1, 2012 at 5:06 AM, James Nylen [1]jny...@gmail.com wrote: I think there's a bug then.* The attached patch fixes the issue. On