Re: [PATCH 00/14] Rework choose-mode internals.

2012-06-04 Thread Thomas Adam
Hi, On Sun, Jun 03, 2012 at 07:59:06PM +0100, Thomas Adam wrote: So some observations/ideas (in no particular order): * I don't like the free() callbacks to each cmd-choose-* file. Ideally we should probably look at centralising these where appropriate, perhaps in window_choose_free()?

[PATCH 00/14] Rework choose-mode internals.

2012-06-03 Thread Thomas Adam
This patch series reworks the choose-mode internals to stop using a literal u_int for identifying chosen elements to some data structure, and instead returns a pointer to a struct. Currently the choose-* commands are returned a u_int representing either a window or session or some other index