Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Nicholas Marriott
Makes sense thanks. But your fix still wraps in some cases, can't spot why immediately probably due to broken EOL tracking where _down moves the cursor to the end. How about this instead? Index: window-copy.c === RCS file: /cvs/src/us

Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Ben Boeckel
On Fri, Jul 05, 2013 at 16:56:33 +0100, Nicholas Marriott wrote: > Hi. What's the behaviour here before and after? Before, if you went "left" from the top-left corner was the top-right corner since (cy = = max(0, cy - 1); cx = end_of_line(cy);) was done. Something similar for the "right" of bottom

Re: [PATCH 3/6] Don't loop in copy mode on first and last lines

2013-07-05 Thread Nicholas Marriott
Hi. What's the behaviour here before and after? On Wed, Jun 12, 2013 at 02:17:57AM -0400, Ben Boeckel wrote: > Because we first move to the first column, then down, on the last line, > the first column is to "the right" of the last column. To fix this, the > current line is checked and if it chan

[PATCH 3/6] Don't loop in copy mode on first and last lines

2013-06-11 Thread Ben Boeckel
Because we first move to the first column, then down, on the last line, the first column is to "the right" of the last column. To fix this, the current line is checked and if it changed, *then* the start of the line motion is used. Similar logic is done for the first line. --- window-copy.c | 17 +