Re: [Toaster] [PATCH 00/10] delete builds,projects,recipes,layers

[Barros Pena, Belen]

Hi Michael,

This all works. There are only a few small UI issues with the branch,
which I've listed below.

Thanks!

Belén   

On 22/09/2016 17:55, "toaster-boun...@yoctoproject.org on behalf of
Michael Wood"  wrote:

>Work to implement deleting of builds projects recipes and layers.
>Includes a number of clean ups in affected areas.

* If a delete a build, I don't see the notification after the delete
process completes

* If I delete a custom image or a layer, the 'cancel' link still shows
while the object is being deleted. All delete actions (for builds,
projects, layers and custom images) should be modal, and we should remove
the 'cancel' button from all delete dialogs once you click the 'delete'
button. The idea being all deletions behave in exactly the same way.

* If I have only one custom image and I delete it, for some reason the
custom images page does not show the message we display for the empty
state. It does show if I refresh the page though. The same happens when I
delete the only project in toaster, which by the way is a case I forgot to
design for :/

* When I delete a layer, I am still landing on the project configuration
page. The idea would be to land on the 'all layers' page, so that once
more all delete behaviours are equal, and deleting something always lands
you in the parent node of the application structure (delete layer in all
layers, delete custom image in all custom images, delete project in all
projects, delete build in project builds).


>
>Obsoletes: 
> -[PATCH 0/4] clean ups, buildinfohelper fix and delete project patches
> -[PATCH v2 0/5] Couple of clean ups, fix for local layers in
>buildinfohelper and api and implementation of delete a project.
>
>Branch available at poky-contrib michaelw/toaster/delete_buttons
>
>Michael Wood (10):
>  toaster: Clean up and convert to rest api project edit and get calls
>  toaster: move MostRecentBuildsView to its own widget
>  toaster: libtoaster Add a global notification set/show mechanism
>  toaster: project page Implement front end feature to delete project
>  toaster: alerts and modals Avoid modals and alerts overlaying each
>other
>  toaster: Add backend API for deleting a build
>  toaster: Add front end controls for deleting a build
>  toaster: importlayer Convert success import to new notification system
>  toaster: customrecipe Add frontend feature to delete custom image
>recipe
>  toaster: layerdetails Update implementation of delete imported layer
>
> bitbake/lib/toaster/toastergui/api.py  | 312
>+
> .../toaster/toastergui/static/js/customrecipe.js   |  32 +++
> .../toaster/toastergui/static/js/importlayer.js|  59 +++-
> .../toaster/toastergui/static/js/layerDepsModal.js |  12 +-
> .../toaster/toastergui/static/js/layerdetails.js   |   7 +-
> .../lib/toaster/toastergui/static/js/libtoaster.js |  42 ++-
> .../toaster/toastergui/static/js/projectpage.js| 237 +++-
> .../toaster/toastergui/static/js/projecttopbar.js  |   6 +-
> .../lib/toaster/toastergui/static/js/tests/test.js |   7 +-
> bitbake/lib/toaster/toastergui/templates/base.html |   1 +
> .../toastergui/templates/basebuildpage.html| 138 ++---
> .../toastergui/templates/baseprojectpage.html  |   6 +
> .../toastergui/templates/builddashboard.html   |   2 +-
> .../toaster/toastergui/templates/customrecipe.html |  35 ++-
> .../toaster/toastergui/templates/layerdetails.html |   9 +-
> .../lib/toaster/toastergui/templates/project.html  |  35 ++-
> .../toastergui/templates/projecttopbar.html|   2 +-
> bitbake/lib/toaster/toastergui/urls.py |  11 +-
> bitbake/lib/toaster/toastergui/views.py| 131 +
> bitbake/lib/toaster/toastergui/widgets.py  | 141 --
> 20 files changed, 679 insertions(+), 546 deletions(-)
>
>-- 
>2.7.4
>
>-- 
>___
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster

-- 
___
toaster mailing list
toaster@yoctoproject.org
https://lists.yoctoproject.org/listinfo/toaster

Re: [Toaster] [PATCH 00/10] delete builds,projects,recipes,layers

[Michael Wood]

There are two browser tests which fail because the tests need updating. 
I will send some additional patches to fix this in a follow up/separate 
series.


On 22/09/16 17:55, Michael Wood wrote:

Work to implement deleting of builds projects recipes and layers.
Includes a number of clean ups in affected areas.

Obsoletes:
  -[PATCH 0/4] clean ups, buildinfohelper fix and delete project patches
  -[PATCH v2 0/5] Couple of clean ups, fix for local layers in buildinfohelper 
and api and implementation of delete a project.

Branch available at poky-contrib michaelw/toaster/delete_buttons

Michael Wood (10):
   toaster: Clean up and convert to rest api project edit and get calls
   toaster: move MostRecentBuildsView to its own widget
   toaster: libtoaster Add a global notification set/show mechanism
   toaster: project page Implement front end feature to delete project
   toaster: alerts and modals Avoid modals and alerts overlaying each
 other
   toaster: Add backend API for deleting a build
   toaster: Add front end controls for deleting a build
   toaster: importlayer Convert success import to new notification system
   toaster: customrecipe Add frontend feature to delete custom image
 recipe
   toaster: layerdetails Update implementation of delete imported layer

  bitbake/lib/toaster/toastergui/api.py  | 312 +
  .../toaster/toastergui/static/js/customrecipe.js   |  32 +++
  .../toaster/toastergui/static/js/importlayer.js|  59 +++-
  .../toaster/toastergui/static/js/layerDepsModal.js |  12 +-
  .../toaster/toastergui/static/js/layerdetails.js   |   7 +-
  .../lib/toaster/toastergui/static/js/libtoaster.js |  42 ++-
  .../toaster/toastergui/static/js/projectpage.js| 237 +++-
  .../toaster/toastergui/static/js/projecttopbar.js  |   6 +-
  .../lib/toaster/toastergui/static/js/tests/test.js |   7 +-
  bitbake/lib/toaster/toastergui/templates/base.html |   1 +
  .../toastergui/templates/basebuildpage.html| 138 ++---
  .../toastergui/templates/baseprojectpage.html  |   6 +
  .../toastergui/templates/builddashboard.html   |   2 +-
  .../toaster/toastergui/templates/customrecipe.html |  35 ++-
  .../toaster/toastergui/templates/layerdetails.html |   9 +-
  .../lib/toaster/toastergui/templates/project.html  |  35 ++-
  .../toastergui/templates/projecttopbar.html|   2 +-
  bitbake/lib/toaster/toastergui/urls.py |  11 +-
  bitbake/lib/toaster/toastergui/views.py| 131 +
  bitbake/lib/toaster/toastergui/widgets.py  | 141 --
  20 files changed, 679 insertions(+), 546 deletions(-)



--
___
toaster mailing list
toaster@yoctoproject.org
https://lists.yoctoproject.org/listinfo/toaster

[Toaster] [PATCH 00/10] delete builds,projects,recipes,layers

[Michael Wood]

Work to implement deleting of builds projects recipes and layers.
Includes a number of clean ups in affected areas.

Obsoletes: 
 -[PATCH 0/4] clean ups, buildinfohelper fix and delete project patches
 -[PATCH v2 0/5] Couple of clean ups, fix for local layers in buildinfohelper 
and api and implementation of delete a project.

Branch available at poky-contrib michaelw/toaster/delete_buttons

Michael Wood (10):
  toaster: Clean up and convert to rest api project edit and get calls
  toaster: move MostRecentBuildsView to its own widget
  toaster: libtoaster Add a global notification set/show mechanism
  toaster: project page Implement front end feature to delete project
  toaster: alerts and modals Avoid modals and alerts overlaying each
other
  toaster: Add backend API for deleting a build
  toaster: Add front end controls for deleting a build
  toaster: importlayer Convert success import to new notification system
  toaster: customrecipe Add frontend feature to delete custom image
recipe
  toaster: layerdetails Update implementation of delete imported layer

 bitbake/lib/toaster/toastergui/api.py  | 312 +
 .../toaster/toastergui/static/js/customrecipe.js   |  32 +++
 .../toaster/toastergui/static/js/importlayer.js|  59 +++-
 .../toaster/toastergui/static/js/layerDepsModal.js |  12 +-
 .../toaster/toastergui/static/js/layerdetails.js   |   7 +-
 .../lib/toaster/toastergui/static/js/libtoaster.js |  42 ++-
 .../toaster/toastergui/static/js/projectpage.js| 237 +++-
 .../toaster/toastergui/static/js/projecttopbar.js  |   6 +-
 .../lib/toaster/toastergui/static/js/tests/test.js |   7 +-
 bitbake/lib/toaster/toastergui/templates/base.html |   1 +
 .../toastergui/templates/basebuildpage.html| 138 ++---
 .../toastergui/templates/baseprojectpage.html  |   6 +
 .../toastergui/templates/builddashboard.html   |   2 +-
 .../toaster/toastergui/templates/customrecipe.html |  35 ++-
 .../toaster/toastergui/templates/layerdetails.html |   9 +-
 .../lib/toaster/toastergui/templates/project.html  |  35 ++-
 .../toastergui/templates/projecttopbar.html|   2 +-
 bitbake/lib/toaster/toastergui/urls.py |  11 +-
 bitbake/lib/toaster/toastergui/views.py| 131 +
 bitbake/lib/toaster/toastergui/widgets.py  | 141 --
 20 files changed, 679 insertions(+), 546 deletions(-)

-- 
2.7.4

-- 
___
toaster mailing list
toaster@yoctoproject.org
https://lists.yoctoproject.org/listinfo/toaster