Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Remy Maucherat
I've been informed by private email that I am terribly rude for making announcements of MinTC releases on the tomcat-dev list, and that I should not make any futher announcements. Sorry, but I consider it rude to post announcements about other projects on the Tomcat mailing list. I attach

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Remy Maucherat
Personally, I've rather enjoyed following MinTC's progress (OK, not really following, since I haven't actually looked at the code :). I could see how someone might think it rude to post the announcement on tomcat-user (since many people there are easily confused :), but IMHO MinTC is

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Jerome Bouat
I don't known well Tomcat 4 but I search for a Servlet container which: - can be used as a component of an application but does not impose a 'web server' structure to the application - is compliant with the latest Servlet standart (~ is an implementation reference) - disallows filesystem

DO NOT REPLY [Bug 6702] - jk_nt_service.exe -i cannot work

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6702. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Remy Maucherat
I don't known well Tomcat 4 but I search for a Servlet container which: - can be used as a component of an application but does not impose a 'web server' structure to the application - is compliant with the latest Servlet standart (~ is an implementation reference) - disallows

[Coyote] Coyote 1.0 Beta 8 available

2002-04-19 Thread Remy Maucherat
Coyote 1.0 Beta 8 is now available, and includes: - HTTP/1.1 protocol handler - JK 2 protocol handler, with support for the AJP 1.3 and 1.4 protocols - An adapter for Tomcat 3.3.x - An adapter for Tomcat 4.x Changes over Beta 7 include: - Fixed SSL configuration bugs with Tomcat 4.x in the

DO NOT REPLY [Bug 5735] - HTTP connector running out of processors under heavy load

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5735. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Rolf Veen
Remy Maucherat wrote: If many people want to see MinTC here, then it will happen even if I may not like it. +1 to MinTC here. Lets be friendly. And open. [ +1 * notCommiter == 0, I know ] Rolf. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail:

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread Ken . Horn
Another (non-committer) +1 for keeping MinTC on tomcat-dev. Having a (perhaps limited) web/servlet server in a jar is a great idea. If Catalina core, migrates to allow this without a MinTC, other than a special server.xml, then that's OK. MinTC will probably have served it's purpose, and will

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Bojan Smojver
On Fri, 2002-04-19 at 13:37, Craig R. McClanahan wrote: Even if the consensus is that these things were off topic, one way to certainly make them on topic would be a discussion of whether you'd want to propose contributing MinTC to the standard distribution (so that it could be built from

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Remy Maucherat
Another (non-committer) +1 for keeping MinTC on tomcat-dev. Having a (perhaps limited) web/servlet server in a jar is a great idea. If Catalina core, migrates to allow this without a MinTC, other than a special server.xml, then that's OK. MinTC will probably have served it's purpose, and

DO NOT REPLY [Bug 8295] New: - Session deserialization fails to load all classes correctly

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8295. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

[GUMP] Build Failure - jakarta-tomcat-4.0

2002-04-19 Thread Craig McClanahan
This email is autogenerated from the output from: http://jakarta.apache.org/builds/gump/2002-04-19/jakarta-tomcat-4.0.html Buildfile: build.xml deploy-prepare: deploy-static: deploy:

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Pier Fumagalli
Remy Maucherat [EMAIL PROTECTED] wrote: The only problem I see, is NOT discussing MinTC issues on tomcat-dev - I wholeheartedly agree with this. MinTC issues are not discussed around here, while I would love to follow its development (darn, not enough time?). Actually, I do care _more_ about

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread Ken . Horn
I have to admit not having read the MinTC source, however, I thought the tomcat community uses/develops multiple implementations of many interfaces. Most of the http/socket/auth?/config (xml file/ajp-webapp/admin) code is effectively multiple implementations of the same interfaces. Isn't the

RE: cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_service_iis.c

2002-04-19 Thread Ignacio J. Ortega
Update, after merging few dozens cvs conflicts :-) :-) , sorry bout that, I'll try to follow up your changes this evening ( here ), please wait for commits.. Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL

patch for tomcat rc script in RPM

2002-04-19 Thread Jason Corley
All, I'm not sure if this is worthwhile for anyone else but my company but myself and a coworker (Jason Maderios [EMAIL PROTECTED]) wrote a patch that saves the contents of the /var/log/tomcat3/tomcat.log file when tomcat is shutdown just in case we ever need the contents for future

RE: patch for tomcat rc script in RPM

2002-04-19 Thread GOMEZ Henri
Seems a good patch, I'm +1 and will include it at least on my rpm - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD...oOOo..(_)..oOOo... PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 -Original

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread GOMEZ Henri
The only problem I see, is NOT discussing MinTC issues on tomcat-dev - I wholeheartedly agree with this. MinTC issues are not discussed around here, while I would love to follow its development (darn, not enough time?). MinTC is an excellent idea but since it's not an Apache project, should

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_iis.h jk_service_iis.c

2002-04-19 Thread nacho
nacho 02/04/19 07:03:28 Modified:jk/native2/server/isapi jk_iis.h jk_service_iis.c Log: * Work in progress More cleanup, compiles again :) Revision ChangesPath 1.3 +14 -17jakarta-tomcat-connectors/jk/native2/server/isapi/jk_iis.h Index: jk_iis.h

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Rolf Veen
Remy Maucherat wrote: I will veto this (or vote against, if it's a majority vote). It has been very clear for a while that the Tomcat project has to provide one and only one servlet container for a particular version of the specifications. That would have been the best. But right now there

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread costinm
I am also interested in MinTC. But I must say I understand Remy's point about 'rudeness'. I don't like bloat and I would love to see more modularization ( in 4.x and 3.x and most of the programs I know ). But this should be done by contributing to the project, not by creating a fork. And if

[JK2] Win32 Signals

2002-04-19 Thread Ignacio J. Ortega
Hola a todos: I'm trying to get to compile the JNI part of JK2 in win32, again with my legendary naiveness ;), how is suppoussed we deal with signals in win32?? just add another ifdef here with a HAVE_UNIX_SIGNALS ? Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL

DO NOT REPLY [Bug 8297] New: - inetinfo.exe error ; Also no resource found (error 404)

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8297. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread costinm
I have to admit not having read the MinTC source, however, I thought the tomcat community uses/develops multiple implementations of many interfaces. Most of the http/socket/auth?/config (xml file/ajp-webapp/admin) code is effectively multiple implementations of the same interfaces. Isn't

RE: [JK2] Win32 Signals

2002-04-19 Thread GOMEZ Henri
I'm trying to get to compile the JNI part of JK2 in win32, again with my legendary naiveness ;), how is suppoussed we deal with signals in win32?? just add another ifdef here with a HAVE_UNIX_SIGNALS ? Could you use instead the SetConsoleCtrlHandler API ? -- To unsubscribe, e-mail:

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_service_iis.c

2002-04-19 Thread nacho
nacho 02/04/19 07:17:08 Modified:jk/native2/server/isapi jk_service_iis.c Log: Cleaning format, detabbify Revision ChangesPath 1.6 +4 -4 jakarta-tomcat-connectors/jk/native2/server/isapi/jk_service_iis.c Index: jk_service_iis.c

RE: [JK2] Win32 Signals

2002-04-19 Thread Ignacio J. Ortega
De: GOMEZ Henri [mailto:[EMAIL PROTECTED]] Enviado el: viernes 19 de abril de 2002 16:17 Could you use instead the SetConsoleCtrlHandler API ? Of course, that part is not a problem, but the other side, how can i deal with unix declarations and code ? it seems Java part is calling native

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Pier Fumagalli
GOMEZ Henri [EMAIL PROTECTED] wrote: - add MinTC as a tomcat 4 subproject and host here in Apache This cannot be done, as the layering structure of the ASF won't allow it. It can be hosted either in commons, either here (but then it would be swallowed by the TC project itself), or as a top

Re: [JK2] Win32 Signals

2002-04-19 Thread Attila Szegedi
It depends what those signals were used for in the UNIX environment. If that was for implementing inter-process communication (IPC), you'd be better off using Win32 IPC primitives (events, semaphors, mutexes - depends on usage). Of course, it again depends on whether you can control the source of

RE: [JK2] Win32 Signals

2002-04-19 Thread GOMEZ Henri
Could you use instead the SetConsoleCtrlHandler API ? Of course, that part is not a problem, but the other side, how can i deal with unix declarations and code ? it seems Java part is calling native to set some Signal handler.. looking for a brief explantion .. You speak about signal

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Pier Fumagalli
[EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I have to admit not having read the MinTC source, however, I thought the tomcat community uses/develops multiple implementations of many interfaces. Most of the http/socket/auth?/config (xml file/ajp-webapp/admin) code is effectively multiple

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread costinm
On Fri, 19 Apr 2002, Rolf Veen wrote: Remy Maucherat wrote: I will veto this (or vote against, if it's a majority vote). It has been very clear for a while that the Tomcat project has to provide one and only one servlet container for a particular version of the specifications. That

Re: [JK2] Win32 Signals

2002-04-19 Thread costinm
On Fri, 19 Apr 2002, Ignacio J. Ortega wrote: Hola a todos: I'm trying to get to compile the JNI part of JK2 in win32, again with my legendary naiveness ;), how is suppoussed we deal with signals in win32?? just add another ifdef here with a HAVE_UNIX_SIGNALS ? It shouldn't have any

RE: cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_service_iis.c

2002-04-19 Thread costinm
On Fri, 19 Apr 2002, Ignacio J. Ortega wrote: Update, after merging few dozens cvs conflicts :-) :-) , sorry bout that, I'll try to follow up your changes this evening ( here ), please wait for commits.. Today is shared memory-day, I'll not touch the IIS. Costin -- To unsubscribe,

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread GOMEZ Henri
This cannot be done, as the layering structure of the ASF won't allow it. It can be hosted either in commons, either here (but then it would be swallowed by the TC project itself), or as a top level project of Jakarta (or some other project)... couldn't it be a tomcat sub project like jasper2

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread Christopher K. St. John
[EMAIL PROTECTED] wrote: The point is not about developing multiple implementations - but about beeing a part of the community and proposing/discussing changes instead of posting announcements of a fork's releases. Costin, My response got to be way too long, so here's just a summary.

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Pier Fumagalli
Christopher K. St. John [EMAIL PROTECTED] wrote: - MinTC is not competition for Tomcat. You would have to be frigging insane to use MinTC if you could possibly use Tomcat 4 instead. But sometimes Tomcat 4 is difficult or impossible to use. That's not because Tomcat 4 is bad, it's just

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread GOMEZ Henri
I don't consider me a Tomcat 4.0 core committer, but that patch would have my biggest +1 on Earth! :) Pier (who has a script to remove stuff from TC4's binary distro!) I'm also not a core (not even satelitar) commiter in TC 4 yet, but a lighter TC 4.x will have my +1 and the current TC

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi isapi.dsp jk_iis.h jk_isapi_plugin.c

2002-04-19 Thread nacho
nacho 02/04/19 10:26:08 Modified:jk/native2/server/isapi isapi.dsp jk_iis.h jk_isapi_plugin.c Log: * Work in progress More cleanup, starting get things in place, some shakes need, but everything is there, compiles.. Revision ChangesPath 1.2 +4 -8

MinTC/Tomcat 4/Catalina. Conflict? No.

2002-04-19 Thread Christopher K. St. John
GOMEZ Henri wrote: I don't consider me a Tomcat 4.0 core committer, but that patch would have my biggest +1 on Earth! :) but a lighter TC 4.x will have my +1 and the current TC 4.0.x 'LE' mode is allready a good step in that direction. Ok, time to change the subject line. I know

DO NOT REPLY [Bug 8285] - PageContextImpl breaks spec; include() explicitly sets autoflush==true

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8285. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: MinTC, terrible rudeness, persistence

2002-04-19 Thread costinm
Christopher, I think a more modular 4.0 would be a step forward - and it seems many others agree. But what you are doing is a fork by all definitions that I know. As I said, I do agree with Remy - if you care about tomcat you should 'persist' in pushing for your ideas and find ways to work

cvs commit: jakarta-tomcat-4.0/webapps/admin/valve valves.jsp

2002-04-19 Thread manveen
manveen 02/04/19 11:04:40 Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve DeleteValveAction.java ValveUtil.java ValvesForm.java webapps/admin/valve valves.jsp Log: * Minor fixes for creating and

[JK2] Reading arbitrary properties files

2002-04-19 Thread Ignacio J. Ortega
Hola a Todos: How can i use jk2 to read and parse an arbitrary properties file? Saludos , Ignacio J. Ortega -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi jk_service_iis.c

2002-04-19 Thread nacho
nacho 02/04/19 11:48:57 Modified:jk/native2/server/isapi jk_service_iis.c Log: * Work in progress Adapting to jk_requtil.c Revision ChangesPath 1.7 +3 -3 jakarta-tomcat-connectors/jk/native2/server/isapi/jk_service_iis.c Index: jk_service_iis.c

Re: MinTC, terrible rudeness, persistence

2002-04-19 Thread Christopher K. St. John
Skip ahead to the substantive-discussion section if you're bored with the other topics in this thread. [EMAIL PROTECTED] wrote: But what you are doing is a fork by all definitions that I know. It's an alternative implementation of some of the Catalina interfaces, but it's clearly not a

DO NOT REPLY [Bug 8312] New: - Minor typos in doc and sample app

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8312. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: [JK2] Reading arbitrary properties files

2002-04-19 Thread costinm
On Fri, 19 Apr 2002, Ignacio J. Ortega wrote: Hola a Todos: How can i use jk2 to read and parse an arbitrary properties file? jk2_config_read() It'll read the properties into the jk_map ( without doing the ${} substitution ! - you must do it after you read ). The only 'special' thing

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java PageInfo.java ParserController.java Validator.java

2002-04-19 Thread kinman
kinman 02/04/19 13:35:01 Modified:jasper2 BUILDING.txt jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java PageInfo.java ParserController.java Validator.java Log: - Implement errata_a per

IIS and TOMCAT on different Machine?

2002-04-19 Thread Sandeep Contractor
How do I integrate IIS and TOMCAT when they are on different machines? Can it be even done? thanks, sandeep

DO NOT REPLY [Bug 6374] - class not find for:org/w3c/dom/range/Range

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6374. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

[PATCH] possible speed enhancement to JspServlet.java

2002-04-19 Thread Duncan McLean
I'm new to this list (and the jasper code), so please let me know if I've submitted this incorrectly. I was doing some profiling of the server side environment that I work on and noticed that quite a bit of time was being used in the JSP engine. After further investigation I

DO NOT REPLY [Bug 8315] New: - Tomcat doesn't create the mod_jk.conf-auto file

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8315. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.c

2002-04-19 Thread costin
costin 02/04/19 15:30:46 Modified:jk/native2/server/apache2 mod_jk2.c Log: uriEnv may be null ( and we have workerEnv in a static variable ). Thanks Nacho:-) Revision ChangesPath 1.12 +2 -4 jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c

DO NOT REPLY [Bug 8318] New: - class not found for: org.apache.cocoon.servlet.CocoonServlet

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8318. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 8315] - Tomcat doesn't create the mod_jk.conf-auto file

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8315. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi isapi.dsp jk_iis.h jk_isapi_plugin.c jk_service_iis.c

2002-04-19 Thread nacho
nacho 02/04/19 16:08:53 Modified:jk/native2/server/isapi isapi.dsp jk_iis.h jk_isapi_plugin.c jk_service_iis.c Log: * Work in progress Near :) Revision ChangesPath 1.3 +1 -1

Tomcat 4.0.3 ClassLoader problems

2002-04-19 Thread Les Hazlewood
Hey guys, I have a question about the classloader... When reading the following message, please keep in the back of your mind that my application does NOT reside in the default webapps directory... I created my own virtual host, with its context in a location like /var/www/mywebapp. I

DO NOT REPLY [Bug 8323] New: - No support for running the 64 bit JVM

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8323. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 8285] - PageContextImpl breaks spec; include() explicitly sets autoflush==true

2002-04-19 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8285. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

[FAQ] jGuru FAQ Update

2002-04-19 Thread Alex Chaffee
jGuru maintains FAQs and Forums on Servlets, JSP, and Tomcat (as well as many other Java topics). Here is an automated update on recent postings to Tomcat-related FAQs. Please direct flames and feedback to [EMAIL PROTECTED] . - Alex

cvs commit: jakarta-tomcat-connectors/jk/native2/server/isapi isapi.def isapi.dsp jk_iis.h jk_isapi_plugin.c jk_service_iis.c

2002-04-19 Thread nacho
nacho 02/04/19 20:06:18 Modified:jk/native2/server/isapi isapi.dsp jk_iis.h jk_isapi_plugin.c jk_service_iis.c Added: jk/native2/server/isapi isapi.def Log: * Adding a def file * Delete references to apr from dsp * Compiles cleanly * added