Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-24 Thread Peter Rossbach
Hmm, I thing we use different protocol handler classes for HTTP and AJP and that is the reason behind the late creation with the init method. :-\ I also thing we can remove a lot of the "unused" attributes that Remy has detected. Peter Shapira, Yoav schrieb: Hi, An optio

RE: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Shapira, Yoav
Hi, >An option would be to >tie the Connector object creation with the creation of the protocol >handler instance. That makes sense anyways. Why delay, since the Connect isn't useful without a ProtocolHandler anyways? Yoav This e-mail, including any attachments, is a confidential business c

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Remy Maucherat
Remy Maucherat wrote: Shapira, Yoav wrote: Hi, Alright ;) That saved me some effort ;) Forget my suggestion, and I'll leave this issue open for now. There are enough other ones for me to look at ;) Well, you can do that part, but not the way you suggested. In the meantime, I'll do what Pete

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Remy Maucherat
Shapira, Yoav wrote: Hi, Alright ;) That saved me some effort ;) Forget my suggestion, and I'll leave this issue open for now. There are enough other ones for me to look at ;) Well, you can do that part, but not the way you suggested. In the meantime, I'll do what Peter suggested and clean up

RE: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Shapira, Yoav
CTED] >Sent: Thursday, September 23, 2004 8:58 AM >To: Tomcat Developers List >Subject: Re: Bugzilla 30936: secure attribute is persisted twice > >Shapira, Yoav wrote: > >>Hi, >>I might take a stab at this later today, using my first approach: "secure" >will beco

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Remy Maucherat
Shapira, Yoav wrote: Hi, I might take a stab at this later today, using my first approach: "secure" will become an attribute of the ProtocolHandler interface. The Connector will retain its getSecure/setSecure methods, but they'll just pass through to the ProtocolHandler. That way the attribute wi

RE: Bugzilla 30936: secure attribute is persisted twice

2004-09-23 Thread Shapira, Yoav
will only be in one place and persisted once. Yoav Shapira Millennium Research Informatics >-Original Message- >From: Remy Maucherat [mailto:[EMAIL PROTECTED] >Sent: Wednesday, September 22, 2004 10:24 AM >To: Tomcat Developers List >Subject: Re: Bugzilla 30936: secure attribu

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-22 Thread Remy Maucherat
Peter Rossbach wrote: Hey, we have many duplicate attributes at connector and protocolhandler classes- I have spent a lot of time to fix that at my new server.xml/context.xml storage module. Current design based on factory model with external description file to handle those issues. Very str

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-20 Thread Peter Rossbach
Hey, we have many duplicate attributes at connector and protocolhandler classes- I have spent a lot of time to fix that at my new server.xml/context.xml storage module. Current design based on factory model with external description file to handle those issues. Very strange, but my only chanc

RE: Bugzilla 30936: secure attribute is persisted twice

2004-09-20 Thread Shapira, Yoav
Hi, >I'm going to wait for Peter for save-to-XML rewriting, before bothering >with fixing the various issues. >(right now, saving data sources needs to be redone as well) I contemplated that, but it seems that here the core problem is not the persisting itself: it's the duplication of attributes

Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-20 Thread Remy Maucherat
Shapira, Yoav wrote: Hi, I'm looking at http://issues.apache.org/bugzilla/show_bug.cgi?id=30936. The "secure" attribute is persisted twice, causing a Digester error, because it's an attribute of both the Connector itself and its ProtocolHandler. The simplest fix seems to be to remove one these attr

Bugzilla 30936: secure attribute is persisted twice

2004-09-20 Thread Shapira, Yoav
Hi, I'm looking at http://issues.apache.org/bugzilla/show_bug.cgi?id=30936. The "secure" attribute is persisted twice, causing a Digester error, because it's an attribute of both the Connector itself and its ProtocolHandler. The simplest fix seems to be to remove one these attributes. It seems f