[5] New Coyote Branch

2002-08-02 Thread Bob Herrmann
So to ensure I understand, the New Coyote Branch means Adding to repository jakarta-tomcat-connectors a directory; coyote/src/java/org/apache/coyote5/ which initially is a copy of coyote/src/java/org/apache/coyote4/ and in coyote5 the Request and Response classes implement

Re: [5] New Coyote Branch

2002-08-02 Thread costinm
On 2 Aug 2002, Bob Herrmann wrote: Adding to repository jakarta-tomcat-connectors a directory; coyote/src/java/org/apache/coyote5/ You mean: coyote/src/java/org/apache/coyote/tomcat5 and in coyote5 the Request and Response classes implement the interfaces tomcat4

Re: New coyote branch

2002-08-01 Thread Remy Maucherat
Justyna Horwat wrote: I looked in jakarta-tomcat-connectors and it doesn't look like jakarta-tomcat-connectors has been branched yet. I checked the archives and saw the vote results where it was decided that the HEAD of jakarta-tomcat-connectors will be used for Tomcat 5 and Coyote 1.0

Re: New coyote branch

2002-08-01 Thread costinm
On Wed, 31 Jul 2002, Peter Lin wrote: Justyna Horwat wrote:I looked in jakarta-tomcat-connectors and it doesn't look like jakarta-tomcat-connectors has been branched yet. I checked the archives and saw the vote results where it was decided that the HEAD of jakarta-tomcat-connectors will

Re: New coyote branch

2002-08-01 Thread Patrick Luby
Justy, I verified that Tomcat 5 builds and runs and most of the servlet tests in Watchdog pass with the current Coyote connector. Of course, I don't think any of the changes in the proposed 2.4 spec have been implemented yet. Are there any changes to Coyote that are explicitly or implicitly

Re: New coyote branch

2002-08-01 Thread Craig R. McClanahan
On Thu, 1 Aug 2002 [EMAIL PROTECTED] wrote: Date: Thu, 1 Aug 2002 07:10:09 -0700 (PDT) From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: New coyote branch On Wed, 31 Jul 2002, Peter Lin wrote: Justyna

Re: New coyote branch

2002-08-01 Thread costinm
On Thu, 1 Aug 2002, Craig R. McClanahan wrote: Justyna Horwat wrote:I looked in jakarta-tomcat-connectors and it doesn't look like jakarta-tomcat-connectors has been branched yet. I checked the archives and saw the vote results where it was decided that the HEAD of

Re: New coyote branch

2002-08-01 Thread Justyna Horwat
Craig summed it up well in his e-mail. The attribute change listeners are explicitly required by the proposed servlet 2.4 spec. I need to modify the ServletRequest instance which happens to be present in Coyote. Both Costin and Remy brought up issues related to as well as good solutions to

Re: New coyote branch

2002-08-01 Thread costinm
Justy, You'll also need to change coyote.Request - since it is the real attribute store. As I mentioned, you'll need to add 2 ActionCodes. That's the correct implementation IMHO ( independent of where you put the CoyoyteRequest ). If it can wait a bit - I can help. Costin On Thu, 1 Aug

Re: New coyote branch

2002-08-01 Thread Craig R. McClanahan
On Thu, 1 Aug 2002 [EMAIL PROTECTED] wrote: Date: Thu, 1 Aug 2002 09:51:09 -0700 (PDT) From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: New coyote branch On Thu, 1 Aug 2002, Craig R. McClanahan wrote

Re: New coyote branch

2002-08-01 Thread costinm
On Thu, 1 Aug 2002, Craig R. McClanahan wrote: o.a.coyote.Request doesn't have setAttribute() or replaceAttribute() methods, so I don't see why it would be affected -- only the Servlet 2.4 version of CoyoteRequest would seem to matter. ??? Are we talking about the same thing ?

Re: New coyote branch

2002-08-01 Thread Craig R. McClanahan
On Thu, 1 Aug 2002 [EMAIL PROTECTED] wrote: Date: Thu, 1 Aug 2002 14:40:33 -0700 (PDT) From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: New coyote branch On Thu, 1 Aug 2002, Craig R. McClanahan wrote

Re: New coyote branch

2002-08-01 Thread costinm
2002, Craig R. McClanahan wrote: On Thu, 1 Aug 2002 [EMAIL PROTECTED] wrote: Date: Thu, 1 Aug 2002 14:40:33 -0700 (PDT) From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: Re: New coyote branch On Thu

New coyote branch

2002-07-31 Thread Justyna Horwat
I looked in jakarta-tomcat-connectors and it doesn't look like jakarta-tomcat-connectors has been branched yet. I checked the archives and saw the vote results where it was decided that the HEAD of jakarta-tomcat-connectors will be used for Tomcat 5 and Coyote 1.0 would be branched. I'd like

Re: New coyote branch

2002-07-31 Thread Peter Lin
I believe remmy is on vacation and is moving to france :) I guess someone else will have to do it. peter Justyna Horwat wrote:I looked in jakarta-tomcat-connectors and it doesn't look like jakarta-tomcat-connectors has been branched yet. I checked the archives and saw the vote results