RE: [J-T-C] Apache 2.0 code review required

2001-09-17 Thread GOMEZ Henri
I'd like to sync tomcat_32, jakarta-tomcat, and j-t-c with the same code-- that is, using r-uri in all cases, but re-encoding it with ap_escape_uri. This seemed to be the consensus a month or two ago in the discussions, as proxies do the same thing (decode, then re-encode). The spec issue is

RE: [J-T-C] Apache 2.0 code review required

2001-09-17 Thread GOMEZ Henri
| If that change make us spec compliant and | mod_rewrite compatible, I'll be OK, but may be | we should all review code change before commit ? | | Also what about IIS/NES/DOMINO in such case ? Attached is what I propose. I can't speak for the other servers, and neither one of our changes

RE: [J-T-C] Apache 2.0 code review required

2001-09-16 Thread Keith Wannamaker
, September 14, 2001 7:16 PM | To: [EMAIL PROTECTED] | Subject: RE: [J-T-C] Apache 2.0 code review required | | | I don't think keeping everything as dumb as the dumbest server | is a good | idea - but the big problem is making sure those features don't | interfere | too much with the servlet spec ( see

Re: [J-T-C] Apache 2.0 code review required

2001-09-14 Thread Justin Erenkrantz
On Sat, Sep 15, 2001 at 12:50:27AM +0200, GOMEZ Henri wrote: Hi to all, I've just commited updated code for Apache 1.3/2.0 I will need a serious code review on Apache 2.0 part and particulary the ws_read() which was grabbed from 1.3 and works (at least on Apache 2.0.24) but may be

RE: [J-T-C] Apache 2.0 code review required

2001-09-14 Thread GOMEZ Henri
Hi to all, I've just commited updated code for Apache 1.3/2.0 I will need a serious code review on Apache 2.0 part and particulary the ws_read() which was grabbed from 1.3 and works (at least on Apache 2.0.24) but may be optimized... snip, snip ws_write() could need also a serious

Re: [J-T-C] Apache 2.0 code review required

2001-09-14 Thread cmanolache
On Fri, 14 Sep 2001, Justin Erenkrantz wrote: Since you have a common infrastructure via callbacks, I don't think you can take advantage of a lot of the new features in Apache 2.0. Oh, well. -- justin Well, we should be able to. We can just add more callbacks - and make sure the code that

RE: [J-T-C] Apache 2.0 code review required

2001-09-14 Thread GOMEZ Henri
I don't think keeping everything as dumb as the dumbest server is a good idea - but the big problem is making sure those features don't interfere too much with the servlet spec ( see the mod_rewrite discussion ). The mod_rewrite case is now handled elegantly via JkOptions :)