Re: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-07 Thread Jan Luehe
Dimitry: I still believe your patch is invalid, as it would amount to synchronizing AT_BEGIN and NESTED variables after calling doStartTag(). However, the spec explicitly mentions that for tag handlers implementing BodyTag, those variables must not be synchronized after doStartTag(), *only* after

RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-07 Thread Dimitry Ivanov
not ideal English. :( -Original Message- From: Jan Luehe [mailto:[EMAIL PROTECTED]] Sent: Wednesday, January 08, 2003 4:08 AM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Re: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag Dimitry: I still believe your

Re: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-06 Thread Jan Luehe
Dimitry, In jasper2, I have found one interesting bug. It hapens when tag implements BodyTag interface and doStartTag returns EVAL_BODY_INCLUDE. See test-case and patch attached. The patch tested under Tomcat 4.1.18. the current synchronization behaviour your are seeing is compliant with

Re: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-06 Thread Jan Luehe
Dimitry, In jasper2, I have found one interesting bug. It hapens when tag implements BodyTag interface and doStartTag returns EVAL_BODY_INCLUDE. See test-case and patch attached. The patch tested under Tomcat 4.1.18. the current synchronization behaviour your are seeing is

RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-06 Thread Dimitry Ivanov
Jan, Two quotes from JSP.10.2.2 (BodyTag) in JSP 1.2 spec. Quote 1 (on page 177 second paragraph): If EVAL_BODY_INCLUDE is returned, then evaluation happens as in Iteration- Tag. Quote 2 (on page 178, last paragraph): If EVAL_BODY_INCLUDE is returned, setBodyContent() is not invoked,

RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-06 Thread Dimitry Ivanov
: RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag Jan, Two quotes from JSP.10.2.2 (BodyTag) in JSP 1.2 spec. Quote 1 (on page 177 second paragraph): If EVAL_BODY_INCLUDE is returned, then evaluation happens as in Iteration- Tag. Quote 2 (on page 178, last

RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-05 Thread Dimitry Ivanov
Dear Tomcat developers, What do you think about described bug? I know, my English is not good. Is it possible to understand my letter? -Original Message- From: Dimitry Ivanov [mailto:[EMAIL PROTECTED]] Sent: Thursday, January 02, 2003 8:31 PM To: [EMAIL PROTECTED] Subject: [PATCH]