RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-04 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Mark Thomas wrote: Fixing bug 13040 requires an additional patch that uses equals() for the whole algorithm. Hence the complications. This is what I was discussing above. The matching rule can't be fully implemented AFAIK. I think the

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-04 Thread Remy Maucherat
Mark Thomas wrote: From: Remy Maucherat [mailto:[EMAIL PROTECTED] Mark Thomas wrote: Fixing bug 13040 requires an additional patch that uses equals() for the whole algorithm. Hence the complications. This is what I was discussing above. The matching rule can't be fully implemented AFAIK. I

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-04 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] My proposal is to change getContext to provide the following behaviour: Context uripath result -- A / A A /foo/ B A /foo/bar/ C A /foo/bar/xxx/

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-02 Thread Remy Maucherat
Mark Thomas wrote: Remy, Looking at bug 13040 I did a bugzilla search and came across bug 11411. I am still thinking about bug 13040 but saw that bug 11411 could be fixed (I had previously closed it without looking at the source closely enough) without getting into the equals()/startsWith()

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-02 Thread Mark Thomas
OK then. Now for the tricky bit. Bug 13040 (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040) highlights a rather knotty problem. Having mulled this over for the last few days I have come to the conclusion that we should be using equals() rather than startsWith() My reasons for this are: -

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-02 Thread Remy Maucherat
Mark Thomas wrote: OK then. Now for the tricky bit. Bug 13040 (http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13040) highlights a rather knotty problem. Having mulled this over for the last few days I have come to the conclusion that we should be using equals() rather than startsWith() My

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-02 Thread Mark Thomas
From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Friday, April 02, 2004 8:30 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina /core ApplicationContext.java Mark Thomas wrote: OK then. Now for the tricky bit. Bug

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-02 Thread Remy Maucherat
Mark Thomas wrote: Fixing bug 13040 requires an additional patch that uses equals() for the whole algorithm. Hence the complications. This is what I was discussing above. The matching rule can't be fully implemented AFAIK. I think the current algorithm is a nice compromise. Please give examples

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-01 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: markt 2004/04/01 12:09:21 Modified:catalina/src/share/org/apache/catalina/core ApplicationContext.java Log: - Fix getContext(/) so current context is returned if called whilst in the root context - Port from TC5 I disagree with

RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java

2004-04-01 Thread Mark Thomas
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Thursday, April 01, 2004 9:47 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina /core ApplicationContext.java [EMAIL PROTECTED] wrote: markt 2004