Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-03 Thread Bojan Smojver
Bojan Smojver wrote: [EMAIL PROTECTED] wrote: I don't think I can do this alone ( if it sounded like I volunteer to fix it - well, I need help ). - Test. I'm one of those overly brave and too stupid that put CVS versions of software in production environment. Promise to give it

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread GOMEZ Henri
- Revert jk/apache to use uri, remove the encode call ( again, j-t and j-t-c - one more week to do that, after that we'll be j-t-c only ). Henri - could you do this and the next one ? I'll reintroduce the JkOptions which will help us play with different encoding : ForwardStandardURI : will

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
? Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 5:18 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | | - Revert jk/apache to use uri, remove the encode call ( again, j-t and | j-t-c

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread GOMEZ Henri
: Volunteers for: - RE: TC 3.3: getRequestURI() | | | | - Revert jk/apache to use uri, remove the encode call ( again, j-t and | j-t-c - one more week to do that, after that we'll be j-t-c | only ). Henri | - could you do this and the next one ? | | I'll reintroduce the JkOptions which

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
, October 01, 2001 5:18 AM | | To: [EMAIL PROTECTED] | | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | | | | | | - Revert jk/apache to use uri, remove the encode call ( | again, j-t and | | j-t-c - one more week to do that, after that we'll be j-t-c | | only ). Henri | | - could you

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread GOMEZ Henri
What whould happen in 3.3 if ForwardEscapedURI was chosen? Wouldn't the facade escape it again? My goal in mod_jk is to keep compatibility with ALL tomcat release, TC 3.2, 3.3 and 4.0. The option will let us configure it, even if by default mod_jk found in TC 3.3 and J-T-C will use the TC

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
hesitate to add it. Keith | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 10:35 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | What whould happen in 3.3 if ForwardEscapedURI was chosen

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread GOMEZ Henri
bug reports. I'd hesitate to add it. The Option could be hidden and use the TC 3.3 behaviour by default... | -Original Message- | From: GOMEZ Henri [mailto:[EMAIL PROTECTED]] | Sent: Monday, October 01, 2001 10:35 AM | To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread Keith Wannamaker
| To: [EMAIL PROTECTED] | Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() | | | Why can't we implement the 3.3 collaborative solution in 4.0 ? | That would maintain compatibility. | | And also in TC 3.2.4 ? | | I just hate to provide an option which could result | in wrong (double

RE: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-10-01 Thread GOMEZ Henri
, October 01, 2001 10:52 PM To: [EMAIL PROTECTED] Subject: RE: Volunteers for: - RE: TC 3.3: getRequestURI() I thought you were talking about the mod_jk in the TC3.3 branch. If you're talking j-t-c only, then I don't mind an Option, as long as it defaults to the 3.3 behavior. Keith

Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-09-30 Thread Bill Barker
, September 30, 2001 1:23 AM Subject: Re: Volunteers for: - RE: TC 3.3: getRequestURI() On Sat, 29 Sep 2001, Bill Barker wrote: It seems that I must have been bad in a past life, since my Karma isn't high enough.:) I've added the code to re-encode the URL to DecodeInterceptor on my

Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-09-30 Thread Bill Barker
:40 AM Subject: Re: Volunteers for: - RE: TC 3.3: getRequestURI() Actually, my original was a straight java.net.URLEncode after stripping out the session id. However, I'm easy. Attached is using UEncoder (which I initially felt was too expensive). I'm starting to come around to your original

Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-09-30 Thread cmanolache
PROTECTED] To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; Bill Barker [EMAIL PROTECTED] Sent: Sunday, September 30, 2001 12:40 AM Subject: Re: Volunteers for: - RE: TC 3.3: getRequestURI() Actually, my original was a straight java.net.URLEncode after stripping out the session id. However, I'm easy

Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-09-29 Thread Bill Barker
: Friday, September 28, 2001 11:17 AM Subject: Volunteers for: - RE: TC 3.3: getRequestURI() It seems most agree on using 'decoded' URI in mod_jk. Making the change is not easy, there are few places where we need to coordinate and make sure we're on the same page. I don't think I can do this alone

Re: Volunteers for: - RE: TC 3.3: getRequestURI()

2001-09-29 Thread cmanolache
Subject: Volunteers for: - RE: TC 3.3: getRequestURI() It seems most agree on using 'decoded' URI in mod_jk. Making the change is not easy, there are few places where we need to coordinate and make sure we're on the same page. I don't think I can do this alone ( if it sounded like I

Re: TC 3.3: getRequestURI()

2001-09-27 Thread jean-frederic clere
[EMAIL PROTECTED] wrote: On Wed, 26 Sep 2001, Keith Wannamaker wrote: 0x3b = ';'. Ignacio is right, SessionID doesn't remove the id because it is not expecting ; to be encoded. So now it shows up in the URI and has the side effect of breaking sessions that depend on url rewriting.

RE: TC 3.3: getRequestURI()

2001-09-27 Thread GOMEZ Henri
-Original Message- From: Keith Wannamaker [mailto:[EMAIL PROTECTED]] Sent: Thursday, September 27, 2001 2:27 AM To: [EMAIL PROTECTED] Subject: RE: TC 3.3: getRequestURI() I'm +1 for this. It is the best solution. Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Larry Isaacs
-Original Message- From: Bojan Smojver [mailto:[EMAIL PROTECTED]] Sent: Wednesday, September 26, 2001 7:41 AM To: Tomcat Dev List Subject: TC 3.3: getRequestURI() The latest TC 3.3 CVS with its mod_jk, gives an encoded URI, together with the session ID

Re: TC 3.3: getRequestURI()

2001-09-26 Thread jean-frederic clere
Larry Isaacs wrote: -Original Message- From: Bojan Smojver [mailto:[EMAIL PROTECTED]] Sent: Wednesday, September 26, 2001 7:41 AM To: Tomcat Dev List Subject: TC 3.3: getRequestURI() The latest TC 3.3 CVS with its mod_jk, gives an encoded URI, together with the session

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
I'm not sure I understand why the session id was not also showing up with r-unparsed_uri. I'm doing some experimenting now.. Keith |/login/login.vm%3bjsessionid=q95pbsuof1 | Probably not. It's a side of effect of the last change which was | to use s-req_uri = ap_escape_uri(r-pool, r-uri);.

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Ignacio J. Ortega
PROTECTED] Asunto: RE: TC 3.3: getRequestURI() I'm not sure I understand why the session id was not also showing up with r-unparsed_uri. I'm doing some experimenting now.. Keith |/login/login.vm%3bjsessionid=q95pbsuof1 | Probably not. It's a side of effect of the last change which

Re: TC 3.3: getRequestURI()

2001-09-26 Thread jean-frederic clere
: Keith Wannamaker [mailto:[EMAIL PROTECTED]] Enviado el: miércoles 26 de septiembre de 2001 16:55 Para: [EMAIL PROTECTED] Asunto: RE: TC 3.3: getRequestURI() I'm not sure I understand why the session id was not also showing up with r-unparsed_uri. I'm doing some experimenting now

Re: TC 3.3: getRequestURI()

2001-09-26 Thread Bill Barker
PROTECTED] To: Tomcat Dev List [EMAIL PROTECTED] Sent: Wednesday, September 26, 2001 4:41 AM Subject: TC 3.3: getRequestURI() The latest TC 3.3 CVS with its mod_jk, gives an encoded URI, together with the session ID on HttpServletRequest.getRequestURI(). Example: /login/login.vm%3bjsessionid

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
Are you using mod_jk? | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED]] | Sent: Wednesday, September 26, 2001 1:17 PM | To: [EMAIL PROTECTED] | Subject: Re: TC 3.3: getRequestURI() | | | I don't get this with RC1. From tomcat-log with debugging enabled for

Re: TC 3.3: getRequestURI()

2001-09-26 Thread Bill Barker
Yes. - Original Message - From: Keith Wannamaker [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, September 26, 2001 10:57 AM Subject: RE: TC 3.3: getRequestURI() Are you using mod_jk? | -Original Message- | From: Bill Barker [mailto:[EMAIL PROTECTED]] | Sent

Re: TC 3.3: getRequestURI()

2001-09-26 Thread Bojan Smojver
Keith Wannamaker wrote: 0x3b = ';'. Ignacio is right, SessionID doesn't remove the id because it is not expecting ; to be encoded. So now it shows up in the URI and has the side effect of breaking sessions that depend on url rewriting. But, the spec does say the URL should be encoded,

RE: TC 3.3: getRequestURI()

2001-09-26 Thread cmanolache
On Wed, 26 Sep 2001, Keith Wannamaker wrote: 0x3b = ';'. Ignacio is right, SessionID doesn't remove the id because it is not expecting ; to be encoded. So now it shows up in the URI and has the side effect of breaking sessions that depend on url rewriting. But, the spec does say the URL

Re: TC 3.3: getRequestURI()

2001-09-26 Thread Bojan Smojver
[EMAIL PROTECTED] wrote: On Wed, 26 Sep 2001, Keith Wannamaker wrote: 0x3b = ';'. Ignacio is right, SessionID doesn't remove the id because it is not expecting ; to be encoded. So now it shows up in the URI and has the side effect of breaking sessions that depend on url rewriting.

RE: TC 3.3: getRequestURI()

2001-09-26 Thread Keith Wannamaker
I'm +1 for this. It is the best solution. Keith | -Original Message- | From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] | | 3. Revert to the use of uri ( i.e. the decoded uri ), and | change the getRequestURI ( the facade ) to generated a | 'canonical' encoding. | Problems: