cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2004-04-25 Thread remm
remm2004/04/25 03:28:29

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  - Experiment with stopping the manager earlier, so that listeners are still present.
  
  Revision  ChangesPath
  1.128 +7 -7  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.127
  retrieving revision 1.128
  diff -u -r1.127 -r1.128
  --- StandardContext.java  15 Apr 2004 01:44:08 -  1.127
  +++ StandardContext.java  25 Apr 2004 10:28:29 -  1.128
  @@ -4467,18 +4467,18 @@
   // Stop our filters
   filterStop();
   
  -// Stop our application listeners
  -listenerStop();
  -
  -// Finalize our character set mapper
  -setCharsetMapper(null);
  -
   // Stop ContainerBackgroundProcessor thread
   super.threadStop();
   
   if ((manager != null)  (manager instanceof Lifecycle)) {
   ((Lifecycle) manager).stop();
   }
  +
  +// Stop our application listeners
  +listenerStop();
  +
  +// Finalize our character set mapper
  +setCharsetMapper(null);
   
   // Normal container shutdown processing
   if (log.isDebugEnabled())
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 18479] - HttpSessionBindingListener.valueUnbound() not called

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=18479.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=18479

HttpSessionBindingListener.valueUnbound() not called

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 10:39 ---
I committed a change which may fix this. Either this fixes it or it will not be
fixed since (unless you submit a tested patch) I don't see the issue as very
important.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

2004-04-25 Thread remm
remm2004/04/25 04:54:04

  Modified:jasper2/src/share/org/apache/jasper JspC.java
  Log:
  - Remove canonicalization, which is not very useful here, and can cause trouble with
symlinks.
  - Bug 28147, submitted by Rick Wong.
  
  Revision  ChangesPath
  1.70  +11 -17
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.69
  retrieving revision 1.70
  diff -u -r1.69 -r1.70
  --- JspC.java 6 Apr 2004 17:58:59 -   1.69
  +++ JspC.java 25 Apr 2004 11:54:04 -  1.70
  @@ -830,28 +830,22 @@
   Enumeration e = pages.elements();
   while (e.hasMoreElements()) {
   String nextjsp = e.nextElement().toString();
  -try {
  -File fjsp = new File(nextjsp);
  -if (!fjsp.exists()) {
  -if (log.isWarnEnabled()) {
  -
log.warn(Localizer.getMessage(jspc.error.fileDoesNotExist,
  -  fjsp.toString()));
  -}
  -continue;
  +File fjsp = new File(nextjsp);
  +if (!fjsp.exists()) {
  +if (log.isWarnEnabled()) {
  +log.warn
  +(Localizer.getMessage
  + (jspc.error.fileDoesNotExist, fjsp.toString()));
   }
  -String s = fjsp.getCanonicalPath();
  -//System.out.println(** + s);
  -if (s.startsWith(uriRoot)) {
  -nextjsp = s.substring(uriRoot.length());
  -}
  -} catch (IOException ioe) {
  -// if we got problems dont change the file name
  +continue;
  +}
  +String s = fjsp.getAbsolutePath();
  +if (s.startsWith(uriRoot)) {
  +nextjsp = s.substring(uriRoot.length());
   }
  -
   if (nextjsp.startsWith(. + File.separatorChar)) {
   nextjsp = nextjsp.substring(2);
   }
  -
   processFile(nextjsp);
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28147] - JasperException for jsp files that are symbolic links

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28147.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28147

JasperException for jsp files that are symbolic links

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 11:55 ---
If this is the only place where a change is needed, then it seems ok.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-5/resources build.xml

2004-04-25 Thread remm
remm2004/04/25 05:01:28

  Modified:resources build.xml
  Log:
  - Add a message about cvs login in the case where checkout fails.
  - Bug 28333, submitted by Sandy McArthur.
  
  Revision  ChangesPath
  1.5   +3 -0  jakarta-tomcat-5/resources/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/resources/build.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- build.xml 15 Jan 2004 09:50:56 -  1.4
  +++ build.xml 25 Apr 2004 12:01:28 -  1.5
  @@ -54,6 +54,9 @@
 target name=checkout
 description=Update or checkout required sources from CVS
   
  +echo level=info
  +message=If the checkout fails, run `cvs -d ${cvsroot} login` and try 
again. The password for the anonymous CVS access is `anoncvs` /
  +
   cvs cvsroot=${cvsroot} quiet=true
command=checkout -P ${tomcat.project} 
dest=${basedir} compression=true /
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28333] - Add info on cvs login to tomcat build file.

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28333.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28333

Add info on cvs login to tomcat build file.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 12:02 ---
Fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-5 tomcat.nsi

2004-04-25 Thread remm
remm2004/04/25 05:35:55

  Modified:.tomcat.nsi
  Log:
  - Add apparently missing read, so that the service uses the same JVM path as the rest
(in case the user manually selects a different VM).
  
  Revision  ChangesPath
  1.44  +7 -1  jakarta-tomcat-5/tomcat.nsi
  
  Index: tomcat.nsi
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/tomcat.nsi,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- tomcat.nsi7 Apr 2004 11:33:40 -   1.43
  +++ tomcat.nsi25 Apr 2004 12:35:55 -  1.44
  @@ -135,6 +135,12 @@
   
 Call configure
 Call findJavaPath
  +  Pop $2
  +
  +  IfSilent +2 0
  +  !insertmacro MUI_INSTALLOPTIONS_READ $2 jvm.ini Field 2 State
  +
  +  Push $2
 Call findJVMPath
 Pop $2
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 12:37 ---
What I meant is actually that you should use something reliable (JAVA_HOME, or
select the right path in the dialog). The registry keys depend on the JDK used,
so it will not really work.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 20608] - context.xml not bound from WAR file

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=20608.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=20608

context.xml not bound from WAR file

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Enhancement



--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 13:57 ---
Not a bug but a wish = enhancement.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Bug report for Tomcat 3 [2004/04/25]

2004-04-25 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt|
| 2478|Opn|Cri|2001-07-06|Passing Session variables between JSP's and Servle|
| 4551|Opn|Nor|2001-10-31|Ctx( /tt01 ): IOException in: R( /tt01 + /com/abc/|
| 4980|New|Min|2001-11-20|Startup message indicates incorrect log file  |
| 4994|New|Nor|2001-11-21|Tomcat needs a mechanism for clean and certain shu|
| 5064|New|Cri|2001-11-25|Socket write error when include files is more than|
| 5108|New|Maj|2001-11-26|Docs for Tomcat 3.2.x appear to be for Tomcat 3.3 |
| 5137|New|Nor|2001-11-27|Null pointer in class loader after attempting to r|
| 5160|Unc|Maj|2001-11-28|'IllegalStateException'   |
| 5331|New|Nor|2001-12-09|getPathInfo vs URL normalization  |
| 5510|New|Blk|2001-12-19|How to call ejb deployed in JBoss from Tomcat serv|
| 5756|New|Nor|2002-01-08|jspc.bat exits with wrong ERRORLEVEL  |
| 5797|New|Nor|2002-01-10|UnCatched ? StringIndexOutOfBoundsException: Strin|
| 6027|New|Maj|2002-01-25|Tomcat  Automatically shuts down as service   |
| 6168|New|Blk|2002-02-01|IllegalStateException |
| 6451|New|Cri|2002-02-14|Stackoverflow |
| 6478|New|Enh|2002-02-14|Default Tomcat Encoding   |
| 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c|
| 6648|New|Nor|2002-02-25|jakarta-servletapi build with java 1.4 javadoc err|
| 6702|New|Cri|2002-02-27|win 2k services not working   |
| 6796|New|Cri|2002-03-01|Tomcat dies periodically  |
| 6989|New|Maj|2002-03-08|Unable to read tld file during parallel JSP compil|
| 7013|New|Cri|2002-03-10|Entering a servlet path with non-ISO8859-1 charact|
| 7227|New|Nor|2002-03-19|error-code directive don't work |
| 7626|New|Nor|2002-03-29|classloader not working properly  |
| 7652|New|Cri|2002-04-01|Tomcat stalls periodically|
| 7785|New|Blk|2002-04-06|tomcat bug in context reloading   |
| 7863|New|Maj|2002-04-09|I have a problem when running Tomcat with IIS |
| 8187|New|Cri|2002-04-17|Errors when Tomcat used with MS Access database   |
| 8239|New|Cri|2002-04-18|Resource temporary unavailable|
| 8263|New|Cri|2002-04-18|url-pattern easy to circumvent|
| 9250|New|Maj|2002-05-20|outOfMemoryError  |
| 9367|New|Maj|2002-05-23|HttpSessionBindingEvent not thrown for HttpSession|
| 9390|New|Nor|2002-05-24|jasper compilation error in tomcat|
| 9480|New|Nor|2002-05-29|Data connection pooling   |
| 9607|New|Maj|2002-06-04|precompile JSP|
| 9737|Ver|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p|
|10047|New|Cri|2002-06-20|IllegalStateException |
|10202|New|Maj|2002-06-25|Tomcat is not responding in time  |
|10357|Unc|Blk|2002-06-30|java.lang.IllegalArgumentException: Short Read|
|10406|New|Cri|2002-07-02|IllegalStateException |
|11087|New|Blk|2002-07-23|IllegalStateException |
|11286|New|Maj|2002-07-30|Tomcat threads not respond if increase JVM size   |
|11466|New|Nor|2002-08-05|ContextManager: SocketException reading request   |
|12156|New|Cri|2002-08-29|Apache and Tomcat 3.3.1 Interworking problem  |
|12194|New|Maj|2002-08-30|Tomcat does not send WWW-Authenticate header  |
|12475|New|Nor|2002-09-10|CPU Usage is 0%, Tomcat doesn't response  |
|12852|New|Nor|2002-09-20|May be error in _jspService() - out.flushBuffers(|
|13706|New|Nor|2002-10-16|Many Processs Java / TOMCAT in a PC with Linux Con|
|14386|New|Maj|2002-11-08|Date headers corrupted using setDateHeader|
|15632|New|Nor|2002-12-23|Problem with the Tomcat Sessions Parameter on URL |

Bug report for Tomcat 4 [2004/04/25]

2004-04-25 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  218|Unc|Nor|2000-11-02|IIS  in-process tomcat BugRat Report#333 |
| 3614|Opn|Nor|2001-09-14|bug in manager webapp |
| 3888|Opn|Blk|2001-09-30|WebappClassLoader: Lifecycle error : CL stopped   |
| 4091|Opn|Nor|2001-10-11|custom host with unpackWARs=true don't expand wa|
| 4138|Opn|Nor|2001-10-12|Processor threads have inconsistent ClassLoader st|
| 4352|Ass|Nor|2001-10-22|JDBCRealm does not work with CLIENT-CERT auth-meth|
| 5181|Opn|Cri|2001-11-29|HttpConnector [8080] No processor available, rejec|
| 5329|New|Nor|2001-12-08|NT Service exits startup before Tomcat is finished|
| 5704|Ass|Maj|2002-01-05|CgiServlet corrupting images? |
| 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob|
| 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi|
| 5858|New|Enh|2002-01-15|Add tomcat dir to java.library.path   |
| 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio|
| 6218|Opn|Nor|2002-02-04|Relative links broken for servlets|
| 6229|New|Enh|2002-02-04|Need way to specify where to write catalina.out   |
| 6399|New|Nor|2002-02-12|unknown protocol: https   |
| 6582|New|Min|2002-02-20|Sample code does not match behavior   |
| 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI|
| 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam|
| 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty|
| 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store   |
| 7360|New|Nor|2002-03-22|res-sharing-scope not supported   |
| 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output|
| 7571|New|Nor|2002-03-28|DataInputStream readLong() Problem|
| 7676|New|Enh|2002-04-02|Allow name property to use match experssions in h|
| 7689|New|Min|2002-04-02|Performance problem with Xerces parser|
| 7723|New|Enh|2002-04-03|[patch] additional factory for org.apache.naming.f|
| 7831|New|Nor|2002-04-08|[PATCH] JNDIRealm does not work with CLIENT-CERT a|
| 7880|Ver|Cri|2002-04-09|If a TLV flags flags an error during the translati|
| 8026|New|Enh|2002-04-12|Exceptions in StandardHostDeployer.addChild are lo|
| 8217|New|Maj|2002-04-17|Documentation references workers. prefix|
| 8275|Ver|Min|2002-04-18|ContextConfig.start() attempts to create a $CATALI|
| 8323|New|Enh|2002-04-20|No support for running the 64 bit JVM |
| 8343|New|Enh|2002-04-21|adding a absorber logger class to org.apache.ca|
| 8441|New|Enh|2002-04-23|Command line files for NetWare|
| 8541|New|Nor|2002-04-26|IIS redirector URL-encodes cookie values  |
| 8705|New|Enh|2002-05-01|SessionListener should extend EventListener   |
| 8709|New|Maj|2002-05-01|ISAPI Filter failing to pass on DAV OPTIONS requ|
| 8744|New|Enh|2002-05-02|No way to configure/extend runtime classloaders.  |
| 8776|New|Enh|2002-05-03|The session url encoding under somce circumstances|
| 9027|New|Cri|2002-05-13|The Tomcat Servlet Container use the identity spec|
| 9050|Ver|Nor|2002-05-13|GET Query Parameters Require an Equal Sign|
| 9227|New|Enh|2002-05-19|Allow an empty value of a pathname in the Standard|
| 9334|New|Nor|2002-05-23|Intermittent parsing error in Ajp13Request|
| 9340|Opn|Cri|2002-05-23|Tomcat Service problem|
| 9417|New|Blk|2002-05-25|ajp13 conector does not pass Query string corectly|
| 9456|New|Enh|2002-05-28|Problem saving server.xml file: invalid XML markup|
| 9511|New|Enh|2002-05-30|Object instantiation optimization in StandardSessi|
| 9629|New|Enh|2002-06-05|Fix ServletContext.getResourcePaths to match spec |
| 9745|New|Enh|2002-06-10|extern cache mgt bug for conditionally dynamic pag|
| 9832|New|Cri|2002-06-13|Tomcat 4 IIS redirector cannot cope with POST in S|
| 

Bug report for Watchdog [2004/04/25]

2004-04-25 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=CriticalMAJ=Major |
| |   |   MIN=Minor   NOR=Normal  ENH=Enhancement   |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|  278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug|
|  279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug|
|  469|Unc|Nor|2001-01-17|in example-taglib.tld urn should be uri BugRat|
|  470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B|
| 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths|
|10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher|
|11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()|
|11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav|
|11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie|
|11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro|
|11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.|
|14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec|
|15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv|
|24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara|
+-+---+---+--+--+
| Total   14 bugs   |
+---+

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28286] - Loosely couple SingleSignOn Valve and Authenticators

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28286.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28286

Loosely couple SingleSignOn Valve and Authenticators





--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 14:55 ---
After reviewing, I am not going to apply this patch or the other. I don't see
the point of adding complexity and additional interfaces when SSO is used
through a standard Valve (SingleSignOn), which can easily be extended to
implement the needed clustering support.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28263] - Tomcat 5 installer Windows detects JRE instead of JDK

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28263

Tomcat 5 installer Windows detects JRE instead of JDK





--- Additional Comments From [EMAIL PROTECTED]  2004-04-25 22:52 ---
Actually the Function findJavaPath, in installation script, already look for 
the JAVA_HOME environment variable as a first try, and this is correct.
The problem is in the second try, when it looks into Windows Registry.
The high-level algorithm for this function is:

1. Try to read JAVA_HOME environment variable.
2. If it exists, JDK is considered found, end function.
3. Else (JAVA_HOME not defined), try to read Windows Registry for JDK 
installation.
4. If Registry key for JDK is found,

The script for Tomcat 4 correctly do the step 3 looking for the SDK 
installation key. But the Tomcat 5 installation script looks for JRE key in 
the step 3, which is obviously wrong. I don't know why the error was 
introduced in Tomcat 5 installation, since it was correct in Tomcat 4.

But it IS a bug. BTW, the registry keys I'm talking about are conformant to 
all versions of Windows installation for Java SDK from Sun Microsystems, 
including the most recent, 1.4.2_04.

I'm sorry, but I can't believe that a basic bug like that will remain existing 
since it can be easily solved and I already sent a patch.

Which Tomcat project commiter is familiar to the Windows installation script?
Does anyone else agree with me, or everybody agree with mr. Remy Maucherat 
that the error should not be fixed?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: DO NOT REPLY [Bug 28263] -

2004-04-25 Thread correo
Hemos recibido su correo electrónico, en breve nos pondremos en contacto con usted. 
Puede ver mas informacion visite nuestra página www.refugiodegredos.com.
Allí encontrará informacion de nuestro Hostal Refugio de Gredos, el Apartamento 
Almanzor y la Casa Rural Almanzor.

Si quiere reservar, llámenos al 920 34 80 47, 650 90 18 99

Atentamente, conchi



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[GUMP@lsd]: jakarta-tomcat-5/jakarta-tomcat-5 failed

2004-04-25 Thread bobh
To whom it may engage...

This is an automated request, but not an unsolicited one. For help 
understanding the request please visit 
http://gump.apache.org/nagged.html, 
and/or contact [EMAIL PROTECTED]

Project jakarta-tomcat-5 has an issue affecting its community integration, and has 
been outstanding for 16 runs.
The current state is 'Failed', for reason 'Build Failed'

Full details are available at:
http://lsd.student.utwente.nl/gump/jakarta-tomcat-5/jakarta-tomcat-5/index.html
That said, some snippets follow:


Gump provided these annotations:
 - Info - Jar [servlets-default.jar] identifier set to jar basename: [servlets-default]
 - Info - Jar [naming-common.jar] identifier set to jar basename: [naming-common]
 - Info - Jar [naming-resources.jar] identifier set to jar basename: [naming-resources]
 - Info - Jar [catalina.jar] identifier set to jar basename: [catalina]
 - Info - Jar [bootstrap.jar] identifier set to jar basename: [bootstrap]
 - Info - Jar [servlets-common.jar] identifier set to jar basename: [servlets-common]
 - Info - Jar [servlets-invoker.jar] identifier set to jar basename: [servlets-invoker]
 - Info - Dependency on javamail exists, no need to add for property mail.jar.
 - Info - Dependency on jaf exists, no need to add for property activation.jar.
 - Info - Dependency on jakarta-servletapi-5-servlet exists, no need to add for 
property servlet-api.jar.
 - Info - Dependency on jakarta-servletapi-5-jsp exists, no need to add for property 
jsp-api.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property xercesImpl.jar.
 - Info - Dependency on xml-xerces exists, no need to add for property 
xmlParserAPIs.jar.
 - Info - Dependency on jakarta-tomcat-util exists, no need to add for property 
tomcat-util.jar.
 - Info - Dependency on commons-el exists, no need to add for property commons-el.jar.
 - Info - Dependency on commons-logging exists, no need to add for property 
commons-logging-api.jar.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.jar.
 - Info - Dependency on ant exists, no need to add for property ant.home.
 - Info - Dependency on jsse exists, no need to add for property jsse.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.home.
 - Info - Dependency on jmx exists, no need to add for property jmx.jar.
 - Info - Dependency on jmx exists, no need to add for property jmx-tools.jar.
 - Info - Dependency on jndi exists, no need to add for property jndi.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.home.
 - Info - Dependency on jakarta-regexp exists, no need to add for property regexp.jar.
 - Info - Dependency on javamail exists, no need to add for property mail.home.
 - Info - Dependency on jakarta-tomcat-coyote exists, no need to add for property 
tomcat-coyote.home.
 - Info - Dependency on jakarta-tomcat-jasper_tc5 exists, no need to add for property 
jasper.home.
 - Info - Dependency on jaf exists, no need to add for property activation.home.
 - Info - Dependency on commons-modeler exists, no need to add for property 
commons-modeler.home.
 - Info - Dependency on commons-daemon exists, no need to add for property 
commons-daemon.jsvc.tar.gz.
 - Info - Dependency on jakarta-struts exists, no need to add for property struts.home.
 - Info - Enable debug output, due to a sequence of 15 previous errors.
 - Info - Failed with reason build failed


Gump performed this work:
http://lsd.student.utwente.nl/gump/jakarta-tomcat-5/jakarta-tomcat-5/gump_work/build_jakarta-tomcat-5_jakarta-tomcat-5.html
Work Name: build_jakarta-tomcat-5_jakarta-tomcat-5 (Type: Build)
State: Failed
Elapsed: 0 hours, 1 minutes, 20 seconds
Command Line: java -Djava.awt.headless=true 
-Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xml-apis.jar:/data3/gump/xml-xalan/java/build/xalan-unbundled.jar:/data3/gump/xml-commons/java/external/build/xml-apis.jar
 org.apache.tools.ant.Main -debug -Dgump.merge=/data3/gump/gump-install/work/merge.xml 
-Dbuild.sysclasspath=only -Dtomcat33.home=*Unset* 
-Djsp-api.jar=/data3/gump/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar 
-Dtomcat-coyote.home=/data3/gump/jakarta-tomcat-connectors/coyote 
-Djndi.jar=/data3/gump/opt/jndi1_2_1/lib/jndi.jar 
-Dsite2.home=/data3/gump/jakarta-site2 
-DxmlParserAPIs.jar=/data3/gump/xml-xerces2/java/build/xercesImpl.jar 
-Dactivation.home=/data3/gump/opt/jaf-1.0.1 -Djmx.home=/data3/gump/opt/jmx-1_2-ri 
-Djdbc20ext.jar=/data3/gump/opt/jdbc2_0/jdbc2_0-stdext.jar 
-Djmx-tools.jar=/data3/gump/opt/jmx-1_2-ri/lib/jmxtools.jar 
-Dregexp.jar=/data3/gump/jakarta-regexp/build/jakarta-regexp-20040426.jar 
-Dmail.home=/data3/gump/opt/javamail-1.3 -Dant.home=/data3/gump/ant/dist 
-Dcommons-modeler.home=/data3/gump/jakarta-commons/modeler 
-Dcommons-launcher.jar=/data3/gump/jakarta-commons/launcher/dist/bin/commons-launcher.jar
 

DO NOT REPLY [Bug 28286] - Loosely couple SingleSignOn Valve and Authenticators

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28286.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28286

Loosely couple SingleSignOn Valve and Authenticators





--- Additional Comments From [EMAIL PROTECTED]  2004-04-26 05:48 ---
I thought you might feel that way about the 28039 patch, which is one reason 
why I wrote the interface proposal ;-)  And, it's true an interface isn't 
absolutely needed; subclassing would work.  The fact that SingleSignOnEntry is 
not public (and I'm not arguing it should be) is a big stumbling block in 
easily subclassing SingleSignOn, but getting around that problem in a subclass 
is no harder than writing a whole new implementation of an interface.

But, to get subclassing to work effectively, a couple things need to be 
changed:

1) AuthenticatorBase.reauthenticateFromSSO() invokes SingleSignOn.lookup().  
This method returns a SingleSignOnEntry, which is a package protected class.  
This effectively precludes subclassing this method.  

2) SingleSignOn.update() is package protected, again preventing subclassing.

I'm attaching another patch that addresses these two issues by:

1) Changing the way AuthenticatorBase.reauthenticateFromSSO() works so it does 
not need to call SingleSignOn.lookup().  lookup() is now only called 
internally in SingleSignOn, so someone who wished to write a subclass could 
just remove any calls to it, write their own lookup algorithm, and replace 
SingleSignOnEntry with their own class.

2) Makes SingleSignOn.update() protected.

Maybe 3rd time's the charm? ;-)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28286] - Loosely couple SingleSignOn Valve and Authenticators

2004-04-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28286.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28286

Loosely couple SingleSignOn Valve and Authenticators





--- Additional Comments From [EMAIL PROTECTED]  2004-04-26 05:49 ---
Created an attachment (id=11330)
Patch to allow subclassing

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]