Re: [OT] - benchmark on APR stuff
Thanks it works with the cvs head from jmeter (2.1) Peter Jason Brittain schrieb: Peter Rossbach wrote: Hey Peter, I have download and install Jmeter 2.0.3 and want load your testplans, but I got this error: 2005/05/03 06:45:43 INFO - jmeter.gui.action.Load: Loading file: D:\peterlintestplan\concurrent_1.jmx 2005/05/03 06:45:43 ERROR - jmeter.save.SaveService: Problem loading part of file org.apache.avalon.framework.configuration.ConfigurationException: No attribute named class is associated with the configuration element testelement at - [snip] What I made wrong? Apparently JMeter 2.0.3 is too old. :) I downloaded and built JMeter from CVS head, and that allowed me to load and run his test plans. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
WebappClassLoader patch for EBCDIC
Hi,
I have prepared a patch to be able to use properties in native encoding. In
EBCDIC Environment the FileInputStream is localized but not the
ByteArrayInputStream therefore loading a properties using the WebappClassLoader
class loader fails.
Any comment before I commit the attached patch?
Cheers
Jean-Frederic
Index: catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java,v
retrieving revision 1.48
diff -u -r1.48 WebappClassLoader.java
--- catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java
30 Mar 2005 13:01:00 - 1.48
+++ catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java
3 May 2005 06:46:51 -
@@ -354,6 +354,11 @@
*/
protected boolean hasExternalRepositories = false;
+/**
+ * need conversion for properties files
+ */
+protected boolean needConvert = false;
+
/**
* All permission.
@@ -1444,6 +1449,15 @@
public void start() throws LifecycleException {
started = true;
+String encoding = null;
+try {
+encoding = System.getProperty(file.encoding);
+} catch (Exception e) {
+return;
+}
+if (encoding.indexOf(EBCDIC)!=-1) {
+needConvert = true;
+}
}
@@ -1695,6 +1709,8 @@
Resource resource = null;
+boolean fileNeedConvert = false;
+
for (i = 0; (entry == null) (i repositoriesLength); i++) {
try {
@@ -1728,6 +1744,12 @@
return null;
}
+if (needConvert) {
+if (path.endsWith(.properties)) {
+fileNeedConvert = true;
+}
+}
+
// Register the full path for modification checking
// Note: Only syncing on a 'constant' object is needed
synchronized (allPermission) {
@@ -1855,8 +1877,8 @@
byte[] binaryContent = new byte[contentLength];
+int pos = 0;
try {
-int pos = 0;
while (true) {
int n = binaryStream.read(binaryContent, pos,
@@ -1874,6 +1896,14 @@
return null;
}
+if (fileNeedConvert) {
+String str = new String(binaryContent,0,pos);
+try {
+binaryContent = str.getBytes(UTF-8);
+} catch (Exception e) {
+return null;
+}
+}
entry.binaryContent = binaryContent;
// The certificates are only available after the JarEntry
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 130 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-native : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: Build) Work ended in a state of : Failed Elapsed: Command Line: make [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native] - Making all in common make[1]: Entering directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' /bin/sh /usr/local/gump/public/workspace/apache-httpd/dest-03052005/build/libtool --silent --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/dest-03052005/include -g -O2 -g -O2 -pthread -DHAVE_APR -I/usr/local/gump/public/workspace/apr/dest-03052005/include/apr-1 -g -O2 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -I/home/gump/workspaces2/public/workspace/apache-httpd/srclib/pcre -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp12_worker.c /usr/local/gump/public/workspace/apache-httpd/dest-03052005/build/libtool: /usr/local/gump/public/workspace/apache-httpd/dest-03052005/build/libtool: No such file or directory make[1]: *** [jk_ajp12_worker.lo] Error 127 make[1]: Leaving directory `/home/gump/workspaces2/public/workspace/jakarta-tomcat-connectors/jk/native/common' make: *** [all-recursive] Error 1 - To subscribe to this information via syndicated feeds: - RSS: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/rss.xml - Atom: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 14240003052005, brutus:brutus-public:14240003052005 Gump E-mail Identifier (unique within run) #6. -- Apache Gump http://gump.apache.org/ [Instance: brutus] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
Bill Barker wrote: Yeah, that works for me as well. My problem now is that the APRized HTTP Connector dies about 70% of the way through a test when I use the HTTPClient option in JMeter. A thread-dump shows all of the Workers waiting, and the Poller polling, but nothing is happening. It's a bit happier when I There's not much wrong with that situation, since it's a bit hard to tell what the client is doing. Maybe it's the 62 sized poller causing trouble if running on Windows (you should get a message about that), in which case you'd need to build APR from scratch. Is the Acceptor thread still accepting and giving that to the workers ? restrict maxThreads, but it still doesn't finish. The Java HTTP Connector finishes the test fine. Not using the HTTPClient option works Ok, but the actual concurrency level is much lower. It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java
remm2005/05/03 02:36:58
Modified:util/java/org/apache/tomcat/util/net/res
LocalStrings.properties
util/java/org/apache/tomcat/util/net AprEndpoint.java
Log:
- Add missing logging.
Revision ChangesPath
1.8 +1 -0
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Index: LocalStrings.properties
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/res/LocalStrings.properties,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- LocalStrings.properties 24 Apr 2005 13:18:28 - 1.7
+++ LocalStrings.properties 3 May 2005 09:36:58 - 1.8
@@ -12,6 +12,7 @@
endpoint.err.close=Caught exception trying to close socket
endpoint.noProcessor=No Processors - worker thread dead!
+endpoint.accept.fail=Socket accept failed
endpoint.poll.limitedpollsize=Failed to create poller with specified size,
uses 62 instead
endpoint.poll.initfail=Poller creation failed
endpoint.poll.fail=Critical poller failure, restarting poller
1.24 +1 -2
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java
Index: AprEndpoint.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- AprEndpoint.java 28 Apr 2005 12:29:51 - 1.23
+++ AprEndpoint.java 3 May 2005 09:36:58 - 1.24
@@ -686,8 +686,7 @@
// Hand this socket off to an appropriate processor
workerThread.assign(socket, pool);
} catch (Exception e) {
-// FIXME: proper logging
-e.printStackTrace();
+log.error(sm.getString(endpoint.accept.fail), e);
}
// The processor will recycle itself when it finishes
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34723] New: - IIS JK can't handle request under heavy load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34723. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34723 Summary: IIS JK can't handle request under heavy load Product: Tomcat 5 Version: Unknown Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Native:JK AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Using isapi_redirect.dll under IIS, I found that HTTP request is not handled (looks like hang). My enviroment is : * Web server - Windows 2000 SP4 - IIS 5.0 - isapi_redirect.dll (1.2.8 or above) * Servlet - Fedora core 3 - Tomcat 5.0.28 I used the Microsoft Stress Tool with these settings: -- GET /servlet-examples/servlet/RequestInfoExample (delay 10) Concurrent Connection : 30 Test Run time : 1 min. --- When I run the MS Stress tool, the first 10 ~ 30 requests are handled. (verified by tomcat's access log) but all the remaing requests are not processed and the result codes are all '403 forbidden'. When I use web browser, the IIS shows '403 too many connection' or something like that. I'll attach the test result of MS stress tool. Using isapi_redirect 1.2.6, I get the better result (few 403 error ratio about 1/10). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34723] - IIS JK can't handle request under heavy load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34723. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34723 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 12:35 --- Created an attachment (id=14917) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14917action=view) The test result of MS stress tool The test result of MS stress tool for IIS-Tomcat using isapi_redirect.dll v1.2.11 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34723] - IIS JK can't handle request under heavy load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34723. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34723 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 12:56 --- These are additional test results for isapi_redirect.dll v.1.2.8 or above. MS Stress Tool Setting -- Result -- no delay / 30 client -- only first 10~30 request are handled and hang. delay 10ms / 30 client -- results are fine. (fewer 403) delay = 10ms / 30 client -- results are fine. (fewer 403) My PCs are : Windows (IIS) : P4 2.4, 1.5G RAM Linux (Tomcat) : P4 1.8, 1G RAM I think that isapi_redirect.dll can't handle heavy load during short delay. But using 1.2.6, the hang does not occur. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: APR distro
Yoav Shapira wrote: Hi, While I'm following the performance testing with interest, I want to start thinking about packaging for 5.5.11. I imagine HttpAprConnector will be compiled and jarred with the rest of the connector stuff, so that's easy. Right, there's not much to do. We also add HttpAprConnector to the configuration reference, with instructions to download APR from apr.apache.org and follow its installation instructions. Is there a minimum APR version? Yes, we need a page on APR. If possible, it would be good to announce APR support officially when: - SSL support is present - AJP support is present (I'll do that), which should help a few use cases (not that many, though) - it is tested and proven to work (for example, I don't understand Bill's test results), or at least we know which platforms work well (Linux seems ok, which is good as it's the one which is the target for APR - most small one machine servers run Linux; Windows has poller size issues by default; Solairs is behaving in some weird way to be investigated) Or do you want to say stuff without SSL and AJP ? (I'm going to insist on the proven to work part, though) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: APR distro
Hi, If possible, it would be good to announce APR support officially when: - SSL support is present - AJP support is present (I'll do that), which should help a few use cases (not that many, though) - it is tested and proven to work (for example, I don't understand Bill's test results), or at least we know which platforms work well (Linux seems ok, which is good as it's the one which is the target for APR - most small one machine servers run Linux; Windows has poller size issues by default; Solairs is behaving in some weird way to be investigated) Or do you want to say stuff without SSL and AJP ? (I'm going to insist on the proven to work part, though) I agree we should insist on the proven to work part. However, I don't much care about the rest: I'm addressing the documentation only at this point, as enough cooks are stirring the performance pot already ;) So I only have to document what works, and only have to do so before I cut the release ;) Yoav - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34724] New: - Domain for single sign-on cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34724. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34724 Summary: Domain for single sign-on cookie Product: Tomcat 5 Version: 5.5.9 Platform: Other OS/Version: other Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] I have the following setup: - Apache webserver in front of Tomcat 5.5.9 - three 3rd-level domains www.mydomain.xa, search.mydomain.xa, my.mydomain.xa - Single Sign-On valve in Tomcat is activated - Login is handled by my.mydomain.xa and it's corresponding webapp under context /My The problem with the SSO cookie created by Tomcat after successful login is that the domain name stored with the cookie is my.mydomain.xa. Therefore the SSO cookie is not sent by the user agent if a request goes to www.mydomain.xa or search.mydomain.xa and single-sign on is not working for these subdomains. So I need a way to tell tomcat to set '.mydomain.xa' as the domain of the SSO cookie so it will the sent by the user agent for all subdomains. Therefore I introduced the system property 'tomcat.sso.cookie.domain' and added a few lines to AuthenticatorBase.java where the value of named system property is used - if available - to set the SSO cookie's domain (see attached patch). The system property can be set in the startup script for example. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34724] - Domain for single sign-on cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34724. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34724 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 13:40 --- Created an attachment (id=14918) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14918action=view) SSO cookie domain patch -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [OT] - benchmark on APR stuff
my apologies, I forgot to mention you need either the jmeter in my directory or a nightly build to use the testplans. good thing you found the solution. peter lin On 5/3/05, Peter Rossbach [EMAIL PROTECTED] wrote: Thanks it works with the cvs head from jmeter (2.1) Peter Jason Brittain schrieb: Peter Rossbach wrote: Hey Peter, I have download and install Jmeter 2.0.3 and want load your testplans, but I got this error: 2005/05/03 06:45:43 INFO - jmeter.gui.action.Load: Loading file: D:\peterlintestplan\concurrent_1.jmx 2005/05/03 06:45:43 ERROR - jmeter.save.SaveService: Problem loading part of file org.apache.avalon.framework.configuration.ConfigurationException: No attribute named class is associated with the configuration element testelement at - [snip] What I made wrong? Apparently JMeter 2.0.3 is too old. :) I downloaded and built JMeter from CVS head, and that allowed me to load and run his test plans. Cheers. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34724] - Domain for single sign-on cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34724. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34724 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 14:12 --- It's a good use case, but it's not the right way to do it. You should add an optional attribute on the SSO valve instead. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: APR distro
Yoav Shapira wrote: I agree we should insist on the proven to work part. However, I don't much care about the rest: I'm addressing the documentation only at this point, as enough cooks are stirring the performance pot already ;) So I only have to document what works, and only have to do so before I cut the release ;) On the performance front, it's been a while I didn't profile anything. I'm going to try to have the profiler up and running again today. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34723] - IIS JK can't handle request under heavy load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34723. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34723 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 14:36 --- This is not a bug. For those kind of questions, you should first try tomcat-user list. For high load you will need to set the 'cachesize', because for IIS the default value is 10, because this is the limit on workstation version of windows. Since you are using server version adjust to you needs, like 30 or more. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_util.c
mturk 2005/05/03 06:26:13
Modified:jk/native/common jk_util.c
Log:
Use macro for setting params instead sprintf -- No function change.
Add 'connections_per_child' synonim for 'cachesize' that beter reflects
the real purpose of cachesize param.
Revision ChangesPath
1.66 +56 -64jakarta-tomcat-connectors/jk/native/common/jk_util.c
Index: jk_util.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_util.c,v
retrieving revision 1.65
retrieving revision 1.66
diff -u -r1.65 -r1.66
--- jk_util.c 28 Apr 2005 17:02:35 - 1.65
+++ jk_util.c 3 May 2005 13:26:13 - 1.66
@@ -42,11 +42,11 @@
#define LIBPATH_OF_WORKER (ld_path)
#define CMD_LINE_OF_WORKER (cmd_line)
#define NATIVE_LIB_OF_WORKER(native_lib)
-#define PREFIX_OF_WORKERworker
#define HOST_OF_WORKER (host)
#define PORT_OF_WORKER (port)
#define TYPE_OF_WORKER (type)
-#define CACHE_OF_WORKER (cachesize)
+#define CACHE_OF_WORKER_DEPRECATED (cachesize)
+#define CACHE_OF_WORKER (connections_per_child)
#define CACHE_TIMEOUT_OF_WORKER (cache_timeout)
#define RECOVERY_OPTS_OF_WORKER (recovery_options)
#define CONNECT_TIMEOUT_OF_WORKER (connect_timeout)
@@ -89,6 +89,11 @@
#define HUGE_BUFFER_SIZE (8*1024)
#define LOG_LINE_SIZE(1024)
+#define MAKE_WORKER_PARAM(P) \
+strcpy(buf, worker.); \
+strcat(buf, wname); \
+strcat(buf, .);\
+strcat(buf, P)
/*
* define the log format, we're using by default the one from error.log
@@ -360,9 +365,7 @@
if (!m || !wname) {
return NULL;
}
-
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, TYPE_OF_WORKER);
-
+MAKE_WORKER_PARAM(TYPE_OF_WORKER);
return jk_map_get_string(m, buf, DEFAULT_WORKER_TYPE);
}
@@ -372,7 +375,7 @@
if (!m || !wname) {
return NULL;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, DOMAIN_OF_WORKER);
+MAKE_WORKER_PARAM(DOMAIN_OF_WORKER);
return jk_map_get_string(m, buf, def);
}
@@ -382,7 +385,7 @@
if (!m || !wname) {
return NULL;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, REDIRECT_OF_WORKER);
+ MAKE_WORKER_PARAM(REDIRECT_OF_WORKER);
return jk_map_get_string(m, buf, def);
}
@@ -394,7 +397,7 @@
return NULL;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, SECRET_OF_WORKER);
+MAKE_WORKER_PARAM(SECRET_OF_WORKER);
return jk_map_get_string(m, buf, NULL);
}
@@ -409,7 +412,7 @@
char buf[1024];
if (m prop wname pname) {
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, pname);
+MAKE_WORKER_PARAM(pname);
*prop = jk_map_get_string(m, buf, NULL);
if (*prop) {
return JK_TRUE;
@@ -425,7 +428,7 @@
if (m prop wname pname) {
int i;
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, pname);
+MAKE_WORKER_PARAM(pname);
i = jk_map_get_int(m, buf, -1);
if (-1 != i) {
*prop = i;
@@ -443,7 +446,7 @@
return NULL;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, HOST_OF_WORKER);
+MAKE_WORKER_PARAM(HOST_OF_WORKER);
return jk_map_get_string(m, buf, def);
}
@@ -456,7 +459,7 @@
return -1;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, PORT_OF_WORKER);
+MAKE_WORKER_PARAM(PORT_OF_WORKER);
return jk_map_get_int(m, buf, def);
}
@@ -481,13 +484,16 @@
int jk_get_worker_cache_size(jk_map_t *m, const char *wname, int def)
{
char buf[1024];
+int rv;
if (!m || !wname) {
return -1;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname, CACHE_OF_WORKER);
-
+MAKE_WORKER_PARAM(CACHE_OF_WORKER);
+if ((rv = jk_map_get_int(m, buf, -1)) = 0)
+return rv;
+MAKE_WORKER_PARAM(CACHE_OF_WORKER_DEPRECATED);
return jk_map_get_int(m, buf, def);
}
@@ -499,8 +505,7 @@
return -1;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname,
-SOCKET_TIMEOUT_OF_WORKER);
+MAKE_WORKER_PARAM(SOCKET_TIMEOUT_OF_WORKER);
return jk_map_get_int(m, buf, def);
}
@@ -513,8 +518,7 @@
return -1;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname,
-WORKER_RECOVER_TIME);
+MAKE_WORKER_PARAM(WORKER_RECOVER_TIME);
return jk_map_get_int(m, buf, def);
}
@@ -527,8 +531,7 @@
return -1;
}
-sprintf(buf, PREFIX_OF_WORKER .%s.%s, wname,
-SOCKET_BUFFER_OF_WORKER);
+MAKE_WORKER_PARAM(SOCKET_BUFFER_OF_WORKER);
RE: Code Submission - Wild Card Aliases
Does anyone care about sort order? The order that the host names come out in
the proposed code is going to be very random. Part of the reasoning behind
getting the keys was to ensure the elements came back sorted in order.
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Peter Rossbach [mailto:[EMAIL PROTECTED]
Sent: Monday, May 02, 2005 10:28 PM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
Hey Geroge,
I review the mapper patch. Cool!
I think getHosts is a little bit strange:
What you think about this:
public String[] getHosts() {
Host[] hosts ;
synchronized(this) {
hosts=new Host[hmHosts.size()];
hosts=(Host[])hmHosts.values().toArray(hosts);
}
String[] hostNames=new String[hmHosts.size()];
for ( int i = 0; i hosts.length; i++ ) {
hostNames[i] = hosts[i].name;
}
return hostNames ;
}
I thing sync is needed. I miss that also at orginal mapper. The host
values get array you also coded at getContextNames().
Can we change getHost to be protected.
Have you wrote junit testcases for the Mapper ?
Please, extract the testcode. I hate those test code inside
production code :-)
I find you patch very usefull!
Thanks
Peter
George Sexton schrieb:
I have completed the coding in o.a.t.u.http.mapper.Mapper to
implement
wild-card aliases.
If a request for a host is made, and that host is not found,
the code tests
the host and aliases list and looks for wild-cards.
So, a host name of www.mydomain.com would match an alias of
*.mydomain.com.
This additional level of testing is only done if the the
presented host name
is not found in the standard host list. Once a host is found
via wild-card,
it is added to the standard host list. Subsequent requests
for that host
name will find it via the standard search mechanism.
As part of the conversion, I re-worked the test harness code
and expanded it
to be a lot more complete. The output of the new test
harness with the
unmodified Mapper code matches identically the output of the modified
mapper. IOW, I'm 99% confident that the behavior of the
Mapper matches the
old Mapper.
The time differential between the two runs is around 500ms
over 1 million
iterations. I.E. the original code runs in 8000 ms for 1
million iterations
of the testing code, while the new code takes 8500ms. The
new code adds
approximately 0.05 % to the time for a lookup.
I am running the modified mapper code with 5.5.9 on an
installation that has
40 hosts configured and it seems to be working correctly.
I'd really appreciate it if a committer would get this added
to the source
tree.
The complete modified Mapper.java file can be downloaded from:
http://www.mhsoftware.com/~gsexton/Mapper.java
If a decision is made to reject this patch, I'd appreciate
knowing why. If
there's something wrong from a coding or style perspective,
I'd be happy to
fix things.
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-site/docs bugreport.html index.html irc.html resources.html
yoavs 2005/05/03 06:48:12 Modified:docs bugreport.html index.html irc.html resources.html Log: Previous update didn't work, touch and build again. Revision ChangesPath 1.31 +7 -1 jakarta-tomcat-site/docs/bugreport.html Index: bugreport.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/bugreport.html,v retrieving revision 1.30 retrieving revision 1.31 diff -u -r1.30 -r1.31 --- bugreport.html31 Mar 2005 14:21:07 - 1.30 +++ bugreport.html3 May 2005 13:48:12 - 1.31 @@ -77,7 +77,13 @@ a href=http://jakarta.apache.org/site/downloads/downloads_tomcat-5.cgi;Current Releases/a /li li -a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Archived Releases/a +a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Tomcat 5.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-4/;Tomcat 4.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-3/;Tomcat 3.x/a /li /ul p 1.78 +7 -1 jakarta-tomcat-site/docs/index.html Index: index.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v retrieving revision 1.77 retrieving revision 1.78 diff -u -r1.77 -r1.78 --- index.html13 Apr 2005 01:19:46 - 1.77 +++ index.html3 May 2005 13:48:12 - 1.78 @@ -79,7 +79,13 @@ a href=http://jakarta.apache.org/site/downloads/downloads_tomcat-5.cgi;Current Releases/a /li li -a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Archived Releases/a +a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Tomcat 5.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-4/;Tomcat 4.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-3/;Tomcat 3.x/a /li /ul p 1.29 +7 -1 jakarta-tomcat-site/docs/irc.html Index: irc.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/irc.html,v retrieving revision 1.28 retrieving revision 1.29 diff -u -r1.28 -r1.29 --- irc.html 31 Mar 2005 14:21:07 - 1.28 +++ irc.html 3 May 2005 13:48:12 - 1.29 @@ -77,7 +77,13 @@ a href=http://jakarta.apache.org/site/downloads/downloads_tomcat-5.cgi;Current Releases/a /li li -a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Archived Releases/a +a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Tomcat 5.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-4/;Tomcat 4.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-3/;Tomcat 3.x/a /li /ul p 1.34 +7 -1 jakarta-tomcat-site/docs/resources.html Index: resources.html === RCS file: /home/cvs/jakarta-tomcat-site/docs/resources.html,v retrieving revision 1.33 retrieving revision 1.34 diff -u -r1.33 -r1.34 --- resources.html31 Mar 2005 14:21:07 - 1.33 +++ resources.html3 May 2005 13:48:12 - 1.34 @@ -77,7 +77,13 @@ a href=http://jakarta.apache.org/site/downloads/downloads_tomcat-5.cgi;Current Releases/a /li li -a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Archived Releases/a +a href=http://archive.apache.org/dist/jakarta/tomcat-5/;Tomcat 5.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-4/;Tomcat 4.x/a +/li +li +a href=http://archive.apache.org/dist/jakarta/tomcat-3/;Tomcat 3.x/a /li /ul p - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34692] - Error in RUNNING.txt
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34692. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34692 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 15:52 --- Maybe on your platform, whatever it is. Every single system I've ever worked with, it's JAVA_HOME. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34302] - Tomcat doesn't read JDK 1.5 correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34302. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34302 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 15:54 --- Please ask on the tomcat-user mailing list. A VerifyError is almost always a configuration error on your behalf, it's not internal to Tomcat. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
yoavs 2005/05/03 07:00:07 Modified:catalina/src/share/org/apache/catalina/realm JNDIRealm.java webapps/docs changelog.xml Log: Bugzilla 34578. Revision ChangesPath 1.24 +3 -3 jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java Index: JNDIRealm.java === RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java,v retrieving revision 1.23 retrieving revision 1.24 diff -u -r1.23 -r1.24 --- JNDIRealm.java25 Mar 2005 08:29:32 - 1.23 +++ JNDIRealm.java3 May 2005 14:00:07 - 1.24 @@ -1,5 +1,5 @@ /* - * Copyright 1999-2002,2004 The Apache Software Foundation. + * Copyright 1999-2002,2004-2005 The Apache Software Foundation. * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. @@ -1075,7 +1075,7 @@ Name contextName = parser.parse(context.getNameInNamespace()); Name baseName = parser.parse(userBase); -// Bugzilla 32267 +// Bugzilla 32269 Name entryName = parser.parse(new CompositeName(result.getName()).get(0)); Name name = contextName.addAll(baseName); 1.300 +18 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.299 retrieving revision 1.300 diff -u -r1.299 -r1.300 --- changelog.xml 2 May 2005 00:05:02 - 1.299 +++ changelog.xml 3 May 2005 14:00:07 - 1.300 @@ -26,6 +26,24 @@ /p /section +section name=Tomcat 5.5.11 (yoavs) + subsection name=General +changelog +/changelog + /subsection + + subsection name=Catalina +changelog + fix +bug34578/bug: Updated JNDIRealm comment. (yoavs) + /fix + add +[Placeholder for HttpAprConnector] + /add +/changelog + /subsection +/section + section name=Tomcat 5.5.10 (yoavs) subsection name=General changelog - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34614] - Differentiate between global JAR files and those used by webapp config.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34614. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34614 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:03 --- I don't get your point, I don't agree with the it seems part, and I don't see a trivial solution to what I think might be your point. If you want to explain your request in detail, please do so on the tomcat-dev mailing list, so we can have a discussion about it and get it clarified. Bugzilla is not a good discussion forum, and I'll close this issue for now. If we talk on the mailing list and come up with a clear request with examples, etc, this item will be reopened. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32753] - Missing configuration attributes for HTTP connector, when persisting the configuration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32753. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32753 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:03 --- Well, if you try it out in 5.5.10 and it doesn't work, please let us know. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
yoavs 2005/05/03 07:05:44 Modified:webapps/docs changelog.xml Log: Oops, jumped the gun a bit with 5.5.11 in the changelog ;) Revision ChangesPath 1.301 +6 -18 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.300 retrieving revision 1.301 diff -u -r1.300 -r1.301 --- changelog.xml 3 May 2005 14:00:07 - 1.300 +++ changelog.xml 3 May 2005 14:05:44 - 1.301 @@ -26,24 +26,6 @@ /p /section -section name=Tomcat 5.5.11 (yoavs) - subsection name=General -changelog -/changelog - /subsection - - subsection name=Catalina -changelog - fix -bug34578/bug: Updated JNDIRealm comment. (yoavs) - /fix - add -[Placeholder for HttpAprConnector] - /add -/changelog - /subsection -/section - section name=Tomcat 5.5.10 (yoavs) subsection name=General changelog @@ -145,6 +127,12 @@ update Add missing CGI variables to SSI servlet. Patch submitted by Fritz Schneider. (markt) /update + fix +bug34578/bug: Updated JNDIRealm comment. (yoavs) + /fix + add +[Placeholder for HttpAprConnector] + /add /changelog /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33095] - Symbolic links in webapp not working as expected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33095. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33095 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:06 --- Please do not reopen an issue without providing further comment or data. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34349] - cookies=false with request mit session cookie
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34349. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34349 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:10 --- Dietmar, please use the tomcat-user and tomcat-dev mailing lists to solicit clarification, rather than reopening Bugzilla issues. Thank you. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml
yoavs 2005/05/03 07:12:52
Modified:catalina/src/share/org/apache/catalina/startup
Bootstrap.java
webapps/docs changelog.xml
Log:
Bugzilla 34273.
Revision ChangesPath
1.22 +3 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Bootstrap.java
Index: Bootstrap.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/Bootstrap.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- Bootstrap.java21 Aug 2004 19:34:59 - 1.21
+++ Bootstrap.java3 May 2005 14:12:52 - 1.22
@@ -409,6 +409,8 @@
daemon.start();
} else if (command.equals(stop)) {
daemon.stopServer(args);
+} else {
+log.warn(Bootsrap: command \ + command + \ does not
exist.);
}
} catch (Throwable t) {
t.printStackTrace();
1.302 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
Index: changelog.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
retrieving revision 1.301
retrieving revision 1.302
diff -u -r1.301 -r1.302
--- changelog.xml 3 May 2005 14:05:44 - 1.301
+++ changelog.xml 3 May 2005 14:12:52 - 1.302
@@ -133,6 +133,9 @@
add
[Placeholder for HttpAprConnector]
/add
+ fix
+bug34273/bug: Better Bootstrap warning message. [Path from Ralf
Hauser] (yoavs)
+ /fix
/changelog
/subsection
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34292] - Manager app returns 'OK' before app is deployed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34292. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34292 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:14 --- The manager deploys your app and returns. It does not wait for its startup to complete, because your app may have all sorts of servlets, filters, and listeners that do zero to hours of work upon startup. If you'd like a synchronous manager, feel free to write one. The current design is intentional, not a bug. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34546] - Cannot remove first valve from pipeline
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34546. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34546 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:18 --- Please provide a ready-to-test WAR or another setup so we can reproduce the behavior you report. Until that happens, we treat this issue as invalid. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34561] - SecurityConstraints.removeAuthRole(String authRole) doesn't not set boolean authConstraint to false if no more roles.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34561. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34561 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:20 --- This is by design, as the comment for the authConstraint field says. authConstraint may be true without roles for the case of no access at all. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34587] - JDTCompiler can not resolve package org.foo when class org.Foo exists
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34587. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34587 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:21 --- Please reopen a new bug report when you have concrete details, rather than guessing and then withdrawing the guess ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34603] - Tomcat adding none .jar files to classpath when compiling JSPs
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34603. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34603 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:22 --- Stuff in jre/lib/ext gets included, that's the purpose of that directory. If you don't want it include, don't put it there. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34605] - Ignore https chain with the ant deployment tasks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34605. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34605 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |enhancement --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:23 --- Please submit your patch in diff format against the class you'd like us to modify. I'm also changing this to an enhancement request. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml proxy-howto.xml
yoavs 2005/05/03 07:29:26 Modified:webapps/docs changelog.xml proxy-howto.xml Log: Bugzilla 34675. Revision ChangesPath 1.303 +3 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v retrieving revision 1.302 retrieving revision 1.303 diff -u -r1.302 -r1.303 --- changelog.xml 3 May 2005 14:12:52 - 1.302 +++ changelog.xml 3 May 2005 14:29:25 - 1.303 @@ -136,6 +136,9 @@ fix bug34273/bug: Better Bootstrap warning message. [Path from Ralf Hauser] (yoavs) /fix + update +bug34675/bug: Updated Proxy-HowTo page with Servlet API calls. (yoavs) + /update /changelog /subsection 1.7 +5 -3 jakarta-tomcat-catalina/webapps/docs/proxy-howto.xml Index: proxy-howto.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/proxy-howto.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- proxy-howto.xml 8 Jan 2004 14:55:57 - 1.6 +++ proxy-howto.xml 3 May 2005 14:29:25 - 1.7 @@ -21,11 +21,13 @@ processing. When Tomcat is running standalone with the a href=config/coyote.htmlCoyote HTTP/1.1 Connector/a, it will generally report the server name specified in the request, and the port number on -which the strongConnector/strong is listening. The two servlet API +which the strongConnector/strong is listening. The servlet API calls of interest, for this purpose, are:/p ul -licodeServletRequest.getServerName()/code/li -licodeServletRequest.getServerPort()/code/li +licodeServletRequest.getServerName()/code: Returns the host name of the server to which the request was sent./li +licodeServletRequest.getServerPort()/code: Returns the host name of the server to which the request was sent./li +licodeServletRequest.getLocalName()/code: Returns the host name of the Internet Protocol (IP) interface on which the request was received./li +licodeServletRequest.getLocalPort()/code: Returns the Internet Protocol (IP) port number of the interface on which the request was received./li /ul pWhen you are running behind a proxy server (or a web server that is - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34675] - Wrong doc content for Proxy Support
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34675. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34675 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:29 --- I've updated and clarified the documentation per your request. Thank you for pointing this out. In the future, when asking for documentation enhancements, please provide the new text you'd like to see. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34578] - Incorrect bug # reference in comment for fix in JNDIRealm
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34578. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34578 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:00 --- Fixed, thanks for pointing it out. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34273] - Better error message for inexisting bootstrapping commands
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34273. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34273 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:13 --- Patch applied. Thank you. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 1:43 AM Subject: Re: Initial test of APR on Solaris Bill Barker wrote: Yeah, that works for me as well. My problem now is that the APRized HTTP Connector dies about 70% of the way through a test when I use the HTTPClient option in JMeter. A thread-dump shows all of the Workers waiting, and the Poller polling, but nothing is happening. It's a bit happier when I There's not much wrong with that situation, since it's a bit hard to tell what the client is doing. Maybe it's the 62 sized poller causing trouble if running on Windows (you should get a message about that), in which case you'd need to build APR from scratch. Is the Acceptor thread still accepting and giving that to the workers ? Only JMeter is running on Windows, and yes, the Acceptor is still accepting. I'm guessing it's a JMeter problem, since it's just too consistant. restrict maxThreads, but it still doesn't finish. The Java HTTP Connector finishes the test fine. Not using the HTTPClient option works Ok, but the actual concurrency level is much lower. It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Interestingly, the non-HTTPClient option never seems to get above ~62 concurrency. Rémy This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat output to Ant?
Hi all, Does anyone know how the Tomcat can be directed to the Ant output? -- Geertjan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34506] - Default encoding issue running Tomcat on z/os
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34506 [EMAIL PROTECTED] changed: What|Removed |Added Component|Catalina|File Upload Product|Tomcat 5|Commons Version|5.0.28 |unspecified --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:16 --- Moving bug to commons-fileupload. When a new stable release of that component becomes available, we'll use it. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
On 5/2/05, George Sexton [EMAIL PROTECTED] wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. Is there any provision to things from the host list or to limit its size? It seems the behavior of adding wild-card matches to the host list can be easily exploited in a denial of service attack by simply requesting a lot of different host names matching some wild-card until the host list consume all available memory. Jin Yu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Code Submission - Wild Card Aliases
Hi, The performance impact is not that big. If it was a configurable option, e.g. enableAliasWildcardMatching, turned off by default, I'd be OK with it. Yoav -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 10:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild- card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 33492] - When using LDAP realms Tomcat floods the LDAP server with searches instead of binding as a DN
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=33492. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=33492 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:09 --- No further comments or data from OP, closing. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
On 5/3/05, Bill Barker [EMAIL PROTECTED] wrote: - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 1:43 AM Subject: Re: Initial test of APR on Solaris Bill Barker wrote: Yeah, that works for me as well. My problem now is that the APRized HTTP Connector dies about 70% of the way through a test when I use the HTTPClient option in JMeter. A thread-dump shows all of the Workers waiting, and the Poller polling, but nothing is happening. It's a bit happier when I There's not much wrong with that situation, since it's a bit hard to tell what the client is doing. Maybe it's the 62 sized poller causing trouble if running on Windows (you should get a message about that), in which case you'd need to build APR from scratch. Is the Acceptor thread still accepting and giving that to the workers ? Only JMeter is running on Windows, and yes, the Acceptor is still accepting. I'm guessing it's a JMeter problem, since it's just too consistant. I'll try to verify whether this is really an issue with jmeter or something else. peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34480] - Parser chokes on tags within HTML comment block
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34480. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34480 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:24 --- Yup, closing per Mr. Backhouse's comments. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34723] - IIS JK can't handle request under heavy load
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34723. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34723 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:16 --- Hi Mladen Turk, Thanks for your comments. It's great help. I'll try first the tomcat-user list. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Code Submission - Wild Card Aliases
0.05% lower is hardly a sufficient reason to reject this. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 8:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
Bill Barker wrote: It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Interestingly, the non-HTTPClient option never seems to get above ~62 concurrency. This looks suspicious to me, as it's the same constant size as the poller on Windows. Maybe Mladen will have ideas. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Code Submission - Wild Card Aliases
Oops, my bad. In actuality, 1 million requests is taking 8,000,000 microseconds on my computer, or 8 microseconds per mapper call. The modification adds 0.5 microseconds to the call. I think given hideous monstrosities like Struts that are layered on top of Tomcat, 0.5 microseconds per call is hardly worth caring about. The real reason the code is slower is because I simplified the list management. The list management code is extra-ordinarily difficult to follow. It is filled with a lot of special case items that required a deep understanding of the whole in order to modify it. An example of this is the find routine that returns the position of the item, or the insert position. This leaves the code filled with oddities like getting back a result, and then doing a case-insensitive string comparison to see if found really found the right thing. If the mapper were modified very often, it would be a major source of problems. In general I favor maintainability and correctness over raw speed. The DOS issue raised by Jin Yu could be a real issue. I'll think it over some more. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 8:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
+1 BTW, did there is provision to reduce search to only *.mydomain.com ? 2005/5/3, Yoav Shapira [EMAIL PROTECTED]: Hi, The performance impact is not that big. If it was a configurable option, e.g. enableAliasWildcardMatching, turned off by default, I'd be OK with it. Yoav -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 10:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild- card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34693] - Tomcat infinite wait on noised network
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34693. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34693 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 16:31 --- We need more information to reproduce this condition. I haven't been able to reproduce it, so I'm closing this issue for now. Any advice on setting this up would be good. Alternatively, feel free to bring up your situation on the tomcat-user and tomcat-dev mailing lists, and we can try to help there, as it's a better discussion forum than Bugzilla. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
Yoav Shapira wrote: Hi, The performance impact is not that big. If it was a configurable option, e.g. enableAliasWildcardMatching, turned off by default, I'd be OK with it. It's not an excuse to write inefficient code. Replicate that kind of stuff all over the place and you'll see the overall performance will be way worse. So making any exceptions for newly added code is bad. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Code Submission - Wild Card Aliases
OK, if I'm hearing (almost everyone) the issues to address are: 1) Sync getHosts() and getContextNames() 2) Figure out some sort of rate-limiting mechanism to limit DOS - Perhaps this should be configurable with # 3 below. 3) Make wild card matching a configurable option. A question for Yoav - At what entity should this mapper option be set ? Engine? Service? George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 -Original Message- From: Yoav Shapira [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 9:02 AM To: 'Tomcat Developers List' Subject: RE: Code Submission - Wild Card Aliases Hi, The performance impact is not that big. If it was a configurable option, e.g. enableAliasWildcardMatching, turned off by default, I'd be OK with it. Yoav -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 10:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild- card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
Hey Remy and George, I have analyse the patch and find it very usefull. When you have a lot of customer at one tomcat with a lot of virtual hosts and customer can change there subdomains mapping, this * Alias Feature is a great help. I have the next two week limit time, but I thing we can integrate the patch. The performance reduction is very small at production use case/envs. Vote +1 to add this patch with small modifications. . Peter Remy Maucherat schrieb: George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
I also thing that the impact is small but the feature is very usefull. A connector option enableAliasWildcardMatching was a good idea. +1 for the patch again. Peter George Sexton schrieb: 0.05% lower is hardly a sufficient reason to reject this. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 8:04 AM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. As part of the conversion, I re-worked the test harness code and expanded it to be a lot more complete. The output of the new test harness with the unmodified Mapper code matches identically the output of the modified mapper. IOW, I'm 99% confident that the behavior of the Mapper matches the old Mapper. The time differential between the two runs is around 500ms over 1 million iterations. I.E. the original code runs in 8000 ms for 1 million iterations of the testing code, while the new code takes 8500ms. The new code adds approximately 0.05 % to the time for a lookup. I am running the modified mapper code with 5.5.9 on an installation that has 40 hosts configured and it seems to be working correctly. I'd really appreciate it if a committer would get this added to the source tree. The complete modified Mapper.java file can be downloaded from: http://www.mhsoftware.com/~gsexton/Mapper.java If a decision is made to reject this patch, I'd appreciate knowing why. If there's something wrong from a coding or style perspective, I'd be happy to fix things. -1 for lower performance and questionable use case. (I didn't get the patch, but I don't really wish to) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
George Sexton wrote: 0.05% lower is hardly a sufficient reason to reject this. Sure, but since it's my decision and not yours, it's a -1 at the moment. Please read my reply to Yoav. Again, you like the use case, while I think it is useless. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
?? Jin Yu [EMAIL PROTECTED] : On 5/2/05, George Sexton wrote: I have completed the coding in o.a.t.u.http.mapper.Mapper to implement wild-card aliases. If a request for a host is made, and that host is not found, the code tests the host and aliases list and looks for wild-cards. So, a host name of www.mydomain.com would match an alias of *.mydomain.com. This additional level of testing is only done if the the presented host name is not found in the standard host list. Once a host is found via wild-card, it is added to the standard host list. Subsequent requests for that host name will find it via the standard search mechanism. Is there any provision to things from the host list or to limit its size? It seems the behavior of adding wild-card matches to the host list can be easily exploited in a denial of service attack by simply requesting a lot of different host names matching some wild-card until the host list consume all available memory. Jin Yu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] ! \\\|/// \\ - - // ( @ @ ) oOOo- (_)-oOOo :gzlongzhijian QQ(OICQ) 40831127 Q :[EMAIL PROTECTED] :http://www.gzlzj.com 401 :510630 :020-33629058 Oooo oooO ( ) ( ) ) / \ ( (_/ \_) - Do You Yahoo!? 150MP3 1G1000
Re: Initial test of APR on Solaris
Remy Maucherat wrote: Bill Barker wrote: It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Interestingly, the non-HTTPClient option never seems to get above ~62 concurrency. This looks suspicious to me, as it's the same constant size as the poller on Windows. Maybe Mladen will have ideas. Well, I never tried the code on Solaris, so really can not tell. The number looks pretty much like on windows where non-patched apr supports only 63 pollable sockets. I hope I'll have my hands on some Solaris box pretty soon, so I'll see what is the problem. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java LocalStrings.properties
luehe 2005/05/03 10:24:10
Modified:catalina/src/share/org/apache/catalina/core
ApplicationContext.java LocalStrings.properties
Log:
Prevent NPE when passing null path argument in several places
Revision ChangesPath
1.28 +18 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationContext.java
Index: ApplicationContext.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationContext.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- ApplicationContext.java 17 Mar 2005 10:53:44 - 1.27
+++ ApplicationContext.java 3 May 2005 17:24:10 - 1.28
@@ -355,6 +355,10 @@
if (!context.isFilesystemBased())
return null;
+if (path == null) {
+return null;
+}
+
File file = new File(basePath, path);
return (file.getAbsolutePath());
@@ -547,6 +551,15 @@
*/
public Set getResourcePaths(String path) {
+// Validate the path argument
+if (path == null) {
+return null;
+}
+if (!path.startsWith(/)) {
+throw new IllegalArgumentException
+(sm.getString(applicationContext.resourcePaths.iae, path));
+}
+
path = normalize(path);
if (path == null)
return (null);
@@ -867,6 +880,10 @@
*/
private String normalize(String path) {
+if (path == null) {
+return null;
+}
+
String normalized = path;
// Normalize the slashes and add leading slash if necessary
1.21 +1 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/LocalStrings.properties
Index: LocalStrings.properties
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/LocalStrings.properties,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- LocalStrings.properties 19 Apr 2005 18:42:29 - 1.20
+++ LocalStrings.properties 3 May 2005 17:24:10 - 1.21
@@ -1,6 +1,7 @@
applicationContext.attributeEvent=Exception thrown by attributes event
listener
applicationContext.mapping.error=Error during mapping
applicationContext.requestDispatcher.iae=Path {0} does not start with a /
character
+applicationContext.resourcePaths.iae=Path {0} does not start with a /
character
applicationContext.setAttribute.namenull=Name cannot be null
applicationDispatcher.allocateException=Allocate exception for servlet {0}
applicationDispatcher.deallocateException=Deallocate exception for servlet
{0}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
Hey George,
the Mapper is create inside Connector.
I think we must setup the new Connector option before we start the
MapperListener inside Connector.start()
add connector and Mapper property enableAliasWildcardMatching at Connector
o.a.c.connector.Connector L1076
if( this.domain != null ) {
mapper.setEnableAliasWildcardMatching
(this.enableAliasWildcardMatching );
mapperListener.setDomain( domain );
//mapperListener.setEngine( service.getContainer().getName() );
mapperListener.init();
...
}
Peter
George Sexton schrieb:
OK, if I'm hearing (almost everyone) the issues to address are:
1) Sync getHosts() and getContextNames()
2) Figure out some sort of rate-limiting mechanism to limit DOS -
Perhaps this should be configurable with # 3 below.
3) Make wild card matching a configurable option.
A question for Yoav - At what entity should this mapper option be set ?
Engine? Service?
George Sexton
MH Software, Inc.
http://www.mhsoftware.com/
Voice: 303 438 9585
-Original Message-
From: Yoav Shapira [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 9:02 AM
To: 'Tomcat Developers List'
Subject: RE: Code Submission - Wild Card Aliases
Hi,
The performance impact is not that big. If it was a
configurable option,
e.g. enableAliasWildcardMatching, turned off by default, I'd
be OK with it.
Yoav
-Original Message-
From: Remy Maucherat [mailto:[EMAIL PROTECTED]
Sent: Tuesday, May 03, 2005 10:04 AM
To: Tomcat Developers List
Subject: Re: Code Submission - Wild Card Aliases
George Sexton wrote:
I have completed the coding in o.a.t.u.http.mapper.Mapper
to implement
wild-card aliases.
If a request for a host is made, and that host is not
found, the code
tests
the host and aliases list and looks for wild-cards.
So, a host name of www.mydomain.com would match an alias of
*.mydomain.com.
This additional level of testing is only done if the the
presented host
name
is not found in the standard host list. Once a host is
found via wild-
card,
it is added to the standard host list. Subsequent
requests for that host
name will find it via the standard search mechanism.
As part of the conversion, I re-worked the test harness code and
expanded it
to be a lot more complete. The output of the new test
harness with the
unmodified Mapper code matches identically the output of
the modified
mapper. IOW, I'm 99% confident that the behavior of the
Mapper matches
the
old Mapper.
The time differential between the two runs is around 500ms over 1
million
iterations. I.E. the original code runs in 8000 ms for 1 million
iterations
of the testing code, while the new code takes 8500ms. The
new code adds
approximately 0.05 % to the time for a lookup.
I am running the modified mapper code with 5.5.9 on an
installation that
has
40 hosts configured and it seems to be working correctly.
I'd really appreciate it if a committer would get this
added to the
source
tree.
The complete modified Mapper.java file can be downloaded from:
http://www.mhsoftware.com/~gsexton/Mapper.java
If a decision is made to reject this patch, I'd
appreciate knowing why.
If
there's something wrong from a coding or style
perspective, I'd be happy
to
fix things.
-1 for lower performance and questionable use case.
(I didn't get the patch, but I don't really wish to)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
Peter Rossbach wrote: I also thing that the impact is small but the feature is very usefull. A connector option enableAliasWildcardMatching was a good idea. +1 for the patch again. -1 for it. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
George Sexton wrote: OK, if I'm hearing (almost everyone) the issues to address are: 1) Sync getHosts() and getContextNames() 2) Figure out some sort of rate-limiting mechanism to limit DOS - Perhaps this should be configurable with # 3 below. Your feature is uselss, so try to reduce the bloat it will cause: one field only. 3) Make wild card matching a configurable option. 4) Make an efficient implementation of the feature. Yours is not, and I will not withdraw my -1 until it is changed. A question for Yoav - At what entity should this mapper option be set ? Engine? Service? This is done with an attribute on the connector, which is then passed to the mapper. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 9:57 AM Subject: Re: Initial test of APR on Solaris Remy Maucherat wrote: Bill Barker wrote: It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Interestingly, the non-HTTPClient option never seems to get above ~62 concurrency. This looks suspicious to me, as it's the same constant size as the poller on Windows. Maybe Mladen will have ideas. Well, I never tried the code on Solaris, so really can not tell. The number looks pretty much like on windows where non-patched apr supports only 63 pollable sockets. It has to be something with the 1.4 JVM on my XP box, since from the docs it's using j.n.URLConnection. What I see is a low thread-count on the Java Connector, which means that there aren't very many connections active. With the HTTPClient, the thread count happily goes up to the number of threads on the test. I hope I'll have my hands on some Solaris box pretty soon, so I'll see what is the problem. My test box is Solaris7 (the shiny new ones are in production, so I can't use them for testing :). It would be interesting if somebody could try it out on a version that isn't a museum piece ;-). Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34546] - Cannot remove first valve from pipeline
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34546. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34546 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 21:14 --- Reopening so I can find it again. This is a bug in StandardPipeline.removeValve, but it's such a minority use- case that I haven't been in a rush to patch it. I should get to it before 5.5.10 gets roled. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Code Submission - Wild Card Aliases
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 10:44 AM Subject: Re: Code Submission - Wild Card Aliases Peter Rossbach wrote: I also thing that the impact is small but the feature is very usefull. A connector option enableAliasWildcardMatching was a good idea. +1 for the patch again. -1 for it. I'm with Remy on this: -1 for the patch as is. The HashMap is just a really bad idea. Rémy This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Code Submission - Wild Card Aliases
Let me see what I can do. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 -Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 03, 2005 1:32 PM To: Tomcat Developers List Subject: Re: Code Submission - Wild Card Aliases - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 10:44 AM Subject: Re: Code Submission - Wild Card Aliases Peter Rossbach wrote: I also thing that the impact is small but the feature is very usefull. A connector option enableAliasWildcardMatching was a good idea. +1 for the patch again. -1 for it. I'm with Remy on this: -1 for the patch as is. The HashMap is just a really bad idea. Rémy This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34561] - SecurityConstraints.removeAuthRole(String authRole) doesn't not set boolean authConstraint to false if no more roles.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34561. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34561 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 22:02 --- then why is it false until one adds roles? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34603] - Tomcat adding none .jar files to classpath when compiling JSPs
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34603. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34603 --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 22:09 --- Why this property file is in this directory is outside of my control. That besides, adding anything other than .jar files and .class as input to javac is just simply asking for trouble. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34710] - Tomcat 4.1.27. uses almost 100% CPU Memory when run as service
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34710. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34710 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-05-03 23:31 --- Bugzilla is not a forum for asking questions. Please use the tomcat-user mailing list. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Initial test of APR on Solaris
- Original Message - From: Bill Barker [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 11:30 AM Subject: Re: Initial test of APR on Solaris - Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Tuesday, May 03, 2005 9:57 AM Subject: Re: Initial test of APR on Solaris Remy Maucherat wrote: Bill Barker wrote: It's hard to tell what is going wrong. Is there logging showing attempted requests and failure codes ? Interestingly, the non-HTTPClient option never seems to get above ~62 concurrency. This looks suspicious to me, as it's the same constant size as the poller on Windows. Maybe Mladen will have ideas. Well, I never tried the code on Solaris, so really can not tell. The number looks pretty much like on windows where non-patched apr supports only 63 pollable sockets. It has to be something with the 1.4 JVM on my XP box, since from the docs it's using j.n.URLConnection. What I see is a low thread-count on the Java Connector, which means that there aren't very many connections active. With the HTTPClient, the thread count happily goes up to the number of threads on the test. I hope I'll have my hands on some Solaris box pretty soon, so I'll see what is the problem. I can get the test to finish if I synchronize around the 'Poll.poll' statement in the Poller. However, doing this sends the perfomance right through the floor :(. I'm guessing it's a problem with doing an add and/or remove (most likely remove, since it hangs when test threads are finishing) at the same time that it's in the middle of a poll. My test box is Solaris7 (the shiny new ones are in production, so I can't use them for testing :). It would be interesting if somebody could try it out on a version that isn't a museum piece ;-). Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Jocelyne Cerasa/LaDefense/Mazars-Guerard/Fr est absent(e).
Je serai absent(e) du 25/04/2005 au 06/05/2005. Absente le 20 etr 21/12, veuillez en cas de besoin , contacter Charles TERRIERE au 6441. Merci à bientôt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project jakarta-tomcat-jk-ant (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-ant has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-ant : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-ant/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [jkant.jar] identifier set to project name -INFO- Failed with reason build failed -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-ant/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-ant.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-ant (Type: Build) Work ended in a state of : Failed Elapsed: Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only jkant [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar - Buildfile: build.xml BUILD FAILED java.lang.NoClassDefFoundError: org/xml/sax/ext/Attributes2 at org.apache.xerces.parsers.AbstractSAXParser.init(Unknown Source) at org.apache.xerces.parsers.SAXParser.init(Unknown Source) at org.apache.xerces.parsers.SAXParser.init(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl.init(Unknown Source) at org.apache.xerces.jaxp.SAXParserFactoryImpl.newSAXParser(Unknown Source) at org.apache.tools.ant.util.JAXPUtils.newSAXParser(JAXPUtils.java:212) at org.apache.tools.ant.util.JAXPUtils.getNamespaceXMLReader(JAXPUtils.java:169) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:187) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:140) at org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:90) at org.apache.tools.ant.Main.runBuild(Main.java:653) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.Main.start(Main.java:150) at org.apache.tools.ant.Main.main(Main.java:240) Total time: 0 seconds java.lang.NoClassDefFoundError: org/xml/sax/ext/Attributes2 at org.apache.xerces.parsers.AbstractSAXParser.init(Unknown Source) at org.apache.xerces.parsers.SAXParser.init(Unknown Source) at org.apache.xerces.parsers.SAXParser.init(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl.init(Unknown Source) at org.apache.xerces.jaxp.SAXParserFactoryImpl.newSAXParser(Unknown Source) at org.apache.tools.ant.util.JAXPUtils.newSAXParser(JAXPUtils.java:212) at org.apache.tools.ant.util.JAXPUtils.getNamespaceXMLReader(JAXPUtils.java:169) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:187) at org.apache.tools.ant.helper.ProjectHelper2.parse(ProjectHelper2.java:140) at org.apache.tools.ant.ProjectHelper.configureProject(ProjectHelper.java:90) at org.apache.tools.ant.Main.runBuild(Main.java:653) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.Main.start(Main.java:150) at org.apache.tools.ant.Main.main(Main.java:240) org/xml/sax/ext/Attributes2 - To subscribe to this information via syndicated feeds: - RSS: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-ant/rss.xml - Atom: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-ant/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 22001803052005, brutus:brutus-public:22001803052005 Gump E-mail Identifier (unique within run) #20. -- Apache Gump
