RE: [j-t-c] patch for jakarta-tomcat-connectors/jk/native/common/ jk_a jp_common.c
You're right, the code is correct in tomcat 3.3 mod_jk
and conform with the latest patch I submitted in this branch.
The error was introduced in the J-T-C port
/* the right place to add file storage for upload */
if((len = read_into_msg_buff(ep, r, pmsg, l, len)) = 0) {
r-content_read += len;
return JK_AJP13_HAS_RESPONSE;
-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .)
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6
-Original Message-
From: Kevin Seguin [mailto:[EMAIL PROTECTED]]
Sent: Monday, December 17, 2001 4:34 PM
To: 'Tomcat Developers List'
Subject: RE: [j-t-c] patch for
jakarta-tomcat-connectors/jk/native/common/ jk_a jp_common.c
The patch seems valid and the pmsg was passed for this
purpose in previous release of J-T-C but some folks
(didn't remember who) make modifications in mod_jk
part of code and the update was lost.
Seems ok, you could commit :)
done.
This patch fix a real problem and should be also
propagated to Tomcat 3.3.1 mod_jk
i looked at the source on the HEAD of
jakarta-tomcat/src/native/mod_jk and
didn't see a similar problem. it's quite possible that i
missed something
:)
-kevin.
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For
additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5504] New: - Can't read enviroment entries defined in applications web.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504 Can't read enviroment entries defined in applications web.xml Summary: Can't read enviroment entries defined in applications web.xml Product: Tomcat 4 Version: 4.0.1 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I want to define an enviroment entry in my web app's web.xml. As stated in the documentation (http://jakarta.apache.org/tomcat/tomcat-4.0- doc/config/context.html#Environment%20Entries) i can eiher do it in my applications web.xml or in the server.xml. I choose to do it in my application's web.xml with the above xml fragment: env-entry env-entry-namefoo/Name/env-entry-name env-entry-valuexxx/env-entry-value env-entry-typejava.lang.String/env-entry-type /env-entry and i saw that using the above code i couldn't retrieve the value. Context initCtx = new InitialContext(); Context envCtx = (Context)initCtx.lookup(java:comp/env); String temp = (String)envCtx.lookup(foo/Name); then using the above xml fragment in my server.xml solved it. Environment name=foo/Name type=java.lang.String value=xxx/ What should i do to retrieve the value from the web.xml without defining it to server.xml? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5506] New: - NoSuchMethodError (apparently on) getServletContext().setAttribute()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506 NoSuchMethodError (apparently on) getServletContext().setAttribute() Summary: NoSuchMethodError (apparently on) getServletContext().setAttribute() Product: Tomcat 4 Version: 4.0.1 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Normal Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Running Tomat 4.0.1 in standalone mode on Windows NT 4 with JDK 1.3, I get F:\jakarta-tomcat-4.0.1\bincatalina run Using CATALINA_BASE: f:\jakarta-tomcat-4.0.1 Using CATALINA_HOME: f:\jakarta-tomcat-4.0.1 Using CLASSPATH: f:\jakarta-tomcat-4.0.1\bin\bootstrap.jar;d:\jdk1.3 \lib\tools.jar Using JAVA_HOME: d:\jdk1.3 Starting service Tomcat-Standalone Apache Tomcat/4.0.1 Exception during startup processing java.lang.reflect.InvocationTargetException: java.lang.NoSuchMethodError at org.apache.catalina.core.StandardContext.postWorkDirectory (StandardContext.java:3919) at org.apache.catalina.core.StandardContext.start (StandardContext.java:3328) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1123) at org.apache.catalina.core.StandardHost.start(StandardHost.java:612) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1123) at org.apache.catalina.core.StandardEngine.start (StandardEngine.java:307) at org.apache.catalina.core.StandardService.start (StandardService.java:388) at org.apache.catalina.core.StandardServer.start (StandardServer.java:505) at org.apache.catalina.startup.Catalina.start(Catalina.java:776) at org.apache.catalina.startup.Catalina.execute(Catalina.java:681) at org.apache.catalina.startup.Catalina.process(Catalina.java:179) at java.lang.reflect.Method.invoke(Native Method) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:243) StandardContext.java:3919 is // Set the appropriate servlet context attribute getServletContext().setAttribute(Globals.WORK_DIR_ATTR, dir); Barry A Byrne -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5504] - Can't read enviroment entries defined in applications web.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504 Can't read enviroment entries defined in applications web.xml --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 02:54 --- The 'examples' context does this. A few env entries are defined in the server.xml, but most others are in web.xml. The JNDI servlet (called 'Naming' in the servlet examples page) is able to display both (on both the 4.0 branch and the HEAD branch), so it appears it's working fine for me. Could you look at it, and try to find what is different ? Your configuration entries look fine to me, so I can't tell what the problm is. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5506] - NoSuchMethodError (apparently on) getServletContext().setAttribute()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506 NoSuchMethodError (apparently on) getServletContext().setAttribute() [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 03:05 --- I don't understand how that problem can happen unless there's a version mismatch on servlet.jar. ServletContext does have a setAttribute method (http://jakarta.apache.org/tomcat/tomcat-4.0- doc/servletapi/javax/servlet/ServletContext.html), and the version of servlet.jar distributed with Tomcat is the right one. The strange thing is that the servlet API 2.2 already had that call (and I can't remember when it was first introduced). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[VOTES] Tomcat 4.0.2 beta 1
Hi, After some delay, I'd like to release the first beta of Tomcat 4.0.2 this week (the sooner, the better, so I plan to package the release as soon as this vote is considered approved). This release has already been approved, and although there are some issues which will need to be addressed before 4.0.2 final is released, there is no open showstopper problems. A few additional fixes may be made before beta 1 is released. The list of changes and fixes is available at: http://cvs.apache.org/viewcvs.cgi/~checkout~/jakarta-tomcat-4.0/Attic/RELEAS E-NOTES-4.0.2-B1.txt?rev=1.1.2.4 ballot [ ] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [ ] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Servlet Caching problem
You may insert following code in your servlets/jsp pages to avoid proxies/browsers caching contents: response.setHeader(Cache-Control, no-store); response.setHeader(Pragma, no-cache); response.setHeader(Expires, 0); It's an annoying problem due to a dummy assumption made by IE and some proxy servers that caused them to ignore any update from the web server; even if they fetched the newer contents from your web server, they simply drop them and show you the old cached contents. - Original Message - From: rakesh [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 2:59 PM Subject: Servlet Caching problem hi I am facing problem in tomcat 3.2.3 while recompiling the servlet ,whenever i make any changes in any existing servlet but after compiling the servlet its still show me the old output of the servlet because its taking that servlet from caching and its not reffreshing that unless until i don't restart the tomcat server Pls help me to solve this problem thanks Rakesh -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5504] - Can't read enviroment entries defined in applications web.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5504 Can't read enviroment entries defined in applications web.xml [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5507] New: - Swapping sessions causes exceptions and it doesn't work with FileStore
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5507. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5507 Swapping sessions causes exceptions and it doesn't work with FileStore Summary: Swapping sessions causes exceptions and it doesn't work with FileStore Product: Tomcat 4 Version: 4.0.1 Final Platform: Other OS/Version: Other Status: NEW Severity: Critical Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] If I use Manager configured for FileStore like Context path=/dialogus docBase=dialogus debug=0 reloadable=true Logger className=org.apache.catalina.logger.FileLogger prefix=dialogus. suffix=.log timestamp=true/ Manager className=org.apache.catalina.session.PersistentManager debug=0 saveOnRestart=true maxActiveSessions=1000 minIdleSwap=-1 maxIdleSwap=-1 maxIdleBackup=1800 Store className=org.apache.catalina.session.FileStore/ /Manager /Context It causes many problems: - There are two threads which expires sessions running concurently. First in store and second in persistent manager. - The threads load each stored session, test if the one has to expire and (if yes) expire it. The problem of the mechanism is the harmless method StandardSession.setID(), which also stores the session to the manager. Why it is implemented so badly I don't know. The deserialization loads the session and uses the method setId() so during the tests for expiration the old stored session replaces the current, active session and all new values are lost and it is a big shame :- I've posted the three patches to the tomcat-dev list. If it is incorrect, please rewrite the managing mechanism according these problems -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5508] New: - No variable EVAL_BODY_BUFFERED
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5508. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5508 No variable EVAL_BODY_BUFFERED Summary: No variable EVAL_BODY_BUFFERED Product: Tomcat 4 Version: 4.0.1 Final Platform: PC OS/Version: Linux Status: NEW Severity: Blocker Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] == localhost_log.2001-12-19.txt == 2001-12-19 03:11:18 StandardWrapperValve[jsp]: Servlet.service() for servlet jsp threw exception org.apache.jasper.JasperException: Unable to compile class for JSP An error occurred at line: 18 in the jsp file: /index.jsp Generated servlet error: /var/tomcat4/work/localhost/Botfighters/index$jsp.java:141: No variable EVAL_BODY_BUFFERED defined in interface javax.servlet.jsp.tagext.BodyTag. if (_jspx_eval_tags_text_0 == javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_BUFFERED) ^ An error occurred at line: 18 in the jsp file: /index.jsp Generated servlet error: /var/tomcat4/work/localhost/Botfighters/index$jsp.java:147: Method doAfterBody () not found in class botfighters.tags.TextTag. } while (_jspx_th_tags_text_0.doAfterBody() == javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN); ^ An error occurred at line: 18 in the jsp file: /index.jsp Generated servlet error: /var/tomcat4/work/localhost/Botfighters/index$jsp.java:147: No variable EVAL_BODY_AGAIN defined in interface javax.servlet.jsp.tagext.BodyTag. } while (_jspx_th_tags_text_0.doAfterBody() == javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN); ^ /var/tomcat4/work/localhost/Botfighters/index$jsp.java:220: Incompatible type for method. Explicit cast needed to convert java.lang.Throwable to java.lang.Exception. if (pageContext != null) pageContext.handlePageException(t); ^ 4 errors at org.apache.jasper.compiler.Compiler.compile(Compiler.java) at org.apache.jasper.servlet.JspServlet.loadJSP(JspServlet.java) at org.apache.jasper.servlet.JspServlet$JspServletWrapper.loadIfNecessary (JspServlet.java) at org.apache.jasper.servlet.JspServlet$JspServletWrapper.service (JspServlet.java) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java) at javax.servlet.http.HttpServlet.service(HttpServlet.java) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter (ApplicationFilterChain.java) at org.apache.catalina.core.ApplicationFilterChain.doFilter (ApplicationFilterChain.java) at org.apache.catalina.core.StandardWrapperValve.invoke (StandardWrapperValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java) at org.apache.catalina.core.StandardContextValve.invoke (StandardContextValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.authenticator.AuthenticatorBase.invoke (AuthenticatorBase.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java) at org.apache.catalina.core.StandardContext.invoke(StandardContext.java) at org.apache.catalina.core.StandardHostValve.invoke (StandardHostValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.valves.ErrorDispatcherValve.invoke (ErrorDispatcherValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.valves.ErrorReportValve.invoke (ErrorReportValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java) at org.apache.catalina.core.StandardPipeline.invokeNext (StandardPipeline.java) at org.apache.catalina.core.StandardPipeline.invoke (StandardPipeline.java) at
RE: Ever increasing heap size with Tomcat 3.2.3 !!!
Before my manager insists that we switch to JRun, Arg !!! can any of the Tomcat developers help with a problem of an ever increasing heap size of the Tomcat java.exe. ?? (We are running Tomcat 3.2.3 and JRE1.3.1. and the IIS redirector) May I suggest you to switch to Tomcat 3.3 instead which is faster than TC 3.2 and give you better arguments for your manager ?) We are running a load test using LoadRunner scripts on some JSP and servlets that are running under Tomcat. The load is not all that heavy but the heap size of the Tomcat java.exe process keeps growing and growing. We modified the java command line to start with -Xmx128m to allow 128 MB of heap but we still max out after a day or so. We even modified one of our servlets to create a thread that runs Runtime.gc() every 30 seconds. The LoadRunner scripts just keep logging in the same 5 people via our authentication servlet so you would think memory use would level out at some point. Tomcat 3.3 is more efficient in memory allocation and reuse which give you a more stable and less memory hog servlet engine than previous release. Nota that Tomcat 3.3 is the Reference Implementation for Servlet 2.2/JSP 1.1 Also jsp are really faster in TC 3.3 than in TC 3.2 Nothing we do seems to keep the heap size from growing. Are there known issues with Tomcat and heap size?? Doing a web search revealed numerous posts with people having similar problems so I believe there is a problem. The standard response these people receive is to increase the heap size via -Xmx But that seems like a band-aid rather than a real solution. That just delays the inevitable. Any insight as to how to keep the Tomcat process from grabbing more and more memory would be appreciated. Do you try : -Xms128 -Xmx128M ? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5510] New: - How to call ejb deployed in JBoss from Tomcat server.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5510. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5510 How to call ejb deployed in JBoss from Tomcat server. Summary: How to call ejb deployed in JBoss from Tomcat server. Product: Tomcat 3 Version: 3.1 Final Platform: All OS/Version: Windows NT/2K Status: NEW Severity: Blocker Priority: Other Component: Webapps AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, I have create EJB jar file and deployed it into JBoss server. I have access this test EJB from normal java program which is working fine. But when i am trying to run this through Tomcat using Jsp/Servlet Client its giving me lots of problems which are as follow 1.) I have copied all the jboss-client jar files from jboss/client to tomcat/lib 2.) There is no ejb.jar file in tomcat server because of that my Remote and home interface is unable to find EJBOject and EJBHome classe. 3.) There is no such documentation which explain that how to call EJB from tomcat. 4.) I have registerd my servlet in web.xml and then i am calling it from normal HTML file but its giving me 404 error. Please suggest me how best i can proceed with tomcat. waiting for your reply Regards, PRakash -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [VOTES] Tomcat 4.0.2 beta 1
The stuff I'd like to see added in TC 4.0.2 (release) is vmroute for supporting load-balancing via mod_jk ? What about ? - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD...oOOo..(_)..oOOo... PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED]] Sent: Wednesday, December 19, 2001 12:26 PM To: [EMAIL PROTECTED] Subject: [VOTES] Tomcat 4.0.2 beta 1 Hi, After some delay, I'd like to release the first beta of Tomcat 4.0.2 this week (the sooner, the better, so I plan to package the release as soon as this vote is considered approved). This release has already been approved, and although there are some issues which will need to be addressed before 4.0.2 final is released, there is no open showstopper problems. A few additional fixes may be made before beta 1 is released. The list of changes and fixes is available at: http://cvs.apache.org/viewcvs.cgi/~checkout~/jakarta-tomcat-4.0 /Attic/RELEAS E-NOTES-4.0.2-B1.txt?rev=1.1.2.4 ballot [ ] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [ ] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5511] New: - Error upload files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5511. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5511 Error upload files Summary: Error upload files Product: Tomcat 3 Version: 3.2.1 Final Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have apache 1.3.19 + mod_jk + jakarta-tomcat 3.2.1 When I upload file directly to tomcat that i don't have error. If i upload file over apache/mod_jk that i have error. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
The stuff I'd like to see added in TC 4.0.2 (release) is vmroute for supporting load-balancing via mod_jk ? What about ? I thought Costin wanted to do it in another way in his JK2 connector ? There's also the auto configuration which isn't going to be very well documented or working in the first beta, but will be in the final. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util JavaGeneratorTool.java
I can't get code involving index and length right without
a lot of trial and error. Fortunately the internal test
revealed this one.
Larry
-Original Message-
From: Bill Barker [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, December 19, 2001 1:09 AM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Oh, well, I guess I had to screw up eventually :-(
Thanks for cleaning up my mess.
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, December 18, 2001 6:39 PM
Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
larryi 01/12/18 18:39:39
Modified:src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Log:
Fix IndexOutOfBoundsException
Revision ChangesPath
1.5 +1 -1
jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java
Index: JavaGeneratorTool.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java
GeneratorTool.
java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4
+++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5
@@ -78,7 +78,7 @@
continue;
}
- if( (s.length()=endIdx) s.charAt( endIdx ) != '/' ) {
+ if( (s.length()endIdx) s.charAt( endIdx ) != '/' ) {
index = s.indexOf(keywords[i],index+3);
continue;
}
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util J avaGeneratorTool.java
Is Tomcat 3.3 affected by this ?
On Wed, 19 Dec 2001 08:10:52 -0500, Larry Isaacs [EMAIL PROTECTED]
escreveu :
I can't get code involving index and length right without
a lot of trial and error. Fortunately the internal test
revealed this one.
Larry
-Original Message-
From: Bill Barker [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, December 19, 2001 1:09 AM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Oh, well, I guess I had to screw up eventually :-(
Thanks for cleaning up my mess.
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, December 18, 2001 6:39 PM
Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
larryi 01/12/18 18:39:39
Modified:src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Log:
Fix IndexOutOfBoundsException
Revision ChangesPath
1.5 +1 -1
jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java
Index: JavaGeneratorTool.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java
GeneratorTool.
java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4
+++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5
@@ -78,7 +78,7 @@
continue;
}
- if( (s.length()=endIdx) s.charAt( endIdx ) != '/' ) {
+ if( (s.length()endIdx) s.charAt( endIdx ) != '/' ) {
index = s.indexOf(keywords[i],index+3);
continue;
}
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
For additional commands, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 3509] - Apache 1.3.20 mod_webapp Tomcat 4b7 HANGS under Win
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3509. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3509 Apache 1.3.20 mod_webapp Tomcat 4b7 HANGS under Win --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 05:36 --- Apache 1.3 + Tomcat 4.0.1 + mod_webapp Tomcat 4.0.1 hangs when servlet calls url.openStream() -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util J avaGeneratorTool.java
Tomcat 3.3 doesn't throw an exception but the coe in
3.3 doesn't accomplish what was intended. See:
http://nagoya.betaversion.org/bugzilla/show_bug.cgi?id=5365
Bugs in code like this often take more than one try to
fix. Hopefully my commit completes the fix. :-)
Larry
-Original Message-
From: Renato [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, December 19, 2001 6:21 AM
To: Tomcat Developers List
Subject: RE: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
J avaGeneratorTool.java
Is Tomcat 3.3 affected by this ?
On Wed, 19 Dec 2001 08:10:52 -0500, Larry Isaacs
[EMAIL PROTECTED]
escreveu :
I can't get code involving index and length right without
a lot of trial and error. Fortunately the internal test
revealed this one.
Larry
-Original Message-
From: Bill Barker [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, December 19, 2001 1:09 AM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Oh, well, I guess I had to screw up eventually :-(
Thanks for cleaning up my mess.
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, December 18, 2001 6:39 PM
Subject: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
larryi 01/12/18 18:39:39
Modified:src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Log:
Fix IndexOutOfBoundsException
Revision ChangesPath
1.5 +1 -1
jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java
Index: JavaGeneratorTool.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java
GeneratorTool.
java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4
+++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5
@@ -78,7 +78,7 @@
continue;
}
- if( (s.length()=endIdx) s.charAt( endIdx ) != '/' ) {
+ if( (s.length()endIdx) s.charAt( endIdx ) != '/' ) {
index = s.indexOf(keywords[i],index+3);
continue;
}
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
For additional commands, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [VOTES] Tomcat 4.0.2 beta 1
ballot [X] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [X] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Larry -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5506] - NoSuchMethodError (apparently on) getServletContext().setAttribute()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506 NoSuchMethodError (apparently on) getServletContext().setAttribute() [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 05:49 --- I am using the servlet.jar that came with the Tomcat 4-0-1 distibution. This contains the Interface ServletContext. This is implemented in the distribution by org.apache.catalina.core.ApplicationContext. I have tried compiling StandardContext.java and get this error: (essentially the same thing, I think) StandardContext.java:3919: cannot resolve symbol symbol : method setAttribute (java.lang.String,java.io.File) location: interface javax.servlet.ServletContext getServletContext().setAttribute(Globals.WORK_DIR_ATTR, dir); I HAVE checked the classpath (several times) and even compiled ApplicationContext.java into the same directory and updated the classpath (no difference) I also tried casting the second parameter to Object (no difference). I have this version of Java: F:\jakarta-tomcat-4.0.1\common\libd:\jdk1.3\bin\java -version java version 1.3.0 Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.0-C) Java HotSpot(TM) Client VM (build 1.3.0-C, mixed mode) Barry A Byrne -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Difference in the Request class between Tomcat 3.2 and Tomcat 3.3
Hi all, What happened to methods getRemoteAddr, getServerName, getServletPath in the Request class for Tomcat 3.3 ? I had an Interceptor written for Tomcat 3.2 that uses these methods within the Request. How can I access internal servlet information from Request int Tomcat 3.3 ? Thanks again Renato - Brazil. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5513] New: - $CLASSPATH in /usr/bin/dtomcat4 from the RPM package
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5513. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5513 $CLASSPATH in /usr/bin/dtomcat4 from the RPM package Summary: $CLASSPATH in /usr/bin/dtomcat4 from the RPM package Product: Tomcat 4 Version: 4.0.1 Final Platform: PC OS/Version: Linux Status: NEW Severity: Minor Priority: Other Component: Installable Packages AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Tomcat 4.0.1 (installed on RedHat 7.2 using RPM's) This line in /usr/bin/dtomcat4 CP=$CATALINA_HOME/bin/bootstrap.jar should be replaced by: CP=$CLASSPATH:$CATALINA_HOME/bin/bootstrap.jar Otherwise CLASSPATH definitions in, e.g., tomcat4.conf won't be seen by dtomcat4. This is important for (installing of) applications like webMathematica. Regards, Rolf Mertig - Mertig Consulting http://www.mertig.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Difference in the Request class between Tomcat 3.2 and Tomcat 3.3
Just found it... they change names... ( silly me :)) ) On Wed Dec 19 11:54:57 2001, Renato [EMAIL PROTECTED] escreveu : Hi all, What happened to methods getRemoteAddr, getServerName, getServletPath in the Request class for Tomcat 3.3 ? I had an Interceptor written for Tomcat 3.2 that uses these methods within the Request. How can I access internal servlet information from Request int Tomcat 3.3 ? Thanks again Renato - Brazil. -- To unsubscribe, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] For additional commands, e-mail: mailto:tomcat-dev- [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/webapp/java WarpConnector.java
remm01/12/19 06:24:29
Modified:webapp/java WarpConnector.java
Log:
- Temporary fix for compilation problem against TC 4.0.
Revision ChangesPath
1.27 +1 -1 jakarta-tomcat-connectors/webapp/java/WarpConnector.java
Index: WarpConnector.java
===
RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/java/WarpConnector.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- WarpConnector.java2001/12/01 07:20:29 1.26
+++ WarpConnector.java2001/12/19 14:24:29 1.27
@@ -453,7 +453,7 @@
* Lifecycle has no listeners registered, a zero-length array is returned.
*/
public LifecycleListener[] findLifecycleListeners() {
-return lifecycle.findLifecycleListeners();
+return null; // FIXME: lifecycle.findLifecycleListeners();
}
/**
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5506] - NoSuchMethodError (apparently on) getServletContext().setAttribute()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506 NoSuchMethodError (apparently on) getServletContext().setAttribute() [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 07:01 --- I have installed j2sdk 1.3.1-01 and it now executes and even compiles correctly. The problem should be assigned to java.sun.com :-) Barry A Byrne PS: watch out with j2sdk 1.3.0 ! -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
Hi, I have noted that 4 of the jsp tests fail: jsp-tests/jsp/tagext/TagSupport/positiveDoStartTagXML.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTag.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTagXML.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTag.jsp It sounds like a tag library is missing (in my test environment) the line where the exception comes from is TagLibraryInfo tlibInfo=tagInfo.getTagLibrary(); From TestTag.java (of jakarta-watchdog-4.0). The WARP part needs a little review... Cheers Jean-frederic Remy Maucherat wrote: Hi, After some delay, I'd like to release the first beta of Tomcat 4.0.2 this week (the sooner, the better, so I plan to package the release as soon as this vote is considered approved). This release has already been approved, and although there are some issues which will need to be addressed before 4.0.2 final is released, there is no open showstopper problems. A few additional fixes may be made before beta 1 is released. The list of changes and fixes is available at: http://cvs.apache.org/viewcvs.cgi/~checkout~/jakarta-tomcat-4.0/Attic/RELEAS E-NOTES-4.0.2-B1.txt?rev=1.1.2.4 ballot [ ] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [ ] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Ever increasing heap size with Tomcat 3.2.3 !!!
Make sure you don't have lots of logging turned on. Tomcat logs message don't get written to the log files immediately. They go into a queue in memory and a low priority thread later flushes message from this queue to disk. If the server is really busy the log writer thread won't get to execute and messages will back up in the in-memory queue. When the load decreases the queue will be flushed and memory will be released. I've spent a fair amount of time running stress tests on Tomcat 3.2.x using JProbe and I have not seen any memory leaks. Marc Saegesser -Original Message- From: Hawkins, Keith (Keith) [mailto:[EMAIL PROTECTED]] Sent: Tuesday, December 18, 2001 11:34 AM To: [EMAIL PROTECTED]; tomcat-user Subject: Ever increasing heap size with Tomcat 3.2.3 !!! Hello, Before my manager insists that we switch to JRun, can any of the Tomcat developers help with a problem of an ever increasing heap size of the Tomcat java.exe. ?? (We are running Tomcat 3.2.3 and JRE1.3.1. and the IIS redirector) We are running a load test using LoadRunner scripts on some JSP and servlets that are running under Tomcat. The load is not all that heavy but the heap size of the Tomcat java.exe process keeps growing and growing. We modified the java command line to start with -Xmx128m to allow 128 MB of heap but we still max out after a day or so. We even modified one of our servlets to create a thread that runs Runtime.gc() every 30 seconds. The LoadRunner scripts just keep logging in the same 5 people via our authentication servlet so you would think memory use would level out at some point. Nothing we do seems to keep the heap size from growing. Are there known issues with Tomcat and heap size?? Doing a web search revealed numerous posts with people having similar problems so I believe there is a problem. The standard response these people receive is to increase the heap size via -Xmx But that seems like a band-aid rather than a real solution. That just delays the inevitable. Any insight as to how to keep the Tomcat process from grabbing more and more memory would be appreciated. Thanks, Keith -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[Patch] add version information to mod_webapp in Server Header
Hi, I have added server version information of mod_webapp for httpd-2.0. Please take a look to the patches. I have modified mod_webapp.c and added a new file wa_version.h. wa_version.h should be placed under jakarta-tomcat-connectors/webapp/include. By adding this patch, httpd-2.0 will return: == Trying 192.168.1.101... Connected to 192.168.1.101. Escape character is '^]'. HEAD / HTTP/1.0 HTTP/1.1 200 OK Date: Wed, 19 Dec 2001 16:46:57 GMT Server: Apache/2.0.30-dev (Unix) mod_webapp/1.0.2-dev Content-Location: index.html.en Vary: negotiate,accept,accept-language,accept-charset TCN: choice Last-Modified: Sun, 02 Dec 2001 11:55:59 GMT ETag: 1ec7d-5b0-f28811c0;1ed38-947-f28811c0 Accept-Ranges: bytes Content-Length: 1456 Connection: close Content-Type: text/html; charset=ISO-8859-1 Content-Language: en Expires: Wed, 19 Dec 2001 16:46:57 GMT == This is a patch for httpd-2.0 only, but I will try to add one for apache-1.3 once the patches are accepted. Punky __ Do You Yahoo!? Check out Yahoo! Shopping and Yahoo! Auctions for all of your unique holiday gifts! Buy at http://shopping.yahoo.com or bid at http://auctions.yahoo.com mod_webapp.c.diff Description: mod_webapp.c.diff /* = * * * * The Apache Software License, Version 1.1 * * * * Copyright (c) 1999-2001 The Apache Software Foundation. * * All rights reserved.* * * * = * * * * Redistribution and use in source and binary forms, with or without modi- * * fication, are permitted provided that the following conditions are met: * * * * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * * * * 2. Redistributions in binary form must reproduce the above copyright * *notice, this list of conditions and the following disclaimer in the * *documentation and/or other materials provided with the distribution. * * * * 3. The end-user documentation included with the redistribution, if any, * *must include the following acknowlegement: * * * * This product includes software developed by the Apache Software * *Foundation http://www.apache.org/. * * * *Alternately, this acknowlegement may appear in the software itself, if * *and wherever such third-party acknowlegements normally appear. * * * * 4. The names The Jakarta Project, WebApp, and Apache Software * *Foundation must not be used to endorse or promote products derived * *from this software without prior written permission. For written * *permission, please contact [EMAIL PROTECTED].* * * * 5. Products derived from this software may not be called Apache nor may * *Apache appear in their names without prior written permission of the * *Apache Software Foundation.* * * * THIS SOFTWARE IS PROVIDED AS IS AND ANY EXPRESSED OR IMPLIED WARRANTIES * * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY * * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL * * THE APACHE SOFTWARE FOUNDATION OR ITS CONTRIBUTORS BE LIABLE FOR ANY * * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, * * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN * * ANY WAY OUT OF THE USE OF THIS
cvs commit: jakarta-tomcat-4.0 build.xml tomcat.nsi
remm01/12/19 09:02:26
Modified:.build.xml tomcat.nsi
Log:
- Upgrade to NSIS 1.91.
- Use new bz2 compression mode for a dramatic reduction in the size of the
installer (it contains source + binaries, and it's smaller than the binary only
.tar.gz), which is now less than 5M.
Revision ChangesPath
1.53 +2 -2 jakarta-tomcat-4.0/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-4.0/build.xml,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -r1.52 -r1.53
--- build.xml 2001/11/21 18:24:05 1.52
+++ build.xml 2001/12/19 17:02:26 1.53
@@ -224,7 +224,7 @@
copy file=${javaservice.home}/bin/JavaService.exe
tofile=${tomcat.dist}/bin/tomcat.exe /
copy file=tomcat.nsi tofile=${tomcat.dist}/tomcat.nsi /
-exec dir=${tomcat.dist} executable=${nsis.home}\makensis.exe
+exec dir=${tomcat.dist} executable=${nsis.home}\makensis-bz2.exe
arg value=tomcat.nsi /
/exec
move file=${tomcat.dist}/tomcat4.exe
@@ -272,7 +272,7 @@
and
os family=windows /
available file=${javaservice.home}/bin/JavaService.exe /
-available file=${nsis.home}\makensis.exe /
+available file=${nsis.home}\makensis-bz2.exe /
/and
/condition
/target
1.22 +3 -41 jakarta-tomcat-4.0/tomcat.nsi
Index: tomcat.nsi
===
RCS file: /home/cvs/jakarta-tomcat-4.0/tomcat.nsi,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- tomcat.nsi2001/11/21 21:04:52 1.21
+++ tomcat.nsi2001/12/19 17:02:26 1.22
@@ -1,6 +1,6 @@
; Tomcat 4 script for Nullsoft Installer
-; $Id: tomcat.nsi,v 1.21 2001/11/21 21:04:52 remm Exp $
+; $Id: tomcat.nsi,v 1.22 2001/12/19 17:02:26 remm Exp $
Name apache-tomcat-4.1
Caption Apache Tomcat 4.1
@@ -55,6 +55,8 @@
CopyFiles $2\lib\tools.jar $INSTDIR\common\lib 4500
+ WriteUninstaller uninst-tomcat4.exe
+
SectionEnd
Section NT Service (NT/2k/XP only)
@@ -297,47 +299,7 @@
FunctionEnd
-; =
-; DoUpdate Function
-; =
-;
-Function doUpdate
-
- ; This function will be called if a previous Tomcat 4.1 installation has been
- ; found
-
- ReadRegStr $1 HKLM SOFTWARE\Apache\Apache Tomcat 4.1
- IfErrors NoUpdate
-
- MessageBox MB_YESNO|MB_ICONQUESTION \
- A previous installation of Jakarata Tomcat 4.1 has been found in $1.\
- Do you want to upgrade it to the latest version ? IDNO NoUpdate
-
- SetOverwrite ifnewer
- SetOutPath $INSTDIR
- File tomcat.ico
- File LICENSE
- File /r bin
- File /r common
- File /r shared
- File /r logs
- File /r server
- File /r work
- SetOutPath $INSTDIR\webapps
- File /r webapps\ROOT
-
- MessageBox MB_OK Update was successful.
-
- ; Installation over
- Abort
-
-NoUpdate:
-
-FunctionEnd
-
-
UninstallText This will uninstall Apache Tomcat 4.1 from your system:
-UninstallExeName uninst-tomcat4.exe
Section Uninstall
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
PersistentManagerBase.processMaxActiveSwaps()
I've been messing around with PersistentManager, trying to get sessions to swap out based on maxActiveSessions. There's a check in processMaxActiveSwaps(): Session sessions[] = findSessions(); // FIXME: Smarter algorithm (LRU) if (getMaxActiveSessions() = sessions.length) return; And also one in createSession(): if ((maxActiveSessions = 0) (sessions.size() = maxActiveSessions)) throw new IllegalStateException (sm.getString(standardManager.createSession.ise)); I'm not seeing any way that the check in processMaxActiveSwaps() could ever fail, since createSessions() will refuse to create more than maxActiveSession Sessions. Which would mean that processMaxActiveSwaps() never gets any farther than that check, and never swaps anything out. -- Christopher St. John [EMAIL PROTECTED] DistribuTopia http://www.distributopia.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.0.2-B1.txt
jfclere 01/12/19 09:39:47 Modified:.Tag: tomcat_40_branch RELEASE-NOTES-4.0.2-B1.txt Log: Start aranging the WARP part of the readme... Revision ChangesPath No revision No revision 1.1.2.5 +3 -2 jakarta-tomcat-4.0/Attic/RELEASE-NOTES-4.0.2-B1.txt Index: RELEASE-NOTES-4.0.2-B1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/Attic/RELEASE-NOTES-4.0.2-B1.txt,v retrieving revision 1.1.2.4 retrieving revision 1.1.2.5 diff -u -r1.1.2.4 -r1.1.2.5 --- RELEASE-NOTES-4.0.2-B1.txt2001/12/18 21:22:43 1.1.2.4 +++ RELEASE-NOTES-4.0.2-B1.txt2001/12/19 17:39:47 1.1.2.5 @@ -3,7 +3,7 @@ Release Notes = -$Id: RELEASE-NOTES-4.0.2-B1.txt,v 1.1.2.4 2001/12/18 21:22:43 remm Exp $ +$Id: RELEASE-NOTES-4.0.2-B1.txt,v 1.1.2.5 2001/12/19 17:39:47 jfclere Exp $ @@ -259,7 +259,7 @@ mappings, security constraints, and other configuration elements. * Currently, mod_webapp forwards *all* requests under the specified - context path to Tomcat for processing. When Tomcat 4.0 final is released, + context path to Tomcat for processing. In a futher release, it will automatically configure itself to serve static resources from Apache *unless* the resource is subject to filtering, or subject to a security constraint, as defined in web.xml. No extra configuration @@ -276,6 +276,7 @@ * The combination of Apache+Tomcat currently passes all spec validation tests in the jakarta-watchdog-4.0 suite. +The WARP connector for Tomcat 4.0 does not support load balancing at this time. -- Tomcat 4.0 and AJP 1.3: -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Patch] add version information to mod_webapp in Server Header
Punky Tse wrote: Hi, I have added server version information of mod_webapp for httpd-2.0. Please take a look to the patches. I have modified mod_webapp.c and added a new file wa_version.h. wa_version.h should be placed under jakarta-tomcat-connectors/webapp/include. +1 for the new file but it would be better to have something similar to mod_jk. Look to jakarta-tomcat-connectors/jk/native/common/jk_version.h By adding this patch, httpd-2.0 will return: == Trying 192.168.1.101... Connected to 192.168.1.101. Escape character is '^]'. HEAD / HTTP/1.0 HTTP/1.1 200 OK Date: Wed, 19 Dec 2001 16:46:57 GMT Server: Apache/2.0.30-dev (Unix) mod_webapp/1.0.2-dev Content-Location: index.html.en Vary: negotiate,accept,accept-language,accept-charset TCN: choice Last-Modified: Sun, 02 Dec 2001 11:55:59 GMT ETag: 1ec7d-5b0-f28811c0;1ed38-947-f28811c0 Accept-Ranges: bytes Content-Length: 1456 Connection: close Content-Type: text/html; charset=ISO-8859-1 Content-Language: en Expires: Wed, 19 Dec 2001 16:46:57 GMT == This is a patch for httpd-2.0 only, but I will try to add one for apache-1.3 once the patches are accepted. Punky __ Do You Yahoo!? Check out Yahoo! Shopping and Yahoo! Auctions for all of your unique holiday gifts! Buy at http://shopping.yahoo.com or bid at http://auctions.yahoo.com Name: mod_webapp.c.diff mod_webapp.c.diff Type: diff files (text/plain) Encoding: base64 Description: mod_webapp.c.diff /* = * * * * The Apache Software License, Version 1.1 * * * * Copyright (c) 1999-2001 The Apache Software Foundation. * * All rights reserved.* * * * = * * * * Redistribution and use in source and binary forms, with or without modi- * * fication, are permitted provided that the following conditions are met: * * * * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * * * * 2. Redistributions in binary form must reproduce the above copyright * *notice, this list of conditions and the following disclaimer in the * *documentation and/or other materials provided with the distribution. * * * * 3. The end-user documentation included with the redistribution, if any, * *must include the following acknowlegement: * * * * This product includes software developed by the Apache Software * *Foundation http://www.apache.org/. * * * *Alternately, this acknowlegement may appear in the software itself, if * *and wherever such third-party acknowlegements normally appear. * * * * 4. The names The Jakarta Project, WebApp, and Apache Software * *Foundation must not be used to endorse or promote products derived * *from this software without prior written permission. For written * *permission, please contact [EMAIL PROTECTED].* * * * 5. Products derived from this software may not be called Apache nor may * *Apache appear in their names without prior written permission of the * *Apache Software Foundation.* * * * THIS SOFTWARE IS PROVIDED AS IS AND ANY EXPRESSED OR IMPLIED WARRANTIES * * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY * * AND FITNESS FOR A PARTICULAR
Re: [VOTES] Tomcat 4.0.2 beta 1
Hi, Did you rebuild/redploy and test with the latest Watchdog? -rl On Wed, 2001-12-19 at 11:16, jean-frederic clere wrote: Hi, I have noted that 4 of the jsp tests fail: jsp-tests/jsp/tagext/TagSupport/positiveDoStartTagXML.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTag.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTagXML.jsp jsp-tests/jsp/tagext/TagSupport/positiveDoStartTag.jsp It sounds like a tag library is missing (in my test environment) the line where the exception comes from is TagLibraryInfo tlibInfo=tagInfo.getTagLibrary(); From TestTag.java (of jakarta-watchdog-4.0). The WARP part needs a little review... Cheers Jean-frederic Remy Maucherat wrote: Hi, After some delay, I'd like to release the first beta of Tomcat 4.0.2 this week (the sooner, the better, so I plan to package the release as soon as this vote is considered approved). This release has already been approved, and although there are some issues which will need to be addressed before 4.0.2 final is released, there is no open showstopper problems. A few additional fixes may be made before beta 1 is released. The list of changes and fixes is available at: http://cvs.apache.org/viewcvs.cgi/~checkout~/jakarta-tomcat-4.0/Attic/RELEAS E-NOTES-4.0.2-B1.txt?rev=1.1.2.4 ballot [ ] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [ ] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 tomcat.nsi
remm01/12/19 09:53:33 Modified:.tomcat.nsi Log: - Fix a bug where the uninstaller was deleted at the end of the installation (because the way the uninstaller is generated has changed). Revision ChangesPath 1.23 +2 -6 jakarta-tomcat-4.0/tomcat.nsi Index: tomcat.nsi === RCS file: /home/cvs/jakarta-tomcat-4.0/tomcat.nsi,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- tomcat.nsi2001/12/19 17:02:26 1.22 +++ tomcat.nsi2001/12/19 17:53:33 1.23 @@ -1,6 +1,6 @@ ; Tomcat 4 script for Nullsoft Installer -; $Id: tomcat.nsi,v 1.22 2001/12/19 17:02:26 remm Exp $ +; $Id: tomcat.nsi,v 1.23 2001/12/19 17:53:33 remm Exp $ Name apache-tomcat-4.1 Caption Apache Tomcat 4.1 @@ -55,7 +55,7 @@ CopyFiles $2\lib\tools.jar $INSTDIR\common\lib 4500 - WriteUninstaller uninst-tomcat4.exe + WriteUninstaller $INSTDIR\uninst-tomcat4.exe SectionEnd @@ -187,10 +187,6 @@ File /r conf SetOverwrite on - - ; since the installer is now created last (in 1.2+), this makes sure - ; that any old installer that is readonly is overwritten. - Delete $INSTDIR\uninst-tomcat4.exe WriteRegStr HKLM SOFTWARE\Apache\Apache Tomcat 4.1 $INSTDIR WriteRegStr HKLM Software\Microsoft\Windows\CurrentVersion\Uninstall\Apache Tomcat 4.1 \ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 build.xml tomcat.nsi
remm01/12/19 10:00:35
Modified:.Tag: tomcat_40_branch build.xml tomcat.nsi
Log:
- Port enhancements to the installer script, including:
- installer file size reduction, without any change to what is actually in the
archive (from 6.4M to 3.9M)
- use of JAVA_HOME, if present, to find the JDK path
- update to NSIS 1.91
Revision ChangesPath
No revision
No revision
1.38.2.10 +2 -2 jakarta-tomcat-4.0/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-4.0/build.xml,v
retrieving revision 1.38.2.9
retrieving revision 1.38.2.10
diff -u -r1.38.2.9 -r1.38.2.10
--- build.xml 2001/10/27 01:13:00 1.38.2.9
+++ build.xml 2001/12/19 18:00:35 1.38.2.10
@@ -221,7 +221,7 @@
copy file=${javaservice.home}/bin/JavaService.exe
tofile=${tomcat.dist}/bin/tomcat.exe /
copy file=tomcat.nsi tofile=${tomcat.dist}/tomcat.nsi /
-exec dir=${tomcat.dist} executable=${nsis.home}\makensis.exe
+exec dir=${tomcat.dist} executable=${nsis.home}\makensis-bz2.exe
arg value=tomcat.nsi /
/exec
move file=${tomcat.dist}/tomcat4.exe
@@ -269,9 +269,9 @@
target name=prepare-release
condition property=execute.installer
and
-equals arg1=${full.dist} arg2=on /
os family=windows /
available file=${javaservice.home}/bin/JavaService.exe /
+available file=${nsis.home}\makensis-bz2.exe /
/and
/condition
/target
1.16.2.3 +76 -50jakarta-tomcat-4.0/tomcat.nsi
Index: tomcat.nsi
===
RCS file: /home/cvs/jakarta-tomcat-4.0/tomcat.nsi,v
retrieving revision 1.16.2.2
retrieving revision 1.16.2.3
diff -u -r1.16.2.2 -r1.16.2.3
--- tomcat.nsi2001/10/05 00:26:01 1.16.2.2
+++ tomcat.nsi2001/12/19 18:00:35 1.16.2.3
@@ -1,6 +1,6 @@
; Tomcat 4 script for Nullsoft Installer
-; $Id: tomcat.nsi,v 1.16.2.2 2001/10/05 00:26:01 remm Exp $
+; $Id: tomcat.nsi,v 1.16.2.3 2001/12/19 18:00:35 remm Exp $
Name apache-tomcat-4.0
Caption Apache Tomcat 4.0
@@ -50,19 +50,21 @@
File /r webapps\manager
File /r webapps\ROOT
- ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Development Kit CurrentVersion
- ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Development Kit\$1 JavaHome
+ Call findJavaPath
+ Pop $2
CopyFiles $2\lib\tools.jar $INSTDIR\common\lib 4500
+ WriteUninstaller $INSTDIR\uninst-tomcat4.exe
+
SectionEnd
Section NT Service (NT/2k/XP only)
SectionIn 3
- ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Runtime Environment CurrentVersion
- ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$1 RuntimeLib
+ Call findJVMPath
+ Pop $2
SetOutPath $INSTDIR\bin
File /oname=tomcat.exe bin\tomcat.exe
@@ -96,8 +98,8 @@
SectionIn 1 2 3
- ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Runtime Environment CurrentVersion
- ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$1 JavaHome
+ Call findJavaPath
+ Pop $2
SetOutPath $SMPROGRAMS\Apache Tomcat 4.0
@@ -186,10 +188,6 @@
SetOverwrite on
- ; since the installer is now created last (in 1.2+), this makes sure
- ; that any old installer that is readonly is overwritten.
- Delete $INSTDIR\uninst-tomcat4.exe
-
WriteRegStr HKLM SOFTWARE\Apache\Apache Tomcat 4.0 $INSTDIR
WriteRegStr HKLM Software\Microsoft\Windows\CurrentVersion\Uninstall\Apache
Tomcat 4.0 \
DisplayName Apache Tomcat 4.0 (remove only)
@@ -205,71 +203,99 @@
Function .onInit
ClearErrors
+
+ Call findJavaPath
+ Pop $1
+ MessageBox MB_OK Using Java Development Kit found in $1
+
+FunctionEnd
+
+
+Function .onInstSuccess
- Call doUpdate
+ ExecShell open '$SMPROGRAMS\Apache Tomcat 4.0'
+
+FunctionEnd
- ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Development Kit CurrentVersion
- ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Development Kit\$1 JavaHome
+
+; =
+; FindJavaPath Function
+; =
+;
+; Find the JAVA_HOME used on the system, and put the result on the top of the
+; stack
+; Will exit if the path cannot be determined
+;
+Function findJavaPath
+
+ ClearErrors
+
+ ReadEnvStr $1 JAVA_HOME
+
+ IfErrors 0 FoundJDK
+
+ ClearErrors
+
+ ReadRegStr $2 HKLM SOFTWARE\JavaSoft\Java Development Kit CurrentVersion
+ ReadRegStr $1 HKLM SOFTWARE\JavaSoft\Java Development Kit\$2 JavaHome
ReadRegStr $3 HKLM SOFTWARE\JavaSoft\Java Runtime Environment CurrentVersion
ReadRegStr $4 HKLM SOFTWARE\JavaSoft\Java Runtime Environment\$3 RuntimeLib
+ FoundJDK:
+
cvs commit: jakarta-tomcat-connectors/jk/test - New directory
costin 01/12/19 10:09:42 jakarta-tomcat-connectors/jk/test - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/test/org - New directory
costin 01/12/19 10:09:45 jakarta-tomcat-connectors/jk/test/org - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/test/org/apache - New directory
costin 01/12/19 10:09:49 jakarta-tomcat-connectors/jk/test/org/apache - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/test/org/apache/ajp/test - New directory
costin 01/12/19 10:09:56 jakarta-tomcat-connectors/jk/test/org/apache/ajp/test - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5506] - NoSuchMethodError (apparently on) getServletContext().setAttribute()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5506 NoSuchMethodError (apparently on) getServletContext().setAttribute() --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 10:24 --- That's not normal, as JDK 1.3.0 doesn't contain any servlet related classes. Are you sure you didn't have some old servlet classes set as a system extension, or something like that ? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
ballot [X] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: Since 4.0.1, there have been lots of bug fixes. It's time. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Ever increasing heap size with Tomcat 3.2.3 !!!
Hi, I know Tomcat 3.2.3 in a banking production doing heavy work with huge uptimes - no memory leaks have been found (but: OS is Solaris). The only time I thought there were memory leaks was also during stress test in two cases: 1) Having a lot of debug log output (but really a lot) 2) Using JSPs (or Servlets) creating a lot of web container sessions in tomcat Here point 2) perhaps needs further explanation: By default a JSP is embedded in a web container session. This session can be used by the developper to put data in the session, that the same user should be able to use later. Even if the developer does not use a session the pure existence of a session consumes memory. In a JSP you can set the session attribute of the page directive to false, if you don't use web container sessions. In case your stress test calls only small JSPs or servlets, which (implicitely) create sessions, you might end up creating 10s of sessions per second. Such an implicit session has a default timeout of 15 minutes, before it is freed. So it would be interesting how the memory bahaves with respect to time. A general debug strategy: simplify your setup, e.g. throw away all the backend logic in your JSPs/Servlets/helper classes. Reduce to a very simple JSP/Servlet to check, if you can really reproduce the leak in tomcat. Maybe it's in the code of some helper classes? Also if you have a possibility to try under a different platform (like Solaris) this might give an indication. You only need to put tomcat there, you can still leave IIS on Windows as the webserver. Rainer Jung At 17:31 19.12.01 , you wrote: Make sure you don't have lots of logging turned on. Tomcat logs message don't get written to the log files immediately. They go into a queue in memory and a low priority thread later flushes message from this queue to disk. If the server is really busy the log writer thread won't get to execute and messages will back up in the in-memory queue. When the load decreases the queue will be flushed and memory will be released. I've spent a fair amount of time running stress tests on Tomcat 3.2.x using JProbe and I have not seen any memory leaks. Marc Saegesser -Original Message- From: Hawkins, Keith (Keith) [mailto:[EMAIL PROTECTED]] Sent: Tuesday, December 18, 2001 11:34 AM To: [EMAIL PROTECTED]; tomcat-user Subject: Ever increasing heap size with Tomcat 3.2.3 !!! Hello, Before my manager insists that we switch to JRun, can any of the Tomcat developers help with a problem of an ever increasing heap size of the Tomcat java.exe. ?? (We are running Tomcat 3.2.3 and JRE1.3.1. and the IIS redirector) We are running a load test using LoadRunner scripts on some JSP and servlets that are running under Tomcat. The load is not all that heavy but the heap size of the Tomcat java.exe process keeps growing and growing. We modified the java command line to start with -Xmx128m to allow 128 MB of heap but we still max out after a day or so. We even modified one of our servlets to create a thread that runs Runtime.gc() every 30 seconds. The LoadRunner scripts just keep logging in the same 5 people via our authentication servlet so you would think memory use would level out at some point. Nothing we do seems to keep the heap size from growing. Are there known issues with Tomcat and heap size?? Doing a web search revealed numerous posts with people having similar problems so I believe there is a problem. The standard response these people receive is to increase the heap size via -Xmx But that seems like a band-aid rather than a real solution. That just delays the inevitable. Any insight as to how to keep the Tomcat process from grabbing more and more memory would be appreciated. Thanks, Keith -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/test/org/apache/ajp/test TestAjp13.java TestAll.java
costin 01/12/19 11:21:55
Added: jk/test/org/apache/ajp/test TestAjp13.java TestAll.java
Log:
Moved test files to separate dir.
Revision ChangesPath
1.1
jakarta-tomcat-connectors/jk/test/org/apache/ajp/test/TestAjp13.java
Index: TestAjp13.java
===
package org.apache.ajp.test;
import org.apache.ajp.*;
import org.apache.tomcat.util.http.*;
import java.io.*;
import java.net.*;
import java.util.*;
// junit
import junit.framework.*;
public class TestAjp13 extends TestCase {
Ajp13Server server = null;
public TestAjp13(String name) {
super(name);
}
public static Test suite() {
return new TestSuite(TestAjp13.class);
}
protected void setUp() {
println(setup...);
server = new Ajp13Server();
server.start();
}
protected void tearDown() {
println(tear down...);
server.shutdown();
}
public void test1() throws Exception {
println(running test1);
Socket s = new Socket(localhost, 8009);
Ajp13Packet p = new Ajp13Packet(Ajp13.MAX_PACKET_SIZE);
p.appendInt(0x1234);
p.appendInt(0);
p.setByteOff(4);
p.appendByte(RequestHandler.JK_AJP13_FORWARD_REQUEST);
p.appendByte((byte)2);
p.appendString(http);
p.appendString(/test_uri);
p.appendString(remote_addr);
p.appendString(remote_host);
p.appendString(server_name);
p.appendInt(80);
p.appendBool(false);
p.appendInt(3);
p.appendString(my header);
p.appendString(my header value);
p.appendInt((0xA0 8) + RequestHandler.SC_REQ_AUTHORIZATION);
p.appendString(some auth string);
p.appendInt((0xA0 8) + RequestHandler.SC_REQ_USER_AGENT);
p.appendString(TestAjp13 User Agent);
p.appendByte(RequestHandler.SC_A_ARE_DONE);
int len = p.getByteOff() - 4;
p.setByteOff(2);
p.appendInt(len);
OutputStream os = s.getOutputStream();
os.write(p.getBuff(), 0, len + 4);
InputStream is = s.getInputStream();
println(decoding response...);
boolean done = false;
while (!done) {
int b1, b2;
// read a packet
// first 2 bytes should be AB
b1 = is.read();
assertTrue(byte 1 was + (char)b1, b1 == (int)'A');
b2 = is.read();
assertTrue(byte 2 was + (char)b2, b2 == (int)'B');
println(b1 = + (char)b1 + ; b2 = + (char)b2);
// next is length
b1 = is.read();
b1 = 0xFF;
b2 = is.read();
b2 = 0xFF;
int l = (b1 8) + b2;
println(length = + l);
// now get data
byte[] buf = new byte[l];
int n = 0;
int off = 0;
int total = 0;
while ((n = is.read(buf, off, l - off)) != -1 (l - off != 0)) {
total += n;
off += n;
}
println(read + total);
assertTrue(total read was + total +
, should have been + l,
total == l);
int code = (int)buf[0];
switch (code) {
case 3:
println(AJP13_SEND_BODY_CHUNK );
break;
case 4:
println(AJP13_SEND_HEADERS );
break;
case 5:
println(AJP13_END_RESPONSE );
done = true;
break;
case 6:
println(AJP13_GET_BODY_CHUNK );
break;
default:
assertTrue(invalid prefix code: + code, false);
break;
}
}
println(shutting down socket...);
s.shutdownOutput();
s.shutdownInput();
s.close();
println(done test1...);
}
protected static void println(String msg) {
System.out.println([TestAjp13] + msg);
}
public static void main(String[] args) throws Exception {
}
}
class Ajp13Server extends Thread {
boolean shutdown = false;
void shutdown() {
this.shutdown = true;
this.interrupt();
}
public void run() {
try {
ServerSocket server = new ServerSocket(8009);
TestAjp13.println(Ajp13Server running...);
Socket socket = server.accept();
Ajp13 ajp13 = new Ajp13();
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp/test TestAjp13.java TestAll.java
costin 01/12/19 11:22:37 Removed: jk/java/org/apache/ajp/test TestAjp13.java TestAll.java Log: Moved tests to a separate dir. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp Ajp13.java
costin 01/12/19 11:27:43
Modified:jk/java/org/apache/ajp Ajp13.java
Log:
Removed the annoing message reported every time apache restarts. It's normal
operation, not an error.
Revision ChangesPath
1.21 +8 -8 jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13.java
Index: Ajp13.java
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/ajp/Ajp13.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- Ajp13.java2001/11/26 16:53:57 1.20
+++ Ajp13.java2001/12/19 19:27:42 1.21
@@ -423,13 +423,13 @@
logger.log(read got # + got);
}
-// connection just closed by remote
-if (got == 0)
-return JK_AJP13_COMM_CLOSED;
-
-// connection dropped by remote
-if (got 0)
+// connection just closed by remote.
+if (got = 0) {
+// This happens periodically, as apache restarts
+// periodically.
+// It should be more gracefull ! - another feature for Ajp14
return JK_AJP13_COMM_BROKEN;
+}
pos += got;
}
@@ -463,7 +463,7 @@
// - connection broken (JK_AJP13_COMM_BROKEN)
//
if(rd 0) {
-logger.log(bad read: + rd);
+// Most likely normal apache restart.
return rd;
}
@@ -477,7 +477,7 @@
total_read = readN(in, b, H_SIZE, len);
-if (total_read 0) {
+if (total_read = 0) {
logger.log(can't read body, waited # + len);
return JK_AJP13_BAD_BODY;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util J avaGeneratorTool.java
Only the nightly builds from 12/15 until tonight.
- Original Message -
From: Renato [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Wednesday, December 19, 2001 11:21 AM
Subject: RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util J
avaGeneratorTool.java
Is Tomcat 3.3 affected by this ?
On Wed, 19 Dec 2001 08:10:52 -0500, Larry Isaacs [EMAIL PROTECTED]
escreveu :
I can't get code involving index and length right without
a lot of trial and error. Fortunately the internal test
revealed this one.
Larry
-Original Message-
From: Bill Barker [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, December 19, 2001 1:09 AM
To: Tomcat Developers List
Subject: Re: cvs commit:
jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Oh, well, I guess I had to screw up eventually :-(
Thanks for cleaning up my mess.
- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Tuesday, December 18, 2001 6:39 PM
Subject: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util
JavaGeneratorTool.java
larryi 01/12/18 18:39:39
Modified:src/share/org/apache/tomcat/util
JavaGeneratorTool.java
Log:
Fix IndexOutOfBoundsException
Revision ChangesPath
1.5 +1 -1
jakarta-tomcat/src/share/org/apache/tomcat/util/JavaGeneratorTool.java
Index: JavaGeneratorTool.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/Java
GeneratorTool.
java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JavaGeneratorTool.java 2001/12/14 03:55:11 1.4
+++ JavaGeneratorTool.java 2001/12/19 02:39:39 1.5
@@ -78,7 +78,7 @@
continue;
}
- if( (s.length()=endIdx) s.charAt( endIdx ) != '/' ) {
+ if( (s.length()endIdx) s.charAt( endIdx ) != '/' ) {
index = s.indexOf(keywords[i],index+3);
continue;
}
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
For additional commands, e-mail: mailto:tomcat-dev-
[EMAIL PROTECTED]
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 3:25 AM Subject: [VOTES] Tomcat 4.0.2 beta 1 ballot [X ] +1: Make the release [ ] -1: I'm opposed to the release until the following issues are fixed: /ballot There is also a new feature that has been added in the HEAD branch which could be worth porting: the instance pooling for STM servlets. I wrote the code as an experiment, but it appears to be working very well (I didn't notice any thread safety issues during load testing). ballot [X] +1: Add the feature to the 4.0 branch [ ] -1: Don't add the feature, because: /ballot Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 4334] - ServerName in httpd.conf vs. defaultHost in server.xml Error: addChild: Child name 'hostname.myserver.com' is not unique
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4334. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4334 ServerName in httpd.conf vs. defaultHost in server.xml Error: addChild: Child name 'hostname.myserver.com' is not unique --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 12:17 --- My observation re-iterate the observations made by jfclere (2001-11-26 06:40) below (above). If I set the ServerName directive to ServerName Tomcat I consistantly see the problem. If I set the ServerName directive to ServerName tomcat then the problem goes away. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 BUILDING.txt
remm01/12/19 13:08:18
Modified:.Tag: tomcat_40_branch BUILDING.txt
Log:
- Update instructions for getting JAXP.
Submitted by Ryan Lubke.
Revision ChangesPath
No revision
No revision
1.5.2.4 +9 -8 jakarta-tomcat-4.0/BUILDING.txt
Index: BUILDING.txt
===
RCS file: /home/cvs/jakarta-tomcat-4.0/BUILDING.txt,v
retrieving revision 1.5.2.3
retrieving revision 1.5.2.4
diff -u -r1.5.2.3 -r1.5.2.4
--- BUILDING.txt 2001/10/04 19:29:30 1.5.2.3
+++ BUILDING.txt 2001/12/19 21:08:18 1.5.2.4
@@ -1,4 +1,4 @@
-$Id: BUILDING.txt,v 1.5.2.3 2001/10/04 19:29:30 remm Exp $
+$Id: BUILDING.txt,v 1.5.2.4 2001/12/19 21:08:18 remm Exp $
Building The Tomcat 4.0 Servlet/JSP Container
@@ -57,17 +57,18 @@
available, which will be used to actually perform the build.
-(2) Download and Install the JAXP/1.1 Reference Implementation
+(2) Download and Install the Java XML Pack Binary Distribution
-* Download a binary distribution of JAXP 1.1 (Final Version) from:
+* Download a binary distribution of Java XML Pack:
-http://java.sun.com/xml/download.html
+http://java.sun.com/xml/downloads/javaxmlpack.html
* Unpack the binary distribution into a convenient location so that the
- JAXP/1.1 release resides in its own directory (conventionally named
- jaxp-1.1. For the purposes of the remainder of this document, the
- symbolic name ${jaxp.home} is used to refer to the full pathname of
- the release directory.
+ Java XML Pack release resides in its own directory (the JAXP libraries
+ reside in the jaxp-1.1.3 subdirectory). For the purposes of the
+ remainder of this document, the symbolic name ${jaxp.home} is used
+ to refer to the full pathname to the jaxp-1.1.3 subdirectory of the
+ Java XML Pack release directory.
* Make the xalan.jar file of this distribution available to Ant (so that
it can be used with the style tag) by copying it to ${ant.home}/lib.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 BUILDING.txt
remm01/12/19 13:08:36
Modified:.BUILDING.txt
Log:
- Update instructions for getting JAXP.
Submitted by Ryan Lubke.
Revision ChangesPath
1.16 +9 -8 jakarta-tomcat-4.0/BUILDING.txt
Index: BUILDING.txt
===
RCS file: /home/cvs/jakarta-tomcat-4.0/BUILDING.txt,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- BUILDING.txt 2001/12/01 07:32:59 1.15
+++ BUILDING.txt 2001/12/19 21:08:36 1.16
@@ -1,4 +1,4 @@
-$Id: BUILDING.txt,v 1.15 2001/12/01 07:32:59 remm Exp $
+$Id: BUILDING.txt,v 1.16 2001/12/19 21:08:36 remm Exp $
Building The Tomcat 4.0 Servlet/JSP Container
@@ -57,17 +57,18 @@
available, which will be used to actually perform the build.
-(2) Download and Install the JAXP/1.1 Reference Implementation
+(2) Download and Install the Java XML Pack Binary Distribution
-* Download a binary distribution of JAXP 1.1 (Final Version) from:
+* Download a binary distribution of Java XML Pack:
-http://java.sun.com/xml/download.html
+http://java.sun.com/xml/downloads/javaxmlpack.html
* Unpack the binary distribution into a convenient location so that the
- JAXP/1.1 release resides in its own directory (conventionally named
- jaxp-1.1. For the purposes of the remainder of this document, the
- symbolic name ${jaxp.home} is used to refer to the full pathname of
- the release directory.
+ Java XML Pack release resides in its own directory (the JAXP libraries
+ reside in the jaxp-1.1.3 subdirectory). For the purposes of the
+ remainder of this document, the symbolic name ${jaxp.home} is used
+ to refer to the full pathname to the jaxp-1.1.3 subdirectory of the
+ Java XML Pack release directory.
* Make the xalan.jar file of this distribution available to Ant (so that
it can be used with the style tag) by copying it to ${ant.home}/lib.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
On Wed, 19 Dec 2001, Remy Maucherat wrote: The stuff I'd like to see added in TC 4.0.2 (release) is vmroute for supporting load-balancing via mod_jk ? What about ? I thought Costin wanted to do it in another way in his JK2 connector ? There's also the auto configuration which isn't going to be very well documented or working in the first beta, but will be in the final. I am planning some enahncements in jk2, but the basic stuff remains - Manager must append the route id ( regardless of the jk connector / protocol ). Sorry, didn't have time to work on this ( lb ), maybe next release... Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
Costin: Where does Manager get the 'route id' from. Tom - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 1:11 PM Subject: Re: [VOTES] Tomcat 4.0.2 beta 1 | On Wed, 19 Dec 2001, Remy Maucherat wrote: | | The stuff I'd like to see added in TC 4.0.2 (release) | is vmroute for supporting load-balancing via mod_jk ? | | What about ? | | I thought Costin wanted to do it in another way in his JK2 connector ? | There's also the auto configuration which isn't going to be very well | documented or working in the first beta, but will be in the final. | | I am planning some enahncements in jk2, but the basic stuff | remains - Manager must append the route id ( regardless of the jk | connector / protocol ). | | Sorry, didn't have time to work on this ( lb ), maybe next release... | | | Costin | | | | | | | -- | To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] | For additional commands, e-mail: mailto:[EMAIL PROTECTED] | | | -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [VOTES] Tomcat 4.0.2 beta 1
On Wed, 19 Dec 2001, Tom Drake wrote: Costin: Where does Manager get the 'route id' from. Easiest: from server.xml ( just add an option somewhere that can be set on the Manager ). I would make it a property of server or service, as it is an id for the running instance of tomcat. That require setting exactly the same id as the worker name in workers.properties. Harder: the information is sent by apache along with the request. You can check ( in AjpRequest ) if Manager has a 'id' set, and if not set it. That will not solve the problem of 'multiple workers for the same tomcat' - but that shouldn't affect 4.0 ( since a single worker type is available - ajp13 ), and will not be a problem in jk2 ( or if it is, we'll solve it then ) Costin Tom - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 1:11 PM Subject: Re: [VOTES] Tomcat 4.0.2 beta 1 | On Wed, 19 Dec 2001, Remy Maucherat wrote: | | The stuff I'd like to see added in TC 4.0.2 (release) | is vmroute for supporting load-balancing via mod_jk ? | | What about ? | | I thought Costin wanted to do it in another way in his JK2 connector ? | There's also the auto configuration which isn't going to be very well | documented or working in the first beta, but will be in the final. | | I am planning some enahncements in jk2, but the basic stuff | remains - Manager must append the route id ( regardless of the jk | connector / protocol ). | | Sorry, didn't have time to work on this ( lb ), maybe next release... | | | Costin | | | | | | | -- | To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] | For additional commands, e-mail: mailto:[EMAIL PROTECTED] | | | -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
route id
Costin: Should this routing id be an attribute of the one of the Container objects (e.g. Server, Service), instead of the Manager? Tom - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED]; Tom Drake [EMAIL PROTECTED] Sent: Wednesday, December 19, 2001 1:45 PM Subject: Re: [VOTES] Tomcat 4.0.2 beta 1 | On Wed, 19 Dec 2001, Tom Drake wrote: | | Costin: | | Where does Manager get the 'route id' from. | | Easiest: from server.xml ( just add an option somewhere | that can be set on the Manager ). I would make it a | property of server or service, as it is an id for | the running instance of tomcat. | That require setting exactly the same id as the worker | name in workers.properties. | | Harder: the information is sent by apache | along with the request. You can check ( in AjpRequest ) | if Manager has a 'id' set, and if not set it. | | That will not solve the problem of 'multiple workers | for the same tomcat' - but that shouldn't affect 4.0 | ( since a single worker type is available - ajp13 ), | and will not be a problem in jk2 ( or if it is, we'll | solve it then ) | | Costin | | | | | | Tom | - Original Message - | From: [EMAIL PROTECTED] | To: Tomcat Developers List [EMAIL PROTECTED] | Sent: Wednesday, December 19, 2001 1:11 PM | Subject: Re: [VOTES] Tomcat 4.0.2 beta 1 | | | | On Wed, 19 Dec 2001, Remy Maucherat wrote: | | | | The stuff I'd like to see added in TC 4.0.2 (release) | | is vmroute for supporting load-balancing via mod_jk ? | | | | What about ? | | | | I thought Costin wanted to do it in another way in his JK2 connector ? | | There's also the auto configuration which isn't going to be very well | | documented or working in the first beta, but will be in the final. | | | | I am planning some enahncements in jk2, but the basic stuff | | remains - Manager must append the route id ( regardless of the jk | | connector / protocol ). | | | | Sorry, didn't have time to work on this ( lb ), maybe next release... | | | | | | Costin | | | | | | | | | | | | | | -- | | To unsubscribe, e-mail: | mailto:[EMAIL PROTECTED] | | For additional commands, e-mail: | mailto:[EMAIL PROTECTED] | | | | | | | | | -- | To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] | For additional commands, e-mail: mailto:[EMAIL PROTECTED] | | | | -- | To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] | For additional commands, e-mail: mailto:[EMAIL PROTECTED] | | | -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: route id
On Wed, 19 Dec 2001, Tom Drake wrote: Date: Wed, 19 Dec 2001 14:46:30 -0800 From: Tom Drake [EMAIL PROTECTED] Reply-To: Tomcat Developers List [EMAIL PROTECTED], Tom Drake [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Subject: route id Costin: Should this routing id be an attribute of the one of the Container objects (e.g. Server, Service), instead of the Manager? Adding it to Engine would seem to be the easiest. It would then be visible from both the request processing pipeline and from the Manager. If that's ok with everyone, I will add it to both branches. Tom Craig McClanahan -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Tomcat 3.3 deployment - last minute problem
Hi all, i also investigating this problem a little bit, my solution to this is use a filter to convert all the income request's data to UTF8. and generate JSP by UTF8 encoding. it work quite good. but the problem is my backend database must have UTF8 support From Timothy - Original Message - From: Renato [EMAIL PROTECTED] To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Tuesday, December 18, 2001 6:27 PM Subject: Re: Tomcat 3.3 deployment - last minute problem Hi all, I'm investigating this problem and may found something. The html that is pushed to my browser is definitely pure Unicode ( UTF8 ), so somehow the HTML bytes are not been properly translated to chars. Where can I look in the code to make some tests ? Thanks Renato. Reply-to: Tomcat Developers List From: Renato Date: Fri Dec 14 15:19:28 2001 To: Tomcat Developers List , Tomcat Developers List , , Subject: Re: Tomcat 3.3 deployment - last minute problem Hi, This is what I'm using: I saw the servlet generated in the work directory and it actually write the response.setContentType(text/html;charset=ISO-8859-1) ( default type in server.xml is set to ISO-8859-1 too ) How can I know the charset of Linux ? ( I'll STW of course.. :)) ) Thanks for the promptness ! On Fri, 14 Dec 2001 08:48:31 -0800 (PST), escreveu : On Fri, 14 Dec 2001, Renato wrote: *** HTML pages with latin characters don't display correctly on Linux *** ( JSP file with: ) Ex: áéíóú It's maybe a problem with the locale variables on my Linux, which I don't quite understand ( tried LC_ALL, LANG, LC_CTYPE and it didn't work ) or Tomcat itself. Do you set the charset in the page setContentType(text/html;charset=8859-??) or the jsp equivalent ? What charset do you use to write the page ? ( i.e. UTF or 8859-?? ) ? There are few variables: - Java default charset ( which is typically the same as the OS charset). This is what jasper uses to read the page from disk. The page is converted to UTF by the reader. ( you can override the charset used on each page, don't remember the directive ) - output charset. This is specified in setContentType() or setCharEncoding on the response, and is used to convert from UTF to the target charset. Costin -- To unsubscribe: mailto:[EMAIL PROTECTED] For additional commands: mailto:[EMAIL PROTECTED] Troubles with the list: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2 build.xml
costin 01/12/19 16:15:44
Modified:jk build.xml README.txt build.properties.sample
jk/native build.xml
jk/native2 build.xml
Log:
A bit of enhancement to the build system, to make it simpler and smarter
( I hope :-)
The goals are to be able to detect what the user has and require minimal
effort. A second goal is to be able to build on all installed platforms.
( at the same time ).
Revision ChangesPath
1.16 +95 -70jakarta-tomcat-connectors/jk/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.xml,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- build.xml 2001/11/27 00:51:16 1.15
+++ build.xml 2001/12/20 00:15:43 1.16
@@ -10,7 +10,7 @@
property file=${user.home}/build.properties/
property file=${user.home}/.build.properties/
-property name=jk.build value=${basedir}/build/
+property name=jk.build location=${basedir}/build/
!-- Compile options --
property name=optimize value=off /
@@ -21,16 +21,12 @@
location=../../jakarta-tomcat/build/tomcat /
property name=catalina.home
location=../../jakarta-tomcat-4.0/build /
+property name=tomcat41.home
+ location=../../jakarta-tomcat-4.1/build /
-!-- Need to build tomcat-util before jk, XXX automate --
-property name=tomcat-util.jar
- location=../util/build/lib/tomcat-util.jar /
-
path id=build-main.classpath
- pathelement location=${tomcat-util.jar}/
pathelement location=${catalina.home}/server/lib/catalina.jar/
pathelement location=${catalina.home}/common/lib/servlet.jar/
- pathelement location=${junit.jar}/
pathelement location=${tomcat33.home}/lib/common/tomcat_core.jar/
pathelement location=${tomcat33.home}/lib/common/core_util.jar/
pathelement
@@ -51,26 +47,25 @@
/path
!-- Detection and reports --
-
-target name=report-tc3 if=tomcat33.detect
- echo message=Tomcat.33 detected /
-/target
-target name=report-tc4 if=tomcat4.detect
- echo message=Tomcat4 detected /
+target name=report
+echo message=Tomcat33: ${tomcat33.detect} ${tomcat33.home} /
+echo message=Tomcat4: ${tomcat4.detect} ${catalina.home} /
+echo message=Tomcat41: ${tomcat41.detect} ${tomcat41.home} /
+echo message=Apache13: ${apache13.detect} ${apache13.home} /
+echo message=Apache20: ${apache20.detect} ${apache20.home} /
+echo message=iPlanet: ${iplanet.detect} ${iplanet.home} /
+echo message=IIS: ${iis.detect} ${iis.home} /
/target
-target name=report depends=report-tc3,report-tc4 /
-
target name=build-prepare
mkdir dir=${jk.build}/
-mkdir dir=${jk.build}/logs/
mkdir dir=${jk.build}/WEB-INF/
mkdir dir=${jk.build}/WEB-INF/conf/
mkdir dir=${jk.build}/WEB-INF/classes/
+mkdir dir=${jk.build}/WEB-INF/classes/META-INF /
mkdir dir=${jk.build}/WEB-INF/lib/
copy file=conf/web.xml tofile=${jk.build}/WEB-INF/web.xml /
- copy file=${tomcat-util.jar} todir=${jk.build}/WEB-INF/lib /
copy todir=${jk.build}/WEB-INF file=interceptors.xml/
copy todir=${jk.build}/WEB-INF/conf
fileset dir=conf includes=* /
@@ -78,22 +73,24 @@
available property=tomcat33.detect
file=${tomcat33.home}/lib/common/tomcat_core.jar /
available property=tomcat4.detect
file=${catalina.home}/server/lib/catalina.jar /
- echo message=${tomcat4.detect}
file=${catalina.home}/server/lib/catalina.jar /
+available property=tomcat41.detect
file=${tomcat41.home}/server/webapps /
/target
-target name=build-main depends=build-prepare,report
- ant dir=../util antfile=../util/build.xml/
-
+target name=build-main
+depends=build-prepare,report,jkutil,jkjava,jkant /
+
+!-- Building --
+
+target name=jkjava
+description=Build java side of the connector
javac srcdir=java
destdir=${jk.build}/WEB-INF/classes
-deprecation=on
+deprecation=off
debug=${debug}
optimize=${optimize}
-verbose=off
-excludes=**/CVS/**
+verbose=off
exclude name=org/apache/ajp/tomcat4/** unless=tomcat4.detect/
exclude name=org/apache/ajp/tomcat33/** unless=tomcat33.detect/
-exclude name=org/apache/ajp/test/** /
classpath refid=build-main.classpath/
/javac
@@ -105,15
cvs commit: jakarta-tomcat-connectors/jk interceptors.xml
costin 01/12/19 16:16:53 Modified:jk interceptors.xml Log: Update to have both the old module and the new one. Revision ChangesPath 1.2 +4 -0 jakarta-tomcat-connectors/jk/interceptors.xml Index: interceptors.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/interceptors.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- interceptors.xml 2001/10/26 21:19:34 1.1 +++ interceptors.xml 2001/12/20 00:16:53 1.2 @@ -5,8 +5,12 @@ module name=Ajp14 javaClass=org.apache.ajp.tomcat33.Ajp14Interceptor / + module name=Jk2 + javaClass=org.apache.jk.server.tomcat33.Ajp14Interceptor / Ajp14 debug=10 port=8010 password=secret/ + + Jk2 debug=10 port=8011 password=secret/ /ContextManager -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native build.xml
costin 01/12/19 16:39:24
Modified:jk build.properties.sample build.xml
jk/native build.xml
Log:
Few more fixes.
Revision ChangesPath
1.7 +2 -0 jakarta-tomcat-connectors/jk/build.properties.sample
Index: build.properties.sample
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.properties.sample,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- build.properties.sample 2001/12/20 00:15:43 1.6
+++ build.properties.sample 2001/12/20 00:39:24 1.7
@@ -20,6 +20,8 @@
# Location of Apache2, Apache1.3, Netscape, IIS
apache2.home=/opt/apache2
apache13.home=/opt/apache13
+iplanet.home=/opt/iplanet6
+
# APR location - by default the version included in Apache2 is used.
# Don't edit unless you install 'standalone' apr.
1.17 +22 -9 jakarta-tomcat-connectors/jk/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.xml,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- build.xml 2001/12/20 00:15:43 1.16
+++ build.xml 2001/12/20 00:39:24 1.17
@@ -53,7 +53,7 @@
echo message=Tomcat4: ${tomcat4.detect} ${catalina.home} /
echo message=Tomcat41: ${tomcat41.detect} ${tomcat41.home} /
echo message=Apache13: ${apache13.detect} ${apache13.home} /
-echo message=Apache20: ${apache20.detect} ${apache20.home} /
+echo message=Apache2: ${apache2.detect} ${apache2.home} /
echo message=iPlanet: ${iplanet.detect} ${iplanet.home} /
echo message=IIS: ${iis.detect} ${iis.home} /
/target
@@ -71,9 +71,22 @@
fileset dir=conf includes=* /
/copy
-available property=tomcat33.detect
file=${tomcat33.home}/lib/common/tomcat_core.jar /
-available property=tomcat4.detect
file=${catalina.home}/server/lib/catalina.jar /
-available property=tomcat41.detect
file=${tomcat41.home}/server/webapps /
+available property=tomcat33.detect
+ file=${tomcat33.home}/lib/common/tomcat_core.jar /
+available property=tomcat4.detect
+ file=${catalina.home}/server/lib/catalina.jar /
+available property=tomcat41.detect
+ file=${tomcat41.home}/server/webapps /
+available property=tomcat41.detect
+ file=${tomcat41.home}/server/webapps /
+available property=apache13.detect
+ file=${apache13.home} /
+available property=apache2.detect
+ file=${apache2.home} /
+available property=iis.detect
+ file=${iis.home} /
+available property=iplanet.detect
+ file=${iplanet.home} /
/target
target name=build-main
@@ -147,19 +160,19 @@
target name=install
depends=install-t33,install-t40,install-t41,install-a20,install-a13 /
-target name=install-t33 if=tomcat33.detected
+target name=install-t33 if=tomcat33.detect
/target
-target name=install-t40 if=tomcat40.detected
+target name=install-t40 if=tomcat40.detect
/target
-target name=install-t41 if=tomcat41.detected
+target name=install-t41 if=tomcat41.detect
/target
-target name=install-a20 if=apache20.detected
+target name=install-a20 if=apache20.detect
/target
-target name=install-a13 if=apache13.detected
+target name=install-a13 if=apache13.detect
/target
!-- javadocs === --
1.24 +29 -14jakarta-tomcat-connectors/jk/native/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/build.xml,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- build.xml 2001/12/20 00:15:43 1.23
+++ build.xml 2001/12/20 00:39:24 1.24
@@ -33,19 +33,29 @@
!-- Targets --
- target name=main depends=init,apache20,jni
+ target name=main depends=init,apache20,apache13,iis,netscape,jni
/target
target name=init
taskdef resource=META-INF/ant.tasks
classpathref=cp.jkant /
-available property=HAVE_APR file=${apr.include}/apr.h /
+available property=apache13.detect
+ file=${apache13.home} /
+available property=apache20.detect
+ file=${apache20.home} /
+available property=iis.detect
+ file=${iis.home} /
+available property=iplanet.detect
+
DO NOT REPLY [Bug 5523] New: - NoSuchMethodError when trying to reach Tomcat homepage
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5523. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5523 NoSuchMethodError when trying to reach Tomcat homepage Summary: NoSuchMethodError when trying to reach Tomcat homepage Product: Tomcat 4 Version: 4.0 Release Candidate 2 Platform: PC OS/Version: Windows 9x Status: NEW Severity: Critical Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have installed Tomcat4.0.1 on Windows 95. I start the Tomcat-Apache using the starup.bat file. The server starts successfully but when I try to get to the Tomcat home page by entering http://localhost:8080 the server raises a java.lang.NoSuchMethodException at org.apache.catalina.connector.ResponseStream.flush(ResponseStream.jav a:244) at java.io.OutputStreamWriter.flush(Unknown Source) at java.io.PrintWriter.flush(Unknown Source) at org.apache.catalina.connector.ResponseWriter.flush(ResponseWriter.jav a:125) at org.apache.catalina.connector.ResponseBase.finishResponse(ResponseBas e.java:481) at org.apache.catalina.connector.HttpResponseBase.finishResponse(HttpRes ponseBase.java:229) at org.apache.catalina.connector.http.HttpResponseImpl.finishResponse(Ht tpResponseImpl.java:288) at org.apache.catalina.connector.http.HttpProcessor.process(HttpProcesso r.java:1038) at org.apache.catalina.connector.http.HttpProcessor.run(HttpProcessor.ja va:1106) at java.lang.Thread.run(Unknown Source) I cannot proceed with my implementation of a Java Server Page application until this issue is resolved. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5523] - NoSuchMethodError when trying to reach Tomcat homepage
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5523. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5523 NoSuchMethodError when trying to reach Tomcat homepage --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 17:25 --- This kind of thing is caused by either a corrupted installation (delete and reload to try again), or by having JAR files in $JAVA_HOME/jre/lib/ext that should not be there. In particular, the system extensions directory should *not* contain anything that came from the Tomcat install (such as servlet.jar or catalina.jar), and should also *not* contain any JAR files that contain classes Tomcat cares about. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5508] - No variable EVAL_BODY_BUFFERED
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5508. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5508 No variable EVAL_BODY_BUFFERED [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME Summary|No variable |No variable |EVAL_BODY_BUFFERED |EVAL_BODY_BUFFERED --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 17:27 --- Most likely explanation is that you have a servlet.jar from an older servlet container in your Java system extensions directory ($JAVA_HOME/jre/lib/ext). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5497] - JSP include not always including
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5497. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5497 JSP include not always including --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 17:31 --- Tomcat pays no attention at all to changes in files included by the %@ include % directive (it doesn't matter what your browser is). If you want the JSP page to be recompiled, you must modify the timestamp of the JSP page itself. However, there have been other bug fixes lately related to includes. Could you please try this against a recent nightly build? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5489] - Typos in resource-env-ref example
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5489. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5489 Typos in resource-env-ref example [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 17:50 --- It looks like Remy fixed this but forgot to close the bug report. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5486] - Standard EA3 Taglib import does not work with if-modified-since http header field
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5486. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5486 Standard EA3 Taglib import does not work with if-modified-since http header field [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 18:27 --- After reading your bug report three times (and running the attached sample), I'm still a little dense. I can repeatedly run your test client program, and repeatedly get exactly the same output data (with the line that says This should be shown if working correctly) against the latest code in the HEAD branch of Tomcat 4 (i.e. what you'd get with nightly builds). In particular, you did not state what is supposed to be different in the response, so it's not clear if I'm interpreting your report correctly. Therefore, I'm going to close this with WORKSFORME. Feel free to reopen this if you can provide more info to help me understand what's going wrong from your perspective. You will note that every response from Tomcat includes a Date header. If you've configured your browser to do so, it will use this date value in a subsequent If-Modified-Since header for the same request URI. The fact that this seems to make a difference, and that the problem only happens to you in Opera, points to Opera's caching as a potential problem. You could try configuring Netscape to send the If-Modified-Since header (it's controlled by the settings on the Advanced - Cache page) and see if you can observe the same results. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5414] - nested jsp:include doesn't parse expression
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5414. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5414 nested jsp:include doesn't parse expression [EMAIL PROTECTED] changed: What|Removed |Added Component|Catalina|Jasper --- Additional Comments From [EMAIL PROTECTED] 2001-12-19 19:05 --- Reclassifying to correct component (Jasper). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [Patch] add version information to mod_webapp in Server Header
JF, Ok, here is the mod_jk favor version patch. ;-) Actually, the idea of original patch is come from httpd-2.0 itself instead of mod_jk. I had looked at the one in mod_jk, but I chose to use httpd-2.0 one for the first patch because it is much simplier. Anyway, check to see this one. Punky - Original Message - From: jean-frederic clere [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, December 20, 2001 1:49 AM Subject: Re: [Patch] add version information to mod_webapp in Server Header Punky Tse wrote: Hi, I have added server version information of mod_webapp for httpd-2.0. Please take a look to the patches. I have modified mod_webapp.c and added a new file wa_version.h. wa_version.h should be placed under jakarta-tomcat-connectors/webapp/include. +1 for the new file but it would be better to have something similar to mod_jk. Look to jakarta-tomcat-connectors/jk/native/common/jk_version.h By adding this patch, httpd-2.0 will return: == Trying 192.168.1.101... Connected to 192.168.1.101. Escape character is '^]'. HEAD / HTTP/1.0 HTTP/1.1 200 OK Date: Wed, 19 Dec 2001 16:46:57 GMT Server: Apache/2.0.30-dev (Unix) mod_webapp/1.0.2-dev Content-Location: index.html.en Vary: negotiate,accept,accept-language,accept-charset TCN: choice Last-Modified: Sun, 02 Dec 2001 11:55:59 GMT ETag: 1ec7d-5b0-f28811c0;1ed38-947-f28811c0 Accept-Ranges: bytes Content-Length: 1456 Connection: close Content-Type: text/html; charset=ISO-8859-1 Content-Language: en Expires: Wed, 19 Dec 2001 16:46:57 GMT == This is a patch for httpd-2.0 only, but I will try to add one for apache-1.3 once the patches are accepted. Punky __ Do You Yahoo!? Check out Yahoo! Shopping and Yahoo! Auctions for all of your unique holiday gifts! Buy at http://shopping.yahoo.com or bid at http://auctions.yahoo.com -- -- Name: mod_webapp.c.diff mod_webapp.c.diff Type: diff files (text/plain) Encoding: base64 Description: mod_webapp.c.diff -- -- /* = * * * * The Apache Software License, Version 1.1 * * * * Copyright (c) 1999-2001 The Apache Software Foundation. * * All rights reserved. * * * * = * * * * Redistribution and use in source and binary forms, with or without modi- * * fication, are permitted provided that the following conditions are met: * * * * 1. Redistributions of source code must retain the above copyright notice * *notice, this list of conditions and the following disclaimer. * * * * 2. Redistributions in binary form must reproduce the above copyright * *notice, this list of conditions and the following disclaimer in the * *documentation and/or other materials provided with the distribution. * * * * 3. The end-user documentation included with the redistribution, if any, * *must include the following acknowlegement: * * * * This product includes software developed by the Apache Software * *Foundation http://www.apache.org/. * * * *Alternately, this acknowlegement may appear in the software itself, if * *and wherever such third-party acknowlegements normally appear. * * * * 4. The names The Jakarta Project, WebApp, and Apache Software * *Foundation must not be used to endorse or promote products derived * *from this software without prior written permission. For written * *permission, please contact [EMAIL PROTECTED]. * * * * 5. Products derived from this software may not be called Apache nor may * *Apache appear in their names without prior written permission of the * *Apache Software Foundation. * * * * THIS SOFTWARE IS PROVIDED AS IS AND ANY EXPRESSED OR IMPLIED WARRANTIES * * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY * * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL * * THE APACHE SOFTWARE FOUNDATION OR ITS CONTRIBUTORS BE LIABLE FOR ANY * * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, * * STRICT
cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/generators StaticInterceptor.java
billbarker01/12/19 19:38:37
Modified:src/share/org/apache/tomcat/modules/generators
StaticInterceptor.java
Log:
Don't check dates if the static page is part of a jsp:include
This was reported as Bug 5497 against 4.x. In the report, it only happened because
of a buggy browser, but there are still possible (if rare) for a servlet to set the
Last-Modified header. In any case, we can't send a 304 response even if we wanted to
for an included page.
Revision ChangesPath
1.16 +14 -11
jakarta-tomcat/src/share/org/apache/tomcat/modules/generators/StaticInterceptor.java
Index: StaticInterceptor.java
===
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/modules/generators/StaticInterceptor.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- StaticInterceptor.java2001/08/12 02:13:25 1.15
+++ StaticInterceptor.java2001/12/20 03:38:36 1.16
@@ -299,21 +299,24 @@
}
File file = new File( absPath );
-MessageBytes imsMB=req.getMimeHeaders().getValue(If-Modified-Since);
+ // If we are included, the If-Modified-Since isn't for us.
+ if( ! res.isIncluded() ) {
+ MessageBytes imsMB=req.getMimeHeaders().getValue(If-Modified-Since);
-if (imsMB != null) {
+ if (imsMB != null) {
-long date = imsMB.getTime();
+ long date = imsMB.getTime();
+
+ if ((file.lastModified() = (date + 1000)) ) {
+ // The entity has not been modified since the date
+ // specified by the client. This is not an error case.
+ context.getContextManager().handleStatus( req, res, 304);
+ return;
+ }
-if ((file.lastModified() = (date + 1000)) ) {
-// The entity has not been modified since the date
-// specified by the client. This is not an error case.
-context.getContextManager().handleStatus( req, res, 304);
-return;
-}
-
-}
+ }
+ }
if( debug0) log( After paranoic checks = + absPath);
String mimeType=ctx.getMimeMap().getContentTypeFor(absPath);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.1.txt
billbarker01/12/19 19:49:14 Modified:.RELEASE-NOTES-3.3.1.txt Log: Document fix for 304 response on included pages. Revision ChangesPath 1.16 +3 -1 jakarta-tomcat/RELEASE-NOTES-3.3.1.txt Index: RELEASE-NOTES-3.3.1.txt === RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.1.txt,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- RELEASE-NOTES-3.3.1.txt 2001/12/17 02:37:40 1.15 +++ RELEASE-NOTES-3.3.1.txt 2001/12/20 03:49:14 1.16 @@ -3,7 +3,7 @@ Release Notes = -$Id: RELEASE-NOTES-3.3.1.txt,v 1.15 2001/12/17 02:37:40 larryi Exp $ +$Id: RELEASE-NOTES-3.3.1.txt,v 1.16 2001/12/20 03:49:14 billbarker Exp $ This document describes the changes that have been made since the @@ -108,6 +108,8 @@ Fixed the position of the ;jsessionid when Tomcat generates a 401 response. Now it is before the query string instead of after. + +5497 Ignore the If-Modified-Since header when including a static page. Configuration: -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[PATCH] jakarta-tomcat-4.0/webapps/admin
Hi, Please commit my patch to the Head branch. thanks, Manveen Comments: --- Modified server.jsp and service.jsp to use custom tags to generate the list of available actions from each page. Using these custom tags eliminates the need of setting ActionVals in SetUpServer and SetUpService.java Index: server.jsp === RCS file: /home/cvspublic/jakarta-tomcat-4.0/webapps/admin/server.jsp,v retrieving revision 1.2 diff -u -r1.2 server.jsp --- server.jsp 2001/12/11 22:54:12 1.2 +++ server.jsp 2001/12/19 22:58:49 @@ -4,6 +4,7 @@ %@ taglib uri=/WEB-INF/struts-bean.tld prefix=bean % %@ taglib uri=/WEB-INF/struts-html.tld prefix=html % %@ taglib uri=/WEB-INF/struts-logic.tld prefix=logic % +%@ taglib uri=/WEB-INF/controls.tld prefix=controls % html:html locale=true @@ -23,11 +24,13 @@ /td td align=right nowrap div class=page-title-text - html:select property=action - bean:define id=actionVals name=serverForm property=actionVals/ - html:options collection=actionVals -property=value labelProperty=label/ -/html:select +controls:actions +controls:action selected=true bean:message +key=actions.available.actions/ /controls:action +controls:action - /controls:action +!-- will add the urls later once those screens get implemented -- +controls:action url= bean:message key=actions.services.create/ +/controls:action +controls:action url= bean:message key=actions.services.delete/ +/controls:action +/controls:actions /div /td /tr Index: service.jsp === RCS file: /home/cvspublic/jakarta-tomcat-4.0/webapps/admin/service.jsp,v retrieving revision 1.1 diff -u -r1.1 service.jsp --- service.jsp 2001/12/14 23:22:33 1.1 +++ service.jsp 2001/12/19 22:58:50 @@ -4,6 +4,7 @@ %@ taglib uri=/WEB-INF/struts-bean.tld prefix=bean % %@ taglib uri=/WEB-INF/struts-html.tld prefix=html % %@ taglib uri=/WEB-INF/struts-logic.tld prefix=logic % +%@ taglib uri=/WEB-INF/controls.tld prefix=controls % html:html locale=true @@ -28,11 +29,33 @@ /td td width=19% div align=right - html:select property=action - bean:define id=actionVals name=serviceForm property=actionVals/ - html:options collection=actionVals - property=value labelProperty=label/ -/html:select +controls:actions +controls:action selected=true -bean:message +key=actions.available.actions/- /controls:action +controls:action - /controls:action +!-- will add the urls later once those screens get implemented -- +controls:action url= bean:message +key=actions.accesslogger.create/ /controls:action +controls:action url= bean:message +key=actions.accesslogger.delete/ /controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.connector.create/ +/controls:action +controls:action url= bean:message key=actions.connector.delete/ +/controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.host.create/ +/controls:action +controls:action url= bean:message key=actions.host.delete/ +/controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.logger.create/ +/controls:action +controls:action url= bean:message key=actions.logger.delete/ +/controls:action +controls:action - /controls:action +controls:action url= bean:message +key=actions.requestfilter.create/ /controls:action +controls:action url= bean:message +key=actions.requestfilter.delete/ /controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.userrealm.create/ +/controls:action +controls:action url= bean:message key=actions.userrealm.delete/ +/controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.valve.create/ +/controls:action +controls:action url= bean:message key=actions.valve.delete/ +/controls:action +controls:action - /controls:action +controls:action url= bean:message key=actions.service.delete/ +/controls:action +/controls:actions /div /td
DO NOT REPLY [Bug 5526] New: - Log filename rollover in AccessLogValue fails.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5526. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5526 Log filename rollover in AccessLogValue fails. Summary: Log filename rollover in AccessLogValue fails. Product: Tomcat 4 Version: 4.0.1 Final Platform: All OS/Version: All Status: NEW Severity: Minor Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The files written to by org.apache.catalina.valves.AccessLogValve do not necessarily roll-over at midnight. IMHO the probable reason for this, looking at the code (revision 1.10), is the following: The getDate() method called with the invoke() method will reset the currentDate field within a granularity of 1sec. invoke() then constructs the access log line and calls log(msg,date). It is within this log() method that the check for file rollover occurs. However the test will fail unless more than 1 sec has elapsed since getDate() was called. Since this is highly likely the old file is never closed and the new file is never opened. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
