DO NOT REPLY [Bug 7759] New: - Reload an existing Application : KO
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7759. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7759 Reload an existing Application : KO Summary: Reload an existing Application : KO Product: Tomcat 4 Version: 4.0.3 Final Platform: PC OS/Version: Linux Status: NEW Severity: Critical Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] As I said in bug 7026 for tomcat 3.3x, there is a malfunction with the reload of an existing application : My test : My application is already deployed. I do some modifications on servlet(s), compile and deploy it(them). With the manager, I reload my application AppliTest : http://localhost:8080/manager/reload?path=/AppliTest Result : My application (18 threads) is well deployed (modifications are OK) but old native threads are still here (but inaccessible) and new native threads (18) have been created. So, if I repeat this operation several times, my system is down because I can't do any fork !!! So, at the moment and while this bug isn't resolved, I think this command (reload) must be prohibited (or this problem indicated in the documentation). Note : this problem is the same if you remove and install the application. Thanks. Yo -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c
Hi,
some days ago I sent a question for an only routing lb-worker. Costin asked for
the patch and here it is.
I added two config-directives for the lb-worker:
local_worker
- this is the name of the worker which should get the request if there is no
session or no jvmRoute.
fault_action
- the possible values are 'balance' and 'reject'. Explanation follows.
Behaviour of lb-worker:
a.) there is a jvmRoute and the corresponding node is ok:
- The request goes to the corresponding node
b.) there is no jvmRoute or the corresponding node didn't answered:
- if a local_worker was given. this one will get the request.
- if a local_worker was given, but it is in error state:
fault_action == reject: the request gets an error.
fault_action == balance: try to find another worker from the list of
balanced workers (c.).
- if no local_worker was given, go directly to c.).
c.) if no worker was found in a) and b) the normal balancing behaviour takes place.
I looked at cvs-repopsitory and it seems that jk_lb_worker.c and jk_util.c have
the same version (1.8, 1.12) like mine from
jakarta-tomcat-connectors-4.0.2-src.tar.gz.
I need the fault_action, because our load balancer should not route a request to
a node without a working local tomcat. So it is an error if an unrouteable
request arrives at a node without a working local tomcat. And it is also an
error to route it to one of the other nodes, because sometimes we switch off one
node only by telling the load balancer not to use it for requests. In this case
the modules should use this node only for requests with a session on it and not
for requests without a session. But for other use cases it might be useful if
mod_jk tries to balance the request in case of a failure of the local tomcat.
I hope it is useful. Sorry i haven't looked into jk2 at this time, but may be i
get time to do it soon.
Bernd
--
Dipl.-Inform. Bernd Koecke
UNIX-Entwicklung
Schlund+Partner AG
Fon: +49-721-91374-0
E-Mail: [EMAIL PROTECTED]
--- jk_lb_worker.c.orig Thu Apr 4 13:20:00 2002
+++ jk_lb_worker.c Fri Apr 5 11:03:09 2002
@@ -95,6 +95,9 @@
worker_record_t *lb_workers;
unsigned num_of_workers;
+worker_record_t *default_worker;
+unsigned reject_on_fault;
+
jk_pool_t p;
jk_pool_atom_t buf[TINY_POOL_SIZE];
@@ -269,6 +272,27 @@
}
}
+if (p-default_worker) {
+rc = p-default_worker;
+if (rc-in_error_state) {
+if (!rc-in_recovering) {
+time_t now = time(0);
+
+if ((now - rc-error_time) WAIT_BEFORE_RECOVER) {
+rc-in_recovering = JK_TRUE;
+rc-error_time = now;
+} else {
+rc = NULL;
+}
+} else {
+rc = NULL;
+}
+}
+if (rc || p-reject_on_fault) {
+return rc;
+}
+}
+
for(i = 0 ; i p-num_of_workers ; i++) {
if(p-lb_workers[i].in_error_state) {
if(!p-lb_workers[i].in_recovering) {
@@ -321,6 +345,8 @@
if(rec) {
int is_recoverable = JK_FALSE;
+jk_log(l, JK_LOG_DEBUG, In jk_lb_worker::service routing to worker
+'%s'\n,
+rec-name);
s-jvm_route = jk_pool_strdup(s-pool, rec-name);
@@ -415,6 +441,22 @@
lb_worker_t *p = pThis-worker_private;
char **worker_names;
unsigned num_of_workers;
+char *default_worker_name;
+unsigned reject_on_fault = JK_FALSE;
+
+if (jk_get_lb_default_worker_name(props, p-name, default_worker_name)) {
+jk_log(l, JK_LOG_DEBUG,
+In jk_lb_worker_t::validate found a local worker is %s\n,
+default_worker_name);
+jk_get_lb_fault_action(props, p-name, reject_on_fault);
+} else {
+jk_log(l, JK_LOG_DEBUG,
+In jk_lb_worker_t::validate didn't found a local worker\n);
+}
+p-reject_on_fault = reject_on_fault;
+jk_log(l, JK_LOG_DEBUG,
+In jk_lb_worker_t::validate reject_on_fault is '%u'\n,
+p-reject_on_fault);
if(jk_get_lb_worker_list(props,
p-name,
@@ -449,6 +491,12 @@
we,
l) || !p-lb_workers[i].w) {
break;
+}
+if (default_worker_name 0 == strcmp(p-lb_workers[i].name,
+default_worker_name)) {
+p-default_worker = (p-lb_workers[i]);
+jk_log(l, JK_LOG_DEBUG,
+In jk_lb_worker_t::validate got a local worker '%s'\n,
+p-default_worker-name);
}
}
--- jk_util.c.orig Thu Apr 4 13:15:42 2002
+++ jk_util.c Thu Apr 4 15:31:08
RE: [PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c
Seems a good patch. Should be commited. BTW, Bernd could you make a little documentation which could be included in jk doc and add example ? Excellent works ;) - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD...oOOo..(_)..oOOo... PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 -Original Message- From: Bernd Koecke [mailto:[EMAIL PROTECTED]] Sent: Friday, April 05, 2002 1:30 PM To: [EMAIL PROTECTED] Subject: [PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c Hi, some days ago I sent a question for an only routing lb-worker. Costin asked for the patch and here it is. I added two config-directives for the lb-worker: local_worker - this is the name of the worker which should get the request if there is no session or no jvmRoute. fault_action - the possible values are 'balance' and 'reject'. Explanation follows. Behaviour of lb-worker: a.) there is a jvmRoute and the corresponding node is ok: - The request goes to the corresponding node b.) there is no jvmRoute or the corresponding node didn't answered: - if a local_worker was given. this one will get the request. - if a local_worker was given, but it is in error state: fault_action == reject: the request gets an error. fault_action == balance: try to find another worker from the list of balanced workers (c.). - if no local_worker was given, go directly to c.). c.) if no worker was found in a) and b) the normal balancing behaviour takes place. I looked at cvs-repopsitory and it seems that jk_lb_worker.c and jk_util.c have the same version (1.8, 1.12) like mine from jakarta-tomcat-connectors-4.0.2-src.tar.gz. I need the fault_action, because our load balancer should not route a request to a node without a working local tomcat. So it is an error if an unrouteable request arrives at a node without a working local tomcat. And it is also an error to route it to one of the other nodes, because sometimes we switch off one node only by telling the load balancer not to use it for requests. In this case the modules should use this node only for requests with a session on it and not for requests without a session. But for other use cases it might be useful if mod_jk tries to balance the request in case of a failure of the local tomcat. I hope it is useful. Sorry i haven't looked into jk2 at this time, but may be i get time to do it soon. Bernd -- Dipl.-Inform. Bernd Koecke UNIX-Entwicklung Schlund+Partner AG Fon: +49-721-91374-0 E-Mail: [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 4668] - File download over http corrupt
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4668. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4668 File download over http corrupt --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 11:48 --- Could you try to determine where the downloaded file is broken, ie using a known file and checking the differences ? -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c
GOMEZ Henri wrote: Seems a good patch. Should be commited. BTW, Bernd could you make a little documentation which could be included in jk doc and add example ? Excellent works ;) Thanks, I'll have a look at the docs in detail and add some example. Should I sent these files to this list? Bernd - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD...oOOo..(_)..oOOo... PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 -Original Message- From: Bernd Koecke [mailto:[EMAIL PROTECTED]] Sent: Friday, April 05, 2002 1:30 PM To: [EMAIL PROTECTED] Subject: [PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c Hi, some days ago I sent a question for an only routing lb-worker. Costin asked for the patch and here it is. I added two config-directives for the lb-worker: local_worker - this is the name of the worker which should get the request if there is no session or no jvmRoute. fault_action - the possible values are 'balance' and 'reject'. Explanation follows. Behaviour of lb-worker: a.) there is a jvmRoute and the corresponding node is ok: - The request goes to the corresponding node b.) there is no jvmRoute or the corresponding node didn't answered: - if a local_worker was given. this one will get the request. - if a local_worker was given, but it is in error state: fault_action == reject: the request gets an error. fault_action == balance: try to find another worker from the list of balanced workers (c.). - if no local_worker was given, go directly to c.). c.) if no worker was found in a) and b) the normal balancing behaviour takes place. I looked at cvs-repopsitory and it seems that jk_lb_worker.c and jk_util.c have the same version (1.8, 1.12) like mine from jakarta-tomcat-connectors-4.0.2-src.tar.gz. I need the fault_action, because our load balancer should not route a request to a node without a working local tomcat. So it is an error if an unrouteable request arrives at a node without a working local tomcat. And it is also an error to route it to one of the other nodes, because sometimes we switch off one node only by telling the load balancer not to use it for requests. In this case the modules should use this node only for requests with a session on it and not for requests without a session. But for other use cases it might be useful if mod_jk tries to balance the request in case of a failure of the local tomcat. I hope it is useful. Sorry i haven't looked into jk2 at this time, but may be i get time to do it soon. Bernd -- Dipl.-Inform. Bernd Koecke UNIX-Entwicklung Schlund+Partner AG Fon: +49-721-91374-0 E-Mail: [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- Dipl.-Inform. Bernd Koecke UNIX-Entwicklung Schlund+Partner AG Fon: +49-721-91374-0 E-Mail: [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: [PATCH] jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,jk_util.c
BTW, Bernd could you make a little documentation which could be included in jk doc and add example ? Excellent works ;) Thanks, I'll have a look at the docs in detail and add some example. Should I sent these files to this list? Yes, please ;) -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 4668] - File download over http corrupt
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4668. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4668 File download over http corrupt [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 13:12 --- I am sorry, but Tomcat does not corrupt files. You clearly have some configuration problem on your network, or the files that you are trying to serve are already corrupted. If you need some help investigating this, please use IRC or tomcat-user. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7762] New: - stdout logfile handling
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7762.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7762
stdout logfile handling
Summary: stdout logfile handling
Product: Tomcat 3
Version: 3.3 Final
Platform: All
OS/Version: Linux
Status: NEW
Severity: Enhancement
Priority: Other
Component: Config
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When tomcat is started with tomcat.sh start -noout the output is redirected to
${TOMCAT_HOME}/logs/stdout.log 21. The reddirect simply overwrites an old
stdout.log this could easyly be changed to be apended or even better move
existing stdout.log before starting.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7759] - Reload an existing Application : KO
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7759. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7759 Reload an existing Application : KO [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 13:21 --- Forking threads is not allowed in the J2EE model (as well as using non container provided resources). If your application does not care about the programming model, and chooses to allocate its own resources, it MUST use the lifecycle event sent by the servlet container (like destroy, or some listener) to cleanup those resources. In any case, it is never the responsability of the container to do that. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java
remm02/04/05 05:37:39
Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java
Log:
- Fix the build (remove TC 3.3 imports + implement missing method).
Revision ChangesPath
1.2 +4 -4
jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java
Index: JkCoyoteHandler.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/java/org/apache/jk/server/JkCoyoteHandler.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JkCoyoteHandler.java 5 Apr 2002 00:13:17 - 1.1
+++ JkCoyoteHandler.java 5 Apr 2002 13:37:39 - 1.2
@@ -67,11 +67,7 @@
import org.apache.jk.core.*;
import org.apache.jk.common.*;
import org.apache.jk.util.*;
-import org.apache.tomcat.modules.server.PoolTcpConnector;
-import org.apache.tomcat.core.*;
-
-import org.apache.tomcat.util.net.*;
import org.apache.tomcat.util.buf.*;
import org.apache.tomcat.util.log.*;
import org.apache.tomcat.util.http.*;
@@ -106,6 +102,10 @@
}
+public Object getAttribute( String name ) {
+return null;
+}
+
/** The adapter, used to call the connector
*/
public void setAdapter(Adapter adapter) {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[GUMP] Build Failure - jakarta-tomcat-4.0
This email is autogenerated from the output from:
http://jakarta.apache.org/builds/gump/2002-04-05/jakarta-tomcat-4.0.html
Buildfile: build.xml
deploy-prepare:
deploy-static:
deploy:
[echo] Target: Catalina - Deploy ...
flags:
flags.display:
[echo] --- Build environment for Catalina ---
[echo] If ${property_name} is displayed, then the property is not set)
[echo] --- Build options ---
[echo] full.dist=${full.dist}
[echo] build.sysclasspath=only
[echo] compile.debug=${compile.debug}
[echo] compile.deprecation=${compile.deprecation}
[echo] compile.optimize=${compile.optimize}
[echo] --- Ant Flags ---
[echo] style task available (required)=true
[echo] --- JDK ---
[echo] jdk.1.2.present=true
[echo] jdk.1.3.present=true
[echo] jdk.1.4.present=${jdk.1.4.present}
[echo] --- Source Dependencies ---
[echo] jtc.home.present=true
[echo] --- Required Libraries ---
[echo] beanutils.present=true
[echo] collections.present=true
[echo] digester.present=true
[echo] jaxp.present=true
[echo] jndi.present=true
[echo] logging.present=true
[echo] regexp.present=true
[echo] servlet.present=true
[echo] --- Optional Libraries ---
[echo] daemon.present=${daemon.present}
[echo] dbcp.present=true
[echo] jaas.present=true
[echo] javamail.present=true
[echo] jmx.present=true
[echo] jsse.present=true
[echo] jta.present=true
[echo] junit.present=true
[echo] ldap.present=true
[echo] modeler.present=true
[echo] pool.present=true
[echo] tyrex.present=${tyrex.present}
[echo] --- Required JARs ---
[echo] jndi.jar.present(except JDK 1.3+)=true
[echo] regexp.jar.present=true
[echo] servlet.jar.present=true
[echo] xerces.jar.present(except JDK 1.4+ or xerces2)=true
[echo] xerces2.jars.present(except JDK 1.4+ or xerces1)=${xerces2.jars.present}
[echo] --- Optional JARs ---
[echo] daemon.jar.present=${daemon.jar.present}
[echo] dbcp.jar.present=true
[echo] jaas.jar.present=true
[echo] javamail.jar.present=true
[echo] jdbc20ext.jar.present=true
[echo] jmx.jar.present=${jmx.jar.present}
[echo] jta.jar.present=true
[echo] junit.jar.present=${junit.jar.present}
[echo] ldap.jar.present=true
[echo] modeler.jar.present=true
[echo] pool.jar.present=true
[echo] tyrex.jar.present=${tyrex.jar.present}
[echo] --- Conditional compilation flags ---
[echo] compile.daemon=${compile.daemon}
[echo] compile.dbcp=true
[echo] compile.jaas=true
[echo] compile.javamail=true
[echo] compile.jmx=true
[echo] compile.jndi=true
[echo] compile.jsse=true
[echo] compile.jta=true
[echo] compile.junit=true
[echo] compile.ldap=true
[echo] compile.ssi=true
[echo] compile.tyrex=${compile.tyrex}
[echo] --- Distribution flags ---
[echo] copy.daemon.jar=${copy.daemon.jar}
[echo] copy.dbcp.jar=true
[echo] copy.jaas.jar=true
[echo] copy.jdbc20ext.jar=true
[echo] copy.javamail.jar=true
[echo] copy.jmx.jar=${copy.jmx.jar}
[echo] copy.jndi.jar=${copy.jndi.jar}
[echo] copy.jta.jar=true
[echo] copy.ldap.jar=${copy.ldap.jar}
[echo] copy.logging.jar=true
[echo] copy.modeler.jar=true
[echo] copy.pool.jar=true
[echo] copy.tyrex.jar=${copy.tyrex.jar}
[echo] copy.xerces.jar=true
[echo] copy.xerces2.jars=${copy.xerces2.jars}
build-prepare:
copy-activation.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-daemon.jar:
copy-dbcp.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jaas.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-jdbc20ext.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-jmx.jar:
copy-jndi.jar:
copy-jsse.jar:
copy-jta.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-ldap.jar:
copy-modeler.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/lib
copy-pool.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/lib
copy-tyrex.jar:
copy-xerces.jar:
[copy] Copying 1 file to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/common/endorsed
copy-xerces2.jars:
build-static:
build-tomcat-util:
build-prepare:
build-main:
build-catalina:
[javac] Compiling 31 source files to
/home/rubys/jakarta/jakarta-tomcat-4.0/catalina/build/server/classes
[javac] Note: 3 files
Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
costin 02/04/04 14:34:46 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: Moved the parseHost method from coyote. That's another step in merging the connector code and sharing a single codebase. The Host: header is specific to http, other protocols may not need this operation. +1; this is HTTP/1.1 specific. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Coyote: replacing Processor with ProtocolHandler
Hi, In order to merge the connector-related code in Coyote and jk, I need a different abstraction. Processor takes InputStream/OutputStream params, and assumes the connector will listen on the port, etc. The problem is that it doesn't map to things like JNI and is hard to abstract things like UnixSocket. I know. I would like to replace it with a similar interface, ProtocolHandler, which is stateless ( Servlet-like ) and will just have a init()/destroy() method, letting the protocol deal with the threads. It's easy to implement it in http11 - this is duplicated in the 33/40 versions. I would prefer to use the 33 thread pool from util, but I'm ok with the code used in 40 ( or I can implement both, with an option ). The 4.0 pool works good, so I don't plan to fix it since it's not broken :) Also, I would like to reduce/eliminate the use of Socket and the other dependencies between Coyote and the protocol impl ( it is supposed to abstract it, but there are few details.. ) Remy, Bill - is it ok ? The HTTP/1.1 processor is written for IS and OS, and in general blocking IO. You can't use any message based processing with it, that's for sure. Will it still work after abstracting this ? Anyway, the init/destroy and other things are probably needed. I'll have to look into the design a lot more Also, since the current code is stable and works good, I wanted to make a 1.0 release of Coyote and the HTTP/1.1 processor so I have something to fall back on if there are some problems with merging to JK. I'd like to: - Release a Coyote 1.0 RC with the current code - Create a 1.0 branch in j-t-c based on the current code Is it ok ? Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Coyote: replacing Processor with ProtocolHandler
On Fri, 5 Apr 2002, Remy Maucherat wrote: It's easy to implement it in http11 - this is duplicated in the 33/40 versions. I would prefer to use the 33 thread pool from util, but I'm ok with the code used in 40 ( or I can implement both, with an option ). The 4.0 pool works good, so I don't plan to fix it since it's not broken :) There is no problem if we use 2 Http11Protocol, one with ThreadPool the other with 4.0 threads. Right now I'm working on the TP one. We don't need two, so I'll try yours ;-) Do you plan to write the Http11ProtocolHandler ? Also, I would like to reduce/eliminate the use of Socket and the other dependencies between Coyote and the protocol impl ( it is supposed to abstract it, but there are few details.. ) Remy, Bill - is it ok ? The HTTP/1.1 processor is written for IS and OS, and in general blocking IO. You can't use any message based processing with it, that's for sure. Will it still work after abstracting this ? Nothing fundamental change in how things work - it'll just move the ( duplicated ) thread and socket code to a lower layer. That's what I understood (but it took me 10 more minutes). If we can pick one threading model - great, if not - we'll have 2, and each server can pick either one at runtime. ( and you get TP and all ssl support from 3.3 for free, useable with the 4.0 connector ) You need to add them in j-t-c/util then. Also, since the current code is stable and works good, I wanted to make a 1.0 release of Coyote and the HTTP/1.1 processor so I have something to fall back on if there are some problems with merging to JK. I'd like to: - Release a Coyote 1.0 RC with the current code - Create a 1.0 branch in j-t-c based on the current code What about: - tag the code ( at the latest beta ). - I'll just add code, with minimal changes to the existing code. - If it works out, release another beta with Coyote supporting both HTTP/1.1 and AJP13. If not, fall back to the branch. Yes, we can create the branch at any time based on the tag. No problem about that. I'll do that. Are you at least ok with adding the o.a.t.u.net ( the 3.3 SSL stuff ) to util, and leaving the ProtocolHandler in ? Yes, of course. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote ProtocolHandler.java
remm02/04/05 07:52:45
Modified:coyote/src/java/org/apache/coyote ProtocolHandler.java
Log:
- Coding style :)
Revision ChangesPath
1.2 +19 -8
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/ProtocolHandler.java
Index: ProtocolHandler.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/ProtocolHandler.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ProtocolHandler.java 5 Apr 2002 05:34:19 - 1.1
+++ ProtocolHandler.java 5 Apr 2002 15:52:45 - 1.2
@@ -73,23 +73,34 @@
*/
public interface ProtocolHandler {
-/** Pass config info
+
+/**
+ * Pass config info.
*/
-public void setAttribute( String name, Object value );
+public void setAttribute(String name, Object value);
+
+
+public Object getAttribute(String name);
+
-public Object getAttribute( String name );
-
-/** The adapter, used to call the connector
+/**
+ * The adapter, used to call the connector.
*/
public void setAdapter(Adapter adapter);
+
public Adapter getAdapter();
-/** Start the protocol
+
+/**
+ * Start the protocol.
*/
-public void init() throws Exception;
+public void init()
+throws Exception;
+
-public void destroy() throws Exception;
+public void destroy()
+throws Exception;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
remm02/04/05 07:53:09
Modified:http11/src/java/org/apache/coyote/http11
Http11Processor.java
Log:
- Coding style :)
Revision ChangesPath
1.13 +7 -4
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
Index: Http11Processor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- Http11Processor.java 4 Apr 2002 22:34:46 - 1.12
+++ Http11Processor.java 5 Apr 2002 15:53:09 - 1.13
@@ -651,12 +651,13 @@
}
+
/**
* Parse host.
*/
public static void parseHost(Request req)
-throws IOException
-{
+throws IOException {
+
MessageBytes valueMB = req.getMimeHeaders().getValue(host);
// 3.3 version. In 4.0 it is extracted from the host header.
// XXX I would rather trust the socket...
@@ -682,7 +683,7 @@
break;
}
}
-
+
if (colonPos 0) {
req.setServerPort(80);
req.serverName().setBytes( valueB, valueS, valueL);
@@ -703,8 +704,10 @@
}
req.setServerPort(port);
}
+
}
-
+
+
/**
* When committing the response, we have to validate the set of headers, as
* well as setup the response filters.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7770] New: - NPE in at session creation shortly after starting tomcat 3.3.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7770. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7770 NPE in at session creation shortly after starting tomcat 3.3.1 Summary: NPE in at session creation shortly after starting tomcat 3.3.1 Product: Tomcat 3 Version: 3.3.1 Final Platform: Sun OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Servlet AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] First odf all my setup: Tomcat 3.3.1 final with mod_jk 1.1 ajp13 behind 2 Apaches 1.3.19 on Solaris 8 (SPARC) I can find the following NPE once in a while shortly after we startup Tomcat: java.lang.NullPointerException at org.apache.tomcat.modules.session.SessionId.processSession (SessionId.java:237) at org.apache.tomcat.modules.session.SessionId.requestMap (SessionId.java:217) at org.apache.tomcat.core.ContextManager.processRequest (ContextManager.java:968) at org.apache.tomcat.facade.RequestDispatcherImpl.doForward (RequestDispatcherImpl.java:259) at org.apache.tomcat.facade.RequestDispatcherImpl.forward (RequestDispatcherImpl.java:174) at org.apache.struts.action.ActionServlet.processActionForward (ActionServlet.java:1758) at org.apache.struts.action.ActionServlet.process (ActionServlet.java:1595) at de.einsurance.gui.framework.ExtendedActionServlet.process (ExtendedActionServlet.java:65) at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:491) at javax.servlet.http.HttpServlet.service(HttpServlet.java) at javax.servlet.http.HttpServlet.service(HttpServlet.java) at org.apache.tomcat.facade.ServletHandler.doService (ServletHandler.java:574) at org.apache.tomcat.core.Handler.invoke(Handler.java:322) at org.apache.tomcat.core.Handler.service(Handler.java:235) at org.apache.tomcat.facade.ServletHandler.service (ServletHandler.java:485) at org.apache.tomcat.facade.RequestDispatcherImpl.doForward (RequestDispatcherImpl.java:272) at org.apache.tomcat.facade.RequestDispatcherImpl.forward (RequestDispatcherImpl.java:174) at org.apache.struts.action.ActionServlet.processActionForward (ActionServlet.java:1758) at org.apache.struts.action.ActionServlet.process (ActionServlet.java:1595) at de.einsurance.gui.framework.ExtendedActionServlet.process (ExtendedActionServlet.java:65) at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:491) at javax.servlet.http.HttpServlet.service(HttpServlet.java) at javax.servlet.http.HttpServlet.service(HttpServlet.java) at org.apache.tomcat.facade.ServletHandler.doService (ServletHandler.java:574) at org.apache.tomcat.core.Handler.invoke(Handler.java:322) at org.apache.tomcat.core.Handler.service(Handler.java:235) at org.apache.tomcat.facade.ServletHandler.service (ServletHandler.java:485) at org.apache.tomcat.core.ContextManager.internalService (ContextManager.java:917) at org.apache.tomcat.core.ContextManager.service (ContextManager.java:833) at org.apache.tomcat.modules.server.Ajp13Interceptor.processConnection (Ajp13Interceptor.java:341) at org.apache.tomcat.util.net.TcpWorkerThread.runIt (PoolTcpEndpoint.java:494) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run (ThreadPool.java:516) at java.lang.Thread.run(Thread.java:479) Has anybody an Idea what happens here? We have the following (quite special) setup in this case, which I try to explain here: 2 HW-loadbalanced Apache server connect via mod_jk 1.1 to several tomcats. More or less one tomcat per Webapp. The error above occurs in a special webapp which is setup a little bit different: For this (our critical webapp) we use a single Tomcat connected via a loadbalanced worker using two ajp13 workers (lbfactor 1 and 0.1) This second worker normaly points to a not running Tomcat and is therefore ignored. When we update some classes or otherwise have to restart our main tomcat, we start the second Tomcat, exchange the worker.property files with one that have lbfactors 0.1 and 1 (the other way around as before) and graceful restart our two apaches. That way, (almost) all new sessions go to the newly started Tomcat, while still existing sessions stick with the old Tomcat. After 30 min, we shut down the original Tomcat and our switch over is finished. So we are missusing the loadbalancing feature to slowly migrate our running sessions to the new Tomcat instance. The above Error sometimes occured at exactly the point, where we start up this
DO NOT REPLY [Bug 7771] New: - [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771 [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. Summary: [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. Product: Tomcat 4 Version: Nightly Build Platform: All URL: http://www.kare.uklinux.net/pub/coyote-response.patch OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Internal implemenetation of Coyote o.a.coyote.tomcat4.CoyoteResponse.toEncoded(String, String) method appends the anchor before query string. this is against the URI RFC. This bug is originates from deprecated HTTP/1.1 Connector. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7700 Cheers, [EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7771] - [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771 [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 16:26 --- Created an attachment (id=1491) toEncoded(String,String) anchor fix -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7772] - Redirect failed after changing an image
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7772. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7772 Redirect failed after changing an image [EMAIL PROTECTED] changed: What|Removed |Added Severity|Major |Normal Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 16:49 --- This is a client feature. The browser should do a request to http://localhost:8080/awg/admin/index.do. What you return for that mapping is up to you. There's probably a better way to do what you want to do. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7772] New: - Redirect failed after changing an image
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7772. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7772 Redirect failed after changing an image Summary: Redirect failed after changing an image Product: Tomcat 4 Version: 4.0.3 Final Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have written struts mapping that enable users to change images via a web site. After storing the image into the file system, I created a new page which redirects the user to the original page (which is also a struts mapping). I did this with meta http-equiv=refresh CONTENT=10; http://localhost:8080/awg/admin/index.do; The refresh redirects the call to the struts mapping that tryed to store the image and not to the desired index page. I want to force the browser not to load the page that contains the image from the cache, but this does not work. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java
remm02/04/05 09:01:01
Modified:coyote/src/java/org/apache/coyote/tomcat4
CoyoteResponse.java
Log:
- It looks like the anchor part should be appended after the query part in the URI.
Section 4 and 5.2 of RFC 2396.
- Thanks to Kare Nuorteva kare at kare.uklinux.net for the patch.
Revision ChangesPath
1.12 +5 -24
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java
Index: CoyoteResponse.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- CoyoteResponse.java 31 Mar 2002 04:41:17 - 1.11
+++ CoyoteResponse.java 5 Apr 2002 17:01:00 - 1.12
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
1.11 2002/03/31 04:41:17 remm Exp $
- * $Revision: 1.11 $
- * $Date: 2002/03/31 04:41:17 $
+ * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v
1.12 2002/04/05 17:01:00 remm Exp $
+ * $Revision: 1.12 $
+ * $Date: 2002/04/05 17:01:00 $
*
*
*
@@ -116,7 +116,7 @@
*
* @author Remy Maucherat
* @author Craig R. McClanahan
- * @version $Revision: 1.11 $ $Date: 2002/03/31 04:41:17 $
+ * @version $Revision: 1.12 $ $Date: 2002/04/05 17:01:00 $
*/
public class CoyoteResponse
@@ -1321,25 +1321,6 @@
}
-/*
-// Construct a new absolute URL if possible (cribbed from
-// the DefaultErrorPage servlet)
-URL url = null;
-try {
-url = new URL(location);
-} catch (MalformedURLException e1) {
-HttpServletRequest hreq =
-(HttpServletRequest) request.getRequest();
-String requrl = HttpUtils.getRequestURL(hreq).toString();
-try {
-url = new URL(new URL(requrl), location);
-} catch (MalformedURLException e2) {
-throw new IllegalArgumentException(location);
-}
-}
-return (url.toExternalForm());
-*/
-
}
@@ -1373,8 +1354,8 @@
sb.append(;jsessionid=);
sb.append(sessionId);
}
-sb.append(anchor);
sb.append(query);
+sb.append(anchor);
return (sb.toString());
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7771] - [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771 [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 17:03 --- I've checked the RFC, and I think you are right. I've applied the patch. Thanks ! -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Coyote: replacing Processor with ProtocolHandler
On Fri, 5 Apr 2002, Remy Maucherat wrote: There is no problem if we use 2 Http11Protocol, one with ThreadPool the other with 4.0 threads. Right now I'm working on the TP one. We don't need two, so I'll try yours ;-) Do you plan to write the Http11ProtocolHandler ? Already done, but I have a bug I'm trying to fix ( the classical body sent before headers or mixed up, I've seen this at least 10 times :-). I'll check it in, it doesn't affect anything else ( it's not pretty yet, I moved code from few places ). Now the big question - can you take a look at util.handler.TcHandler ? I'm don't want to replace ActionHook ( for now :-), but maybe have Action extend TcHandler - or something similar, so the hook can use the ctx ( and pass and return information ). I can also use TcHandlerContext ( i.e. just a set of int-indexed notes ) as param for Action hook as the first step. Long term I think we should use TcHandler as the main hook and deprecate ActionHook/JkHandler/etc. Of course, the name and interface is open to change - we can rename it TcHook and make it interface, or use action() and pass an object similar with ActionCode ( maybe ActionChain - since each ActionCode represents a specific category of hooks chained ) Just review it - pluging it in can be done later ( and smoothly ) Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java
remm02/04/05 09:25:26 Modified:catalina/src/share/org/apache/catalina/connector HttpResponseBase.java Log: - Port patch. - It looks like the anchor part should be appended after the query part in the URI. Section 4 and 5.2 of RFC 2396. - Thanks to Kare Nuorteva kare at kare.uklinux.net for the patch. Revision ChangesPath 1.53 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java Index: HttpResponseBase.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v retrieving revision 1.52 retrieving revision 1.53 diff -u -r1.52 -r1.53 --- HttpResponseBase.java 18 Mar 2002 07:15:39 - 1.52 +++ HttpResponseBase.java 5 Apr 2002 17:25:26 - 1.53 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.52 2002/03/18 07:15:39 remm Exp $ - * $Revision: 1.52 $ - * $Date: 2002/03/18 07:15:39 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.53 2002/04/05 17:25:26 remm Exp $ + * $Revision: 1.53 $ + * $Date: 2002/04/05 17:25:26 $ * * * @@ -104,7 +104,7 @@ * * @author Craig R. McClanahan * @author Remy Maucherat - * @version $Revision: 1.52 $ $Date: 2002/03/18 07:15:39 $ + * @version $Revision: 1.53 $ $Date: 2002/04/05 17:25:26 $ * @deprecated */ @@ -756,8 +756,8 @@ sb.append(;jsessionid=); sb.append(sessionId); } -sb.append(anchor); sb.append(query); +sb.append(anchor); return (sb.toString()); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java
remm02/04/05 09:26:25 Modified:catalina/src/share/org/apache/catalina/connector Tag: tomcat_40_branch HttpResponseBase.java Log: - Port patch. - It looks like the anchor part should be appended after the query part in the URI. Section 4 and 5.2 of RFC 2396. - Thanks to Kare Nuorteva kare at kare.uklinux.net for the patch. Revision ChangesPath No revision No revision 1.37.2.12 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java Index: HttpResponseBase.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v retrieving revision 1.37.2.11 retrieving revision 1.37.2.12 diff -u -r1.37.2.11 -r1.37.2.12 --- HttpResponseBase.java 12 Mar 2002 20:20:39 - 1.37.2.11 +++ HttpResponseBase.java 5 Apr 2002 17:26:25 - 1.37.2.12 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.37.2.11 2002/03/12 20:20:39 remm Exp $ - * $Revision: 1.37.2.11 $ - * $Date: 2002/03/12 20:20:39 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.37.2.12 2002/04/05 17:26:25 remm Exp $ + * $Revision: 1.37.2.12 $ + * $Date: 2002/04/05 17:26:25 $ * * * @@ -102,7 +102,7 @@ * * @author Craig R. McClanahan * @author Remy Maucherat - * @version $Revision: 1.37.2.11 $ $Date: 2002/03/12 20:20:39 $ + * @version $Revision: 1.37.2.12 $ $Date: 2002/04/05 17:26:25 $ */ public class HttpResponseBase @@ -740,8 +740,8 @@ sb.append(;jsessionid=); sb.append(sessionId); } -sb.append(anchor); sb.append(query); +sb.append(anchor); return (sb.toString()); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Coyote: replacing Processor with ProtocolHandler
On Fri, 5 Apr 2002, Remy Maucherat wrote: There is no problem if we use 2 Http11Protocol, one with ThreadPool the other with 4.0 threads. Right now I'm working on the TP one. We don't need two, so I'll try yours ;-) Do you plan to write the Http11ProtocolHandler ? Already done, but I have a bug I'm trying to fix ( the classical body sent before headers or mixed up, I've seen this at least 10 times :-). I'll check it in, it doesn't affect anything else ( it's not pretty yet, I moved code from few places ). Ok, please do. Since I'll probably use it, I'll try to improve it (assuming it needs improving). Now the big question - can you take a look at util.handler.TcHandler ? I'm don't want to replace ActionHook ( for now :-), but maybe have Action extend TcHandler - or something similar, so the hook can use the ctx ( and pass and return information ). I can also use TcHandlerContext ( i.e. just a set of int-indexed notes ) as param for Action hook as the first step. I have no problems getting rid of the current 'action' mechanism and replacing it with your handler. Long term I think we should use TcHandler as the main hook and deprecate ActionHook/JkHandler/etc. Of course, the name and interface is open to change - we can rename it TcHook and make it interface, or use action() and pass an object similar with ActionCode ( maybe ActionChain - since each ActionCode represents a specific category of hooks chained ) Given what and where the ActionHook/Code is used, I really have no problem replacing it if the replacement object allows me to do the same things. From TC, the action stuff is used through the Catalina API, so there's nothing impacted outside of Coyote. The protocol handler change should also have zero impact, as I just need to rewrite the CatalinaConnector wrapper to use it instead of using its own pooling. Very easy to do overall. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net - New directory
costin 02/04/05 09:40:48 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net - New directory -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
why doesnt auto discovery of uri's from tld not work in tomcat 4.0.4
Hi The jsp spec 1.2 says that All i need to do is drop tld files in web-inf folder or subdirectory OR drop tlds packaged in jars in web-inf/lib folder and I can use the uri (in these tld files ) in my jsp like %@ taglib uri=myuri prefix... % but the implementation of 4.03 doesnt support autodiscovery at all. SO i checked 4.04 (26th march build) and it supports it but only for packaged jars(when my tld is inside the meta-inf folder of the jar) why not for tld files in web-inf folder. Is there anything I am missing or is this being worked upon. The problems i observed in latest tomcat 4.04 (26th march) are below /WEB-INF/x.tld no autodiscovery of the uri in this file /WEB-INF/sub-folder/q.tld --- no autodiscovery of the uri in this file /WEB-INF/lib/y.jar (with a file meta-inf/y.tld) -- autodiscovery works for the uri in y.tld /WEB-INF/lib/y.jar (with a file meta-inf/sub-folder/z.tld) --- autodiscovery doesnt work /WEB-INF/lib/sub-folder/y.jar (with file in meta-inf/a.tld) ---autodiscovery doesnt work ...else where i think iam right the next one shouldnt work (it anyway doesnt work now) /myjspfiles/test.tld ---autodiscovery doesn work ( i think it shouldnt work (or i am not sure) ) *PS: Does autodiscovery happen only for tld and jars in web-inf folder or anywhere in the web application (ie if i place a tld or a packaged jar with my jsp file. Can i use the uri in these tlds or not ? Thanks Raj _ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
webapp_bug
Hi! I have a big problem, i think it we found a bug in apache-tomcat mod_webapp connector. I attached the example servlet. The client gets the first byte from DumpServlet only after all have been written AND doGet (doPost) of DumpServlet returned. Seems to be a bug in the connector (it works well with both standalone tomcat and apche with JSERV). (DumpServlet replies writes the configured number of bytes and then sleeps the specified millis before returning. Usage: host/servlet/DumpServlet?count=256sleep=1chunked=true count defaults to 4096; sleep defaults to 1000 (a second) chunked defaults to false DumpServlet sets content length iff chunked is false.) My system is RedHat 7.1, and i used tomcat4-4.0.3-1.noarch.rpm and mod_webapp-1.0-1.i386.rpm. exe Mindmaker inc. Mobil: +36 30 231 5584 DumpServlet.java Description: Binary data -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util build.xml
costin 02/04/05 09:45:08
Modified:util build.xml
Log:
Add detection script for JSSE and PureTLS ( cutpaste from tomcat ).
For PureTLS - I think it would be usefull to not require it in classpath,
but that's who it is right now in 33.
Revision ChangesPath
1.4 +18 -2 jakarta-tomcat-connectors/util/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/util/build.xml,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- build.xml 8 Jun 2001 19:54:06 - 1.3
+++ build.xml 5 Apr 2002 17:45:08 - 1.4
@@ -6,14 +6,25 @@
property name=tomcat-util.build value=${basedir}/build/
-target name=build-prepare
+
+target name=detect
+available property=jsse.present
+ file=${jsse.lib}/jsse.jar/
+!-- XXX make this file based, I don't like requiring it in the classpath
--
+available property=puretls.present
+ classname=COM.claymoresystems.ptls.SSLContext/
+/target
+
+target name=build-prepare depends=detect
mkdir dir=${tomcat-util.build}/
mkdir dir=${tomcat-util.build}/classes/
mkdir dir=${tomcat-util.build}/lib/
/target
target name=build-main depends=build-prepare
-
+echo message=- Java-utils - /
+echo message=-- puretls.present = ${puretls.present} /
+echo message=-- jsse.present = ${jsse.present}/
javac srcdir=java
destdir=${tomcat-util.build}/classes
deprecation=on
@@ -21,6 +32,11 @@
optimize=off
verbose=off
excludes=**/CVS/**
+classpath location=${jsse.lib}/jsse.jar /
+classpath location=${jsse.lib}/jnet.jar /
+classpath location=${jsse.lib}/jcert.jar /
+exclude name=**/util/net/JSSE* unless=jsse.present/
+exclude name=**/util/net/PureTLS* unless=puretls.present/
/javac
!-- Copy static resource files --
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
costin 02/04/05 09:48:27
Modified:http11/src/java/org/apache/coyote/http11
Http11Processor.java
Log:
Added some comments with the code that will have to be added to pass up
the SSL information.
This info shouldn't be extracted unless the user requests it - it is
pretty expensive. The current method is to save the socket and have the
connector extract it directly, but that doesn't work for other protocols.
Revision ChangesPath
1.14 +13 -0
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
Index: Http11Processor.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- Http11Processor.java 5 Apr 2002 15:53:09 - 1.13
+++ Http11Processor.java 5 Apr 2002 17:48:26 - 1.14
@@ -455,6 +455,19 @@
started = false;
+} else if (actionCode == ActionCode.ACTION_REQ_ATTRIBUTE ) {
+
+// XXX Will be fixed if we replace ActionCode/Action with TcHandler,
+// the context can be used to pass and return information
+// try {
+// if(key.equals(javax.servlet.request.cipher_suite))
+// return httpReq.sslSupport.getCipherSuite();
+// if(key.equals(javax.servlet.request.X509Certificate))
+// return httpReq.sslSupport.getPeerCertificateChain();
+// } catch (Exception e){
+// log.warn(Exception getting SSL attribute + key,e);
+// return null;
+// }
}
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Protocol.java
costin 02/04/05 09:50:39
Added: http11/src/java/org/apache/coyote/http11 Http11Protocol.java
Log:
Initial implementation of http11 'protocolHandler'
The SSL stuff is not completely plugged in, and it will require a recompilation
of util ( so you have the util.net available ).
It also seem to have some problems with the output ( but more likley the bug
is in my refactored connector ). The code will be cleaned up after all pieces
are assembled.
Revision ChangesPath
1.1
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/Http11Protocol.java
Index: Http11Protocol.java
===
/*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package org.apache.coyote.http11;
import java.io.InputStream;
import java.io.IOException;
import java.io.OutputStream;
import org.apache.coyote.*;
import java.io.*;
import java.net.*;
import java.util.*;
import java.text.*;
import org.apache.tomcat.util.res.StringManager;
import org.apache.tomcat.util.IntrospectionUtils;
import org.apache.tomcat.util.buf.*;
import org.apache.tomcat.util.http.*;
import org.apache.tomcat.util.log.*;
import org.apache.tomcat.util.net.*;
/**
* Abstract the protocol implementation, including threading, etc.
* Processor is single threaded and specific to stream-based protocols,
* will not fit Jk protocols like JNI.
*
* @author Remy Maucherat
* @author Costin Manolache
*/
public class Http11Protocol implements ProtocolHandler
{
Adapter adapter;
Http11ConnectionHandler cHandler=new Http11ConnectionHandler( this );
/** Pass config info
*/
public void setAttribute( String name, Object value ) {
log.info(setAttribute + name + + value );
if( maxKeepAliveRequests.equals(name) ) {
//maxKeepAliveRequests=String.intValue((String)value);
}
}
public Object getAttribute( String key ) {
return null;
}
/** The adapter, used to call the connector
*/
public void
DO NOT REPLY [Bug 7700] - [PATCH] Anchors don't work when session tracking is handled by URL rewrite
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7700. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7700 [PATCH] Anchors don't work when session tracking is handled by URL rewrite [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 18:06 --- To elaborate on Bill's point. If the anchor correctly follows the query, then the anchor travels to the rewritten URL via the query. No anchor will be detected because is was removed as part of the query. Only if there is no query will an achor be detected. Thus the order doesn't matter except that the current code recreates the same order in the original URL. This means that if someone incorrectly put the anchor in front of the query string, it will still be in front of the query string in the rewritten URL. I agree with Bill that this is preferable to fixing the URL. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7771] - [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771 [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 18:17 --- Remy, I'm not sure this is a fix. If the anchor correctly follows the query, then the anchor travels to the rewritten URL via the query. No anchor will be detected because is was removed as part of the query. Only if there is no query will an achor be detected. Thus the order doesn't matter except that the old code recreates the same order as in the original URL. With this patch, a URL with the anchor incorrectly in front of the query will be rewritten in a fixed format. IMHO, if the URL is wrong to start with, it should still be wrong after it is rewritten. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java
kinman 02/04/05 10:40:50
Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Node.java
Log:
- Fixed some typo and obvious bugs.
- Reverted codes to init JspAttrs in Node.CustomTag: not the right place for it.
Revision ChangesPath
1.3 +4 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
Index: Generator.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- Generator.java28 Mar 2002 19:43:08 - 1.2
+++ Generator.java5 Apr 2002 18:40:50 - 1.3
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
1.2 2002/03/28 19:43:08 kinman Exp $
- * $Revision: 1.2 $
- * $Date: 2002/03/28 19:43:08 $
+ * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
1.3 2002/04/05 18:40:50 kinman Exp $
+ * $Revision: 1.3 $
+ * $Date: 2002/04/05 18:40:50 $
*
*
*
@@ -216,7 +216,7 @@
if (pageInfo.isSession())
out.printil(HttpSession session = null;);
- if (ctxt.isErrorPage())
+ if (pageInfo.isIsErrorPage())
out.printil(Throwable exception = (Throwable)
request.getAttribute(\javax.servlet.jsp.jspException\););
out.printil(ServletContext application = null;);
1.4 +6 -14
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
Index: Node.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Node.java 4 Apr 2002 11:32:05 - 1.3
+++ Node.java 5 Apr 2002 18:40:50 - 1.4
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
1.3 2002/04/04 11:32:05 remm Exp $
- * $Revision: 1.3 $
- * $Date: 2002/04/04 11:32:05 $
+ * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
1.4 2002/04/05 18:40:50 kinman Exp $
+ * $Revision: 1.4 $
+ * $Date: 2002/04/05 18:40:50 $
*
*
*
@@ -465,7 +465,7 @@
v.visit(this);
}
- public void setValue(JspAttribute page) {
+ public void setValue(JspAttribute value) {
this.value = value;
}
@@ -579,7 +579,7 @@
v.visit(this);
}
- public void setValue(JspAttribute page) {
+ public void setValue(JspAttribute value) {
this.value = value;
}
@@ -603,7 +603,7 @@
v.visit(this);
}
- public void setBeanName(JspAttribute page) {
+ public void setBeanName(JspAttribute beanName) {
this.beanName = beanName;
}
@@ -663,14 +663,6 @@
this.name = name;
this.prefix = prefix;
this.shortName = shortName;
-jspAttrs = new JspAttribute[attrs.getLength()];
-Hashtable attrsHashtable = new Hashtable();
-for (int i = 0; i attrs.getLength(); i++) {
-jspAttrs[i] = new JspAttribute
-(attrs.getLocalName(i), attrs.getValue(i), false);
-attrsHashtable.put(attrs.getLocalName(i), attrs.getValue(i));
-}
-tagData = new TagData(attrsHashtable);
}
public void accept(Visitor v) throws JasperException {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7771] - [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7771 [PATCH] HttpServletResponse.encodeURL and encodeRedirectURL appends link anchor before query string. [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 18:41 --- Ok, I'll revert the patch. I guess the tactic of the bug submitter worked great (insisting until someone fixes it). The RFC seemed to point that way, I just wasn't aware of how the code really behaved. *** This bug has been marked as a duplicate of 7700 *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7700] - [PATCH] Anchors don't work when session tracking is handled by URL rewrite
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7700. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7700 [PATCH] Anchors don't work when session tracking is handled by URL rewrite --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 18:41 --- *** Bug 7771 has been marked as a duplicate of this bug. *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Tomcat3Adapter.java Tomcat3Request.java Tomcat3Response.java
costin 02/04/05 10:42:03
Added: coyote/src/java/org/apache/coyote/tomcat3
CoyoteInterceptor2.java Tomcat3Adapter.java
Tomcat3Request.java Tomcat3Response.java
Log:
Initial ( and incomplete ) refactoring to use ProtocolHandler and
stateless objects.
I used different names to avoid affecting the existing ( working ) impl.,
the code is cut and pasted.
After I get everything stable we can switch back to the original
names or keep the new ones.
Revision ChangesPath
1.1
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/CoyoteInterceptor2.java
Index: CoyoteInterceptor2.java
===
/*
*
*
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
*notice, this list of conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright
*notice, this list of conditions and the following disclaimer in
*the documentation and/or other materials provided with the
*distribution.
*
* 3. The end-user documentation included with the redistribution, if
*any, must include the following acknowlegement:
* This product includes software developed by the
*Apache Software Foundation (http://www.apache.org/).
*Alternately, this acknowlegement may appear in the software itself,
*if and wherever such third-party acknowlegements normally appear.
*
* 4. The names The Jakarta Project, Tomcat, and Apache Software
*Foundation must not be used to endorse or promote products derived
*from this software without prior written permission. For written
*permission, please contact [EMAIL PROTECTED]
*
* 5. Products derived from this software may not be called Apache
*nor may Apache appear in their names without prior written
*permission of the Apache Group.
*
* THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
* USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
* OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package org.apache.coyote.tomcat3;
import java.io.*;
import java.net.*;
import java.util.*;
import java.text.*;
import org.apache.tomcat.core.*;
import org.apache.tomcat.util.res.StringManager;
import org.apache.tomcat.util.IntrospectionUtils;
import org.apache.tomcat.util.buf.*;
import org.apache.tomcat.util.http.*;
import org.apache.tomcat.util.log.*;
import org.apache.tomcat.util.compat.*;
import org.apache.tomcat.util.net.*;
import org.apache.coyote.*;
/** Standalone http.
*
* Connector properties:
* ul
* li secure - will load a SSL socket factory and act as https server/li
* /ul
*
* Properties passed to the net layer:
* ul
* litimeout/li
* libacklog/li
* liaddress/li
* liport/li
* /ul
* Thread pool properties:
* ul
* liminSpareThreads/li
* limaxSpareThreads/li
* limaxThreads/li
* lipoolOn/li
* /ul
* Properties for HTTPS:
* ul
* likeystore - certificates - default to ~/.keystore/li
* likeypass - password/li
* liclientauth - true if the server should authenticate the client using
certs/li
* /ul
* Properties for HTTP:
* ul
* lireportedname - name of server sent back to browser (security purposes)/li
* /ul
*/
public class CoyoteInterceptor2 extends BaseInterceptor
{
private String
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java
remm02/04/05 10:42:51 Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java Log: - Revert patch. Revision ChangesPath 1.13 +5 -5 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java Index: CoyoteResponse.java === RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- CoyoteResponse.java 5 Apr 2002 17:01:00 - 1.12 +++ CoyoteResponse.java 5 Apr 2002 18:42:51 - 1.13 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v 1.12 2002/04/05 17:01:00 remm Exp $ - * $Revision: 1.12 $ - * $Date: 2002/04/05 17:01:00 $ + * $Header: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteResponse.java,v 1.13 2002/04/05 18:42:51 remm Exp $ + * $Revision: 1.13 $ + * $Date: 2002/04/05 18:42:51 $ * * * @@ -116,7 +116,7 @@ * * @author Remy Maucherat * @author Craig R. McClanahan - * @version $Revision: 1.12 $ $Date: 2002/04/05 17:01:00 $ + * @version $Revision: 1.13 $ $Date: 2002/04/05 18:42:51 $ */ public class CoyoteResponse @@ -1354,8 +1354,8 @@ sb.append(;jsessionid=); sb.append(sessionId); } -sb.append(query); sb.append(anchor); +sb.append(query); return (sb.toString()); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java
remm02/04/05 10:43:12 Modified:catalina/src/share/org/apache/catalina/connector HttpResponseBase.java Log: - Revert patch. Revision ChangesPath 1.54 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java Index: HttpResponseBase.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v retrieving revision 1.53 retrieving revision 1.54 diff -u -r1.53 -r1.54 --- HttpResponseBase.java 5 Apr 2002 17:25:26 - 1.53 +++ HttpResponseBase.java 5 Apr 2002 18:43:12 - 1.54 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.53 2002/04/05 17:25:26 remm Exp $ - * $Revision: 1.53 $ - * $Date: 2002/04/05 17:25:26 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.54 2002/04/05 18:43:12 remm Exp $ + * $Revision: 1.54 $ + * $Date: 2002/04/05 18:43:12 $ * * * @@ -104,7 +104,7 @@ * * @author Craig R. McClanahan * @author Remy Maucherat - * @version $Revision: 1.53 $ $Date: 2002/04/05 17:25:26 $ + * @version $Revision: 1.54 $ $Date: 2002/04/05 18:43:12 $ * @deprecated */ @@ -756,8 +756,8 @@ sb.append(;jsessionid=); sb.append(sessionId); } -sb.append(query); sb.append(anchor); +sb.append(query); return (sb.toString()); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java
remm02/04/05 10:44:21 Modified:catalina/src/share/org/apache/catalina/connector Tag: tomcat_40_branch HttpResponseBase.java Log: - Revert patch. Revision ChangesPath No revision No revision 1.37.2.13 +5 -5 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java Index: HttpResponseBase.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v retrieving revision 1.37.2.12 retrieving revision 1.37.2.13 diff -u -r1.37.2.12 -r1.37.2.13 --- HttpResponseBase.java 5 Apr 2002 17:26:25 - 1.37.2.12 +++ HttpResponseBase.java 5 Apr 2002 18:44:21 - 1.37.2.13 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.37.2.12 2002/04/05 17:26:25 remm Exp $ - * $Revision: 1.37.2.12 $ - * $Date: 2002/04/05 17:26:25 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v 1.37.2.13 2002/04/05 18:44:21 remm Exp $ + * $Revision: 1.37.2.13 $ + * $Date: 2002/04/05 18:44:21 $ * * * @@ -102,7 +102,7 @@ * * @author Craig R. McClanahan * @author Remy Maucherat - * @version $Revision: 1.37.2.12 $ $Date: 2002/04/05 17:26:25 $ + * @version $Revision: 1.37.2.13 $ $Date: 2002/04/05 18:44:21 $ */ public class HttpResponseBase @@ -740,8 +740,8 @@ sb.append(;jsessionid=); sb.append(sessionId); } -sb.append(query); sb.append(anchor); +sb.append(query); return (sb.toString()); } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote build.xml
costin 02/04/05 11:11:05
Modified:.build.xml
coyote build.xml
Log:
Few small fixes.
I build all the stuff in one jar for easier testing. I'm also experimenting
with the order and with removing util from 3.3.
Revision ChangesPath
1.2 +11 -0 jakarta-tomcat-connectors/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/build.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- build.xml 4 Apr 2002 20:25:03 - 1.1
+++ build.xml 5 Apr 2002 19:11:05 - 1.2
@@ -25,4 +25,15 @@
/jar
/target
+
+ target name=clean
+ description=Compile Coyote and all related protocols
+ant dir=util target=clean /
+ant dir=coyote target=clean /
+ant dir=http11 target=clean/
+ant dir=jk target=clean /
+
+delete file=jtc.jar /
+ /target
+
/project
1.7 +5 -2 jakarta-tomcat-connectors/coyote/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/build.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- build.xml 10 Mar 2002 06:15:47 - 1.6
+++ build.xml 5 Apr 2002 19:11:05 - 1.7
@@ -3,7 +3,7 @@
!--
Coyote connector framework for Jakarta Tomcat
-$Id: build.xml,v 1.6 2002/03/10 06:15:47 billbarker Exp $
+$Id: build.xml,v 1.7 2002/04/05 19:11:05 costin Exp $
--
@@ -74,15 +74,19 @@
!-- Construct compile classpath --
path id=compile.classpath
pathelement location=${build.home}/classes/
+pathelement location=../util/build/classes/
pathelement location=${tomcat-util.jar}/
pathelement location=${catalina.home}/server/lib/catalina.jar/
pathelement location=${catalina.home}/common/lib/servlet.jar/
/path
path id=compile.classpath.tomcat33
pathelement location=${build.home}/classes/
+pathelement location=../util/build/classes/
pathelement location=${tomcat33.home}/lib/container/tomcat_util.jar/
+pathelement location=${tomcat33.home}/lib/container/jtc.jar/
pathelement location=${tomcat33.home}/lib/container/tomcat_modules.jar/
pathelement location=${tomcat33.home}/lib/common/tomcat_core.jar/
+pathelement location=${tomcat33.home}/lib/common/core_util.jar/
/path
@@ -212,7 +216,6 @@
includes=org/apache/coyote/**
excludes=**/tomcat4/* /
/target
-
target name=compile.tests depends=compile
description=Compile unit test cases
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk build.xml
costin 02/04/05 11:11:42
Modified:jk build.xml
Log:
Build ordering
Revision ChangesPath
1.31 +2 -1 jakarta-tomcat-connectors/jk/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/build.xml,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- build.xml 3 Apr 2002 23:56:41 - 1.30
+++ build.xml 5 Apr 2002 19:11:42 - 1.31
@@ -90,6 +90,7 @@
/copy
path id=build-main.classpath
+pathelement location=../util/build/classes/
pathelement location=${catalina.home}/server/lib/catalina.jar/
pathelement location=${catalina.home}/common/lib/servlet.jar/
pathelement location=${tomcat33.home}/lib/common/tomcat_core.jar/
@@ -110,7 +111,7 @@
/target
target name=build-main
-depends=prepare,report,jkutil,jkjava,jkant /
+depends=prepare,report,jkjava,jkant /
!-- Building --
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.c
costin 02/04/05 11:13:56
Modified:jk/native2/server/apache2 mod_jk2.c
Log:
Added a pre-defined serverRoot variable, to resolve paths.
Right now the best way is to not use relative paths, but ${serverRoot}/logs/...
or ${serverRoot}/conf/jk2.properties.
Revision ChangesPath
1.8 +4 -2 jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c
Index: mod_jk2.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- mod_jk2.c 26 Mar 2002 03:04:54 - 1.7
+++ mod_jk2.c 5 Apr 2002 19:13:56 - 1.8
@@ -59,7 +59,7 @@
* Description: Apache 2 plugin for Jakarta/Tomcat *
* Author: Gal Shachor [EMAIL PROTECTED] *
* Henri Gomez [EMAIL PROTECTED] *
- * Version: $Revision: 1.7 $ *
+ * Version: $Revision: 1.8 $ *
***/
/*
@@ -292,12 +292,14 @@
jkb=env-createBean2( env, env-globalPool,workerEnv, );
workerEnv= jkb-object;
env-alias( env, workerEnv: , workerEnv);
-
+
if( workerEnv==NULL ) {
env-l-jkLog(env, env-l, JK_LOG_ERROR, Error creating workerEnv\n);
return;
}
+workerEnv-initData-add( env, workerEnv-initData, serverRoot,
ap_server_root);
+
/* Local initialization */
workerEnv-_private = s;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java
kinman 02/04/05 12:27:30
Modified:jasper2/src/share/org/apache/jasper/compiler Node.java
Log:
- Add visitBody to visit(JspText) for the default visitor, because
jsp:text has a body.
Revision ChangesPath
1.5 +4 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
Index: Node.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Node.java 5 Apr 2002 18:40:50 - 1.4
+++ Node.java 5 Apr 2002 20:27:30 - 1.5
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
1.4 2002/04/05 18:40:50 kinman Exp $
- * $Revision: 1.4 $
- * $Date: 2002/04/05 18:40:50 $
+ * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
1.5 2002/04/05 20:27:30 kinman Exp $
+ * $Revision: 1.5 $
+ * $Date: 2002/04/05 20:27:30 $
*
*
*
@@ -956,6 +956,7 @@
public void visit(JspText n) throws JasperException {
doVisit(n);
+ visitBody(n);
}
public void visit(TemplateText n) throws JasperException {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7778] New: - mod_webapp does not set 'Content-Type: text/html' when reporting a compiler error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7778. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7778 mod_webapp does not set 'Content-Type: text/html' when reporting a compiler error Summary: mod_webapp does not set 'Content-Type: text/html' when reporting a compiler error Product: Tomcat 4 Version: 4.0.3 Final Platform: PC OS/Version: Linux Status: NEW Severity: Minor Priority: Other Component: Connector:Webapp AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] TC 4.0.3 APACHE 1.3.20 since upgrading from TC4.0.1 - TC4.0.3 the 500-Internal Server Error page which is displayed by TC when a compiler error occurs while serving a jsp-file no longer has it's content-type set to text/html. Probably many installations won't be affected by it, but since setting apache's defaulttype to something other than text/html is possible, TC should set the Content-Type to text/html explicitly. It was reproducible on TC4.0.2 final and TC4.0.3 final using the most recent mod_webapp.so (self-compiled and precompiled) with a simple jsp not closing the %@ tag... I had TC4.0.1, TC4.0.2 and TC4.0.3 installed in parallel (all stock-installations downloaded and untarred from apache.org - not changed a single file)... tested this using the exact same config-file (with -config ). I used a link to refer to the TC installation to be started. When running TC4.0.2 and TC4.0.3 every compilation-error had a MIME-Type of: text/plain. Running TC4.0.1 it was text/html again. Changing the DefaultType in apache's config from text/plain to text/html fixed the problem for now! However: it'd be nice to use a DefaultType of text/plain again (for some other reason...) Thanks :-) Matthias Ivers -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7778] - mod_webapp does not set 'Content-Type: text/html' when reporting a compiler error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7778. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7778 mod_webapp does not set 'Content-Type: text/html' when reporting a compiler error [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 21:16 --- This has already been fixed. *** This bug has been marked as a duplicate of 6468 *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 6468] - content-type not set for errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6468. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6468 content-type not set for errors [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2002-04-05 21:16 --- *** Bug 7778 has been marked as a duplicate of this bug. *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3 CoyoteInterceptor2.java Tomcat3Request.java Tomcat3Response.java
costin 02/04/05 14:17:49
Modified:coyote/src/java/org/apache/coyote/tomcat3
CoyoteInterceptor2.java Tomcat3Request.java
Tomcat3Response.java
Log:
One more step.
The only remaining problem is implementing callbacks to the protocol that
'pull' information.
Revision ChangesPath
1.2 +2 -2
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/CoyoteInterceptor2.java
Index: CoyoteInterceptor2.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/CoyoteInterceptor2.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CoyoteInterceptor2.java 5 Apr 2002 18:42:03 - 1.1
+++ CoyoteInterceptor2.java 5 Apr 2002 22:17:49 - 1.2
@@ -193,9 +193,9 @@
*/
public int preService(org.apache.tomcat.core.Request request,
org.apache.tomcat.core.Response response) {
- if(response instanceof CoyoteResponse) {
+ if(response instanceof Tomcat3Response) {
try {
- ((CoyoteResponse)response).sendAcknowledgement();
+ ((Tomcat3Response)response).sendAcknowledgement();
} catch(Exception ex) {
log(Can't send ACK, ex);
}
1.2 +35 -48
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/Tomcat3Request.java
Index: Tomcat3Request.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat3/Tomcat3Request.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- Tomcat3Request.java 5 Apr 2002 18:42:03 - 1.1
+++ Tomcat3Request.java 5 Apr 2002 22:17:49 - 1.2
@@ -78,18 +78,23 @@
/** The Request to connect with Coyote.
* This class handles the I/O requirements and transferring the request
* line and Mime headers between Coyote and Tomcat.
- * @Author Bill Barker
+ *
+ * @author Bill Barker
+ * @author Costin Manolache
*/
public class Tomcat3Request extends org.apache.tomcat.core.Request {
org.apache.coyote.Request coyoteRequest=null;
-
-SSLSupport sslSupport=null;
+
+// For SSL attributes we need to call an ActionHook to get
+// info from the protocol handler.
+//SSLSupport sslSupport=null;
+
ByteChunk readChunk = new ByteChunk();
int pos=-1;
int end=-1;
byte [] readBuffer = null;
-Socket socket = null;
+
public Tomcat3Request() {
super();
@@ -100,11 +105,11 @@
public void recycle() {
super.recycle();
if( coyoteRequest != null) coyoteRequest.recycle();
+
remoteAddrMB.recycle();
remoteHostMB.recycle();
-
readChunk.recycle();
- sslSupport=null;
+
readBuffer=null;
pos=-1;
end=-1;
@@ -115,32 +120,22 @@
* attributes to the Tomcat attributes.
*/
public void setCoyoteRequest(org.apache.coyote.Request cReq) {
- coyoteRequest=cReq;
- // This is really ugly, but fast.
- // I could still be talked out of it.
- schemeMB.recycle();
- methodMB.recycle();
- uriMB.recycle();
- queryMB.recycle();
- protoMB.recycle();
- try {
- schemeMB.duplicate(coyoteRequest.scheme());
- methodMB.duplicate(coyoteRequest.method());
- uriMB.duplicate(coyoteRequest.requestURI());
- queryMB.duplicate(coyoteRequest.query());
- protoMB.duplicate(coyoteRequest.protocol());
- } catch(IOException iex) { // ignore
- }
+coyoteRequest=cReq;
+
+// The CoyoteRequest/Tomcat3Request are bound togheter, they
+// don't change. That means we can use the same field ( which
+// doesn't change as well.
+schemeMB = coyoteRequest.scheme();
+methodMB = coyoteRequest.method();
+uriMB = coyoteRequest.requestURI();
+queryMB = coyoteRequest.query();
+protoMB = coyoteRequest.protocol();
+
headers = coyoteRequest.getMimeHeaders();
scookies.setHeaders(headers);
params.setHeaders(headers);
}
-/** Set the socket for this request.
- */
-public void setSocket(Socket socket) {
- this.socket = socket;
-}
-
+
/** Read a single character from the request body.
*/
public int doRead() throws IOException {
@@ -201,43 +196,35 @@
// override special methods
public MessageBytes remoteAddr() {
- if( remoteAddrMB.isNull() ) {
- remoteAddrMB.setString(socket.getInetAddress().getHostAddress());
- }
CoyoteRequest: the socket
2 questions ( for Remy ): - is anyone using the getSocket() method in CoyoteRequest ? It's obvious this can't work for other protocols, and extracting SSL info is specific to the SSL impl and should be done at the protocol layer. - Any reason for not extending HttpBaseRequest ? Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
2 questions ( for Remy ): - is anyone using the getSocket() method in CoyoteRequest ? It's obvious this can't work for other protocols, and extracting SSL info is specific to the SSL impl and should be done at the protocol layer. Some valves in the Catalina pipeline use that. It probably should be done at the protocol layer, but I can't do that for compatibility reasons, so I think the socket should be set as a note in the Request object (as is suggested in the commented out code in the HTTP/1.1 protocol handler). - Any reason for not extending HttpBaseRequest ? You mean HttpRequestBase in Catalina ? This object's implementation is bad, and I wanted to deprecate it to make that obvious. There's little code duplication overall. There's also no ugly casts to the XXBase objects in the Catalina pipeline (everthing uses the interfaces), so it works fine. I'll do a CoyoteConnector2 for Catalina soon too to see how it works. Probably tomorrow. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
On Fri, 5 Apr 2002, Remy Maucherat wrote: Some valves in the Catalina pipeline use that. It probably should be done at the protocol layer, but I can't do that for compatibility reasons, so I think the socket should be set as a note in the Request object (as is suggested in the commented out code in the HTTP/1.1 protocol handler). Ok. I hope the code can deal with 'no socket' case - since in Ajp case the socket is completely useless. I have big doubts the code that calls getSocket() can even work with ajp or pureTLS or other things. Probably a good idea to find where it is and call the right thing ( like getAttribute for certs, etc ). - Any reason for not extending HttpBaseRequest ? You mean HttpRequestBase in Catalina ? This object's implementation is bad, and I wanted to deprecate it to make that obvious. There's little code duplication overall. There's also no ugly casts to the XXBase objects in the Catalina pipeline (everthing uses the interfaces), so it works fine. I'll do a CoyoteConnector2 for Catalina soon too to see how it works. Probably tomorrow. Ok, what about CoyoteConnector3 ? I already started with 2 :-) ( but I'll start working on Jk if you do the Connector ) Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 352] - xsl.apply xsl.import Absolute (external) URLs BugRat Report#632
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=352. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=352 xsl.apply xsl.import Absolute (external) URLs BugRat Report#632 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|tomcat- |[EMAIL PROTECTED] |[EMAIL PROTECTED] | Status|NEW |UNCONFIRMED --- Additional Comments From [EMAIL PROTECTED] 2002-04-06 00:32 --- This feature won't be added. The XSL taglib will be deprecated soon since it uses Xalan1 which is deprecated and the XTAGS and Standard taglibs provide a better alternative. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 331] - Support for parametric XSL in xsl-taglib BugRat Report#597
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=331. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=331 Support for parametric XSL in xsl-taglib BugRat Report#597 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|tomcat- |[EMAIL PROTECTED] |[EMAIL PROTECTED] | Status|NEW |UNCONFIRMED -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 349] - Suport for relative URLS in XSL taglib BugRat Report#627
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=349. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=349 Suport for relative URLS in XSL taglib BugRat Report#627 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|tomcat- |[EMAIL PROTECTED] |[EMAIL PROTECTED] | Status|NEW |UNCONFIRMED -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[FAQ] jGuru FAQ Update
jGuru maintains FAQs and Forums on Servlets, JSP, and Tomcat (as well as many other Java topics). Here is an automated update on recent postings to Tomcat-related FAQs. Please direct flames and feedback to [EMAIL PROTECTED] . - Alex JGURU LAUNCHES PREMIUM SERVICES! For as little as 0.14 a day, you can look at naughty pictures on the net...just not at jGuru. You can, however, help keep jGuru the best place to get Java answers by becoming a premium member! Help support jGuru: http://www.jguru.com/misc/page.jsp?fsm=premiumregnode=blurbsrc=email Hi. You asked to be notified weekly when certain jGuru.com items get new entries. ++ JavaServer Pages (JSP) FAQ: http://www.jguru.com/faq/JSP I have a Jsp page that accepts some parameters from the user. Now if the user clicks on the Submit button in rapid succession, multiple entries are inserted in DB, though I am checking for duplicate entries. This works fine if the user enters the same data after some time. It gives appropriate message saying Duplicate record. p Please use html tags to format code blocks. http://www.jguru.com/misc/faqtrampoline.jsp?src=notifyEID=820070 I'm a bit confused with the term bean in JSP eg. the tag lt;jsp:useBean ... gt; From what I understand, the term bean used here is referring to a simple java object. p When I look through the JavaBean resources, their definition of bean seemed a bit different. p Any comment ? brbrbr Thank u ... http://www.jguru.com/misc/faqtrampoline.jsp?src=notifyEID=820069 Need some assistance on this one. I am very new to managing a java environment and a production application appears to be having a major memory leak. Am currently using JDK 1.3 on a Sun box running Sol 2.6, with 2GB of RAm, and using Orion 1.5.1. I have -Xmx set to 756MB. When Orion is started the heap immediately grabs 512MB, then over the next 6 - 8 hours the heap slowly consumes all but 30 or so MB of RAM on the box, totally disregarding the -Xmx setting. Additionally, if we run a bootstrap of our a client during this time memory consumption is accelerated drastically. Any insights would be greatly appreciated. http://www.jguru.com/misc/faqtrampoline.jsp?src=notifyEID=820066 Can any one post a - code snippet - which can create a .txt file on the application server - using the text from a textArea on a JSP page. (Basically the user types some text on the JSP on a client and the text should be saved to a txt-file on ap-server.) http://www.jguru.com/misc/faqtrampoline.jsp?src=notifyEID=820007 What is the easiest way to convert the output of a JSP to PDF? http://www.jguru.com/misc/faqtrampoline.jsp?src=notifyEID=820005 You can shut email notification off at the FAQ home page(s) or: http://www.jguru.com/guru/notifyprefs.jsp -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
On Fri, 5 Apr 2002, Remy Maucherat wrote: Some valves in the Catalina pipeline use that. It probably should be done at the protocol layer, but I can't do that for compatibility reasons, so I think the socket should be set as a note in the Request object (as is suggested in the commented out code in the HTTP/1.1 protocol handler). Ok. I hope the code can deal with 'no socket' case - since in Ajp case the socket is completely useless. Apparently, the only class which uses that method is o.a.c.valves.CertificatesValve. It handles the case where getSocket returns null. I have big doubts the code that calls getSocket() can even work with ajp or pureTLS or other things. Probably a good idea to find where it is and call the right thing ( like getAttribute for certs, etc ). I'm not sure about it, but it doesn't look like client-cert would work with PureTLS. - Any reason for not extending HttpBaseRequest ? You mean HttpRequestBase in Catalina ? This object's implementation is bad, and I wanted to deprecate it to make that obvious. There's little code duplication overall. There's also no ugly casts to the XXBase objects in the Catalina pipeline (everthing uses the interfaces), so it works fine. I'll do a CoyoteConnector2 for Catalina soon too to see how it works. Probably tomorrow. Ok, what about CoyoteConnector3 ? I already started with 2 :-) It's quite simple to do. I'll do it at least to learn how to manipulate the new interface, and see if there are problems with the new Http11Protocol class. ( but I'll start working on Jk if you do the Connector ) That's not something I can do, so that looks like a good idea :) Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: CoyoteRequest: the socket
Remy Maucherat [EMAIL PROTECTED] writes: On Fri, 5 Apr 2002, Remy Maucherat wrote: I have big doubts the code that calls getSocket() can even work with ajp or pureTLS or other things. Probably a good idea to find where it is and call the right thing ( like getAttribute for certs, etc ). I'm not sure about it, but it doesn't look like client-cert would work with PureTLS. Hmm... I need to dig into this. Why do you think it wouldn't? -Ekr -- [Eric Rescorla [EMAIL PROTECTED]] http://www.rtfm.com/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java
remm02/04/05 19:06:32
Modified:coyote/src/java/org/apache/coyote/tomcat4 CoyoteRequest.java
Log:
- Fix an off-by-one bug in the construction of the request dispatcher path.
Revision ChangesPath
1.16 +5 -5
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java
Index: CoyoteRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- CoyoteRequest.java3 Apr 2002 15:57:11 - 1.15
+++ CoyoteRequest.java6 Apr 2002 03:06:32 - 1.16
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
1.15 2002/04/03 15:57:11 remm Exp $
- * $Revision: 1.15 $
- * $Date: 2002/04/03 15:57:11 $
+ * $Header:
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
1.16 2002/04/06 03:06:32 remm Exp $
+ * $Revision: 1.16 $
+ * $Date: 2002/04/06 03:06:32 $
*
*
*
@@ -123,7 +123,7 @@
*
* @author Remy Maucherat
* @author Craig R. McClanahan
- * @version $Revision: 1.15 $ $Date: 2002/04/03 15:57:11 $
+ * @version $Revision: 1.16 $ $Date: 2002/04/06 03:06:32 $
*/
public class CoyoteRequest
@@ -1063,7 +1063,7 @@
int pos = servletPath.lastIndexOf('/');
String relative = null;
-if (pos 0) {
+if (pos = 0) {
relative = RequestUtil.normalize
(servletPath.substring(0, pos + 1) + path);
} else {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpRequestBase.java
remm02/04/05 19:06:52
Modified:catalina/src/share/org/apache/catalina/connector
HttpRequestBase.java
Log:
- Fix an off-by-one bug in the construction of the request dispatcher path.
Revision ChangesPath
1.37 +5 -5
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java
Index: HttpRequestBase.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- HttpRequestBase.java 23 Mar 2002 17:35:11 - 1.36
+++ HttpRequestBase.java 6 Apr 2002 03:06:52 - 1.37
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
1.36 2002/03/23 17:35:11 remm Exp $
- * $Revision: 1.36 $
- * $Date: 2002/03/23 17:35:11 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
1.37 2002/04/06 03:06:52 remm Exp $
+ * $Revision: 1.37 $
+ * $Date: 2002/04/06 03:06:52 $
*
*
*
@@ -102,7 +102,7 @@
* be implemented.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.36 $ $Date: 2002/03/23 17:35:11 $
+ * @version $Revision: 1.37 $ $Date: 2002/04/06 03:06:52 $
* @deprecated
*/
@@ -762,7 +762,7 @@
int pos = servletPath.lastIndexOf('/');
String relative = null;
-if (pos 0) {
+if (pos = 0) {
relative = RequestUtil.normalize
(servletPath.substring(0, pos + 1) + path);
} else {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpRequestBase.java
remm02/04/05 19:07:03
Modified:catalina/src/share/org/apache/catalina/connector Tag:
tomcat_40_branch HttpRequestBase.java
Log:
- Fix an off-by-one bug in the construction of the request dispatcher path.
Revision ChangesPath
No revision
No revision
1.31.2.3 +5 -5
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java
Index: HttpRequestBase.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
retrieving revision 1.31.2.2
retrieving revision 1.31.2.3
diff -u -r1.31.2.2 -r1.31.2.3
--- HttpRequestBase.java 23 Mar 2002 17:35:02 - 1.31.2.2
+++ HttpRequestBase.java 6 Apr 2002 03:07:03 - 1.31.2.3
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
1.31.2.2 2002/03/23 17:35:02 remm Exp $
- * $Revision: 1.31.2.2 $
- * $Date: 2002/03/23 17:35:02 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpRequestBase.java,v
1.31.2.3 2002/04/06 03:07:03 remm Exp $
+ * $Revision: 1.31.2.3 $
+ * $Date: 2002/04/06 03:07:03 $
*
*
*
@@ -102,7 +102,7 @@
* be implemented.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.31.2.2 $ $Date: 2002/03/23 17:35:02 $
+ * @version $Revision: 1.31.2.3 $ $Date: 2002/04/06 03:07:03 $
*/
public class HttpRequestBase
@@ -754,7 +754,7 @@
int pos = servletPath.lastIndexOf('/');
String relative = null;
-if (pos 0) {
+if (pos = 0) {
relative = RequestUtil.normalize
(servletPath.substring(0, pos + 1) + path);
} else {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Timestamps in catalina.out?
Is there a way to append a timestamp to the entries within catalina.out? I see where you can specify timestamp=true in server.xml (below), but that goes to another log. Logger className=org.apache.catalina.logger.FileLogger prefix=apache_log. suffix=.txt timestamp=true/ Thanks. -- Alfred -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7785] New: - tomcat bug in context reloading
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7785. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7785 tomcat bug in context reloading Summary: tomcat bug in context reloading Product: Tomcat 3 Version: 3.2.3 Final Platform: Other OS/Version: Linux Status: NEW Severity: Blocker Priority: Other Component: Unknown AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] There seems to be a bug in the version 3.2.3 of tomcat Due to which , I am getting this exception java.lang.ClassCastException: ClassTeacher.Registration.RegSession at com.MindShaper.ClassTeacher.Apps.HigherEd.IIFT.Users.ProgramBuy.doPost (ProgramBuy.java:44) at javax.servlet.http.HttpServlet.service(HttpServlet.java:760) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.tomcat.core.ServletWrapper.doService(ServletWrapper.java:405) at org.apache.tomcat.core.Handler.service(Handler.java:287 Plz see the link below. My problem is similer. http://www.apachelabs.org/tomcat-dev/27.mbox/% [EMAIL PROTECTED]%3E this exception shows up whenever I am trying to cast an Object obtained from session after uploading a servlet.The details are same as discussed in the above link. Plz note that we need auto reloading of the servlets so it cannot be turned false. Please note that this problem would be temporarily resolved once you restart the tomcat, but will show up as soon as I upload a servlets. The source code of the TestServlet. HttpSession sess=req.getSession(false); Object o=sess.getValue(SessionObjectDefines.KEY_REGINFO); out.print(o.getClass() +o.getClass()+br); ClassTeacher.Registration.RegSession regSess = (ClassTeacher.Registration.RegSession)o; On running this , we see this o.getClass() prints the fully qualified class name as ClassTeacher.Registration.RegSession which is same as the object I am trying to cast to. counter is ...11 o.getClass() class ClassTeacher.Registration.RegSession Error: 500 Location: /servlets/TestServlet Internal Servlet Error: java.lang.ClassCastException: ClassTeacher.Registration.RegSession at TestServlet.doGet(TestServlet.java:39) at javax.servlet.http.HttpServlet.service(HttpServlet.java:740) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.tomcat.core.ServletWrapper.doService(ServletWrapper.java:405) at org.apache.tomcat. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
