Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-09-12 Thread Bill Barker


- Original Message -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Wednesday, September 11, 2002 10:48 PM
Subject: cvs commit:
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
CoyoteResponse.java


 amyroh  2002/09/11 22:48:19

   Modified:coyote/src/java/org/apache/coyote Response.java
coyote/src/java/org/apache/coyote/tomcat4
 CoyoteResponse.java
   Log:
   Fix for Response.setLocale() to set charset encoding correctly -
bugzilla 10901.
   Patch submitted by OGAWA Kan [EMAIL PROTECTED].

   Revision  ChangesPath
   1.14  +79 -74
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java

   Index: Response.java


It would be really nice if people could split tab-fix from code commits.
:(

Of course, it's not Amy's fault.  There shouldn't have been tabs in
o.a.c.Response in the first place (It's under the 4.x coding specs).  I'm
just whining here.



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteResponse.java

2002-09-12 Thread amyroh

amyroh  2002/09/11 23:42:12

  Modified:coyote/src/java/org/apache/coyote Response.java
   coyote/src/java/org/apache/coyote/tomcat4
CoyoteResponse.java
  Log:
  Minor ugly tab fixes.
  
  Revision  ChangesPath
  1.15  +71 -71
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java
  
  Index: Response.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- Response.java 12 Sep 2002 05:48:18 -  1.14
  +++ Response.java 12 Sep 2002 06:42:11 -  1.15
  @@ -168,7 +168,7 @@
   }
   
   public OutputBuffer getOutputBuffer() {
  -return outputBuffer;
  +return outputBuffer;
   }
   
   
  @@ -178,7 +178,7 @@
   
   
   public MimeHeaders getMimeHeaders() {
  -return headers;
  +return headers;
   }
   
   
  @@ -196,12 +196,12 @@
   
   
   public final void setNote(int pos, Object value) {
  -notes[pos] = value;
  +notes[pos] = value;
   }
   
   
   public final Object getNote(int pos) {
  -return notes[pos];
  +return notes[pos];
   }
   
   
  @@ -230,7 +230,7 @@
* Set the response status 
*/ 
   public void setStatus( int status ) {
  -this.status = status;
  +this.status = status;
   }
   
   
  @@ -251,12 +251,12 @@
   
   
   public boolean isCommitted() {
  -return commited;
  +return commited;
   }
   
   
   public void setCommitted(boolean v) {
  -this.commited = v;
  +this.commited = v;
   }
   
   
  @@ -277,12 +277,12 @@
* processing.
*/
   public Exception getErrorException() {
  -return errorException;
  +return errorException;
   }
   
   
   public boolean isExceptionPresent() {
  -return ( errorException != null );
  +return ( errorException != null );
   }
   
   
  @@ -291,14 +291,14 @@
* request processing.
*/
   public void setErrorURI(String uri) {
  -errorURI = uri;
  +errorURI = uri;
   }
   
   
   /** Get the request URI that caused the original error.
*/
   public String getErrorURI() {
  -return errorURI;
  +return errorURI;
   }
   
   
  @@ -319,14 +319,14 @@
   message = null;
   headers.clear();
   
  -// Force the PrintWriter to flush its data to the output
  -// stream before resetting the output stream
  -//
  -// Reset the stream
  -if (commited) {
  -//String msg = sm.getString(servletOutputStreamImpl.reset.ise); 
  -throw new IllegalStateException();
  -}
  +// Force the PrintWriter to flush its data to the output
  +// stream before resetting the output stream
  +//
  +// Reset the stream
  +if (commited) {
  +//String msg = sm.getString(servletOutputStreamImpl.reset.ise); 
  +throw new IllegalStateException();
  +}
   
   action(ActionCode.ACTION_RESET, this);
   }
  @@ -344,27 +344,27 @@
   
   //  Headers 
   public boolean containsHeader(String name) {
  -return headers.getHeader(name) != null;
  +return headers.getHeader(name) != null;
   }
   
   
   public void setHeader(String name, String value) {
  -char cc=name.charAt(0);
  -if( cc=='C' || cc=='c' ) {
  -if( checkSpecialHeader(name, value) )
  -return;
  -}
  -headers.setValue(name).setString( value);
  +char cc=name.charAt(0);
  +if( cc=='C' || cc=='c' ) {
  +if( checkSpecialHeader(name, value) )
  +return;
  +}
  +headers.setValue(name).setString( value);
   }
   
   
   public void addHeader(String name, String value) {
  -char cc=name.charAt(0);
  -if( cc=='C' || cc=='c' ) {
  -if( checkSpecialHeader(name, value) )
  -return;
  -}
  -headers.addValue(name).setString( value );
  +char cc=name.charAt(0);
  +if( cc=='C' || cc=='c' ) {
  +if( checkSpecialHeader(name, value) )
  +return;
  +}
  +headers.addValue(name).setString( value );
   }
   
   
  @@ -374,27 +374,27 @@
* Return true if the header is special, no need to set the header.
*/
   private boolean checkSpecialHeader( String name, String value) {
  -// XXX Eliminate redundant fields !!!
  -// ( both header and in special fields )
  -if( name.equalsIgnoreCase( Content-Type ) ) {
  -setContentType( value );
  -return true;
  -}
  -if( name.equalsIgnoreCase( Content-Length ) ) {
  -try {
  -int 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java

2002-09-12 Thread amyroh

amyroh  2002/09/11 23:44:25

  Modified:catalina/src/conf tomcat-users.xml web.xml
   catalina/src/share/org/apache/catalina/servlets
HTMLManagerServlet.java ManagerServlet.java
   catalina/src/share/org/apache/catalina/valves
ErrorReportValve.java
  Log:
  Fix the output character encoding of servlet to Tomcat 5.
  
  Revision  ChangesPath
  1.4   +1 -1  jakarta-tomcat-catalina/catalina/src/conf/tomcat-users.xml
  
  Index: tomcat-users.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/tomcat-users.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- tomcat-users.xml  11 Aug 2002 13:54:53 -  1.3
  +++ tomcat-users.xml  12 Sep 2002 06:44:25 -  1.4
  @@ -4,7 +4,7 @@
 you must define such a user - the username and password are arbitrary.
   --
   tomcat-users
  -  user name=tomcat password=tomcat roles=tomcat /
  +  user name=tomcat password=tomcat roles=tomcat,admin /
 user name=role1  password=tomcat roles=role1  /
 user name=both   password=tomcat roles=tomcat,role1 /
   /tomcat-users
  
  
  
  1.3   +4 -4  jakarta-tomcat-catalina/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/web.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- web.xml   23 Aug 2002 23:04:05 -  1.2
  +++ web.xml   12 Sep 2002 06:44:25 -  1.3
  @@ -226,7 +226,7 @@
 !--$CATALINA_HOME/server/lib/servlets-cgi.renametojar file   --
 !--to $CATALINA_HOME/server/lib/servlets-cgi.jar --
   
  -!--
  +
   servlet
   servlet-namecgi/servlet-name
   servlet-classorg.apache.catalina.servlets.CGIServlet/servlet-class
  @@ -244,7 +244,7 @@
   /init-param
load-on-startup5/load-on-startup
   /servlet
  ---
  +
   
   
 !--  Built In Servlet Mappings = --
  @@ -287,12 +287,12 @@
   --
   
   !-- The mapping for the CGI Gateway servlet --
  -!--
  +
   servlet-mapping
   servlet-namecgi/servlet-name
   url-pattern/cgi-bin/*/url-pattern
   /servlet-mapping
  ---
  +
   
   
 !--  Default Session Configuration = --
  
  
  
  1.2   +7 -4  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java
  
  Index: HTMLManagerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- HTMLManagerServlet.java   18 Jul 2002 16:47:40 -  1.1
  +++ HTMLManagerServlet.java   12 Sep 2002 06:44:25 -  1.2
  @@ -70,6 +70,7 @@
   import java.text.MessageFormat;
   import java.util.Date;
   import java.util.Iterator;
  +import java.util.Locale;
   import java.util.Map;
   import java.util.TreeMap;
   import javax.servlet.ServletException;
  @@ -127,6 +128,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/html);
  +Locale locale = Locale.getDefault();
  +response.setLocale(locale);
   PrintWriter writer = response.getWriter();
   
   // Process the requested command
  
  
  
  1.2   +9 -4  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java
  
  Index: ManagerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ManagerServlet.java   18 Jul 2002 16:47:41 -  1.1
  +++ ManagerServlet.java   12 Sep 2002 06:44:25 -  1.2
  @@ -74,6 +74,7 @@
   import java.net.URL;
   import java.util.Enumeration;
   import java.util.Iterator;
  +import java.util.Locale;
   import java.util.jar.JarEntry;
   import java.util.jar.JarFile;
   import javax.naming.Binding;
  @@ -330,6 +331,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/plain);
  +Locale locale = Locale.getDefault();
  +response.setLocale(locale);
   PrintWriter writer = response.getWriter();
   
   // Process the requested command (note - /deploy is not listed here)
  @@ -393,6 +396,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/plain);
  +Locale 

Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4CoyoteResponse.java

2002-09-12 Thread Amy Roh

Bill Barker wrote:
 - Original Message -
 From: [EMAIL PROTECTED]
 To: [EMAIL PROTECTED]
 Sent: Wednesday, September 11, 2002 10:48 PM
 Subject: cvs commit:
 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
 CoyoteResponse.java
 
 
 
amyroh  2002/09/11 22:48:19

  Modified:coyote/src/java/org/apache/coyote Response.java
   coyote/src/java/org/apache/coyote/tomcat4
CoyoteResponse.java
  Log:
  Fix for Response.setLocale() to set charset encoding correctly -
 
 bugzilla 10901.
 
  Patch submitted by OGAWA Kan [EMAIL PROTECTED].

  Revision  ChangesPath
  1.14  +79 -74
 
 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Response.java
 
  Index: Response.java

 
 
 It would be really nice if people could split tab-fix from code commits.
 :(
 
 Of course, it's not Amy's fault.  There shouldn't have been tabs in
 o.a.c.Response in the first place (It's under the 4.x coding specs).  I'm
 just whining here.

Yeah, I agree it's pretty ugly.  :-(  I just commited the fix.  :-)

Amy

 
 
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-catalina/catalina/src/conf tomcat-users.xml web.xml

2002-09-12 Thread amyroh

amyroh  2002/09/12 00:02:17

  Modified:catalina/src/conf tomcat-users.xml web.xml
  Log:
  Revert the mistake changes to conf files.  oops.
  
  Revision  ChangesPath
  1.5   +1 -1  jakarta-tomcat-catalina/catalina/src/conf/tomcat-users.xml
  
  Index: tomcat-users.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/tomcat-users.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- tomcat-users.xml  12 Sep 2002 06:44:25 -  1.4
  +++ tomcat-users.xml  12 Sep 2002 07:02:16 -  1.5
  @@ -4,7 +4,7 @@
 you must define such a user - the username and password are arbitrary.
   --
   tomcat-users
  -  user name=tomcat password=tomcat roles=tomcat,admin /
  +  user name=tomcat password=tomcat roles=tomcat /
 user name=role1  password=tomcat roles=role1  /
 user name=both   password=tomcat roles=tomcat,role1 /
   /tomcat-users
  
  
  
  1.4   +5 -4  jakarta-tomcat-catalina/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/web.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- web.xml   12 Sep 2002 06:44:25 -  1.3
  +++ web.xml   12 Sep 2002 07:02:16 -  1.4
  @@ -226,7 +226,7 @@
 !--$CATALINA_HOME/server/lib/servlets-cgi.renametojar file   --
 !--to $CATALINA_HOME/server/lib/servlets-cgi.jar --
   
  -
  +!--
   servlet
   servlet-namecgi/servlet-name
   servlet-classorg.apache.catalina.servlets.CGIServlet/servlet-class
  @@ -244,7 +244,7 @@
   /init-param
load-on-startup5/load-on-startup
   /servlet
  -
  +--
   
   
 !--  Built In Servlet Mappings = --
  @@ -287,12 +287,13 @@
   --
   
   !-- The mapping for the CGI Gateway servlet --
  -
  +
  +!--
   servlet-mapping
   servlet-namecgi/servlet-name
   url-pattern/cgi-bin/*/url-pattern
   /servlet-mapping
  -
  +--
   
   
 !--  Default Session Configuration = --
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets HTMLManagerServlet.java ManagerServlet.java

2002-09-12 Thread amyroh

amyroh  2002/09/12 00:07:28

  Modified:catalina/src/share/org/apache/catalina/servlets
HTMLManagerServlet.java ManagerServlet.java
  Log:
  Minor tab fixes.
  
  Revision  ChangesPath
  1.11  +6 -6  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java
  
  Index: HTMLManagerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- HTMLManagerServlet.java   10 Sep 2002 03:31:16 -  1.10
  +++ HTMLManagerServlet.java   12 Sep 2002 07:07:27 -  1.11
  @@ -128,8 +128,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/html);
  - Locale locale = Locale.getDefault();
  - response.setLocale(locale);
  +Locale locale = Locale.getDefault();
  +response.setLocale(locale);
   PrintWriter writer = response.getWriter();
   
   // Process the requested command
  
  
  
  1.27  +8 -8  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java
  
  Index: ManagerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/ManagerServlet.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- ManagerServlet.java   10 Sep 2002 03:31:16 -  1.26
  +++ ManagerServlet.java   12 Sep 2002 07:07:27 -  1.27
  @@ -331,8 +331,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/plain);
  - Locale locale = Locale.getDefault();
  - response.setLocale(locale);
  +Locale locale = Locale.getDefault();
  +response.setLocale(locale);
   PrintWriter writer = response.getWriter();
   
   // Process the requested command (note - /deploy is not listed here)
  @@ -396,8 +396,8 @@
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/plain);
  - Locale locale = Locale.getDefault();
  - response.setLocale(locale);
  +Locale locale = Locale.getDefault();
  +response.setLocale(locale);
   PrintWriter writer = response.getWriter();
   
   // Process the requested command
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk aphowto.xml

2002-09-12 Thread hgomez

hgomez  2002/09/12 00:53:09

  Modified:jk/xdocs/jk aphowto.xml
  Log:
  Updates provided by IBM fellow Walt Krapohl
  
  Revision  ChangesPath
  1.9   +28 -21jakarta-tomcat-connectors/jk/xdocs/jk/aphowto.xml
  
  Index: aphowto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk/aphowto.xml,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- aphowto.xml   10 Sep 2002 11:35:20 -  1.8
  +++ aphowto.xml   12 Sep 2002 07:53:09 -  1.9
  @@ -9,12 +9,12 @@
   section name=Introduction
   p
   This document explains how to connect Tomcat to the popular open source web server, 
Apache. 
  -There is actually to version of Apache, 1.3 and 2.0 and both could used mod_jk, the 
Tomcat redirector
  +There is actually two version of Apache, 1.3 and 2.0 and both can be used with 
mod_jk, the Tomcat redirector
   module.
   /p
   
   p
  -We recommand you to read also the a href=jk/workershowto.htmlWorkers HowTo/a 
document
  +It is recommanded that you also read the a href=jk/workershowto.htmlWorkers 
HowTo/a document
   to learn how to setup the working entities between your WebServer and Tomcat 
Engines.
   /p
   
  @@ -161,7 +161,7 @@
   /p
   
   p
  -For example JK 1.2.0 could be find a 
href=http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk/release/v1.2.0/bin/;
  +For example JK 1.2.0 can be found a 
href=http://jakarta.apache.org/builds/jakarta-tomcat-connectors/jk/release/v1.2.0/bin/;
   here/a and contains the following:
   /p
   
  @@ -287,7 +287,7 @@
   note# JkRequestLogFormat set the request format /note
   readJkRequestLogFormat %w %V %T/read
   note# Send servlet for context /examples to worker named worker1/note
  -readJkMout  /examples/servlet/* worker1/read
  +readJkMount  /examples/servlet/* worker1/read
   note# Send JSPs  for context /examples to worker named worker1/note
   readJkMount  /examples/*.jsp worker1/read
   /screen
  @@ -297,7 +297,7 @@
   
   section name=mod_jk Directives
   p
  -We'll discuss here about mod_jk directives and details them
  +We'll discuss here the mod_jk directives and details behind them
   /p
   
   subsection name=Define workers
  @@ -371,9 +371,9 @@
   Request logging is configured and enabled on a per virtual host basis. 
   To enable request logging for a virtual host just add a JkRequestLogFormat config. 
   The syntax of the format string is similiar to the Apache LogFormat command, 
  -here is a list of the avaialbe request log format options:
  +here is a list of the available request log format options:
   /p
  -
  +   
   p
   table
 trthOptions/ththDescription/th/tr
  @@ -618,7 +618,7 @@
   /subsection
   
   subsection name=Using configure to build mod_jk
  -pHere's how to use configure to prepare mod_jk building, just type: 
  +pHere's how to use configure to prepare mod_jk for building, just type: 
   source
   ./configure [autoconf arguments] [jakarta-tomcat-connectors arguments]
   /source
  @@ -793,14 +793,21 @@
   
   section name=Building mod_jk for Apache on iSeries/OS400
   p
  -Since OS400 V4R5, iSeries (AS/400) use Apache 2.0 as their primary web server, 
replacing the old IBM webserver.
  -It's now possible to build mod_jk on iSeries thanks to the help of IBM Rochester 
Labs who provided informations and patches
  -to adapt mod_jk to their Operating System.
  +Since OS400 V4R5, iSeries (AS/400) has used Apache 2.0 as their primary web server, 
  +replacing the old IBM webserver.
  +It's now possible to build mod_jk on iSeries thanks to the help of the IBM 
  +Rochester Labs which has provided information and patches
  +to adapt mod_jk to OS400.
  +/p
  +p
  +You should have at least Apache 2.0.39, a C Compiler and IFS.
  +Apache 2.0.39 is provided with the most recent set of PTFs for the iSeries Apache
  +server, which can be found at a 
href=http://www.ibm.com/servers/eserver/iseries/software/http/;
  +http://www.ibm.com/servers/eserver/iseries/software/http//a
   /p
  +
   p
  -You should have at least Apache 2.0.39 which is provided in recent PTFs, a C 
Compiler and IFS.
  -Since there's still no configure stuff on iSeries, you'll have to use the good 
command line or use a CL with is present 
  -in mod_jk source.
  +To configure mod_jk on iSeries use the CL source provided with the mod_jk source.
   /p
   ul
   li
  @@ -813,7 +820,7 @@
   Send the whole jk source directory to iSeries directory via FTP.
   /li
   li
  -Then go to iSeries command line :
  +Then go to the iSeries command line :
   /li
   /ul
   screen5250
  @@ -901,9 +908,9 @@
   typemake install/typebr/
   note Configure in the Apache sources: /note
   typecd /home/apache/apache_1.3.26/type
  -typeconfigure ... --enable-module=dir --disable-shared=dir \ /type
  -type  --activate-module=src/modules/jk/libjk.a \  /type
  -type  --disable-shared=jk/type
  

cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk domhowto.xml neshowto.xml iishowto.xml

2002-09-12 Thread hgomez

hgomez  2002/09/12 00:54:16

  Modified:jk/xdocs/jk domhowto.xml neshowto.xml iishowto.xml
  Log:
  Correct english sentences
  
  Revision  ChangesPath
  1.4   +1 -1  jakarta-tomcat-connectors/jk/xdocs/jk/domhowto.xml
  
  Index: domhowto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk/domhowto.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- domhowto.xml  10 Sep 2002 08:02:49 -  1.3
  +++ domhowto.xml  12 Sep 2002 07:54:16 -  1.4
  @@ -12,7 +12,7 @@
   /p
   
   p
  -We recommand you to read also the a href=jk/workershowto.htmlWorkers HowTo/a 
document
  +It is recommanded that you also read the a href=jk/workershowto.htmlWorkers 
HowTo/a document
   to learn how to setup the working entities between your WebServer and Tomcat 
Engines.
   /p
   
  
  
  
  1.4   +1 -1  jakarta-tomcat-connectors/jk/xdocs/jk/neshowto.xml
  
  Index: neshowto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk/neshowto.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- neshowto.xml  10 Sep 2002 08:02:49 -  1.3
  +++ neshowto.xml  12 Sep 2002 07:54:16 -  1.4
  @@ -18,7 +18,7 @@
   /p
   
   p
  -We recommand you to read also the a href=jk/workershowto.htmlWorkers HowTo/a 
document
  +It is recommanded that you also read the a href=jk/workershowto.htmlWorkers 
HowTo/a document
   to learn how to setup the working entities between your WebServer and Tomcat 
Engines.
   /p
   
  
  
  
  1.4   +1 -1  jakarta-tomcat-connectors/jk/xdocs/jk/iishowto.xml
  
  Index: iishowto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk/iishowto.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- iishowto.xml  10 Sep 2002 08:02:49 -  1.3
  +++ iishowto.xml  12 Sep 2002 07:54:16 -  1.4
  @@ -18,7 +18,7 @@
   /p
   
   p
  -We recommand you to read also the a href=jk/workershowto.htmlWorkers HowTo/a 
document
  +It is recommanded that you also read the a href=jk/workershowto.htmlWorkers 
HowTo/a document
   to learn how to setup the working entities between your WebServer and Tomcat 
Engines.
   /p
   
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




build errors

2002-09-12 Thread jean-frederic clere

Hi,

I am fighting with the build of TC 4.1:
+++
 [javac] Compiling 14 source files to 
/home/jakarta/jakarta-tomcat-4.1/jasper/build/shared/classes
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:388:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:398:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:413:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:1298:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()) {
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:1441:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()) {
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:1826:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (ctxt.getOptions().isPoolingEnabled()) {
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java:1841:
 
Method isPoolingEnabled() not found in interface org.apache.jasper.Options.
 [javac] if (gen.ctxt.getOptions().isPoolingEnabled()) {
 [javac]   ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java:452:
 
Method getTagLibraryInfo(java.lang.String) not found in class 
org.apache.jasper.compiler.TldLocationsCache.
 [javac] TagLibraryInfo tl=cache.getTagLibraryInfo( uri );
 [javac]  ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java:299:
 
No variable validating defined in class org.apache.jasper.xmlparser.ParserUtils.
 [javac] if( false.equals( validating )) ParserUtils.validating=false;
 [javac]  ^
 [javac] 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java:345: 
No variable validating defined in class org.apache.jasper.xmlparser.ParserUtils.
 [javac] org.apache.jasper.xmlparser.ParserUtils.validating=b;
 [javac]^
 [javac] Note: 
/home/jakarta/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
 
uses or overrides a deprecated API.  Recompile with -deprecation for details.
 [javac] 10 errors, 1 warning

BUILD FAILED
file:/home/jakarta/jakarta-tomcat-jasper/jasper2/build.xml:83: Compile failed; 
see the compiler error output for details.

Total time: 12 seconds
+++

I have checked out the jasper branch tomcat_4_branch.

Any ideas what I am doing wrong?

Cheers

Jean-frederic


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/support jk_apxs.m4

2002-09-12 Thread jfclere

jfclere 2002/09/12 03:33:45

  Modified:jk/support jk_apxs.m4
  Log:
  Prevent using --with-apxs2 with apache-1.3 and vice-versa(s).
  
  Revision  ChangesPath
  1.5   +7 -1  jakarta-tomcat-connectors/jk/support/jk_apxs.m4
  
  Index: jk_apxs.m4
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/support/jk_apxs.m4,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- jk_apxs.m416 Jun 2002 20:41:33 -  1.4
  +++ jk_apxs.m412 Sep 2002 10:33:45 -  1.5
  @@ -119,11 +119,17 @@
   
   dnl check if we have an apxs for Apache 1.3 or 2.0
   if ${TEST} -z $APA ; then
  +   if ${TEST} ! -z $1 ; then
  +AC_MSG_ERROR(Do not use --with-apxs$1 but --with-apxs)
  +   fi
 WEBSERVERS=${WEBSERVERS} server/apache13
 RWEBSERVER=apache-1.3
 APXS$1_CFLAGS=`${APXS$1} -q CFLAGS`
 APXS$1_CPPFLAGS=
   else
  +   if ${TEST} -z $1 ; then
  +AC_MSG_ERROR(Do not use --with-apxs but --with-apxs2)
  +   fi
 WEBSERVERS=${WEBSERVERS} server/apache2
 RWEBSERVER=apache-2.0
 APACHE2_CONFIG_VARS=${apache_dir}/build/config_vars.mk
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache13 mod_jk2.c

2002-09-12 Thread jfclere

jfclere 2002/09/12 03:43:37

  Modified:jk/native2/server/apache13 mod_jk2.c
  Log:
  Typo.
  
  Revision  ChangesPath
  1.19  +2 -2  jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.c
  
  Index: mod_jk2.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache13/mod_jk2.c,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- mod_jk2.c 15 Aug 2002 11:22:41 -  1.18
  +++ mod_jk2.c 12 Sep 2002 10:43:36 -  1.19
  @@ -438,7 +438,7 @@
   /* get_env() */
   env = workerEnv-globalEnv-getEnv( workerEnv-globalEnv );
   
  -uriEnv = workerEnv-uriMap-mapUri(env, workerEnv-uriMap,NULL,r-uri, );
  +uriEnv = workerEnv-uriMap-mapUri(env, workerEnv-uriMap,NULL,r-uri );
   
   if(uriEnv==NULL || uriEnv-workerName==NULL) {
   workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/support jk_apxs.m4

2002-09-12 Thread Henri Gomez

[EMAIL PROTECTED] wrote:
 jfclere 2002/09/12 03:33:45
 
   Modified:jk/support jk_apxs.m4
   Log:
   Prevent using --with-apxs2 with apache-1.3 and vice-versa(s).
   
   Revision  ChangesPath
   1.5   +7 -1  jakarta-tomcat-connectors/jk/support/jk_apxs.m4
   
   Index: jk_apxs.m4
   ===
   RCS file: /home/cvs/jakarta-tomcat-connectors/jk/support/jk_apxs.m4,v
   retrieving revision 1.4
   retrieving revision 1.5
   diff -u -r1.4 -r1.5
   --- jk_apxs.m4  16 Jun 2002 20:41:33 -  1.4
   +++ jk_apxs.m4  12 Sep 2002 10:33:45 -  1.5
   @@ -119,11 +119,17 @@

dnl check if we have an apxs for Apache 1.3 or 2.0
if ${TEST} -z $APA ; then
   + if ${TEST} ! -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs$1 but --with-apxs)
   + fi
  WEBSERVERS=${WEBSERVERS} server/apache13
  RWEBSERVER=apache-1.3
  APXS$1_CFLAGS=`${APXS$1} -q CFLAGS`
  APXS$1_CPPFLAGS=
else
   + if ${TEST} -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs but --with-apxs2)
   + fi
  WEBSERVERS=${WEBSERVERS} server/apache2
  RWEBSERVER=apache-2.0
  APACHE2_CONFIG_VARS=${apache_dir}/build/config_vars.mk
   

Are you sure ?

The goal was to set configure to be able to generate stuff for APXS
and APXS2 the same time, to help build apache and apache2 on a single pass


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/support jk_apxs.m4

2002-09-12 Thread jean-frederic clere

Henri Gomez wrote:
 [EMAIL PROTECTED] wrote:
 
 jfclere 2002/09/12 03:33:45

   Modified:jk/support jk_apxs.m4
   Log:
   Prevent using --with-apxs2 with apache-1.3 and vice-versa(s).
 Revision  ChangesPath
   1.5   +7 -1  jakarta-tomcat-connectors/jk/support/jk_apxs.m4
 Index: jk_apxs.m4
   ===
   RCS file: /home/cvs/jakarta-tomcat-connectors/jk/support/jk_apxs.m4,v
   retrieving revision 1.4
   retrieving revision 1.5
   diff -u -r1.4 -r1.5
   --- jk_apxs.m416 Jun 2002 20:41:33 -1.4
   +++ jk_apxs.m412 Sep 2002 10:33:45 -1.5
   @@ -119,11 +119,17 @@
   dnl check if we have an apxs for Apache 1.3 or 2.0
if ${TEST} -z $APA ; then
   +  if ${TEST} ! -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs$1 but --with-apxs)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache13
  RWEBSERVER=apache-1.3
  APXS$1_CFLAGS=`${APXS$1} -q CFLAGS`
  APXS$1_CPPFLAGS=
else
   +  if ${TEST} -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs but --with-apxs2)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache2
  RWEBSERVER=apache-2.0
  APACHE2_CONFIG_VARS=${apache_dir}/build/config_vars.mk
   
 
 
 Are you sure ?
 
 The goal was to set configure to be able to generate stuff for APXS
 and APXS2 the same time, to help build apache and apache2 on a single pass

Yes, but we should not allow to configure using --with-apxs when Apache is 2.0 
or we should do like in native: --with-apxs works for both 1.3 and 2.0.

The fastest work-around is to make sure the --with-apxs and with-apxs2 are use 
only with their  respective Apache version. And that what I am doing.

 
 
 -- 
 To unsubscribe, e-mail:   
 mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: 
 mailto:[EMAIL PROTECTED]
 
 




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12550] - webapps/MYWEBAPP/WEB-INF/lib not loading jars

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12550

webapps/MYWEBAPP/WEB-INF/lib not loading jars





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 10:57 ---
Both here in bugzilla and on tomcat-user we get alot of these problem reports.
Why don't we put a README file in /temp which states this directory is a temp
directory required by the JVM.  That way this directory will always get
created when the distribution is unarchived.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




problem with nested (struts) iterate tags with Tomcat 4.1.10

2002-09-12 Thread Martin Wilson

Hi,

I think this is a defect in Tomcat 4.1.10. Does anyone agree?

I have recently installed Tomcat 4.1.10, having previously used Tomcat
4.0.4. We're using Struts 1.0.2.
Some of our jsp pages give the following error:

Generated servlet error:
[javac] Compiling 1 source file
D:\jakarta\jakarta-tomcat-latest\work\Standalone\localhost\collection\jsp\al
l_exhibitions_jsp.java:459: _jspx_exhibition_in_type_1 is already defined in
_jspService(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpSer
vletResponse)
  java.lang.Object _jspx_exhibition_in_type_1 =
exhibition_in_type;

The problem appears to be whenever struts-logic:iterate tags are nested.
In the servlet generated from the jsp pages I can see the problem: the
variable used to refer to the current object in the iteration is defined at
the top of the _jspService method, and at the start of the iterate block.
Is this a known issue with 4.1.10? It doesn't happen with 4.1.9.

If anyone knows a fix for this (other than use an earlier version of
Tomcat), or if it a known defect that will be fixed in subsequent releases
please email me directly.

Thanks,
Martin.


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/support jk_apxs.m4

2002-09-12 Thread Henri Gomez

jean-frederic clere wrote:
 Henri Gomez wrote:
 
 [EMAIL PROTECTED] wrote:

 jfclere 2002/09/12 03:33:45

   Modified:jk/support jk_apxs.m4
   Log:
   Prevent using --with-apxs2 with apache-1.3 and vice-versa(s).
 Revision  ChangesPath
   1.5   +7 -1  jakarta-tomcat-connectors/jk/support/jk_apxs.m4
 Index: jk_apxs.m4
   ===
   RCS file: /home/cvs/jakarta-tomcat-connectors/jk/support/jk_apxs.m4,v
   retrieving revision 1.4
   retrieving revision 1.5
   diff -u -r1.4 -r1.5
   --- jk_apxs.m416 Jun 2002 20:41:33 -1.4
   +++ jk_apxs.m412 Sep 2002 10:33:45 -1.5
   @@ -119,11 +119,17 @@
   dnl check if we have an apxs for Apache 1.3 or 2.0
if ${TEST} -z $APA ; then
   +  if ${TEST} ! -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs$1 but 
 --with-apxs)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache13
  RWEBSERVER=apache-1.3
  APXS$1_CFLAGS=`${APXS$1} -q CFLAGS`
  APXS$1_CPPFLAGS=
else
   +  if ${TEST} -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs but --with-apxs2)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache2
  RWEBSERVER=apache-2.0
  APACHE2_CONFIG_VARS=${apache_dir}/build/config_vars.mk
   



 Are you sure ?

 The goal was to set configure to be able to generate stuff for APXS
 and APXS2 the same time, to help build apache and apache2 on a single 
 pass
 
 
 Yes, but we should not allow to configure using --with-apxs when Apache 
 is 2.0 or we should do like in native: --with-apxs works for both 1.3 
 and 2.0.

 The fastest work-around is to make sure the --with-apxs and with-apxs2 
 are use only with their  respective Apache version. And that what I am 
 doing.

So we could still use --with-apxs and --with-apxs2 on the same command 
line ?



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 installhowto.xml configweb.xml

2002-09-12 Thread jfclere

jfclere 2002/09/12 05:39:12

  Modified:jk/xdocs/jk2 configweb.xml
  Added:   jk/xdocs/jk2 installhowto.xml
  Log:
  Start to describe the installation of mod_jk2.
  
  Revision  ChangesPath
  1.2   +0 -5  jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml
  
  Index: configweb.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- configweb.xml 29 Aug 2002 11:04:34 -  1.1
  +++ configweb.xml 12 Sep 2002 12:39:12 -  1.2
  @@ -15,11 +15,6 @@
 where ${serverRoot} is something like /opt/apache.
   /p
   /section
  -section name=Installation
  -subsection name=Apache 1/
  -subsection name=Apache 2/
  -subsection name=IIS/
  -/section
   section name=Config file
   p The default config file is user editable, but mod_jk will persist the 
   changes requested by protocol( not implemented). If you manually change the file 
while jk2 is 
  
  
  
  1.1  jakarta-tomcat-connectors/jk/xdocs/jk2/installhowto.xml
  
  Index: installhowto.xml
  ===
  ?xml version=1.0?
  document
properties
  titleInstallation of mod_jk2 in the Web Server/title
  author email=[EMAIL PROTECTED]Jean-Frederic Clere/author
/properties
section name=Installation
  p
The actual build mechanism creates the dso files in the
build/jk2/${servername} subdirectory of the jakarta-tomcat-connectors/jk.
When configure --with-jni is used 2 dso files are created.
These files have to be copied in the right location of the web server
installation.
  /p
  subsection name=Apache 1/
  subsection name=Apache 2
p
  In the following example Apache-2.0 is installed in
  /home/apache20/apache40 and the commands are excuted in
  the jakarta-tomcat-connectors directory.
/p
screen
  noteCopy the dso files in the modules location:/note
  typecp jk/build/jk2/apache2/mod_jk2.so 
/home/apache20/apache40/modules/type
  typecp jk/build/jk2/apache2/jkjni.so /home/apache20/apache40/modules/type
  noteAdd mod_jk2 loading in the httpd.conf:/note
  readLoadModule jk2_module modules/mod_jk2.so/read
/screen
  /subsection
  subsection name=IIS/
/section
  /document
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/support jk_apxs.m4

2002-09-12 Thread jean-frederic clere

Henri Gomez wrote:
 jean-frederic clere wrote:
 
 Henri Gomez wrote:

 [EMAIL PROTECTED] wrote:

 jfclere 2002/09/12 03:33:45

   Modified:jk/support jk_apxs.m4
   Log:
   Prevent using --with-apxs2 with apache-1.3 and vice-versa(s).
 Revision  ChangesPath
   1.5   +7 -1  jakarta-tomcat-connectors/jk/support/jk_apxs.m4
 Index: jk_apxs.m4
   ===
   RCS file: /home/cvs/jakarta-tomcat-connectors/jk/support/jk_apxs.m4,v
   retrieving revision 1.4
   retrieving revision 1.5
   diff -u -r1.4 -r1.5
   --- jk_apxs.m416 Jun 2002 20:41:33 -1.4
   +++ jk_apxs.m412 Sep 2002 10:33:45 -1.5
   @@ -119,11 +119,17 @@
   dnl check if we have an apxs for Apache 1.3 or 2.0
if ${TEST} -z $APA ; then
   +  if ${TEST} ! -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs$1 but 
 --with-apxs)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache13
  RWEBSERVER=apache-1.3
  APXS$1_CFLAGS=`${APXS$1} -q CFLAGS`
  APXS$1_CPPFLAGS=
else
   +  if ${TEST} -z $1 ; then
   +AC_MSG_ERROR(Do not use --with-apxs but 
 --with-apxs2)
   +  fi
  WEBSERVERS=${WEBSERVERS} server/apache2
  RWEBSERVER=apache-2.0
  APACHE2_CONFIG_VARS=${apache_dir}/build/config_vars.mk
   




 Are you sure ?

 The goal was to set configure to be able to generate stuff for APXS
 and APXS2 the same time, to help build apache and apache2 on a single 
 pass



 Yes, but we should not allow to configure using --with-apxs when 
 Apache is 2.0 or we should do like in native: --with-apxs works for 
 both 1.3 and 2.0.
 
 
 The fastest work-around is to make sure the --with-apxs and 
 with-apxs2 are use only with their  respective Apache version. And 
 that what I am doing.
 
 
 So we could still use --with-apxs and --with-apxs2 on the same command 
 line ?

Of course ;-)

 
 
 
 -- 
 To unsubscribe, e-mail:   
 mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: 
 mailto:[EMAIL PROTECTED]
 
 




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configweb.xml

2002-09-12 Thread jfclere

jfclere 2002/09/12 05:59:33

  Modified:jk/xdocs/jk2 configweb.xml
  Log:
  Add a line to list the possible worker types.
  
  Revision  ChangesPath
  1.3   +3 -0  jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml
  
  Index: configweb.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- configweb.xml 12 Sep 2002 12:39:12 -  1.2
  +++ configweb.xml 12 Sep 2002 12:59:33 -  1.3
  @@ -259,6 +259,9 @@
   /subsection
   /subsection
   subsection name=workers
  +p
  + For the moment 4 worker types are supported: jni,ajp13,status,lb.
  +/p
   subsection name=jni
   pworker used in inprocess, holds the details of the Tomcat class 
to startup, and paramters to pass/p
   p
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configweb.xml

2002-09-12 Thread jean-frederic clere

What about creating style(s) for the nested subsections?
This document is not very readable for the moment and I am looking for ideas to 
improve it.

[EMAIL PROTECTED] wrote:
 jfclere 2002/09/12 05:59:33
 
   Modified:jk/xdocs/jk2 configweb.xml
   Log:
   Add a line to list the possible worker types.
   
   Revision  ChangesPath
   1.3   +3 -0  jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml
   
   Index: configweb.xml
   ===
   RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml,v
   retrieving revision 1.2
   retrieving revision 1.3
   diff -u -r1.2 -r1.3
   --- configweb.xml   12 Sep 2002 12:39:12 -  1.2
   +++ configweb.xml   12 Sep 2002 12:59:33 -  1.3
   @@ -259,6 +259,9 @@
/subsection
/subsection
subsection name=workers
   +p
   + For the moment 4 worker types are supported: jni,ajp13,status,lb.
   +/p
subsection name=jni
pworker used in inprocess, holds the details of the Tomcat 
class to startup, and paramters to pass/p
p
   
   
   
 
 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]
 
 




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configweb.xml

2002-09-12 Thread Henri Gomez

jean-frederic clere wrote:
 What about creating style(s) for the nested subsections?
 This document is not very readable for the moment and I am looking for 
 ideas to improve it.

It seems fine to me.




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12559] - setLocale gives wrong content type

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12559.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12559

setLocale gives wrong content type





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 14:01 ---
Hi, James.

If you use my patch for Bug 10901, is Bug 12559 solved ???
( Bug 10901 is different from this bug. )

When customizing the patch for Bug 10901,
I encountered the same phenomenon as this bug you reported.
However, I didn't detect that bug at this time.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/resources LocalStrings_fr.properties

2002-09-12 Thread hgomez

hgomez  2002/09/12 07:27:16

  Modified:src/share/org/apache/tomcat/resources
LocalStrings_fr.properties
  Log:
  Correct typo
  
  Revision  ChangesPath
  1.5   +2 -2  
jakarta-tomcat/src/share/org/apache/tomcat/resources/LocalStrings_fr.properties
  
  Index: LocalStrings_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/resources/LocalStrings_fr.properties,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- LocalStrings_fr.properties3 Nov 2001 03:50:50 -   1.4
  +++ LocalStrings_fr.properties12 Sep 2002 14:27:16 -  1.5
  @@ -15,7 +15,7 @@
   defaulterrorpage.includedservlet=Erreur de Servlet incluse:
   defaulterrorpage.location=Location:
   defaulterrorpage.errorlocation=Erreur de Location:
  -defaulterrorpage.notfound404=Introuvabble(404)
  +defaulterrorpage.notfound404=Introuvable(404)
   defaulterrorpage.rootcause=Raison principale:
   defaulterrorpage.documentmoved=Le document a été déplacé
   defaulterrorpage.thisdocumenthasmoved=Ce document a été déplacé
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/jasper/resources messages_fr.properties

2002-09-12 Thread hgomez

hgomez  2002/09/12 07:32:52

  Modified:src/share/org/apache/jasper/resources messages_fr.properties
  Log:
  Add missing fr translations
  
  Revision  ChangesPath
  1.6   +4 -1  
jakarta-tomcat/src/share/org/apache/jasper/resources/messages_fr.properties
  
  Index: messages_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/resources/messages_fr.properties,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- messages_fr.properties30 Nov 2001 22:20:07 -  1.5
  +++ messages_fr.properties12 Sep 2002 14:32:52 -  1.6
  @@ -208,3 +208,6 @@
   jspc.error.emptyWebApp=-webapp nécessite un argument suivant de type fichier
   jsp.error.no.more.content=Fin de contenu atteinte alors que plus d''analyse est 
nécessaire: Un tag non terminé ou une erreur de tag imbriqué?
   jsp.error.unterminated.user.tag=Tag utilisateur non terminé: Le tag de fermeture 
{0} est introuvable ou incorrectement imbriqué
  +jsp.error.invalid.javaEncoding=Encodage java invalide. Les essais avec {0} puis 
avec {1} ont échoués.
  +jsp.error.needAlternateJavaEncoding=L'encodage java par défaut {0} n'est pas valide 
sur votre environnement java. Une alternative peut être spécifiée via le paramêtre 
'javaEncoding' de JspServlet.
  +jsp.error.badcount=Erreur Interne.  Tentative de décrément du compteur de reference 
sur une JSP non référencéess.
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12578] New: - JSP forward not working OK from JSP include

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578

JSP forward not working OK from JSP include

   Summary: JSP forward not working OK from JSP include
   Product: Tomcat 4
   Version: 4.0.4 Final
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


My main JSP file include other JSP files, some of them are simply forward to
the real context page (also a JSP file). It looks that if page a does
jsp:include to page b, which will use jsp:forward to different page c,
then the output of c will replace the output of a.

It looks as if a forwarded in an included page will cause the main page to
be replaced by the forMy structure looks like:

Main file a.jsp

h1 BEGIN /h1
jsp:include page=a1.jsp /
jsp:include page=a2.jsp /
jsp:include page=a3.jsp /
/h1 END /h1

The small files a1.jsp, a2.jsp, a3.jsp contain:
a1.jsp: jsp:forward page=a1x.jsp /
a2.jsp: jsp:forward page=a2x.jsp /
a3.jsp: jsp:forward page=a3x.jsp /

The files a1x.jsp, a2x.jsp, a3x.jsp contain:
a1x.jsp: h1 a1x /h1
a2x.jsp: h1 a2x /h1
a3x.jsp: h1 a3x /h1

The pages are placed into the ROOT context of a default TOMCAT install. When the
page is fetched I was expecting:
BEGIN
a1x
a2x
a3x
END

Instead, I'm only seeing:
a1x


It looks as if the page:forward in a1.jsp, cause the whole request to be
forwarded to a1x.jsp. Instead of just forwarding the a1.jsp request to
a1x.jsp, it behave as if the forward request was issues from a.jsp.

I checked the code with Jrun - and it behaves the way I expect it to be. I'm not
if the specification are clean about this behavior, but this behavior is wrong.
It will cause a JSP page to behave differently if any included page is using the
jsp:forward directive.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12578] - JSP forward not working OK from JSP include

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578

JSP forward not working OK from JSP include

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 15:30 ---
See section 8.4 of the Servlet 2.3 spec:
If output data exists in the response buffer that has not been committed, the
content must cleared before the target servlet’s service method is called. 

and

Before the forward method of the RequestDispatcher interface returns, the
response must be committed and closed by the servlet container.

This means when a jsp:forward is performed - the existing output buffer is
cleared. Then after a jsp:foward is performed, the response is closed. Any other
code on that JSP will not be able to write to the response.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12503] - default servlet overrides welcome file

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12503

default servlet overrides welcome file





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 15:33 ---
It would seem to me, if you explicity map all requests to a servlet - then you
would expect all requests to go to the servlet.  Finding that some are sent to
welcome files would be surprising.

for example, suppose I access URL, /servlet/bank/customer, tomcat would have
to check for one or more welcome files before passing the request to the bank
servlet.  I think that would be annoying.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configweb.xml

2002-09-12 Thread mturk

mturk   2002/09/12 09:15:25

  Modified:jk/xdocs/jk2 configweb.xml
  Log:
  added a 'reverse' uri decription.
  Please do a syntax and grammar check.
  
  Revision  ChangesPath
  1.4   +7 -0  jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml
  
  Index: configweb.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/jk2/configweb.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- configweb.xml 12 Sep 2002 12:59:33 -  1.3
  +++ configweb.xml 12 Sep 2002 16:15:25 -  1.4
  @@ -149,6 +149,13 @@
   td/
   tdthe context that will be served by this uri component 
(webapp style)/td
   /tr
  +tr
  +tdreverse/td
  +td0/td
  +tdIf set to 1 all satisfied matches will be rejected.
  +This is usefull for the situations when you wish to map the entire application, but 
still wish that
  +paticular context is not served through Tomcat./td
  +/tr
   /table
   /p
   /subsection
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12578] - JSP forward not working OK from JSP include

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12578

JSP forward not working OK from JSP include





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 16:20 ---
I believe that the question is WHICH output buffer should be cleared. If page
A does jsp:include to page B, and page B does jsp:forward to page C.
Should the output buffer for page A or page B should be cleared ?

Assuming that the standard does not address this issue, I think that
interpretation that emphasize reusable pages will prefer to prevent page B,
from having side effect on page A.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-connectors/jk/native/common jk_jni_worker.c

2002-09-12 Thread hgomez

hgomez  2002/09/12 09:29:19

  Modified:jk/native/common jk_jni_worker.c
  Log:
  OS400 JNI need strings to be converted from EBCDIC to ASCII
  
  Revision  ChangesPath
  1.14  +46 -1 jakarta-tomcat-connectors/jk/native/common/jk_jni_worker.c
  
  Index: jk_jni_worker.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_jni_worker.c,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- jk_jni_worker.c   4 Sep 2002 11:41:20 -   1.13
  +++ jk_jni_worker.c   12 Sep 2002 16:29:19 -  1.14
  @@ -1045,7 +1045,18 @@
   jk_log(l, JK_LOG_DEBUG, 
  Into get_bridge_object\n);
   
  +/* OS400 need conversion from EBCDIC to ASCII before passing to JNI*/
  +
  +#ifdef AS400
  +#pragma convert(819)
  +#endif
  +
   p-jk_java_bridge_class = (*env)-FindClass(env, JAVA_BRIDGE_CLASS_NAME);
  +
  +#ifdef AS400
  +#pragma convert(0)
  +#endif
  +
   if(!p-jk_java_bridge_class) {
jk_log(l, JK_LOG_EMERG, Can't find class %s\n, JAVA_BRIDGE_CLASS_NAME);
return JK_FALSE;
  @@ -1053,10 +1064,18 @@
   jk_log(l, JK_LOG_DEBUG, 
  In get_bridge_object, loaded %s bridge class\n, 
JAVA_BRIDGE_CLASS_NAME);
   
  +#ifdef AS400
  +#pragma convert(819)
  +#endif
  +
   constructor_method_id = (*env)-GetMethodID(env,
   p-jk_java_bridge_class,
   init, /* method name */
   ()V);   /* method sign */
  +#ifdef AS400
  +#pragma convert(0)
  +#endif
  +
   if(!constructor_method_id) {
p-jk_java_bridge_class = NULL;
jk_log(l, JK_LOG_EMERG, 
  @@ -1091,28 +1110,54 @@
 JNIEnv *env,
 jk_logger_t *l)
   {
  +
  +#ifdef AS400
  +#pragma convert(819)
  +#endif
  +
   p-jk_startup_method = (*env)-GetMethodID(env,
  p-jk_java_bridge_class, 
  startup, 
  
(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)I);  
  +
  +#ifdef AS400
  +#pragma convert(0)
  +#endif
  +
   if(!p-jk_startup_method) {
jk_log(l, JK_LOG_EMERG, Can't find startup()\n); 
return JK_FALSE;
   }
   
  +#ifdef AS400
  +#pragma convert(819)
  +#endif
  +
   p-jk_service_method = (*env)-GetMethodID(env,
  p-jk_java_bridge_class, 
  service, 
  (JJ)I);   
  +#ifdef AS400
  +#pragma convert(0)
  +#endif
  +
   if(!p-jk_service_method) {
jk_log(l, JK_LOG_EMERG, Can't find service()\n); 
   return JK_FALSE;
   }
   
  +#ifdef AS400
  +#pragma convert(819)
  +#endif
  +
   p-jk_shutdown_method = (*env)-GetMethodID(env,
   p-jk_java_bridge_class, 
   shutdown, 
   ()V);   
  +#ifdef AS400
  +#pragma convert(0)
  +#endif
  +
   if(!p-jk_shutdown_method) {
jk_log(l, JK_LOG_EMERG, Can't find shutdown()\n); 
   return JK_FALSE;
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




4.1.10 tarball is borked.

2002-09-12 Thread Pier Fumagalli

Whoever packaged the tar gzip distribution didn't check that it was actually
_packaged_ properly...

I get a few gazillion broken files (noticeably with some beautiful
././@LongLink entries), and with all file names longer than 100 or
something characters foobared up... (like:
jakarta-tomcat-4.1.10/webapps/tomcat-docs/servletapi/javax/servlet/ServletCo
ntextAttributeEvent.html100644)

Plus, at the end, I s

tar: Invalid header, starting valid header search.
tar: End of archive volume 1 reached

And thank god that this is supposed to be a _release_ release... (of course
no errors in the .zip distribution, remember that WinZip doesn't friggin
built correct TAR archives)...

Pier


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: 4.1.10 tarball is borked.

2002-09-12 Thread Craig R. McClanahan



On Thu, 12 Sep 2002, Pier Fumagalli wrote:

 Date: Thu, 12 Sep 2002 19:27:31 +0100
 From: Pier Fumagalli [EMAIL PROTECTED]
 Reply-To: Tomcat Developers List [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Subject: 4.1.10 tarball is borked.

 Whoever packaged the tar gzip distribution didn't check that it was actually
 _packaged_ properly...


Which file did you try?  I just downloaded jakarta-tomcat-4.1.10.tar.gz
(dated 30-Aug-2002 06:38) and it worked fine on RedHat 7.2.  You're not
trying to use Solaris tar by any chance?  :-)

Craig


 I get a few gazillion broken files (noticeably with some beautiful
 ././@LongLink entries), and with all file names longer than 100 or
 something characters foobared up... (like:
 jakarta-tomcat-4.1.10/webapps/tomcat-docs/servletapi/javax/servlet/ServletCo
 ntextAttributeEvent.html100644)

 Plus, at the end, I s

 tar: Invalid header, starting valid header search.
 tar: End of archive volume 1 reached

 And thank god that this is supposed to be a _release_ release... (of course
 no errors in the .zip distribution, remember that WinZip doesn't friggin
 built correct TAR archives)...

 Pier


 --
 To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
 For additional commands, e-mail: mailto:[EMAIL PROTECTED]




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: 4.1.10 tarball is borked.

2002-09-12 Thread Pier Fumagalli

Craig R. McClanahan [EMAIL PROTECTED] wrote:
 On Thu, 12 Sep 2002, Pier Fumagalli wrote:
 
 Date: Thu, 12 Sep 2002 19:27:31 +0100
 From: Pier Fumagalli [EMAIL PROTECTED]
 Reply-To: Tomcat Developers List [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Subject: 4.1.10 tarball is borked.
 
 Whoever packaged the tar gzip distribution didn't check that it was actually
 _packaged_ properly...
 
 
 Which file did you try?  I just downloaded jakarta-tomcat-4.1.10.tar.gz
 (dated 30-Aug-2002 06:38) and it worked fine on RedHat 7.2.  You're not
 trying to use Solaris tar by any chance?  :-)

No


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: 4.1.10 tarball is borked.

2002-09-12 Thread Pier Fumagalli

Pier Fumagalli [EMAIL PROTECTED] wrote:

 Craig R. McClanahan [EMAIL PROTECTED] wrote:
 On Thu, 12 Sep 2002, Pier Fumagalli wrote:
 
 Date: Thu, 12 Sep 2002 19:27:31 +0100
 From: Pier Fumagalli [EMAIL PROTECTED]
 Reply-To: Tomcat Developers List [EMAIL PROTECTED]
 To: Tomcat Developers List [EMAIL PROTECTED]
 Subject: 4.1.10 tarball is borked.
 
 Whoever packaged the tar gzip distribution didn't check that it was actually
 _packaged_ properly...
 
 
 Which file did you try?  I just downloaded jakarta-tomcat-4.1.10.tar.gz
 (dated 30-Aug-2002 06:38) and it worked fine on RedHat 7.2.  You're not
 trying to use Solaris tar by any chance?  :-)
 
 No

Hit return too fast... Doesn't look good with BSD tar (NetBSD and MacOS/X)
at all... Older distributions worked fine... Maybe someone changed the way
in which the tarballs are built? GNU tar works.

Pier


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12590] New: - Unable to nest jsp:attribute within jsp:body if used with jsp:include

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12590.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12590

Unable to nest jsp:attribute within jsp:body if used with jsp:include

   Summary: Unable to nest jsp:attribute within jsp:body if used
with jsp:include
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


A test case like:

jsp:include 
   jsp:attribute name=page
 foo.jsp
/jsp:attribute
jsp:body
   jsp:param
  jsp:attribute name=name 

 
/jsp:include

Throws a error :

org.apache.jasper.JasperException: /jsp2/jspattrpos/param-in-param.jsp(13,15)
Not allowed in a template text body.
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:95)
at 
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:440)
at 
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:126)
at 
org.apache.jasper.compiler.Parser.parseElementsTemplateText(Parser.java:1524)
at org.apache.jasper.compiler.Parser.parseBody(Parser.java:1642)
at org.apache.jasper.compiler.Parser.parseNamedAttributes(Parser.java:1688)
at org.apache.jasper.compiler.Parser.parseEmptyBody(Parser.java:904)
at org.apache.jasper.compiler.Parser.parseParam(Parser.java:792)
at org.apache.jasper.compiler.Parser.parseBody(Parser.java:1639)
at org.apache.jasper.compiler.Parser.parseJspBody(Parser.java:1574)
at org.apache.jasper.compiler.Parser.parseJspAttributeAndBody(Parser.java:1016)
at org.apache.jasper.compiler.Parser.parseOptionalBody(Parser.java:981)
at org.apache.jasper.compiler.Parser.parseInclude(Parser.java:821)
at org.apache.jasper.compiler.Parser.parseAction(Parser.java:1140)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1420)
at org.apache.jasper.compiler.Parser.parse(Parser.java:159)
at 
org.apache.jasper.compiler.ParserController.parseFile(ParserController.java:245)
at org.apache.jasper.compiler.ParserController.parse(ParserController.java:169)
at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:259)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:409)
at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:570)
at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:295)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:289)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:240)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:271)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2505)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at
org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:170)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:171)
at
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at 

DO NOT REPLY [Bug 12591] New: - Variable declared with scope=AT_END available within the body of a simple tag

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12591.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12591

Variable declared with scope=AT_END available within the body of a simple tag

   Summary: Variable declared with scope=AT_END available within
the body of a simple tag
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


If a Simple Tag creates a variables via the TLD /TagExTraInfo Class with a scope
of AT_END, then the variable is accessible within the body of the tag.

test case:
/jsp20-tests/jsp2/simpletagpos/STVarAtEndPo.jsp

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12594] New: - If a SKIP_PAGE is returned from a classic tag nested within a Simple Tag , the page following the simple tag is displayed

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12594.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12594

If a SKIP_PAGE is returned from a classic tag nested within a Simple Tag , the page 
following the simple tag is displayed

   Summary: If a SKIP_PAGE is returned from a classic tag nested
within a Simple Tag , the page following the simple tag
is displayed
   Product: Tomcat 5
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Lets take this case :
st:simpletag att=val1 
   ct:tagex att2=val2
  I return a SKIP_PAGE 
/st:tagex
 Template text 
/st:simpletag
   This is the text after the simple tag

In such a case where ct:tagex returns a SKIP_PAGE in the doEndTag the text after
the end tag of the simple tag handler is displayed.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper gump3.xml

2002-09-12 Thread bobh

bobh2002/09/12 13:39:58

  Modified:.gump3.xml
  Log:
  - We only need to export the jar that comes with jasper... jasper is
  actually compiled when tc5 is compiled. so the other jars arent exported
  via this project
  
  Revision  ChangesPath
  1.3   +1 -3  jakarta-tomcat-jasper/gump3.xml
  
  Index: gump3.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-jasper/gump3.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- gump3.xml 11 Sep 2002 21:14:12 -  1.2
  +++ gump3.xml 12 Sep 2002 20:39:58 -  1.3
  @@ -11,9 +11,7 @@
 cvs repository=jakarta module=jakarta-tomcat-jasper/
 project name=jakarta-tomcat-jasper_tc5
 home nested=jasper2 /
  -  jar name=build/shared/lib/jasper-compiler.jar /
  -  jar name=build/shared/lib/jasper-runtime.jar /
  -  jar name=build/shared/lib/jsp20el.jar /
  +  jar name=lib/jsp20el.jar /
 /project
   
 depend project=commons-logging/
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi SSIServlet.java

2002-09-12 Thread amyroh

amyroh  2002/09/12 13:40:37

  Modified:catalina/src/share/org/apache/catalina/core
StandardContextValve.java
   catalina/src/share/org/apache/catalina/ssi SSIServlet.java
  Log:
  Change back to return 404 since the spec will be changed to require 404
  for WEB-INF and META-INF directories.
  
  Revision  ChangesPath
  1.3   +5 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextValve.java
  
  Index: StandardContextValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContextValve.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- StandardContextValve.java 12 Sep 2002 00:37:56 -  1.2
  +++ StandardContextValve.java 12 Sep 2002 20:40:37 -  1.3
  @@ -165,7 +165,7 @@
   relativeURI.equals(/WEB-INF) ||
   relativeURI.startsWith(/META-INF/) ||
   relativeURI.startsWith(/WEB-INF/)) {
  -forbidden(requestURI, (HttpServletResponse) response.getResponse());
  +notFound(requestURI, (HttpServletResponse) response.getResponse());
   return;
   }
   
  
  
  
  1.3   +24 -22
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServlet.java
  
  Index: SSIServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/ssi/SSIServlet.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- SSIServlet.java   12 Sep 2002 00:37:56 -  1.2
  +++ SSIServlet.java   12 Sep 2002 20:40:37 -  1.3
  @@ -216,15 +216,15 @@
path.toUpperCase().startsWith(/WEB-INF) ||
path.toUpperCase().startsWith(/META-INF) ) {
   
  -res.sendError(res.SC_FORBIDDEN, path);
  -log( Can't serve file:  + path );
  +res.sendError(res.SC_NOT_FOUND  , path);
  +log( Can't serve file:  + path );
   return;
   }
   
  -URL resource = servletContext.getResource(path);
  +URL resource = servletContext.getResource(path);
   if (resource==null) {
   res.sendError(res.SC_NOT_FOUND, path);
  -log( Can't find file:  + path );
  +log( Can't find file:  + path );
   return;
   }
   
  @@ -235,36 +235,38 @@
   new java.util.Date()).getTime() + expires.longValue() * 1000);
   }
   
  -processSSI( req, res, resource );
  +processSSI( req, res, resource );
   }
   
   protected void processSSI( HttpServletRequest req,
  HttpServletResponse res,
  URL resource ) throws IOException {
  -SSIExternalResolver ssiExternalResolver = new SSIServletExternalResolver( this, 
req, res,
  -  isVirtualWebappRelative,
  -  debug );
  -SSIProcessor ssiProcessor = new SSIProcessor( ssiExternalResolver, debug );
  +   
  +SSIExternalResolver ssiExternalResolver = 
  +new SSIServletExternalResolver( this, req, res,
  +isVirtualWebappRelative,
  +debug );
  +SSIProcessor ssiProcessor = new SSIProcessor( ssiExternalResolver, debug );
   
   PrintWriter printWriter = null;
  -StringWriter stringWriter = null;
  +StringWriter stringWriter = null;
   if (buffered) {
  -stringWriter = new StringWriter();
  +stringWriter = new StringWriter();
   printWriter = new PrintWriter( stringWriter );
   } else {
   printWriter = res.getWriter();
  -}
  +}
   
   URLConnection resourceInfo = resource.openConnection();
   InputStream resourceInputStream = resourceInfo.getInputStream();
  -BufferedReader bufferedReader = new BufferedReader( new InputStreamReader( 
resourceInputStream ) );
  -Date lastModifiedDate = new Date( resourceInfo.getLastModified() );
  -ssiProcessor.process( bufferedReader, lastModifiedDate, printWriter );
  +BufferedReader bufferedReader = new BufferedReader( new InputStreamReader( 
resourceInputStream ) );
  +Date lastModifiedDate = new Date( resourceInfo.getLastModified() );
  +ssiProcessor.process( bufferedReader, lastModifiedDate, printWriter );
   
   if ( buffered ) {
  -printWriter.flush();
  -String text = stringWriter.toString();
  +printWriter.flush();
  +String text = stringWriter.toString();
   res.getWriter().write( text );
  -}
  +}
   }
   }
  
  
  

--
To 

DO NOT REPLY [Bug 12462] - Request to META-INF return a 404 error

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462

Request to META-INF return a 404 error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |



--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 20:41 ---
I talked to the spec lead and the spec will be changed that a 404 will be 
required for WEB-INF and META-INF directories.  I have reverted the fix.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12462] - Request to META-INF return a 404 error

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12462

Request to META-INF return a 404 error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime JspContextWrapper.java

2002-09-12 Thread kinman

kinman  2002/09/12 13:48:17

  Modified:jasper2/src/share/org/apache/jasper/compiler
TagFileProcessor.java
   jasper2/src/share/org/apache/jasper/runtime
JspContextWrapper.java
  Log:
  - pageInfo can be null if the page is not compiled.
  - JspContextWrapper needs to implement VariableResolver interface.
  
  Revision  ChangesPath
  1.27  +7 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java
  
  Index: TagFileProcessor.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/TagFileProcessor.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- TagFileProcessor.java 11 Sep 2002 21:50:02 -  1.26
  +++ TagFileProcessor.java 12 Sep 2002 20:48:17 -  1.27
  @@ -387,9 +387,11 @@
// dependant list.
PageInfo pageInfo = wrapper.getJspEngineContext().getCompiler().
getPageInfo();
  - Iterator iter = pageInfo.getDependants().iterator();
  - if (iter.hasNext()) {
  - parentPageInfo.addDependant((String)iter.next());
  + if (pageInfo != null) {
  + Iterator iter = pageInfo.getDependants().iterator();
  + if (iter.hasNext()) {
  + parentPageInfo.addDependant((String)iter.next());
  + }
}
   
return tagClass;
  
  
  
  1.3   +20 -4 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspContextWrapper.java
  
  Index: JspContextWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspContextWrapper.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- JspContextWrapper.java19 Aug 2002 16:54:17 -  1.2
  +++ JspContextWrapper.java12 Sep 2002 20:48:17 -  1.3
  @@ -79,6 +79,7 @@
   import javax.servlet.jsp.JspWriter;
   import javax.servlet.jsp.tagext.BodyContent;
   import javax.servlet.jsp.JspException;
  +import javax.servlet.jsp.el.ELException;
   import javax.servlet.jsp.el.ExpressionEvaluator;
   import javax.servlet.jsp.el.VariableResolver;
   
  @@ -88,7 +89,7 @@
*
* @author Kin-man Chung
*/
  -public class JspContextWrapper extends PageContext {
  +public class JspContextWrapper extends PageContext implements VariableResolver {
   
   private PageContext pageContext;
   private transient Hashtable  pageAttributes;
  @@ -248,5 +249,20 @@
   throws IOException, ServletException 
   {
pageContext.handlePageException(t);
  +}
  +
  +/**
  + * VariableResolver interface
  + */
  +public Object resolveVariable( String pName, Object pContext )
  +throws ELException
  +{
  + if (pageContext instanceof PageContextImpl) {
  + return ((PageContextImpl)pageContext).
  + resolveVariable(pName, pContext);
  + }
  +
  + return ((JspContextWrapper)pageContext).
  + resolveVariable(pName, pContext);
   }
   }
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties

2002-09-12 Thread kinman

kinman  2002/09/12 14:57:01

  Modified:jasper2/src/share/org/apache/jasper/compiler Parser.java
   jasper2/src/share/org/apache/jasper/resources
messages.properties
  Log:
  - Fix 12590: jsp:attribute should be allowed in the body of jsp:param
for its value attribute
  
  Revision  ChangesPath
  1.31  +25 -12
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Parser.java
  
  Index: Parser.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Parser.java,v
  retrieving revision 1.30
  retrieving revision 1.31
  diff -u -r1.30 -r1.31
  --- Parser.java   6 Sep 2002 21:16:23 -   1.30
  +++ Parser.java   12 Sep 2002 21:57:00 -  1.31
  @@ -1505,23 +1505,32 @@
   } else if (reader.matches(jsp:directive.)) {
   parseXMLDirective(parent);
   } else if (reader.matches(%!)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Declarations );
   } else if (reader.matches(jsp:declaration)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Declarations );
   } else if (reader.matches(%=)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Expressions );
   } else if (reader.matches(jsp:expression)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Expressions );
   } else if (reader.matches(%)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Scriptlets );
   } else if (reader.matches(jsp:scriptlet)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Scriptlets );
   } else if (reader.matches(jsp:text)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + lt;jsp:text );
   } else if (reader.matches(${)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Expression language );
   } else if (reader.matches(jsp:)) {
  -err.jspError( reader.mark(), jsp.error.not.in.template );
  +err.jspError( reader.mark(), jsp.error.not.in.template,
  + Standard actions );
} else {
   parseTemplateText(parent);
}
  @@ -1736,6 +1745,10 @@
}
} else if (n instanceof Node.PlugIn) {
if (width.equals(name) || height.equals(name)) {
  + return TagInfo.BODY_CONTENT_JSP;
  + }
  + } else if (n instanceof Node.ParamAction) {
  + if (value.equals(name)) {
return TagInfo.BODY_CONTENT_JSP;
}
}
  
  
  
  1.39  +2 -2  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
  
  Index: messages.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
  retrieving revision 1.38
  retrieving revision 1.39
  diff -u -r1.38 -r1.39
  --- messages.properties   11 Sep 2002 20:50:45 -  1.38
  +++ messages.properties   12 Sep 2002 21:57:01 -  1.39
  @@ -298,6 +298,6 @@
   jsp.error.xmlns.redefinition.notimplemented=Internal error: Attempt to redefine 
xmlns:{0}.  Redefinition of namespaces is not implemented.
   jsp.error.could.not.add.taglibraries=Could not add tag one or more libraries.
   jsp.error.duplicate.name.jspattribute=The attribute {0} specified in the standard 
or custom action also appears as the value of the name attribute in the enclosed 
jsp:attribute
  -jsp.error.not.in.template=Not allowed in a template text body.
  +jsp.error.not.in.template={0} not allowed in a template text body.
   jsp.error.badaction=The action is not a recognizable standard action.
   jsp.error.tagdirective.badbodycontent=Invalid body-content ({0}) in tag directive
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12590] - Unable to nest jsp:attribute within jsp:body if used with jsp:include

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12590.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12590

Unable to nest jsp:attribute within jsp:body if used with jsp:include

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-09-12 Thread kinman

kinman  2002/09/12 15:51:23

  Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
  Log:
  - Fix 12594: When in a fragment, a SKIP_PAGE return should be converted to a
SkipException.
  
  Revision  ChangesPath
  1.100 +9 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.99
  retrieving revision 1.100
  diff -u -r1.99 -r1.100
  --- Generator.java11 Sep 2002 19:07:32 -  1.99
  +++ Generator.java12 Sep 2002 22:51:23 -  1.100
  @@ -694,6 +694,7 @@
private String parent;
private String simpleTagHandlerVar;
private boolean isSimpleTagHandler;
  + private boolean isFragment;
private boolean isTagFile;
private ServletWriter out;
private MethodsBuffer methodsBuffer;
  @@ -961,7 +962,7 @@
out.print( pageParam );
printParams(n, pageParam, page.isLiteral());
out.println(););
  - if (isTagFile) {
  + if (isTagFile || isFragment) {
out.printil(throw new javax.servlet.jsp.SkipPageException(););
} else {
out.printil((methodNesting  0)? return true;: return;);
  @@ -2094,7 +2095,7 @@
out.print(tagHandlerVar);
out.println(.doEndTag() == javax.servlet.jsp.tagext.Tag.SKIP_PAGE));
out.pushIndent();
  - if (isTagFile) {
  + if (isTagFile || isFragment) {
out.printil(throw new javax.servlet.jsp.SkipPageException(););
} else {
out.printil((methodNesting  0)? return true;: return;);
  @@ -2667,9 +2668,12 @@
out = fragment.getMethodsBuffer().getOut();
String tmpParent = parent;
parent = tagHandlerVar;
  + boolean tmpIsFragment = isFragment;
  + isFragment = true;
   visitBody( n );
   out = outSave;
parent = tmpParent;
  + isFragment = tmpIsFragment;
fragmentHelperClass.closeFragment(fragment, methodNesting);
   // XXX - Need to change pageContext to jspContext if
   // we're not in a place where pageContext is defined (e.g.
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12594] - If a SKIP_PAGE is returned from a classic tag nested within a Simple Tag , the page following the simple tag is displayed

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12594.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12594

If a SKIP_PAGE is returned from a classic tag nested within a Simple Tag , the page 
following the simple tag is displayed

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12387] - JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in classpath

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387

JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in 
classpath





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 23:11 ---
The way I fixed this problem (thanks to an article at webmasterbase.com) was to 
take both apache and tomcat and install them in the root of my c:\ drive.  The 
logic behind this is that there is a problem installing in the Program FIles 
directory because of the space between program and files.  I installed apache 
in C:\Apache and tomcat in C:\Apache\Tomcat.  After I did this it worked like a 
champ

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12591] - Variable declared with scope=AT_END available within the body of a simple tag

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12591.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12591

Variable declared with scope=AT_END available within the body of a simple tag

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 23:12 ---
Not a bug. This test case is testing for the presence of a *scoped* as
opposed to a *scripting* variable.

The doTag() implementation of the simple tag handler in this test case
generates the scoped variable before invoking its fragment body (using
getJspBody().invoke()), which explains why that variable is visible
within the fragment body (using an EL expression).

In addition, the doTag() implementation adds the variable to the
fragment parameter map, which is an additional reason why it can be
accessed in the fragment body (per the spec, for each key present in
the Map, the fragment must make a page scope variable available to the
fragment body, so that the parameters can be accessed via the
Expression Language or via other mechanisms).

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12387] - JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in classpath

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12387

JSP Compilation errors: jars in WEB-INF/lib and classes in WEB-INF/classes not in 
classpath





--- Additional Comments From [EMAIL PROTECTED]  2002-09-12 23:13 ---
I also installed the zip version of the Tomcat download and not the exe

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




[PATCH] for bug#12049: symlinked directories, jsp pages are not served

2002-09-12 Thread Liu, Xiaoyan

This bug is kind of annoying when there are lots of pages
shared across multiple clients. The common practice we
use on Tomcat 4.0.2 is to build symbolic links under each
client that points to a centralized place to avoid file 
copying on deployment.

With the new code in 4.1, the path check below prevents 
any symlinked pages from being served. I would like to
have it removed. However, with these two lines removed,
the code essentially retroback to 4.0.2 version with
very minor changes. 


org/apache/naming/resources/FileDirContext.java

 -866,10 +866,6 
 if (canPath == null)
 return null;

-if (!canPath.startsWith(absoluteBase)) {
-return null;
-}
-
 // Windows only check
 if ((caseSensitive)  (File.separatorChar  == '\\')) {
 String fileAbsPath = file.getAbsolutePath();



Xiaoyan Liu
Capitalthinking.com



Re: [PATCH] for bug#12049: symlinked directories, jsp pages are not served

2002-09-12 Thread Remy Maucherat

 This bug is kind of annoying when there are lots of pages
 shared across multiple clients. The common practice we
 use on Tomcat 4.0.2 is to build symbolic links under each
 client that points to a centralized place to avoid file 
 copying on deployment.
 
 With the new code in 4.1, the path check below prevents 
 any symlinked pages from being served. I would like to
 have it removed. However, with these two lines removed,
 the code essentially retroback to 4.0.2 version with
 very minor changes. 

Obviously, those lines are for security reasons.

-1 for the patch (at best, the check will be made optional).

Remy

 org/apache/naming/resources/FileDirContext.java
 
 @@ -866,10 +866,6 @@
  if (canPath == null)
  return null;
 
 -if (!canPath.startsWith(absoluteBase)) {
 -return null;
 -}
 -
  // Windows only check
  if ((caseSensitive)  (File.separatorChar  == '\\')) {
  String fileAbsPath = file.getAbsolutePath();
 
 
 
 Xiaoyan Liu
 Capitalthinking.com
 


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2002-09-12 Thread luehe

luehe   2002/09/12 17:29:48

  Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
  Log:
  Removed curly brackets at the beginning and end of simple tag invocation
  
  Revision  ChangesPath
  1.101 +3 -8  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.100
  retrieving revision 1.101
  diff -u -r1.100 -r1.101
  --- Generator.java12 Sep 2002 22:51:23 -  1.100
  +++ Generator.java13 Sep 2002 00:29:48 -  1.101
  @@ -2156,9 +2156,6 @@
declareScriptingVars(n, VariableInfo.AT_BEGIN);
saveScriptingVars(n, VariableInfo.AT_BEGIN);
   
  - out.printil({);
  - out.pushIndent();
  -
out.printin(tagHandlerClass.getName());
out.print( );
out.print(tagHandlerVar);
  @@ -2199,8 +2196,6 @@
out.println(.doTag(););
   
restoreScriptingVars(n, VariableInfo.AT_BEGIN);
  - out.popIndent();
  - out.printil(});
   
// Synchronize AT_BEGIN scripting variables
syncScriptingVars(n, VariableInfo.AT_BEGIN);
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: [PATCH] for bug#12049: symlinked directories, jsp pages arenot served

2002-09-12 Thread Pier Fumagalli

On 13/9/02 1:14, Remy Maucherat [EMAIL PROTECTED] wrote:

 This bug is kind of annoying when there are lots of pages
 shared across multiple clients. The common practice we
 use on Tomcat 4.0.2 is to build symbolic links under each
 client that points to a centralized place to avoid file
 copying on deployment.
 
 With the new code in 4.1, the path check below prevents
 any symlinked pages from being served. I would like to
 have it removed. However, with these two lines removed,
 the code essentially retroback to 4.0.2 version with
 very minor changes.
 
 Obviously, those lines are for security reasons.
 
 -1 for the patch (at best, the check will be made optional).

Hmm... I'm wondering what are the problems if that check is not performed...
I don't see major concerns in allowing symlinked files or directories...

Also, few lines below, the check should be done for OS/X as well, given that
the file system is case insensitive, and for Unix operating systems if they
mount network shared volumes in case those are case unsensitive (SMB with
case insensitive FS on the other side, that kinda stuff)...

Pier


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12601] New: - Listener Exception does not cause server error

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12601.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12601

Listener Exception does not cause server error

   Summary: Listener Exception does not cause server error
   Product: Tomcat 5
   Version: Unknown
  Platform: PC
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In the application, if there is a exception thrown from method (e.g. session 
time out)
 public void sessionDestroyed(HttpSessionEvent event) 

Then the server does not give 500 error for the further request to the 
application.

According to servlet 2.4 spec, SRV 10.6. , The container may respond to all 
subseuent requests to the web applicaiton with an HTTP status code 500 to 
indicate the applicaiton error

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans DefaultContextMBean.java MBeanFactory.java ServerLifecycleListener.java

2002-09-12 Thread amyroh

amyroh  2002/09/12 18:35:23

  Modified:catalina/src/share/org/apache/catalina/mbeans
DefaultContextMBean.java MBeanFactory.java
ServerLifecycleListener.java
  Log:
  Add NamingResource handling for DefaultContext.
  
  Revision  ChangesPath
  1.2   +5 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/DefaultContextMBean.java
  
  Index: DefaultContextMBean.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/DefaultContextMBean.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- DefaultContextMBean.java  9 Sep 2002 23:39:03 -   1.1
  +++ DefaultContextMBean.java  13 Sep 2002 01:35:22 -  1.2
  @@ -265,6 +265,7 @@
   ManagedBean managed = registry.findManagedBean(ContextResource);
   ObjectName oname =
   MBeanUtils.createObjectName(managed.getDomain(), resource);
  +
   return (oname.toString());
   }
   
  
  
  
  1.38  +6 -8  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
  
  Index: MBeanFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -r1.37 -r1.38
  --- MBeanFactory.java 11 Sep 2002 14:19:33 -  1.37
  +++ MBeanFactory.java 13 Sep 2002 01:35:22 -  1.38
  @@ -819,7 +819,7 @@
   public String createStandardContext(String parent, String path,
   String docBase)
   throws Exception {
  -
  +
   // Create a new StandardContext instance
   StandardContext context = new StandardContext();
   path = getPathStr(path);
  @@ -832,15 +832,13 @@
   Service service = server.findService(pname.getKeyProperty(service));
   Engine engine = (Engine) service.getContainer();
   Host host = (Host) engine.findChild(pname.getKeyProperty(host));
  -context.setParent(host);
   host.addChild(context);
   
   // Return the corresponding MBean name
   ManagedBean managed = registry.findManagedBean(StandardContext);
   ObjectName oname =
   MBeanUtils.createObjectName(managed.getDomain(), context);
  -throw new Exception(oname.toString());
  -//return (oname.toString());
  +return (oname.toString());
   
   }
   
  
  
  
  1.33  +45 -7 
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ServerLifecycleListener.java
  
  Index: ServerLifecycleListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ServerLifecycleListener.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- ServerLifecycleListener.java  11 Sep 2002 14:19:33 -  1.32
  +++ ServerLifecycleListener.java  13 Sep 2002 01:35:22 -  1.33
  @@ -948,6 +948,44 @@
   
   
   /**
  + * Deregister the MBeans for the specified DefaultContext and its nested
  + * components.
  + *
  + * @param dcontext DefaultContext for which to deregister MBeans
  + *
  + * @exception Exception if an exception is thrown during MBean destruction
  + */
  +protected void destroyMBeans(DefaultContext dcontext) throws Exception {
  +
  +Manager dManager = dcontext.getManager();
  +if (dManager != null) {
  +if (debug = 4)
  +log(Destroying MBean for Manager  + dManager);
  +MBeanUtils.destroyMBean(dManager);
  +}
  +
  +Loader dLoader = dcontext.getLoader();
  +if (dLoader != null) {
  +if (debug = 4)
  +log(Destroying MBean for Loader  + dLoader);
  +MBeanUtils.destroyMBean(dLoader);
  +}
  +
  +// Destroy the MBeans for the NamingResources (if any)
  +NamingResources resources = dcontext.getNamingResources();
  +if (resources != null) {
  +destroyMBeans(resources);
  +}
  +
  +// deregister the MBean for the DefaultContext itself
  +if (debug = 4)
  +log(Destroying MBean for Context  + dcontext);
  +MBeanUtils.destroyMBean(dcontext);
  +
  +}
  +
  +
  +/**
* Deregister the MBeans for the specified Engine and its nested
* components.
*
  @@ -1138,7 +1176,7 @@
*
* @param service Service for which to destroy MBeans
*
  -o * @exception Exception if an exception is thrown during MBean destruction
  + * @exception Exception if an 

cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/defaultcontext SaveDefaultContextAction.java

2002-09-12 Thread amyroh

amyroh  2002/09/12 18:35:35

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
Lists.java TomcatTreeBuilder.java
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/context
SaveContextAction.java
   webapps/admin/WEB-INF/classes/org/apache/webapp/admin/defaultcontext
SaveDefaultContextAction.java
  Log:
  Add NamingResource handling for DefaultContext.
  
  Revision  ChangesPath
  1.12  +24 -18
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/Lists.java
  
  Index: Lists.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/Lists.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- Lists.java11 Sep 2002 14:20:00 -  1.11
  +++ Lists.java13 Sep 2002 01:35:34 -  1.12
  @@ -259,10 +259,9 @@
* @exception Exception if thrown while retrieving the list
*/
   public static List getDefaultContexts(MBeanServer mbserver, String 
  -container, String containerType) throws Exception {
  +container) throws Exception {
   
  -return (getDefaultContexts(mbserver, new ObjectName(container), 
  -containerType));
  +return (getDefaultContexts(mbserver, new ObjectName(container)));
   
   }
   
  @@ -280,19 +279,26 @@
* @exception Exception if thrown while retrieving the list
*/
   public static List getDefaultContexts(MBeanServer mbserver, ObjectName 
  -container, String containerType) throws Exception {
  -
  +container) throws Exception {
  +
   StringBuffer sb = new StringBuffer(container.getDomain());
  -if (containerType.equals(service)) {
  -sb.append(:type=DefaultContext,service=);
  -sb.append(container.getKeyProperty(name));
  -sb.append(,*);
  -} else if (containerType.equals(host)) {
  -sb.append(:type=DefaultContext,host=);
  -sb.append(container.getKeyProperty(host));
  +sb.append(:type=DefaultContext);
  +String type = container.getKeyProperty(type);
  +String host = container.getKeyProperty(host);
  +if (Host.equals(type)) {
  +host = container.getKeyProperty(host);
  +}
  +if (host != null) {
  +sb.append(,host=);
  +sb.append(host);
  +}
  +String service = container.getKeyProperty(service);
  +if (Service.equals(type)) {
  +service = container.getKeyProperty(name);
  +}
  +if (service != null) {
   sb.append(,service=);
  -sb.append(container.getKeyProperty(service));
  -sb.append(,*);
  +sb.append(service);
   }
   ObjectName search = new ObjectName(sb.toString());
   ArrayList defaultContexts = new ArrayList();
  
  
  
  1.36  +8 -10 
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TomcatTreeBuilder.java
  
  Index: TomcatTreeBuilder.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TomcatTreeBuilder.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- TomcatTreeBuilder.java11 Sep 2002 14:20:00 -  1.35
  +++ TomcatTreeBuilder.java13 Sep 2002 01:35:34 -  1.36
  @@ -215,7 +215,7 @@
   false);
   serverNode.addChild(serviceNode);
   getConnectors(serviceNode, serviceName);
  -getDefaultContexts(serviceNode, serviceName, service, resources);
  +getDefaultContexts(serviceNode, serviceName, resources);
   getHosts(serviceNode, serviceName, resources);
   getLoggers(serviceNode, serviceName);
   getRealms(serviceNode, serviceName);
  @@ -290,7 +290,7 @@
   false);
   serviceNode.addChild(hostNode);
   getContexts(hostNode, hostName, resources);
  -getDefaultContexts(hostNode, hostName, host, resources);
  +getDefaultContexts(hostNode, hostName, resources);
   getLoggers(hostNode, hostName);
   getRealms(hostNode, hostName);
   getValves(hostNode, hostName);
  @@ -350,12 +350,10 @@
* @exception Exception if an exception occurs building the tree
*/
   public void getDefaultContexts(TreeControlNode hostNode, String containerName, 
  -String containerType, MessageResources resources) 
  -throws Exception {
  +

Re: [PATCH] for bug#12049: symlinked directories, jsp pages arenot served

2002-09-12 Thread Remy Maucherat

 On 13/9/02 1:14, Remy Maucherat [EMAIL PROTECTED] wrote:

  This bug is kind of annoying when there are lots of pages
  shared across multiple clients. The common practice we
  use on Tomcat 4.0.2 is to build symbolic links under each
  client that points to a centralized place to avoid file
  copying on deployment.
 
  With the new code in 4.1, the path check below prevents
  any symlinked pages from being served. I would like to
  have it removed. However, with these two lines removed,
  the code essentially retroback to 4.0.2 version with
  very minor changes.
 
  Obviously, those lines are for security reasons.
 
  -1 for the patch (at best, the check will be made optional).

 Hmm... I'm wondering what are the problems if that check is not
performed...
 I don't see major concerns in allowing symlinked files or directories...

Well, it has the advantage of:
- preventing access if somehow there's a security problem which is later
found in Tomcat, which would otherwise allow browsing the HD
- it may be what fixed the path disclosure issues on Windows

I will make the check optional (with a flag).

 Also, few lines below, the check should be done for OS/X as well, given
that
 the file system is case insensitive, and for Unix operating systems if
they
 mount network shared volumes in case those are case unsensitive (SMB with
 case insensitive FS on the other side, that kinda stuff)...

Quite possibly.

Remy


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12601] - Listener Exception does not cause server error

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12601.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12601

Listener Exception does not cause server error





--- Additional Comments From [EMAIL PROTECTED]  2002-09-13 03:09 ---
Well, it looks to me it is a may, not a must, so ignoring the error looks 
ok according to your quote.

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Applet Codebase From Servlet

2002-09-12 Thread Martin Mc Atamney

I have a servlet which produces straight HTML.  In the HTML I'd like to 
embed an applet tag.  My servlet is in com.test.servlet, my applet in 
com.test.applet.

I set the code value in the applet tag to test.class, but after trying 
various combinations for codebase I still getting a FileNotFound exception 
when a browser tries to load my applet.

Am I missing something.  I am using jakarta-tomcat-4.0-b5





_
Send and receive Hotmail on your mobile device: http://mobile.msn.com


--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




Re: Applet Codebase From Servlet

2002-09-12 Thread Bojan Smojver

There is no difference between the HTML generated by the servlet and a static
HTML file. So, cut yourself a static HTML file (handy for testing), put the
applet tag in there and watch the web server log files to see what is the actual
requested URL. Once you know that, fix it accordingly and you'll be laughing.

Bojan

Quoting Martin Mc Atamney [EMAIL PROTECTED]:

 I have a servlet which produces straight HTML.  In the HTML I'd like to 
 embed an applet tag.  My servlet is in com.test.servlet, my applet in 
 com.test.applet.
 
 I set the code value in the applet tag to test.class, but after trying 
 various combinations for codebase I still getting a FileNotFound exception 
 when a browser tries to load my applet.
 
 Am I missing something.  I am using jakarta-tomcat-4.0-b5

-
This mail sent through IMP: http://horde.org/imp/

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/compat Jdk11Compat.java Jdk12Support.java SimpleClassLoader.java

2002-09-12 Thread billbarker

billbarker2002/09/12 21:47:02

  Modified:src/share/org/apache/tomcat/util/compat Jdk11Compat.java
Jdk12Support.java SimpleClassLoader.java
  Log:
  Converting to using commons-logging.
  
  Revision  ChangesPath
  1.14  +7 -10 
jakarta-tomcat/src/share/org/apache/tomcat/util/compat/Jdk11Compat.java
  
  Index: Jdk11Compat.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/compat/Jdk11Compat.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- Jdk11Compat.java  18 Sep 2001 23:24:46 -  1.13
  +++ Jdk11Compat.java  13 Sep 2002 04:47:02 -  1.14
  @@ -74,7 +74,9 @@
   The base class supports JDK1.1 behavior. 
   */
   public class Jdk11Compat {
  -
  +static org.apache.commons.logging.Log logger =
  + org.apache.commons.logging.LogFactory.getLog(Jdk11Compat.class);
  +
   /** Return java version as a string
*/
   public static String getJavaVersion() {
  @@ -209,7 +211,8 @@
try {
URL url=new URL( jar:file:/test.jar!/foo);
} catch( MalformedURLException ex ) {
  - if( dL 0) d( Installing jar protocol handler );
  + if( logger.isDebugEnabled() ) 
  + logger.debug( Installing jar protocol handler );
String handlers=System.getProperty(java.protocol.handler.pkgs);
if( handlers==null ) {
handlers=URL_COMPAT_HANDLERS;
  @@ -219,12 +222,11 @@
}
}
System.getProperties().put(java.protocol.handler.pkgs, handlers);
  - if( dL  0 ) {
  + if( logger.isDebugEnabled() ) {
try {
URL url=new URL( jar:file:/test.jar!/foo);
} catch( MalformedURLException ex1 ) {
  - d(Jar protocol failing );
  - ex1.printStackTrace();
  + logger.debug(Jar protocol failing , ex1);
}
}
}
  @@ -233,10 +235,5 @@
   
   private static final String URL_COMPAT_HANDLERS=
org.apache.tomcat.util.compat;
  -
  -private static final int dL=10;
  -private static void d(String s ) {
  -System.err.println( Jdk11Compat:  + s );
  -}
   
   }
  
  
  
  1.11  +0 -1  
jakarta-tomcat/src/share/org/apache/tomcat/util/compat/Jdk12Support.java
  
  Index: Jdk12Support.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/compat/Jdk12Support.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- Jdk12Support.java 11 Jan 2002 06:55:30 -  1.10
  +++ Jdk12Support.java 13 Sep 2002 04:47:02 -  1.11
  @@ -72,7 +72,6 @@
*/
   public class Jdk12Support extends Jdk11Compat {
   
  -
   /** Return a class loader. For JDK1.2+ will return a URLClassLoader.
*  For JDK1.1 will return the util.SimepleClassLoader
*/
  
  
  
  1.5   +26 -23
jakarta-tomcat/src/share/org/apache/tomcat/util/compat/SimpleClassLoader.java
  
  Index: SimpleClassLoader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/compat/SimpleClassLoader.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- SimpleClassLoader.java17 Jun 2001 18:09:13 -  1.4
  +++ SimpleClassLoader.java13 Sep 2002 04:47:02 -  1.5
  @@ -86,7 +86,8 @@
* The class path can be set only when the object is constructed.
*/
   public class SimpleClassLoader extends ClassLoader {
  -private static final int debug=0;
  +static org.apache.commons.logging.Log logger =
  + org.apache.commons.logging.LogFactory.getLog(SimpleClassLoader.class);
   
   /**
* The classpath which this classloader searches for class definitions.
  @@ -168,11 +169,6 @@
}
   }
   
  -// debug only 
  -void log( String s ) {
  - System.out.println(SimpleClassLoader:  + s );
  -}
  -
   // Implementation of Classloader
   
   /*
  @@ -202,7 +198,8 @@
   protected synchronized Class loadClass(String name, boolean resolve)
   throws ClassNotFoundException
   {
  -if( debug0) log( loadClass()  + name +   + resolve);
  +if( logger.isDebugEnabled() )
  + logger.debug( loadClass()  + name +   + resolve);
// The class object that will be returned.
   Class c = null;
   
  @@ -219,7 +216,8 @@
try {
c = parent.loadClass(name);
if (c != null) {
  - if( debug0) log( loadClass() from parent  + name);
  + 

Re: [PATCH] for bug#12049: symlinked directories, jsp pages arenot served

2002-09-12 Thread Bill Barker


- Original Message -
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED]
Sent: Thursday, September 12, 2002 7:39 PM
Subject: Re: [PATCH] for bug#12049: symlinked directories, jsp pages arenot
served


  On 13/9/02 1:14, Remy Maucherat [EMAIL PROTECTED] wrote:
 
   This bug is kind of annoying when there are lots of pages
   shared across multiple clients. The common practice we
   use on Tomcat 4.0.2 is to build symbolic links under each
   client that points to a centralized place to avoid file
   copying on deployment.
  
   With the new code in 4.1, the path check below prevents
   any symlinked pages from being served. I would like to
   have it removed. However, with these two lines removed,
   the code essentially retroback to 4.0.2 version with
   very minor changes.
  
   Obviously, those lines are for security reasons.
  
   -1 for the patch (at best, the check will be made optional).
 
  Hmm... I'm wondering what are the problems if that check is not
 performed...
  I don't see major concerns in allowing symlinked files or directories...

 Well, it has the advantage of:
 - preventing access if somehow there's a security problem which is later
 found in Tomcat, which would otherwise allow browsing the HD
 - it may be what fixed the path disclosure issues on Windows

 I will make the check optional (with a flag).

+1 (if I knew how, I'd do it myself).  I agree that the default should be to
disable sym-links, but the webmaster (and, with my webmaster hat on, I can't
use = 4 without sym-links) should be able to say what he/she wants to
trust.


  Also, few lines below, the check should be done for OS/X as well, given
 that
  the file system is case insensitive, and for Unix operating systems if
 they
  mount network shared volumes in case those are case unsensitive (SMB
with
  case insensitive FS on the other side, that kinda stuff)...

 Quite possibly.

 Remy


 --
 To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
 For additional commands, e-mail:
mailto:[EMAIL PROTECTED]



--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/hooks Hooks.java

2002-09-12 Thread billbarker

billbarker2002/09/12 22:23:32

  Modified:src/share/org/apache/tomcat/util/hooks Hooks.java
  Log:
  Converting to commons-logging.
  
  Revision  ChangesPath
  1.9   +5 -5  jakarta-tomcat/src/share/org/apache/tomcat/util/hooks/Hooks.java
  
  Index: Hooks.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/hooks/Hooks.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Hooks.java2 Jun 2002 05:30:31 -   1.8
  +++ Hooks.java13 Sep 2002 05:23:32 -  1.9
  @@ -85,6 +85,9 @@
* implementation
*/
   public class Hooks {
  +static org.apache.commons.logging.Log logger =
  + org.apache.commons.logging.LogFactory.getLog(Hooks.class);
  +
   public static final int INITIAL_HOOKS=24;
   int hookCount;
   String hookNames[];
  @@ -160,7 +163,8 @@
for( int i=0; i hookNames.length ; i++ ) {
if( hookNames[i]==null ) continue;
if( hasHook( bi, hookNames[i] )) {
  - if( dL  0 ) debug( Adding  + hookNames[i] +   +bi );
  + if( logger.isDebugEnabled() ) 
  + logger.debug( Adding  + hookNames[i] +   +bi );
hooksV[i].addElement( bi );
hooks[i]=null;
}
  @@ -207,10 +211,6 @@
allModules=new Object[allModulesV.size()];
allModulesV.copyInto( allModules );
return allModules;
  -}
  -
  -private void debug(String s ) {
  - System.out.println(Hooks:  + s );
   }
   
   /** Test if the interceptor implements a particular
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/io FileUtil.java

2002-09-12 Thread billbarker

billbarker2002/09/12 22:31:08

  Modified:src/share/org/apache/tomcat/util/io FileUtil.java
  Log:
  Converting to commons-logging.
  
  Revision  ChangesPath
  1.8   +10 -9 jakarta-tomcat/src/share/org/apache/tomcat/util/io/FileUtil.java
  
  Index: FileUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/io/FileUtil.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- FileUtil.java 22 Jan 2002 06:09:51 -  1.7
  +++ FileUtil.java 13 Sep 2002 05:31:08 -  1.8
  @@ -67,7 +67,6 @@
   import java.io.*;
   import java.util.zip.*;
   
  -import org.apache.tomcat.util.log.*;
   
   /*
* FileUtil contains utils for dealing with Files. Some of these are 
  @@ -128,7 +127,9 @@
   
   // XXX tc_log is the default channel in tomcat, this component
   //should be able to log in a specific channel.
  -static Log loghelper = Log.getLog(tc/FileUtil, FileUtil);
  +static org.apache.commons.logging.Log logger =
  + org.apache.commons.logging.LogFactory.getLog(DependClassLoader.class);
  +
   
   /** All the safety checks from getRealPath() and
DefaultServlet.
  @@ -187,8 +188,7 @@
try {
canPath=new File(realPath).getCanonicalPath();
} catch( IOException ex ) {
  - //log(safePath:  + realPath, ex);
  - loghelper.log(in safePath( + base +, +path + ), realPath= + 
realPath, ex);
  + logger.error(in safePath( + base +, +path + ), realPath= + realPath, 
ex);
return null;
}
   
  @@ -405,8 +405,9 @@
fos.close();
}
} catch( FileNotFoundException ex ) {
  - //loghelper.log(FileNotFoundException:  +
  - //   ze.getName(), Logger.ERROR );
  + if(logger.isDebugEnabled())
  + logger.debug(FileNotFoundException:  +
  +   ze.getName(), Logger.ERROR );
throw ex;
}
}
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12605] New: - [RFE] text/xml mime type not listed in default web.xml

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12605.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12605

[RFE] text/xml mime type not listed in default web.xml

   Summary: [RFE] text/xml mime type not listed in default web.xml
   Product: Tomcat 4
   Version: 4.1.10
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I was having Tomcat serve up xml pages and I couldn't figure out why, in 
response wrapper used in my filter that the setContentType(String) that I was 
overriding was never getting called.

Turns out that Tomcat's default servlet doesn't call setContentType(String) 
unless a mime-type has been defined in either Tomcat's conf/web.xml or the 
webapps's WEB-INF/web.xml.  I didn't have it defined in my own webapp because I 
assumed that such a common file type would have been already listed in 
conf/web.xml.  When I added the text/xml mime type to my own web.xml, 
everything worked as expected.

I propose that, at the very least, the following mime types get added to 
Tomcat's conf/web.xml to avoid future confusion ...

mime-mapping
extensionxml/extension
mime-typetext/xml/mime-type
/mime-mapping

mime-mapping
extensionxsl/extension
mime-typetext/xml/mime-type
/mime-mapping

Jake

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/io FileUtil.java

2002-09-12 Thread billbarker

billbarker2002/09/12 22:43:48

  Modified:src/share/org/apache/tomcat/util/io FileUtil.java
  Log:
  Fix cut/paste errors.
  
  Revision  ChangesPath
  1.9   +6 -7  jakarta-tomcat/src/share/org/apache/tomcat/util/io/FileUtil.java
  
  Index: FileUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/io/FileUtil.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- FileUtil.java 13 Sep 2002 05:31:08 -  1.8
  +++ FileUtil.java 13 Sep 2002 05:43:48 -  1.9
  @@ -128,7 +128,7 @@
   // XXX tc_log is the default channel in tomcat, this component
   //should be able to log in a specific channel.
   static org.apache.commons.logging.Log logger =
  - org.apache.commons.logging.LogFactory.getLog(DependClassLoader.class);
  + org.apache.commons.logging.LogFactory.getLog(FileUtil.class);
   
   
   /** All the safety checks from getRealPath() and
  @@ -405,9 +405,8 @@
fos.close();
}
} catch( FileNotFoundException ex ) {
  - if(logger.isDebugEnabled())
  - logger.debug(FileNotFoundException:  +
  -   ze.getName(), Logger.ERROR );
  + logger.error(FileNotFoundException:  +
  +  ze.getName(), ex);
throw ex;
}
}
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/xml XmlMapper.java

2002-09-12 Thread billbarker

billbarker2002/09/12 22:47:59

  Modified:src/share/org/apache/tomcat/util/xml XmlMapper.java
  Log:
  Convert to commons-logging.
  
  Revision  ChangesPath
  1.41  +14 -14
jakarta-tomcat/src/share/org/apache/tomcat/util/xml/XmlMapper.java
  
  Index: XmlMapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/xml/XmlMapper.java,v
  retrieving revision 1.40
  retrieving revision 1.41
  diff -u -r1.40 -r1.41
  --- XmlMapper.java19 Dec 2001 00:02:09 -  1.40
  +++ XmlMapper.java13 Sep 2002 05:47:59 -  1.41
  @@ -23,6 +23,9 @@
*/
   public class XmlMapper  extends HandlerBase implements SaxContext
   {
  +static org.apache.commons.logging.Log logger =
  + org.apache.commons.logging.LogFactory.getLog(XmlMapper.class);
  +
   Locator locator;
   
   /**
  @@ -44,7 +47,6 @@
   
   String body;
   
  -int debug=0;
   boolean validating=false;
   private Hashtable entities = new Hashtable();
   
  @@ -56,7 +58,8 @@
   
   public void setDocumentLocator (Locator locator)
   {
  - if( debug0 ) log(Set locator :  + locator);
  + if( logger.isDebugEnabled() ) 
  + logger.debug(Set locator :  + locator);
this.locator = locator;
   }
   
  @@ -80,7 +83,8 @@
throws SAXException
   {
try {
  - if( debug5) log(sp +   + tag +   + attributes + );
  + if( logger.isTraceEnabled() ) 
  + logger.trace(sp +   + tag +   + attributes + );
attributeStack[sp]=attributes;
tagStack[sp]=tag;
sp++;
  @@ -223,17 +227,15 @@
   //  Utils 
   // Debug ( to be replaced with the real thing )
   public void setDebug( int level ) {
  - if(level!=0) log( Debug level:  + level );
  - debug=level;
   }
   
   public int getDebug() {
  - return debug;
  + return logger.isDebugEnabled() ? 1 : 0;
   }
   
   public void setValidating( boolean validating ) {
  - if (debug = 1)
  - log(Validating =  + validating);
  + if ( logger.isTraceEnabled() )
  + logger.trace(Validating =  + validating);
this.validating = validating;
   }
   
  @@ -241,12 +243,6 @@
return (this.validating);
   }
   
  -public void log(String msg) {
  - // log is for debug only, it should't be enabled for anything else
  - // ( no dependency on Logger or any external tomcat package )
  - System.out.println(XmlMapper:  + msg);
  -}
  -
   public void setVariable( String name, Object value ) {
if( value==null)
variables.remove(name);
  @@ -271,6 +267,10 @@
   public void useLocalLoader(boolean b ) {
useLocalLoader=b;
   }
  +public void log(String msg) {
  + logger.info(msg);
  +}
  +
   static final Jdk11Compat jdk11Compat=Jdk11Compat.getJdkCompat();
   
   /** read an XML file, construct and return the object hierarchy
  
  
  

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12606] New: - jasper2 sometimes creates multiple declarations of the same variable name in the generated servlet - jsp compilation fails

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606

jasper2 sometimes creates multiple declarations of the same variable name in the 
generated servlet - jsp compilation fails

   Summary: jasper2 sometimes creates multiple declarations of the
same variable name in the generated servlet - jsp
compilation fails
   Product: Tomcat 4
   Version: 4.1.10
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper 2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


the new optimization in jasper2 sometimes creates multiple declarations of the 
same variable name in the generated servlet - jsp compilation fails.

It happened for me on strut's logic:iterate tags. the two variables were 
the id and the indexId attribute of the tag:

GENERATED SERVLET (snippett):

  public void _jspService(...) throws ... {

JspFactory _jspxFactory = null;
...
JspWriter _jspx_out = null;

/* FIRST DECL */
org.sureguidance.Comment _jspx_comment_1 = null;
java.lang.Integer _jspx_commentIndex_1 = null;
/**/

try {
  _jspxFactory = JspFactory.getDefaultFactory();
  response.setContentType(text/html;charset=ISO-8859-1);
  pageContext = _jspxFactory.getPageContext(this, request, response,
null, true, 8192, true);
  ...
do {
  out.write(\n);
  /*   logic:iterate  */
  /* SECOND DECL */
  org.sureguidance.Comment _jspx_comment_1 = comment;
  java.lang.Integer _jspx_commentIndex_1 = commentIndex;
  /**/

note that in the second decl, the variables comment and commentIndex
were not defined previously in the servlet: cause for another compilation 
error.


JSP:

...
div class=LeftSubNavStyle
  logic:iterate id=section
  name=chapter
  property=sectionsList
  type=org.sureguidance.Section
  indexId=sectionIndex
logic:iterate id=comment
name=section
property=commentsList
type=org.sureguidance.Comment
indexId=commentIndex
  bean:define id=commentAnchor name=comment property=anchor
type=java.lang.String/
  logic:notEqual name=comment property=subject value=
bbean:write name=comment property=index/./b

note that section and sectionIndex do not have this problem 

contact me if you need complete code and the error page.

thanx,
you guys rock!!!

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12606] - jasper2 sometimes creates multiple declarations of the same variable name in the generated servlet - jsp compilation fails

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606

jasper2 sometimes creates multiple declarations of the same variable name in the 
generated servlet - jsp compilation fails





--- Additional Comments From [EMAIL PROTECTED]  2002-09-13 06:19 ---
Created an attachment (id=3037)
leftNav_jsp.java

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]




DO NOT REPLY [Bug 12606] - jasper2 sometimes creates multiple declarations of the same variable name in the generated servlet - jsp compilation fails

2002-09-12 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12606

jasper2 sometimes creates multiple declarations of the same variable name in the 
generated servlet - jsp compilation fails





--- Additional Comments From [EMAIL PROTECTED]  2002-09-13 06:20 ---
Created an attachment (id=3038)
leftNav.jsp

--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]