cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java

[billbarker]

billbarker2002/12/31 22:26:32

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java
  Log:
  Port from Tomcat 4.
  
  Revision  ChangesPath
  1.10  +4 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- ManagerBase.java  31 Dec 2002 03:48:08 -  1.9
  +++ ManagerBase.java  1 Jan 2003 06:26:32 -   1.10
  @@ -637,7 +637,6 @@
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
  -session.setId(sessionId);
   }
   synchronized (sessions) {
   while (sessions.get(sessionId) != null){ // Guarantee uniqueness
  @@ -645,7 +644,6 @@
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
  -session.setId(sessionId);
   }
   }
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

[billbarker]

billbarker2002/12/31 22:24:26

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java
  Log:
  Set the sessionId property only once.
  
  It seems that this is an issue for the community, so let's get it right.
  
  Submitted by: Phil Steitz [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.17  +4 -6  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- ManagerBase.java  31 Dec 2002 03:45:48 -  1.16
  +++ ManagerBase.java  1 Jan 2003 06:24:26 -   1.17
  @@ -584,7 +584,6 @@
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
  -session.setId(sessionId);
   }
   synchronized (sessions) {
   while (sessions.get(sessionId) != null){ // Guarantee uniqueness
  @@ -592,7 +591,6 @@
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
  -session.setId(sessionId);
   }
   }
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 15746] - Possible concurrency problem in StandardSession.recycle()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746

Possible concurrency problem in StandardSession.recycle()





--- Additional Comments From [EMAIL PROTECTED]  2003-01-01 02:12 ---
Created an attachment (id=4311)
Patch to move isValid = false to start of StandardSession.recycle()

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 15746] New: - Possible concurrency problem in StandardSession.recycle()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15746

Possible concurrency problem in StandardSession.recycle()

   Summary: Possible concurrency problem in
StandardSession.recycle()
   Product: Tomcat 4
   Version: 4.1.19
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


A session being recycled could have attributes added by other threads *after*
the attributes are cleared, since this method is not synchronized.

This exposure can be eliminated by moving the isValid = false to the beginning
of the method.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/sessionManagerBase.java

[Glenn Olander]

fyi, this still isn't correct.  If you can simply copy/paste the code
from these messages I'm sending, that should ensure the correct code 
gets checked in. Here is
what it should look like:


   String sessionId = generateSessionId();
   String jvmRoute = getJvmRoute();
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
   }  
   synchronized (sessions) {
   while (sessions.get(sessionId) != null){// Guarantee 
uniqueness
   log("Found duplicate session id, getting a new one.");
   sessionId = generateSessionId();
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
   }
   }
   session.setId(sessionId);
   }
   return (session);



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session ManagerBase.java

[Phil Steitz]

[EMAIL PROTECTED] wrote:

billbarker2002/12/30 19:45:48

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java
  Log:
  Make certain that the jvmRoute is attached to the session before comparing for uniqueness.
  
  Submitted by: Glenn Olander [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.16  +15 -9 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- ManagerBase.java	30 Dec 2002 02:36:26 -	1.15
  +++ ManagerBase.java	31 Dec 2002 03:45:48 -	1.16
  @@ -580,17 +580,23 @@
   session.setMaxInactiveInterval(this.maxInactiveInterval);
   String sessionId = generateSessionId();
   
  -synchronized (sessions) {
  -while (sessions.get(sessionId) != null)// Guarantee uniqueness
  -sessionId = generateSessionId();
  -}
  -
   String jvmRoute = getJvmRoute();
   // @todo Move appending of jvmRoute generateSessionId()???
   if (jvmRoute != null) {
   sessionId += '.' + jvmRoute;
   session.setId(sessionId);
   }
  +synchronized (sessions) {
  +while (sessions.get(sessionId) != null){ // Guarantee uniqueness
  +sessionId = generateSessionId();
  +// @todo Move appending of jvmRoute generateSessionId()???
  +if (jvmRoute != null) {
  +sessionId += '.' + jvmRoute;
  +session.setId(sessionId);
  +}
  +}
  +}
  +
   session.setId(sessionId);
   
   return (session);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



Seems to me that all but the last setID(sessionID) in the code above 
should be removed.  The session ID should not be set until a unique id 
has been found. I have attached a patch against the current head 
removing the lines to be deleted.  Unless I am missing something, there 
is no point in making these calls -- and from looking at what setID 
does, there could be some undesirable side effects.

-Phil
Index: ManagerBase.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
retrieving revision 1.16
diff -u -r1.16 ManagerBase.java
--- ManagerBase.java31 Dec 2002 03:45:48 -  1.16
+++ ManagerBase.java1 Jan 2003 00:37:30 -
@@ -584,7 +584,6 @@
 // @todo Move appending of jvmRoute generateSessionId()???
 if (jvmRoute != null) {
 sessionId += '.' + jvmRoute;
-session.setId(sessionId);
 }
 synchronized (sessions) {
 while (sessions.get(sessionId) != null){ // Guarantee uniqueness
@@ -592,7 +591,6 @@
 // @todo Move appending of jvmRoute generateSessionId()???
 if (jvmRoute != null) {
 sessionId += '.' + jvmRoute;
-session.setId(sessionId);
 }
 }
 }


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java

[Glenn Nielsen]

Remy Maucherat wrote:

Remy Maucherat wrote:


[EMAIL PROTECTED] wrote:


glenn   2002/12/31 06:01:17

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java 
Options.java
   jasper2/src/share/org/apache/jasper/compiler 
Compiler.java
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.



I didn't try it (but I was looking at that in the Ant docs after the 
posts in tomcat-user), but there seems to be redundency in Ant, as 
using "extJavac" as the compier name is supposed to do the same. Since 
changing the compiler name is already supported, maybe adding the fork 
parameter was not needed.


BTW, I just found that:

Windows Note:When the modern compiler is used in unforked mode on 
Windows, it locks up the files present in the classpath of the  
task, and does not release them. The side effect of this is that you 
will not be able to delete or move those files later on in the build. 
The workaround is to fork when invoking the compiler.



Right, I think I posted that in my original proposal.


So it could (finally) explain the mysterious JAR file locking on 
Windows. I think we should set to fork as the default; javac is just too 
risky to run in the same process ;-)


Thats fine with me.  Go for it. :-)

Glenn

--
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder|
MOREnet System Programming   |  * if iz ina coment.  |
Missouri Research and Education Network  |  */   |
--


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Questions related to a port of the IIS-connector to Domino I plan toprovide

[olaf . hahnl]

"Mladen Turk" <[EMAIL PROTECTED]> wrote on 30.12.2002 19:25:01:
>
> > >
> > > Looks to me like that you are using the wrong JVM.
> > >
> > The strange thing is, that this only happens when using
> > Domino 6 and not when using Domino 5 with the same JVM path
> > and DSAPI filter. I extracted the relevant code from
> > 'jk_jni_worker.c' and found the mentioned "JNI_CreateJavaVM"
> > call to be the problem. I tried it with JDK/JRE 1.3.1_06 and
> > JDK/JRE 1.4.1_01 and got the same results :( Can there be any
> > class-path or system-path related issues, which might be
> > handled different from Domino 5 to 6? Any other ideas or hints?
> >
>
> Seems that Domino 6 is using its own JVM (think that the one (IBM 1.3.1)
> comes with installation) and you have collision problem cause you are
> loading another JVM in the process.

You are right, from the Domino 6 Java directory and the jvm.dll I got this
string "J2RE 1.3.1 IBM Windows 32 build cn131-20020515". Domino 5.0.11 has
a javai.dll with the version string "1.1.8_008_Iris" in it.

> There could be a problem with that if Domino already loads JVM, cause
> you can load JVM only once per process.  We'll need to change some calls
> to JNI to attach to already created JVM. I'll try to do that (for JK2).

Ok, I understand what the problem is most likely. If I try to load the JVM
of Domino 6 I get the 'error', that the JVM already exists. If one would
use this JVM, the problem is that you may not have any or at least
restricted control over startup options (see below) and if, they must be
specified in notes.ini for example as JavaUserClasses with a limit of 255
chars. And what might be a problem too is that you are bound to the JDK
version which is delivered with Domino. But it would be much better this
way than not be able to use it at all, so I would appreciate! if you could
do/integrate this. (See below some code I would suggest for the problem of
discovering a loaded JVM for windows, what do you think?)

I looked into the documentation of notes.ini variables which allow to
configure the included JVM. There seems to be no documented way to set
custom options like -Dtomcat-home=... and so on. On the other hand you can
set the classpath and heap/stack sizes (for reference see
http://www-10.lotus.com/ldd/today.nsf/54dd141eed99bf278525697a00561a66/e94d1b96f50fce5685256af6006299da?OpenDocument
 and
http://www-10.lotus.com/ldd/today.nsf/54dd141eed99bf278525697a00561a66/2d5fefbb437a00256c410047a793?OpenDocument)

By the way: I changed my test code to create a JVM based on a JDK 1.1.8
which I have installed on my machine. That worked without any problems, but
obviously gets me nowhere. On the other hand under Domino 5 a JVM is also
already loaded when the connector is creating another JVM, but perhaps the
Domino JVM 1.1.8 is more "forgiving".

> Do you have some tools (like Process Explorer from SysInternals?) so you
> can tell if the JVM is already loaded and what is the version.

I used Process Explorer and found what I described in the sections above.
Domino 6 loads the JVM in "Lotus\Domino\jvm\bin" but Domino 5 loads JVM
(javai.dll) in its programm directory as well.

> MT.

Olaf

This code enumerates all moduls loaded by a process and if jvm.dll is found
gives back the complete path and filename. I have tested it shortly and it
did the job for me very well.

static char* findAlreadyLoadedJVM()
{
  static char jvm[MAX_PATH+1];
  HANDLE hSnapshot;
  MODULEENTRY32 lpme;
  BOOL err;

  // Create snapshot for all moduls loaded by the current process
  hSnapshot = CreateToolhelp32Snapshot(TH32CS_SNAPMODULE, 0);
  lpme.dwSize = sizeof(MODULEENTRY32);

  err = Module32First(hSnapshot, &lpme);
  while (err)
  {
// compare if modul-name is a loaded JVM
if (_stricmp("jvm.dll", lpme.szModule) == 0)
{
  // copy path and file-name, close handle and return jvm
  strcpy(jvm, lpme.szExePath);
  CloseHandle(hSnapshot);
  return jvm;
}
err = Module32Next(hSnapshot, &lpme);
  }
  CloseHandle(hSnapshot);

  // no loaded JVM found
  return NULL;
}



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Undefined symbol "ap_get_module_config"

[Raible, Matt]

I am trying to integrate the latest Apache version and Tomcat versions using
the AJP Connector and I'm getting the following error when I try to start
Apache:

Syntax error on line 1107 of /usr/local/etc/apache2/httpd.conf:
Cannot load /usr/local/libexec/apache2/mod_jk.so into server:
/usr/local/libexec/apache2/mod_jk.so: Undefined symbol
"ap_get_module_config"

Here are the specifics:
FreeBSD 4.7 i386
Apache 2.0.43 (from ports)
Tomcat 4.1.18 (binary download)

Linux compatibility
Sun Java 1.4.1 running in linux compatibility mode

>From httpd.conf
# Loading of JK objects
LoadModule jk_module libexec/apache2/mod_jk.so
JkWorkersFile conf/workers.properties 
JkLogFile logs/mod_jk.log
JkLogLevel info
JkMount /*.jsp loadbalancer 
JkMount /servlet/* loadbalancer

Using mod_jk2.0.42.so binary build for FreeBSD

Thanks,

Matt



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-catalina/webapps/docs jasper-howto.xml

[remm]

remm2002/12/31 06:48:44

  Modified:webapps/docs jasper-howto.xml
  Log:
  - Fix typo.
  
  Revision  ChangesPath
  1.3   +1 -1  jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml
  
  Index: jasper-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- jasper-howto.xml  31 Dec 2002 14:12:31 -  1.2
  +++ jasper-howto.xml  31 Dec 2002 14:48:44 -  1.3
  @@ -162,7 +162,7 @@
   true so that Ant compiles JSP pages in a seperate JVM.
   This removes the synchronization of JSP page compiles and prevents
   all the javac classes from being instantiated and subsequently garbage
  -collected by the JVM Tomcat is running in.
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/tomcat-docs jasper-howto.xml

[glenn]

glenn   2002/12/31 06:12:05

  Modified:.RELEASE-NOTES-4.1.txt
   catalina/src/conf web.xml
   webapps/tomcat-docs jasper-howto.xml
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.
  
  Revision  ChangesPath
  1.43  +5 -1  jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt
  
  Index: RELEASE-NOTES-4.1.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v
  retrieving revision 1.42
  retrieving revision 1.43
  diff -u -r1.42 -r1.43
  --- RELEASE-NOTES-4.1.txt 30 Dec 2002 16:06:09 -  1.42
  +++ RELEASE-NOTES-4.1.txt 31 Dec 2002 14:12:05 -  1.43
  @@ -157,6 +157,10 @@
   [4.1.8] JspCompilationContext:
   Use _ instead of $ to generate file and class names for jsp servlets.
   
  +[4.1.19] Compiler:
  + Added new "fork" option. This tells Ant to fork the JSP page javac
  + compile so that it is run in a different JVM from the one Tomcat
  + is running in. Please refer to the Jasper-HOWTO for more information.
   
   ==
   BUG FIXES AND IMPROVEMENTS:
  
  
  
  1.47  +4 -0  jakarta-tomcat-4.0/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/conf/web.xml,v
  retrieving revision 1.46
  retrieving revision 1.47
  diff -u -r1.46 -r1.47
  --- web.xml   27 Dec 2002 20:54:43 -  1.46
  +++ web.xml   31 Dec 2002 14:12:05 -  1.47
  @@ -115,6 +115,10 @@
 
 
 
  +  
  +  
  +  
  +  
 
 
 
  
  
  
  1.4   +11 -3 jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml
  
  Index: jasper-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/tomcat-docs/jasper-howto.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- jasper-howto.xml  28 Sep 2002 00:24:31 -  1.3
  +++ jasper-howto.xml  31 Dec 2002 14:12:05 -  1.4
  @@ -114,6 +114,10 @@
   Explorer when using  tags.   Default
   clsid:8AD9C840-044E-11D1-B3E9-00805F499D93.
   
  +fork - Have Ant fork JSP page compiles so they are
  +performed in a seperate JVM from Tomcat? true or
  +false, default false.
  +
   javaEncoding - Java file encoding to use for generating
   java source files. Default UTF8.
   
  @@ -152,9 +156,13 @@
   
   development - To enable background compilation of JSP
   pages set this to false.
  -compiler - The internal JVM javac compiler used by Ant
  -has a known memory leak.  If you anticipate that JSP pages will get recompiled
  -frequently consider using an external compiler such as jikes.
  +fork - The internal JVM javac compiler used by Ant
  +has a known memory leak. And Ant requires that java compiles be synchronized,
  +i.e. only one JSP page can be compiled at a time.  Set fork to
  +true so that Ant compiles JSP pages in a seperate JVM.
  +This removes the synchronization of JSP page compiles and prevents
  +all the javac classes from being instantiated and subsequently garbage
  +collected by the JVM Tomcat is running in.
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java

[Remy Maucherat]

Remy Maucherat wrote:

[EMAIL PROTECTED] wrote:


glenn   2002/12/31 06:01:17

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java Options.java
   jasper2/src/share/org/apache/jasper/compiler Compiler.java
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.



I didn't try it (but I was looking at that in the Ant docs after the 
posts in tomcat-user), but there seems to be redundency in Ant, as using 
"extJavac" as the compier name is supposed to do the same. Since 
changing the compiler name is already supported, maybe adding the fork 
parameter was not needed.

BTW, I just found that:

Windows Note:When the modern compiler is used in unforked mode on 
Windows, it locks up the files present in the classpath of the  
task, and does not release them. The side effect of this is that you 
will not be able to delete or move those files later on in the build. 
The workaround is to fork when invoking the compiler.


So it could (finally) explain the mysterious JAR file locking on 
Windows. I think we should set to fork as the default; javac is just too 
risky to run in the same process ;-)

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-catalina/webapps/docs jasper-howto.xml

[glenn]

glenn   2002/12/31 06:12:32

  Modified:catalina/src/conf web.xml
   webapps/docs jasper-howto.xml
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.
  
  Revision  ChangesPath
  1.10  +4 -0  jakarta-tomcat-catalina/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/web.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- web.xml   28 Dec 2002 01:39:38 -  1.9
  +++ web.xml   31 Dec 2002 14:12:31 -  1.10
  @@ -111,6 +111,10 @@
 
 
 
  +  
  +  
  +  
  +  
 
 
 
  
  
  
  1.2   +11 -3 jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml
  
  Index: jasper-howto.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/jasper-howto.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- jasper-howto.xml  16 Nov 2002 14:59:07 -  1.1
  +++ jasper-howto.xml  31 Dec 2002 14:12:31 -  1.2
  @@ -114,6 +114,10 @@
   Explorer when using  tags.   Default
   clsid:8AD9C840-044E-11D1-B3E9-00805F499D93.
   
  +fork - Have Ant fork JSP page compiles so they are
  +performed in a seperate JVM from Tomcat? true or
  +false, default false.
  +
   javaEncoding - Java file encoding to use for generating
   java source files. Default UTF8.
   
  @@ -152,9 +156,13 @@
   
   development - To enable background compilation of JSP
   pages set this to false.
  -compiler - The internal JVM javac compiler used by Ant
  -has a known memory leak.  If you anticipate that JSP pages will get recompiled
  -frequently consider using an external compiler such as jikes.
  +fork - The internal JVM javac compiler used by Ant
  +has a known memory leak. And Ant requires that java compiles be synchronized,
  +i.e. only one JSP page can be compiled at a time.  Set fork to
  +true so that Ant compiles JSP pages in a seperate JVM.
  +This removes the synchronization of JSP page compiles and prevents
  +all the javac classes from being instantiated and subsequently garbage
  +collected by the JVM Tomcat is running in.
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compilerCompiler.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:

glenn   2002/12/31 06:01:17

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java Options.java
   jasper2/src/share/org/apache/jasper/compiler Compiler.java
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.


I didn't try it (but I was looking at that in the Ant docs after the 
posts in tomcat-user), but there seems to be redundency in Ant, as using 
"extJavac" as the compier name is supposed to do the same. Since 
changing the compiler name is already supported, maybe adding the fork 
parameter was not needed.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java

[glenn]

glenn   2002/12/31 06:01:17

  Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java Options.java
   jasper2/src/share/org/apache/jasper/compiler Compiler.java
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.
  
  Revision  ChangesPath
  1.16  +21 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java
  
  Index: EmbededServletOptions.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- EmbededServletOptions.java8 Dec 2002 13:42:52 -   1.15
  +++ EmbededServletOptions.java31 Dec 2002 14:01:17 -  1.16
  @@ -91,6 +91,11 @@
   private boolean development = true;
   
   /**
  + * Should Ant fork its java compiles of JSP pages.
  + */
  +public boolean fork = false;
  +
  +/**
* Do you want to keep the generated Java files around?
*/
   private boolean keepGenerated = true;
  @@ -303,6 +308,10 @@
return javaEncoding;
   }
   
  +public boolean getFork() {
  +return fork;
  +}
  +
   public JspConfig getJspConfig() {
return jspConfig;
   }
  @@ -479,6 +488,15 @@
   String javaEncoding = config.getInitParameter("javaEncoding");
   if (javaEncoding != null) {
   this.javaEncoding = javaEncoding;
  +}
  +
  +String fork = config.getInitParameter("fork");
  +if (fork != null) {
  +if (fork.equalsIgnoreCase("true"))
  +this.fork = true;
  +else if (fork.equalsIgnoreCase("false"))
  +this.fork = false;
  +else Constants.message ("jsp.warning.fork", Logger.WARNING);
   }
   
// Setup the global Tag Libraries location cache for this
  
  
  
  1.20  +7 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- JspC.java 4 Dec 2002 00:48:42 -   1.19
  +++ JspC.java 31 Dec 2002 14:01:17 -  1.20
  @@ -311,6 +311,10 @@
return "UTF-8";
   }
   
  +public boolean getFork() {
  +return false;
  +}
  +
   public String getClassPath() {
   if( classPath != null )
   return classPath;
  
  
  
  1.11  +8 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java
  
  Index: Options.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- Options.java  4 Dec 2002 00:48:42 -   1.10
  +++ Options.java  31 Dec 2002 14:01:17 -  1.11
  @@ -170,6 +170,11 @@
   public String getJavaEncoding();
   
   /**
  + * boolean flag to tell Ant whether to fork JSP page compilations.
  + */
  +public boolean getFork();
  +
  +/**
* Obtain JSP configuration informantion specified in web.xml.  
*/
   public JspConfig getJspConfig();
  
  
  
  1.45  +6 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
  
  Index: Compiler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- Compiler.java 11 Dec 2002 07:51:20 -  1.44
  +++ Compiler.java 31 Dec 2002 14:01:17 -  1.45
  @@ -357,6 +357,7 @@
   javac.setDebug(ctxt.getOptions().getClassDebugInfo());
   javac.setSrcdir(srcPath);
   javac.setOptimize(! ctxt.getOptions().getClassDebugInfo() );
  +javac.setFork(ctxt.getOptions().getFork());
   info.append("srcDir=" + srcPath + "\n" );
   
   // Set the Java compiler to use
  @@ -372,8 +373,12 @@
   info.append("include="+ ctxt.getJspPath() + "\n" );
   
   try {
  -synchronized(javacLock) {
  +if (ctxt.getOptions().getFork()) {
   javac.execute();
  +} else {
  +synchronized(javacLock) {
  +javac.execute();
  +}
   }
   } catch (BuildException e) {
   l

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java

[glenn]

glenn   2002/12/31 06:00:36

  Modified:jasper2/src/share/org/apache/jasper Tag: tomcat_4_branch
EmbededServletOptions.java JspC.java Options.java
   jasper2/src/share/org/apache/jasper/compiler Tag:
tomcat_4_branch Compiler.java
  Log:
  Implement new Ant javac fork option.
  If set to true Ant forks a new process to compile JSP pages
  and does it without synchronization. Default is false.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.8.2.2   +21 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java
  
  Index: EmbededServletOptions.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
  retrieving revision 1.8.2.1
  retrieving revision 1.8.2.2
  diff -u -r1.8.2.1 -r1.8.2.2
  --- EmbededServletOptions.java8 Sep 2002 05:45:59 -   1.8.2.1
  +++ EmbededServletOptions.java31 Dec 2002 14:00:36 -  1.8.2.2
  @@ -89,6 +89,11 @@
   public boolean development = true;
   
   /**
  + * Should Ant fork its java compiles of JSP pages.
  + */
  +public boolean fork = false;
  +
  +/**
* Do you want to keep the generated Java files around?
*/
   public boolean keepGenerated = true;
  @@ -279,6 +284,10 @@
return javaEncoding;
   }
   
  +public boolean getFork() {
  +return fork;
  +}
  +
   /**
* Create an EmbededServletOptions object using data available from
* ServletConfig and ServletContext. 
  @@ -428,6 +437,15 @@
   String javaEncoding = config.getInitParameter("javaEncoding");
   if (javaEncoding != null) {
   this.javaEncoding = javaEncoding;
  +}
  +
  +String fork = config.getInitParameter("fork");
  +if (fork != null) {
  +if (fork.equalsIgnoreCase("true"))
  +this.fork = true;
  +else if (fork.equalsIgnoreCase("false"))
  +this.fork = false;
  +else Constants.message ("jsp.warning.fork", Logger.WARNING);
   }
   
// Setup the global Tag Libraries location cache for this
  
  
  
  1.12.2.3  +7 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.12.2.2
  retrieving revision 1.12.2.3
  diff -u -r1.12.2.2 -r1.12.2.3
  --- JspC.java 7 Nov 2002 08:46:53 -   1.12.2.2
  +++ JspC.java 31 Dec 2002 14:00:36 -  1.12.2.3
  @@ -303,6 +303,10 @@
return "UTF-8";
   }
   
  +public boolean getFork() {
  +return false;
  +}
  +
   public String getClassPath() {
   if( classPath != null )
   return classPath;
  
  
  
  1.6.2.1   +8 -3  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java
  
  Index: Options.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Options.java,v
  retrieving revision 1.6
  retrieving revision 1.6.2.1
  diff -u -r1.6 -r1.6.2.1
  --- Options.java  26 Jun 2002 16:50:38 -  1.6
  +++ Options.java  31 Dec 2002 14:00:36 -  1.6.2.1
  @@ -176,4 +176,9 @@
   public String getJavaEncoding();
   
   
  +/**
  + * boolean flag to tell Ant whether to fork JSP page compilations.
  + */
  +public boolean getFork();
  +
   }
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.18.2.9  +9 -4  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
  
  Index: Compiler.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
  retrieving revision 1.18.2.8
  retrieving revision 1.18.2.9
  diff -u -r1.18.2.8 -r1.18.2.9
  --- Compiler.java 10 Dec 2002 21:29:59 -  1.18.2.8
  +++ Compiler.java 31 Dec 2002 14:00:36 -  1.18.2.9
  @@ -288,6 +288,7 @@
   javac.setDebug(ctxt.getOptions().getClassDebugInfo());
   javac.setSrcdir(srcPath);
   javac.setOptimize(! ctxt.getOptions().getClassDebugInfo() );
  +javac.setFork(ctxt.getOptions().getFork());
   
   info.append("srcDir=" + srcPath + "\n" );
   
  @@ -304,8 +305,12 @@
   
   BuildException error=null;
   try {
  -synchronized(javacLock) {
  +if (ctxt.getOptions().getFork()) {
   javac.execute();
  +} else {
  +synchronize

Re: LocalStrings.properties

[Glenn Nielsen]

Thanks for reporting this. This has been fixed in all the property language files for the session.

Glenn

Leif Van Horn wrote:

Here is a patch for
catalina/src/share/org/apache/catalina/session/LocalStrings.properties
One of the lines is obviously not correct.  I beleive this is the
correct fix.

Thanks,
Leif Van Horn

diff -bruN tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
--- tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties	Wed Dec 11 03:46:36 2002
+++ tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties	Mon Dec 30 10:59:52 2002
@@ -44,7 +44,7 @@
 standardSession.notSerializable=Cannot serialize session attribute {0} for session {1}
 standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
 standardSession.sessionEvent=Session event listener threw exception
-standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
+standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
 standardSession.setAttribute.ise=setAttribute: Session already invalidated
 standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
 standardSession.sessionCreated=Created Session id = {0}




diff -bruN tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
--- tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties	Wed Dec 11 03:46:36 2002
+++ tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties	Mon Dec 30 10:59:52 2002
@@ -44,7 +44,7 @@
 standardSession.notSerializable=Cannot serialize session attribute {0} for session {1}
 standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
 standardSession.sessionEvent=Session event listener threw exception
-standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
+standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
 standardSession.setAttribute.ise=setAttribute: Session already invalidated
 standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
 standardSession.sessionCreated=Created Session id = {0}





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_fr.properties LocalStrings_ja.properties

[glenn]

glenn   2002/12/31 04:56:35

  Modified:catalina/src/share/org/apache/catalina/session
LocalStrings.properties LocalStrings_fr.properties
LocalStrings_ja.properties
  Log:
  Fix property names
  
  Revision  ChangesPath
  1.12  +1 -1  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings.properties,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- LocalStrings.properties   3 Jan 2002 08:52:57 -   1.11
  +++ LocalStrings.properties   31 Dec 2002 12:56:35 -  1.12
  @@ -44,7 +44,7 @@
   standardSession.notSerializable=Cannot serialize session attribute {0} for session 
{1}
   standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
   standardSession.sessionEvent=Session event listener threw exception
  -standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
  +standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
   standardSession.setAttribute.ise=setAttribute: Session already invalidated
   standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
   standardSession.sessionCreated=Created Session id = {0}
  
  
  
  1.2   +1 -1  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings_fr.properties
  
  Index: LocalStrings_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings_fr.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- LocalStrings_fr.properties6 Nov 2002 09:21:18 -   1.1
  +++ LocalStrings_fr.properties31 Dec 2002 12:56:35 -  1.2
  @@ -44,7 +44,7 @@
   standardSession.notSerializable=Impossible de sérialiser l''attribut de session {0} 
pour la session {1}
   standardSession.removeAttribute.ise="removeAttribute": Session déjà invalidée
   standardSession.sessionEvent=L''écouteur d''évènement de session (session event 
listener) a généré une exception
  -standardSession.setAttribute.ise="setAttribute": attribut non sérialisable
  +standardSession.setAttribute.iae="setAttribute": attribut non sérialisable
   standardSession.setAttribute.ise="setAttribute": Session déjà invalidée
   standardSession.setAttribute.namenull="setAttribute": le nom de paramètre ne peut 
être nul
   standardSession.sessionCreated=Création de l'Id de Session = {0}
  
  
  
  1.2   +1 -1  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings_ja.properties
  
  Index: LocalStrings_ja.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/LocalStrings_ja.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- LocalStrings_ja.properties13 Sep 2001 02:19:21 -  1.1
  +++ LocalStrings_ja.properties31 Dec 2002 12:56:35 -  1.2
  @@ -43,7 +43,7 @@
   standardSession.notSerializable=\u30bb\u30c3\u30b7\u30e7\u30f3 {1} 
\u306e\u305f\u3081\u306b\u30bb\u30c3\u30b7\u30e7\u30f3\u5c5e\u6027 {0} 
\u3092\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u307e\u305b\u3093
   standardSession.removeAttribute.ise=removeAttribute: 
\u30bb\u30c3\u30b7\u30e7\u30f3\u306f\u3059\u3067\u306b\u7121\u52b9\u5316\u3055\u308c\u3066\u3044\u307e\u3059
   
standardSession.sessionEvent=\u30bb\u30c3\u30b7\u30e7\u30f3\u30a4\u30d9\u30f3\u30c8\u30ea\u30b9\u30ca\u304c\u4f8b\u5916\u3092\u6295\u3052\u307e\u3057\u305f
  -standardSession.setAttribute.ise=setAttribute: 
\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u306a\u3044\u5c5e\u6027\u3067\u3059
  +standardSession.setAttribute.iae=setAttribute: 
\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u306a\u3044\u5c5e\u6027\u3067\u3059
   standardSession.setAttribute.ise=setAttribute: 
\u30bb\u30c3\u30b7\u30e7\u30f3\u306f\u3059\u3067\u306b\u7121\u52b9\u5316\u3055\u308c\u3066\u3044\u307e\u3059
   standardSession.setAttribute.namenull=setAttribute: 
name\u30d1\u30e9\u30e1\u30bf\u306fnull\u3067\u3042\u3063\u3066\u306f\u3044\u3051\u307e\u305b\u3093
   standardSession.sessionCreated=\u30bb\u30c3\u30b7\u30e7\u30f3ID = {0} 
\u3092\u751f\u6210\u3057\u307e\u3057\u305f
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

[glenn]

glenn   2002/12/31 04:55:21

  Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
  Log:
  oops, revert last change
  
  Revision  ChangesPath
  1.33  +5 -5  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java
  
  Index: StandardSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -r1.32 -r1.33
  --- StandardSession.java  31 Dec 2002 12:44:05 -  1.32
  +++ StandardSession.java  31 Dec 2002 12:55:21 -  1.33
  @@ -1237,7 +1237,7 @@
   if ((manager != null) && manager.getDistributable() &&
 !(value instanceof Serializable))
   throw new IllegalArgumentException
  -(sm.getString("standardSession.setAttribute.ise"));
  +(sm.getString("standardSession.setAttribute.iae"));
   
   // Replace or add this attribute
   Object unbound = null;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session LocalStrings.properties LocalStrings_fr.properties LocalStrings_ja.properties

[glenn]

glenn   2002/12/31 04:54:04

  Modified:catalina/src/share/org/apache/catalina/session
LocalStrings.properties LocalStrings_fr.properties
LocalStrings_ja.properties
  Log:
  Fix property names
  
  Revision  ChangesPath
  1.2   +1 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- LocalStrings.properties   18 Jul 2002 16:47:51 -  1.1
  +++ LocalStrings.properties   31 Dec 2002 12:54:04 -  1.2
  @@ -44,7 +44,7 @@
   standardSession.notSerializable=Cannot serialize session attribute {0} for session 
{1}
   standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
   standardSession.sessionEvent=Session event listener threw exception
  -standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
  +standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
   standardSession.setAttribute.ise=setAttribute: Session already invalidated
   standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
   standardSession.sessionCreated=Created Session id = {0}
  
  
  
  1.2   +1 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings_fr.properties
  
  Index: LocalStrings_fr.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings_fr.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- LocalStrings_fr.properties6 Nov 2002 09:23:37 -   1.1
  +++ LocalStrings_fr.properties31 Dec 2002 12:54:04 -  1.2
  @@ -44,7 +44,7 @@
   standardSession.notSerializable=Impossible de sérialiser l''attribut de session {0} 
pour la session {1}
   standardSession.removeAttribute.ise="removeAttribute": Session déjà invalidée
   standardSession.sessionEvent=L''écouteur d''évènement de session (session event 
listener) a généré une exception
  -standardSession.setAttribute.ise="setAttribute": attribut non sérialisable
  +standardSession.setAttribute.iae="setAttribute": attribut non sérialisable
   standardSession.setAttribute.ise="setAttribute": Session déjà invalidée
   standardSession.setAttribute.namenull="setAttribute": le nom de paramètre ne peut 
être nul
   standardSession.sessionCreated=Création de l'Id de Session = {0}
  
  
  
  1.2   +1 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings_ja.properties
  
  Index: LocalStrings_ja.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/LocalStrings_ja.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- LocalStrings_ja.properties18 Jul 2002 16:47:51 -  1.1
  +++ LocalStrings_ja.properties31 Dec 2002 12:54:04 -  1.2
  @@ -43,7 +43,7 @@
   standardSession.notSerializable=\u30bb\u30c3\u30b7\u30e7\u30f3 {1} 
\u306e\u305f\u3081\u306b\u30bb\u30c3\u30b7\u30e7\u30f3\u5c5e\u6027 {0} 
\u3092\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u307e\u305b\u3093
   standardSession.removeAttribute.ise=removeAttribute: 
\u30bb\u30c3\u30b7\u30e7\u30f3\u306f\u3059\u3067\u306b\u7121\u52b9\u5316\u3055\u308c\u3066\u3044\u307e\u3059
   
standardSession.sessionEvent=\u30bb\u30c3\u30b7\u30e7\u30f3\u30a4\u30d9\u30f3\u30c8\u30ea\u30b9\u30ca\u304c\u4f8b\u5916\u3092\u6295\u3052\u307e\u3057\u305f
  -standardSession.setAttribute.ise=setAttribute: 
\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u306a\u3044\u5c5e\u6027\u3067\u3059
  +standardSession.setAttribute.iae=setAttribute: 
\u30b7\u30ea\u30a2\u30e9\u30a4\u30ba\u3067\u304d\u306a\u3044\u5c5e\u6027\u3067\u3059
   standardSession.setAttribute.ise=setAttribute: 
\u30bb\u30c3\u30b7\u30e7\u30f3\u306f\u3059\u3067\u306b\u7121\u52b9\u5316\u3055\u308c\u3066\u3044\u307e\u3059
   standardSession.setAttribute.namenull=setAttribute: 
name\u30d1\u30e9\u30e1\u30bf\u306fnull\u3067\u3042\u3063\u3066\u306f\u3044\u3051\u307e\u305b\u3093
   standardSession.sessionCreated=\u30bb\u30c3\u30b7\u30e7\u30f3ID = {0} 
\u3092\u751f\u6210\u3057\u307e\u3057\u305f
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

[glenn]

glenn   2002/12/31 04:53:45

  Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
  Log:
  oops, revert last change
  
  Revision  ChangesPath
  1.10  +5 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
  
  Index: StandardSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- StandardSession.java  31 Dec 2002 12:48:24 -  1.9
  +++ StandardSession.java  31 Dec 2002 12:53:45 -  1.10
  @@ -1275,7 +1275,7 @@
   if ((manager != null) && manager.getDistributable() &&
 !(value instanceof Serializable))
   throw new IllegalArgumentException
  -(sm.getString("standardSession.setAttribute.ise"));
  +(sm.getString("standardSession.setAttribute.iae"));
   
   // Replace or add this attribute
   Object unbound = null;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

[glenn]

glenn   2002/12/31 04:48:24

  Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
  Log:
  Fix typo in LocalStrings property
  
  Revision  ChangesPath
  1.9   +5 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java
  
  Index: StandardSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- StandardSession.java  12 Dec 2002 15:11:53 -  1.8
  +++ StandardSession.java  31 Dec 2002 12:48:24 -  1.9
  @@ -1275,7 +1275,7 @@
   if ((manager != null) && manager.getDistributable() &&
 !(value instanceof Serializable))
   throw new IllegalArgumentException
  -(sm.getString("standardSession.setAttribute.iae"));
  +(sm.getString("standardSession.setAttribute.ise"));
   
   // Replace or add this attribute
   Object unbound = null;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session StandardSession.java

[glenn]

glenn   2002/12/31 04:44:05

  Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
  Log:
  Fix typo in LocalStrings property
  
  Revision  ChangesPath
  1.32  +5 -5  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java
  
  Index: StandardSession.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java,v
  retrieving revision 1.31
  retrieving revision 1.32
  diff -u -r1.31 -r1.32
  --- StandardSession.java  23 Jul 2002 12:49:11 -  1.31
  +++ StandardSession.java  31 Dec 2002 12:44:05 -  1.32
  @@ -1237,7 +1237,7 @@
   if ((manager != null) && manager.getDistributable() &&
 !(value instanceof Serializable))
   throw new IllegalArgumentException
  -(sm.getString("standardSession.setAttribute.iae"));
  +(sm.getString("standardSession.setAttribute.ise"));
   
   // Replace or add this attribute
   Object unbound = null;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[Fwd: tomcat/apache connector startup failure: NCDFE fprorg/apache/commons/logging/LogFactory]

[Lacoste (Frisurf)]

Forwarding this to the dev list as it seems to be a problem with tomcat.

Cheers,

J.

--- Begin Message ---
Having trouble to make ajp13 connector work (jk2 with Apache 2).

Tomcat fails connecting initializing with the following error:

SEVERE: Can't create apr
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory

As a consequence of this problem (I think it is related), I cannot
access the dynamic pages from apache. Tomcat works great
(http://localhost:8080/examples/) while http://localhost/examples/
returns a 500 Error (Connection refused on port 8019 - errno 111).

(nb: I modified the default port to be 8019 instead of 8009).

I've tried several variations of the jk2.properties and
workers2.properties without success. Spent a lot of time on the mailing
lists archives without success neither.

I moved the commons-logging.jar from $TOMCAT/server/lib/ to
$TOMCAT/common/lib as advised in some mails. This didn't work.
Even if if had worked, it seems it would have been  inapropriate:
see http://issues.apache.org/bugzilla/show_bug.cgi?id=13689

I also used the attached jsp deployed in $TOMCAT/webapps/ROOT to see the
CLASSPATH which is outputed as 
  /usr/local/java/lib/tools.jar:/opt/tomcat/bin/bootstrap.jar
which seems normal to me.

I didn't try to modify the CLASSPATH in catalina.sh as it doesn't seem
like the correct thing to do neither. 

It seems like this is a ClassLoader problem. If there is a way to enable
debugging for the class loader, I am also interested. I found this: 
http://jakarta.apache.org/tomcat/tomcat-4.1-doc/config/loader.html
But didn't find yet how to use it.

It seems that I am not the only one to have had this problem. I spent
already too much time on it so I will accept any idea/hints on how to
make this work. 

I am using 
- linux OS (Mandrake 9.0)
- JDK 1.4.1_01-b01
- tomcat-4.1.18-LE-jdk14.jar
- jakarta-tomcat-connectors-4.1.18-src.tar.gz
- Apache 2.0.43 

Error details:

INFO: Starting Coyote HTTP/1.1 on port 8080
Dec 30, 2002 8:58:03 PM org.apache.jk.server.JkMain newHandler
SEVERE: Can't create apr
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
at org.apache.jk.apr.AprImpl.(AprImpl.java:340)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:140)
at org.apache.jk.server.JkMain.newHandler(JkMain.java:556)
at org.apache.jk.server.JkMain.start(JkMain.java:341)
at org.apache.jk.server.JkCoyoteHandler.start(JkCoyoteHandler.java:169)
at
org.apache.coyote.tomcat4.CoyoteConnector.start(CoyoteConnector.java:1056)
at
org.apache.catalina.core.StandardService.start(StandardService.java:506)
at
org.apache.catalina.core.StandardServer.start(StandardServer.java:2189)
at org.apache.catalina.startup.Catalina.start(Catalina.java:512)
at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)
Dec 30, 2002 8:58:03 PM org.apache.jk.common.ChannelSocket init
INFO: JK2: ajp13 listening on /0.0.0.0:8009
Dec 30, 2002 8:58:03 PM org.apache.jk.server.JkMain start
INFO: Jk running ID=0 time=2/239  config=/opt/tomcat/conf/jk2.properties



-- 
Jerome Lacoste (Frisurf) <[EMAIL PROTECTED]>
CoffeeBreaks


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 
--- End Message ---
--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 15735] New: - Misspelling in french

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15735

Misspelling in french

   Summary: Misspelling in french
   Product: Tomcat 3
   Version: 3.1.1 Final
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The error 404 in french have a misspelling.

Introuvabble -> Introuvable

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

LocalStrings.properties

[Leif Van Horn]

Here is a patch for
catalina/src/share/org/apache/catalina/session/LocalStrings.properties
One of the lines is obviously not correct.  I beleive this is the
correct fix.

Thanks,
Leif Van Horn

diff -bruN 
tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
 
tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
--- 
tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
Wed Dec 11 03:46:36 2002
+++ 
+tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
+ Mon Dec 30 10:59:52 2002
@@ -44,7 +44,7 @@
 standardSession.notSerializable=Cannot serialize session attribute {0} for session {1}
 standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
 standardSession.sessionEvent=Session event listener threw exception
-standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
+standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
 standardSession.setAttribute.ise=setAttribute: Session already invalidated
 standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
 standardSession.sessionCreated=Created Session id = {0}

diff -bruN 
tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
 
tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
--- 
tomcat4-4.1.17.orig/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
Wed Dec 11 03:46:36 2002
+++ 
+tomcat4-4.1.17/jakarta-tomcat-4.1.17-src/catalina/src/share/org/apache/catalina/session/LocalStrings.properties
+ Mon Dec 30 10:59:52 2002
@@ -44,7 +44,7 @@
 standardSession.notSerializable=Cannot serialize session attribute {0} for session {1}
 standardSession.removeAttribute.ise=removeAttribute: Session already invalidated
 standardSession.sessionEvent=Session event listener threw exception
-standardSession.setAttribute.ise=setAttribute: Non-serializable attribute
+standardSession.setAttribute.iae=setAttribute: Non-serializable attribute
 standardSession.setAttribute.ise=setAttribute: Session already invalidated
 standardSession.setAttribute.namenull=setAttribute: name parameter cannot be null
 standardSession.sessionCreated=Created Session id = {0}


--
To unsubscribe, e-mail:   
For additional commands, e-mail: