Re: Duplicate session IDs are *common*

2003-01-08 Thread Craig R. McClanahan


On Wed, 8 Jan 2003, Aditya wrote:

> Date: Wed, 08 Jan 2003 22:36:58 -0800
> From: Aditya <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: Tomcat Developers List <[EMAIL PROTECTED]>
> Subject: Re: Duplicate session IDs are *common*
>
> > On Wed, 08 Jan 2003 19:37:28 -0800, Costin Manolache <[EMAIL PROTECTED]> said:
> > The default is java.security.SecureRandom - and should give enough
> > randomness. There is a change on head ( that would work with 5.0 -
> > but it can be backported ) that allow you to use /dev/urandom ( or
> > another source - it can be a pipe or something like that ).
>
> what about "hashing" the random part with System.currentTimeMillis()
> so that even the vanishingly small probability of a collision is
> avoided?  Or would that be too expensive?
>

The better check is the one that has been implemented -- if whatever
session id you just calculated (for a new session) is already in use, pick
another one.

> Adi

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Duplicate session IDs are *common*

2003-01-08 Thread Aditya
> On Wed, 08 Jan 2003 19:37:28 -0800, Costin Manolache <[EMAIL PROTECTED]> said:
> The default is java.security.SecureRandom - and should give enough
> randomness. There is a change on head ( that would work with 5.0 -
> but it can be backported ) that allow you to use /dev/urandom ( or
> another source - it can be a pipe or something like that ).

what about "hashing" the random part with System.currentTimeMillis()
so that even the vanishingly small probability of a collision is
avoided?  Or would that be too expensive?

Adi

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Duplicate session IDs are *common*

2003-01-08 Thread Craig R. McClanahan


On Wed, 8 Jan 2003, Costin Manolache wrote:

> Date: Wed, 08 Jan 2003 19:37:28 -0800
> From: Costin Manolache <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Re: Duplicate session IDs are *common*
>
> Schnitzer, Jeff wrote:
>
> > For whatever reason, be it the seed algorithm or the hashing algorithm
> > or something else that degenerates the randomness - the duplicate
> > session ID problem is very, very common.
> >
> > I discovered this problem because a few of our users suddenly found
> > themselves with the sessions from administrative accounts.  Luckily they
> > alerted us instead of causing mayhem.  There were at least three
> > separate occasions of this in the last week - that we heard about.
> >
> > We have also seen this a number of times with other game components -
> > users suddenly finding themselves logged in as other people.
> >
> > It probably explains the recent post to tomcat-user included below.
> >
> > Here at my company this problem caused about as much panic as a wildfire
> > breaking out in the machine room (read: LOTS).  I humbly suggest raising
> > the level of concern a bit; post a security bulletin, etc.
>
> What version of tomcat ? Are you on Linux ? What randomClass are you using ?
> How many sessions are usually generated ?
>
> The default is java.security.SecureRandom - and should give enough
> randomness. There is a change on head ( that would work with 5.0 - but
> it can be backported ) that allow you to use /dev/urandom ( or another
> source - it can be a pipe or something like that ).
>

Even though duplicate session ids are *possible* (because Tomcat doesn't
check for it), the 99.9% cause of this kind of a problem is application
programming errors like using an instance (or static) variable in a
servlet to store per-request state information.  That only works if the
servlet never processes more than one request at a time.  Based on my
experience, I don't believe this is a *common* problem, but it is a
problem that needs to be addressed.

>
> Costin
>

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Duplicate session IDs are *common*

2003-01-08 Thread Costin Manolache
Schnitzer, Jeff wrote:

> For whatever reason, be it the seed algorithm or the hashing algorithm
> or something else that degenerates the randomness - the duplicate
> session ID problem is very, very common.
> 
> I discovered this problem because a few of our users suddenly found
> themselves with the sessions from administrative accounts.  Luckily they
> alerted us instead of causing mayhem.  There were at least three
> separate occasions of this in the last week - that we heard about.
> 
> We have also seen this a number of times with other game components -
> users suddenly finding themselves logged in as other people.
> 
> It probably explains the recent post to tomcat-user included below.
> 
> Here at my company this problem caused about as much panic as a wildfire
> breaking out in the machine room (read: LOTS).  I humbly suggest raising
> the level of concern a bit; post a security bulletin, etc.

What version of tomcat ? Are you on Linux ? What randomClass are you using ?
How many sessions are usually generated ?

The default is java.security.SecureRandom - and should give enough 
randomness. There is a change on head ( that would work with 5.0 - but
it can be backported ) that allow you to use /dev/urandom ( or another
source - it can be a pipe or something like that ). 


Costin




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Duplicate session IDs are *common*

2003-01-08 Thread Schnitzer, Jeff
For whatever reason, be it the seed algorithm or the hashing algorithm
or something else that degenerates the randomness - the duplicate
session ID problem is very, very common.

I discovered this problem because a few of our users suddenly found
themselves with the sessions from administrative accounts.  Luckily they
alerted us instead of causing mayhem.  There were at least three
separate occasions of this in the last week - that we heard about.

We have also seen this a number of times with other game components -
users suddenly finding themselves logged in as other people.

It probably explains the recent post to tomcat-user included below.

Here at my company this problem caused about as much panic as a wildfire
breaking out in the machine room (read: LOTS).  I humbly suggest raising
the level of concern a bit; post a security bulletin, etc.

Jeff Schnitzer
[EMAIL PROTECTED]
The Sims Online


> -Original Message-
> From: Michael Molloy [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, January 08, 2003 2:13 PM
> To: Tomcat Users List
> Subject: One other freaky thing
> 
> Our application is running on a server in Pennsylvania. A user there
> was working as well as a user in Tennessee. The user in Tennessee got
> an error on a page, hit her back key, and the user in Pennsylvania's
> screen showed up on the Tennessee user's screen.  The people in
> Tennessee are connected to the Pennsylvania system via a frame relay.
> 
> Everything is contained within each user's session, so this should
> never happen. The application has been under development for a year
> now, and this has never happened before.
> 
> Some kind of weird bug that we shouldn't worry about, or something
that
> someone else has encountered?
> 
> Thanks for any help,
> --Michael Molloy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15845] - Memory Leak when compiling JSP

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15845

Memory Leak when compiling JSP





--- Additional Comments From [EMAIL PROTECTED]  2003-01-09 00:06 ---
I added the Jasper 2 fork init parameter to both the Tomcat 4.1 branch
and the Tomcat 5 branch.  So it will be available in the Tomcat 4.1.19 release.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin TreeControlTag.java

2003-01-08 Thread amyroh
amyroh  2003/01/08 15:39:48

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
TreeControlTag.java
  Log:
  Provide alt attribute for images for section 508 accessibility improvement.
  
  Revision  ChangesPath
  1.2   +9 -5  
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TreeControlTag.java
  
  Index: TreeControlTag.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TreeControlTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- TreeControlTag.java   18 Jul 2002 16:48:22 -  1.1
  +++ TreeControlTag.java   8 Jan 2003 23:39:48 -   1.2
  @@ -382,7 +382,7 @@
   out.print(images);
   out.print("/");
   out.print(IMAGE_LINE_VERTICAL);
  -out.print("\" border=\"0\">");
  +out.print("\" alt=\"\" border=\"0\">");
   }
   out.println();
   }
  @@ -418,16 +418,19 @@
   out.print(IMAGE_LINE_LAST);
   else
   out.print(IMAGE_LINE_MIDDLE);
  +out.print("\" alt=\"");
   } else if (node.isExpanded()) {
   if (node.isLast())
   out.print(IMAGE_HANDLE_DOWN_LAST);
   else
   out.print(IMAGE_HANDLE_DOWN_MIDDLE);
  +out.print("\" alt=\"close node");
   } else {
   if (node.isLast())
   out.print(IMAGE_HANDLE_RIGHT_LAST);
   else
   out.print(IMAGE_HANDLE_RIGHT_MIDDLE);
  +out.print("\" alt=\"expand node");
   }
   out.print("\" border=\"0\">");
   if ((action != null) && !node.isLeaf())
  @@ -465,6 +468,7 @@
   out.print(images);
   out.print("/");
   out.print(node.getIcon());
  +out.print("\" alt=\"");
   out.print("\" border=\"0\">");
   if (hyperlink != null)
   out.print("");
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin TreeControlTag.java

2003-01-08 Thread amyroh
amyroh  2003/01/08 15:39:02

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
TreeControlTag.java
  Log:
  Provide alt attribute for images for section 508 accessibility improvement.
  
  Revision  ChangesPath
  1.8   +9 -5  
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TreeControlTag.java
  
  Index: TreeControlTag.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/TreeControlTag.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- TreeControlTag.java   13 Mar 2002 20:09:55 -  1.7
  +++ TreeControlTag.java   8 Jan 2003 23:39:01 -   1.8
  @@ -382,7 +382,7 @@
   out.print(images);
   out.print("/");
   out.print(IMAGE_LINE_VERTICAL);
  -out.print("\" border=\"0\">");
  +out.print("\" alt=\"\" border=\"0\">");
   }
   out.println();
   }
  @@ -418,16 +418,19 @@
   out.print(IMAGE_LINE_LAST);
   else
   out.print(IMAGE_LINE_MIDDLE);
  +out.print("\" alt=\"");
   } else if (node.isExpanded()) {
   if (node.isLast())
   out.print(IMAGE_HANDLE_DOWN_LAST);
   else
   out.print(IMAGE_HANDLE_DOWN_MIDDLE);
  +out.print("\" alt=\"close node");
   } else {
   if (node.isLast())
   out.print(IMAGE_HANDLE_RIGHT_LAST);
   else
   out.print(IMAGE_HANDLE_RIGHT_MIDDLE);
  +out.print("\" alt=\"expand node");
   }
   out.print("\" border=\"0\">");
   if ((action != null) && !node.isLeaf())
  @@ -465,6 +468,7 @@
   out.print(images);
   out.print("/");
   out.print(node.getIcon());
  +out.print("\" alt=\"");
   out.print("\" border=\"0\">");
   if (hyperlink != null)
   out.print("");
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[PATCH] jakarta-servletapi-5

2003-01-08 Thread Mark Roth
Attached are some fixes leading up to our second proposed final draft 
release of the specification.  Please let me know if there are any 
questions or concerns.

jsr152/src/share/dtd/jsp_2_0.xsd
  - Updated comments for jsp-property-groupType

jsr154/src/share/dtd/jsp_2_0.xsd
  - Updated comments for jsp-property-groupType

jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java
  - Fixed typo: 'the the'

jsr152/src/share/javax/servlet/jsp/tagext/VariableInfo.java
  - Fixed typo: 'AT_NESTED' --> 'NESTED'
  - Fixed table - AT_BEGIN and NESTED should be synchronized
after doStartTag() if EVAL_BODY_INCLUDE is returned.

---
Mark Roth, Java Software
JSP 2.0 Co-Specification Lead
Sun Microsystems, Inc.
? jsr152/src/share/javax/servlet/jsp/JspException.class
? jsr152/src/share/javax/servlet/jsp/JspWriter.class
? jsr152/src/share/javax/servlet/jsp/.nbattrs
? jsr152/src/share/javax/servlet/jsp/tagext/SimpleTag.class
Index: jsr152/src/share/dtd/jsp_2_0.xsd
===
RCS file: /home/cvspublic/jakarta-servletapi-5/jsr152/src/share/dtd/jsp_2_0.xsd,v
retrieving revision 1.5
diff -u -r1.5 jsp_2_0.xsd
--- jsr152/src/share/dtd/jsp_2_0.xsd8 Nov 2002 21:30:20 -   1.5
+++ jsr152/src/share/dtd/jsp_2_0.xsd8 Jan 2003 22:42:10 -
@@ -8,7 +8,7 @@
  version="2.0">
 
 
-@(#)jsp_2_0.xsds   1.14 11/06/02
+@(#)jsp_2_0.xsds   1.15 01/02/03
 
 
 
@@ -136,10 +136,10 @@
 All files so described are deemed to be JSP files.  The
 following additional properties can be described:
 
-- Control enabling of EL evaluation.
-- Control enabling of Scripting elements.
+- Control whether EL is ignored
+- Control whether scripting elements are invalid
 - Indicate pageEncoding information.
-- Indicating that a resource is a JSP document
+- Indicate that a resource is a JSP document (XML)
 - Prelude and Coda automatic includes.
 
 
Index: jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java
===
RCS file: 
/home/cvspublic/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java,v
retrieving revision 1.4
diff -u -r1.4 TagInfo.java
--- jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java  4 Nov 2002 17:44:24 
-   1.4
+++ jsr152/src/share/javax/servlet/jsp/tagext/TagInfo.java  8 Jan 2003 22:42:10 
+-
@@ -268,7 +268,7 @@
  *
  * @param data TagData describing this action.
  * @return if a TagExtraInfo object is associated with this TagInfo, the
- * the result of getTagExtraInfo().getVariableInfo( data ), otherwise
+ * result of getTagExtraInfo().getVariableInfo( data ), otherwise
  * null if the tag has no "id" attribute or new VariableInfo[] {
  * new VariableInfo( data.getId(), "java.lang.Object", true,
  * VariableInfo.NESTED ) } if an "id" attribute is present.
Index: jsr152/src/share/javax/servlet/jsp/tagext/VariableInfo.java
===
RCS file: 
/home/cvspublic/jakarta-servletapi-5/jsr152/src/share/javax/servlet/jsp/tagext/VariableInfo.java,v
retrieving revision 1.6
diff -u -r1.6 VariableInfo.java
--- jsr152/src/share/javax/servlet/jsp/tagext/VariableInfo.java 18 Dec 2002 18:35:37 
-  1.6
+++ jsr152/src/share/javax/servlet/jsp/tagext/VariableInfo.java 8 Jan 2003 22:42:10 
+-
@@ -193,9 +193,9 @@
  *   
  * BodyTag
  * 
- * 
+ * AT_BEGIN, 
+NESTED1
  * 
- * AT_BEGIN, AT_NESTED
+ * AT_BEGIN, 
+NESTED1
  * 
  * AT_BEGIN, NESTED
  * 
@@ -220,6 +220,9 @@
  *   
  * 
  * 
+ * 1 Called after doStartTag() if 
+ * EVAL_BODY_INCLUDE is returned, or after 
+ * doInitBody() otherwise.
  * 
  *
  * Variable Information in the TLD
Index: jsr154/src/share/dtd/jsp_2_0.xsd
===
RCS file: /home/cvspublic/jakarta-servletapi-5/jsr154/src/share/dtd/jsp_2_0.xsd,v
retrieving revision 1.5
diff -u -r1.5 jsp_2_0.xsd
--- jsr154/src/share/dtd/jsp_2_0.xsd8 Nov 2002 21:30:21 -   1.5
+++ jsr154/src/share/dtd/jsp_2_0.xsd8 Jan 2003 22:42:11 -
@@ -8,7 +8,7 @@
  version="2.0">
 
 
-@(#)jsp_2_0.xsds   1.14 11/06/02
+@(#)jsp_2_0.xsds   1.15 01/02/03
 
 
 
@@ -136,10 +136,10 @@
 All files so described are deemed to be JSP files.  The
 following additional properties can be described:
 
-- Control enabling of EL evaluation.
-- Control enabling of Scripting elements.
+- Control whether EL is ignored
+- Control whether scripting elements are invalid
 - Indicate pageEncoding information.
-- Indicating that a resource is a JSP document
+- Indicate that a resource is a JSP document (XML)
 - Prelude and Coda automatic includes.
 
 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-08 Thread luehe
luehe   2003/01/08 14:24:29

  Modified:jasper2/src/share/org/apache/jasper/compiler Tag:
tomcat_4_branch Generator.java
  Log:
  Applied patch provided by Dimitry Ivanov to fix synchronization of
  AT_BEGIN and NESTED variables for tag handlers implementing BodyTag
  whose doStartTag() returns EVAL_BODY_INCLUDE
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.35.2.14 +6 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.35.2.13
  retrieving revision 1.35.2.14
  diff -u -r1.35.2.13 -r1.35.2.14
  --- Generator.java22 Nov 2002 23:47:31 -  1.35.2.13
  +++ Generator.java8 Jan 2003 22:24:28 -   1.35.2.14
  @@ -1376,12 +1376,13 @@
out.printin(tagHandlerVar);
out.println(".doInitBody();");
   
  + out.popIndent();
  + out.printil("}");
  +
// Synchronize AT_BEGIN and NESTED scripting variables
syncScriptingVars(n, VariableInfo.AT_BEGIN);
syncScriptingVars(n, VariableInfo.NESTED);

  - out.popIndent();
  - out.printil("}");
} else {
// Synchronize NESTED scripting variables
syncScriptingVars(n, VariableInfo.NESTED);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java

2003-01-08 Thread luehe
luehe   2003/01/08 14:15:57

  Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
  Log:
  Applied patch provided by Dimitry Ivanov to fix synchronization of
  AT_BEGIN and NESTED variables for tag handlers implementing BodyTag
  whose doStartTag() returns EVAL_BODY_INCLUDE
  
  Revision  ChangesPath
  1.146 +6 -5  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.145
  retrieving revision 1.146
  diff -u -r1.145 -r1.146
  --- Generator.java8 Jan 2003 18:42:42 -   1.145
  +++ Generator.java8 Jan 2003 22:15:56 -   1.146
  @@ -1980,12 +1980,13 @@
out.printin(tagHandlerVar);
out.println(".doInitBody();");
   
  + out.popIndent();
  + out.printil("}");
  +
// Synchronize AT_BEGIN and NESTED scripting variables
syncScriptingVars(n, VariableInfo.AT_BEGIN);
syncScriptingVars(n, VariableInfo.NESTED);
   
  - out.popIndent();
  - out.printil("}");
} else {
// Synchronize NESTED scripting variables
syncScriptingVars(n, VariableInfo.NESTED);
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag

2003-01-08 Thread Jan Luehe
Dimitry:

> And JSP.10.5.9:
> "The scope value for a variable implies what methods may affect its
> value and thus
> where synchronization is needed:
>  - for NESTED, after doInitBody and doAfterBody for a tag handler
> implementing
> BodyTag, and after doStartTag otherwise.
>  - for AT_BEGIN, after doInitBody, doAfterBody, and doEndTag for a tag
> handler implementing BodyTag, and doStartTag and doEndTag otherwise."
> 
> There is nothing about synchronization *only* when doInitBody has
> *invoked*.

Actually, the above has been too simplistic, because it does not consider the
case where BodyTag.doStartTag() returns EVAL_BODY_INCLUDE and
doInitBody() is not called, giving the container no opportunity to
synchronize the variables before the body of the tag.

I've talked to the JSP 2.0 spec lead, who is going to clarify the spec
as you suggested.

I've also applied your latest patch.

Thanks!


Jan



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: ClassLoader problems

2003-01-08 Thread Costin Manolache
Once again - debugging it is close to impossible ( just like most 
classloader problems), but luckily I guessed how to fix it - just 
remove the "endorsed" property and it works again...

What "endorsed dirs" has to do with ActionHook - I don't know.

Costin

Costin Manolache wrote:

> Ok, that's another really strange JDK1.4 problem. I hate class loaders.
> 
> It works perfectly fine with JDK1.3 - but fails with JDK1.4.1.
> 
> Needless to say - tomcat-coyote is in lib, and if I enable -verbose:class
> it actually displays a line showing ActionHook is loaded - only to throw
> the exception few lines down.
> 
> Any idea ? I get this with 4.1 head and also with 5.0 ( but in 5.0 I may
> have a strange env - that's why I tested with a clean 4.1 head )
> 
> Java is 1.4.1_01-b01 on linux.
>  
> Costin
> 
> 
> The exception is:
> Using CATALINA_BASE:   /ws/41/dist
> Using CATALINA_HOME:   /ws/41/dist
> Using CATALINA_TMPDIR: /ws/41/dist/temp
> Using JAVA_HOME:   /usr/java/jdk14
> /usr/java/jdk14/bin/java
> -Djava.endorsed.dirs=/ws/41/dist/bin:/ws/41/dist/common/endorsed
> -classpath /usr/java/jdk14/lib/tools.jar:/ws/41/dist/bin/bootstrap.jar
> -Dcatalina.base=/ws/41/dist -Dcatalina.home=/ws/41/dist
> -Djava.io.tmpdir=/ws/41/dist/temp org.apache.catalina.startup.Bootstrap
> start
> Exception during startup processing
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 
> at
> 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 
> at
> 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:324)
> at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)
> Caused by: java.lang.NoClassDefFoundError: org/apache/coyote/ActionHook
> at java.lang.ClassLoader.findBootstrapClass(Native Method)
> at java.lang.ClassLoader.findBootstrapClass0(ClassLoader.java:723)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:294)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:292)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:265)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:255)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:941)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:941)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)
> at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
> at java.lang.ClassLoader.defineClass0(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:502)
> at
> 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:250) at
> java.net.URLClassLoader.access$100(URLClassLoader.java:54) at
> java.net.URLClassLoader$1.run(URLClassLoader.java:193) at
> java.security.AccessController.doPrivileged(Native Method) at
> java.net.URLClassLoader.findClass(URLClassLoader.java:186)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.findClass(StandardClassLoader.java:621)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:958)
> 
> at
> 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)
> at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:140)
> 
> at
> 
org.apache.coyote.tomcat4.CoyoteConnector.initialize(CoyoteConnector.java:1016)
> 
> at
> 
org.apache.catalina.core.StandardService.initialize(StandardService.java:579)
> 
> at
> 
org.apache.catalina.core.StandardServer.initialize(StandardServer.java:2246)
> at org.apache.catalina.startup.Catalina.start(Catalina.java:511)
> at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
> at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
> ... 5 more



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: JMX-RI-1.2 problems

2003-01-08 Thread Costin Manolache
Amy Roh wrote:


> If you need new additions and fixes in JMX1.2, then switching to 1.2
> sounds
> good to me.  What other changes are needed to make it work with JMX1.2?  I
> can volunteer to make the changes (especially in mbeans-descriptors.xml)
> if you point me to the list of changes.

The build file and changing the [] seems to be all.

I'm not sure how to best deal with the download, and I assume few build
files or properties need to change.

Let me know if you see additional problems - I have it running ( but
I have a modified modeler and a lot of other changes in my ws ). 

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15892] - Incorrect decoding of URL for getPathInfo()

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15892

Incorrect decoding of URL for getPathInfo()

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 21:37 ---
The '+' character only should be decoded to ' ' in the query string.  In the 
PathInfo, it should be left alone.  See RFC 2396 for more info.

In the PathInfo, the ' ' character should be encoded as %20.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: JMX-RI-1.2 problems

2003-01-08 Thread Amy Roh
> You may have noticed - tomcat doesn't work with JMX 1.2
> The main problem is that the spec now requires the type to be
> JNI-style ( [Ljava.lang.String; instead of java.lang.String[] ).
> That would require a change in mbeans-descriptos.xml - but I'm
> not sure if mx4j would still work after that.
>
> There are also some additions and fixes in JMX1.2 we may need
> ( like sending the attribute change notifications to all listeners -
> that works in jboss-jmx, but not in mx4j and jmx1.1-ri ).
>
> Should we switch to ri-1.2 until MX4J finishes the update to
> 1.2 ?
>
> The license seems more relaxed now - so we may be able to redistribute
> it without problems. Obviously MX4J should be preffered for the
> release.

If you need new additions and fixes in JMX1.2, then switching to 1.2 sounds
good to me.  What other changes are needed to make it work with JMX1.2?  I
can volunteer to make the changes (especially in mbeans-descriptors.xml) if
you point me to the list of changes.

Amy
>
> Opinions ? Volunteers :-) ?
>
> Costin
>
>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15904] New: - UnsupportedEncodingException not thrown if invalid charset (from content type) is set and a call to ServletResponse.getWriter() is made.

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15904

UnsupportedEncodingException not thrown if invalid charset (from content type) is set 
and a call to ServletResponse.getWriter() is made.

   Summary: UnsupportedEncodingException not thrown if invalid
charset (from content type) is set and a call to
ServletResponse.getWriter() is made.
   Product: Tomcat 5
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


According the the javadocs for Servletrespons.getWriter():
  - "java.io.UnsupportedEncodingException - if the charset specified in
setContentType cannot be used"

The following code doesn't cause the UnsupportedEncodingException to be thrown:

response.setContentType("text/html; charset=invalid-charset");
response.getWriter();

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




ClassLoader problems

2003-01-08 Thread Costin Manolache
Ok, that's another really strange JDK1.4 problem. I hate class loaders.

It works perfectly fine with JDK1.3 - but fails with JDK1.4.1.

Needless to say - tomcat-coyote is in lib, and if I enable -verbose:class
it actually displays a line showing ActionHook is loaded - only to throw the
exception few lines down.

Any idea ? I get this with 4.1 head and also with 5.0 ( but in 5.0 I may
have a strange env - that's why I tested with a clean 4.1 head )

Java is 1.4.1_01-b01 on linux.
 
Costin


The exception is:
Using CATALINA_BASE:   /ws/41/dist
Using CATALINA_HOME:   /ws/41/dist
Using CATALINA_TMPDIR: /ws/41/dist/temp
Using JAVA_HOME:   /usr/java/jdk14
/usr/java/jdk14/bin/java 
-Djava.endorsed.dirs=/ws/41/dist/bin:/ws/41/dist/common/endorsed -classpath 
/usr/java/jdk14/lib/tools.jar:/ws/41/dist/bin/bootstrap.jar 
-Dcatalina.base=/ws/41/dist -Dcatalina.home=/ws/41/dist 
-Djava.io.tmpdir=/ws/41/dist/temp org.apache.catalina.startup.Bootstrap 
start
Exception during startup processing
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:203)
Caused by: java.lang.NoClassDefFoundError: org/apache/coyote/ActionHook
at java.lang.ClassLoader.findBootstrapClass(Native Method)
at java.lang.ClassLoader.findBootstrapClass0(ClassLoader.java:723)
at java.lang.ClassLoader.loadClass(ClassLoader.java:294)
at java.lang.ClassLoader.loadClass(ClassLoader.java:292)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:265)
at java.lang.ClassLoader.loadClass(ClassLoader.java:255)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:941)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:941)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
at java.lang.ClassLoader.defineClass0(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:502)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:123)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:250)
at java.net.URLClassLoader.access$100(URLClassLoader.java:54)
at java.net.URLClassLoader$1.run(URLClassLoader.java:193)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:186)

at 
org.apache.catalina.loader.StandardClassLoader.findClass(StandardClassLoader.java:621)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:958)

at 
org.apache.catalina.loader.StandardClassLoader.loadClass(StandardClassLoader.java:857)
at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:315)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:140)

at org.apache.coyote.tomcat4.CoyoteConnector.initialize(CoyoteConnector.java:1016)

at org.apache.catalina.core.StandardService.initialize(StandardService.java:579)

at org.apache.catalina.core.StandardServer.initialize(StandardServer.java:2246)
at org.apache.catalina.startup.Catalina.start(Catalina.java:511)
at org.apache.catalina.startup.Catalina.execute(Catalina.java:400)
at org.apache.catalina.startup.Catalina.process(Catalina.java:180)
... 5 more


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-5/resources mbeans.xml

2003-01-08 Thread costin
costin  2003/01/08 12:09:08

  Modified:resources mbeans.xml
  Log:
  Moved the jmx starting from catalina.xml ( the one using server.xml ).
  This part works fine ( well, there are few small fixes that may be needed -
  and I don't know why naming doesn't seem to work well, I get ResourceRef
  for the user database ).
  
  Revision  ChangesPath
  1.3   +91 -11jakarta-tomcat-5/resources/mbeans.xml
  
  Index: mbeans.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/resources/mbeans.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- mbeans.xml6 Jan 2003 18:38:31 -   1.2
  +++ mbeans.xml8 Jan 2003 20:09:08 -   1.3
  @@ -9,19 +9,29 @@
 
 
 
  +  
 
 
   
 
   
 
  +
  +  
 
  - 
  +  
  +
  +   
   
  -  
  -
  +  
  +
  +
  +
  +  
 
 
  +  
  +  
 
   
 
  @@ -48,14 +58,30 @@
   
   
   
  -
  -
  -
  +
 
  +
  +
 
   
   
  -  
  +  
  +
  +  
  +
  +  
  +
  +  
  +
  +  
   
   
  @@ -67,10 +93,11 @@
 
   
   
  -  
 
  -
  +
   
  +
   
  @@ -115,7 +142,7 @@
  type="boolean"
  value="false" />
   
  -
  +
   
   
   
  +  
  +
  +
  +  
  +   
  +
  +  
  +  
  +  
  +  
  +
  +  
  +
  +  
  +
  +
  +
  +
  +  
  +
  +
  +
  +
  +
  +  
  +
  +  
  +  
  +
  +
  +
  +  
  +
  +  
  +
  +
  +  
  +  
  +
 
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15845] - Memory Leak when compiling JSP

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15845

Memory Leak when compiling JSP





--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 19:41 ---
I ran jprobe on it and it is never being collected because it is never 
dereferenced from jasper.  so this is a problem with jasper, I agree that the 
5.0 patch fixes it because it is forked but I thought that was not being ported 
to 4.x

John

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-01-08 Thread remm
remm2003/01/08 11:38:05

  Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
  Log:
  - Invalid date headers should be ignored.
  - Bug 15890.
  
  Revision  ChangesPath
  1.59  +6 -6  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
  
  Index: DefaultServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
  retrieving revision 1.58
  retrieving revision 1.59
  diff -u -r1.58 -r1.59
  --- DefaultServlet.java   18 Sep 2002 13:16:39 -  1.58
  +++ DefaultServlet.java   8 Jan 2003 19:38:05 -   1.59
  @@ -1623,7 +1623,7 @@
   }
   }
   } catch(IllegalArgumentException illegalArgument) {
  -return false;
  +return true;
   }
   return true;
   
  @@ -1714,7 +1714,7 @@
   }
   }
   } catch(IllegalArgumentException illegalArgument) {
  -return false;
  +return true;
   }
   return true;
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15890] - Invalid If-Modified-Since leads to empty response.

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15890

Invalid If-Modified-Since leads to empty response.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 19:38 ---
The fix will be in 4.1.19.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2003-01-08 Thread remm
remm2003/01/08 11:36:11

  Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
  Log:
  - Invalid date headers should be ignored.
  - Bug 15890.
  
  Revision  ChangesPath
  1.5   +6 -6  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
  
  Index: DefaultServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- DefaultServlet.java   3 Jan 2003 19:32:52 -   1.4
  +++ DefaultServlet.java   8 Jan 2003 19:36:10 -   1.5
  @@ -1609,7 +1609,7 @@
   }
   }
   } catch(IllegalArgumentException illegalArgument) {
  -return false;
  +return true;
   }
   return true;
   
  @@ -1700,7 +1700,7 @@
   }
   }
   } catch(IllegalArgumentException illegalArgument) {
  -return false;
  +return true;
   }
   return true;
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15772] - catalina's web.xml missing mime-types some incorrect...

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15772

catalina's web.xml missing mime-types some incorrect...





--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 19:36 ---
The white-space issue isn't much of an issue.  In the mods I made, I just made 
sure that anything in common between the web.xml from Tomcat-4.1.18 and Tomcat-
5.0 looked exactly the same.  Since Tomcat-4.1.18 is the stable side of things, 
I made the web.xml of Tomcat-5.0 match that of Tomcat-4.1.18.  In the case of 
white-space, this means that if the web.xml of Tomcat-5.0 had an extra tab at 
the end of a line where it didn't in Tomcat-4.1.18, I removed it to make it 
match Tomcat-4.1.18's web.xml.  To see what I am talking about, perform a diff 
on the old Tomcat-5.0 web.xml and compare it to that of Tomcat-4.1.18.  Notice 
the differences where there really shouldn't be any?

Does that make sense?  It may seem pedantic, but it makes it easier to perform 
diff's on the files so that it is easier to keep them in sync.  Again, not a 
big issue, but I figured I might as well fix it while I was making other more 
meaningful changes.  Thanks for applying the changes!

Jake

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15845] - Memory Leak when compiling JSP

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15845

Memory Leak when compiling JSP

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 19:35 ---
To summarize, it's up to the compiler to clean up what it allocates. I'm against
the patch, but using the new fork option for javac will likely fix it.
Otherwise, precompile.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




A little help please

2003-01-08 Thread John Trollinger
Could someone familiar with Jasper please look at bug 15845.  This is
causing us problems and we found a work around but without the knowing
why the code was running the way it was in the first place it is hard to
validate that our solution will not have any adverse affects.

Thanks,

John


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [PROPOSAL] Tomcat doc organization

2003-01-08 Thread Remy Maucherat
Glenn Nielsen wrote:

Craig R. McClanahan wrote:



On Tue, 7 Jan 2003, Glenn Nielsen wrote:


The docs generated by Maven and Forrest based builds do this already --
they declare a stylesheet for the "print" media that leaves off the
navigation column when you print the document, without having to
explicitly generate print-friendly versions.  We could either import the
relevant stylesheets, or convert the docco generation to use these
existing packages.



Right.  Forrest looks promising and that may be the way to go sometime
in the future.  I don't have the time right now.  Adding printer friendly
docs with our current doc build is pretty simple. :-)


Adding a new stylesheet looks ok with me, as I don't see what it would 
break. This is probably not the best solution, of course, but it looks 
like it's "least effort". +1.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



Re: JMX-RI-1.2 problems

2003-01-08 Thread Remy Maucherat
Costin Manolache wrote:

You may have noticed - tomcat doesn't work with JMX 1.2
The main problem is that the spec now requires the type to be 
JNI-style ( [Ljava.lang.String; instead of java.lang.String[] ).
That would require a change in mbeans-descriptos.xml - but I'm
not sure if mx4j would still work after that.

There are also some additions and fixes in JMX1.2 we may need
( like sending the attribute change notifications to all listeners -
that works in jboss-jmx, but not in mx4j and jmx1.1-ri ).

Should we switch to ri-1.2 until MX4J finishes the update to 
1.2 ? 

The license seems more relaxed now - so we may be able to redistribute
it without problems. Obviously MX4J should be preffered for the 
release. 

Opinions ? Volunteers :-) ?

That seems ok to me, but we should switch back to MX4J ASAP after that. 
(but I don't have time to help these days, unfortunately)

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



JMX-RI-1.2 problems

2003-01-08 Thread Costin Manolache
You may have noticed - tomcat doesn't work with JMX 1.2
The main problem is that the spec now requires the type to be 
JNI-style ( [Ljava.lang.String; instead of java.lang.String[] ).
That would require a change in mbeans-descriptos.xml - but I'm
not sure if mx4j would still work after that.

There are also some additions and fixes in JMX1.2 we may need
( like sending the attribute change notifications to all listeners -
that works in jboss-jmx, but not in mx4j and jmx1.1-ri ).

Should we switch to ri-1.2 until MX4J finishes the update to 
1.2 ? 

The license seems more relaxed now - so we may be able to redistribute
it without problems. Obviously MX4J should be preffered for the 
release. 

Opinions ? Volunteers :-) ?

Costin




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Generator.java Node.java Validator.java

2003-01-08 Thread luehe
luehe   2003/01/08 10:42:43

  Modified:jasper2/src/share/org/apache/jasper/compiler Generator.java
Node.java Validator.java
  Log:
  Fixed 15854: Unable to provide a qname attribute value to the name
   attribute of the jsp:attribute action.
  
  Revision  ChangesPath
  1.145 +11 -11
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java
  
  Index: Generator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Generator.java,v
  retrieving revision 1.144
  retrieving revision 1.145
  diff -u -r1.144 -r1.145
  --- Generator.java6 Jan 2003 18:57:14 -   1.144
  +++ Generator.java8 Jan 2003 18:42:42 -   1.145
  @@ -2388,17 +2388,17 @@
   }
   }
   
  - String attrName = attr.getName();
  + String localName = attr.getLocalName();
   
Method m = null;
Class[] c = null;
if (attr.isDynamic()) {
c = OBJECT_CLASS;
   } else {
  - m = handlerInfo.getSetterMethod(attrName);
  + m = handlerInfo.getSetterMethod(localName);
if (m == null) {
err.jspError(n, "jsp.error.unable.to_find_method",
  -  attrName);
  +  attr.getName());
}
c = m.getParameterTypes();
// XXX assert(c.length > 0)
  @@ -2410,8 +2410,8 @@
if (!n.checkIfAttributeIsJspFragment(attr.getName())
&& !attr.isDynamic()) {
attrValue = convertString(
  -c[0], attrValue, attrName,
  - handlerInfo.getPropertyEditorClass(attrName),
  +c[0], attrValue, localName,
  + handlerInfo.getPropertyEditorClass(localName),
true);
}
} else if (attr.isELInterpreterInput()) {
  @@ -2420,8 +2420,8 @@
attrValue, c[0], n.getPrefix(), "_jspx_fnmap", false );
   } else {
attrValue = convertString(
  -c[0], attrValue, attrName,
  - handlerInfo.getPropertyEditorClass(attrName),
  +c[0], attrValue, localName,
  + handlerInfo.getPropertyEditorClass(localName),
false);
}
return attrValue;
  @@ -2503,7 +2503,7 @@
} else {
out.printin(tagHandlerVar);
out.print(".");
  - 
out.print(handlerInfo.getSetterMethod(attrs[i].getName()).getName());
  + 
out.print(handlerInfo.getSetterMethod(attrs[i].getLocalName()).getName());
out.print("(");
out.print(attrValue);
out.println(");");
  
  
  
  1.51  +37 -11
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java
  
  Index: Node.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Node.java,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- Node.java 6 Jan 2003 18:57:15 -   1.50
  +++ Node.java 8 Jan 2003 18:42:43 -   1.51
  @@ -175,7 +175,15 @@
   int numChildNodes = nodes.size();
   for( int i = 0; i < numChildNodes; i++ ) {
   NamedAttribute na = (NamedAttribute)nodes.getNode( i );
  -if( na.getName().equals( name ) ) {
  + boolean found = false;
  + int index = name.indexOf(':');
  + if (index != -1) {
  + // qualified name
  + found = na.getName().equals(name);
  + } else {
  + found = na.getLocalName().equals(name);
  + }
  + if (found) {
   result = na;
   break;
   }
  @@ -1312,15 +1320,25 @@
   private boolean trim = true;
   
   private ChildInfo childInfo;
  + private String name;
  + private String localName;
  + private String prefix;
   
   public NamedAttribute( Attributes attrs, Mark start, Node parent) {
   super( attrs, start, parent );
  -this.temporaryVariableName = JspUtil.nextTemporaryVariableName();
  +temporaryVariableName = JspUtil.nextTemporaryVariableName();
   if( "false".equals( this.getAttributeValue( "trim" ) ) ) {
   // (if null or true, leave default of true)
   trim = false;
   }
  -this.childInfo = new ChildInfo();
  

problems with ClassLoader and custom Server class.

2003-01-08 Thread Dan Hansen
Hi all,
 
 I've encountered a peculiar problem writing a Server for catalina (tomcat
4.1.18)

 I don't know if anyone else has written a customized Server so I
 don't know if this is uncharted territory or not - I saw nothing in my
 search of the archives but I might have missed it.  
 
 The key problem is that a new Server put into a jar into the 
 server/lib or common/lib directly results in one or another 
 of the ClassLoaders becoming unable to see other basic classes 
 in that catalina.jar (and others if you
 just naively put catalina.jar into the CLASSPATH to make it 
 available globally).
 
 Background Notes (in no particular order)
 1. You can replace the standard Server with your implementation via
 the className attribute in server configuration.
 2. You can make this class visible to the server by placing it in a
 jar in common/lib or in server/lib.
 3. Tomcat has different ClassLoaders for different portions of the
 container and web apps running on the container

 In other words, resources may be visible in one portion of the
 container and not in others.
 So if you write a MyServer class, put in a jar, and place it in (say)
 shared/lib - this will not work because the server needs to see the
 class and the shared portion is only visible to webapps.

 Here's the problem - write your MyServer class, put it in
 common/lib or server/lib.  Now when you try to run "catalina.bat run" 
 the ClassLoader cannot see org.apache.catalina.core.LifeCycle
 (which lives in the same package and jar as the StandardServer in the
 server portion of the container - i.e. catalina.jar).
 
 Heck, you don't even have to write your own class.  Put the
 StandardServer into your own package and jar in common/lib or server/lib
and you
 have the same problem.

 If you've got any insight into this problem I'd be in your debt.
 Dan

Dan Hansen | software engineer | +1.720.932.4724 | [EMAIL PROTECTED] |
www.creo.com
Creo - Creative Software Group

IMAGINE CREATE BELIEVE





--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15854] - Unable to provide a qname attribute value to the name attribute of the jsp:attribute action.

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15854

Unable to provide a qname attribute value to the name attribute of the jsp:attribute 
action.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15894] New: - Access to other sessions possible (session is immediately recycled after invalidation/expiration)

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15894

Access to other sessions possible (session is immediately recycled after 
invalidation/expiration)

   Summary: Access to other sessions possible (session is
immediately recycled after invalidation/expiration)
   Product: Tomcat 3
   Version: 3.3.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Critical
  Priority: Other
 Component: Servlet
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello 
 
it is possible to access a session of somebody else through calling 
session.invalidate. Here is an example JSP: 
 
<% 
  HttpSession s = request.getSession(true); 
  String name = request.getParameter("name"); 
  s.setAttribute("name", name); 
  Thread.sleep(5000); 
  s.invalidate(); 
  Thread.sleep(5000); 
  s = request.getSession(true); 
  String nameFromSession = (String) s.getAttribute("name"); %> 
 
Test Invalidate 
 
 
 
<% if (nameFromSession == null) { %> 
  second session was clean. 
<% } else { %> 
 
  Session not Empty after invalidate!!! 
 
  I got the session from <%=nameFromSession%> 
<% } %> 
 
 
 
 
 
Login on one browser with 
http://localhost:8080/examples/testInvalidate.jsp?name=Martin 
and then after 8 seconds on another browser (if cookies are disabled you can 
use two windows of the same browser) with 
http://localhost:8080/examples/testInvalidate.jsp?name=Waldemar 
You'll get the session of Martin. 
 
The problem is that SimpleSessionStore recycles the sessions right away. I 
attached a path to delay the recycling. 
The patch also touches three files to reduce racing problems. To fix the 
problem only SimpleSessionStore needs to be updated. 
 
Christian Wicke 
 
Here is my patch: 
 
diff -Naur ./facade22/org/apache/tomcat/facade/HttpSessionFacade.java 
../../../jakarta-tomcat-3.3.1-src/src/facade22/org/apache/tomcat/facade/HttpSessionFacade.java
 
--- ./facade22/org/apache/tomcat/facade/HttpSessionFacade.java  Wed Jan  8 
15:17:18 2003 
+++ 
../../../jakarta-tomcat-3.3.1-src/src/facade22/org/apache/tomcat/facade/HttpSessionFacade.java
  
Tue Mar 26 16:36:48 2002 
@@ -148,8 +148,7 @@ 
  * @exception IllegalStateException if this method is called on 
  *  an invalidated session 
  */ 
-// avoid parallel call to invalidate through synchronized 
-public synchronized void invalidate() { 
+public void invalidate() { 
checkValid(); 
realSession.getTimeStamp().setValid( false ); 
// remove all attributes 
diff -Naur ./share/org/apache/tomcat/modules/session/SessionExpirer.java 
../../../jakarta-tomcat-3.3.1-src/src/share/org/apache/tomcat/modules/session/SessionExpirer.java
 
--- ./share/org/apache/tomcat/modules/session/SessionExpirer.java   Wed 
Jan  8 13:32:21 2003 
+++ 
../../../jakarta-tomcat-3.3.1-src/src/share/org/apache/tomcat/modules/session/SessionExpirer.java
   
Tue Mar 26 16:36:49 2002 
@@ -159,14 +159,7 @@ 
} 
 
public void expired(TimeStamp o ) { 
- ServerSession sses=(ServerSession)o.getParent(); 
-// double check if this session is not touched in 
-// meantime by SessionId.processSession 
-   synchronized (sses) { 
-  if (System.currentTimeMillis() - o.getLastAccessedTime() < 
o.getMaxInactiveInterval()) 
-// session touched in meantime, don't expire 
-return; 
- 
+   ServerSession sses=(ServerSession)o.getParent(); 
if( debug > 0  ) { 
se.log( "Session expired " + sses); 
} 
@@ -174,7 +167,6 @@ 
// After expiring it, we clean up. 
if( debug > 0 ) se.log( "Recycling " + sses); 
sses.recycle(); 
-} 
} 
 } 
 } 
diff -Naur ./share/org/apache/tomcat/modules/session/SessionId.java 
../../../jakarta-tomcat-3.3.1-src/src/share/org/apache/tomcat/modules/session/SessionId.java
 
--- ./share/org/apache/tomcat/modules/session/SessionId.javaWed Jan  8 
15:13:14 2003 
+++ 
../../../jakarta-tomcat-3.3.1-src/src/share/org/apache/tomcat/modules/session/SessionId.java

Tue Mar 26 16:37:15 2002 
@@ -239,13 +239,6 @@ 
  sessionId,  false ); 
if( sess!=null ) break; 
} 
-  if (sess == null) 
-return null; 
- // avoid parallel expiration of the SessionExpirer 
- synchronized (sess) { 
-   //double check whether the session has been expired meantime 
-   if (sess.getState() == ServerSession.STATE_EXPIRED) 
- return null; 
 
 /* The following block of code verifies if Tomcat session matches 
SSL session (if 

DO NOT REPLY [Bug 15892] - Incorrect decoding of URL for getPathInfo()

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15892

Incorrect decoding of URL for getPathInfo()





--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 16:48 ---
Created an attachment (id=4373)
Source code for the example URL

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15893] New: - Need a getPort() method on Connector or similar functionality

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15893

Need a getPort() method on Connector or similar functionality

   Summary: Need a getPort() method on Connector or similar
functionality
   Product: Tomcat 4
   Version: 4.1.18
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


We use the Embedded Tomcat as a help server in Eclipse and have a need to run 
Tomcat on an arbitrary port. In particular, we want to createa Connector by 
passing port=0, have the system pick up port when a ServetSocket is created, 
and later we want to retrieve that port.
possible solution is to add a getPort() method on the Connector.

In 4.0.4, we got around this by setting our own ServerSocketFactory on the 
Connector, and keep track of the port created. 
We were looking at moving to Tomcat 4.1.18, but the factory there is only used 
for secure connections, for the other connection a DefaultServerSocketFactory 
is used, so we're stuck.

A possible solution is to add a getPort() on the Connector that can return the 
real port used. There would be a sequencing problem here, as thep port may only 
be known after the Connector is started, but that'll be ok.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15892] New: - Incorrect decoding of URL for getPathInfo()

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15892

Incorrect decoding of URL for getPathInfo()

   Summary: Incorrect decoding of URL for getPathInfo()
   Product: Tomcat 4
   Version: 4.1.18
  Platform: PC
   URL: http://bowmore.dcs.st-
andrews.ac.uk:8080/getpathbug/index.html
OS/Version: Linux
Status: NEW
  Severity: Major
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


"+" characters in the path info of a servlet (returned by
HttpServletRequest.getPathInfo ()) are not handled correctly. They should be
decoded to a " " character, but instead are left undecoded. Using the supplied
URL as an example, the last two tests should return "test test", and
"test+test". Instead both return "test+test".

The result of this is that it is impossible to tell the difference between a URL
which includes a " " character, and a URL which includes a "+".

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




FYI: [Fwd: documentation error]

2003-01-08 Thread Henri Gomez
<<< text/plain; charset=ISO-8859-1; format=flowed: Unrecognized >>>
--- Begin Message ---
I wished to point out that in the jakarta/tomcat documentation, there is an
error.  

Under server configuration reference, Host
(webapps\tomcat-docs\config\host.html), it shows, under the section heading
request filters, an example of using the valve xml tag for the server.xml
configuration file.


  ...
  
  
  ...


The problem is in the regular expression, it should read:


  ...
  
  
  ...


Without the '\w' and the '\d' the server will not start, as the regular
expression engine will throw an exception.

Excellent job, else, guys!  Thanks,

Shawn Stoffer
 <> 



Stoffer, Shawn D.vcf
Description: Binary data
--- End Message ---
--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


DO NOT REPLY [Bug 15772] - catalina's web.xml missing mime-types some incorrect...

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15772

catalina's web.xml missing mime-types some incorrect...

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 16:18 ---
OK I have ported the change from Tomcat 4.1.x branch and make the change you
requested. What is the white space issue?

-- Jeanfrancois

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Tomcat 4.1.18 rpm available

2003-01-08 Thread Henri Gomez
After some delay the TC 4.1.18 rpms are available at :

http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.18/rpms/

Regards


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-catalina/catalina/src/conf web.xml

2003-01-08 Thread jfarcand
jfarcand2003/01/08 08:16:09

  Modified:catalina/src/conf web.xml
  Log:
  Add missing mime type and fix a bug.(port patch from Tomcat 4)
  
  PR: Bugzilla #15772
  Submitted by: Jacob Kjome at visi.com
  
  Revision  ChangesPath
  1.12  +17 -1 jakarta-tomcat-catalina/catalina/src/conf/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/conf/web.xml,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- web.xml   1 Jan 2003 15:21:40 -   1.11
  +++ web.xml   8 Jan 2003 16:16:08 -   1.12
  @@ -521,6 +521,14 @@
   text/javascript
   
   
  +jsf
  +text/plain
  +
  +
  +jspf
  +text/plain
  +
  +
   kar
   audio/x-midi
   
  @@ -789,10 +797,18 @@
   image/x-xbitmap
   
   
  +xml
  +text/xml
  +
  +
   xpm
   image/x-xpixmap
   
   
  +xsl
  +text/xml
  +
  +
   xwd
   image/x-xwindowdump
   
  @@ -826,7 +842,7 @@
   
   
   wmls
  -text/vnd.wap.wmls
  +text/vnd.wap.wmlscript
   
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15890] New: - Invalid If-Modified-Since leads to empty response.

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15890

Invalid If-Modified-Since leads to empty response.

   Summary: Invalid If-Modified-Since leads to empty response.
   Product: Tomcat 4
   Version: 4.1.17
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This was observed for static content, so the bug may be in 
org.apache.catalina.servlets.DefaultServlet rather than the connector itself.

When a client provides an invalid If-Modified-Since header (eg Java 1.3 
URLConnection class on a non-English locale does this; see Sun bug #4397096), 
the response is always empty, with a 200 response code. I'd expect an invalid 
If-Modified-Since header to be ignored and the response returned normally (in 
this case it should have been about 15k worth).

Example below (Japanese character for Thurs replaced with [MOKU] since it gets 
corrupted otherwise).


GET /altio/altioClient.js HTTP/1.1
Cookie: JSESSIONID=344928E8EB29CFC13A93D232FDDF0834
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0; .NET CLR 
1.0.3705)
X-Altio-Proxy: 41710
Accept-Language: en-us,ja;q=0.5
Host: altiojr:8080
Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2
Connection: keep-alive
If-Modified-Since: [MOKU], 01 1 1970 00:00:00 GMT

HTTP/1.1 200 OK
Content-Type: text/plain
Content-Length: 0
Date: Wed, 08 Jan 2003 15:32:56 GMT
Server: Apache Coyote/1.0

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Tomcat --> DB2 DBCP : authentication problem

2003-01-08 Thread vidar . kongsli
I am trying to configure a connection from Tomcat 4.1.18 to DB2 7.2
FixPack5 (NT, local DB2 client), and receive the following error message
when trying to open a connection to the database:

org.apache.commons.dbcp.DbcpException: COM.ibm.db2.jdbc.DB2Exception:
[IBM][CLI Driver] SQL0567N "SYSTEM" is not a valid authorization ID.
SQLSTATE=42602

The exception is thrown when trying to create the connection in the
following code:

javax.naming.InitialContext ctx = new javax.naming.InitialContext();
javax.sql.DataSource ds = (javax.sql.DataSource)envx.lookup
("java:comp/env/jdbc/MyDB2");
java.sql.Connection connection = ds.getConnection();

The resource definition in server.xml is as follows:




  
userdb2admin
  
  
passworddb2admin
  
  
driverClassName
COM.ibm.db2.jdbc.app.DB2Driver
  
  
url
jdbc:db2:SAMPLE
  
  
maxActive
8
  
  
maxIdle
4
  
   
removeAbandoned
true
  
  
removeAbandonedTimeout
60
  
  
logAbandoned
true
  
  
maxWait
1
  


I have tried to connect using the same username and password by manually
creating a JDBC connection with the same driver (not using JNDI), and it
works fine:

Class.forName("com.ibm.db2.jcc.DB2Driver").newInstance();
con = DriverManager.getConnection( "jdbc:db2:SAMPLE", "db2admin",
"db2admin" );

 It seems that Tomcat does not send the correct credentials (the ones
defined in the resourceparams in server.xml) when trying to connect to DB2
(it seems to send "SYSTEM" rather than "db2admin"). I have installed the
necessary jakarta components for connection pooling and I have made the IBM
driver classes available in the $CATALINA_HOME/common/lib directory. Hence,
I suspect that the problem originates in the connection pooling part of
Tomcat.

Have anyone experienced similar problems or have any idea about how to
solve this?

Any suggestions are greatly appreciated.

Regards
Vidar

B | vidar kongsli, consultant
E | +47 982 19 329, [EMAIL PROTECTED]
K | bekk consulting as, pb. 134 sentrum, 0102 oslo,
K | www.bekk.no




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [PROPOSAL] Tomcat doc organization

2003-01-08 Thread Glenn Nielsen
Craig R. McClanahan wrote:


On Tue, 7 Jan 2003, Glenn Nielsen wrote:



Date: Tue, 07 Jan 2003 21:35:12 -0600
From: Glenn Nielsen <[EMAIL PROTECTED]>
Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: [PROPOSAL] Tomcat doc organization

If you follow the tomcat-user list there are many questions that are asked
which the reply could be RTFM.  If the tomcat docs were organized in a way
which made them easier to use this may reduce the number of RTFM type of
questions.

Proposed changes to doc organization:

For each individual page generate a "Printer Friendly" version without the
navigation menu.  Provide a link on the menu to the printer friendly version.
These can easily be generated from the existing xml files, I already have a
minor change in tomcat-docs.xsl to support this.




The docs generated by Maven and Forrest based builds do this already --
they declare a stylesheet for the "print" media that leaves off the
navigation column when you print the document, without having to
explicitly generate print-friendly versions.  We could either import the
relevant stylesheets, or convert the docco generation to use these
existing packages.



Right.  Forrest looks promising and that may be the way to go sometime
in the future.  I don't have the time right now.  Adding printer friendly
docs with our current doc build is pretty simple. :-)




For the Config Reference and HOW-TO's provide a printer friendly version
that includes all of those docs.  This will make it easier for user's to
print out a Tomcat manual.



Shouldn't be too hard to accomplish with a document that just includes all
the individual parts into a single resulting "page".



Yup. :-)




Where appropriate, add Table of Content sections at the top to make
finding what you want and navigating within a single document easier.




Oh, and generate an searchable index with Lucene ... :-)



I'll leave that for someone else.  I am just looking at what can be done
easily and quickly to improve our docs using our existing stuff.

Glenn


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 15845] - Memory Leak when compiling JSP

2003-01-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15845

Memory Leak when compiling JSP





--- Additional Comments From [EMAIL PROTECTED]  2003-01-08 11:45 ---
in the JspCompilationContext class if we change the compile() method to this

public void compile() throws JasperException, FileNotFoundException {
createCompiler();
if (jspCompiler.isOutDated()) {
try {
jspCompiler.compile();
reload = true;
} catch (JasperException ex) {
throw ex;
} catch (Exception ex) {
throw new JasperException(
Constants.getString("jsp.error.unable.compile"),ex);
}
}
jspCompiler = null;
}

our jsp compilation test goes from using 500 meg of memory to 50 meg of memory.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: hello

2003-01-08 Thread Martin Algesten
This is the developer list for development questions. Please direct this
question to the tomcat-user list.

(
 Tip: Have a look at web.xml  directive:
  
404
/error404.jsp
  
  
)

Martin


> -Original Message-
> From: Dan Agarlita [mailto:[EMAIL PROTECTED]] 
> Sent: 09 January 2003 10:33
> To: 'Tomcat Developers List'
> Subject: hello
> 
> 
> I want to know how can I modify the 404 Error page.
> I want to put another page. Is a param? Or I have to modify 
> some classes ?
> 
> :) 10x, dan
> 
> 
> --
> To unsubscribe, e-mail:   
>  [EMAIL PROTECTED]>
> For 
> additional commands, 
> e-mail: 
> 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




hello

2003-01-08 Thread Dan Agarlita
I want to know how can I modify the 404 Error page.
I want to put another page. Is a param? Or I have to modify some classes
?

:) 10x, dan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [PATCH] forward instead of redirect for welcome files

2003-01-08 Thread Jan Grant
On 7 Jan 2003, Matt Parker wrote:

> On Tue, 2003-01-07 at 04:40, Remy Maucherat wrote:
> > I'll -1 this patch unless the new behavior is made optional (and default
> > to the current behavior).
> >
> > Remy
>
> Okay, it's now an init param which defaults to false. Following are
> DefaultServlet.java and web.xml patches.

Hopefully in time this can become turned on by default. This behaviour
almost made it into the last servlet spec but got dropped at some point
between candidate spec and the release.

Since user behaviour is typically to bookmark pages that they're looking
at, the redirect behaviour essentially makes the welcome file feature
useless (for all the reasons outlined in "Cool URLs don't change").

-- 
jan grant, ILRT, University of Bristol. http://www.ilrt.bris.ac.uk/
Tel +44(0)117 9287088 Fax +44 (0)117 9287112 http://ioctl.org/jan/
...You're visualising the _duck_ taped over my _mouth_..?


--
To unsubscribe, e-mail:   
For additional commands, e-mail: