DO NOT REPLY [Bug 16983] New: - ServletContext.getContext(String) cannot return other contexts when called from root context.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16983.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16983
ServletContext.getContext(String) cannot return other contexts when called from root
context.
Summary: ServletContext.getContext(String) cannot return other
contexts when called from root context.
Product: Tomcat 4
Version: 4.1.18
Platform: All
OS/Version: All
Status: NEW
Severity: Major
Priority: Other
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
I believe the problem lies in the implementation of getContext(String)
in the class org.apache.catalina.core.ApplicationContext. I studied the
source and traced the problem to the following lines (starting at line 442):
String contextPath = context.getPath();
if (!contextPath.endsWith(/))
contextPath = contextPath + /;
if ((contextPath.length() 0) (uri.startsWith(contextPath))) {
return (this);
}
If the contextPath is (root), the above code will always return the
current context (since contextPath.length() 0 will always be true).
A fix could be to replace the last if-statement with, for instance, the
following:
if ( ((contextPath.length() 1) (uri.startsWith(contextPath))) ||
contextPath.equals(uri) ) {
return (contextPath);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valveRemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java
Amy Roh wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: amyroh 2003/02/10 18:27:15 Modified:webapps/admin build.xml webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties ApplicationResources_es.properties webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java Log: Add validation for RemoteAddrValve and RemoteHostValve to prevent installing a filter that prevents the admin's own access. I don't understand what this does over the stanadard remote host/addr valves. If the maintainer of server.xml wishes to deny access to the admin, then he has the right to do so IMO. I don't agree with forcing the localhost to have access, essentially. I may have an idea of where this new feature is coming from ;-) If the maintainer of server.xml or tomcat wishes to deny access to the admin, he can surely do so by editing server.xml and is recommended to do so if that's what he desires. This patch doesn't prevent that availability. This patch only adds validation in admin to prevent the admin to crash because if the user, who doesn't have better idea how these filters work, just create these filters that deny access to its own admin while running admin will cause the whole admin to crash. Just try adding these valves with deny attribute 127.0.0.1, the whole admin will crash before this patch. Again, this is just a validation of inputs that will have admin continue to work instead of limiting these filters usage. Also note that you can still create these filters to prevent admin access from other ip addresses or host other than admin's own ip and host. Yes, but IMO, it's the admin's problem. The admin webapp shouldn't duplicate the functionality that it present elsewhere. Also, if the admin wishes to disable access from localhost (and access from elsewhere), then he has the right to do so. Sorry, but you can only go so far with the for dummy factor ... Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TC 5.0 nightly builds
Remy Maucherat wrote: Kin-Man Chung wrote: No matter how easy the build is, it is still not as easy as downloading a binary from the nightly build area. Just tell someone who haven;t done a build before to do it now and watch her cringe! I don't care ;-) Unix users are used to building things, and it works for the better. Sue' point is that TC5 nightly build has failed for a week now and should be fixed. It's important that we have a current nightly build for TC5, especially since we don't have a release for TC5 (hint! hint :) ). I really really don't see the point. Nightlies are completely useless IMO as soon as the build system is really easy (not easy enough right now, though). Getting reliable Nightlies will have a side effect to improve the build system and make themselves nearly useless ;-) Something like ant night. For the moment I am not able to build Nightlies because of the firewall and because the ant download task mixes cvs and http download: I have to do cvs via SOCKS5 and http via a proxy. So I am thinking to separate the cvs and http downloads. Any comments? I need something like: /usr/local/socksified/bin/runsocks ant downloadcvs ant downloadhttp Of course ant download will still do its actual task. Cheers Jean-frederic Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TC 5.0 nightly builds
jean-frederic clere wrote: Remy Maucherat wrote: Getting reliable Nightlies will have a side effect to improve the build system and make themselves nearly useless ;-) Something like ant night. For the moment I am not able to build Nightlies because of the firewall and because the ant download task mixes cvs and http download: I have to do cvs via SOCKS5 and http via a proxy. So I am thinking to separate the cvs and http downloads. Any comments? I need something like: /usr/local/socksified/bin/runsocks ant downloadcvs ant downloadhttp Of course ant download will still do its actual task. That seems a good idea :) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/users group.jsp user.jsp
amyroh 2003/02/12 02:04:10 Modified:webapps/admin/users group.jsp user.jsp Log: Remove groups and roles tables on user and group page. These tables were causing exceptions when page validation fails. Revision ChangesPath 1.7 +0 -1 jakarta-tomcat-4.0/webapps/admin/users/group.jsp Index: group.jsp === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/group.jsp,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- group.jsp 15 Jan 2003 22:25:22 - 1.6 +++ group.jsp 12 Feb 2003 10:04:10 - 1.7 @@ -109,7 +109,6 @@ bean:define id=checkboxes scope=page value=true/ br - %@ include file=roles.jspf % %@ include file=../buttons.jsp % 1.8 +0 -3 jakarta-tomcat-4.0/webapps/admin/users/user.jsp Index: user.jsp === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/users/user.jsp,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- user.jsp 15 Jan 2003 22:25:22 - 1.7 +++ user.jsp 12 Feb 2003 10:04:10 - 1.8 @@ -120,9 +120,6 @@ bean:define id=checkboxes scope=page value=true/ br - %@ include file=groups.jspf % - br - %@ include file=roles.jspf % %@ include file=../buttons.jsp % - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/admin/users group.jsp user.jsp
amyroh 2003/02/12 02:08:45 Modified:webapps/admin/users group.jsp user.jsp Log: Port change. Revision ChangesPath 1.5 +1 -2 jakarta-tomcat-catalina/webapps/admin/users/group.jsp Index: group.jsp === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/group.jsp,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- group.jsp 23 Jan 2003 00:07:10 - 1.4 +++ group.jsp 12 Feb 2003 10:08:45 - 1.5 @@ -108,8 +108,7 @@ /table bean:define id=checkboxes scope=page value=true/ - br - %@ include file=roles.jspf % + %@ include file=../buttons.jsp % 1.5 +0 -3 jakarta-tomcat-catalina/webapps/admin/users/user.jsp Index: user.jsp === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/users/user.jsp,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- user.jsp 23 Jan 2003 00:07:10 - 1.4 +++ user.jsp 12 Feb 2003 10:08:45 - 1.5 @@ -120,9 +120,6 @@ bean:define id=checkboxes scope=page value=true/ br - %@ include file=groups.jspf % - br - %@ include file=roles.jspf % %@ include file=../buttons.jsp % - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP] Build Failure - jakarta-tomcat-jk-native
This email is autogenerated from the output from:
http://cvs.apache.org/builds/gump/2003-02-12/jakarta-tomcat-jk-native.html
Buildfile: build.xml
init:
[echo] /home/rubys
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk
apache20:
apache13:
iis:
netscape:
jni:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni
[so] Compiling 4 out of 4
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_pool.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_util.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
[so] Compile failed 1
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
[so] Command:libtool --mode=compile cc -c -o
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni/jni/jk_jnicb.o
-I/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common
-I/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni
-I/usr/java/j2sdk1.4.1_01/jre/../include -I${build.compiler.base}/include -g -W
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
[so] Output:
[so] mkdir
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni/jni/.libs
[so] cc -c -I/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common
-I/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni
-I/usr/java/j2sdk1.4.1_01/jre/../include -I\${build.compiler.base}/include -g -W
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c -fPIC -DPIC
-o /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni/jni/.libs/jk_jnicb.lo
[so] StdErr:
[so] In file included from
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.h:2,
[so] from
/home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c:64:
[so] /usr/java/j2sdk1.4.1_01/include/jni.h:27:20: jni_md.h: No such file or
directory
BUILD FAILED
file:///home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/build.xml:63: Compile
failed /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/jni/jk_jnicb.c
Total time: 5 seconds
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16950] - input validation not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16950. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16950 input validation not working [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 10:17 --- I have removed the roles and groups tables that were present on user and group jsp pages that were causing the exception when its validation fails. The fix should be available in the next release. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core ApplicationContext.java
remm2003/02/12 02:24:10 Modified:catalina/src/share/org/apache/catalina/core ApplicationContext.java Log: - Add an often requested kludge (which doesn't make the spec any less broken), to allow getting contexts from the root context. - Submitted by Martin Algesten. Revision ChangesPath 1.41 +1159 -1159jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationContext.java Index: ApplicationContext.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/ApplicationContext.java,v retrieving revision 1.40 retrieving revision 1.41 diff -u -r1.40 -r1.41 --- ApplicationContext.java 6 Nov 2002 13:39:36 - 1.40 +++ ApplicationContext.java 12 Feb 2003 10:24:09 - 1.41 @@ -1,1159 +1,1159 @@ -/* - * $Header$ - * $Revision$ - * $Date$ - * - * - * - * The Apache Software License, Version 1.1 - * - * Copyright (c) 1999 The Apache Software Foundation. All rights - * reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in - *the documentation and/or other materials provided with the - *distribution. - * - * 3. The end-user documentation included with the redistribution, if - *any, must include the following acknowlegement: - * This product includes software developed by the - *Apache Software Foundation (http://www.apache.org/). - *Alternately, this acknowlegement may appear in the software itself, - *if and wherever such third-party acknowlegements normally appear. - * - * 4. The names The Jakarta Project, Tomcat, and Apache Software - *Foundation must not be used to endorse or promote products derived - *from this software without prior written permission. For written - *permission, please contact [EMAIL PROTECTED] - * - * 5. Products derived from this software may not be called Apache - *nor may Apache appear in their names without prior written - *permission of the Apache Group. - * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED - * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR - * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF - * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND - * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, - * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT - * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - * - * - * This software consists of voluntary contributions made by many - * individuals on behalf of the Apache Software Foundation. For more - * information on the Apache Software Foundation, please see - * http://www.apache.org/. - * - * [Additional notices, if required by prior licensing conditions] - * - */ - - -package org.apache.catalina.core; - - -import java.io.BufferedReader; -import java.io.InputStream; -import java.io.IOException; -import java.io.File; -import java.io.UnsupportedEncodingException; -import java.net.MalformedURLException; -import java.net.Socket; -import java.net.URL; -import java.security.AccessController; -import java.security.Principal; -import java.security.PrivilegedAction; -import java.security.PrivilegedExceptionAction; -import java.security.PrivilegedActionException; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Collections; -import java.util.Enumeration; -import java.util.HashMap; -import java.util.HashSet; -import java.util.Iterator; -import java.util.Locale; -import java.util.Map; -import java.util.Set; -import javax.naming.NamingException; -import javax.naming.Binding; -import javax.naming.directory.DirContext; -import javax.servlet.RequestDispatcher; -import javax.servlet.Servlet; -import javax.servlet.ServletContext; -import javax.servlet.ServletContextAttributeEvent; -import
Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java
Amy Roh wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: amyroh 2003/02/10 18:27:15 Modified:webapps/admin build.xml webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties ApplicationResources_es.properties webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java Log: Add validation for RemoteAddrValve and RemoteHostValve to prevent installing a filter that prevents the admin's own access. I don't understand what this does over the stanadard remote host/addr valves. If the maintainer of server.xml wishes to deny access to the admin, then he has the right to do so IMO. I don't agree with forcing the localhost to have access, essentially. I may have an idea of where this new feature is coming from ;-) If the maintainer of server.xml or tomcat wishes to deny access to the admin, he can surely do so by editing server.xml and is recommended to do so if that's what he desires. This patch doesn't prevent that availability. This patch only adds validation in admin to prevent the admin to crash because if the user, who doesn't have better idea how these filters work, just create these filters that deny access to its own admin while running admin will cause the whole admin to crash. Just try adding these valves with deny attribute 127.0.0.1, the whole admin will crash before this patch. Again, this is just a validation of inputs that will have admin continue to work instead of limiting these filters usage. Also note that you can still create these filters to prevent admin access from other ip addresses or host other than admin's own ip and host. Yes, but IMO, it's the admin's problem. The admin webapp shouldn't duplicate the functionality that it present elsewhere. Also, if the admin wishes to disable access from localhost (and access from elsewhere), then he has the right to do so. I see your point regarding the admin should let disabling access from localhost if it's accessing from elsewhere. How about if I remove checking for localhost and just keep the checking for admin's own ip and host? Sorry, but you can only go so far with the for dummy factor ... I know. I know. ;-) Amy Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0 RELEASE-NOTES-4.1.txt
remm2003/02/12 02:29:33 Modified:.RELEASE-NOTES-4.1.txt Log: - Status update. Revision ChangesPath 1.55 +1346 -1340jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt Index: RELEASE-NOTES-4.1.txt === RCS file: /home/cvs/jakarta-tomcat-4.0/RELEASE-NOTES-4.1.txt,v retrieving revision 1.54 retrieving revision 1.55 diff -u -r1.54 -r1.55 --- RELEASE-NOTES-4.1.txt 10 Feb 2003 19:47:40 - 1.54 +++ RELEASE-NOTES-4.1.txt 12 Feb 2003 10:29:32 - 1.55 @@ -1,1340 +1,1346 @@ - Apache Tomcat Version 4.1 - = -Release Notes -= - -$Id$ - - - -INTRODUCTION: - - - -This document describes the changes that have been made in the current -development version of Apache Tomcat, relative to the Tomcat 4.0 release. -The release notes for all prior releases of Tomcat 4.0 are also included, for -your reference. - -Bug reports should be entered at the bug reporting system for -Jakarta projects at: - -http://nagoya.apache.org/bugzilla/ - -Please report bugs and feature requests under product name Tomcat 4. - - - - -NEW FEATURES: - - - - -General New Features: - - -[4.1.1] Administration Webapp: -Complete development of the initial version of the administration web -application. - -[4.1.5] Administration Webapp: -Add support for manipulating JNDI resources of web applications. - -[4.1.6] Administration Webapp: -Add support for JavaMail resources. - -[4.1.6] Tyrex resources: -Upgrade to Tyrex 1.0. - -[4.1.10] Commons components: - Upgrade to stable releases. - -[4.1.11] Administration Webapp: - Add support for DefaultContext. - -[4.1.11] Documentation: - New JK and JK 2 documentation. - -[4.1.15] i18n: - Complete French language translation. - -[4.1.19] Documentation: - Added printer friendly versions of the documents. - -[4.1.19] Administration Webapp: - Complete the accessibility requirements to pass section 508. - - -- -Catalina New Features: -- - -[4.1.3] Catalina: - Implement custom logger which can be used to capture System.out and - System.err to a buffer for later use. - -[4.1.3] SSIServlet: - Complete rewrite of the SSI functionality (WARNING: servlet class name - has changed). - -[4.1.3] CoyoteConnector: - Add PureTLS support. - -[4.1.4] Embedded: - Add support for Coyote HTTP/1.1 and Coyote JK 2. - -[4.1.4] DefaultContext: - Refactoring of DefaultContext to support dynamic configuration (naming - resources and other misc properties). - -[4.1.4] MBeanUtils: - Allow specifying custom MBean descriptor files. - -[4.1.5] ServerLifecycleListener: - Generate MBeans for the JNDI resources of the contexts. - -[4.1.8] BootstrapService: - Allow passing parameters to the BootstrapService. - -[4.1.15] JNDIRealm: - Add support for SSL with the JNDIRealm. - -[4.1.16] AuthenticatorBase: - Add a configuration option to disable setting the headers which - prevent proxies from caching protected pages. Using this option may - open security holes in your application, so it should only be used - if you are certain about what you are doing. - -[4.1.16] JNDIRealm: - Allow configuring how JNDI should handle referrals returned - by the server. - -[4.1.16] AccessLogValve: - Allow disabling log file rotation, and add new patterns. - -[4.1.17] DataSourceRealm: - A new Realm implementation which can use a JNDI named JDBC - DataSource has been added. - -[4.1.19] JNDIRealm: - Added support for using an alternateURL if a socket connection - can not be made to the provider at the connectionURL. - -[4.1.19] CoyoteConnector: - Add HTTP/1.1 GZIP compression support. - -[4.1.20] StandardWrapper, ManagerBase: - Added JavaBean fields to expose statistics through JMX. - -[4.1.20] GlobalResourcesLifecycleListener: - Allow the listener to be associated with a Service. - - -Jasper New Features: - -[4.1.1] JspServlet, Options: -Add new reloading flag allowing to disable the JSP reloading checks, -to allow better performance on production servers. - -[4.1.1] JspServlet: -Refactor the JSP modification checking as a
Re: [4.1.20] Tagging today
Costin Manolache wrote: After the tag, I would like to port back the jsr77 names for servlets and enable the new attributes ( it'll be conditioned by a flag - so it won't be enable by default, only if someone sets the flag). The change is local to ServerLifecycleListener, and I tested it with reloading and the /admin. Is it ok ? We should wait IMO for the next stable release to port that. So if it's 4.1.20, great ! Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valveRemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java
Amy Roh wrote: Amy Roh wrote: Yes, but IMO, it's the admin's problem. The admin webapp shouldn't duplicate the functionality that it present elsewhere. Also, if the admin wishes to disable access from localhost (and access from elsewhere), then he has the right to do so. I see your point regarding the admin should let disabling access from localhost if it's accessing from elsewhere. How about if I remove checking for localhost and just keep the checking for admin's own ip and host? That's probably acceptable. It's not worth the complexity IMO, but it's up to you. Ok, go to bed now :) It's way too late for you, so I'm not integrating your patches for that tag ;-) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardWrapperValve.java
amyroh 2003/02/12 03:04:59
Modified:catalina/src/share/org/apache/catalina/core
StandardWrapperValve.java
Log:
Fix to return 404 for permanent UnavailableException and 503 for temporary
UnavailableException according to Servlet spec 2.4. It was still returning 503
for permanent UnavailableException for the first request to the page before this
fix.
Revision ChangesPath
1.12 +11 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java
Index: StandardWrapperValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- StandardWrapperValve.java 30 Jan 2003 18:22:47 - 1.11
+++ StandardWrapperValve.java 12 Feb 2003 11:04:59 - 1.12
@@ -308,11 +308,16 @@
//exception(request, response, e);
wrapper.unavailable(e);
long available = wrapper.getAvailable();
-if ((available 0L) (available Long.MAX_VALUE))
+if ((available 0L) (available Long.MAX_VALUE)) {
hres.setDateHeader(Retry-After, available);
-hres.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE,
+hres.sendError(HttpServletResponse.SC_SERVICE_UNAVAILABLE,
sm.getString(standardWrapper.isUnavailable,
wrapper.getName()));
+} else if (available == Long.MAX_VALUE) {
+hres.sendError(HttpServletResponse.SC_NOT_FOUND,
+sm.getString(standardWrapper.notFound,
+wrapper.getName()));
+}
// Do not save exception in 'throwable', because we
// do not want to do exception(request, response, e) processing
} catch (ServletException e) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java ValveUtil.java
Amy Roh wrote: Amy Roh wrote: Yes, but IMO, it's the admin's problem. The admin webapp shouldn't duplicate the functionality that it present elsewhere. Also, if the admin wishes to disable access from localhost (and access from elsewhere), then he has the right to do so. I see your point regarding the admin should let disabling access from localhost if it's accessing from elsewhere. How about if I remove checking for localhost and just keep the checking for admin's own ip and host? That's probably acceptable. It's not worth the complexity IMO, but it's up to you. Ok, go to bed now :) It's way too late for you, so I'm not integrating your patches for that tag ;-) lol. :-D I don't really care if it's included in *this* tag. I just wanted to come to an agreement between usability and dummy patience. ;-) I must be in european time zone for today. bonne nuit. Amy Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16988] New: - Can't create apr
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16988. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16988 Can't create apr Summary: Can't create apr Product: Tomcat 4 Version: 4.1.18 Platform: Other URL: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15776 OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: Other Component: Connector:Coyote JK 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] see bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15776. This dosnt seem to work on any port for me using redhat7.2. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java
amyroh 2003/02/12 03:47:07
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
RemoteAddrValveForm.java RemoteHostValveForm.java
Log:
Allow admin to add RemoteAddrValve and RemoteHostValve to prevent access
from localhost(127.0.0.1) in case the admin is accessed from elsewhere.
Revision ChangesPath
1.4 +8 -8
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteAddrValveForm.java
Index: RemoteAddrValveForm.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteAddrValveForm.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- RemoteAddrValveForm.java 11 Feb 2003 02:27:15 - 1.3
+++ RemoteAddrValveForm.java 12 Feb 2003 11:47:06 - 1.4
@@ -237,11 +237,11 @@
}
for (int i = 0; i denies.length; i++) {
-if (denies[i].match(127.0.0.1)) {
-errors.add(deny,
-new ActionError(error.denyIP));
-}
if (denies[i].match(ip)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyIP));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(ip)) {
errors.add(deny,
1.4 +12 -9
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteHostValveForm.java
Index: RemoteHostValveForm.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteHostValveForm.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- RemoteHostValveForm.java 11 Feb 2003 02:27:15 - 1.3
+++ RemoteHostValveForm.java 12 Feb 2003 11:47:06 - 1.4
@@ -240,12 +240,11 @@
}
for (int i = 0; i denies.length; i++) {
-if (denies[i].match(localhost) ||
-denies[i].match(127.0.0.1)) {
-errors.add(deny,
-new ActionError(error.denyHost));
-}
if (denies[i].match(host)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyHost));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(host)) {
errors.add(deny,
@@ -253,6 +252,10 @@
}
}
} else if (denies[i].match(ip)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyHost));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(ip)) {
errors.add(deny,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve RemoteAddrValveForm.java RemoteHostValveForm.java
amyroh 2003/02/12 03:47:41
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve
RemoteAddrValveForm.java RemoteHostValveForm.java
Log:
Port change.
Revision ChangesPath
1.3 +8 -8
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteAddrValveForm.java
Index: RemoteAddrValveForm.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteAddrValveForm.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- RemoteAddrValveForm.java 11 Feb 2003 03:34:43 - 1.2
+++ RemoteAddrValveForm.java 12 Feb 2003 11:47:41 - 1.3
@@ -237,11 +237,11 @@
}
for (int i = 0; i denies.length; i++) {
-if (denies[i].match(127.0.0.1)) {
-errors.add(deny,
-new ActionError(error.denyIP));
-}
if (denies[i].match(ip)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyIP));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(ip)) {
errors.add(deny,
1.3 +12 -9
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteHostValveForm.java
Index: RemoteHostValveForm.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/valve/RemoteHostValveForm.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- RemoteHostValveForm.java 11 Feb 2003 03:34:43 - 1.2
+++ RemoteHostValveForm.java 12 Feb 2003 11:47:41 - 1.3
@@ -240,12 +240,11 @@
}
for (int i = 0; i denies.length; i++) {
-if (denies[i].match(localhost) ||
-denies[i].match(127.0.0.1)) {
-errors.add(deny,
-new ActionError(error.denyHost));
-}
if (denies[i].match(host)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyHost));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(host)) {
errors.add(deny,
@@ -253,6 +252,10 @@
}
}
} else if (denies[i].match(ip)) {
+if (allows.length 1) {
+errors.add(deny,
+new ActionError(error.denyHost));
+}
for (int j = 0; j allows.length; j++) {
if (!allows[j].match(ip)) {
errors.add(deny,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16989] New: - Enable compression mimetypes configuration on Coyote connector
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16989. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16989 Enable compression mimetypes configuration on Coyote connector Summary: Enable compression mimetypes configuration on Coyote connector Product: Tomcat 4 Version: 4.0 Beta 1 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I would like to configure the Coyote compressable mimetypes on the server.xml configuration file, adding the text/javascript mimetype. You should add a new setCompressableMimetypes method on coyoteConnector.java, interfacing with addCompressableMimeType method on Http11Processor.java The params of this new setCompressableMimetypes method could be a string with the new mimetypes enabled separated by a colon. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16989] - Enable compression mimetypes configuration on Coyote connector
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16989. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16989 Enable compression mimetypes configuration on Coyote connector [EMAIL PROTECTED] changed: What|Removed |Added Version|4.0 Beta 1 |4.1.19 --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 11:52 --- Changing tomcat version. Sorry this is for 4.1.19 and upwards - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat won't startup
Dear All, when I try to start up tomcat I receive the following exception: Exception during startup processing java.lang.reflect.InvocationTargetException: java.lang.NoClassDefFoundError: org/apache/naming/JndiPermission at org.apache.naming.resources.DirContextURLStreamHandler.openConnection(DirContextURLStreamHandler.java:135) at java.net.URL.openConnection(URL.java:781) at sun.net.www.protocol.jar.JarURLConnection.init(JarURLConnection.java:67) at sun.net.www.protocol.jar.Handler.openConnection(Handler.java:27) at java.net.URL.openConnection(URL.java:781) at org.apache.catalina.startup.ContextConfig.tldConfigJar(ContextConfig.java:1091) at org.apache.catalina.startup.ContextConfig.tldConfig(ContextConfig.java:1042) at org.apache.catalina.startup.ContextConfig.start(ContextConfig.java:828) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:224) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:155) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1131) at org.apache.catalina.core.StandardContext.start(StandardContext.java:3334) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1123) at org.apache.catalina.core.StandardHost.start(StandardHost.java:612) at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1123) at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:307) at org.apache.catalina.core.StandardService.start(StandardService.java:388) at org.apache.catalina.core.StandardServer.start(StandardServer.java:505) at org.apache.catalina.startup.Catalina.start(Catalina.java:776) at org.apache.catalina.startup.Catalina.execute(Catalina.java:681) at org.apache.catalina.startup.Catalina.process(Catalina.java:179) at java.lang.reflect.Method.invoke(Native Method) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:243) am I missing a jar file somewhere or something else is wrong? Best Regards, Yakov Belov
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449
Race condition when compiling jsp pages
--- Additional Comments From [EMAIL PROTECTED] 2003-02-12 13:09 ---
Here you go, very easy way to reproduce the bug.
here is a patch for JspWrapperServlet.java, all it does is a Thread.sleep() to
make the condition easy to reproduce.
--- /old/JspServletWrapper.java 2003-02-10 11:29:52.0 -0500
+++ /new/JspServletWrapper.java 2003-02-12 08:02:39.0 -0500
@@ -148,11 +148,14 @@
try {
servletClass = ctxt.load();
+Thread.sleep(5000);
theServlet = (Servlet) servletClass.newInstance();
} catch( IllegalAccessException ex1 ) {
throw new JasperException( ex1 );
} catch( InstantiationException ex ) {
throw new JasperException( ex );
+} catch ( InterruptedException e ) {
+ e.printStackTrace();
}
theServlet.init(config);
now if you run the admin webapp without the jsp pages being precompiled and
rapidly click between two or three items in the tree as the pages are compiling
you will see the stacktrace for the null pointer exception.
The cause of this is still the sam, there is NO way around the flaws of the
double check in java, let me repeat there is NO way around it. Any place you
use the double check in java you will have a race condition.
If you don't care to fix the bug that is your choice, but I feel the bug should
be in a open or wontfix state, not a fixed state as the bug still does exist.
thanks,
john
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 14994] - https coyote connector leaving sockets in CLOSE_WAIT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14994. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14994 https coyote connector leaving sockets in CLOSE_WAIT [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 14:12 --- The possibility to set the socket linger? Is this a setting somwhere? Regarding it not being a problem, I've let it go as long as 3 days and the sockets are not recycled. Seems like a definite DoS problem when all I have to do is hammer the Refresh button on my browser for 30 seconds and I'll reach the acceptCount number of connections with CLOSE_WAIT's, thereby refusing connection for all other users for at least 3 days (and probably forever). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16979] - xercesImpl.jar in WEB-INF/lib does not override common/endorsed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16979. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16979 xercesImpl.jar in WEB-INF/lib does not override common/endorsed [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 14:45 --- I am using JDK 1.3.1 . - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 14994] - https coyote connector leaving sockets in CLOSE_WAIT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14994. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14994 https coyote connector leaving sockets in CLOSE_WAIT --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 15:16 --- We have recently experimented with Coyote and HTTPS. The symptoms we encountered are very similar to those described by Mike. After a very limited time HTTPS is blocked completely and never serves any further requests. (In our case, due to lack of time at the moment, we have simply reverted to the old deprecated https connector. I can thus unfortunately not supply any further information. This comment should be considered merely a FYI.) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17000] New: - [PATCH] Allow System.exit to be called if non-daemon threads exist on shutdown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17000. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17000 [PATCH] Allow System.exit to be called if non-daemon threads exist on shutdown Summary: [PATCH] Allow System.exit to be called if non-daemon threads exist on shutdown Product: Tomcat 5 Version: 5.0.0 Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Attached is a patch to StandardServer (and LocalStrings.properties) to allow System.exit to be called in the scenario non-daemon threads are running after a shutdown. This behavior is active ONLY if explicitly turned on by setting a new property in StandardServer called shutdownWait. This value represents the number of seconds to sleep (in another non-daemon thread) before calling System.exit. If accepted - I will go through the effort of submitting patches to work with the admin app. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17000] - [PATCH] Allow System.exit to be called if non-daemon threads exist on shutdown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17000. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17000 [PATCH] Allow System.exit to be called if non-daemon threads exist on shutdown --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 15:34 --- Created an attachment (id=4831) diff file of the files described - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 10852] - Patch: Add Connection Pooling to JNDIRealm
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10852. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10852 Patch: Add Connection Pooling to JNDIRealm [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 15:36 --- Closing bug since patch is old (and submitted by me). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449 Race condition when compiling jsp pages --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 16:14 --- What is your configuration for jasper, the default? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449 Race condition when compiling jsp pages --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 16:18 --- servlet servlet-namejsp/servlet-name servlet-classorg.apache.jasper.servlet.JspServlet/servlet-class init-param param-namelogVerbosityLevel/param-name param-valueWARNING/param-value /init-param init-param param-namekeepgenerated/param-name param-valuetrue/param-value /init-param load-on-startup3/load-on-startup /servlet - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449 Race condition when compiling jsp pages --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 16:33 --- I think I have now found the bug. The reload flag was getting set to false by ctxt.load() but theServlet had not yet been instantiated. Deferring the setting of the reload flag to false until after theServlet has been instantiated should fix the bug. Without your patch which forces a synchronize for every request. :-) I will be making the commits shortly. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java
glenn 2003/02/12 08:35:21 Modified:jasper2/src/share/org/apache/jasper Tag: tomcat_4_branch JspCompilationContext.java jasper2/src/share/org/apache/jasper/servlet Tag: tomcat_4_branch JspServletWrapper.java Log: Final fix for bug 16449 Revision ChangesPath No revision No revision 1.6.2.8 +3 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java Index: JspCompilationContext.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v retrieving revision 1.6.2.7 retrieving revision 1.6.2.8 diff -u -r1.6.2.7 -r1.6.2.8 --- JspCompilationContext.java10 Feb 2003 16:29:52 - 1.6.2.7 +++ JspCompilationContext.java12 Feb 2003 16:35:20 - 1.6.2.8 @@ -504,7 +504,6 @@ (Constants.getString(jsp.error.unable.compile), ex); } removed = 0; -jsw.setReload(false); return servletClass; } No revision No revision 1.6.2.4 +4 -3 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java Index: JspServletWrapper.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java,v retrieving revision 1.6.2.3 retrieving revision 1.6.2.4 diff -u -r1.6.2.3 -r1.6.2.4 --- JspServletWrapper.java10 Feb 2003 16:29:52 - 1.6.2.3 +++ JspServletWrapper.java12 Feb 2003 16:35:21 - 1.6.2.4 @@ -157,6 +157,7 @@ theServlet.init(config); firstTime = false; +reload = false; } } } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449 Race condition when compiling jsp pages --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 16:38 --- The logic in Jasper is just too complex :-( - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java
glenn 2003/02/12 08:37:11 Modified:jasper2/src/share/org/apache/jasper JspCompilationContext.java jasper2/src/share/org/apache/jasper/servlet JspServletWrapper.java Log: Final fix for bug 16449, ported from Tomcat 4 Revision ChangesPath 1.31 +3 -4 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java Index: JspCompilationContext.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspCompilationContext.java,v retrieving revision 1.30 retrieving revision 1.31 diff -u -r1.30 -r1.31 --- JspCompilationContext.java10 Feb 2003 16:38:59 - 1.30 +++ JspCompilationContext.java12 Feb 2003 16:37:11 - 1.31 @@ -609,7 +609,6 @@ ex); } removed = 0; -jsw.setReload(false); return servletClass; } 1.28 +4 -3 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java Index: JspServletWrapper.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JspServletWrapper.java,v retrieving revision 1.27 retrieving revision 1.28 diff -u -r1.27 -r1.28 --- JspServletWrapper.java11 Feb 2003 21:43:59 - 1.27 +++ JspServletWrapper.java12 Feb 2003 16:37:11 - 1.28 @@ -196,6 +196,7 @@ theServlet.init(config); firstTime = false; +reload = false; } } } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17010] New: - After some load HttpProcessor threads will die
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17010. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17010 After some load HttpProcessor threads will die Summary: After some load HttpProcessor threads will die Product: Tomcat 4 Version: 4.0.6 Final Platform: HP OS/Version: HP-UX Status: NEW Severity: Critical Priority: Other Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] After putting some stress on our web application we are getting hanging requests. We used OptimizeIT to trace the threads and it seems that after a while we get a log4j lock (tried 1.2.5 and currently trying 1.2.7) on a rolling file across multiple threads. These threads then exit and sometimes the StandardManager exits. When this happens our pages accept requests on port 80 but there are no responses since the Manager is dead. Thanks in advance for any help. Jim Kerwood - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17011] New: - tomcat status codes not documented anywhere
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17011 tomcat status codes not documented anywhere Summary: tomcat status codes not documented anywhere Product: Tomcat 4 Version: 4.0.3 Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Jasper 2 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I can't locate any documentation for the MINOR codes that are reported by Tomcat on failures The major codes are standard HTTP codes. The minor 4 digit codes are probably much more valuable for debugging specific problems BUT there is no documentation Do we have to randomly scan ALL open source looking for the minor status codes eg status code = 500 6787... Where is 6787 documented??? Thanks.. Jim Mason - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-5 build.properties.default build.xml
remm2003/02/12 09:26:15
Modified:.build.properties.default build.xml
Log:
- Update to digester 1.4.
- Update to NSIS 2.0b1 (I'll likely need to update the script, obviously ;-) ).
Revision ChangesPath
1.67 +7 -7 jakarta-tomcat-5/build.properties.default
Index: build.properties.default
===
RCS file: /home/cvs/jakarta-tomcat-5/build.properties.default,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -r1.66 -r1.67
--- build.properties.default 5 Feb 2003 08:44:09 - 1.66
+++ build.properties.default 12 Feb 2003 17:26:15 - 1.67
@@ -67,11 +67,11 @@
commons-launcher.loc=http://jakarta.apache.org/builds/jakarta-commons/release/commons-launcher/v0.9/commons-launcher-0.9.tar.gz
-# - Commons Digester, version 20020820 or later -
-commons-digester.home=${base.path}/commons-digester
-commons-digester.lib=${commons-digester.home}/dist
+# - Commons Digester, version 1.4 or later -
+commons-digester.home=${base.path}/commons-digester-1.4
+commons-digester.lib=${commons-digester.home}
commons-digester.jar=${commons-digester.lib}/commons-digester.jar
-commons-digester.loc=jakarta-commons/digester
+commons-digester.loc=http://www.apache.org/dist/jakarta/commons/digester/binaries/commons-digester-1.4.tar.gz
# - Commons Expression Language (EL) -
@@ -192,10 +192,10 @@
# - NSIS, version 2.0a7 or later -
-nsis.home=${base.path}/nsis-2.0
+nsis.home=${base.path}/nsis-2.0-b1
nsis.exe=${nsis.home}/makensis.exe
nsis.installoptions.dll=${nsis.home}/Plugins/InstallOptions.dll
-nsis.loc=http://telia.dl.sourceforge.net/sourceforge/nsis/nsis20b0.exe
+nsis.loc=http://telia.dl.sourceforge.net/sourceforge/nsis/nsis20b1.exe
# - Struts, version 1.1 Beta 2 or later -
1.79 +2 -3 jakarta-tomcat-5/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
retrieving revision 1.78
retrieving revision 1.79
diff -u -r1.78 -r1.79
--- build.xml 10 Feb 2003 19:17:51 - 1.78
+++ build.xml 12 Feb 2003 17:26:15 - 1.79
@@ -958,9 +958,8 @@
param name=destfile value=${logkit.jar}/
/antcall
-antcall target=cvsbuild
- param name=location value=${commons-digester.loc}/
- param name=subdir value=${commons-digester.home}/
+antcall target=downloadgz
+ param name=sourcefile value=${commons-digester.loc}/
param name=destfile value=${commons-digester.jar}/
/antcall
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17011] - tomcat status codes not documented anywhere
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17011 tomcat status codes not documented anywhere [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 17:29 --- Can you be more specific as to where the 6787 is originating? http://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html states the status line to be: Status-Line = HTTP-Version SP Status-Code SP Reason-Phrase CRLF There is no such thing as a minor 4 digit codes. Closing for now unless more clarification is given. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16449] - Race condition when compiling jsp pages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16449 Race condition when compiling jsp pages --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 17:33 --- Yeah, I noticed that right before lunch, but was waiting untill I got back.. I tested changing the reload = false after the newInstance() and all apeared to work ok, but I thought that the newInstance() happened in a seperate thread so the the instance might not be finished initializing at the time it was returned, which could still cause a race condition. not sure about this though.. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationDispatcher.java ApplicationHttpRequest.java
luehe 2003/02/12 09:39:11
Modified:catalina/src/share/org/apache/catalina/core
ApplicationDispatcher.java
ApplicationHttpRequest.java
Log:
According to SRV.4.1.1 (When Parameters Are Available), post form
data must be available to the servlet via the request object's input
stream until the first call to a method of the getParameter family.
Post form data used to be consumed from the input stream and added to
the parameter set *before* any such method call.
It is now read from the input stream as part of the method call.
Revision ChangesPath
1.9 +5 -9
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java
Index: ApplicationDispatcher.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- ApplicationDispatcher.java29 Jan 2003 01:42:38 - 1.8
+++ ApplicationDispatcher.java12 Feb 2003 17:39:11 - 1.9
@@ -466,11 +466,7 @@
if (queryString != null) {
wrequest.setAttribute(Globals.FORWARD_QUERY_STRING_ATTR,
queryString);
-}
-
-if (queryString != null) {
wrequest.setQueryString(queryString);
-wrequest.mergeParameters(queryString);
}
// only set the Dispatcher Type to Forward if it has not been set. It
will have
@@ -631,7 +627,7 @@
if (queryString != null) {
wrequest.setAttribute(Globals.INCLUDE_QUERY_STRING_ATTR,
queryString);
-wrequest.mergeParameters(queryString);
+ wrequest.setQueryString(queryString);
}
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
1.3 +74 -51
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
Index: ApplicationHttpRequest.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ApplicationHttpRequest.java 17 Dec 2002 20:06:20 - 1.2
+++ ApplicationHttpRequest.java 12 Feb 2003 17:39:11 - 1.3
@@ -190,6 +190,12 @@
StringManager.getManager(Constants.Package);
+/**
+ * Have the parameters for this request already been parsed?
+ */
+private boolean parsedParams = false;
+
+
// - ServletRequest Methods
@@ -276,6 +282,7 @@
*/
public String getParameter(String name) {
+ parseParameters();
synchronized (parameters) {
Object value = parameters.get(name);
if (value == null)
@@ -297,6 +304,7 @@
*/
public Map getParameterMap() {
+ parseParameters();
return (parameters);
}
@@ -308,6 +316,7 @@
*/
public Enumeration getParameterNames() {
+ parseParameters();
synchronized (parameters) {
return (new Enumerator(parameters.keySet()));
}
@@ -323,6 +332,7 @@
*/
public String[] getParameterValues(String name) {
+ parseParameters();
synchronized (parameters) {
Object value = parameters.get(name);
if (value == null)
@@ -389,7 +399,6 @@
// Package Methods
-
/**
* Return descriptive information about this implementation.
*/
@@ -423,47 +432,6 @@
/**
- * Merge the parameters from the specified query string (if any), and
- * the parameters already present on this request (if any), such that
- * the parameter values from the query string show up first if there are
- * duplicate parameter names.
- *
- * @param queryString The query string containing parameters to be merged
- */
-void mergeParameters(String queryString) {
-
-if ((queryString == null) || (queryString.length() 1))
-return;
-
-HashMap queryParameters = new HashMap();
-String encoding = getCharacterEncoding();
-if (encoding == null)
-encoding = ISO-8859-1;
-try {
-RequestUtil.parseParameters
-(queryParameters, queryString, encoding);
-} catch (Exception e)
DO NOT REPLY [Bug 17014] New: - ServletResponse.flushBuffer() no longer commits the response
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17014.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17014
ServletResponse.flushBuffer() no longer commits the response
Summary: ServletResponse.flushBuffer() no longer commits the
response
Product: Tomcat 4
Version: 4.1.18
Platform: All
OS/Version: Other
Status: NEW
Severity: Major
Priority: Other
Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
ServletResponse.flushBuffer() no longer commits the response (writing status
code and headers) as specified in the Servlet spec ...
public void flushBuffer() throws java.io.IOException
Forces any content in the buffer to be written to the client. A call
to this method automatically commits the response, meaning the status
code and headers will be written.
Presumably this was lost in the transition from HttpConnector to
CoyoteConnector. This can be fixed by altering
org.apache.coyote.tomcat4.CoyoteReponse.
public void flushBuffer() throws IOException {
// NEW *
if ( !isCommitted() )
coyoteResponse.sendHeaders();
// *
outputBuffer.flush();
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 13158] - Compliance issue - PageContext.Include with an unresolvable URL fails to throw an IllegalArgumentException.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13158. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13158 Compliance issue - PageContext.Include with an unresolvable URL fails to throw an IllegalArgumentException. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 18:25 --- The signature for this method has changed and no longer throws an IllegalArgumentException. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Patch: org.apache.catalina.util.RequestUtil
Hi folks!
I haven't contributed to tomcat in so long, I no
longer have a working password to apache.org! :-)
I.E. - my last commit predates the great break-in of
'01 and during that time I had moved, changed jobs,
etc. so I didn't get a new password back when they
were being reset. It feels cool to be posting to
tomcat-dev again! :-)
Well, sure enough, I have a change I need to commit.
Attached is a patch to fix an obscure use of a
deprecated java.lang.String method
(getBytes(int,int,byte[],int)). In this case the fix
is to simply use getBytes().
The patch I built applies the fix for
jakarta-tomcat-4.0/catalina/share/src/org/apache/catalina/util/RequestUtil.java
The same problem is also in the same file in the
jakarta-tomcat-catalina module. Are these sym-linked
together (i.e are they the same file?) or does the
change need to be submitted separately for identical
files in the separate modules?
I am working on a project that may require the removal
of the use of other deprecated API's and (among other
things) we are using an embedded form of tomcat that
may need to run on a VM that does not support
deprecated APIs. If someone would tell me who I
should contact to reset my committer account access
([EMAIL PROTECTED]), it would be very helpful.
Cheers,
Mel
Dr. Mel Martinez
[EMAIL PROTECTED]
[EMAIL PROTECTED]
__
Do you Yahoo!?
Yahoo! Shopping - Send Flowers for Valentine's Day
http://shopping.yahoo.com
Index: RequestUtil.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/RequestUtil.java,v
retrieving revision 1.19
diff -u -r1.19 RequestUtil.java
--- RequestUtil.java21 Feb 2002 22:51:55 - 1.19
+++ RequestUtil.java12 Feb 2003 17:18:27 -
@@ -331,9 +331,7 @@
throws UnsupportedEncodingException {
if ((data != null) (data.length() 0)) {
-int len = data.length();
-byte[] bytes = new byte[len];
-data.getBytes(0, len, bytes, 0);
+byte[] bytes = data.getBytes();
parseParameters(map, bytes, encoding);
}
@@ -371,9 +369,7 @@
if (str == null)
return (null);
-int len = str.length();
-byte[] bytes = new byte[len];
-str.getBytes(0, len, bytes, 0);
+byte[] bytes = str.getBytes();
return URLDecode(bytes, enc);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 21:19 --- Remy - Please look at the comments and versions # closely. Tomcat Version string is filled in the bug report (4.1.18), Apache version was specified in the comments (2.0.43/2.044). Just because it works in 5.x doesn't imply it will automatically work in 4.x (how callous to assume that ) Will be hapy to supply all the logs/config files. Let me attach them in the next email. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 17025] New: - Ajp13Processors can sometimes stop handling requests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17025. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17025 Ajp13Processors can sometimes stop handling requests Summary: Ajp13Processors can sometimes stop handling requests Product: Tomcat 4 Version: 4.0.4 Final Platform: Sun OS/Version: Solaris Status: NEW Severity: Critical Priority: Other Component: Connector:JK/AJP (deprecated) AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have noticed a condition that apparently prevent an Ajp13Processor from handling additional requests. The server environment includes: 4 webservers running iWS 6.0 SP5 and configured to use the iWS ajp connector 3 tomcat servers, tomcat 4.0.4, tomcat servers are set for max AjpProcessors of 512 each. The iWS servers load balance across all three tomcat servers. Occasionally in the catalina_log.*.txt files, I would notice IllegalArgumentExceptions like this: 2003-02-07 12:12:30 Ajp13Processor[8009][3] process: invoke java.lang.IllegalArgumentException: Cookie name EXPIRES is a reserved token at javax.servlet.http.Cookie.init(Cookie.java:185) at org.apache.ajp.tomcat4.Ajp13Request.addCookies(Ajp13Request.java:189) at org.apache.ajp.tomcat4.Ajp13Request.setAjpRequest(Ajp13Request.java:148) at org.apache.ajp.tomcat4.Ajp13Processor.process(Ajp13Processor.java:446) at org.apache.ajp.tomcat4.Ajp13Processor.run(Ajp13Processor.java:551) at java.lang.Thread.run(Thread.java:479) ls Usually followed pretty closely by a new Ajp13Processor being created: 2003-02-07 13:04:19 Ajp13Processor[8009][8] Starting background thread This would happen even on the weekends when I know the traffic is so much lower that the existing number of Ajp13Processors should handle the load just fine. I turned Ajp13Connector debugging on at one point to get a better handle on how things are behaving. What I noticed is once an Ajp13Processor has errored like the above, although it would reset itself, there was never any more log entries showing it accepting and procssing requests. Further, when I shut down any of the three tomcat servers, I would immediately see in the catalina_log.*.txt files of the other two server that additional Ajp13Connectors were being created *and* they immediately speq the IllegalArgumentException. It would seem that although the Ajp13Connector things it has reset itself, it hasn't let the web server on the other side of the connection know about this, assuming the Ajp13Connector just hasn't replied yet. Note bug 5181 and bug 7177 may be related issues. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 21:50 --- Created an attachment (id=4838) worker 2 conf with JNI config - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 21:52 --- Created an attachment (id=4839) httpd conf with mod_jk2 module - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 21:54 --- Created an attachment (id=4840) Jk2.properties with in process enabled - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-12 21:55 --- Created an attachment (id=4841) server.xml with ajp13 out-process connector disabled for JNI - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans MBeanUtils.java
costin 2003/02/12 14:06:33
Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanUtils.java
Log:
Add registration for servlet wrappers and support for jsr77-like names - all the
code is optional and conditional on a flag. If the flag is not set - nothing
will happen ( or change )
Revision ChangesPath
1.47 +114 -9
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java
Index: MBeanUtils.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -r1.46 -r1.47
--- MBeanUtils.java 22 Nov 2002 04:44:10 - 1.46
+++ MBeanUtils.java 12 Feb 2003 22:06:33 - 1.47
@@ -77,8 +77,8 @@
import javax.management.OperationsException;
import javax.management.modelmbean.InvalidTargetObjectTypeException;
import javax.management.modelmbean.ModelMBean;
+
import org.apache.catalina.Connector;
-import org.apache.catalina.Contained;
import org.apache.catalina.Container;
import org.apache.catalina.Context;
import org.apache.catalina.DefaultContext;
@@ -98,6 +98,8 @@
import org.apache.catalina.User;
import org.apache.catalina.UserDatabase;
import org.apache.catalina.Valve;
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.Contained;
import org.apache.catalina.connector.http.HttpConnector;
import org.apache.catalina.core.StandardService;
import org.apache.catalina.deploy.ContextEnvironment;
@@ -166,6 +168,7 @@
*/
private static MBeanServer mserver = createServer();
+static boolean jsr77Names=false;
// - Static Methods
@@ -258,11 +261,33 @@
ModelMBean mbean = managed.createMBean(context);
ObjectName oname = createObjectName(domain, context);
mserver.registerMBean(mbean, oname);
+if( jsr77Names ) {
+oname = createObjectName77(domain, context);
+mserver.registerMBean(mbean, oname);
+}
+return (mbean);
+}
+
+public static ModelMBean createMBean(Wrapper wrapper)
+throws Exception {
+
+String mname = createManagedName(wrapper);
+ManagedBean managed = registry.findManagedBean(mname);
+if (managed == null) {
+Exception e = new Exception(ManagedBean is not found with +mname);
+throw new MBeanException(e);
+}
+String domain = managed.getDomain();
+if (domain == null)
+domain = mserver.getDefaultDomain();
+ModelMBean mbean = managed.createMBean(wrapper);
+ObjectName oname = createObjectName(domain, wrapper);
+mserver.registerMBean(mbean, oname);
return (mbean);
}
-
+
/**
* Create, register, and return an MBean for this
* codeContextEnvironment/code object.
@@ -563,6 +588,9 @@
domain = mserver.getDefaultDomain();
ModelMBean mbean = managed.createMBean(factory);
ObjectName oname = createObjectName(domain, factory);
+if( mserver.isRegistered(oname)) {
+mserver.unregisterMBean(oname);
+}
mserver.registerMBean(mbean, oname);
return (mbean);
@@ -904,7 +932,57 @@
}
-
+public static ObjectName createObjectName77(String domain,
+Context context)
+throws MalformedObjectNameException {
+
+ObjectName name = null;
+Host host = (Host)context.getParent();
+Service service = ((Engine)host.getParent()).getService();
+String path = context.getPath();
+if (path.length() 1)
+path = /;
+String localName= // +
+((host.getName()==null)? DEFAULT : host.getName()) + path;
+name = new ObjectName(domain + :j2eeType=WebModule,name= +
+ localName + ,j2eeApplication=none,j2eeServer=none);
+return (name);
+}
+
+/**
+ * Create an codeObjectName/code for this
+ * codeContext/code object.
+ *
+ * @param domain Domain in which this name is to be created
+ * @param context The Context to be named
+ *
+ * @exception MalformedObjectNameException if a name cannot be created
+ */
+public static ObjectName createObjectName(String domain,
+ Wrapper wrapper)
+throws MalformedObjectNameException {
+
+ObjectName name = null;
+Context context=(Context)wrapper.getParent();
+Host host = (Host)context.getParent();
+Service service
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans ServerLifecycleListener.java
costin 2003/02/12 14:11:27
Modified:catalina/src/share/org/apache/catalina/mbeans
ServerLifecycleListener.java
Log:
Added optional wrapper and jsr77 names - conditional on a flag.
No change in behavior should be visible if the flag is not set.
I tested the unloading and reloading - and it works fine.
( well, there are some problems with full server reloading - but they
were in before )
Revision ChangesPath
1.37 +96 -13
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ServerLifecycleListener.java
Index: ServerLifecycleListener.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/ServerLifecycleListener.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- ServerLifecycleListener.java 30 Jan 2003 20:46:51 - 1.36
+++ ServerLifecycleListener.java 12 Feb 2003 22:11:27 - 1.37
@@ -75,31 +75,40 @@
import javax.management.MBeanException;
import javax.management.MBeanServer;
import javax.management.ObjectName;
+
import org.apache.catalina.Connector;
import org.apache.catalina.Container;
-import org.apache.catalina.ContainerEvent;
-import org.apache.catalina.ContainerListener;
import org.apache.catalina.Context;
import org.apache.catalina.DefaultContext;
import org.apache.catalina.Engine;
-import org.apache.catalina.Globals;
+import org.apache.catalina.Group;
import org.apache.catalina.Host;
+import org.apache.catalina.LifecycleEvent;
+import org.apache.catalina.LifecycleListener;
import org.apache.catalina.Loader;
import org.apache.catalina.Logger;
import org.apache.catalina.Manager;
-import org.apache.catalina.Lifecycle;
-import org.apache.catalina.LifecycleEvent;
-import org.apache.catalina.LifecycleListener;
import org.apache.catalina.Realm;
+import org.apache.catalina.Role;
import org.apache.catalina.Server;
import org.apache.catalina.ServerFactory;
import org.apache.catalina.Service;
+import org.apache.catalina.User;
+import org.apache.catalina.UserDatabase;
import org.apache.catalina.Valve;
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.Contained;
+import org.apache.catalina.ContainerListener;
+import org.apache.catalina.ContainerEvent;
+import org.apache.catalina.Lifecycle;
+import org.apache.catalina.Globals;
import org.apache.catalina.core.StandardContext;
import org.apache.catalina.core.StandardEngine;
import org.apache.catalina.core.StandardHost;
import org.apache.catalina.core.StandardServer;
import org.apache.catalina.core.StandardService;
+import org.apache.catalina.core.StandardWrapper;
+import org.apache.catalina.core.ContainerBase;
import org.apache.catalina.deploy.ContextEnvironment;
import org.apache.catalina.deploy.ContextResource;
import org.apache.catalina.deploy.ContextResourceLink;
@@ -128,6 +137,7 @@
* The debugging detail level for this component.
*/
protected int debug = 0;
+boolean jsr77Names=false;
public int getDebug() {
return (this.debug);
@@ -137,6 +147,16 @@
this.debug = debug;
}
+public void setJsr77Names( boolean b ) {
+MBeanUtils.jsr77Names=b;
+jsr77Names=b;
+}
+
+/** Enable registration of contexts and servlet wrappers using JSR77 naming
pattern.
+ */
+public boolean getJsr77Names() {
+return jsr77Names;
+}
/**
* Semicolon separated list of paths containing MBean desciptor resources.
@@ -209,7 +229,8 @@
// We are embedded.
if( lifecycle instanceof Service ) {
-log( Starting embeded + lifecycle);
+if( debug 0 )
+log( Starting embeded + lifecycle);
try {
MBeanFactory factory = new MBeanFactory();
createMBeans(factory);
@@ -441,6 +462,18 @@
MBeanUtils.createMBean(cRealm);
}
+// Create the mbeans for servlets
+if( jsr77Names ) {
+Container childs[]=context.findChildren();
+for( int i=0; ichilds.length; i++ ) {
+StandardWrapper wrapper=(StandardWrapper)childs[i];
+// XXX prevent duplicated registration
+if( debug 0 )
+log(Register child wrapper (findChildren) + wrapper);
+MBeanUtils.createMBean( wrapper );
+}
+}
+
// Create the MBeans for the associated Valves
if (context instanceof StandardContext) {
Valve cValves[] = ((StandardContext)context).getValves();
@@ -449,8 +482,7 @@
[PATCH] Added app column to tomcat$sessions
I wrote a patch to JDBCStore.java that adds a new column to the
tomcat$sessions table to hold information about the webapp that is
trying to save the session.
The need for this comes when you run multiple webapps which each may
have classes in session that are unique to the webapp. As written,
JDBCStore tries to pull all webapps from the database regardless of who
generated them. Exceptions ensue.
With this patch, a webapp will only read and write sessions that belong
to it. I much prefer this to creating multiple tomcat$session tables
because of the testing and maintenance aspects. Hopefully somebody
will agree enough to consider applying this patch.
Cheers,
~Tom
p.s. With all the fixes I've submitted, my version of Tomcat has a much
more stable implementation of JDBCStore than the controlled version ...
good for me but bad for everyone else ... what's the trick to getting
the patches accepted?
Index: JDBCStore.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/JDBCStore.java,v
retrieving revision 1.9
diff -r1.9 JDBCStore.java
11c11
* Copyright (c) 1999 The Apache Software Foundation. All rights
---
* Copyright (c) 1999, 2003 The Apache Software Foundation. All rights
82a83
import java.util.ArrayList;
125a127,131
/**
* name associated with this app
*/
private String myName = null;
144a151,155
* App column to use.
*/
protected String sessionAppCol = app;
/**
219a231,245
* Return the name for this instance (built from container name)
*/
public String getName() {
if (myName == null) {
Container container = manager.getContainer();
if (container.getParent() == null) {
myName = container.getName();
} else {
myName = container.getParent().getName() + container.getName();
}
}
return myName;
}
/**
300a327,346
* Set the App column for the table.
*
* @param sessionAppCol the column name
*/
public void setSessionAppCol(String sessionAppCol) {
String oldSessionAppCol = this.sessionAppCol;
this.sessionAppCol = sessionAppCol;
support.firePropertyChange(sessionAppCol,
oldSessionAppCol,
this.sessionAppCol);
}
/**
* Return the Id column for the table.
*/
public String getSessionAppCol() {
return(this.sessionAppCol);
}
/**
391,393c437,438
SELECT COUNT(s.+sessionIdCol+), c.+sessionIdCol+
FROM +sessionTable+ s, +sessionTable+ c+
GROUP BY c.+sessionIdCol;
---
SELECT +sessionIdCol+ FROM +sessionTable +
WHERE + sessionAppCol + = ?;
406a452
preparedKeysSql.setString(1, getName());
408,414c454,460
if (rst != null rst.next()) {
keys = new String[rst.getInt(1)];
keys[0] = rst.getString(2);
i=1;
while(rst.next())
keys[i++] = rst.getString(2);
---
if (rst != null) {
ArrayList ids = new ArrayList();
while(rst.next()) {
String id = rst.getString(1);
ids.add(id);
}
keys = (String[])ids.toArray(new String[ids.size()]);
445c491,492
) FROM .concat(sessionTable);
---
) FROM .concat(sessionTable) +
WHERE + sessionAppCol + = ?;
455a503
preparedSizeSql.setString(1, getName());
497c545
WHERE +sessionIdCol+ = ?;
---
WHERE +sessionIdCol+ = ? AND + sessionAppCol + = ?;
506a555
preparedLoadSql.setString(2, getName());
630a680
sessionAppCol+, +
634c684
sessionLastAccessedCol+) VALUES (?, ?, ?, ?, ?);
---
sessionLastAccessedCol+) VALUES (?, ?, ?, ?, ?, ?);
665,668c715,719
preparedSaveSql.setBinaryStream(2, in, size);
preparedSaveSql.setString(3, session.isValid()?1:0);
preparedSaveSql.setInt(4, session.getMaxInactiveInterval());
preparedSaveSql.setLong(5, session.getLastAccessedTime());
---
preparedSaveSql.setString(2, getName());
preparedSaveSql.setBinaryStream(3, in, size);
preparedSaveSql.setString(4, session.isValid()?1:0);
preparedSaveSql.setInt(5, session.getMaxInactiveInterval());
preparedSaveSql.setLong(6, session.getLastAccessedTime());
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/xmlparser XMLEncodingDetector.java XercesEncodingDetector.java
luehe 2003/02/12 15:44:24
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
PageInfo.java ParserController.java Validator.java
jasper2/src/share/org/apache/jasper/xmlparser
XMLEncodingDetector.java
XercesEncodingDetector.java
Log:
Last round of encoding-determination changes, to comply with the spec.
Revision ChangesPath
1.52 +1 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java
Index: Compiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/Compiler.java,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- Compiler.java 12 Feb 2003 02:22:51 - 1.51
+++ Compiler.java 12 Feb 2003 23:44:22 - 1.52
@@ -210,7 +210,7 @@
pageInfo.setELIgnoredSpecified(true);
}
pageInfo.setIsXml(JspUtil.booleanValue(jspProperty.isXml()));
- pageInfo.setPageEncoding(jspProperty.getPageEncoding());
+ pageInfo.setConfigEncoding(jspProperty.getPageEncoding());
pageInfo.setELIgnored(JspUtil.booleanValue(jspProperty.isELIgnored()));
pageInfo.setScriptingInvalid(JspUtil.booleanValue(jspProperty.isScriptingInvalid()));
if (jspProperty.getIncludePrelude() != null) {
1.19 +30 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageInfo.java
Index: PageInfo.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/PageInfo.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- PageInfo.java 12 Feb 2003 02:22:51 - 1.18
+++ PageInfo.java 12 Feb 2003 23:44:22 - 1.19
@@ -89,6 +89,17 @@
private String errorPage = null;
private String pageEncoding = null;
+// Encoding specified in JSP config element
+private String configEncoding;
+
+/*
+ * Indicates whether an encoding has been explicitly specified in the
+ * page's XML prolog (only used for pages in XML syntax).
+ * This information is used to decide whether a translation error must
+ * be reported for encoding conflicts.
+ */
+private boolean isEncodingSpecifiedInProlog;
+
private int maxTagNesting = 0;
private boolean scriptless = false;
private boolean scriptingInvalid = false;
@@ -228,6 +239,22 @@
public String getPageEncoding() {
return pageEncoding;
+}
+
+public void setIsEncodingSpecifiedInProlog(boolean isSpecified) {
+ this.isEncodingSpecifiedInProlog = isSpecified;
+}
+
+public boolean isEncodingSpecifiedInProlog() {
+ return this.isEncodingSpecifiedInProlog;
+}
+
+public void setConfigEncoding(String enc) {
+ this.configEncoding = enc;
+}
+
+public String getConfigEncoding() {
+ return this.configEncoding;
}
public int getMaxTagNesting() {
1.32 +35 -27
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java
Index: ParserController.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/ParserController.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- ParserController.java 27 Jan 2003 23:15:33 - 1.31
+++ ParserController.java 12 Feb 2003 23:44:23 - 1.32
@@ -199,27 +199,23 @@
figureOutJspDocument(absFileName, jarFile);
if (isTopFile) {
- if (isXml) {
- // Make sure the encoding determined from the XML prolog
- // matches that in the JSP config element, if present.
- // Treat UTF-16, UTF-16BE, and UTF-16LE as identical.
- String jspConfigPageEnc = pageInfo.getPageEncoding();
+ if (isXml pageInfo.isEncodingSpecifiedInProlog()) {
+ /*
+ * Make sure the encoding explicitly specified in the XML
+ * prolog (if any) matches that in the JSP config element
+ * (if any), treating UTF-16, UTF-16BE, and UTF-16LE as
+ * identical.
+ */
+ String jspConfigPageEnc = pageInfo.getConfigEncoding();
if (jspConfigPageEnc != null
!jspConfigPageEnc.equals(sourceEnc)
- (!jspConfigPageEnc.startsWith(UTF-16)
+ (!jspConfigPageEnc.startsWith(UTF-16)
|| !sourceEnc.startsWith(UTF-16))) {
Jasper JSP forward infinite loop bug ?
Hi, When I was using HttpUnit's ServletUnit and ServletRunner(webInfDir + /web.xml,) to test a JSP (using Jasper as a mock object, no full-blown server), I found that Jasper's pageContext.forward() method was causing stack overflow because it forwarded to the original JSP itself, causing an infinite loop. I had to patch Jasper's source to make it work. Has any one else seen a similar problem? How did you address it? I was using Tomcat 4.1.18 source. My patch: --- jakarta-tomcat-4.1.18-src/jasper/src/share/org/apache/jasper/runtime/PageContextImpl.java 2002-12-19 08:51:54.0 -0500 +++ /home/zcai/PageContextImpl.java 2003-02-12 18:03:42.0 -0500 @@ -422,6 +422,8 @@ } String path = getAbsolutePathRelativeToContext(relativeUrlPath); +// zcai, remember we need to ask JspServlet to process the JSP page we are forwarding to, not the original one +request.setAttribute(org.apache.jasper.Constants.JSP_FILE, path); String includeUri = (String) request.getAttribute(Constants.INC_SERVLET_PATH); if (includeUri != null) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TC 5.0 nightly builds
Hi, I'm in a process of getting an account on nagoya where I will install a script that will do the the nightly build (for Tomcat 5). I should have something automated for the week-end if all goes well :-) -- Jeanfrancois Remy Maucherat wrote: jean-frederic clere wrote: Remy Maucherat wrote: Getting reliable Nightlies will have a side effect to improve the build system and make themselves nearly useless ;-) Something like ant night. For the moment I am not able to build Nightlies because of the firewall and because the ant download task mixes cvs and http download: I have to do cvs via SOCKS5 and http via a proxy. So I am thinking to separate the cvs and http downloads. Any comments? I need something like: /usr/local/socksified/bin/runsocks ant downloadcvs ant downloadhttp Of course ant download will still do its actual task. That seems a good idea :) Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources messages.properties
luehe 2003/02/12 18:41:26
Modified:jasper2/src/share/org/apache/jasper/compiler
JspDocumentParser.java
jasper2/src/share/org/apache/jasper/resources
messages.properties
Log:
added support for jsp:fallback action to XML syntax
Revision ChangesPath
1.38 +7 -4
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java
Index: JspDocumentParser.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JspDocumentParser.java,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- JspDocumentParser.java7 Feb 2003 20:16:18 - 1.37
+++ JspDocumentParser.java13 Feb 2003 02:41:26 - 1.38
@@ -589,9 +589,12 @@
node = new Node.DoBodyAction(attrsCopy, start, current);
} else if (qName.equals(JSP_ELEMENT)) {
node = new Node.JspElement(attrsCopy, start, current);
+ } else if (qName.equals(JSP_FALLBACK)) {
+ node = new Node.FallBackAction(start, current);
} else {
throw new SAXParseException(
- Localizer.getMessage(jsp.error.badStandardAction),
+ Localizer.getMessage(jsp.error.xml.badStandardAction,
+ qName),
locator);
}
1.92 +2 -1
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties
Index: messages.properties
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources/messages.properties,v
retrieving revision 1.91
retrieving revision 1.92
diff -u -r1.91 -r1.92
--- messages.properties 10 Feb 2003 18:21:32 - 1.91
+++ messages.properties 13 Feb 2003 02:41:26 - 1.92
@@ -306,6 +306,7 @@
jsp.error.duplicate.name.jspattribute=The attribute {0} specified in the standard
or custom action also appears as the value of the name attribute in the enclosed
jsp:attribute
jsp.error.not.in.template={0} not allowed in a template text body.
jsp.error.badStandardAction=Invalid standard action
+jsp.error.xml.badStandardAction=Invalid standard action: {0}
jsp.error.tagdirective.badbodycontent=Invalid body-content ({0}) in tag directive
jsp.error.config_pagedir_encoding_mismatch=Page-encoding specified in
jsp-property-group ({0}) is different from that specified in page directive ({1})
jsp.error.prolog_pagedir_encoding_mismatch=Page-encoding specified in XML prolog
({0}) is different from that specified in page directive ({1})
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-13 03:36 --- A quick question to Remy: are you running Microsoft Windows for your mod_jk2/JNI inprocess setup? I actually have seen quite some success stories for Windows users but nobody from Unix world has had any success yet. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-13 03:39 --- Rahul, your httpd.conf has mod_jk2.dll so I assume you are Microsoft Windows also? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16974] - JNI broken in jk2 - due to jk2_channel_jni_open()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16974 JNI broken in jk2 - due to jk2_channel_jni_open() --- Additional Comments From [EMAIL PROTECTED] 2003-02-13 03:45 --- If you are Windows user, this howto will get you going: http://www.gregoire.org/howto/Apache2_Jk2_TC4.1.x_JSDK1.4.x.html but what about us Unix users? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat + NES on Solaris
Does anyone have a compiled copy of nsapi_redirector.so for Solaris 8, Tomcat 4.1.18 and NES 4? I have been unable to compile it myself because I don't have the Netscape SuiteSpot libraries. I would really appreciate it if somebody could forward me a binary or point me to a website where I can find one. Rest assured, I already tried just about every channel possible before resorting to this list. Regards, Craig Pardey ** * IMPORTANT INFORMATION* This document should be read only by those persons to whom it is addressed and its content is not intended for use by any other persons. If you have received this message in error, please notify us immediately. Please also destroy and delete the message from your computer. Any unauthorised form of reproduction of this message is strictly prohibited. St.George is not liable for the proper and complete transmission of the information contained in this communication, nor for any delay in its receipt. **
[ANN] Tomcat 4.1.20 Alpha released
Tomcat 4.1.20 Alpha is now available for testing. Changes over Tomcat 4.1.19 include: - Fix classloading failures when using Tomcat in JNI mode with JK 2 - Upgrade to Xerces 2.3.0 - Admin webapp fixes (including fixes to saving to server.xml) - Disable recycling of sessions - Refactoring of session persistence - Disable socket linger in Coyote HTTP/1.1 (delay when closing a socket), and allow configuring it - Allow cross context from the root context - Documentation updates - Fix memory leak in Jasper when compiling JSP pages - Fix JspC, which may now be used again for complex webapps precompilation, such as Tomcat's own admin webapp - Fix isThreadSafe feature in Jasper - Fix JspWriter recycling after an exception was thrown in a tag's body content The release notes include the full list of changes. Downloads: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/release/v4.1.20-alpha/ Remy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ErrorDispatcherValve.java
amyroh 2003/02/12 23:22:01
Modified:catalina/src/share/org/apache/catalina/valves
ErrorDispatcherValve.java
Log:
Fix to return an error-page for 500 if it's defined in web.xml.
If ErrorDispatcherValve does not find an error-page for an internal error, it sets
the error code to 500 but does not then try to see if there is an error-page
mapping for this error code.
If the servlet throws an exception that does not map to an error-page, then we
should set the error-code to 500 and see if there is an error-page for 500 and
if so, return that. Most users will configure a generic error-page for 500
rather than for exception-types.
Fix for bugtraq 4685997.
Revision ChangesPath
1.5 +27 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorDispatcherValve.java
Index: ErrorDispatcherValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorDispatcherValve.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ErrorDispatcherValve.java 4 Nov 2002 06:33:02 - 1.4
+++ ErrorDispatcherValve.java 13 Feb 2003 07:22:01 - 1.5
@@ -258,7 +258,22 @@
log(Exception Processing + errorPage, e);
}
}
+} else {
+// A custom error-page has not been defined for the exception
+// that was thrown during request processing. Check if an
+// error-page for error code 500 was specified and if so,
+// send that page back as the response.
+ServletResponse sresp = (ServletResponse) response;
+if (sresp instanceof HttpServletResponse) {
+((HttpServletResponse) sresp).setStatus(
+HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
+// The response is an error
+response.setError();
+
+status(request, response);
+}
}
+
}
@@ -389,7 +404,14 @@
try {
// Reset the response if possible (else IllegalStateException)
-hres.reset();
+//hres.reset();
+// Reset the response (keeping the real error code and message)
+Integer statusCodeObj =
+(Integer) hreq.getAttribute(Globals.STATUS_CODE_ATTR);
+int statusCode = statusCodeObj.intValue();
+String message =
+(String) hreq.getAttribute(Globals.ERROR_MESSAGE_ATTR);
+((HttpResponse) response).reset(statusCode, message);
// Forward control to the specified location
ServletContext servletContext =
@@ -451,4 +473,3 @@
}
-
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
