DO NOT REPLY [Bug 20527] - solution to Unable to compile class for JSP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20527. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20527 solution to Unable to compile class for JSP --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 07:05 --- see http://jakarta.apache.org/tomcat/faq/misc.html#compile - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 16688] - JSP's not compiling - javac: invalid flag: C:\Java\jars\Tomcat
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16688.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16688
JSP's not compiling - javac: invalid flag: C:\Java\jars\Tomcat
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
URL||http://jakarta.apache.org/to
||mcat/faq/misc.html#compile
Summary|JSP's not compiling |JSP's not compiling -
||javac: invalid flag:
||C:\Java\jars\Tomcat
--- Additional Comments From [EMAIL PROTECTED] 2003-07-19 07:29 ---
I have the same problem with a different spin to it:
In the browser, I see
org.apache.jasper.JasperException: Unable to compile class for JSP
An error occurred at line: -1 in the jsp file: null
Generated servlet error:
[javac] Since fork is true, ignoring compiler setting.
[javac] Compiling 1 source file
[javac] Since fork is true, ignoring compiler setting.
[javac] javac: invalid flag: C:\Java\jars\Tomcat
[javac] Usage: javac
[javac] where possible options include:
[javac] -gGenerate all debugging info
[javac] -g:none Generate no debugging info
[javac] -g:{lines,vars,source}Generate only some debugging info
[javac] -nowarn Generate no warnings
[javac] -verbose Output messages about what the compiler
is doing
[javac] -deprecation Output source locations where deprecated
APIs are used
[javac] -classpath Specify where to find user class files
[javac] -sourcepath Specify where to find input source files
[javac] -bootclasspath Override location of bootstrap class files
[javac] -extdirsOverride location of installed extensions
[javac] -d Specify where to place generated class files
[javac] -encoding Specify character encoding used by source files
[javac] -source Provide source compatibility with specified release
[javac] -target Generate class files for specific VM version
[javac] -help Print a synopsis of standard options
at
org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:130)
at
org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:293)
at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:353)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:370)
In catalina.out
19.07.2003 07:52:43 org.apache.coyote.http11.Http11Protocol start
INFO: Starting Coyote HTTP/1.1 on port 8443
Compile failed; see the compiler error output for details.
at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:842)
at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:682)
at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:317)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:370)
...
I solved it by re-installing tomcat in a directory that has no spaces in its
path. I don't know how I fell into this problem, because before, I ran tomcat
dozens of times successfully even with the space in the ..cat 4.1.
Suggestions:
For the exception case, have org.apache.jasper.compiler.Compiler.compile or
org.apache.tools.ant.taskdefs.Javac.compile with which arguments they call javac
and where they get them from!
One more strange observation:
- even though I installed with windows installer, the windows registry is
unchanged (still has the old paths with spaces e.g. in JVM Option Number 0 or
System.err File)
- it even has as JVM library a jdk1.3... that I deleted months ago
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat JdkCompat.java
remm2003/07/19 01:32:54
Modified:util/java/org/apache/tomcat/util/compat JdkCompat.java
Log:
- Apply Tim Funk's patch to trunk the stacktrace on older JDK.
- Add a -4 offset to try to remove the \tat in front of the trace line.
Revision ChangesPath
1.6 +10 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java
Index: JdkCompat.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- JdkCompat.java18 Jul 2003 22:24:37 - 1.5
+++ JdkCompat.java19 Jul 2003 08:32:54 - 1.6
@@ -210,7 +210,13 @@
public String getPartialServletStackTrace(Throwable t) {
StringWriter stackTrace = new StringWriter();
t.printStackTrace(new PrintWriter(stackTrace));
-return stackTrace.toString();
+String st = stackTrace.toString();
+int i = st.lastIndexOf(javax.servlet.);
+if (i -1) {
+return st.substring(0, i);
+} else {
+return st;
+}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21172] - Problem setting cookies on coyote connector
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21172. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21172 Problem setting cookies on coyote connector [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 08:50 --- I haven't re-checked, but this may have been due to my using an older version of mod_jk2.so that I was using on the apache side. See my comments on bug 234. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat JdkCompat.java
remm2003/07/19 02:05:11
Modified:util/java/org/apache/tomcat/util/compat JdkCompat.java
Log:
- Forgot the offset, oops.
Revision ChangesPath
1.7 +4 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java
Index: JdkCompat.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- JdkCompat.java19 Jul 2003 08:32:54 - 1.6
+++ JdkCompat.java19 Jul 2003 09:05:11 - 1.7
@@ -213,7 +213,7 @@
String st = stackTrace.toString();
int i = st.lastIndexOf(javax.servlet.);
if (i -1) {
-return st.substring(0, i);
+return st.substring(0, i - 4);
} else {
return st;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat Jdk14Compat.java JdkCompat.java
remm2003/07/19 03:03:29
Modified:util/java/org/apache/tomcat/util/compat Jdk14Compat.java
JdkCompat.java
Log:
- Improve filter exception trace.
- I'll add a note in the HTML that the full stack trace of the root cause is
available in the logs.
Revision ChangesPath
1.5 +12 -8
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/Jdk14Compat.java
Index: Jdk14Compat.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/Jdk14Compat.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Jdk14Compat.java 18 Jul 2003 22:24:37 - 1.4
+++ Jdk14Compat.java 19 Jul 2003 10:03:29 - 1.5
@@ -132,14 +132,18 @@
trace.append(t.toString()).append('\n');
StackTraceElement[] elements = t.getStackTrace();
int pos = elements.length;
-for (int i = (elements.length - 1); i = 0; i--) {
-if (elements[i].getClassName().startsWith(javax.servlet.)) {
-pos = i + 1;
-break;
+for (int i = 0; i elements.length; i++) {
+if ((elements[i].getClassName().startsWith
+ (org.apache.catalina.core.ApplicationFilterChain))
+ (elements[i].getMethodName().equals(internalDoFilter))) {
+pos = i;
}
}
for (int i = 0; i pos; i++) {
-trace.append('\t').append(elements[i].toString()).append('\n');
+if (!(elements[i].getClassName().startsWith
+ (org.apache.catalina.core.))) {
+trace.append('\t').append(elements[i].toString()).append('\n');
+}
}
return trace.toString();
}
1.8 +6 -5
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java
Index: JdkCompat.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- JdkCompat.java19 Jul 2003 09:05:11 - 1.7
+++ JdkCompat.java19 Jul 2003 10:03:29 - 1.8
@@ -141,7 +141,7 @@
javaVersion = JAVA_1_3;
Class.forName(java.lang.CharSequence);
javaVersion = JAVA_1_4;
-java14=true;
+//java14=true;
} catch (ClassNotFoundException cnfe) {
// swallow as we've hit the max class version that we have
}
@@ -211,7 +211,8 @@
StringWriter stackTrace = new StringWriter();
t.printStackTrace(new PrintWriter(stackTrace));
String st = stackTrace.toString();
-int i = st.lastIndexOf(javax.servlet.);
+int i = st.lastIndexOf
+(org.apache.catalina.core.ApplicationFilterChain.internalDoFilter);
if (i -1) {
return st.substring(0, i - 4);
} else {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat JdkCompat.java
remm2003/07/19 03:04:05
Modified:util/java/org/apache/tomcat/util/compat JdkCompat.java
Log:
- Forgot to reset my debugging flag.
Revision ChangesPath
1.9 +4 -4
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java
Index: JdkCompat.java
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/compat/JdkCompat.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- JdkCompat.java19 Jul 2003 10:03:29 - 1.8
+++ JdkCompat.java19 Jul 2003 10:04:05 - 1.9
@@ -141,7 +141,7 @@
javaVersion = JAVA_1_3;
Class.forName(java.lang.CharSequence);
javaVersion = JAVA_1_4;
-//java14=true;
+java14=true;
} catch (ClassNotFoundException cnfe) {
// swallow as we've hit the max class version that we have
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java LocalStrings.properties LocalStrings_fr.properties
remm2003/07/19 03:14:18
Modified:catalina/src/share/org/apache/catalina/valves
ErrorReportValve.java LocalStrings.properties
LocalStrings_fr.properties
Log:
- Add a note about the full trace being available in the logs, when one or more
exceptions are displayed.
Revision ChangesPath
1.6 +14 -6
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java
Index: ErrorReportValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ErrorReportValve.java 18 Jul 2003 22:25:52 - 1.5
+++ ErrorReportValve.java 19 Jul 2003 10:14:17 - 1.6
@@ -322,6 +322,7 @@
sb.append(/u/p);
if (throwable != null) {
+
String stackTrace = JdkCompat.getJdkCompat()
.getPartialServletStackTrace(throwable);
sb.append(pb);
@@ -329,6 +330,7 @@
sb.append(/b pre);
sb.append(stackTrace);
sb.append(/pre/p);
+
while (rootCause != null) {
stackTrace = JdkCompat.getJdkCompat()
.getPartialServletStackTrace(rootCause);
@@ -337,13 +339,19 @@
sb.append(/b pre);
sb.append(stackTrace);
sb.append(/pre/p);
-
-/* In case root cause is somehow heavily nested */
+// In case root cause is somehow heavily nested
if (rootCause instanceof ServletException)
rootCause = ((ServletException) rootCause).getRootCause();
else
rootCause = null;
}
+
+sb.append(pb);
+sb.append(sm.getString(errorReportValve.note));
+sb.append(/b u);
+sb.append(sm.getString(errorReportValve.rootCauseInLogs));
+sb.append(/u/p);
+
}
sb.append(HR size=\1\ noshade);
1.4 +2 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties
Index: LocalStrings.properties
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/LocalStrings.properties,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- LocalStrings.properties 22 Feb 2003 14:56:35 - 1.3
+++ LocalStrings.properties 19 Jul 2003 10:14:17 - 1.4
@@ -22,6 +22,8 @@
errorReportValve.description=description
errorReportValve.exception=exception
errorReportValve.rootCause=root cause
+errorReportValve.note=note
+errorReportValve.rootCauseInLogs=The full stack trace of the root cause is
available in the Tomcat logs.
# HTTP status reports
http.100=The client may continue ({0}).
1.3 +2 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/LocalStrings_fr.properties
Index: LocalStrings_fr.properties
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/LocalStrings_fr.properties,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- LocalStrings_fr.properties18 Jul 2003 22:31:55 - 1.2
+++ LocalStrings_fr.properties19 Jul 2003 10:14:17 - 1.3
@@ -19,6 +19,8 @@
errorReportValve.description=description
errorReportValve.exception=exception
errorReportValve.rootCause=cause mère
+errorReportValve.note=note
+errorReportValve.rootCauseInLogs=La trace complète de la cause mère de cette erreur
est disponible dans les fichiers journaux de Tomcat.
# HTTP status reports
http.100=Le client peut continuer ({0}).
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves AccessLogValve.java
funkman 2003/07/19 06:16:25
Modified:catalina/src/share/org/apache/catalina/valves
AccessLogValve.java
Log:
per http://marc.theaimsgroup.com/?l=tomcat-devm=105853698814388w=2
Add leading + to timezone offset.
This also makes = + which I think is OK.
Revision ChangesPath
1.5 +3 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
Index: AccessLogValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- AccessLogValve.java 4 Jun 2003 16:58:21 - 1.4
+++ AccessLogValve.java 19 Jul 2003 13:16:25 - 1.5
@@ -1049,6 +1049,8 @@
if ((offset0)) {
tz.append(-);
offset = -offset;
+} else {
+tz.append(+);
}
long hourOffset = offset/(1000*60*60);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves AccessLogValve.java
funkman 2003/07/19 06:17:47
Modified:catalina/src/share/org/apache/catalina/valves
AccessLogValve.java
Log:
(backport from 5)
per http://marc.theaimsgroup.com/?l=tomcat-devm=105853698814388w=2
Add leading + to timezone offset.
This also makes = + which I think is OK.
Revision ChangesPath
1.17 +3 -1
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java
Index: AccessLogValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/AccessLogValve.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- AccessLogValve.java 8 Jul 2003 23:12:51 - 1.16
+++ AccessLogValve.java 19 Jul 2003 13:17:46 - 1.17
@@ -1049,6 +1049,8 @@
if ((offset0)) {
tz.append(-);
offset = -offset;
+} else {
+tz.append(+);
}
long hourOffset = offset/(1000*60*60);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves LocalStrings.properties mbeans-descriptors.xml ErrorDispatcherValve.java
remm2003/07/19 07:30:07
Modified:catalina/src/share/org/apache/catalina/core
LocalStrings.properties StandardHost.java
StandardHostValve.java StandardServer.java
catalina/src/share/org/apache/catalina/valves
LocalStrings.properties mbeans-descriptors.xml
Removed: catalina/src/share/org/apache/catalina/valves
ErrorDispatcherValve.java
Log:
- Merge ErrorDispacherValve functionality back into StadardHostValve, and
remove associated hacks from StandardServer and StandardHost.
Revision ChangesPath
1.8 +1 -0
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/LocalStrings.properties
Index: LocalStrings.properties
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/LocalStrings.properties,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- LocalStrings.properties 24 Jun 2003 22:37:33 - 1.7
+++ LocalStrings.properties 19 Jul 2003 14:30:07 - 1.8
@@ -93,6 +93,7 @@
standardHost.accessBase=Cannot access document base directory {0}
standardHost.alreadyStarted=Host has already been started
standardHost.appBase=Application base directory {0} does not exist
+standardHost.clientAbort=Remote Client Aborted Request, IOException: {0}
standardHost.configRequired=URL to configuration file is required
standardHost.configNotAllowed=Use of configuration file is not allowed
standardHost.installBase=Only web applications in the Host web application
directory can be installed
1.19 +1 -5
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHost.java
Index: StandardHost.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHost.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- StandardHost.java 21 Jun 2003 20:00:22 - 1.18
+++ StandardHost.java 19 Jul 2003 14:30:07 - 1.19
@@ -75,7 +75,6 @@
import org.apache.catalina.LifecycleException;
import org.apache.catalina.Valve;
import org.apache.catalina.Realm;
-import org.apache.catalina.valves.ErrorDispatcherValve;
import org.apache.catalina.valves.ValveBase;
import org.apache.commons.modeler.Registry;
@@ -788,9 +787,6 @@
errorReportValveClass));
}
}
-
-// Set dispatcher valve
-addValve(new ErrorDispatcherValve());
super.start();
1.7 +317 -4
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
Index: StandardHostValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- StandardHostValve.java18 Jul 2003 18:49:28 - 1.6
+++ StandardHostValve.java19 Jul 2003 14:30:07 - 1.7
@@ -66,16 +66,28 @@
import java.io.IOException;
+import javax.servlet.RequestDispatcher;
+import javax.servlet.ServletContext;
import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.catalina.Container;
import org.apache.catalina.Context;
+import org.apache.catalina.Globals;
+import org.apache.catalina.HttpRequest;
+import org.apache.catalina.HttpResponse;
+import org.apache.catalina.Logger;
import org.apache.catalina.Manager;
import org.apache.catalina.Request;
import org.apache.catalina.Response;
import org.apache.catalina.Session;
import org.apache.catalina.ValveContext;
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.connector.ClientAbortException;
+import org.apache.catalina.deploy.ErrorPage;
+import org.apache.catalina.util.RequestUtil;
import org.apache.catalina.util.StringManager;
import org.apache.catalina.valves.ValveBase;
@@ -176,6 +188,307 @@
// Ask this Context to process this request
context.getPipeline().invoke(request, response);
+// Error page processing
+response.setSuspended(false);
+
+Throwable t = (Throwable) hreq.getAttribute(Globals.EXCEPTION_ATTR);
+
+if (t != null) {
+throwable(request, response, t);
+} else {
+status(request, response);
+}
+
+}
+
+
+//
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardHostValve.java
remm2003/07/19 07:33:29
Modified:catalina/src/share/org/apache/catalina/core
StandardHostValve.java
Log:
- Forgot one small patch.
- Add my name to the author list, from the ErrorDispatcherValve.
Revision ChangesPath
1.8 +2 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java
Index: StandardHostValve.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardHostValve.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- StandardHostValve.java19 Jul 2003 14:30:07 - 1.7
+++ StandardHostValve.java19 Jul 2003 14:33:29 - 1.8
@@ -100,6 +100,7 @@
* when processing HTTP requests.
*
* @author Craig R. McClanahan
+ * @author Remy Maucherat
* @version $Revision$ $Date$
*/
@@ -234,7 +235,7 @@
// If this is an aborted request from a client just log it and return
if (realError instanceof ClientAbortException ) {
log(sm.getString(
-errorDispatcherValve.clientAbort,
+standardHost.clientAbort,
((ClientAbortException)realError).getThrowable().getMessage()));
return;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java
remm2003/07/19 09:13:36
Modified:catalina/src/share/org/apache/catalina/startup
ContextConfig.java
Log:
- Like some of the other resources, application parameters must not be reset
on a context stop, as they come from a Context element. Regular parameters
read from web.xml should be fine.
Revision ChangesPath
1.28 +3 -1
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
Index: ContextConfig.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- ContextConfig.java15 Jun 2003 07:41:12 - 1.27
+++ ContextConfig.java19 Jul 2003 16:13:36 - 1.28
@@ -775,12 +775,14 @@
}
// Removing application parameters
+/*
ApplicationParameter[] applicationParameters =
context.findApplicationParameters();
for (i = 0; i applicationParameters.length; i++) {
context.removeApplicationParameter
(applicationParameters[i].getName());
}
+*/
// Removing security constraints
SecurityConstraint[] securityConstraints = context.findConstraints();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21600] - Parameter's lost after manager stop/start or reload
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600 Parameter's lost after manager stop/start or reload [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:17 --- No, you shouldn't assume anything, the JNDI resource are handled fine. The ContextConfig was resetting the application parameters, which was wrong. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20086] - Broken link for JK Documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20086. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20086 Broken link for JK Documentation [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Component|Connector:Coyote JK 2 |Webapps:Documentation Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:26 --- This now links to the online docs. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] New: - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) Summary: Found some bugs at tester (FIX with patch) Product: Tomcat 5 Version: Nightly Build Platform: PC OS/Version: Windows XP Status: NEW Severity: Normal Priority: Other Component: Tester AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I found some bugs at tester modul at current tomcat 5 cvs 19.07.2003 state. Two are not found: Include Bug with RequestDesipatcher TesterClient based on HttpUrlConnection can't read input with Status 500 Response. Check with HttpClient 2.0.0 and it works in a simple env. S. Dteail Patch and Report (attached) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:29 --- Created an attachment (id=7391) Patch to fix some Bugs at tester - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:29 --- Created an attachment (id=7392) BugReport - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:31 --- Created an attachment (id=7393) Simple Example with HttpClient to access and simulate HttpUrlConnection failure - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:31 --- Created an attachment (id=7394) tester build.properties for tomcat5 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:32 --- Created an attachment (id=7395) tester/bin/build.properties (example) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 16:41 --- Ok, thanks, that's useful. There are mistakes in the patch: the failures in the lifecycle test are real (but very minor) failures. I believe the JMX registration doesn't happen if the init of a servlet fails, and so the new mapper (which uses JMX to update itself) doesn't map the request to the servlet, which gives the 404. About the include failure: it fails because of the invoker servlet. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21600] - Parameter's lost after manager stop/start or reload
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600 Parameter's lost after manager stop/start or reload --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 18:22 --- Hi Remy, Was the fix done for just Tomcat-5 or was it also applied to the Tomcat-4.1.xx codebase? Just wondering if I can expect future versions of Tomcat-4.1.xx to work properly. thanks, Jake - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21600] - Parameter's lost after manager stop/start or reload
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21600 Parameter's lost after manager stop/start or reload --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 18:30 --- The fix is currently only in Tomcat 5. Note: I didn't actually test the fix (but the flaw in the code was evident, and similar to previous flaws in JNDI resources handling). If you'd like to experiment with Tomcat development, now would be the right time to get the sources and test the fix :) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 21731] - Found some bugs at tester (FIX with patch)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21731 Found some bugs at tester (FIX with patch) --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 20:02 --- I'm in the process of applying your patches. Feel free to contribute more to the tester: switch to HttpClient, new tests, etc. Note: There's a socket mode in the current tester to fix the failures with 500 and error pages (use the protocol attribute of the tester task). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/tester/web/WEB-INF web.xml
remm2003/07/19 13:21:12
Modified:tester build.xml
tester/src/bin tester.xml
tester/src/tester/org/apache/tester ErrorPage04.java
tester/web/WEB-INF web.xml
Log:
- Fix some tests (bug 21731).
- Partially submitted by Peter Rossbach.
Revision ChangesPath
1.3 +1 -0 jakarta-tomcat-catalina/tester/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/tester/build.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- build.xml 11 Sep 2002 03:33:58 - 1.2
+++ build.xml 19 Jul 2003 20:21:12 - 1.3
@@ -88,6 +88,7 @@
!-- Install Xerces --
copy todir=${tester.build}/web/WEB-INF/lib file=${xercesImpl.jar}/
+copy todir=${tester.build}/web/WEB-INF/lib file=${xmlParserAPIs.jar}/
!-- Create and install tester library --
mkdir dir=${tester.build}/web/WEB-INF/lib/
1.5 +1 -1 jakarta-tomcat-catalina/tester/src/bin/tester.xml
Index: tester.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/tester/src/bin/tester.xml,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- tester.xml18 Jul 2003 09:47:23 - 1.4
+++ tester.xml19 Jul 2003 20:21:12 - 1.5
@@ -6,7 +6,7 @@
property name=host value=localhost/
property name=port value=8080/
!-- property name=protocol value=HTTP/1.0/ --
- property name=protocol value=/ !-- Use HttpURLConnection --
+ property name=protocol value=HTTP/1.0/ !-- Use HttpURLConnection --
property name=context.path value=/tester/
property name=jsp-examples.path value=/jsp-examples/
property name=servlets-examples.path value=/servlets-examples/
1.2 +7 -17
jakarta-tomcat-catalina/tester/src/tester/org/apache/tester/ErrorPage04.java
Index: ErrorPage04.java
===
RCS file:
/home/cvs/jakarta-tomcat-catalina/tester/src/tester/org/apache/tester/ErrorPage04.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ErrorPage04.java 18 Jul 2002 16:47:26 - 1.1
+++ ErrorPage04.java 19 Jul 2003 20:21:12 - 1.2
@@ -89,26 +89,16 @@
value = request.getAttribute(javax.servlet.error.exception);
if (value == null)
sb.append( exception is missing/);
-else if (!(value instanceof javax.servlet.ServletException)) {
+else if (!(value instanceof org.apache.tester.TesterException)) {
sb.append( exception class is );
sb.append(value.getClass().getName());
sb.append(/);
} else {
-exception = (ServletException) value;
-rootCause = exception.getRootCause();
-if (rootCause == null) {
-sb.append( rootCause is missing/);
-} else if (!(rootCause instanceof TesterException)) {
-sb.append( rootCause is );
-sb.append(rootCause.getClass().getName());
+TesterException te = (TesterException) rootCause;
+if (!ErrorPage03 Threw Exception.equals(te.getMessage())) {
+sb.append( exception message is );
+sb.append(te.getMessage());
sb.append(/);
-} else {
-TesterException te = (TesterException) rootCause;
-if (!ErrorPage03 Threw Exception.equals(te.getMessage())) {
-sb.append( exception message is );
-sb.append(te.getMessage());
-sb.append(/);
-}
}
}
@@ -121,7 +111,7 @@
sb.append(/);
} else {
Class clazz = (Class) value;
-if (!javax.servlet.ServletException.equals(clazz.getName())) {
+if (!org.apache.tester.TesterException.equals(clazz.getName())) {
sb.append( exception_type class is );
sb.append(clazz.getName());
sb.append(/);
1.4 +18 -0 jakarta-tomcat-catalina/tester/web/WEB-INF/web.xml
Index: web.xml
===
RCS file: /home/cvs/jakarta-tomcat-catalina/tester/web/WEB-INF/web.xml,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- web.xml 28 Dec 2002 04:23:54 - 1.3
+++ web.xml 19 Jul 2003 20:21:12 - 1.4
@@ -1025,8 +1025,26 @@
/servlet
+servlet
+servlet-nameinvoker/servlet-name
+servlet-class
+
DO NOT REPLY [Bug 21711] - Error when compiling a JSP that uses a TLD 1.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21711. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21711 Error when compiling a JSP that uses a TLD 1.1 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-07-19 20:54 --- I believe Tomcat's behavior here is consistent with the JSP 1.1 specification. Your example works if the attribute is renamed to something other than id, or if the attribute value is not specified as a request-time attribute value. The error only occurs when specifying a request-time attribute value for a parameter named id. The spec mandates special treatment of attributes named id, as detailed in section 2.12.2: 'The id=name attribute/value tuple in an element has special meaning to a JSP container, both at page translation time, and at client request processing time; in particular: · the name must be unique within the translation unit, and identifies the particular element in which it appears to the JSP container and page.' name must be unique within the translation unit to me implies name cannot be a request-time attribute value, as if it were, there would be no way to verify uniqueness at translation time. The spec seems to make this explicit in a parenthetical in section 5.1.3.2: note that id must be a translation- time attribute. The code seems to be consistent with this interpretation. The actual exception is thrown by code that I don't have access to, but it's clear from the Javadocs that the problem is that TagData.getID expects the value of the id attribute to be a String (as it would be if it were a translation- time attribute), whereas Tomcat has set it to TagData.REQUEST_TIME_VALUE, as is proper for a request-time attribute value. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
