Re: [PATCH] Bug 22666

2003-09-07 Thread Remy Maucherat
Mark Thomas wrote: This is obviously a bigger mess than I first thought. As I see it, the following options exist for resolving bug 22666. 1. WONTFIX - On the basis that there is too much uncertainty to do anything sensible and that any changes made might break interoperability as per Remy's

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java

2003-09-07 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: remm2003/09/06 10:49:31 Modified:catalina/src/share/org/apache/catalina/loader WebappClassLoader.java Log: - Modify the bundling of commons-logging to fix (hopefully) the nagging CL issues. - The commons-logging-api JAR will

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http Parameters.java

2003-09-07 Thread remm
remm2003/09/07 00:37:12 Modified:util/java/org/apache/tomcat/util/http Parameters.java Log: - Handle query string decoding as a special case. - Char decoding is not lazy anymore (if parameter parsing is requested), but the difference was mostly rhetorical. - This will

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java

2003-09-07 Thread remm
remm2003/09/07 00:38:42 Modified:catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java Log: - Handle query string decoding as a special case. - The URI encoding is used for now. Add a new field for more flexibility. - The encoding needs to

Re: [PATCH] Bug 22666

2003-09-07 Thread Remy Maucherat
Remy Maucherat wrote: I'll vote almost 2 ;-) No client I know of is always cosistently using UTF8 to encode the URL, but however, I'm not sure clients are using the encoding of the entity body to encode the URL. Proper character decoding of the decoded (it means %xx decoded here) URL is

DO NOT REPLY [Bug 22848] - [PATCH] Fix typos/grammar in changelog.html

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22848] - [PATCH] Fix typos/grammar in changelog.html

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22965] - [PATCH] Tidy up conf/web.xml

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22965. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22965] New: - [PATCH] Tidy up conf/web.xml

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22965. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

2003-09-07 Thread remm
remm2003/09/07 06:25:26 Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java Log: - Null a busy processor in the pool array. This isn't particularly useful, but is more consistent with the rest of the algorithm, and helps get a clearer picture when

[5.0] JSP performance ...

2003-09-07 Thread Remy Maucherat
... is not as good as it should be. I found a benchmark where TC is currently not too good. The problem occurs when dealing with lots of strings. I'm attaching the benchmark, the code generated by TC, and the code generated by Resin. Resin String handling tricks ends with it making about half

[5.0] Planning

2003-09-07 Thread Remy Maucherat
Rather than having a vote for 5.0.10, I'd like to release a new 5.0.11 build with the fix for the (nasty) commons-logging classloading issues. The idea is that using Struts 1.1 with log4j is quite common, and using that in conjunction with a context config file cut pasted from the manager or

RE: [PATCH] Bug 22666

2003-09-07 Thread Mark Thomas
On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Remy Maucherat wrote: I've just committed a very simple implementation of this (without the extra queryStringEncoding field, although this is not hard to add). Comments ? Remy Thanks for your help with

Bug report for Tomcat 3 [2003/09/07]

2003-09-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 4 [2003/09/07]

2003-09-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Watchdog [2003/09/07]

2003-09-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf MessageBytes.java

2003-09-07 Thread remm
remm2003/09/07 07:36:59 Modified:util/java/org/apache/tomcat/util/buf MessageBytes.java Log: - toChars should set the type to chars. Revision ChangesPath 1.9 +1 -0 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/buf/MessageBytes.java

Re: [PATCH] Bug 22666

2003-09-07 Thread Remy Maucherat
Mark Thomas wrote: On Sunday, September 07, 2003 8:47 AM, Remy Maucherat [SMTP:[EMAIL PROTECTED] wrote: Remy Maucherat wrote: I've just committed a very simple implementation of this (without the extra queryStringEncoding field, although this is not hard to add). Comments ? Remy Thanks for your

cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Request.java

2003-09-07 Thread remm
remm2003/09/07 11:03:21 Modified:coyote/src/java/org/apache/coyote Request.java Log: - Make the update of the stats an explicit call (I believe it is valid to call recycle multiple times, and it is hard to avoid with HTTP keepalive). Revision ChangesPath 1.23

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

2003-09-07 Thread remm
remm2003/09/07 11:04:58 Modified:http11/src/java/org/apache/coyote/http11 Http11Processor.java Log: - Make the update of the stats an explicit call (I believe it is valid to call recycle multiple times, and it is hard to avoid with HTTP keepalive).

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/jk/server JkCoyoteHandler.java

2003-09-07 Thread remm
remm2003/09/07 11:05:15 Modified:jk/java/org/apache/jk/server JkCoyoteHandler.java Log: - Make the update of the stats an explicit call (I believe it is valid to call recycle multiple times, and it is hard to avoid with HTTP keepalive). Revision ChangesPath 1.44

cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager Constants.java HTMLManagerServlet.java ManagerServlet.java StatusTransformer.java

2003-09-07 Thread remm
remm2003/09/07 11:47:14 Modified:webapps/manager/WEB-INF/classes/org/apache/catalina/manager Constants.java HTMLManagerServlet.java ManagerServlet.java StatusTransformer.java Log: - Bug 22956: Use UTF8 encoding. - Submitted by

DO NOT REPLY [Bug 22956] - Manager webapp can't treat encvoding correctly

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22956. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22961] - WebAppClassLoader tries to load class from system classloader twice

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22961. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 22848] - [PATCH] Fix typos/grammar in changelog.html

2003-09-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22848. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2003-09-07 Thread remm
remm2003/09/07 12:05:46 Modified:webapps/docs changelog.xml Log: - Fix typos, submitted by Yann C├ębron. Revision ChangesPath 1.19 +4 -4 jakarta-tomcat-catalina/webapps/docs/changelog.xml Index: changelog.xml

jakarta-tomcat-connectors/util build broke for j2sdk 1.3

2003-09-07 Thread Glenn Nielsen
I can no longer build jakarta-tomcat-connectors/util. It looks like a dependency for java 1.4 has crept in with how jsse is being used. Glenn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: jakarta-tomcat-connectors/util build broke for j2sdk 1.3

2003-09-07 Thread Bill Barker
It works fine for me. I just did an update on j-t-c, and a clean build of Tomcat 5, and it worked fine (well, up until it got to the docs, but I've still got an old version of xalan in ant :). - Original Message - From: Glenn Nielsen [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Sunday,

cvs commit: jakarta-tomcat-connectors/util build.xml

2003-09-07 Thread glenn
glenn 2003/09/07 20:29:18 Modified:util build.xml Log: Fix the build for jdk 1.3 Revision ChangesPath 1.26 +1 -0 jakarta-tomcat-connectors/util/build.xml Index: build.xml === RCS

Re: jakarta-tomcat-connectors/util build broke for j2sdk 1.3

2003-09-07 Thread Glenn Nielsen
You had to be using jsse rather than PureTLS and building with jdk 1.4. It is fixed now. A new JSSE class was added for JDK1.4 support but it wasn't excluded from the build if jdk1.4 wasn't present. Glenn Bill Barker wrote: It works fine for me. I just did an update on j-t-c, and a clean