Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

[Bill Barker]

- Original Message - 
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Thursday, December 25, 2003 1:15 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads
ThreadPool.java


> [EMAIL PROTECTED] wrote:
> > billbarker2003/12/24 19:08:31
> >
> >   Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java
> >   Log:
> >   Fix potential race condition.
> >
> >   You'll need some pretty high-end hardware to see this in the real
world, but it's still technically a bug.
>
> When can it occur, and what does the problem do ? All calls to
> openThreads are synced on the pool, so new threads should be created
> sequentially.
>

I was thinking that on a big enough SMP machine it would be possible to
check noThreadData before the constructor exists.  Of course, it's not since
the check is after the wait(), and notify() can't be called until the
constructor exits.  I realized this about half an hour after the commit, but
it didn't seem worth reverting.  I can revert it if people want.

> >   Revision  ChangesPath
> >   1.19  +1 -1
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPoo
l.java
> >
> >   Index: ThreadPool.java
> >   ===
> >   RCS file:
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads
/ThreadPool.java,v
> >   retrieving revision 1.18
> >   retrieving revision 1.19
> >   diff -u -r1.18 -r1.19
> >   --- ThreadPool.java 6 Nov 2003 19:05:23 - 1.18
> >   +++ ThreadPool.java 25 Dec 2003 03:08:31 - 1.19
> >   @@ -638,9 +638,9 @@
> >t = new ThreadWithAttributes(p, this);
> >t.setDaemon(true);
> >t.setName(p.getName() + "-Processor" + p.getSequence());
> >   -t.start();
> >p.addThread( t, this );
> >noThData=true;
> >   +t.start();
> >}
> >
> >public void run() {
>
> Rémy
>
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>


This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25680] - Exception thrown when including a jsp mapped to a custom servlet name

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25680

Exception thrown when including a jsp mapped to a custom servlet name

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 20:23 ---
Reopening: the code in the trimmed-down attached app was causing exception 
before the patch.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25680] - Exception thrown when including a jsp mapped to a custom servlet name

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25680

Exception thrown when including a jsp mapped to a custom servlet name





--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 20:21 ---
Created an attachment (id=9703)
Trimmed down testcase: this caused out of bounds exception before the patch

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25680] - Exception thrown when including a jsp mapped to a custom servlet name

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25680

Exception thrown when including a jsp mapped to a custom servlet name

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 19:47 ---
My last comment basically meant: if you can't explain how to encounter the
issue, then your patch will not be committed.
I stated the same when you posted on tomcat-dev mentioning this problem in a
similar vague fashion.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25748] - Synchronization issues in ThreadPool.java

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25748

Synchronization issues in ThreadPool.java





--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 19:42 ---
Quite frankly you need to improve how you interact with this community. I think
the "problems" you attempted to point out are hypothetical at best, and the
changes you did suggest would not fix anything.
If you want to make yourself understood, you need to post detailed, argumented
information.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25748] - Synchronization issues in ThreadPool.java

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25748

Synchronization issues in ThreadPool.java





--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 18:58 ---
The bug has been closed as dup, but the problematic code appears in 4.1.24-.28
and very recent 5.x betas (as of 3 weeks ago).  Perhaps the problematic code has
been fixed in the interim? 

We can mention the issue in the 1.5.0 release notes to warn users that 4.1.2X
and some 5.x versions are unstable.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25748] - Synchronization issues in ThreadPool.java

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25748

Synchronization issues in ThreadPool.java





--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 18:57 ---
The bug has been closed as dup, but the problematic code appears in 4.1.24-.28
and very recent 5.x betas (as of 3 weeks ago).  Perhaps the problematic code has
been fixed in the interim?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: NIO and JDK link

[Tim Funk]

It is built using 1.4 - but does not *require* 1.4. IIRC, your thread was 
requesting making 1.4 required.

-Tim

Vic Cekvenich wrote:


Shapira, Yoav wrote:



Is there a plan sometime to consider moving TC 5 to 1.4 JRE?


It's already compiled and built on JDK 1.4.  


Wait... there was a whole tread while back saying that Tomcat 5 will not 
be on 1.4.  Yup, even the TC5 pages say it's 1.4.

A few months ago I got a whole buch of arrows for asking for 1.4 on this 
list.

.V



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: NIO and JDK link

[Vic Cekvenich]

Shapira, Yoav wrote:



Is there a plan sometime to consider moving TC 5 to 1.4 JRE?


It's already compiled and built on JDK 1.4.  
Wait... there was a whole tread while back saying that Tomcat 5 will not 
be on 1.4.  Yup, even the TC5 pages say it's 1.4.

A few months ago I got a whole buch of arrows for asking for 1.4 on this 
list.

.V



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads ThreadPool.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
billbarker2003/12/24 19:08:31

  Modified:util/java/org/apache/tomcat/util/threads ThreadPool.java
  Log:
  Fix potential race condition.
  
  You'll need some pretty high-end hardware to see this in the real world, but it's still technically a bug.
When can it occur, and what does the problem do ? All calls to 
openThreads are synced on the pool, so new threads should be created 
sequentially.

  Revision  ChangesPath
  1.19  +1 -1  jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java
  
  Index: ThreadPool.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/threads/ThreadPool.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- ThreadPool.java	6 Nov 2003 19:05:23 -	1.18
  +++ ThreadPool.java	25 Dec 2003 03:08:31 -	1.19
  @@ -638,9 +638,9 @@
   t = new ThreadWithAttributes(p, this);
   t.setDaemon(true);
   t.setName(p.getName() + "-Processor" + p.getSequence());
  -t.start();
   p.addThread( t, this );
   	noThData=true;
  +t.start();
   }
   
   public void run() {
Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25737] - Realm based authentication fails in cluster

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25737

Realm based authentication fails in cluster

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 09:03 ---
Please, please post on tomcat-user. BZ is not a support forum. Likely, sticky
sessions don't work in your setup (likely no matching jvmRoute attributes on the
Engines).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 25744] - Silent Installation Errors Out in 5.0.16

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25744

Silent Installation Errors Out in 5.0.16

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-12-25 08:58 ---
I wasn't aware of a silent installation feature. So if this worked, it is only
by accident.
For installing silently, I think .zip files are better overall ...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]