Simple But Irritating problem accesing beans from jsp

2004-09-24 Thread Dinesh Keesara
the following code is working perfectly:

[EMAIL PROTECTED] import=com.dinesh.* %
% IdCard myidcard=new IdCard();%
%
myidcard.setName(HariKiran);
myidcard.setRollNo(123);
%
%=myidcard.getName()%
br
%=myidcard.getRollNo()%

but if i replace it with jsp:usebean tag  like this :

[EMAIL PROTECTED] import=com.dinesh.* %
jsp:usebean id=myidcard  class=com.dinesh.IdCard scope=page
jsp:setProperty name=myidcard property=rollNo value=123 
jsp:setProperty name=myidcard property=name value=Harikiran 
%=myidcard.getName()%
br
%=myidcard.getRollNo()%
/jsp:usebean

i am getting a jsp.error.badaction messsage here is complete stack trace :

HTTP Status 500 -



type Exception report

message

description The server encountered an internal error () that prevented
it from fulfilling this request.

exception

org.apache.jasper.JasperException: /idcard1.jsp(5,5) jsp.error.badaction
   at 
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:94)
   at org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:428)
   at org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:126)
   at org.apache.jasper.compiler.Parser.parseAction(Parser.java:671)
   at org.apache.jasper.compiler.Parser.parseElements(Parser.java:803)
   at org.apache.jasper.compiler.Parser.parse(Parser.java:122)
   at org.apache.jasper.compiler.ParserController.parse(ParserController.java:199)
   at org.apache.jasper.compiler.ParserController.parse(ParserController.java:153)
   at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:227)
   at org.apache.jasper.compiler.Compiler.compile(Compiler.java:369)
   at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:473)
   at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:190)
   at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
   at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
   at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
   at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
   at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
   at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
   at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
   at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
   at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
   at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
   at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2422)
   at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
   at 
org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:171)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
   at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:163)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
   at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
   at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
   at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
   at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
   at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
   at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
   at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:199)
   at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:833)
   at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:711)
   at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:584)
   at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:687)
   at java.lang.Thread.run(Thread.java:536)


--
Dinesh Keesara
M.Tech(Software Engg.)
School of IT, JNTU,

Re: Simple But Irritating problem accesing beans from jsp

2004-09-24 Thread Michael McGrady
useBean instead of userbean?
Michael McGrady
Dinesh Keesara wrote:
the following code is working perfectly:
[EMAIL PROTECTED] import=com.dinesh.* %
% IdCard myidcard=new IdCard();%
%
myidcard.setName(HariKiran);
myidcard.setRollNo(123);
%
%=myidcard.getName()%
br
%=myidcard.getRollNo()%
but if i replace it with jsp:usebean tag  like this :
[EMAIL PROTECTED] import=com.dinesh.* %
jsp:usebean id=myidcard  class=com.dinesh.IdCard scope=page
jsp:setProperty name=myidcard property=rollNo value=123 
jsp:setProperty name=myidcard property=name value=Harikiran 
%=myidcard.getName()%
br
%=myidcard.getRollNo()%
/jsp:usebean
i am getting a jsp.error.badaction messsage here is complete stack trace :
HTTP Status 500 -

type Exception report
message
description The server encountered an internal error () that prevented
it from fulfilling this request.
exception
org.apache.jasper.JasperException: /idcard1.jsp(5,5) jsp.error.badaction
  at 
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:94)
  at org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:428)
  at org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:126)
  at org.apache.jasper.compiler.Parser.parseAction(Parser.java:671)
  at org.apache.jasper.compiler.Parser.parseElements(Parser.java:803)
  at org.apache.jasper.compiler.Parser.parse(Parser.java:122)
  at org.apache.jasper.compiler.ParserController.parse(ParserController.java:199)
  at org.apache.jasper.compiler.ParserController.parse(ParserController.java:153)
  at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:227)
  at org.apache.jasper.compiler.Compiler.compile(Compiler.java:369)
  at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:473)
  at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:190)
  at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
  at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
  at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
  at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
  at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2422)
  at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at 
org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:171)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
  at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:163)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:199)
  at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:833)
  at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:711)
  at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:584)
  at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:687)
  at java.lang.Thread.run(Thread.java:536)
--
Dinesh Keesara
M.Tech(Software Engg.)
School of IT, 

Re: Simple But Irritating problem accesing beans from jsp

2004-09-24 Thread Michael McGrady
Sorry, I mean: useBean instead of usebean?  (My eyesight is not great.  
Nerd, you know!)

Michael McGrady
Dinesh Keesara wrote:
the following code is working perfectly:
[EMAIL PROTECTED] import=com.dinesh.* %
% IdCard myidcard=new IdCard();%
%
myidcard.setName(HariKiran);
myidcard.setRollNo(123);
%
%=myidcard.getName()%
br
%=myidcard.getRollNo()%
but if i replace it with jsp:usebean tag  like this :
[EMAIL PROTECTED] import=com.dinesh.* %
jsp:usebean id=myidcard  class=com.dinesh.IdCard scope=page
jsp:setProperty name=myidcard property=rollNo value=123 
jsp:setProperty name=myidcard property=name value=Harikiran 
%=myidcard.getName()%
br
%=myidcard.getRollNo()%
/jsp:usebean
i am getting a jsp.error.badaction messsage here is complete stack trace :
HTTP Status 500 -

type Exception report
message
description The server encountered an internal error () that prevented
it from fulfilling this request.
exception
org.apache.jasper.JasperException: /idcard1.jsp(5,5) jsp.error.badaction
  at 
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:94)
  at org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:428)
  at org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:126)
  at org.apache.jasper.compiler.Parser.parseAction(Parser.java:671)
  at org.apache.jasper.compiler.Parser.parseElements(Parser.java:803)
  at org.apache.jasper.compiler.Parser.parse(Parser.java:122)
  at org.apache.jasper.compiler.ParserController.parse(ParserController.java:199)
  at org.apache.jasper.compiler.ParserController.parse(ParserController.java:153)
  at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:227)
  at org.apache.jasper.compiler.Compiler.compile(Compiler.java:369)
  at 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:473)
  at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:190)
  at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
  at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
  at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
  at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
  at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2422)
  at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at 
org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:171)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
  at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:163)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
  at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
  at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
  at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
  at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:199)
  at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:833)
  at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:711)
  at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:584)
  at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:687)
  at 

Re: Simple But Irritating problem accesing beans from jsp

2004-09-24 Thread Dinesh Keesara
Hey Grady ...

Really Thanks ... I am dying for this since 24 hours ...you proved ..
how stupid i am ..

anyway thanks 


On Thu, 23 Sep 2004 23:33:14 -0700, Michael McGrady
[EMAIL PROTECTED] wrote:
 Sorry, I mean: useBean instead of usebean?  (My eyesight is not great.
 Nerd, you know!)
 
 
 
 Michael McGrady
 
 Dinesh Keesara wrote:
 
 the following code is working perfectly:
 
 [EMAIL PROTECTED] import=com.dinesh.* %
 % IdCard myidcard=new IdCard();%
 %
 myidcard.setName(HariKiran);
 myidcard.setRollNo(123);
 %
 %=myidcard.getName()%
 br
 %=myidcard.getRollNo()%
 
 but if i replace it with jsp:usebean tag  like this :
 
 [EMAIL PROTECTED] import=com.dinesh.* %
 jsp:usebean id=myidcard  class=com.dinesh.IdCard scope=page
 jsp:setProperty name=myidcard property=rollNo value=123 
 jsp:setProperty name=myidcard property=name value=Harikiran 
 %=myidcard.getName()%
 br
 %=myidcard.getRollNo()%
 /jsp:usebean
 
 i am getting a jsp.error.badaction messsage here is complete stack trace :
 
 HTTP Status 500 -
 
 
 
 type Exception report
 
 message
 
 description The server encountered an internal error () that prevented
 it from fulfilling this request.
 
 exception
 
 org.apache.jasper.JasperException: /idcard1.jsp(5,5) jsp.error.badaction
at 
  org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:94)
at 
  org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:428)
at 
  org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:126)
at org.apache.jasper.compiler.Parser.parseAction(Parser.java:671)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:803)
at org.apache.jasper.compiler.Parser.parse(Parser.java:122)
at 
  org.apache.jasper.compiler.ParserController.parse(ParserController.java:199)
at 
  org.apache.jasper.compiler.ParserController.parse(ParserController.java:153)
at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:227)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:369)
at 
  org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:473)
at 
  org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:190)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at 
  org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
at 
  org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
at 
  org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at 
  org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at 
  org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at 
  org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2422)
at 
  org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at 
  org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:171)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at 
  org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:163)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
at 
  org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at 
  org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
at 
  org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
at 
  org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:199)
at 

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm MemoryRealm.java JAASMemoryLoginModule.java

2004-09-24 Thread remm
remm2004/09/24 00:25:07

  Modified:catalina/src/share/org/apache/catalina/startup
HostConfig.java ContextConfig.java
   catalina/src/share/org/apache/catalina/realm
MemoryRealm.java JAASMemoryLoginModule.java
  Log:
  - Digester handling fixes: always call reset in a finally block after using a 
digester.
  
  Revision  ChangesPath
  1.47  +6 -3  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java
  
  Index: HostConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v
  retrieving revision 1.46
  retrieving revision 1.47
  diff -u -r1.46 -r1.47
  --- HostConfig.java   6 Sep 2004 15:02:07 -   1.46
  +++ HostConfig.java   24 Sep 2004 07:25:06 -  1.47
  @@ -557,8 +557,11 @@
   try {
   Context context = null;
   synchronized (digester) {
  -context = (Context) digester.parse(contextXml);
  -digester.reset();
  +try {
  +context = (Context) digester.parse(contextXml);
  +} finally {
  +digester.reset();
  +}
   }
   if (context instanceof Lifecycle) {
   Class clazz = Class.forName(host.getConfigClass());
  
  
  
  1.58  +1 -7  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
  
  Index: ContextConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
  retrieving revision 1.57
  retrieving revision 1.58
  diff -u -r1.57 -r1.58
  --- ContextConfig.java23 Sep 2004 06:58:52 -  1.57
  +++ ContextConfig.java24 Sep 2004 07:25:07 -  1.58
  @@ -294,7 +294,6 @@
   if( url!=null ) {
   InputSource is = new InputSource(url.toExternalForm());
   is.setByteStream(stream);
  -webDigester.clear();
   if (context instanceof StandardContext) {
   ((StandardContext) context).setReplaceWelcomeFiles(true);
   }
  @@ -326,7 +325,6 @@
   } catch (IOException e) {
   log.error(sm.getString(contextConfig.applicationClose), e);
   }
  -webDigester.push(null);
   }
   }
   webRuleSet.recycle();
  @@ -616,9 +614,7 @@
   
   if (context instanceof StandardContext)
   ((StandardContext) context).setReplaceWelcomeFiles(true);
  -digester.clear();
   digester.setClassLoader(this.getClass().getClassLoader());
  -//log.info( Using cl:  + webDigester.getClassLoader());
   digester.setUseContextClassLoader(false);
   digester.push(context);
   digester.setErrorHandler(new ContextErrorHandler());
  @@ -705,9 +701,7 @@
   synchronized (contextDigester) {
   try {
   source.setByteStream(stream);
  -contextDigester.clear();
   contextDigester.setClassLoader(this.getClass().getClassLoader());
  -//log.info( Using cl:  + webDigester.getClassLoader());
   contextDigester.setUseContextClassLoader(false);
   contextDigester.push(context.getParent());
   contextDigester.push(context);
  
  
  
  1.7   +3 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java
  
  Index: MemoryRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/MemoryRealm.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- MemoryRealm.java  6 Sep 2004 15:02:07 -   1.6
  +++ MemoryRealm.java  24 Sep 2004 07:25:07 -  1.7
  @@ -298,10 +298,11 @@
   synchronized (digester) {
   digester.push(this);
   digester.parse(file);
  -digester.reset();
   }
   } catch (Exception e) {
   throw new LifecycleException(memoryRealm.readXml, e);
  +} finally {
  +digester.reset();
   }
   
   // Perform normal superclass initialization
  
  
  
  1.12  +3 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JAASMemoryLoginModule.java
  
  Index: JAASMemoryLoginModule.java
  ===
  RCS file: 

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester Digester.java

2004-09-24 Thread remm
remm2004/09/24 00:27:04

  Modified:util/java/org/apache/tomcat/util/digester Digester.java
  Log:
  - Reset now removes the error handler, the root and calls clear. Calling it should 
be enough to prevent any leaks (of course,
the leaking would only last until the next use of the digester instance, which 
isn't too bad overall).
  
  Revision  ChangesPath
  1.5   +3 -1  
jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester/Digester.java
  
  Index: Digester.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/digester/Digester.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- Digester.java 6 Sep 2004 15:02:08 -   1.4
  +++ Digester.java 24 Sep 2004 07:27:04 -  1.5
  @@ -2373,6 +2373,8 @@
   
   public void reset() {
   root = null;
  +setErrorHandler(null);
  +clear();
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup ContextConfig.java

2004-09-24 Thread remm
remm2004/09/24 01:23:30

  Modified:catalina/src/share/org/apache/catalina/startup Tag:
TOMCAT_5_0 ContextConfig.java
  Log:
  - Reset digester state.
  - Patch submitted by Scott Stark.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.44.2.2  +3 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java
  
  Index: ContextConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/ContextConfig.java,v
  retrieving revision 1.44.2.1
  retrieving revision 1.44.2.2
  diff -u -r1.44.2.1 -r1.44.2.2
  --- ContextConfig.java6 Sep 2004 18:57:06 -   1.44.2.1
  +++ ContextConfig.java24 Sep 2004 08:23:30 -  1.44.2.2
  @@ -285,7 +285,9 @@
   } catch (IOException e) {
   log.error(sm.getString(contextConfig.applicationClose), e);
   }
  +webDigester.clear();
   webDigester.push(null);
  +webDigester.setErrorHandler(null);
   }
   }
   webRuleSet.recycle();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31398] New: - StandardWrapperValve logging

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31398.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31398

StandardWrapperValve logging

   Summary: StandardWrapperValve logging
   Product: Tomcat 4
   Version: 4.1.27
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I suppose there is a bug in the following method
org.apache.catalina.core.StandardWrapperValve#log(String message, Throwable 
throwable)

If no logger is specified and an exception has occured
the same method log(String message, Throwable throwable) is invoked
instead of invoking log(String message) as it should be in my opinion.

/**
 * Log a message on the Logger associated with our Container (if any)
 *
 * @param message Message to be logged
 * @param throwable Associated exception
 */
private void log(String message, Throwable throwable) {

Logger logger = null;
if (container != null)
logger = container.getLogger();
if (logger != null)
logger.log(StandardWrapperValve[ + container.getName() + ]: 
   + message, throwable);
else {
String containerName = null;
if (container != null)
containerName = container.getName();
log( StandardWrapperValve[ + containerName
   + ]:  + message,  throwable);  - here ist the bug
}

}


Regards
Karin

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31361] - Add OS/2 launchers to tomcat

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31361.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31361

Add OS/2 launchers to tomcat





--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 09:03 ---
Hello,

I created the OS/2 scripts some time ago too. They are available at
http://hobbes.nmsu.edu/pub/os2/apps/internet/www/server/tomcat_5-0-27_os2.zip

Another person also created non-Rexx scripts that should also work. Check the
OS/2 FAQ page for links.

I also asked officialy for adding my scripts to the distribution but it was
rejected because OS/2 is not officialy supported and there are too few users
running OS/2. You may ask Yoav Shapira (via Tomcat-dev list) to add a link to
your scripts too.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31361] - Add OS/2 launchers to tomcat

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31361.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31361

Add OS/2 launchers to tomcat





--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 09:57 ---
Actually I'm working on NetBeans OS/2 support. It is also non-official, but
they didn't argue about the small number of users.
I'm trying to solve http://www.netbeans.org/issues/show_bug.cgi?id=42678
and I'm close to it.
This Tomcat issue blocks that NetBeans issue.
I don't think they would agree to add these scripts to their embedded tomcat.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28727] - CLOSE_WAIT connections draw 100 % cpu

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28727.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28727

CLOSE_WAIT connections draw 100 % cpu





--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 10:41 ---
I'm going to switch to Tomcat 5.0.28 embedded.
The bug usually shows up in 2/3 days, depending on users activity.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31405] New: - [Documentation RFE] unpackwar implications (slow startup)

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31405.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31405

[Documentation RFE] unpackwar implications (slow startup)

   Summary: [Documentation RFE] unpackwar implications (slow
startup)
   Product: Tomcat 5
   Version: 5.0.28
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31405] - [Documentation RFE] unpackwar implications (slow startup)

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31405.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31405

[Documentation RFE] unpackwar implications (slow startup)





--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 12:44 ---
Created an attachment (id=12856)
startUp.png quality analyzer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31405] - [Documentation RFE] unpackwar implications (slow startup)

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31405.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31405

[Documentation RFE] unpackwar implications (slow startup)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 12:56 ---
Let's not waste anyone's time with this quality metric. If you want to suggest
changes, please provide patches.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Interesting usage of Tomcat...

2004-09-24 Thread Shapira, Yoav

Hi,
By the way, sorry to veer a bit outside my original topic, but talking
about new embedded Tomcat stuff: we've made great progress in the
Geronimo world over the past couple of weeks in this area.  There's a
TomcatGBean implemented and working.  Some enterprise-stuff issues
remain, e.g. JAAS/JACC integration and some JSR77 stuff, but the basic
use-case is working.  The status is tracked at
http://wiki.apache.org/geronimo/Tomcat and the code is at
http://svn.apache.org/viewcvs.cgi/geronimo/trunk/modules/tomcat/?root=Ap
ache-SVN.

Yoav Shapira
Millennium Research Informatics


-Original Message-
From: Jean-Francois Arcand [mailto:[EMAIL PROTECTED]
Sent: Thursday, September 23, 2004 5:01 PM
To: Tomcat Developers List
Subject: Re: Interesting usage of Tomcat...



Costin Manolache wrote:
 Mladen Turk wrote:

 Shapira, Yoav wrote:


http://www.theserverside.com/talks/VendorPerspectives/Mainsoft/intervie
w
 .tss


 Yes, indeed :)

 Almost a year ago I proposed a project that would enable Tomcat to
 seemesly integrate the legacy code. Something like moving the
 perspective from being an backend to becoming an integrator.

 Of course, the reaction was not much in favor :).
 But seems that the direction is to integrate as much of those
 'million lines written' as possible.

 Regards,
 MT.


 We know more now than we did one year ago :-)

 Beeing able to integrate our code in other apps and other apps in our
 code is indeed becoming more and more important.

plug
and guess what I'm talking about at Apache Conf 2004 ;-).
/plug

OK that was an easy plug :-)

-- Jeanfrancois


 Costin



 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31405] - [Documentation RFE] unpackwar implications (slow startup)

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31405.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31405

[Documentation RFE] unpackwar implications (slow startup)

[EMAIL PROTECTED] changed:

   What|Removed |Added

URL||http://jakarta.apache.org/to
   ||mcat/tomcat-5.0-
   ||doc/config/host.html#Standar
   ||d Implementation



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 13:01 ---
my tomcat server has 4 servlets loaded multiple times by 3 connectors (in 3
different wars).

In order not to have to clean after these instances I put unpackwar=false.
As a minor security consideration, each time less the files are on the disk, the
smaller is the exposure (albeit an informed attacker would anyway be most
interested in the ./work/*/_* directories).

Anyway, being aware that this would reduce startup, time, I was surprised about
the accelerated deterioration of startup time as my application and the number
of jsp's grew. It's roughly 300 struts-related classes and 300 jsps. On an intel
machine one generation behind, it easily took 5 minutes or more to start,
especially, the super.init() method of the four servlets took ages.
As per the attached screenshot, I guess the reason for this is the unpackwar
that throws over 10'000 (probably planned?) exceptions (WARDir*...) and might
unpack the war many times.

RFE:

If these assumptions are right, I suggest to enhance the documentation at the
above URL to inform the tomcat administrator about these implications.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Patrick Grundschok/te1/te/cag est absent(e).

2004-09-24 Thread Patrick Grundschok




Je serai absent(e) du  23/09/2004 au 27/09/2004.

I will be on holiday on friday the 24/9 and will be back on monday at the
office


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Bugzilla 30936: secure attribute is persisted twice

2004-09-24 Thread Peter Rossbach
Hmm,
   I thing we use different protocol handler classes for HTTP and AJP 
and that
   is the reason behind the late creation with the init method. :-\  
  
   I also thing we can remove a lot of the unused attributes that 
Remy has detected.

Peter
  
Shapira, Yoav schrieb:

Hi,
 

An option would be to
tie the Connector object creation with the creation of the protocol
handler instance.
   

That makes sense anyways.  Why delay, since the Connect isn't useful
without a ProtocolHandler anyways?
Yoav

This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 31405] - [Documentation RFE] unpackwar implications (slow startup)

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31405.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31405

[Documentation RFE] unpackwar implications (slow startup)





--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 13:52 ---
Even if it is the problem (which I'm not sure of), it will be very difficult to
fix.
I'd like to point out that the regular file based stuff creates as many of these
exceptions, and, generally, Struts webapps startup is extremely slow.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



classloader

2004-09-24 Thread Costin Manolache
I had a small vacation, and managed to make some of the changes in the 
classloader/module area. I'm not completely done - but I want to 
eventually start checking in some of the code ( if nobody objects ).

To avoid breaking anything, I started a new package ( 
o.a.tomcat.util.loader ), and started with the existing classes, with 
small refactorings.

- WebappClassLoader
- Bootstrap
- CatalinaProperties
plus some extra classes to support jboss ( or m-let) style loading.
I tried to remove all dependencies outside JDK1.4 - the package is
very small, and I think it's ok to not use commons-logging or jmx in 
this area. Apache.naming and jmx functionality is added via hooks - 
after the server loader ( now repository ) is started.

I think this will improve a bit the code structure - currently we have a 
bit of a mess in how we select some classes in the bin/ jars.

I'm not planning any change in the existing code - except adding few 
classes and code to allow the new loader to be used ( as an option ) 
instead of the old one.

My goal ( which is not yet completely done ) is to support modules for
connectors/interceptors/etc - with reloading and all the cool stuff, and 
make this integrable with existing systems ( jboss, other jmx/mlet based 
 applications, eclipse ). Instead of having the entire tomcat as one 
chunk of code ( plus all the depenencies ) integrated in one plugin, it 
should be possible to add a smaller subset and then have 
connectors/auth/etc as separate plugins.

Please let me know if this is ok with you - I'll have another long trip 
in mid Oct. and I hope to get this done, but if there are problems with 
what I'm trying to do ( or conflicts with other plans ), I would 
appreciate feedback before I waste the time :-)

Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


RE: classloader

2004-09-24 Thread Shapira, Yoav

Hi,
I think it's a great goal and a great idea -- I look forward to seeing
progress on it ;)

Yoav Shapira
Millennium Research Informatics


-Original Message-
From: news [mailto:[EMAIL PROTECTED] On Behalf Of Costin Manolache
Sent: Friday, September 24, 2004 10:41 AM
To: [EMAIL PROTECTED]
Subject: classloader

I had a small vacation, and managed to make some of the changes in the
classloader/module area. I'm not completely done - but I want to
eventually start checking in some of the code ( if nobody objects ).

To avoid breaking anything, I started a new package (
o.a.tomcat.util.loader ), and started with the existing classes, with
small refactorings.

- WebappClassLoader
- Bootstrap
- CatalinaProperties
plus some extra classes to support jboss ( or m-let) style loading.

I tried to remove all dependencies outside JDK1.4 - the package is
very small, and I think it's ok to not use commons-logging or jmx in
this area. Apache.naming and jmx functionality is added via hooks -
after the server loader ( now repository ) is started.

I think this will improve a bit the code structure - currently we have
a
bit of a mess in how we select some classes in the bin/ jars.

I'm not planning any change in the existing code - except adding few
classes and code to allow the new loader to be used ( as an option )
instead of the old one.

My goal ( which is not yet completely done ) is to support modules
for
connectors/interceptors/etc - with reloading and all the cool stuff,
and
make this integrable with existing systems ( jboss, other jmx/mlet
based
  applications, eclipse ). Instead of having the entire tomcat as one
chunk of code ( plus all the depenencies ) integrated in one plugin, it
should be possible to add a smaller subset and then have
connectors/auth/etc as separate plugins.

Please let me know if this is ok with you - I'll have another long trip
in mid Oct. and I hope to get this done, but if there are problems with
what I'm trying to do ( or conflicts with other plans ), I would
appreciate feedback before I waste the time :-)

Costin


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




This e-mail, including any attachments, is a confidential business communication, and 
may contain information that is confidential, proprietary and/or privileged.  This 
e-mail is intended only for the individual(s) to whom it is addressed, and may not be 
saved, copied, printed, disclosed or used by anyone else.  If you are not the(an) 
intended recipient, please immediately delete this e-mail from your computer system 
and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2004-09-24 Thread yoavs
yoavs   2004/09/24 07:55:14

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java
   webapps/docs changelog.xml
  Log:
  Bugzilla 31356.
  
  Revision  ChangesPath
  1.36  +5 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- ManagerBase.java  7 Sep 2004 21:45:07 -   1.35
  +++ ManagerBase.java  24 Sep 2004 14:55:13 -  1.36
  @@ -799,8 +799,11 @@
   StringBuffer buffer = new StringBuffer();
   do {
   int resultLenBytes = 0;
  -if (result != null)
  +if (result != null) {
   buffer = new StringBuffer();
  +duplicates++;
  +}
  +
   while (resultLenBytes  this.sessionIdLength) {
   getRandomBytes(random);
   random = getDigest().digest(random);
  
  
  
  1.117 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.116
  retrieving revision 1.117
  diff -u -r1.116 -r1.117
  --- changelog.xml 23 Sep 2004 20:14:48 -  1.116
  +++ changelog.xml 24 Sep 2004 14:55:14 -  1.117
  @@ -57,6 +57,9 @@
fix
  bug31362/bug: Missing -Xdebug in catalina.bat when launching with JPDA 
and Security. (yoavs)
/fix
  + fix
  +   bug31356/bug: Duplicates not counted in session generation. (yoavs)
  + /fix
   /changelog
 /subsection
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31356] - Duplicate sessions counter not incremented in ManagerBase

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31356.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31356

Duplicate sessions counter not incremented in ManagerBase

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 14:59 ---
OK, I've applied your patch, fixing this item for now.  As Remy said, the whole 
duplicates counting and tracking may be removed in a future release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29823] - 'admin' app saves non-latin descriptions as garbage

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29823.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29823

'admin' app saves non-latin descriptions as garbage

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 15:02 ---
*** Bug 31381 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31381] - password for connection pooling problem

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31381.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31381

password for connection pooling problem

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 15:01 ---
This is a known issue: see the data for the duplicate one.  $'s are 
interpreted ;(

*** This bug has been marked as a duplicate of 29823 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31382] - Stack overflow at JspServlet with self referencing JSP tag files.

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31382.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31382

Stack overflow at JspServlet with self referencing JSP tag files.

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Catalina|Jasper



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 15:03 ---
Pleast post the JSP file (or a WAR containing a complete webapp) we can use to 
reproduce this problem.  I'm also changing the component from Catalina to 
Jasper.  Finally, even though I'd guess it's still present, can you please test 
on 5.0.28 (the latest stable version at the time of this writing)?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: classloader

2004-09-24 Thread Remy Maucherat
Costin Manolache wrote:
I had a small vacation, and managed to make some of the changes in the 
classloader/module area. I'm not completely done - but I want to 
eventually start checking in some of the code ( if nobody objects ).

To avoid breaking anything, I started a new package ( 
o.a.tomcat.util.loader ), and started with the existing classes, with 
small refactorings.

- WebappClassLoader
- Bootstrap
- CatalinaProperties
plus some extra classes to support jboss ( or m-let) style loading.
I tried to remove all dependencies outside JDK1.4 - the package is
very small, and I think it's ok to not use commons-logging or jmx in 
this area. Apache.naming and jmx functionality is added via hooks - 
after the server loader ( now repository ) is started.

I think this will improve a bit the code structure - currently we have 
a bit of a mess in how we select some classes in the bin/ jars.

I'm not planning any change in the existing code - except adding few 
classes and code to allow the new loader to be used ( as an option ) 
instead of the old one.

My goal ( which is not yet completely done ) is to support modules for
connectors/interceptors/etc - with reloading and all the cool stuff, 
and make this integrable with existing systems ( jboss, other jmx/mlet 
based  applications, eclipse ). Instead of having the entire tomcat as 
one chunk of code ( plus all the depenencies ) integrated in one 
plugin, it should be possible to add a smaller subset and then have 
connectors/auth/etc as separate plugins.

Please let me know if this is ok with you - I'll have another long 
trip in mid Oct. and I hope to get this done, but if there are 
problems with what I'm trying to do ( or conflicts with other plans ), 
I would appreciate feedback before I waste the time :-)
Ok. How broken is it ? ;) If it's not that broken, I think you should 
overwrite the existing code. Or you can keep it elsewhere (in utils) and 
work on it for the next branch.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util ServerInfo.java ServerInfo.properties

2004-09-24 Thread mturk
mturk   2004/09/24 09:40:50

  Modified:catalina/src/share/org/apache/catalina/util ServerInfo.java
ServerInfo.properties
  Log:
  Add server built and version number to ServerInfo.
  It just makes '-version' more informative.
  
  Revision  ChangesPath
  1.4   +48 -3 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ServerInfo.java
  
  Index: ServerInfo.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ServerInfo.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ServerInfo.java   30 Jun 2004 15:25:31 -  1.3
  +++ ServerInfo.java   24 Sep 2004 16:40:50 -  1.4
  @@ -41,6 +41,16 @@
*/
   private static String serverInfo = null;
   
  +/**
  + * The server built String.
  + */
  +private static String serverBuilt = null;
  +
  +/**
  + * The server's version number String.
  + */
  +private static String serverNumber = null;
  +
   static {
   
   try {
  @@ -50,12 +60,18 @@
   props.load(is);
   is.close();
   serverInfo = props.getProperty(server.info);
  +serverBuilt = props.getProperty(server.built);
  +serverNumber = props.getProperty(server.number);
   } catch (Throwable t) {
   ;
   }
   if (serverInfo == null)
   serverInfo = Apache Tomcat;
  -
  +if (serverBuilt == null)
  +serverBuilt = unknown;
  +if (serverNumber == null)
  +serverNumber = 5.5.0.0;
  +
   }
   
   
  @@ -71,9 +87,38 @@
   
   }
   
  +/**
  + * Return the server built time for this version of Tomcat.
  + */
  +public static String getServerBuilt() {
  +
  +return (serverBuilt);
  +
  +}
  +
  +/**
  + * Return the server's version number.
  + */
  +public static String getServerNumber() {
  +
  +return (serverNumber);
  +
  +}
   
   public static void main(String args[]) {
  -System.out.println(Version:  + getServerInfo());
  +System.out.println(Server version:  + getServerInfo());
  +System.out.println(Server built:+ getServerBuilt());
  +System.out.println(Server number:   + getServerNumber());
  +System.out.println(OS Name: +
  +   System.getProperty(os.name));
  +System.out.println(OS Version:  +
  +   System.getProperty(os.version));
  +System.out.println(Architecture:+
  +   System.getProperty(os.arch));
  +System.out.println(JVM Version: +
  +   System.getProperty(java.runtime.version));
  +System.out.println(JVM Vendor:  +
  +   System.getProperty(java.vm.vendor));   
 
   }
   
   }
  
  
  
  1.2   +2 -0  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ServerInfo.properties
  
  Index: ServerInfo.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/util/ServerInfo.properties,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ServerInfo.properties 18 Jul 2002 16:47:46 -  1.1
  +++ ServerInfo.properties 24 Sep 2004 16:40:50 -  1.2
  @@ -1 +1,3 @@
   server.info=Apache Tomcat/@VERSION@
  [EMAIL PROTECTED]@
  [EMAIL PROTECTED]@
  \ No newline at end of file
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina build.xml

2004-09-24 Thread mturk
mturk   2004/09/24 09:41:12

  Modified:catalina build.xml
  Log:
  Add server built and version number to ServerInfo.
  It just makes '-version' more informative.
  
  Revision  ChangesPath
  1.74  +6 -1  jakarta-tomcat-catalina/catalina/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/build.xml,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- build.xml 16 Sep 2004 15:31:19 -  1.73
  +++ build.xml 24 Sep 2004 16:41:12 -  1.74
  @@ -616,9 +616,14 @@
 exclude name=org/apache/naming/factory/SendMailFactory.java/
 exclude name=org/apache/catalina/launcher/**/
   /javac
  -
  +tstamp
  +format property=TODAY pattern=MMM d  locale=en/
  +format property=TSTAMP pattern=hh:mm:ss/
  +/tstamp
   !-- Copy static resource files --
   filter token=VERSION value=${version}/
  +filter token=VERSION_NUMBER value=${version.number}/
  +filter token=VERSION_BUILT value=${TODAY} ${TSTAMP}/
   copy todir=${classes.dir} filtering=true encoding=ISO-8859-1
 fileset dir=src/share
   exclude name=**/*.java/
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin CommitChangesAction.java

2004-09-24 Thread Mladen Turk
[EMAIL PROTECTED] wrote:
amyroh  2004/09/17 11:32:14
  Log:
  More logging changes - let me know if you see any problems with'em.

[javac] \jakarta-tomcat-catalina\tester\src\teste
r\org\apache\tester\TestClient.java:488: cannot resolve symbol
[javac] symbol  : variable log
[javac] location: class org.apache.tester.TestClient
[javac] log.println(DATA:  + outData);
[javac] ^
[javac] \jakarta-tomcat-catalina\tester\src\teste
r\org\apache\tester\TestClient.java:490: cannot resolve symbol
[javac] symbol  : variable log
[javac] location: class org.apache.tester.TestClient
[javac] log.println(TEXT:  + outText);
[javac] ^
Seems that this is caused by your lates patch.
MT.


smime.p7s
Description: S/MIME Cryptographic Signature


DO NOT REPLY [Bug 31413] New: - Can't deploy WAR files locally

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31413.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31413

Can't deploy WAR files locally

   Summary: Can't deploy WAR files locally
   Product: Tomcat 5
   Version: 5.5.1
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Trying to deploy a WAR file using the html manager console, I get the following
exception. It only occurs when I use localhost for this operation.


24-Sep-2004 3:25:45 PM org.apache.catalina.core.ApplicationContext log
SEVERE: HTMLManager: FAIL - Deploy Upload Failed, Exception: Exception invoking
method check
javax.management.RuntimeOperationsException: Exception invoking method check
at org.apache.commons.modeler.BaseModelMBean.invoke(BaseModelMBean.java:511)
at com.sun.jmx.mbeanserver.DynamicMetaDataImpl.invoke(Unknown Source)
at com.sun.jmx.mbeanserver.MetaDataImpl.invoke(Unknown Source)
at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(Unknown Source)
at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(Unknown Source)
at org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1402)
at
org.apache.catalina.manager.HTMLManagerServlet.doPost(HTMLManagerServlet.java:209)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:709)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:482)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:106)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799)
at
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:576)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
at org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:875)
at org.apache.catalina.startup.HostConfig.checkResources(HostConfig.java:949)
at org.apache.catalina.startup.HostConfig.check(HostConfig.java:1151)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.commons.modeler.BaseModelMBean.invoke(BaseModelMBean.java:503)
... 22 more
24-Sep-2004 3:25:45 PM org.apache.catalina.core.ApplicationContext log
INFO: HTMLManager: list: Listing contexts for virtual host 'localhost'

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31413] - Can't deploy WAR files locally

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=31413.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31413

Can't deploy WAR files locally

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 20:26 ---
This works for me.
So try a nightly, and if it still doesn't work, describe exactly the server
state (using the default out-of-the-box config would be best) and the
application you're deploying.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster to-do.txt

2004-09-24 Thread fhanik
fhanik  2004/09/24 13:45:47

  Modified:modules/cluster to-do.txt
  Log:
  Added a wish for the ability to disable replicated attribute events
  
  Revision  ChangesPath
  1.2   +1 -0  jakarta-tomcat-catalina/modules/cluster/to-do.txt
  
  Index: to-do.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/modules/cluster/to-do.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- to-do.txt 10 Sep 2004 21:52:32 -  1.1
  +++ to-do.txt 24 Sep 2004 20:45:47 -  1.2
  @@ -7,4 +7,5 @@
   6. Implement context attribute replication (?)
   7. JMX friendly
   8. Documentation
  +9. Add a flag for replicated  attribute events, to enable or disable them
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17014] - ServletResponse.flushBuffer() no longer commits the response

2004-09-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=17014.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17014

ServletResponse.flushBuffer() no longer commits the response

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2004-09-24 22:44 ---
I just ran into this problem myself. I've been working on integrating my own
socket factory into the coyote connecter code (a socket factory that produces
secure sockets) and this socket factory produces sockets that do not flush on
close so I never get any replies. I don't think that socket.close() can be
assumed to flush the output stream (at least the javadoc doesn't say so) and
shutdownOutput() or flush() are never called. I think that this line in
org.apache.coyote.http11.Http11Protocol:

// recycle kernel sockets ASAP
try { if (socket != null) socket.close (); }

should be changed to either include a call to socket.shutdownOutput() or
out.flush() before the close.

/Sam

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]