Re: [VOTE] PMC Chair

2005-03-25 Thread Henri Gomez
[ +1 ] Remy Maucherat

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] PMC Chair

2005-03-25 Thread Mladen Turk
[ +1 ] Remy Maucherat
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-03-25 Thread pero
pero2005/03/25 00:29:38

  Modified:catalina/src/share/org/apache/catalina/realm JNDIRealm.java
RealmBase.java
   webapps/docs changelog.xml
  Log:
  Fix some RealmBase/JNDIRealm log.isXXXEnabled
  
  Revision  ChangesPath
  1.23  +3 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java
  
  Index: JNDIRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- JNDIRealm.java24 Mar 2005 17:12:50 -  1.22
  +++ JNDIRealm.java25 Mar 2005 08:29:32 -  1.23
  @@ -1065,7 +1065,8 @@
   
   // Check no further entries were found
   if (results.hasMore()) {
  -containerLog.info(username  + username +  has multiple 
entries);
  +if(containerLog.isInfoEnabled())
  +containerLog.info(username  + username +  has multiple 
entries);
   return (null);
   }
   
  
  
  
  1.50  +19 -11
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java
  
  Index: RealmBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v
  retrieving revision 1.49
  retrieving revision 1.50
  diff -u -r1.49 -r1.50
  --- RealmBase.java2 Mar 2005 19:27:11 -   1.49
  +++ RealmBase.java25 Mar 2005 08:29:34 -  1.50
  @@ -741,10 +741,12 @@
   response.sendError
   (HttpServletResponse.SC_FORBIDDEN,
sm.getString(realmBase.forbidden));
  -if( log.isDebugEnabled() ) log.debug(No roles );
  +if( log.isDebugEnabled() )
  +log.debug(No roles );
   return (false); // No listed roles means no access at all
   } else {
  -log.debug(Passing all access);
  +if(log.isDebugEnabled())
  +log.debug(Passing all access);
   return (true);
   }
   } else if (principal == null) {
  @@ -793,7 +795,8 @@
   
   GenericPrincipal gp = (GenericPrincipal) principal;
   if (!(gp.getRealm() == this)) {
  -log.debug(Different realm  + this +   + gp.getRealm());//
return (false);
  +if(log.isDebugEnabled())
  +log.debug(Different realm  + this +   + 
gp.getRealm());//return (false);
   }
   boolean result = gp.hasRole(role);
   if (log.isDebugEnabled()) {
  @@ -956,7 +959,8 @@
   
   // Validate and update our current component state
   if (started) {
  -log.info(sm.getString(realmBase.alreadyStarted));
  +if(log.isInfoEnabled())
  +log.info(sm.getString(realmBase.alreadyStarted));
   return;
   }
   if( !initialized ) {
  @@ -992,7 +996,8 @@
   
   // Validate and update our current component state
   if (!started) {
  -log.info(sm.getString(realmBase.notStarted));
  +if(log.isInfoEnabled())
  +log.info(sm.getString(realmBase.notStarted));
   return;
   }
   lifecycle.fireLifecycleEvent(STOP_EVENT, null);
  @@ -1011,7 +1016,8 @@
   if ( oname!=null ) {   
   try {   
   Registry.getRegistry(null, null).unregisterComponent(oname); 
  -log.debug( unregistering realm  + oname );   
  +if(log.isDebugEnabled())
  +log.debug( unregistering realm  + oname );   
   } catch( Exception ex ) {   
   log.error( Can't unregister realm  + oname, ex);   
   }  
  @@ -1161,7 +1167,7 @@
   // Digest the credentials and return as hexadecimal
   return (HexUtils.convert(md.digest()));
   } catch(Exception ex) {
  -ex.printStackTrace();
  +log.error(ex);
   return credentials;
   }
   
  @@ -1268,11 +1274,12 @@
   host + path);
   }
   if( mserver.isRegistered(parent ))  {
  -log.debug(Register with  + parent);
  +if(log.isDebugEnabled())
  +log.debug(Register with  + parent);
   mserver.setAttribute(parent, new Attribute(realm, 
this));
   }
   } catch (Exception e) {
  -log.info(Parent not available yet:  + parent);  
  +log.error(Parent not available yet:  + parent);  
  

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java

2005-03-25 Thread pero
pero2005/03/25 00:31:33

  Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java
  Log:
  Remove DefaultContext comment
  
  Revision  ChangesPath
  1.35  +1 -28 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
  
  Index: MBeanFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- MBeanFactory.java 29 Jan 2005 19:37:27 -  1.34
  +++ MBeanFactory.java 25 Mar 2005 08:31:31 -  1.35
  @@ -143,35 +143,8 @@
   }
   return t;
   }
  -
   
  /**
  - * Get Parent DefaultContext to add its child component 
  - * from parent's ObjectName
  - */
  -/*
  -private DefaultContext getDefaultContext(ObjectName pname) 
  -throws Exception {
  -
  -String type = pname.getKeyProperty(type);
  -if (type.equals(DefaultContext)) {
  -Service service = getService(pname);
  -StandardEngine engine = (StandardEngine) service.getContainer();
  -String hostName = pname.getKeyProperty(host);
  -if (hostName!=null) {
  -StandardHost host = 
  -(StandardHost) engine.findChild(hostName);
  -return host.getDefaultContext();
  -} else {
  -return engine.getDefaultContext();
  -}
  -}
  -return null;
  -}
  -*/
  -
  -
  -/**
* Get Parent ContainerBase to add its child component 
* from parent's ObjectName
*/
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] PMC Chair

2005-03-25 Thread Remy Maucherat
Yoav Shapira wrote:
The initial Tomcat PMC chair should be:
[  ] Remy Maucherat
[  ] Yoav Shapira 
The vote needs to be somewhat private, and sent to someone trusted who 
will then announce the final tally ;)

(otherwise, it's banana republic: whoever does not agree raise your 
hand; oh, I kinda liked you, you know; [machine gun sound]; anyone else ?)

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans MBeanFactory.java

2005-03-25 Thread pero
pero2005/03/25 00:38:48

  Modified:catalina/src/share/org/apache/catalina/mbeans
MBeanFactory.java
  Log:
  Remove StandardDefaultContext Handling at findObjectName
  correct some Indentation!
  
  Revision  ChangesPath
  1.36  +9 -11 
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java
  
  Index: MBeanFactory.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanFactory.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- MBeanFactory.java 25 Mar 2005 08:31:31 -  1.35
  +++ MBeanFactory.java 25 Mar 2005 08:38:48 -  1.36
  @@ -117,8 +117,6 @@
   
   if (type.equals(org.apache.catalina.core.StandardContext)) {
   return StandardContext;
  -} else if 
(type.equals(org.apache.catalina.core.StandardDefaultContext)) {
  -return DefaultContext;
   } else if (type.equals(org.apache.catalina.core.StandardEngine)) {
   return Engine;
   } else if (type.equals(org.apache.catalina.core.StandardHost)) {
  @@ -277,10 +275,10 @@
   
   // Create a new DataSourceRealm instance
   DataSourceRealm realm = new DataSourceRealm();
  - realm.setDataSourceName(dataSourceName);
  - realm.setRoleNameCol(roleNameCol);
  - realm.setUserCredCol(userCredCol);
  - realm.setUserNameCol(userNameCol);
  +realm.setDataSourceName(dataSourceName);
  +realm.setRoleNameCol(roleNameCol);
  +realm.setUserCredCol(userCredCol);
  +realm.setUserNameCol(userNameCol);
   realm.setUserRoleTable(userRoleTable);
   realm.setUserTable(userTable);
   
  @@ -377,10 +375,10 @@
   
   // Create a new JDBCRealm instance
   JDBCRealm realm = new JDBCRealm();
  - realm.setDriverName(driverName);
  - realm.setConnectionName(connectionName);
  - realm.setConnectionPassword(connectionPassword);
  - realm.setConnectionURL(connectionURL);
  +realm.setDriverName(driverName);
  +realm.setConnectionName(connectionName);
  +realm.setConnectionPassword(connectionPassword);
  +realm.setConnectionURL(connectionURL);
   
   // Add the new instance to its parent component
   ObjectName pname = new ObjectName(parent);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationHttpRequest.java

2005-03-25 Thread pero
pero2005/03/25 00:41:24

  Modified:catalina/src/share/org/apache/catalina/core
ApplicationHttpRequest.java
  Log:
  Indentation. No change.
  
  Revision  ChangesPath
  1.26  +2 -2  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java
  
  Index: ApplicationHttpRequest.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/ApplicationHttpRequest.java,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- ApplicationHttpRequest.java   7 Feb 2005 21:56:32 -   1.25
  +++ ApplicationHttpRequest.java   25 Mar 2005 08:41:23 -  1.26
  @@ -511,7 +511,7 @@
   // Return the current session if it exists and is valid
   if (session != null  session.isValid()) {
   return (session.getSession());
  - }
  +}
   
   HttpSession other = super.getSession(false);
   if (create  (other == null)) {
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] PMC Chair

2005-03-25 Thread Mladen Turk
Remy Maucherat wrote:
The vote needs to be somewhat private, and sent to someone trusted who 
will then announce the final tally ;)

Probably :)
Perhaps to Henri Yandell. He's the current PMC, and I think we can
trust him. After all, I heard that he likes administrative jobs ;).
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] PMC Chair

2005-03-25 Thread Remy Maucherat
Mladen Turk wrote:
Remy Maucherat wrote:
The vote needs to be somewhat private, and sent to someone trusted who 
will then announce the final tally ;)
Probably :)
Perhaps to Henri Yandell. He's the current PMC, and I think we can
trust him. After all, I heard that he likes administrative jobs ;).
That seems like a good idea.
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33810] - Stream closed errors from JSP tags under load

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33810


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 11:01 ---
That was just an advice that you shouldn't be calling close in your tags since
it is useless (obviously, the tag calling close will not be the one then
experiencing the exception: it can be fairly random).
I marked the bug as fixed since I fixed the issue in CVS.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33325] - add target clean to top-level build.xml

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33325.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33325


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 04:17 ---
Netbuild file date and version updated, top-level clean target added.  Please
test when 5.5.9 comes out in a few days.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http MimeHeaders.java

2005-03-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
billbarker2005/03/24 19:53:25
  Modified:util/java/org/apache/tomcat/util/http MimeHeaders.java
  Log:
  Make setValue guarantee that the header is unique (that's how it's being used anyway).
  
  Fix for Bug #34113

  - MessageBytes value=getValue(name);
  - if( value == null ) {
  - MimeHeaderField mh = createHeader();
  - mh.getName().setString(name);
  - value=mh.getValue();
  - }
  - return value;
  +for ( int i = 0; i  count; i++ ) {
  +if(headers[i].getName().equalsIgnoreCase(name)) {
  +for ( int j=i+1; j  count; j++ ) {
  +if(headers[j].getName().equalsIgnoreCase(name)) {
  +removeHeader(j--);
  +}
  +}
  +return headers[i].getValue();
  +}
  +}
  +MimeHeaderField mh = createHeader();
  +mh.getName().setString(name);
  +return mh.getValue();
This should be more efficient as I don't like what removeHeader does. 
Since it only happens when actually having a multi valued header, it is 
not that critical, however.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 33806] - Session tracking using URL rewriting fails, if client URL-encodes reserved characters ; and =

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33806.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33806





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 12:00 ---
(In reply to comment #1)
 The client needs to preserve path parameters, otherwise it will not work.

I'm well aware of that. Question was: by performing an URL encoding on reserved
characters ; and :, it the client actually doing something illegal or should
tomcat be able to handle it?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34176] New: - can't retrieve JNDI resource in 5.5.8 (works in 5.5.7)

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34176.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34176

   Summary: can't retrieve JNDI resource in 5.5.8 (works in 5.5.7)
   Product: Tomcat 5
   Version: 5.5.8
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


In Tomcat 5.5.8, JNDI resource can't be retrieved (works in 5.5.7)
With 
Context path=/test docBase=/home/marc/EWorkspace/test reloadable=false
debug=1
  Resource name=mail/Session auth=Container type=javax.mail.Session
mail.smtp.host=localhost/
/Context

and following code (in an ini Servlet)
  Context ctx = new InitialContext();
  Object sessionobj = ctx.lookup(java:/comp/env/mail/Session);
  log(session obj:  + sessionobj);

without any resource ref in the web xml, logs show that resource is found in
Tomcat 5.5.7 but not in 5.5.8.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33806] - Session tracking using URL rewriting fails, if client URL-encodes reserved characters ; and =

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33806.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33806





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 12:06 ---
';' is reserved, because it is used to define path parameters (such as the
session id). If it is encoded, it becomes a regular part of the URI.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33739] - 5.5 Docs missing CATALINA_BASE info formerly in RUNNING.txt

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33739.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33739


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-23 17:02 ---
Added clarifying comments and references/instructions for RUNNING.txt into
setup.html.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] PMC Chair

2005-03-25 Thread Jim Jagielski
I would recommend that before anyone responds, we decide who should
rec' and tally the votes. Also, votes should only be counted
from those who will be on the new PMC.

So before the vote:

   1. Finalize list of PMC members
  (all current committers)
   2. Determine who to collect and tally votes
  (I propose Henri Yandell)


-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
There 10 types of people: those who read binary and everyone else.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34176] - can't retrieve JNDI resource in 5.5.8 (works in 5.5.7)

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34176.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34176


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 14:26 ---
Yup, that was my fault when building Tomcat.  Already ACKed and resolved for
5.5.9.  (5.5.8 will not leave alpha status).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33806] - Session tracking using URL rewriting fails, if client URL-encodes reserved characters ; and =

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33806.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33806





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 14:33 ---
(In reply to comment #3)
 ';' is reserved, because it is used to define path parameters (such as the
 session id). If it is encoded, it becomes a regular part of the URI.

Okay, thank you for clearing that out.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34150] - child pid # exit signal Segmentation fault (11)

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34150


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]   |tomcat-
   ||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 14:34 ---
You might want to try prefork to check whether this is a thread-safety issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33810] - Stream closed errors from JSP tags under load

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33810





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 14:35 ---
Are you talking about the fix you made in BodyContentImpl.setWriter() method to
set closed = false? If so, please note that this is happening after the fix.
We are using the patched jasper-runtime.jar with that fix.

Or, Did you make a new fix after I re-opened the bug?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [VOTE] PMC Chair

2005-03-25 Thread Yoav Shapira
Hi,

 I would recommend that before anyone responds, we decide who should
 rec' and tally the votes. Also, votes should only be counted
 from those who will be on the new PMC.
 
 So before the vote:
 
1. Finalize list of PMC members
   (all current committers)
2. Determine who to collect and tally votes
   (I propose Henri Yandell)

All fine by me.  I suppose people who have been inactive for a while aren't
suddenly going to come in and vote.  And then once we have a PMC, we can
decide if we want to do anything like move them to honorary emeritus status
out of the CVS avail file.

Have a good weekend everyone,

Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reminder: 5.5.9 tomorrow

2005-03-25 Thread Yoav Shapira
Hi,

This is just a reminder that I plan to cut and tag Tomcat version 5.5.9
tomorrow, Saturday March 26th, at 1400h my time, which is 1900h UTC/GMT.

 

Jan, as Remy and you discussed yesterday on the mailing list, please revert
your commit that throws the IllegalStateException in HttpSession#getId.

 

Thanks, and have a good weekend everyone,

 

Yoav Shapira

System Design and Management Fellow

MIT Sloan School of Management / School of Engineering

Cambridge, MA USA

 mailto:[EMAIL PROTECTED] [EMAIL PROTECTED] /
mailto:[EMAIL PROTECTED] [EMAIL PROTECTED]

 



Behaviour of mod_jk AJP 1.3 load balanced workers

2005-03-25 Thread Mathias Herberts
Hi,
we are using Tomcat as our application server with front end Apache 
servers (1.3.33) running mod_jk from Jakarta Tomcat Connectors 1.2.8.

We have load balancing workers which load balance ajp13 workers.
Some of the applications we are hosting make heavy use of HTML Forms 
using GET as the submission method. From time to time, a form text input 
field will be big (above 8kb) making the AJP 1.3 packet too big and thus 
leading to an error in jk_msg_buff.c:jk_b_append_string called from 
jk_msh_buff.c:ajp_marshal_into_msgb. The error is clearly due to the 
size of the query string. The behavior of ajp_marshal_into_msgb is to 
qualify the error as unrecoverable (is_recoverable_error is set to 
JK_FALSE) and ajp_service will return JK_FALSE thus leading to the given 
worker being unavailable for recovery_time seconds (at least 60 seconds 
per default).

The error encountered is not due to a failure in Tomcat but to a bad 
request. If I agree that is_recoverable_error should indeed be set to 
JK_FALSE so no other worker is tried for this request, I think it is 
wrong to consider the worker as having failed. The impact of such a 
request should be limited to the request itself and not fail the whole 
worker, otherwise we have a wonderful DOS opportunity.

What do others think of this beahviour?
Thanks,
Mathias.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] PMC Chair

2005-03-25 Thread Bill Barker
- Original Message - 
From: Remy Maucherat [EMAIL PROTECTED]
To: Tomcat Developers List tomcat-dev@jakarta.apache.org
Sent: Friday, March 25, 2005 1:34 AM
Subject: Re: [VOTE] PMC Chair


Yoav Shapira wrote:
The initial Tomcat PMC chair should be:
[X ] Remy Maucherat
[  ] Yoav Shapira
The vote needs to be somewhat private, and sent to someone trusted who will 
then announce the final tally ;)

(otherwise, it's banana republic: whoever does not agree raise your hand; 
oh, I kinda liked you, you know; [machine gun sound]; anyone else ?)

I love the smell of machine gun fire in the morning ;-).
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33810] - Stream closed errors from JSP tags under load

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33810





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 17:19 ---
Yes, I did make a new change in CVS.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34113] - [PATCH] setHeader( ) method in Response object does not clear multiple values

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34113.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34113


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 17:38 ---
This is fixed now in the CVS, and will appear in 5.5.9.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-03-25 Thread billbarker
billbarker2005/03/25 08:43:09

  Modified:webapps/docs changelog.xml
  Log:
  doc change
  
  Revision  ChangesPath
  1.269 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.268
  retrieving revision 1.269
  diff -u -r1.268 -r1.269
  --- changelog.xml 25 Mar 2005 08:29:34 -  1.268
  +++ changelog.xml 25 Mar 2005 16:43:09 -  1.269
  @@ -160,6 +160,9 @@
 fix
   bug32741/bug: Fix spelling of committed [patch from Ben 
Souther] (yoavs)
 /fix
  +  fix
  +bug34133/bug: Make setHeader clear multi-valued headers 
(billbarker)
  +  /fix
/changelog
  /subsection
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-03-25 Thread remm
remm2005/03/25 08:47:44

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
   webapps/docs changelog.xml
  Log:
  - 34161: StdContext.stop should do the same thing as ContainerBase.stop (ie, 
not throw an exception if it was not started).
  
  Revision  ChangesPath
  1.172 +6 -7  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.171
  retrieving revision 1.172
  diff -u -r1.171 -r1.172
  --- StandardContext.java  25 Mar 2005 03:56:55 -  1.171
  +++ StandardContext.java  25 Mar 2005 16:47:44 -  1.172
  @@ -4221,12 +4221,11 @@
   public synchronized void stop() throws LifecycleException {
   
   // Validate and update our current component state
  -if (!started)
  -throw new LifecycleException
  -(sm.getString(containerBase.notStarted, logName()));
  -
  -if (log.isDebugEnabled())
  -log.debug(Stopping);
  +if (!started) {
  +if(log.isInfoEnabled())
  +log.info(sm.getString(containerBase.notStarted, 
logName()));
  +return;
  +}
   
   // Notify our interested LifecycleListeners
   lifecycle.fireLifecycleEvent(BEFORE_STOP_EVENT, null);
  
  
  
  1.270 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.269
  retrieving revision 1.270
  diff -u -r1.269 -r1.270
  --- changelog.xml 25 Mar 2005 16:43:09 -  1.269
  +++ changelog.xml 25 Mar 2005 16:47:44 -  1.270
  @@ -134,6 +134,9 @@
 update
 Fix some RealmBase/JNDIRealm log.isXXXEnabled (pero)
 /update
  +  fix
  +  bug34161/bug: Harmonize StandardContext.stop with 
ContainerBase.stop (remm)
  +  /fix
   /changelog
  /subsection
  
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34161] - Can't stop tomcat if an application doesn't run

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34161.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34161


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 17:48 ---
This is now fixed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Reminder: 5.5.9 tomorrow

2005-03-25 Thread Jan Luehe


Yoav Shapira wrote:
 Hi,
 
 This is just a reminder that I plan to cut and tag Tomcat version 5.5.9
 tomorrow, Saturday March 26th, at 1400h my time, which is 1900h UTC/GMT.
 
  
 
 Jan, as Remy and you discussed yesterday on the mailing list, please revert
 your commit that throws the IllegalStateException in HttpSession#getId.

Done! Will revisit for 5.5.10.

Thanks,

Jan


  
 
 Thanks, and have a good weekend everyone,
 
  
 
 Yoav Shapira
 
 System Design and Management Fellow
 
 MIT Sloan School of Management / School of Engineering
 
 Cambridge, MA USA
 
  mailto:[EMAIL PROTECTED] [EMAIL PROTECTED] /
 mailto:[EMAIL PROTECTED] [EMAIL PROTECTED]
 
  
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session StandardSession.java

2005-03-25 Thread Remy Maucherat
[EMAIL PROTECTED] wrote:
luehe   2005/03/25 08:49:28
  Modified:catalina/src/share/org/apache/catalina/session
StandardSession.java
  Log:
  Commented out session validity check in StandardSession.getId().
  Will revisit for 5.5.10.
There will be two options for the internal components, I think:
1) use a new getIdInternal method
2) call isValild before doing the stuff (this might be better)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: [VOTE] PMC Chair

2005-03-25 Thread Costin Manolache
Jim Jagielski wrote:
I would recommend that before anyone responds, we decide who should
rec' and tally the votes. Also, votes should only be counted
from those who will be on the new PMC.
So before the vote:
   1. Finalize list of PMC members
  (all current committers)
   2. Determine who to collect and tally votes
  (I propose Henri Yandell)

Let's not make this too long or complicated.
Some votes are already out of the box, and I think we agree that
any committer who wants to be in the PMC can get there by simply asking 
for it.

So if Henri can send back a count ( or just the winner ) of all private 
votes he receives, as well as the list of people who voted - we can 
check against avail and update the PMC member list as well. ( a vote by 
a committer is an indication that he wants to vote so he wants to be in 
the pmc :-).

Costin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Windows service shutdown not invoking destroy()?

2005-03-25 Thread Daniel Rabe
I'm running Tomcat 5.0.28 on Windows XP Pro as a Windows service. If I use 
shutdown.bat to stop Tomcat, then the destroy() method of my servlet is 
invoked. If I simply stop the Windows service, destroy() apparently is NOT 
called. The behavior is not consistent; I've seen it work on one machine, but 
not on another. I uninstalled and re-installed on the machine where it wasn't 
working, and it didn't make a difference (still doesn't work).

Has anyone else run into this? Any ideas on what might cause the problem?

Thanks,
--Dan



DO NOT REPLY [Bug 33774] - JNDIRealm fails when server disconnects after time

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33774.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33774





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 18:00 ---
We have a CVS browser, so how about verifying in the code that I did the right
thing ?

I did not test it, I simply removed the portions of code which looked highly
suspicious.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Reminder: 5.5.9 tomorrow

2005-03-25 Thread Yoav Shapira
Hi,

 Jan, as Remy and you discussed yesterday on the mailing list, please
revert
 your commit that throws the IllegalStateException in HttpSession#getId.

Done! Will revisit for 5.5.10.

Thanks!

Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] PMC Chair

2005-03-25 Thread Henri Yandell
On Fri, 25 Mar 2005 09:19:07 -0800, Costin Manolache
[EMAIL PROTECTED] wrote:
 Jim Jagielski wrote:
  I would recommend that before anyone responds, we decide who should
  rec' and tally the votes. Also, votes should only be counted
  from those who will be on the new PMC.
 
  So before the vote:
 
 1. Finalize list of PMC members
(all current committers)
 2. Determine who to collect and tally votes
(I propose Henri Yandell)
 
 
 
 Let's not make this too long or complicated.
 
 Some votes are already out of the box, and I think we agree that
 any committer who wants to be in the PMC can get there by simply asking
 for it.
 
 So if Henri can send back a count ( or just the winner ) of all private
 votes he receives, as well as the list of people who voted - we can
 check against avail and update the PMC member list as well. ( a vote by
 a committer is an indication that he wants to vote so he wants to be in
 the pmc :-).

Yup. I can do this. Go for it.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34183] New: - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34183.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183

   Summary: org.apache.jasper.runtime.JspFactoryImpl pooling should
be configurable
   Product: Tomcat 5
   Version: 5.0.28
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P3
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


o.a.j.r.JspFactoryImpl has USE_POOL static member initialized to true. It should
be configurable similar to how tag pooling can be turned on/off.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core StandardContext.java

2005-03-25 Thread luehe
luehe   2005/03/25 10:12:48

  Modified:catalina/src/share/org/apache/catalina/core
StandardContext.java
  Log:
  Minor adjustment to fix for 32866:
  Issue log message about propagating value of distributable to
  manager only if there is a manager in place
  
  Revision  ChangesPath
  1.173 +5 -4  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
  
  Index: StandardContext.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
  retrieving revision 1.172
  retrieving revision 1.173
  diff -u -r1.172 -r1.173
  --- StandardContext.java  25 Mar 2005 16:47:44 -  1.172
  +++ StandardContext.java  25 Mar 2005 18:12:48 -  1.173
  @@ -1200,10 +1200,11 @@
  new Boolean(this.distributable));
   
   // Bugzilla 32866
  -if(log.isDebugEnabled()) {
  -log.debug(Propagating distributable= + distributable +  to 
manager);
  -}
   if(getManager() != null) {
  +if(log.isDebugEnabled()) {
  +log.debug(Propagating distributable= + distributable
  +  +  to manager);
  +}
   getManager().setDistributable(distributable);
   }
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34183] - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34183.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 19:14 ---
I disagree with this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34183] - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34183.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 20:27 ---
This can be useful for trouble shooting purposes, avoiding memory leaks due to
bugs, etc., Also Sun recommends against implementing object pools. It is all
about choice. If some one wants to use pooling they can use it, if others do not
want it, they should be able to turn it off.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Behaviour of mod_jk AJP 1.3 load balanced workers

2005-03-25 Thread Mladen Turk
Yes, that makes sense, since it's not Tomcat nor transport
error. I'll fix that ASAP.
This is actually a bug since the return value should be
OK with proper HTTP status code (in this case BAD_REQUEST).
Regards,
Mladen.
Mathias Herberts wrote:
Hi,
we are using Tomcat as our application server with front end Apache 
servers (1.3.33) running mod_jk from Jakarta Tomcat Connectors 1.2.8.

We have load balancing workers which load balance ajp13 workers.
Some of the applications we are hosting make heavy use of  HTML Forms 
using GET as the submission method. From time to time, a form text input 
field will be big (above 8kb) making the AJP 1.3 packet too big and thus 
leading to an error in jk_msg_buff.c:jk_b_append_string called from 
jk_msh_buff.c:ajp_marshal_into_msgb. The error is clearly due to the 
size of the query string. The behavior of ajp_marshal_into_msgb is to 
qualify the error as unrecoverable (is_recoverable_error is set to 
JK_FALSE) and ajp_service will return JK_FALSE thus leading to the given 
worker being unavailable for recovery_time seconds (at least 60 seconds 
per default).

The error encountered is not due to a failure in Tomcat but to a bad 
request. If I agree that is_recoverable_error should indeed be set to 
JK_FALSE so no other worker is tried for this request, I think it is 
wrong to consider the worker as having failed. The impact of such a 
request should be limited to the request itself and not fail the whole 
worker, otherwise we have a wonderful DOS opportunity.

What do others think of this beahviour?
Thanks,
Mathias.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: Behaviour of mod_jk AJP 1.3 load balanced workers

2005-03-25 Thread Mladen Turk
Mathias Herberts wrote:
Hi,
Some of the applications we are hosting make heavy use of HTML Forms 
using GET as the submission method. From time to time, a form text input 
field will be big (above 8kb) making the AJP 1.3 packet too big and thus 

Now that I think more of that, you can use the Apache's
'LimitRequestLine' directive (default 8190), so this won't get to
the mod_jk at first.
But it still stands that the worker should not be marked as in
error state in that scenario.
Regards,
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 34183] - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34183.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183





--- Additional Comments From [EMAIL PROTECTED]  2005-03-25 22:30 ---
If Sun recommended to jump off a cliff, would you ? Remember those are the same
guys who told you to use Swing in JDK 1.2 to build all your desktop apps.

Let's say that since you're the first one who has a need for this (like you
were the first one to use close inside your tags), then the feature is not
actually needed, and would be bloat. If you really want it, it can be compiled
easily.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp DataSender.java

2005-03-25 Thread pero
pero2005/03/25 14:06:10

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
DataSender.java
  Log:
   Add doProcessingStats to synchronous, asynchronous and fastqueueasync sender 
modes
   to get min, avg, max processing times as IDataSender JMX MBeans
  
  Revision  ChangesPath
  1.4   +84 -2 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java
  
  Index: DataSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- DataSender.java   14 Mar 2005 21:24:30 -  1.3
  +++ DataSender.java   25 Mar 2005 22:06:10 -  1.4
  @@ -74,6 +74,26 @@
   protected long dataResendCounter = 0;
   
   /**
  + * doProcessingStats
  + */
  +protected boolean doProcessingStats = false;
  +
  +/**
  + * proessingTime
  + */
  +protected long processingTime = 0;
  +
  +/**
  + * min proessingTime
  + */
  +protected long minProcessingTime = Long.MAX_VALUE ;
  +
  +/**
  + * max proessingTime
  + */
  +protected long maxProcessingTime = 0;
  +   
  +/**
* keep socket open for no more than one min
*/
   private long keepAliveTimeout = 60 * 1000;
  @@ -137,6 +157,47 @@
   }
   
   /**
  + * @return Returns the avg processingTime/nrOfRequests.
  + */
  +public long getAvgProcessingTime() {
  +return processingTime / nrOfRequests;
  +}
  + 
  +/**
  + * @return Returns the maxProcessingTime.
  + */
  +public long getMaxProcessingTime() {
  +return maxProcessingTime;
  +}
  +
  +/**
  + * @return Returns the minProcessingTime.
  + */
  +public long getMinProcessingTime() {
  +return minProcessingTime;
  +}
  +
  +/**
  + * @return Returns the processingTime.
  + */
  +public long getProcessingTime() {
  +return processingTime;
  +}
  +
  +/**
  + * @return Returns the doProcessingStats.
  + */
  +public boolean isDoProcessingStats() {
  +return doProcessingStats;
  +}
  +/**
  + * @param doProcessingStats The doProcessingStats to set.
  + */
  +public void setDoProcessingStats(boolean doProcessingStats) {
  +this.doProcessingStats = doProcessingStats;
  +}
  + 
  +/**
* @return Returns the connectCounter.
*/
   public long getConnectCounter() {
  @@ -329,6 +390,9 @@
   dataResendCounter = 0;
   socketOpenCounter =isConnected() ? 1 : 0;
   socketCloseCounter = 0;
  +processingTime = 0 ;
  +minProcessingTime = Long.MAX_VALUE ;
  +maxProcessingTime = 0 ;
   }
   
   /**
  @@ -392,10 +456,21 @@
   log.debug(sm.getString(IDataSender.stats, new Object[] {
   getAddress().getHostAddress(), new Integer(getPort()),
   new Long(totalBytes), new Long(nrOfRequests),
  -new Long(totalBytes / nrOfRequests) }));
  +new Long(totalBytes / nrOfRequests),
  +new Long(getProcessingTime()),
  +new Long(getAvgProcessingTime())}));
   }
   }
   
  +protected void addProcessingStats(long startTime) {
  +long time = System.currentTimeMillis() - startTime ;
  +if(time  minProcessingTime)
  +minProcessingTime = time ;
  +if( time  maxProcessingTime)
  +maxProcessingTime = time ;
  +processingTime += time ;
  +}
  +
   /**
* push messages with only one socket at a time
* 
  @@ -407,6 +482,10 @@
*/
   protected synchronized void pushMessage(String messageid, byte[] data)
   throws java.io.IOException {
  +long time = 0 ;
  +if(doProcessingStats) {
  +time = System.currentTimeMillis();
  +}
   checkIfCloseSocket();
   if (!isConnected())
   openSocket();
  @@ -430,6 +509,9 @@
   }
   this.keepAliveCount++;
   checkIfCloseSocket();
  +if(doProcessingStats) {
  +addProcessingStats(time);
  +}
   addStats(data.length);
   if (log.isTraceEnabled())
   log.trace(sm.getString(IDataSender.send.message, 
address.getHostAddress(),
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp mbeans-descriptors.xml

2005-03-25 Thread pero
pero2005/03/25 14:06:30

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
mbeans-descriptors.xml
  Log:
   Add doProcessingStats to synchronous, asynchronous and fastqueueasync sender 
modes
   to get min, avg, max processing times as IDataSender JMX MBeans
  
  Revision  ChangesPath
  1.5   +66 -2 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/mbeans-descriptors.xml
  
  Index: mbeans-descriptors.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/mbeans-descriptors.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- mbeans-descriptors.xml14 Mar 2005 21:24:30 -  1.4
  +++ mbeans-descriptors.xml25 Mar 2005 22:06:30 -  1.5
  @@ -95,6 +95,10 @@
 description=number of wrong transfers
type=long
writeable=false/
  + attribute name=senderObjectNames
  +   description=get all sender object names
  +   type=[Ljavax.management.ObjectName;
  +   writeable=false/
   operation   name=start
  description=Start the cluster
  impact=ACTION
  @@ -136,7 +140,7 @@
 description=Wait for ack after data send
 is=true
type=boolean
  - writeable=false /
  + writeable=false/
   attribute   name=ackTimeout
 description=acknowledge timeout
type=long/
  @@ -175,6 +179,26 @@
 description=number of bytes transfered
type=long
writeable=false/
  +attribute   name=processingTime
  +  description=sending processing time
  + type=long
  + writeable=false/
  +attribute   name=minProcessingTime
  +  description=minimal sending processing time
  + type=long
  + writeable=false/
  +attribute   name=avgProcessingTime
  +  description=processing time / nrOfRequests
  + type=long
  + writeable=false/
  +attribute   name=maxProcessingTime
  +  description=maximal sending processing time
  + type=long
  + writeable=false/
  +attribute   name=doProcessingStats
  +  description=create Processing time stats
  +  is=true
  + type=boolean /
   attribute   name=connectCounter
 description=counts connects
type=long
  @@ -254,7 +278,7 @@
 description=Wait for ack after data send
 is=true
type=boolean
  - writeable=false /
  + writeable=false/
   attribute   name=ackTimeout
 description=acknowledge timeout
type=long/
  @@ -314,6 +338,26 @@
 description=number of bytes transfered
type=long
writeable=false/
  +attribute   name=processingTime
  +  description=sending processing time
  + type=long
  + writeable=false/
  +attribute   name=minProcessingTime
  +  description=minimal sending processing time
  + type=long
  + writeable=false/
  +attribute   name=avgProcessingTime
  +  description=processing time / nrOfRequests
  + type=long
  + writeable=false/
  +attribute   name=maxProcessingTime
  +  description=maximal sending processing time
  + type=long
  + writeable=false/
  +attribute   name=doProcessingStats
  +  description=create Processing time stats
  +  is=true
  + type=boolean / 
   attribute   name=connectCounter
 description=counts connects
type=long
  @@ -503,6 +547,26 @@
 description=number of bytes transfered
type=long
writeable=false/
  +attribute   name=processingTime
  +  description=sending processing time
  + type=long
  + writeable=false/
  +attribute   name=minProcessingTime
  +  description=minimal sending processing time
  + type=long
  + writeable=false/
  +attribute   name=avgProcessingTime
  +  description=processing time / nrOfRequests
  + type=long
  + writeable=false/
  +attribute   name=maxProcessingTime
  +  description=maximal sending processing time
  + type=long
  + writeable=false/
  +attribute   

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp FastAsyncSocketSender.java

2005-03-25 Thread pero
pero2005/03/25 14:07:20

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
FastAsyncSocketSender.java
  Log:
  Correct i18n key
  
  Revision  ChangesPath
  1.2   +2 -2  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java
  
  Index: FastAsyncSocketSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- FastAsyncSocketSender.java15 Mar 2005 11:26:58 -  1.1
  +++ FastAsyncSocketSender.java25 Mar 2005 22:07:20 -  1.2
  @@ -392,7 +392,7 @@
   entry = entry.next();
   } while (entry != null);
   } else {
  -
log.error(sm.getString(syncSocketSender.queue.empty,sender.getAddress(), new 
Integer(sender.getPort(;
  +
log.error(sm.getString(AsyncSocketSender.queue.empty,sender.getAddress(), new 
Integer(sender.getPort(;
   }
   }
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp Jdk13ReplicationListener.java

2005-03-25 Thread pero
pero2005/03/25 14:08:59

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
Jdk13ReplicationListener.java
  Log:
  Change attribute name waitForAck to sendAck
  Add compress/uncompress message data transfer
  
  Revision  ChangesPath
  1.5   +47 -10
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/Jdk13ReplicationListener.java
  
  Index: Jdk13ReplicationListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/Jdk13ReplicationListener.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- Jdk13ReplicationListener.java 13 Jul 2004 09:43:58 -  1.4
  +++ Jdk13ReplicationListener.java 25 Mar 2005 22:08:59 -  1.5
  @@ -22,10 +22,14 @@
   import java.net.Socket;
   import java.net.ServerSocket;
   import java.net.InetSocketAddress;
  +import java.nio.channels.Selector;
  +
   import org.apache.catalina.cluster.io.ListenCallback;
   import org.apache.catalina.cluster.io.Jdk13ObjectReader;
   
   /**
  + * @author Filip Hanik
  + * @version $Revision$, $Date$
*/
   public class Jdk13ReplicationListener implements Runnable
   {
  @@ -38,23 +42,52 @@
   private java.net.InetAddress bind;
   private int port;
   private long timeout = 0;
  -private boolean synchronous = false;
   ServerSocket serverSocket = null;
  +
  +/**
  + * sendAck
  + */
  +private boolean sendAck = true ;
  +/**
  + * Compress message data bytes
  + */
  +private boolean compress = true ;
  +
   
   public Jdk13ReplicationListener(ListenCallback callback,
  int poolSize,
  java.net.InetAddress bind,
  int port,
  long timeout,
  -   boolean synchronous)
  +   boolean sendAck)
   {
  -this.synchronous=synchronous;
  +this.sendAck=sendAck;
   this.callback = callback;
   this.bind = bind;
   this.port = port;
   this.timeout = timeout;
   }
   
  +/**
  + * @return Returns the compress.
  + */
  +public boolean isCompress() {
  +return compress;
  +}
  +
  +/**
  + * @param compress The compress to set.
  + */
  +public void setCompress(boolean compress) {
  +this.compress = compress;
  +}
  +public boolean isSendAck() {
  +return sendAck;
  +}
  +public void setSendAck(boolean sendAck) {
  +this.sendAck = sendAck;
  +}
  +
   public void run()
   {
   try
  @@ -76,7 +109,7 @@
   serverSocket.bind (new InetSocketAddress (bind,port));
   while (doListen) {
   Socket socket = serverSocket.accept();
  -ClusterListenThread t = new ClusterListenThread(socket,new 
Jdk13ObjectReader(socket,callback));
  +ClusterListenThread t = new ClusterListenThread(socket,new 
Jdk13ObjectReader(socket,callback,compress),sendAck);
   t.setDaemon(true);
   t.start();
   }//while
  @@ -96,10 +129,12 @@
   private Socket socket;
   private Jdk13ObjectReader reader;
   private boolean keepRunning = true;
  -private static byte[] ackMsg = new byte[] {6,2,3};
  -ClusterListenThread(Socket socket, Jdk13ObjectReader reader) {
  +private boolean sendAck ;
  +private static byte[] ACK_COMMAND = new byte[] {6,2,3};
  +ClusterListenThread(Socket socket, Jdk13ObjectReader reader, boolean 
sendAck) {
   this.socket = socket;
   this.reader = reader;
  +this.sendAck = sendAck ;
   }
   
   public void run() {
  @@ -112,9 +147,11 @@
   if ( cnt  0 ) {
   ack = reader.append(buffer, 0, cnt);
   }
  -while ( ack  0 ) {
  -sendAck();
  -ack--;
  +if(sendAck) {
  +while ( ack  0 ) {
  +sendAck();
  +ack--;
  +}
   }
   }
   } catch ( Exception x ) {
  @@ -126,7 +163,7 @@
   
   private void sendAck() throws java.io.IOException {
   //send a reply-acknowledgement
  -socket.getOutputStream().write(ackMsg);
  +socket.getOutputStream().write(ACK_COMMAND);
   }
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp ReplicationListener.java

2005-03-25 Thread pero
pero2005/03/25 14:10:25

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
ReplicationListener.java
  Log:
  Change attribute name waitForAck to sendAck
  Add compress/uncompress message data transfer
  Update some documentation
  
  Revision  ChangesPath
  1.20  +74 -24
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java
  
  Index: ReplicationListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- ReplicationListener.java  15 Feb 2005 09:31:45 -  1.19
  +++ ReplicationListener.java  25 Mar 2005 22:10:25 -  1.20
  @@ -17,26 +17,44 @@
   package org.apache.catalina.cluster.tcp;
   
   
  +import java.net.InetSocketAddress;
  +import java.net.ServerSocket;
  +import java.nio.channels.SelectableChannel;
  +import java.nio.channels.SelectionKey;
  +import java.nio.channels.Selector;
   import java.nio.channels.ServerSocketChannel;
   import java.nio.channels.SocketChannel;
  -import java.nio.channels.Selector;
  -import java.nio.channels.SelectionKey;
  -import java.nio.channels.SelectableChannel;
  -
  -import java.net.ServerSocket;
  -import java.net.InetSocketAddress;
   import java.util.Iterator;
  -import org.apache.catalina.cluster.io.ListenCallback;
  -import org.apache.catalina.cluster.io.ObjectReader;
  +
   import org.apache.catalina.cluster.CatalinaCluster;
   import org.apache.catalina.cluster.ClusterReceiver;
  +import org.apache.catalina.cluster.tcp.Constants;
  +import org.apache.catalina.cluster.io.ListenCallback;
  +import org.apache.catalina.cluster.io.ObjectReader;
  +import org.apache.catalina.util.StringManager;
   /**
  - */
  +* FIXME i18n log messages
  +* FIXME jmx support
  +* @author Peter Rossbach
  +* @author Filip Hanik
  +* @version $Revision$ $Date$
  +*/
   public class ReplicationListener implements Runnable,ClusterReceiver
   {
  -
   private static org.apache.commons.logging.Log log =
   org.apache.commons.logging.LogFactory.getLog( 
ReplicationListener.class );
  +
  +/**
  + * The descriptive information about this implementation.
  + */
  +private static final String info = ReplicationListener/1.1;
  +
  +/**
  + * The string manager for this package.
  + */
  +protected StringManager sm = StringManager.getManager(Constants.Package);
  +
  +
   private ThreadPool pool = null;
   private boolean doListen = false;
   private ListenCallback callback;
  @@ -45,7 +63,12 @@
   private int tcpThreadCount;
   private long tcpSelectorTimeout;
   private int tcpListenPort;
  -private boolean waitForAck;
  +private boolean sendAck;
  +/**
  + * Compress message data bytes
  + */
  +private boolean compress = true ;
  +
   private Selector selector = null;
   
   private Object interestOpsMutex = new Object();
  @@ -53,6 +76,24 @@
   public ReplicationListener() {
   }
   
  +/**
  + * @return Returns the compress.
  + */
  +public boolean isCompress() {
  +return compress;
  +}
  +
  +/**
  + * @param compress The compress to set.
  + */
  +public void setCompress(boolean compressMessageData) {
  +this.compress = compressMessageData;
  +}
  +
  +/**
  + * start cluster receiver
  + * @see org.apache.catalina.cluster.ClusterReceiver#start()
  + */
   public void start() {
   try {
   pool = new ThreadPool(tcpThreadCount, 
TcpReplicationThread.class, interestOpsMutex);
  @@ -89,6 +130,11 @@
   }
   }
   
  +/**
  + * get data from channel and store in byte array
  + * send it to cluster
  + * @throws Exception
  + */
   public void listen ()
   throws Exception
   {
  @@ -134,11 +180,12 @@
   ServerSocketChannel server =
   (ServerSocketChannel) key.channel();
   SocketChannel channel = server.accept();
  +Object attach  = attach = new ObjectReader(channel, 
selector,
  +callback,isCompress()) ;
   registerChannel(selector,
   channel,
   SelectionKey.OP_READ,
  -new ObjectReader(channel, selector,
  -callback));
  +attach);
   }
   // is there data to read on this channel?
   if (key.isReadable()) {
  @@ -159,7 +206,7 @@
   

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp SimpleTcpCluster.java

2005-03-25 Thread pero
pero2005/03/25 14:11:40

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
SimpleTcpCluster.java
  Log:
  Add a lot Fixme for next 5.5.10 release :-)
  
  Revision  ChangesPath
  1.59  +65 -22
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java
  
  Index: SimpleTcpCluster.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java,v
  retrieving revision 1.58
  retrieving revision 1.59
  diff -u -r1.58 -r1.59
  --- SimpleTcpCluster.java 15 Feb 2005 09:31:45 -  1.58
  +++ SimpleTcpCluster.java 25 Mar 2005 22:11:39 -  1.59
  @@ -58,8 +58,17 @@
* setting up a cluster and provides callers with a valid multicast
* receiver/sender.
* 
  + * FIXME remove install/remove/start/stop context dummys
  + * FIXME better stats
  + * FIXME factor out receiver handling
  + * FIXME Support JMX and Lifecycle Listener Notification (start/stop member) 
(start/stop context/manager)
  + * FIXME optimize message package creation
  + * FIXME better compress message handling
  + * FIXME Clearer implementation from notifyListenersOnReplication flag
  + *
* @author Filip Hanik
* @author Remy Maucherat
  + * @author Peter Rossbach
* @version $Revision$, $Date$
*/
   
  @@ -297,10 +306,18 @@
   return manager;
   }
   
  +/* remove an application form cluster replication bus
  + * FIXME notify someone (JMX(Listener)
  + * @see 
org.apache.catalina.cluster.CatalinaCluster#removeManager(java.lang.String)
  + */
   public void removeManager(String name) {
   managers.remove(name);
   }
   
  +/* add an application to cluster replication bus
  + * FIXME notify someone (JMX(Listener)
  + * @see 
org.apache.catalina.cluster.CatalinaCluster#addManager(java.lang.String, 
org.apache.catalina.cluster.ClusterManager)
  + */
   public void addManager(String name, ClusterManager manager) {
   manager.setName(name);
   manager.setCluster(this);
  @@ -366,6 +383,7 @@
* other nodes in the cluster, and request the current session state to 
be
* transferred to this node.
* 
  + * FIXME notify someone (JMX(Listener)   
* @exception IllegalStateException
*if this component has already been started
* @exception LifecycleException
  @@ -389,7 +407,7 @@
   
   }
   registerMBeans();
  -clusterReceiver.setWaitForAck(clusterSender.isWaitForAck());
  +clusterReceiver.setSendAck(clusterSender.isWaitForAck());
   clusterReceiver.setCatalinaCluster(this);
   clusterReceiver.start();
   clusterSender.setCatalinaCluster(this);
  @@ -435,20 +453,15 @@
(smsg.getEventType() == 
SessionMessage.EVT_GET_ALL_SESSIONS)
(membershipService.getMembers().length  0)) {
   destination = membershipService.getMembers()[0];
  -}//end if
  -}//end if
  -msg.setTimestamp(System.currentTimeMillis());
  -java.io.ByteArrayOutputStream outs = new 
java.io.ByteArrayOutputStream();
  -java.io.ObjectOutputStream out = new java.io.ObjectOutputStream(
  -outs);
  -out.writeObject(msg);
  -byte[] data = outs.toByteArray();
  +}
  +}
  +byte[] data = createMessageData(msg);
   if (destination != null) {
   Member tcpdest = dest;
   if ((tcpdest != null)

(!membershipService.getLocalMember().equals(tcpdest))) {
   clusterSender.sendMessage(msg.getUniqueId(), data, 
tcpdest);
  -}//end if
  +}
   } else {
   clusterSender.sendMessage(msg.getUniqueId(), data);
   }
  @@ -458,6 +471,22 @@
   }
   
   /**
  + * Send Message create Timestamp and generate message bytes form msg
  + * @param msg cluster message
  + * @return cluster message as byte array
  + * @throws IOException
  + */
  +protected byte[] createMessageData(ClusterMessage msg) throws 
IOException {
  +msg.setTimestamp(System.currentTimeMillis());
  +java.io.ByteArrayOutputStream outs = new 
java.io.ByteArrayOutputStream();
  +java.io.ObjectOutputStream out = new java.io.ObjectOutputStream(
  +outs);
  +out.writeObject(msg);
  +byte[] data = outs.toByteArray();
  +return data;
  +}
  +
  +/**
* send message to all cluster members
* 
* @see 

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp ReplicationTransmitter.java

2005-03-25 Thread pero
pero2005/03/25 14:12:32

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
ReplicationTransmitter.java
  Log:
  Refactor Code
  Add compress transfer handling
  Add api docs
  
  Revision  ChangesPath
  1.22  +444 -250  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
  
  Index: ReplicationTransmitter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- ReplicationTransmitter.java   15 Feb 2005 09:32:39 -  1.21
  +++ ReplicationTransmitter.java   25 Mar 2005 22:12:31 -  1.22
  @@ -16,6 +16,7 @@
   
   package org.apache.catalina.cluster.tcp;
   
  +import java.io.IOException;
   import java.util.HashMap;
   import java.util.Iterator;
   import java.util.Map;
  @@ -24,18 +25,22 @@
   import javax.management.ObjectName;
   
   import org.apache.catalina.cluster.ClusterSender;
  -import org.apache.catalina.cluster.Constants;
   import org.apache.catalina.cluster.Member;
   import org.apache.catalina.cluster.io.XByteBuffer;
   import org.apache.catalina.util.StringManager;
   import org.apache.tomcat.util.IntrospectionUtils;
   
  -
   /**
  + * Transmit message to ohter cluster members create sender from 
replicationMode
  + * type 
  + * FIXME i18n log messages
  + * FIXME compress data depends on message type and size 
  + * FIXME send very big messages at some block see FarmWarDeployer!
  + * TODO pause and resume senders
  + * 
* @author Peter Rossbach
* @author Filip Hanik
  - * @version 1.2
  - * 
  + * @version $Revision$ $Date$
*/
   public class ReplicationTransmitter implements ClusterSender {
   private static org.apache.commons.logging.Log log = 
org.apache.commons.logging.LogFactory
  @@ -44,37 +49,69 @@
   /**
* The descriptive information about this implementation.
*/
  -private static final String info = ReplicationTransmitter/1.2;
  +private static final String info = ReplicationTransmitter/1.3;
   
   /**
* The string manager for this package.
*/
   protected StringManager sm = StringManager.getManager(Constants.Package);
   
  -private java.util.HashMap map = new java.util.HashMap();
  +private Map map = new HashMap();
   
   public ReplicationTransmitter() {
   }
   
  +/**
  + * number of transmitted messages
  + */
   private long nrOfRequests = 0;
   
  +/**
  + * number of transmitted bytes
  + */
   private long totalBytes = 0;
   
  +private long failureCounter = 0;
  +
  +/**
  + * current sender replication mode
  + */
   private String replicationMode;
   
  +/**
  + * sender default ackTimeout
  + */
   private long ackTimeout = 15000; //15 seconds by default
   
  -private boolean waitForAck = true ;
  -
  -private SimpleTcpCluster cluster;
  +/**
  + * enabled wait for ack
  + */
  +private boolean waitForAck = true;
   
  -private ObjectName objectName;
  +/**
  + * autoConnect sender when next message send
  + */
  +private boolean autoConnect = true;
   
  -private boolean autoConnect = true ;
  +/**
  + * Compress message data bytes
  + */
  +private boolean compress = true;
   
  +/**
  + * dynamic sender codeproperties/code
  + */
   private Map properties = new HashMap();
   
  -private long failureCounter = 0 ;
  +/**
  + * my cluster
  + */
  +private SimpleTcpCluster cluster;
  +
  +/**
  + * Transmitter Mbean name
  + */
  +private ObjectName objectName;
   
   // - 
Properties
   
  @@ -89,27 +126,6 @@
   
   }
   
  -private synchronized void addStats(int length) {
  -nrOfRequests++;
  -totalBytes += length;
  -if (log.isDebugEnabled() 
  -   (nrOfRequests % 100) == 0) {
  -log.debug(Nr of bytes sent= + totalBytes +  over 
  -+ nrOfRequests +  == + (totalBytes / nrOfRequests)
  -+  bytes/request);
  -}
  -
  -}
  -
  -/*
  - * Reset sender statistics
  - */
  -public synchronized void resetStatistics() {
  -nrOfRequests = 0;
  -totalBytes = 0;
  -failureCounter = 0;
  -}
  -
   /**
* @return Returns the nrOfRequests.
*/
  @@ -124,6 +140,28 @@
   return totalBytes;
   }
   
  +/**
  + * @return Returns the failureCounter.
  + */
  +public long getFailureCounter() {
  +return failureCounter;
  +}
  +
  +/**
  + * current 

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp TcpReplicationThread.java

2005-03-25 Thread pero
pero2005/03/25 14:18:38

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
TcpReplicationThread.java
  Log:
  use constant ACK byte array instead create new 3 byte buffer for every 
message ack
  better waitAck Handling
  
  Revision  ChangesPath
  1.14  +30 -22
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java
  
  Index: TcpReplicationThread.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- TcpReplicationThread.java 15 Feb 2005 09:31:45 -  1.13
  +++ TcpReplicationThread.java 25 Mar 2005 22:18:38 -  1.14
  @@ -15,26 +15,28 @@
*/
   
   package org.apache.catalina.cluster.tcp;
  +import java.io.IOException;
   import java.nio.ByteBuffer;
   import java.nio.channels.SelectionKey;
  -import java.io.IOException;
   import java.nio.channels.SocketChannel;
  +
   import org.apache.catalina.cluster.io.ObjectReader;
   
   /**
  - * A worker thread class which can drain channels and echo-back
  - * the input.  Each instance is constructed with a reference to
  - * the owning thread pool object. When started, the thread loops
  - * forever waiting to be awakened to service the channel associated
  - * with a SelectionKey object.
  - * The worker is tasked by calling its serviceChannel() method
  - * with a SelectionKey object.  The serviceChannel() method stores
  - * the key reference in the thread object then calls notify()
  - * to wake it up.  When the channel has been drained, the worker
  - * thread returns itself to its parent pool.
  - */
  -public class TcpReplicationThread extends WorkerThread
  -{
  + * A worker thread class which can drain channels and echo-back the input. 
Each
  + * instance is constructed with a reference to the owning thread pool object.
  + * When started, the thread loops forever waiting to be awakened to service 
the
  + * channel associated with a SelectionKey object. The worker is tasked by
  + * calling its serviceChannel() method with a SelectionKey object. The
  + * serviceChannel() method stores the key reference in the thread object then
  + * calls notify() to wake it up. When the channel has been drained, the 
worker
  + * thread returns itself to its parent pool.
  + * 
  + * @author Filip Hanik
  + * @version $Revision$, $Date$
  + */
  +public class TcpReplicationThread extends WorkerThread {
  +private static final byte[] ACK_COMMAND = new byte[] {6, 2, 3};
   private static org.apache.commons.logging.Log log =
   org.apache.commons.logging.LogFactory.getLog( 
TcpReplicationThread.class );
   private ByteBuffer buffer = ByteBuffer.allocate (1024);
  @@ -53,7 +55,8 @@
   // sleep and release object lock
   this.wait();
   } catch (InterruptedException e) {
  -log.info(TCP worker thread interrupted in cluster,e);
  +if(log.isInfoEnabled())
  +log.info(TCP worker thread interrupted in cluster,e);
   // clear interrupt status
   Thread.interrupted();
   }
  @@ -119,16 +122,16 @@
   // loop while data available, channel is non-blocking
   while ((count = channel.read (buffer))  0) {
   buffer.flip();   // make buffer readable
  -int pkgcnt = reader.append(buffer.array(),0,count);
  +reader.append(buffer.array(),0,count);
   buffer.clear();  // make buffer empty
   }
   //check to see if any data is available
   int pkgcnt = reader.execute();
  -while ( pkgcnt  0 ) {
  -if (waitForAck) {
  +if (waitForAck) {
  +while ( pkgcnt  0 ) {
   sendAck(key,channel);
  -} //end if
  -pkgcnt--;
  +pkgcnt--;
  +}
   }
   
   if (count  0) {
  @@ -149,10 +152,15 @@
   
   }
   
  +/**
  + * send a reply-acknowledgement (6,2,3)
  + * @param key
  + * @param channel
  + */
   private void sendAck(SelectionKey key, SocketChannel channel) {
  -//send a reply-acknowledgement
  +
   try {
  -channel.write(ByteBuffer.wrap(new byte[] {6, 2, 3}));
  +channel.write(ByteBuffer.wrap(ACK_COMMAND));
   } catch ( java.io.IOException x ) {
   log.warn(Unable to send ACK back through channel, channel 
disconnected?: +x.getMessage());
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional 

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp ThreadPool.java

2005-03-25 Thread pero
pero2005/03/25 14:19:34

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
ThreadPool.java
  Log:
  remove auto comment
  
  Revision  ChangesPath
  1.9   +0 -4  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ThreadPool.java
  
  Index: ThreadPool.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ThreadPool.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- ThreadPool.java   13 Jul 2004 09:43:58 -  1.8
  +++ ThreadPool.java   25 Mar 2005 22:19:34 -  1.9
  @@ -19,10 +19,6 @@
   import java.util.LinkedList;
   
   /**
  - * pTitle: /p
  - * pDescription: /p
  - * pCopyright: Copyright (c) 2002/p
  - * pCompany: /p
* @author not attributable
* @version 1.0
*/
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp LocalStrings.properties

2005-03-25 Thread pero
pero2005/03/25 14:20:26

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
LocalStrings.properties
  Log:
  add processing time stats parameter
  
  Revision  ChangesPath
  1.4   +1 -1  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/LocalStrings.properties,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- LocalStrings.properties   14 Mar 2005 21:24:30 -  1.3
  +++ LocalStrings.properties   25 Mar 2005 22:20:26 -  1.4
  @@ -10,7 +10,7 @@
   IDataSender.openSocket=Sender open socket to [{0}:{1,number,integer}]
   IDataSender.send.again=Send data again to [{0}:{1,number,integer}]
   IDataSender.send.message=Send message to [{0}:{1,number,integer}] id=[{2}] 
size={3,number,integer}
  -IDataSender.stats=Send stats from [{0}:{1,number,integer}] Nr of bytes 
sent={2,number,integer} over {3} == {4,number,integer} bytes/request
  +IDataSender.stats=Send stats from [{0}:{1,number,integer}] Nr of bytes 
sent={2,number,integer} over {3} = {4,number,integer} bytes/request, processing 
time {5,number,integer} msec, avg processing time {6,number,integer} msec
   PoolSocketSender.senderQueue.sender.failed=PoolSocketSender create new 
sender to [{0}:{1,number,integer}] failed
   PoolSocketSender.noMoreSender=No socket sender available for client 
[{0}:{1,number,integer}] did it disappear?
   ReplicationTransmitter.getProperty=get property {0}
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io Jdk13ObjectReader.java ObjectReader.java XByteBuffer.java

2005-03-25 Thread pero
pero2005/03/25 14:21:27

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/io
Jdk13ObjectReader.java ObjectReader.java
XByteBuffer.java
  Log:
  add compress handling
  add some documentation
  
  Revision  ChangesPath
  1.5   +42 -11
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io/Jdk13ObjectReader.java
  
  Index: Jdk13ObjectReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io/Jdk13ObjectReader.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- Jdk13ObjectReader.java1 Jul 2004 09:44:27 -   1.4
  +++ Jdk13ObjectReader.java25 Mar 2005 22:21:26 -  1.5
  @@ -16,6 +16,10 @@
   
   package org.apache.catalina.cluster.io;
   
  +
  +import java.net.Socket;
  +import org.apache.catalina.cluster.io.XByteBuffer;
  +
   /**
* The object reader object is an object used in conjunction with
* java.nio TCP messages. This object stores the message bytes in a
  @@ -26,24 +30,41 @@
* for message encoding and decoding.
*
* @author Filip Hanik
  + * @author Peter Rossbach
* @version $Revision$, $Date$
*/
  -
  -import java.net.Socket;
  -import org.apache.catalina.cluster.io.XByteBuffer;
   public class Jdk13ObjectReader
   {
   private Socket socket;
   private ListenCallback callback;
   private XByteBuffer buffer;
   
  +/**
  + * use this socket and callback to receive messages
  + * @param socket listener socket
  + * @param callback SimpleTcpCluster listener
  + * @param compress is send message data compress or flat.
  + */
   public Jdk13ObjectReader( Socket socket,
  -   ListenCallback callback )  {
  +   ListenCallback callback, boolean compress)  {
   this.socket = socket;
   this.callback = callback;
  -this.buffer = new XByteBuffer();
  +this.buffer = new XByteBuffer(compress);
   }
   
  +
  +/**
  + * Append new bytes to buffer. 
  + * Is message complete receiver send message to callback
  + * @see 
org.apache.catalina.cluster.tcp.SimpleTcpCluster#messageDataReceived(byte[])
  + * @see XByteBuffer#doesPackageExist()
  + * @see XByteBuffer#extractPackage(boolean)
  + * @param data new transfer buffer
  + * @param off offset
  + * @param len length in buffer
  + * @return number of messages that sended to callback
  + * @throws java.io.IOException
  + */
   public int append(byte[] data,int off,int len) throws 
java.io.IOException {
   boolean result = false;
   buffer.append(data,off,len);
  @@ -54,22 +75,32 @@
   callback.messageDataReceived(b);
   pkgCnt++;
   pkgExists = buffer.doesPackageExist();
  -}//end if
  +}
   return pkgCnt;
   }
   
  +
  +/**
  + * send message to callback
  + * @see Jdk13ObjectReader#append(byte[], int, int)
  + * @return
  + * @throws java.io.IOException
  + */
   public int execute() throws java.io.IOException {
   return append(new byte[0],0,0);
   }
   
  +/**
  + * write data to socket (ack)
  + * @see org.apache.catalina.cluster.tcp.Jdk13ReplicationListener#sendAck
  + * @param data
  + * @return
  + * @throws java.io.IOException
  + */
   public int write(byte[] data)
  throws java.io.IOException {
  socket.getOutputStream().write(data);
  return 0;
   
   }
  -
  -
  -
  -
   }
  
  
  
  1.7   +59 -23
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io/ObjectReader.java
  
  Index: ObjectReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/io/ObjectReader.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ObjectReader.java 1 Jul 2004 09:44:27 -   1.6
  +++ ObjectReader.java 25 Mar 2005 22:21:26 -  1.7
  @@ -13,9 +13,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
  -
   package org.apache.catalina.cluster.io;
   
  +import java.nio.ByteBuffer;
  +import java.nio.channels.Selector;
  +import java.nio.channels.SocketChannel;
  +
   /**
* The object reader object is an object used in conjunction with
* java.nio TCP messages. This object stores the message bytes in a
  @@ -26,59 +29,92 @@
* for message encoding and decoding.
*
* @author Filip Hanik
  + * @author Peter Rossbach
* @version $Revision$, $Date$
*/
  +public class ObjectReader {
   
  -import 

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster ClusterReceiver.java

2005-03-25 Thread pero
pero2005/03/25 14:21:55

  Modified:modules/cluster/src/share/org/apache/catalina/cluster
ClusterReceiver.java
  Log:
  add getCatalinaCluster
  add documentation
  
  Revision  ChangesPath
  1.4   +40 -5 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterReceiver.java
  
  Index: ClusterReceiver.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/ClusterReceiver.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ClusterReceiver.java  15 Feb 2005 09:31:45 -  1.3
  +++ ClusterReceiver.java  25 Mar 2005 22:21:55 -  1.4
  @@ -18,26 +18,61 @@
   
   
   /**
  - * 
  + * Cluster Receiver Interface
* @author Filip Hanik
* @author Peter Rossbach
  - * @version 1.1
  - *
  + * @version $Revision$, $Date$
*/
   public interface ClusterReceiver
   {
   
  +/**
  + * Start message listing
  + * @throws java.io.IOException
  + */
   public void start() throws java.io.IOException;
   
  +/**
  + * Stop message listing 
  + */
   public void stop();
   
  +/**
  + * set callback
  + * @see 
org.apache.catalina.cluster.tcp.SimpleTcpCluster#messageDataReceived(byte[])
  + * @param cluster
  + */
   public void setCatalinaCluster(CatalinaCluster cluster);
   
  -public boolean isWaitForAck();
  -public void setWaitForAck(boolean isWaitForAck);
  +/**
  + * get Callback
  + * @return
  + */
  +public CatalinaCluster getCatalinaCluster();
   
  +/**
  + * Send Ack to sender or not
  + * @return
  + */
  +public boolean isSendAck();
  +
  +/**
  + * set ack mode
  + * @param isSendAck
  + */
  +public void setSendAck(boolean isSendAck);
  +
  +/**
  + * get the listing ip interface
  + * @return
  + */
   public String getHost();
   
  +
  +/**
  + * get the listing ip port
  + * @return
  + */
   public int getPort();
   
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp PooledSocketSender.java

2005-03-25 Thread pero
pero2005/03/25 14:22:46

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
PooledSocketSender.java
  Log:
  Add Fixme for 5.5.10
  
  Revision  ChangesPath
  1.10  +2 -0  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/PooledSocketSender.java
  
  Index: PooledSocketSender.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/PooledSocketSender.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- PooledSocketSender.java   15 Feb 2005 09:31:45 -  1.9
  +++ PooledSocketSender.java   25 Mar 2005 22:22:46 -  1.10
  @@ -23,6 +23,8 @@
   /**
* Send cluster messages with a pool of sockets (25).
* 
  + * FIXME support processing stats
  + * 
* @author Filip Hanik
* @author Peter Rossbach
* @version 1.2
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

2005-03-25 Thread pero
pero2005/03/25 14:24:21

  Modified:webapps/docs changelog.xml
  Log:
  Update Cluster changes
  
  Revision  ChangesPath
  1.271 +37 -11jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.270
  retrieving revision 1.271
  diff -u -r1.270 -r1.271
  --- changelog.xml 25 Mar 2005 16:47:44 -  1.270
  +++ changelog.xml 25 Mar 2005 22:24:20 -  1.271
  @@ -185,17 +185,43 @@
  
  subsection name=Cluster
   changelog
  -   fix
  -  Fix JvmRouteBinderValve primary failover attribute to
  -  org.apache.catalina.cluster.session.JvmRouteOrignalSessionID (pero)
  -   /fix
  -   add
  -  Integrate new fastasyncqueue cluster sender mode.
  -  Support queue size limitation,
  -  get all queued objects and send it to the backup node,
  -  no queue thread lock contention under high replication load,
  -  submitted by Rainer Jung (pero)
  -   /add
  +  fix
  +Fix JvmRouteBinderValve primary failover attribute to
  +org.apache.catalina.cluster.session.JvmRouteOrignalSessionID (pero)
  +  /fix
  +  fix
  +Change attribute name waitForAck to sendAck at ReplicationListener 
(pero)
  +  /fix
  +  add
  +Integrate new fastasyncqueue cluster sender mode.
  +Support queue size limitation,
  +get all queued objects and send it to the backup node,
  +no queue thread lock contention under high replication load,
  +submitted by Rainer Jung (pero)
  +  /add
  +  add
  +Add compress attribute to Sender and Receiver to transfer data 
uncompressed. 
  +At high cluster load this option consume lesser cpu and memory.
  +Implement the compress handling to ReplicationTransmitter, 
ReplicationListener, 
  +XByteBuffer and Jdk13ReplicationListener (pero)
  +  /add
  +  add
  +Add doProcessingStats to synchronous, asynchronous and 
fastqueueasync sender modes
  +to get min, avg, max processing times as IDataSender JMX MBeans 
(pero)
  +  /add
  +  fix
  +TcpThreadPool use constant ACK byte array instead create 
  +new 3 byte buffer for every message ack (pero)
  +  /fix
  +  update
  +Refactor ReplicationTransmitter and ReplicationListener (pero)
  +  /update
  +  update
  +add getCatalinaCluster() to ClusterReceiver and SimpleTcpCluster 
(pero)
  +  /update
  +  update
  +Update the Api documentation (pero)
  +  /update
   /changelog
  /subsection
  subsection name=Webapps
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 34183] - org.apache.jasper.runtime.JspFactoryImpl pooling should be configurable

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34183.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34183





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 03:01 ---
I do evaluate Sun or any other vendor's guidelines/recommendations first, and if
it makes sense I follow them. In the case of Sun's recommendation against object
pooling it makes sense. We tried to implement object pooling in our apps and
found that it is not worth the trouble. Modern hotspot JVMs are so mucch better
at allocating memory and garbage collecting them compared to older JVMs. Also,
when recyling objects state should be cleared properly to avoid risk of memory
leaks/bugs. This is the same case with Jasper runtime too. 

I have said many times, that we do not call close() from the JSP tags. The tags
are  either jakarta taglibs tags or struts tags. Any one has access to the
source code. Why do you keep telling we have close() from tags? Have you ever
looked at the source code for these tags? 

I can certainly make code changes myself and get these missing functionality.
This is not good for maintanenace of our apps as we do want to keep upgrading to
newer versions of open source software we use. 

If you are not interested in making fixes/enhancements based on customer needs
that is really up to you. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33810] - Stream closed errors from JSP tags under load

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33810





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 03:20 ---
I checked tomcat-dev mailing list for cvs-commit messages by you. I did not see
it in there. Can you please tell me what classes changed exactly?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33249] - Autodeploy sometimes results in Missing application web.xml

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33249.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33249





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 03:49 ---
I believe I found what was causing this problem.  It turned out that my
servlet's code left file handles open to files within the context directory. 
There's a bug in the PC version of Java that prevents open files from being
deleted, so that prevented Tomcat from removing the old context directory when
unpacking a new version of the WAR file.  Once I closed the file handles, the
problem went away.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33249] - Autodeploy sometimes results in Missing application web.xml

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33249.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33249


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 04:04 ---
Good, thanks for reporting your findings.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml jndi-datasource-examples-howto.xml

2005-03-25 Thread yoavs
yoavs   2005/03/25 19:16:18

  Modified:webapps/docs changelog.xml
jndi-datasource-examples-howto.xml
  Log:
  Bugzilla 33755.
  
  Revision  ChangesPath
  1.272 +4 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.271
  retrieving revision 1.272
  diff -u -r1.271 -r1.272
  --- changelog.xml 25 Mar 2005 22:24:20 -  1.271
  +++ changelog.xml 26 Mar 2005 03:16:18 -  1.272
  @@ -60,6 +60,10 @@
 add
   bug33325/bug: Added top-level clean target to Netbuild build.xml 
file. (yoavs)
 /add
  +  update
  +bug33755/bug: Clarified Postgresql JNDI datasource example. 
[patch submitted by
  +  Tom Witmer] (yoavs)
  +  /update
   /changelog
  /subsection
   
  
  
  
  1.14  +84 -7 
jakarta-tomcat-catalina/webapps/docs/jndi-datasource-examples-howto.xml
  
  Index: jndi-datasource-examples-howto.xml
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/docs/jndi-datasource-examples-howto.xml,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- jndi-datasource-examples-howto.xml27 Sep 2004 16:00:31 -  
1.13
  +++ jndi-datasource-examples-howto.xml26 Mar 2005 03:16:18 -  
1.14
  @@ -30,7 +30,7 @@
   section name=Introduction
   
   pJNDI Datasource configuration is covered extensively in the
  -JNDI-Resources-HOWTO however, feedback from codetomcat-user/code has
  +JNDI-Resources-HOWTO.  However, feedback from codetomcat-user/code has
   shown that specifics for individual configurations can be rather tricky./p
   
   pHere then are some example configurations that have been posted to
  @@ -41,6 +41,12 @@
   know if you have any other tested configurations that you feel may be of use
   to the wider audience, or if you feel we can improve this section in 
anyway./p
   
  +p
  +bPlease note that JNDI resource configuration has changed somewhat between
  +Tomcat 5.0.x and Tomcat 5.5.x./b  You will most likely need to modify your 
JNDI
  +resource configurations to match the syntax in the example below in order
  +to make them work in Tomcat 5.5.x.
  +/p
   /section
   
   section name=Database Connection Pool (DBCP) Configurations
  @@ -335,16 +341,65 @@
   
   subsection name=PostgreSQL
   h30.Introduction/h3
  -pPostgreSQL is configured in a similar manner to Oracle. Again, 
highlighting the differences.
  -These notes are untested as yet and we would appreciate feedback./p
  -h31.server.xml configuration/h3
  +pPostgreSQL is configured in a similar manner to Oracle./p
  +
  +h31. Required files /h3
  +p
  +Copy the Postgres JDBC jar to $CATALINA_HOME/common/lib. As with Oracle, the
  +jars need to be in this directory in order for DBCP's Classloader to find
  +them. This has to be done regardless of which configuration step you take 
next.
  +/p
  +
  +h32. Resource configuration/h3
  +
  +p
  +You have two choices here: define a datasource that is shared across all 
Tomcat
  +applications, or define a datasource specifically for one application.
  +/p
  +
  +h42a. Shared resource configuration/h4
  +p
  +Use this option if you wish to define a datasource that is shared across
  +multiple Tomcat applications, or if you just prefer defining your datasource
  +in this file.
  +/p
  +piThis author has not had success here, although others have reported so.
  +Clarification would be appreciated here./i/p
  +
   source
   lt;Resource name=jdbc/postgres auth=Container
 type=javax.sql.DataSource driverClassName=org.postgresql.Driver
 url=jdbc:postgresql://127.0.0.1:5432/mydb
  -  username=myuser password=mypasswd maxActive=20 maxIdle=10 
maxWait=-1/ 
  +  username=myuser password=mypasswd maxActive=20 maxIdle=10 
maxWait=-1/gt;
   /source
  -h32.web.xml configuration/h3
  +h42b. Application-specific resource configuration/h4
  +
  +p
  +Use this option if you wish to define a datasource specific to your 
application,
  +not visible to other Tomcat applications. This method is less invasive to 
your
  +Tomcat installation.
  +/p
  +
  +p
  +Create a resource definition file for your application defining the
  +datasource. This file must have the same name as your application, so if
  +your application deploys as codesomeApp.war/code, this filename must
  +be codesomeApp.xml/code. This file should look something like the 
following.
  +/p
  +
  +source
  +lt;Context path=/someApp docBase=someApp
  +   crossContext=true reloadable=true debug=1gt;
  +
  +lt;Resource name=jdbc/postgres auth=Container
  +  type=javax.sql.DataSource driverClassName=org.postgresql.Driver
  +  

DO NOT REPLY [Bug 33774] - JNDIRealm fails when server disconnects after time

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33774.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33774


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 04:20 ---
The code looks decent to me.  Will, please test 5.5.9 which will be out in a
couple of days, and if it still fails reopen this issue.  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29727] - JNDI env-entry not reload when context reloaded

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29727.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 04:23 ---
The chances of this getting fixes in Tomcat 5.0.x are now slim.  Can either or
both of you test with 5.5.7 (or 5.5.9 which will be out in a couple of days) and
let us know if it works or not?  That would be great...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30936] - Adding HTTPS Connector with Administration webapp mangles server.xml

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=30936.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30936





--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 04:23 ---
This should be fixed in the new storeconfig module that's shipping with Tomcat
5.5.9, which itself will be out in a couple of days.  Can you please test it
when you get a chance and let us know how it works?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33755] - Documentation enhancement to JNDI-Datasources-examples for Postgres

2005-03-25 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=33755.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33755


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-03-26 04:17 ---
Both suggestions accepted and implemented.  Thanks for submitting the patch.

In the future, please submit patches as attachments to the Bugzilla issue rather
than in the comments section.  Thanks ;)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Behaviour of mod_jk AJP 1.3 load balanced workers

2005-03-25 Thread Mathias Herberts
Hi Mladen,

Now that I think more of that, you can use the Apache's
'LimitRequestLine' directive (default 8190), so this won't get to
the mod_jk at first.
this will indeed fix some cases, but the AJP13 packet can still be 
filled up by adding junk headers to the request, Apache does not take 
headers into account to compute the size of the RequestLine (only the 
URI is).

The DOS condition is then still there.
Mathias.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]