Re: [Kin-Man] Jasper compiling wrong stuff in the wrong place...

Pier, Long time no see/talk/eamil. How are you? Haven't seen that before, and no idea why it's so. You'll need to give me a test case. Why aren't you using jasper2 instead? Glenn's recompilation stuff works great! - Kin-man > Date: Fri, 17 May 2002 11:54:38 +0100 > From: Pier Fumagalli <[E

Re: Switching javac for jasper 2

See below. > Date: Thu, 16 May 2002 14:07:36 -0700 (PDT) > From: [EMAIL PROTECTED] > Subject: Re: Switching javac for jasper 2 > X-X-Sender: [EMAIL PROTECTED] > To: Tomcat Developers List <[EMAIL PROTECTED]>, Kin-Man Chung <[EMAIL PROTECTED]> > MIME-version: 1.

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated byJasper2

Denis, First let me mention a couple of improvements over the existing codes that was generated for flattening out the try/catch block. See if you agree with me. 1. I notice the following code pattern that is now generated. bitmask.set(1); addTagToVector(tags, 1, new Integer(_j

Switching javac for jasper 2

Tomcat has been using sun.tools.javac.Main as the default java compiler for compiling the java files generated by Jasper. This compiler is essentially a JDK1.2 compiler, current deprecated and unsupported. The warning message "Note: sun.tools.javac.Main has been deprecated" is probably familiar t

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated byJasper2

See intermixed. > Date: Thu, 09 May 2002 20:48:27 -0400 (EDT) > From: Denis Benoit <[EMAIL PROTECTED]> > Subject: Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by Jasper2 > > Good idea, but I think it would be hard to accomplish as presented. Look again > at your pseudo-code:

Re: [PATCH] Re: [PROPOSAL] Modification of the code generated byJasper2

> Date: Wed, 08 May 2002 20:50:06 -0400 (EDT) > > Mr Maucherat noticed that the patch do create a BitSet and a Vector, even for > JSPs that don't have tags, I think it could be avoided if we did some kind of > lazy initialisation. My first, dumb, I confess! idea was to put the Vector > and the

Re: JSP no reload

It is currently not an option to turn off checking out-of-date jsp pages that triggers recompilations. There has been some efforts recently at speeding up this area in jasper2 (Remy'work, Duncan's patch for timestamp cache, and my recent mods), so you may want to try jasper2 to see if performans

Re: [PROPOSAL] jasper2 detection of compile time page include changes

+1 on the idea. With minor changes, we can also implement a compiler server that compiles out-of-date pages in the background thread. This would greatly improve the response time for accessing the pages, when recompilations are needed. > Date: Wed, 24 Apr 2002 10:52:51 -0500 > From: Glenn Niels

Re: [PATCH] possible speed enhancement to JspServlet.java

patch. If you wish, you should try running with japser2, and compare its performance with the one you patched. > Date: Fri, 19 Apr 2002 16:58:54 -0700 (PDT) > From: Kin-Man Chung <[EMAIL PROTECTED]> > Subject: Re: [PATCH] possible speed enhancement to JspServlet.java > To: [

Re: [PATCH] possible speed enhancement to JspServlet.java

Thank you for the patch! It looks interesting! I'll definitely look at it carefully and apply it to jasper or jasper2 when I have time, most probably sometime next week. > Date: Fri, 19 Apr 2002 17:09:49 -0400 > From: Duncan McLean <[EMAIL PROTECTED]> > Subject: [PATCH] possible speed enhanceme

Re: cvs commit:jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java

> Date: Thu, 04 Apr 2002 11:20:21 -0800 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java > To: Tomcat Developers List <[EMAIL PROTECTED]> > MIME-version: 1.0 > X-MIMEOLE: Produced By Microsoft MimeO

Re: cvs commit:jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java

Remy, I afraid that this patch won't work, because you are initializing CustomTag.JspAttrs in the constructor, which is too early. CustomTag.JspAttrs is currently set in Validator, after tld is consulted to see if the tag attribute can take a request time expression; and if so, extracts the strin

Re: Jasper2

[EMAIL PROTECTED] wrote: > > I had problems with the new compiler / runtime environment though (for ex, > the include example doesn't work, and the admin webapp can't compile), so > it's not ready yet. > The include example is wrong in that it includes a page directive <%@ page buffer="5"

Re: Jasper2

Good for you, Remy! > Actually, I've already done the optimization for the runtime and it is very > significant for simple pages (see my commits last week); when the page does > run, it does it very fast now. There's no hotspot left in the runtime > (according to OptimizeIt; of course, it won't h

Jspc documentation

> Kin-Man, > I have a side question. > I am looking for the documentation /comments on the Jasper compiler(jspc)-I > have > looked through the JspC.java but there are no comment about different > compiler options. > I wondering if you can point me in a right direction. > Thank you. > Leo > Hmm

Re: Jasper2

able improvements that we should do? - kin-man > Date: Wed, 03 Apr 2002 07:29:32 -0500 > From: peter lin <[EMAIL PROTECTED]> > Subject: Jasper2 > To: Kin-Man Chung <[EMAIL PROTECTED]> > MIME-version: 1.0 > Content-transfer-encoding: 7bit > X-Accept-Language: en-U

Re: tag pooling question

Tomcat Developers List <[EMAIL PROTECTED]>, Kin-Man Chung <[EMAIL PROTECTED]> > MIME-version: 1.0 > X-Authentication-warning: dyn-181.sfo.covalent.net: costinm owned process doing -bs > > On Wed, 27 Mar 2002, Kin-Man Chung wrote: > > > Pulling codes out of iteratio

RE: [PLAN] New Jasper

OK, that'd be easier. :) I'll give it a try. Thanks for the suggestion. > Date: Wed, 27 Mar 2002 14:59:00 -0800 (PST) > From: [EMAIL PROTECTED] > Subject: RE: [PLAN] New Jasper > X-X-Sender: <[EMAIL PROTECTED]> > To: Tomcat Developers List <[EMAIL PROTECTED]&

RE: [PLAN] New Jasper

and see if jasper2 should move in there. Thanks for the suggestion. > Date: Tue, 26 Mar 2002 15:04:16 +0100 > From: "Ignacio J. Ortega" <[EMAIL PROTECTED]> > Subject: RE: [PLAN] New Jasper > To: 'Tomcat Developers List' <[EMAIL PROTECTED]>, '

Re: tag pooling question

Pulling codes out of iteration tag bodies is very high on my list of optimizations that I wnat to do. I don't think we can do much about general scriplets that contain loops, though. But before we start on jasper optimization work, we'll need benchmarks and performance analysers. I have learnt

Re: [PLAN] New Jasper

on of custom tags). It is much easier for a custom parser to just handle them as special cases. > Date: Tue, 26 Mar 2002 08:17:12 -0600 > From: Bob Lee <[EMAIL PROTECTED]> > Subject: Re: [PLAN] New Jasper > To: Tomcat Developers List <[EMAIL PROTECTED]>, 'Kin-Man

Re: [PLAN] New Jasper

> On Mon, 25 Mar 2002, Kin-Man Chung wrote: > > > I have noticed that the current Jasper does a lot of string manipulations > > very slowly, e.g. there are unnecessary copying or concatenations, and > > the uses of String where StringBuffer should be used. Hopefull

Re: [PLAN] New Jasper

0.0.1309 > X-Antivirus-Data: Virus data file v4189 created Mar 06 2002 > X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > List-Post: <mailto:[EMAIL PROTECTED]> > List-Subscribe: <mailto:[EMAIL PROTECTED]> > List-Unsubscribe: <mailto:[EMAIL PROTECTED]> > List-Hel

RE: [PLAN] New Jasper

ue, 26 Mar 2002 00:47:12 +0100 > From: "Ignacio J. Ortega" <[EMAIL PROTECTED]> > Subject: RE: [PLAN] New Jasper > To: 'Tomcat Developers List' <[EMAIL PROTECTED]>, 'Kin-Man Chung' <[EMAIL PROTECTED]> > MIME-version: 1.0 > X-Priority

[PLAN] New Jasper

As I have announced here before, I have been working on rewriting part of Jasper. There are several goals for the new Jasper: 1. To reorganize/simplify parsing and code generation to make it more maintainable and yet runs faster. 2. To be used as a basis for reference implementati

Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release

+1 on both. > Date: Thu, 21 Mar 2002 16:25:50 -0800 > From: Remy Maucherat <[EMAIL PROTECTED]> > Subject: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release > To: Tomcat Developers List <[EMAIL PROTECTED]> > MIME-version: 1.0 > X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2600. > Conten

Re: Jasper error handling extensions

I am in the process of rewriting much of Jasper, and am using an error handling mechanism very similar in idea to the one you just proposed. The new jasper would alos support JSR45, which is an interface for source mapping. The error handler (and other compiler plugins) can be configured with a c

Re: [VOTES] Tomcat 4.0.2 beta 1

> > [X] +1: Make the release > [ ] -1: I'm opposed to the release until the following issues are fixed: > Since 4.0.1, there have been lots of bug fixes. It's time. -- To unsubscribe, e-mail: For additional commands, e-mail:

RE: [PATCH] Bug 5471 - JspC broken when compiling webapps

lets/index.java - contains class > com.netfolio.jspservlets.index > /com/netfolio/jspservlets//subdir/index.java - contains class > com.netfolio.jspservlets.subdir.index > > > > > -Original Message- > > From: Kin-Man Chung [mailto:[EMAIL PROTECTED]] > >

Re: [PATCH] Bug 5471 - JspC broken when compiling webapps

Believe or not, Jasper once mangled the file names in a way similar to what is in the patch. It was modified in response to a bug (Bugzilla is currently unavailable, so I can't look up the bug number). The filer complained that for a file with deeply nested path, the resultant file name is too l

Bug 4954 - When specifying CATALINA_BASE explicitly,that dir has to have "shared/lib/jasper-*.jar" in it

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4954 Looks like a build environment issue. Want to take a look at this? Thanks. -- To unsubscribe, e-mail: For additional commands, e-mail:

[PROPOSAL] 4.0 Jasper rewrite

1 The Problem The current JSP compiler (Jasper) in tomcat 4.0 is essentially an one-pass compiler, with a two stage process. The Jsp page is first parsed, looking for JSP syntatic elements, and a list of generators for these elements are produced. At the second stage, these generators are visit

Re: [PATCH] Tomcat 4.0.1- Proposed fix for Bugzilla 4609

The problem is actually deeper than is reported in the bug report. 1. We also need a fix for flush(), since invoking flush after close should also throw IOE. 2. The fixes should also be applied to BodyContentImpl.java, since it's just another JspWriter. However, doing all these fixe

Re: [VOTE] New Committer

+1 Welcome, Patrick. > Date: Wed, 17 Oct 2001 22:02:13 -0600 (MDT) > From: Christopher Cain <[EMAIL PROTECTED]> > Subject: [VOTE] New Committer > X-Originating-IP: 216.17.139.153 > To: [EMAIL PROTECTED] > MIME-version: 1.0 > Content-transfer-encoding: 8BIT > Delivered-to: mailing list [EMAIL PRO

[PATCH] TC4.0 Improvements in validator messages

e. It differs from JasperException in * that it does not print stack trace. * * @author Kin-man Chung */ public class JasperError extends org.apache.jasper.JasperException { public JasperError(String reason) { super(reason); } } misto% runsocks cvs diff -u co

[PATCH] TC4.0 "null" JasperException

Fixes #3617. Patch supplied by [EMAIL PROTECTED] (Martijn Koster) Index: Compiler.java === RCS file: /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/C ompiler.java,v retrieving revision 1

[PATCH] TC4.0 Error in setting string literal to Object in custom tags

This patch fixes #3707. misto% runsocks cvs diff -u "TagBeginGenerator.java" Index: TagBeginGenerator.java === RCS file: /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/T agBeginGenerator.java,v retrie

Re: [PATCH] Error in examples/simpletag/foo.jsp

This patch fixes #3739. runsocks cvs diff -u foo.jsp Index: foo.jsp === RCS file: /home/cvspublic/jakarta-tomcat-4.0/webapps/examples/jsp/simpletag/foo.jsp,v retrieving revision 1.2 diff -u -r1.2 foo.jsp --- foo.jsp 2001/09/05 0

[PATCH] TC4.0 Throws NPE in JakartaCommentGenerator

This patch fixes the NPE raised when a jsp:useBean has a non empty body. However, it does not "fix" the problem reported in #3740, since I couldn't reproduce the same bug, though the test now works! misto% runsocks cvs diff -u Parser.java Index: Parser.java ==

Re: [PATCH] Jspc throws NPE when used without -webapp

an" <[EMAIL PROTECTED]> > Subject: Re: [PATCH] Jspc throws NPE when used without -webapp > To: [EMAIL PROTECTED], Kin-Man Chung <[EMAIL PROTECTED]> > MIME-version: 1.0 > X-Spam-Rating: localhost 1.6.2 0/1000/N > > Thanks Kin-Man. Can you validate the proposed pa

[PATCH] Jspc throws NPE when used without -webapp

This patch fixes the reopen #3529. Now jspc works for taglib when -webapp is not specified. The logic used in JspC.java to get the uri root and base is still very convoluted and should be a prime target for rewrite, maybe later. misto% runsocks cvs diff -u JspC.java Index: JspC.java ==

[PATCH] BullPointerException in JakataCommentGenerator

This patch fixes #3079 misto% runsocks cvs diff -u Parser.java Index: Parser.java === RCS file: /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/P arser.java,v retrieving revision 1.12 diff -u -r1.12 Pa

[PATH} Jspc can't handle taglibs

This patch fixes #3529 and #3235, and was provided by Peter Roßbach ([EMAIL PROTECTED]). I verified the fix with samll test cases. Note that -webapp option has to be used. misto% runsocks cvs diff -u JspC.java Index: JspC.java ===

[PATH] XML fragments in jsp handled incorrectly

This patch fixes #3350. In a JSP document, the tags in a XML fragment are always generated before the characters. The current fix preserves their orders. misto% runsocks cvs diff -u ParserXJspSaxHandler.java Index: ParserXJspSaxHandler.java ==

[PATCH] JSP generated file names are too long

This patches fixes Bug 2917. The name of the .java files generated by Jasper includes the path name, which can be a problem in Windows if the path name is long. Since the files are placed under the directories indicated by the path name, there is really no reason to include the pathname with the

[PATCH] Jasper generates bad custom tag variable names

This patch fixes Bug 3019. If a tag name includes a '-', the generated var name is not a legal Java identifier name, causing javac compilation errors. The bug is fixed by substituting '-' with "$1". Similarily, '.' is replaced by "$2", and ':' by "$3". runsocks cvs diff -u TagGeneratorBase.jav

[PATCH] Jsp XML document produces invlaid XML

This patch fixes 3174 and 3351. This fix was supplied by the submitter [EMAIL PROTECTED] This fix looks good. Index: XmlOutputter.java === RCS file: /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/X

[PATCH] Tag attributes of type char and short bug

Date: Wed, 05 Sep 2001 14:22:21 -0700 (PDT) From: Kin-Man Chung <[EMAIL PROTECTED]> Subject: [PATH] Tag attributes of type char and short bug To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-MD5: NTIF51okQsoUB2BTXXgn/Q== This patch fixe

<    1   2