For practical purposes, I don't think you'll gain much using plugins
for c:set and c:out, since they are relatively simple, and the
overheads for invoking the corresponding tag handlers is relatively
minor. You'll probably achieve most benefit if you can provide plugins
for them that only handle
The method generateBody() is meant to continue to generate
codes for body of the tag, as usual. What you want is a method
to generate codes to get the body content, which is certainly
doable, but is not currently available. You are welcome to have
the first crack at extending the plugin
The body content of a tag is a runtime entity, and you cannot
generally get it during compilation time, since it may contain
non-template texts. You need to achieve what you want in another way,
such as the use of JSP fragments.
-Kin-man
On Sat, 2005-08-20 at 00:26, wing lee wrote:
I think
It appears that my name (Kin-man Chung [EMAIL PROTECTED]) has been
dropped from the PMC. Hope this is not intentional. :-)
On Wed, 2005-04-06 at 05:15, Remy Maucherat wrote:
Hi,
Here's a new draft with the necessary updates.
I suppose this needs to be sent to the PMC for approval
Please file a report on bugzilla. If you also include a test case
(to save me some typing :)), I'll take a look to see where Jasper is
spending its time. Did you said it was in commons-el? That'd be bad.
-Kin-man
On Wed, 2004-10-20 at 00:43, Eric Blenkush wrote:
On Oct 19, 2004, at 10:41 PM,
I have no problem getting rid of all those messages, since they are
no longer useful.
- Kin-man
On Fri, 2004-09-17 at 14:23, Amy Roh wrote:
[EMAIL PROTECTED] wrote:
amyroh 2004/09/17 14:02:34
Modified:jasper2/src/share/org/apache/jasper/compiler SmapUtil.java
Which watchdog is it? Can you send me the other part (tld and tag handler)
of it?
If the tag is of a TAGDEPENDENT body type, then its body is should not
be evaluated. It used to be evaluated in XML syntax, which is wrong and
which is what the patch intend to fix. If this is the case, then the
.
-Kin-man
Date: Tue, 30 Mar 2004 08:30:05 -0600
From: Jess Holle [EMAIL PROTECTED]
Subject: Re: Tomcat 5.0.20 Issue
To: Tomcat Developers List [EMAIL PROTECTED]
X-OriginalArrivalTime: 30 Mar 2004 14:30:06.0040 (UTC)
FILETIME=[7EEF4580:01C41663]
Kin-Man Chung wrote:
I think your only
I think your only valid point is the one about the need to make
errorOnUseBeanInvalidClassAttribute be switchable from Jspc main,
but we are not bundling jspc scripts anymore, so I didn't feel there
is a need for it. Anyway, its value can be set with an ant task.
Otherwise, Jasper behaves the
-1. The patch breaks the spec.
According to JSP 2.0 spec, JSP.5.5 (p1-111),
If the page output was unbuffered and anything has been written to
it, an attempt to forward the request will result in an
IllegalStateException.
-Kin-man
Date: Thu, 18 Mar 2004 21:05:17 +
From:
page. My reading of the spec is that
this
shouldn't happen. I can't see how this check helps meet the part of the spec
you
quoted.
Am I being stupid and missing the blindingly obvious here?
Mark
-Original Message-
From: Kin-Man Chung [mailto:[EMAIL PROTECTED]
Sent
-1.
Remy, please reread JSP 2.0 spec, p 1-101,1-102. Bullet .2 of the Semantics
section was added to allow for this kind of optimization. Bullet .5 and .6
will be executed ONLY IF the container choose not to issue translation errors.
-Kin-man
Date: Mon, 02 Feb 2004 18:18:01 +
From:
happy...
-Kin-man
Date: Mon, 02 Feb 2004 19:41:54 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler
Generator.java
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
-1.
Remy, please
Date: Mon, 02 Feb 2004 20:17:29 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler
Generator.java
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
Agreed that the spec can be clearer
The source for Jasper in Tomcat 4.1.29 is from j-t-j/jasper2 with
Tomcat_4_branch tag. The head branch is for Tomcat 5.
A lot of bugs filed against Tomcat 4.1.x has been fixed in Tomcat 5.
Unfortunately I don't have cycles to apply the fixes to 4.1.x. It would
be great if someone can do that,
The code for Jasper in 4.0.x is in the module jakarta-tomcat-4.0.
Date: Thu, 30 Oct 2003 14:51:13 -0600
From: Ken Sipe [EMAIL PROTECTED]
Subject: Jasper used for Tomcat 4.0.6
To: [EMAIL PROTECTED]
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Importance: Normal
X-Priority: 3
Date: Wed, 29 Oct 2003 11:32:58 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: [VOTE] New builds
To: Tomcat Developers List [EMAIL PROTECTED]
ballot
Release 4.1.29 as Stable ?
[ ] Yes
[ ] No
/ballot
ballot
Release 5.0.14 as Beta ?
[X] Yes
Jasper seems solid.
[ ] No
to give
this up as another mystery of the universe. :-)
-Kin-man
Date: Wed, 15 Oct 2003 10:36:01 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: [5] IndexOutOfBoundsException from CharChunk
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
I don't know much
I am getting a sporadic IndexOutOfBoundsException and it seems to come from
org.apache.tomcat.util.buf.CharChunk.flushBuffer. The trace is
Servlet.service() for servlet jsp threw exception
java.lang.IndexOutOfBoundsException
at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:132)
Date: Wed, 08 Oct 2003 21:22:07 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: [5] IndexOutOfBoundsException from CharChunk
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
I am getting a sporadic IndexOutOfBoundsException and it seems to come from
This is a bug. I have committed a fix in Tomcat 5. Thanks for reporting.
-Kin-man
Date: Tue, 23 Sep 2003 07:30:29 -0400
From: Tim Funk [EMAIL PROTECTED]
Subject: \% not handled right?
To: Tomcat Developers List [EMAIL PROTECTED]
Attached is a note from tomcat-user which I think might be
Eric,
I forgot about those generated Declartions. It good to have an extra
pair of eyes to keep one honest. Thanks. :)
I have committed a fix for this and the last you reported. Please see if
it works better now. I have noticed that smap now contains lots of
overlaps, because of
Date: Mon, 15 Sep 2003 22:57:32 -0700
From: Eric Carmichael [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources
messages.properties
X-Originating-IP: [64.203.49.21]
To: Tomcat Developers List [EMAIL PROTECTED]
X-MIMEOLE: Produced
more use there.
-Kin-man
Date: Tue, 16 Sep 2003 19:46:19 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/resources
messages.properties
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
I
Ah, I forgot about the fix that you did in SmapUtil to improve line mappings
for template texts. Sorry. :-(
But this also shows that tight coupling between Generator and SmapUtil is
flagile and error prone. I think it would be a better design if we
decouple these two modules somehow. We could
Yeah, now I remember; but I didn't pay attention then! :-)
Anyway, the print methods handle null String and Object, so we are covered.
This is true for outputting expressions in text mode; evaluating attributes
with expressions is, however, another matter.
BTW, I also think it acceptable to
Date: Wed, 10 Sep 2003 18:34:40 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: AW: AW: AW: [5.0] JSP performance ...
To: Tomcat Developers List [EMAIL PROTECTED]
Torsten Fohrer wrote:
next try
Yes, the code is better (IMO) and performs a little better also.
However,
Date: Tue, 09 Sep 2003 08:59:51 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: AW: [5.0] JSP performance ...
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
I have implemented generating text strings as char arrays, with a
compiler option to turn
This seems easy enough to implement, so I'll look into it. Concatenating
texts is also on my list, and it should help a little in this case.
- Kin-man
Date: Mon, 08 Sep 2003 08:46:32 +0200
From: Torsten Fohrer [EMAIL PROTECTED]
Subject: AW: [5.0] JSP performance ...
To: 'Tomcat Developers
PROTECTED]
Subject: Re: AW: [5.0] JSP performance ...
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
This seems easy enough to implement, so I'll look into it. Concatenating
texts is also on my list, and it should help a little in this case.
That would be awesome
if there is any value in committing my change. :(
-Kin-man
Date: Mon, 08 Sep 2003 15:18:34 -0700 (PDT)
From: Kin-Man Chung [EMAIL PROTECTED]
Subject: Re: AW: [5.0] JSP performance ...
To: [EMAIL PROTECTED]
Content-MD5: +Y/z1F8l8EXxpI9LL3yPSA==
I took a look at o.a.j.runtime.JspWriterImpl
Remy,
I discovered there is a jasper bug that causes wrong Java line numbers
to be mapped when codes for invoking tag handlers are generated in separate
methods. This would completely screw up JSP debugging, and causes javac
error messages to be lost if it happens in the generated method. I
It eventually invokes
request.getRequestDispatcher(bar.jsp).include().
Date: Fri, 08 Aug 2003 11:40:45 +0200
From: Marc Baumgartner [EMAIL PROTECTED]
Subject: JSP include
To: [EMAIL PROTECTED]
Content-disposition: inline
Hello all,
I want to fix a bug in the JSPReader of
He has my +1 as well. Yan and I need all the help on Jasper!
Date: Sun, 10 Aug 2003 18:56:49 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: [VOTE] New committer: Eric Carmichael
To: Tomcat Developers List [EMAIL PROTECTED]
I'd like to nominate Eric Carmichael as a committer on the
I don't think this patch is correct. The order that the methods
startPrefixMapping and endPrefixMapping are called is properly nested,
so a stack is appropiate. Take for instance the follow xml fragment
1 foo xmlns:my=mytaglib !-- namespace for my taglib --
2bar xmlns:my=nottaglib/ !--
You are right in that this is not a spec conformant issue and is
therefore not a bug.
Except for some exceptions, most exceptions are caught and rethrown
as JasperExceptions. Making exceptions would just, well, complicate
things. :-)
-Kin-man
Date: Fri, 08 Aug 2003 09:00:30 -0400
From: Tim
Can you reproduce your problem with Tomcat 5? If so, you may get it
fixed faster if you post it on bugzilla. When you do, make sure to
include a test case (a war file would be great).
Not sure I understand what the problem is. Also not sure what
jsp:include has to anything to do with your
Date: Fri, 30 May 2003 13:47:01 -0400
From: Tim Funk [EMAIL PROTECTED]
Subject: [5] EL parsing eats extra character after '?'
To: Tomcat Developers List [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Attached below is a message from tomcat-user. I don't know it this is a valid
issue or not. If
The patch you mentioned in 14302 was actually applied to TC5.
Date: Fri, 28 Feb 2003 12:07:21 -0800
From: Hans Bergsten [EMAIL PROTECTED]
Subject: Re: [4.1.21] Stability rating
To: Tomcat Developers List [EMAIL PROTECTED]
Remy Maucherat wrote:
ballot
[X] Alpha
[ ] Beta
[ ] Stable
Date: Fri, 21 Feb 2003 19:16:46 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: [5.0.1] Tagging today
To: Tomcat Developers List [EMAIL PROTECTED]
Costin Manolache wrote:
Kin-Man Chung wrote:
I also don't believe jsp-examples has been successful compiled with JSPC
before
The fix looks OK, except that you still need to put the call to
incTripCount in a synchronized block. Of course that won't
be necessary for JSPC.
There may better solutions to this problem, and I'll look into that.
I'll also make sure that there won't be problems using jspc on tag
files.
Date: Tue, 18 Feb 2003 21:46:54 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: [5.0.1] Tagging today
To: Tomcat Developers List [EMAIL PROTECTED]
Costin Manolache wrote:
Remy Maucherat wrote:
Costin Manolache wrote:
Remy Maucherat wrote:
Jeanfrancois Arcand
No matter how easy the build is, it is still not as easy as downloading
a binary from the nightly build area. Just tell someone who haven;t
done a build before to do it now and watch her cringe!
Sue' point is that TC5 nightly build has failed for a week now
and should be fixed. It's important
There has been inquiries about a Tomcat 5 release, both in and out
of the mailing list. I usually direct them to our nightly builds,
but there is no links from the jakarta page, and they are not always
available. I think it's time that we make a release, to make it
easier for people to try it
You should try to get answers to questions like this on tmcat-users alias.
You'll need to put whatever you import in a package. This is a new
in JDK1.4.
Date: Wed, 05 Feb 2003 17:39:07 +0530
From: Sachin Chowdhary [EMAIL PROTECTED]
Subject: bean with jsp
To: [EMAIL PROTECTED]
X-MIMEOLE:
See below.
Date: Wed, 22 Jan 2003 19:03:08 +0100
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java
To: Tomcat Developers List [EMAIL PROTECTED]
Costin Manolache wrote:
Remy Maucherat wrote:
Then why
Date: Wed, 22 Jan 2003 13:20:48 -0600
From: Glenn Nielsen [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
See below.
Date: Wed, 22 Jan 2003 19:03
]
Subject: Re: [newbie] where do I get TagFileInfo, etc.?
To: Tomcat Developers List [EMAIL PROTECTED]
Kin-Man Chung wrote:
It's in jakarta-servletapi-4, which IS mentioned in BUILDING_txt.
Make sure that you have servlet.home defined correctly in build.properties.
I'm trying to build
Performance-wise, wouldn't doing javac compilation in another process
be much worse than synchronized javac, at least for systems with small
number of processors? It would nice if we can have some numbers for
comparision.
I know javac used to have memory leak, but is it still true for modern
It's in jakarta-servletapi-4, which IS mentioned in BUILDING_txt.
Make sure that you have servlet.home defined correctly in build.properties.
Date: Wed, 04 Dec 2002 17:39:25 -0800
From: Michael [EMAIL PROTECTED]
Subject: [newbie] where do I get TagFileInfo, etc.?
To: [EMAIL PROTECTED]
I'm
I am designing a framework in Jasper for enabling plugins that
work closely with Jasper to generate Java codes instead of calls
to tag handlers. The main idea is to take take JSTL tags, such as
c:forEach var=i begin=1, end=100
${i}
/c:forEach
and generates the Java
According to the JSP 1.2 Spec, the release method is not invoked between
tag usages, but is invoked before GC of the tag handler. Therefore
it should not be used to reset the tag handler to its initial state;
you should do that in doStartTag. See p164 and p166.
Date: Mon, 11 Nov 2002 13:32:31
() i haven't any
properties set
Who call the release method in reaction of the GC, finalize can't it.
On Monday 11 November 2002 18:44, Kin-Man Chung wrote:
According to the JSP 1.2 Spec, the release method is not invoked between
tag usages, but is invoked before GC of the tag
costin,
This fix seems to break errorPage handling in JSP, causing the errorPage
example to fail, and a couple of JSP watchdog tests too. I have reverted
your fix.
I have not reverted the tomcat_4_branch.
Date: Thu, 24 Oct 2002 19:18:55 +
From: [EMAIL PROTECTED]
Subject: cvs commit:
:10:09 + (UTC)
X-Injected-Via-Gmane: http://gmane.org/
NNTP-posting-host: 64.84.39.162
Kin-Man Chung wrote:
costin,
This fix seems to break errorPage handling in JSP, causing the errorPage
example to fail, and a couple of JSP watchdog tests too. I have reverted
your fix.
I
I got the following exception when I run TC5.
I am using xerces-2_0_1. I tried disable xmlValidation, but still have
the problem.
catalina.sh run
Using CATALINA_BASE: /home/kchung/tc/jakarta-tomcat-5/build
Using CATALINA_HOME: /home/kchung/tc/jakarta-tomcat-5/build
Using CATALINA_TMPDIR:
If you are using JDK javac for compiling the servlet generated by the
JSP compiler, then you probably ran into the problem that the javac
not being thread-safe.
In Tomcat 5 the javac compilation is synchronized, so that the compilation
is serialized. Guess that fix is not ported to 4.1.5. :-(
+1
Date: Sat, 28 Sep 2002 16:12:06 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: [VOTE] [5.0] Milestones
To: Tomcat Developers List [EMAIL PROTECTED]
Hi,
Now that the first stable releases of Tomcat 4.1 are out (and according
to reports, of good overall quality), it could be
JSR45 support is already in Tomcat 5, which is yet to be released. You
can, however, build it from source and try it out yourself.
Date: Wed, 18 Sep 2002 16:48:00 +0200
From: Damian Frach [EMAIL PROTECTED]
Subject: JSR45
To: [EMAIL PROTECTED]
Hi,
I am a member of the web app group of
I'd suggest that we remove this test.
Jasper 2 and jasper produces different but correct XML view of the JSP
document. If the golden file is fixed to pass in TC5, it would then
fail in TC4.0.
Date: Wed, 11 Sep 2002 18:10:59 -0400
From: Steve Downey [EMAIL PROTECTED]
Subject: Catalina tester
This is not a bug. Any % that appears in an expression bracketed by
% ... % needs to be escaped as %\ (JSP.2.6).
Date: Mon, 09 Sep 2002 15:17:04 -0400
From: Stephane Zafirov [EMAIL PROTECTED]
Subject: JSP Bug
To: [EMAIL PROTECTED]
I just wanted to make sure the following bug has been
Date: Wed, 28 Aug 2002 16:41:16 -0700 (PDT)
From: Craig R. McClanahan [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet
JspServletWrapper.java
To: Tomcat Developers List [EMAIL PROTECTED]
On 28 Aug 2002 [EMAIL PROTECTED]
There is also this feature/bug in jasper2 regarding the scope of
scripting variables that costin had objected to. The clarifications
from JSP spec lead inidcates that costin was right. We should have a
fix this week and that should go into 4.1.10.
- Kin-man
Date: Sat, 10 Aug 2002 09:54:02
The head branch of jasper2 is meant to be part of Jakarta-tomcat-5, which
in the middle of being set up. It might be a while before tomcat 5
can be built.
You should check out the tomcat_4_branch of jasper2 for your build.
If you really want to build Jakarta-tomcat-4 with the head branch
of
Date: Thu, 18 Jul 2002 14:15:16 -0400
From: Tim Funk [EMAIL PROTECTED]
Subject: Re: cvs commit:
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper
JspCompilationContext.java
To: Tomcat Developers List [EMAIL PROTECTED]
Content-transfer-encoding: 7bit
Yeah! $ is replaced by _
I am sympathetic to Jon's view on separating servlet and JSP API
and repositories.
One result of the separation would make it likely that package names
for JSP 2.0 API may change. JSP2.0 is now in public review, so it may
be important to raise this issue before the door is closed.
Until the
Remy,
No they don't: they are bug fixes for JSP2.0 stuff.
I'll make sure bug fixes that apply to both branches get in both branches.
Don't worry! :-)
- Kin-man
Date: Wed, 17 Jul 2002 00:43:53 +0200
From: Remy Maucherat [EMAIL PROTECTED]
Subject: Re: cvs commit:
I totally agree that the use of $ in a file name is a pain in the neck.
In fact, I don't see the need for appending a $jsp at all. Currently
we have the following mapping:
jsp file name: foo.jsp
class name: foo$jsp
servelt file name: foo$jsp.java
class file name:
I think you and Craig are both right. So how about using a _ instead of
a $?
Date: Mon, 15 Jul 2002 12:48:18 -0700
From: Arvind Srinivasan [EMAIL PROTECTED]
Subject: Re: $ in JSP names
To: Tomcat Developers List [EMAIL PROTECTED]
Cc: Kin-Man Chung [EMAIL PROTECTED]
Content-transfer
ballot
A) Servlet 2.4 JSP 2.0 API
1. [X] Use new jakarta-servletapi-5
2. [ ] Use the HEAD of jakarta-servletapi
3. [ ] Other:
B) Catalina 2.0
1. [X] Use new jakarta-tomcat-catalina
2. [ ] Use new jakarta-tomcat-5.0
3. [ ] Use the HEAD of jakarta-tomcat-4.0
4. [ ] Other:
C)
+1.
I'll populate jasper2 and servlet-api with initial changes for JSP2.0
support.
Date: Tue, 02 Jul 2002 16:57:20 -0700
From: Remy Maucherat [EMAIL PROTECTED]
Subject: [VOTE] Apache Tomcat 5.0 Proposal
To: Tomcat Developers List [EMAIL PROTECTED]
After trying to address the concerns
- in the same case, the 'a' variable is declared at the top
of the file, even if it is AT_END. That brakes previous iterate
that used the 'a' id. I believe this is a bug.
According to the spec, the scope of an AT_END variable spans
from the end element of the tag exposing it to
Costin,
On Fri, 21 Jun 2002, Kin-Man Chung wrote:
Use of scripting varibles in nested tag never work before, so obviously
no body uses it much. I think the whole scripting variable in JSP1.2 is
poorly designed, and not well understood.
The failures are from an app that worked
My problem is that code that worked with jasper1 no longer works with
jasper2.
And I believe the use case is valid and within the spec, and quite
common.
The latest failure is just 2 iterate tags and a condition tag -
I think it should work.
Costin
With the Jan's patch last
Costin,
I'm a bit worried here - most of the stuff is pretty basic and
common use of tags. Watchdog and the test suite was supposed
to detect that withou any problems.
Use of scripting varibles in nested tag never work before, so obviously
no body uses it much. I think the whole
-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: 18 June 2002 06:44
To: Tomcat Developers List; Kin-Man Chung
Subject: Re: Jasper2: serious problem with tag declarations
On Mon, 17 Jun 2002, Kin-Man Chung wrote:
Costin,
I am not aware that id attribute is handled differently
costin 2002/06/14 13:43:05
Log:
Second stage of braking jasper2.
You think jasper 2 is going too fast? :-)
Otherwise +1 on the changes.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
costin 2002/06/14 13:44:37
Modified:jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
Split the compile() method in generateJava() and generateClass() - JspC only
generates
java, the compile is a separate step.
Why not have an option to include javac
I'd like to nominate Jan Luehe as a committer to tomcat.
Jan is currently a commiter for Jakarta taglib project, and has been
active in implementing JSTL, the standard tag library.
Jan was involved with jasper 2 from the beginning, and has contributed
to writing a number of important modules in
Remy,
I like this much better! No private API used, and cleaner generated
codes!
Some nitpicks! :-) See below.
There seems to be no need for a JspxState object anymore.
Jspx.State.tagCount is really not used, and JspxState.out can be
make local. I should just comment that out for now.
I already committed a fix for this problem a couple of days ago.
The problem is of course private instance variables are beening referenced
in a child class. The 1.3 javac does not flag this as an error, and
1.4 javac gives misleading error messages!
Date: Fri, 07 Jun 2002 11:32:02 -0400
Looks like the same problem as one decribed in bugzilla #9699 that
got reported today. Good timing! :-)
Date: Fri, 07 Jun 2002 15:42:54 +0530
From: Anil Agrawal [EMAIL PROTECTED]
Subject: problem in nested custom tags- Jboss3.0-tomcat4.03.
To: '[EMAIL PROTECTED]' [EMAIL PROTECTED]
Cc:
I assume that lOffset is a scripting variable defined either in a variable
element of a tld, or in a TagExtraInfo, and that its declaration (in the
generated java file) is a result of the compiler trying to do its
synchronization with the pagecontext attribute of the same name.
If so, what is
ballot
[ ] Alpha
[X] Beta
/ballot
4.1.3 should be feature complete (at least according to what is in the
release plan; it now has the Ant compiler in Jasper 2 and a more finalized
admin webapp), and does not seem to have any major issues, so it looks like
a decent beta candidate.
org.apache.jasper.runtime.JspException seems to be serving no purpose,
and it conflicts with javax.servlet.jsp.JspException.
Any objections to my removing it?
BTW, it also exists in tomcat 4/jasper.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail:
I think it a good idea to limit the stacks to some reasonable value. One
easy way of accomplishing this is to add a tag object to the stack only
when its stack has not reach its maximum size.
The neat thing about these two approaches is that they can both be
implemented. Once a tag object is
I am still in vacation mode, unil Thursday. Just want to giva some
quick response.
Like Costin, I don't think that there would be much performance penalty
by calling a private method. In fact, if we want to reduce the number
of unnecessary calls, I have another idea... well I have two
+1
Welcome! And looking forward to working more with you on Jasper performance!
Date: Tue, 21 May 2002 19:33:27 -0700
From: Remy Maucherat [EMAIL PROTECTED]
Subject: [VOTE] New committer: Denis Benoit
To: [EMAIL PROTECTED]
MIME-version: 1.0
X-MIMEOLE: Produced By Microsoft MimeOLE
Haven't seen that before, and no idea why it's so. You'll need to
give me a test case.
Test case: touch
$CATALINA_HOME/webapps/examples/jsp/colors/colrs.jsp
So that Jasper will have to recompile it, and it will try (the first time)
to recompile also:
However, I'd like to point out that there's no other choice but to upgrade.
In many situations, the current Jasper 2 generated servlets don't compile to
valid bytecode when using the classic compiler (and you get a VerifyError
when loading the class; this happens esp when using JSTL).
See below.
Date: Thu, 16 May 2002 14:07:36 -0700 (PDT)
From: [EMAIL PROTECTED]
Subject: Re: Switching javac for jasper 2
X-X-Sender: [EMAIL PROTECTED]
To: Tomcat Developers List [EMAIL PROTECTED], Kin-Man Chung
[EMAIL PROTECTED]
MIME-version: 1.0
Delivered-to: mailing list [EMAIL
Pier,
Long time no see/talk/eamil. How are you?
Haven't seen that before, and no idea why it's so. You'll need to
give me a test case.
Why aren't you using jasper2 instead? Glenn's recompilation stuff
works great!
- Kin-man
Date: Fri, 17 May 2002 11:54:38 +0100
From: Pier Fumagalli
-Man Chung [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
MIME-version: 1.0
Now you mentioned the use of an array to hold tag objects, I have
another idea. Why don't we use a stack to simulate the runtime state?
Each stack entry would have a tag object and a state. State 0 means
call
Now, about the level of nesting, shouldn't the information be available
through the PageInfo object? After all, the purpose of this class is
A repository for various info about the page under compilation. And
Generator currently has access to an instance of it. So, if PageInfo
had
Tomcat has been using sun.tools.javac.Main as the default java compiler
for compiling the java files generated by Jasper. This compiler is
essentially a JDK1.2 compiler, current deprecated and unsupported.
The warning message Note: sun.tools.javac.Main has been deprecated
is probably familiar to
Denis,
First let me mention a couple of improvements over the existing codes
that was generated for flattening out the try/catch block. See if
you agree with me.
1. I notice the following code pattern that is now generated.
bitmask.set(1);
addTagToVector(tags, 1, new
See intermixed.
Date: Thu, 09 May 2002 20:48:27 -0400 (EDT)
From: Denis Benoit [EMAIL PROTECTED]
Subject: Re: [PATCH] Re: [PROPOSAL] Modification of the code generated by
Jasper2
Good idea, but I think it would be hard to accomplish as presented. Look
again
at your pseudo-code:
It is currently not an option to turn off checking out-of-date jsp pages
that triggers recompilations. There has been some efforts recently at
speeding up this area in jasper2 (Remy'work, Duncan's patch for timestamp
cache, and my recent mods), so you may want to try jasper2 to see if
performans
+1 on the idea.
With minor changes, we can also implement a compiler server that compiles
out-of-date pages in the background thread. This would greatly improve
the response time for accessing the pages, when recompilations are needed.
Date: Wed, 24 Apr 2002 10:52:51 -0500
From: Glenn
. If you wish, you should try running with
japser2, and compare its performance with the one you patched.
Date: Fri, 19 Apr 2002 16:58:54 -0700 (PDT)
From: Kin-Man Chung [EMAIL PROTECTED]
Subject: Re: [PATCH] possible speed enhancement to JspServlet.java
To: [EMAIL PROTECTED]
MIME-version
1 - 100 of 137 matches
Mail list logo
