Re: cvs commit: jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/managerHTMLManagerServlet.java LocalStrings.properties ManagerServlet.java

2003-08-01 Thread Radim Kubacki 
[EMAIL PROTECTED] wrote:
remm2003/06/15 11:31:45

  Modified:webapps/manager/WEB-INF/classes/org/apache/catalina/manager
HTMLManagerServlet.java LocalStrings.properties
ManagerServlet.java
  Log:
  - Update the manager to implement the new functionality as described in the docs.
  - Pausing won't be implemented, due to difficulties, and the likelihood of bringing
the whole server to its knees (thanks to Glenn for poiting that out).
  - Versioning is not tested yet.
  - Known issue: locking occurs on an uploaded WAR, for reasons which
elude me right now.
  - Known issue 2: to deploy local WARs, a jar:file: URL must be used.
  
  1.2   +257 -55   jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/ManagerServlet.java
  
  Index: ManagerServlet.java
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/ManagerServlet.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- ManagerServlet.java	26 Mar 2003 09:49:19 -	1.1
  +++ ManagerServlet.java	15 Jun 2003 18:31:45 -	1.2
  @@ -331,6 +349,12 @@
   String path = request.getParameter(path);
   String type = request.getParameter(type);
   String war = request.getParameter(war);
  +String tag = request.getParameter(tag);
  +boolean update = false;
  +if ((request.getParameter(update) != null) 
  + (request.getParameter(update).equals(true))) {
  +update = false;
  +}
   
   // Prepare our output writer to generate the response message
   Locale locale = Locale.getDefault();
Remy,

here you set update to false or to false ;-). Would it be better touse 
something like this?

boolean update = true.equals(request.getParameter(update));

  @@ -399,6 +431,12 @@
   if (command == null)
   command = request.getServletPath();
   String path = request.getParameter(path);
  +String tag = request.getParameter(tag);
  +boolean update = false;
  +if ((request.getParameter(update) != null) 
  + (request.getParameter(update).equals(true))) {
  +update = false;
  +}
   
   // Prepare our output writer to generate the response message
   response.setContentType(text/plain);
The same here.

Radim

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [5.0.3] Tag soon, 5.0 release plan

2003-06-18 Thread Radim Kubacki 
Remy Maucherat wrote:
Shapira, Yoav wrote:

Howdy,


complete. What's missing is better docs, and lots of tweaks and fixes.


I'd like to help with the docs.  Can you prioritize what docs you think
need work (or need to be written from scratch)?  I actually have tomcat
commit access already, so there should be no delay like with
commons-modeler ;(


Sure. Well, I was thinking writing new docs on setup and run would be 
useful.
It's not only the basics. It should talk about using commons-daemon to 
run on Unix, and other stuff.

Other docs about the new features are welcome also:
- new monitoring features (JMX, how to use MC4J with TC, etc)
Remmy,

recently you wrote that it would be nice to ship with JMX 1.2 + a JSR 
160 implementation if possible. Do you think it will be possible to get 
this from MX4J? Or is it possible to use JMX1.2 RI + JSR160 RI (when it 
will be finalized)?

Radim
- updates for the deployer tweaks and improvements
- etc
I think any useful docs will help, so feel free to contribute whatever 
you'd like ;-)

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

fileupload dependency in build.properties.default

2003-06-12 Thread Radim Kubacki 
Hi,

I suggest to update j-t-5/build.properties.default to refer to 
commons-fileupload RC1 rather than beta-1. The reason for upgrading was 
discussed recently.

# - Commons FileUpload, version 1.0 or later -
commons-fileupload.home=${base.path}/commons-fileupload-1.0-rc1
commons-fileupload.lib=${commons-fileupload.home}
commons-fileupload.jar=${commons-fileupload.lib}/commons-fileupload-1.0-rc1.jar
commons-fileupload.loc=http://www.apache.org/dist/jakarta/commons/fileupload/binaries/commons-fileupload-1.0-rc1.tar.gz
Radim

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: JSP won't work unless have package in taglib .java file

2003-04-06 Thread Radim Kubacki 
David Thielen wrote:
Hi;

If I have a tld object (ie TemplateDesc.java) with no project and place it
in WEB-INF/classes - it won't work. But if I give it a package name and
place it in WEB-INF/classes/package - then it works.
The problem seems to be that with no package it generates the code:
TemplateDesc _jspx_th_tl_TP_0 = (TemplateDesc)
_jspx_tagPool_tl_TP.get(com.windwardreports.TemplateDesc.class);
but with the package it generates:
com.windwardreports.TemplateDesc _jspx_th_tl_TP_0 =
(com.windwardreports.TemplateDesc)
_jspx_tagPool_tl_TP.get(com.windwardreports.TemplateDesc.class);
which makes sense. But why can it find it as part of a package but not with
no package?
Since JDK1.4 the compiler rejects import statements that import a type 
from the unnamed namespace. See 
http://java.sun.com/j2se/1.4/compatibility.html (section 8 of 
incompatibilies).

Simply don't use unnamed namespace.

Radim

thanks - dave




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]