DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2005-08-20 21:31 --- *** Bug 36284 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #14517|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-03-23 15:36 --- Created an attachment (id=14546) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14546action=view) Allow jasper to resolve external entities -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-23 15:36 --- After Bill and Jan review, a new patch to close this BZ -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-19 10:36 --- Well if it works, I'm happy with this patch. Will try it Monday. Thanks William -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-19 11:09 --- Couldn't wait monday. Ok it seems to works. Resolver get a systemId : jndi:/localhost/webappname/WEB-INF/app.xml And it works. Only got in System.out : 19 mars 2005 11:06:49 org.apache.jasper.xmlparser.MyEntityResolver resolveEntity GRAVE: PUBLIC ID invalide: null 19 mars 2005 11:06:57 org.apache.jasper.xmlparser.MyEntityResolver resolveEntity GRAVE: PUBLIC ID invalide: null 19 mars 2005 11:06:59 org.apache.jasper.xmlparser.MyEntityResolver resolveEntity GRAVE: PUBLIC ID invalide: null 19 mars 2005 11:07:00 org.apache.jasper.xmlparser.MyEntityResolver resolveEntity GRAVE: PUBLIC ID invalide: null 19 mars 2005 11:07:02 org.apache.jasper.xmlparser.MyEntityResolver resolveEntity GRAVE: PUBLIC ID invalide: null So a simpler patch could be commited :) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-18 14:47 --- Created an attachment (id=14517) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=14517action=view) a patch to allow Jasper to resolve external entities located in WEBAPP -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-18 16:05 --- if (systemId.startsWith(file:///WEB-INF/)) return new InputSource(ctxt.getResourceAsStream(systemId.substring(7))); - -1 No surprise here ... -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-18 16:15 --- It's a trick : if (systemId.startsWith(file:///WEB-INF/)) return new InputSource(ctxt.getResourceAsStream(systemId.substring(7))); XML parser have a pseudo root origine set to /WEB-INF/ and as such you get the systemId filed with 'file:///WEB-INF/whatever.xml' when you have defined a ENTITY what SYSTEM whatever.xml With the substring 7 we remove the file: and as such get /WEB-INF/whatever.xml from ServletContext via getResourceAsStream. So it should works EVEN if the webapp is not file based. I do that to respect WHAT YOU REQUIRED, ie no InputSource from a File, just from a resource. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 --- Additional Comments From [EMAIL PROTECTED] 2005-03-18 20:17 --- It should be enough to do (in JspConfig): URL uri = ctcx.getResource(WEB_XML); InputSource ip = new InputSource(uri.openStream()); ip.setSystemId(uri.toExternalForm()); and leave the EntityResolver alone. Between Xerces and o.a.naming they can work out the relative Entity references. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:00 --- As promised ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:02 --- Reread xml spec, nothing prevent us to use external entities like this. Also external entities are invalid when outside webapp, it's not the case here. You should read : My web.xml is : ?xml version=1.0 encoding=ISO-8859-1? !DOCTYPE web-app PUBLIC -//Sun Microsystems, Inc.//DTD Web Application 2.3//EN http://java.sun.com/dtd/web-app_2_3.dtd; [ !ENTITY base SYSTEM base.xml ] web-app ... base; /web-app -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:04 --- Webapps are not necessarily filesystem based. As a result, that kind of little tricks are not portable, and cannot be supported. As you know, I am very efficient at marking reports invalid ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34034.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34034
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID |
--- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:16 ---
Actually, I just saw it maybe can work even when not filesystem based:
if (altDDName != null) {
url = new File(altDDName).toURL();
} else {
url = servletContext.getResource(
Constants.ApplicationWebXml);
}
if( url!=null ) {
InputSource is = new InputSource(url.toExternalForm());
is.setByteStream(stream);
I still really don't care about the issue, but my big issue with this might go
away.
This might teach people that it's not a good idea to bug me about something I
don't care about all morning long (some people you might not know about may have
gotten the same idea at the same time) ;)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Remy, let be serious. If the definition is invalid for Jasper, you should be consistant and do the same at web.xml reading/parsing time. Also when you have a webapp with more than 150 servlets, produced by 2 or 3 teams, and with the mapping requirement, you SHOULD use this kind of ENTITY inclusion to make life a little simpler for developpers. Do you hate developpers ? or Team working ? If the SYSTEM entity tag is invalid, what could we use instead ? PUBLIC ? Sorry but this one is a show stopper... On Wed, 16 Mar 2005 15:04:26 +0100, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:04 --- Webapps are not necessarily filesystem based. As a result, that kind of little tricks are not portable, and cannot be supported. As you know, I am very efficient at marking reports invalid ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You reported the bug, or are watching the reporter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Remy you promised to close it and I promised you to reopen. The bug is for me a showstopper and if it's not resolved, I'll vote -1 to future Tomcat 5.5 release. On Wed, 16 Mar 2005 15:00:15 +0100, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34034. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34034 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2005-03-16 15:00 --- As promised ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Henri Gomez wrote: Remy, let be serious. If the definition is invalid for Jasper, you should be consistant and do the same at web.xml reading/parsing time. Also when you have a webapp with more than 150 servlets, produced by 2 or 3 teams, and with the mapping requirement, you SHOULD use this kind of ENTITY inclusion to make life a little simpler for developpers. Do you hate developpers ? or Team working ? If the SYSTEM entity tag is invalid, what could we use instead ? PUBLIC ? Sorry but this one is a show stopper... Show stopper ? Get real, nobody but you cares. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Henri Gomez wrote: Remy you promised to close it and I promised you to reopen. The bug is for me a showstopper and if it's not resolved, I'll vote -1 to future Tomcat 5.5 release. I did look at the code in ContextConfig, and had already reopend the report, since it seemed to indicate that it would work using URLs. My mistake. I'm assuming this. If it doesn't work with anything but the filesystem, then I am -1 for the feature. That being said, I will make no effort to fix it. I'm sure people who are interested in the feature will help fix it ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
So what about ? If I provide a Fix to Jasper to make it works like ContextConfig does, will it be -1 ? On Wed, 16 Mar 2005 15:47:23 +0100, Remy Maucherat [EMAIL PROTECTED] wrote: Henri Gomez wrote: Remy you promised to close it and I promised you to reopen. The bug is for me a showstopper and if it's not resolved, I'll vote -1 to future Tomcat 5.5 release. I did look at the code in ContextConfig, and had already reopend the report, since it seemed to indicate that it would work using URLs. My mistake. I'm assuming this. If it doesn't work with anything but the filesystem, then I am -1 for the feature. That being said, I will make no effort to fix it. I'm sure people who are interested in the feature will help fix it ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Henri Gomez wrote: So what about ? If I provide a Fix to Jasper to make it works like ContextConfig does, will it be -1 ? If it doesn't use filesystem stuff (like ContextConfig), and it works (that helps), I will of course not -1 any changes :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 34034] - Jasper didn't respect external entities
Happy to see you more positive ;) I'll take a carefull look around this Jasper to avoid broking everything but I feel I should add a specific or configurable EntityResolver in such case. On Wed, 16 Mar 2005 17:07:06 +0100, Remy Maucherat [EMAIL PROTECTED] wrote: Henri Gomez wrote: So what about ? If I provide a Fix to Jasper to make it works like ContextConfig does, will it be -1 ? If it doesn't use filesystem stuff (like ContextConfig), and it works (that helps), I will of course not -1 any changes :) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
