Re: [BUG PATCH] for Kaffe VM

[Takashi Okamoto]

Hi, Tomcat developers.

  I found problem that tomcat 3.2-b8 doesn't work on Kaffe VM.
  (probably 3.2 final is same)
  Error occurs at read() method in java.io.BufferedInputStream.

I had a contact to Edouard  who is one of Kaffe VM developer.
He said Tomcat should be fixed.

I forward him mail.
Please fix this problem.

If tomcat don't work on Kaffe VM,bTomcat can't be included Debian main
package/b
because JDK and JRE isn't free software.


Regards.
- mail form Edouard --
Takashi Okamoto wrote:

  Could you test the following changes:
 
  In methods read() and skip() of java.io.BufferedInputStream, change test
  pos == buf.length
  by
  pos == buf.length || pos = count
 
  and say me if it work.

 It's good. Tomcat worked.

Well, I think others methods may not work too (available, mark, reset).

As BufferedInputStream constructor initialize pos, count and markpos, I
think it's a org.apache.tomcat.util.RecycleBufferedInputStream bug.

If setInputStream() and reclycle() do the RightThinkTM, I hope that
Tomcat will work with unmodified Kaffe and GNU Classpath
BufferedInputStream class.

Try the following changes and use unmodified BufferedInputStream.  If
Tomcat then work, could you fill a bug report to Tomcat team ?

public void setInputStream( InputStream is ) {
this.in = is;
this.pos = this.count = 0;
this.markpos = -1;
}

public void recycle() {
this.in = null;
this.pos = this.count = 0;
this.markpos = -1;
}

Hope this help.
--
Edouard G. Parmelan
http://egp.free.fr

-
Takashi Okamoto

Re: [BUG? PATCH] for Kaffe VM

[Takashi Okamoto]

 I found problem that tomcat 3.2-b8 doesn't work on Kaffe VM.
 (probably 3.2 final is same) 
 Error occurs at read() method in java.io.BufferedInputStream.

 # Maybe it's Kaffe VM's problem.(which has problem?)

Kaffe developer resolved this problem in Kaffe VM.
We won't need following patch for next Kaffe release.

*** RecycleBufferedInputStream.java.org Sat Dec  9 02:35:35 2000
--- RecycleBufferedInputStream.java Sat Dec  9 02:35:57 2000
***
*** 73,83 
--- 73,85 
  public void setInputStream( InputStream is ) {
   this.count=0;
   this.in=is;
+  this.pos=0;
  }
  
  public void recycle() {
   this.in=null;
   this.count=0;
+  this.pos=0;
  }
---
Takashi Okamoto