Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Brian Olsen
Remy Maucherat wrote: Brian Olsen wrote: Hey Guys, I just made a proposed patch for the enhancement request I made regarding the SIP Servlet API http://issues.apache.org/bugzilla/show_bug.cgi?id=21169 It adds a new interface org.apache.catalina.ServletSession that contains the methods that

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Bill Barker
- Original Message - From: Brian Olsen [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 30, 2003 1:31 AM Subject: Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169) Remy Maucherat wrote

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Yoav Shapira
: Monday, June 30, 2003 1:31 AM Subject: Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169) Remy Maucherat wrote: Brian Olsen wrote: Hey Guys, I just made a proposed patch for the enhancement

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Remy Maucherat
Bill Barker wrote: Like Remy, I'm -0 on the patch. As I read Remy's post, this means that neither of us will actually veto it if some other developer decides to post it. However, neither of us consider it to be a-good-idea, so we will be looking for implementation holes to veto ;-). The internal

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Brian Olsen
Bill Barker wrote: - Original Message - From: Brian Olsen [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 30, 2003 1:31 AM Subject: Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169) Remy

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Brian Olsen
Remy Maucherat wrote: Bill Barker wrote: Like Remy, I'm -0 on the patch. As I read Remy's post, this means that neither of us will actually veto it if some other developer decides to post it. However, neither of us consider it to be a-good-idea, so we will be looking for implementation holes

Re: [PATCH] Change getSession() in org.apache.catalina.Session from HttpSession to a more general interface (enhancement request 21169)

2003-06-30 Thread Remy Maucherat
Brian Olsen wrote: Remy Maucherat wrote: It's not that I do think it's a bad idea, it's just I think there are other problems. I would be willing to consider including the patch (but I need to look into possible side effects first). What could those side effects be??? You're changing the core