Re: [Patch] Coyote losing parameters across form login (wasRe: Connectorissues)

2003-04-04 Thread Jeff Tulley
One more try, all files as .txt  What is the best way to send a .zip
file?
Actually, I've attached the file that was in the zip as
AddParametersTest.java  It should go in
j-t-c/util/test/org/apache/tomcat/util/http   Nothing from /test down
currently exists in the util dir.

It looks like my previous submissions on this list also did not show
up.  I should have checked more carefully.

I've also attached my patch for the minor type in SoTask.java

Sorry for the mess.

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com

>>> [EMAIL PROTECTED] 4/4/03 12:17:48 PM >>>
Jeff Tulley wrote:
> Which?  All of them?  I had 3 attachments with the extension ".patch"
(I
> could rename to .txt, though .patch has worked in the past I
thought). 
> And, 1 zip file that I renamed to test.zip.txt
> 
> Please let me know which if any were visible, and the best way to
send
> a zip file.

The .zip is not valid, and the 3 other attachements are not there.

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED] 
For additional commands, e-mail: [EMAIL PROTECTED] 

Index: Request.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Request.java,v
retrieving revision 1.15
diff -u -r1.15 Request.java
--- Request.java19 Sep 2002 06:39:43 -  1.15
+++ Request.java3 Apr 2003 17:28:56 -
@@ -385,6 +385,9 @@
 public Parameters getParameters() {
return parameters;
 }
+   public void addParameter(String name, String[] values) {
+  parameters.addParameterValues(name, values);
+   }
 
 
 //  Other attributes 

Index: Parameters.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/Parameters.java,v
retrieving revision 1.8
diff -u -r1.8 Parameters.java
--- Parameters.java 29 Jun 2002 02:15:02 -  1.8
+++ Parameters.java 3 Apr 2003 17:30:39 -
@@ -336,6 +336,26 @@
paramHashStringArray.put(key, values);
 }
 
+   public void addParameterValues( String key, String[] newValues) {
+  if( key==null ) return;
+  String values[];
+  if (paramHashStringArray.containsKey(key)) {
+ String oldValues[] = (String[])paramHashStringArray.
+ get(key);
+ values = new String[oldValues.length + newValues.length];
+ for (int i = 0; i < oldValues.length; i++) {
+values[i] = oldValues[i];
+ }
+ for (int i = 0; i < newValues.length; i++) {
+values[i+ oldValues.length] = newValues[i];
+ }
+  } else {
+ values = newValues;
+  }
+  
+  paramHashStringArray.put(key, values);
+   }
+
 public void setURLDecoder( UDecoder u ) {
urlDec=u;
 }


Index: CoyoteRequest.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRequest.java,v
retrieving revision 1.28
diff -u -r1.28 CoyoteRequest.java
--- CoyoteRequest.java  24 Nov 2002 11:56:15 -  1.28
+++ CoyoteRequest.java  3 Apr 2003 17:28:09 -
@@ -1262,7 +1262,7 @@
  * @param values Corresponding values for this request parameter
  */
 public void addParameter(String name, String values[]) {
-// Not used
+coyoteRequest.addParameter(name, values);
 }
 

Index: SoTask.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-connectors/jk/jkant/java/org/apache/jk/ant/SoTask.java,v
retrieving revision 1.23
diff -u -r1.23 SoTask.java
--- SoTask.java 9 Jun 2002 00:10:02 -   1.23
+++ SoTask.java 3 Apr 2003 00:19:44 -
@@ -364,7 +364,7 @@
  * (XXX including extension - this should be automatically added )
  */
 public void setModule(String modName) {
-this.module = module;
+this.module = modName;
 }
 
 // XXX Add specific code for Netware, Windows and platforms where libtool



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Patch] Coyote losing parameters across form login (wasRe: Connectorissues)

2003-04-04 Thread Jeff Tulley
Which?  All of them?  I had 3 attachments with the extension ".patch" (I
could rename to .txt, though .patch has worked in the past I thought). 
And, 1 zip file that I renamed to test.zip.txt

Please let me know which if any were visible, and the best way to send
a zip file.

Jeff Tulley  ([EMAIL PROTECTED])
(801)861-5322
Novell, Inc., The Leading Provider of Net Business Solutions
http://www.novell.com

>>> [EMAIL PROTECTED] 4/4/03 9:27:05 AM >>>
Jeff Tulley wrote:
> here is the code, please review
> 3 of them are patches for existing source code.  test.zip (.txt, I
> couldn't remember if the mailing list strips off zip files) is a new
> junit TestCase to test my stuff in Parameters.java.  I propose that
be
> put in j-t-c/util/test, unless there is a better place.  I don't know
if
> there is a better way to submit a new directory via CVS since I
cannot
> "diff -u" it.
> 
> CoyoteRequest.java and Request.java fixes are very straightforward,
> just doing the same sort of thing that is done in the rest of the
code. 
> Parameters.java is where I took an already existing (private)
method,
> made a copy of it, renamed and made the copy public, and then adapted
it
> to work with multi-valued parameters.
> 
> This seems to do the job correctly.

The attachement doesn't work for me.

Remy


-
To unsubscribe, e-mail: [EMAIL PROTECTED] 
For additional commands, e-mail: [EMAIL PROTECTED] 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]